berkshelf 5.5.0 → 5.6.0

data/spec/unit/berkshelf/config_spec.rb

@@ -1,30 +1,30 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::Config do
-  describe '::file' do
-    context 'when the file does not exist' do
+  describe "::file" do
+    context "when the file does not exist" do
       before { allow(File).to receive(:exists?).and_return(false) }
 
-      it 'is nil' do
+      it "is nil" do
         expect(Berkshelf::Config.file).to be_nil
       end
     end
   end
 
-  describe '::instance' do
-    it 'should be a Berkshelf::Config' do
+  describe "::instance" do
+    it "should be a Berkshelf::Config" do
       expect(Berkshelf::Config.instance).to be_an_instance_of(Berkshelf::Config)
     end
 
-    context 'attributes' do
-      it 'should have a default API timeout' do
-        expect(Berkshelf::Config.instance.api.timeout).to eq('30')
+    context "attributes" do
+      it "should have a default API timeout" do
+        expect(Berkshelf::Config.instance.api.timeout).to eq("30")
       end
     end
   end
 
-  describe '::path' do
-    it 'is a string' do
+  describe "::path" do
+    it "is a string" do
       expect(Berkshelf::Config.path).to be_a(String)
     end
 
@@ -38,8 +38,8 @@ describe Berkshelf::Config do
 
     context "when ENV['BERKSHELF_CONFIG'] is used" do
       before do
-        allow(ENV).to receive(:[]).with('BERKSHELF_CONFIG').and_return('/tmp/config.json')
-        allow(File).to receive(:exists?).with('/tmp/config.json').and_return(true)
+        allow(ENV).to receive(:[]).with("BERKSHELF_CONFIG").and_return("/tmp/config.json")
+        allow(File).to receive(:exists?).with("/tmp/config.json").and_return(true)
       end
 
       it "points to a location within it" do

data/spec/unit/berkshelf/cookbook_generator_spec.rb

@@ -1,13 +1,13 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::CookbookGenerator do
-  let(:name)             { 'sparkle_motion' }
-  let(:license)          { 'reserved' }
-  let(:maintainer)       { 'Berkshelf Core' }
-  let(:maintainer_email) { 'core@berkshelf.com' }
+  let(:name)             { "sparkle_motion" }
+  let(:license)          { "reserved" }
+  let(:maintainer)       { "Berkshelf Core" }
+  let(:maintainer_email) { "core@berkshelf.com" }
 
   let(:target) { tmp_path.join(name) }
-  let(:kitchen_generator) { double('kitchen-generator', invoke_all: nil) }
+  let(:kitchen_generator) { double("kitchen-generator", invoke_all: nil) }
 
   before do
     allow(Kitchen::Generator::Init)
@@ -16,66 +16,66 @@ describe Berkshelf::CookbookGenerator do
       .and_return(kitchen_generator)
   end
 
-  context 'with default options' do
+  context "with default options" do
     before do
       capture(:stdout) do
         Berkshelf::CookbookGenerator.new([target, name],
           license:          license,
           maintainer:       maintainer,
-          maintainer_email: maintainer_email,
+          maintainer_email: maintainer_email
         ).invoke_all
       end
     end
 
     it "generates a new cookbook" do
       expect(target).to have_structure {
-        directory 'attributes'
-        directory 'files' do
-          directory 'default'
+        directory "attributes"
+        directory "files" do
+          directory "default"
         end
-        directory 'libraries'
-        directory 'providers'
-        directory 'recipes' do
-          file 'default.rb' do
-            contains '# Cookbook Name:: sparkle_motion'
-            contains '# Recipe:: default'
+        directory "libraries"
+        directory "providers"
+        directory "recipes" do
+          file "default.rb" do
+            contains "# Cookbook Name:: sparkle_motion"
+            contains "# Recipe:: default"
             contains "# Copyright (C) #{Time.now.year} Berkshelf Core"
-            contains '# All rights reserved - Do Not Redistribute'
+            contains "# All rights reserved - Do Not Redistribute"
           end
         end
-        directory 'resources'
-        directory 'templates' do
-          directory 'default'
+        directory "resources"
+        directory "templates" do
+          directory "default"
         end
-        file 'LICENSE' do
+        file "LICENSE" do
           contains "Copyright (C) #{Time.now.year} Berkshelf Core"
-          contains 'All rights reserved - Do Not Redistribute'
+          contains "All rights reserved - Do Not Redistribute"
         end
-        file 'README.md' do
-          contains '# sparkle_motion-cookbook'
-          contains '### sparkle_motion::default'
+        file "README.md" do
+          contains "# sparkle_motion-cookbook"
+          contains "### sparkle_motion::default"
           contains "    <td><tt>['sparkle_motion']['bacon']</tt></td>"
           contains "Include `sparkle_motion` in your node's `run_list`:"
           contains '    "recipe[sparkle_motion::default]"'
-          contains 'Author:: Berkshelf Core (<core@berkshelf.com>)'
+          contains "Author:: Berkshelf Core (<core@berkshelf.com>)"
         end
-        file 'CHANGELOG.md' do
-          contains '# 0.1.0'
+        file "CHANGELOG.md" do
+          contains "# 0.1.0"
           contains "Initial release of sparkle_motion"
         end
-        file 'metadata.rb' do
+        file "metadata.rb" do
           contains "name             'sparkle_motion'"
           contains "maintainer       'Berkshelf Core'"
           contains "maintainer_email 'core@berkshelf.com'"
           contains "license          'All rights reserved'"
           contains "description      'Installs/Configures sparkle_motion'"
         end
-        file 'Berksfile' do
+        file "Berksfile" do
           contains 'source "https://supermarket.chef.io"'
-          contains 'metadata'
+          contains "metadata"
         end
-        file 'Gemfile'
-        file 'chefignore'
+        file "Gemfile"
+        file "chefignore"
       }
     end
   end
@@ -83,15 +83,15 @@ describe Berkshelf::CookbookGenerator do
   context "given a 'maintainer_email' option" do
     before do
       allow(Kitchen::Generator::Init).to receive(:new).with(any_args()).and_return(kitchen_generator)
-      capture(:stdout) {
-        Berkshelf::CookbookGenerator.new([target, name], maintainer_email: 'jamie@vialstudios.com').invoke_all
-      }
+      capture(:stdout) do
+        Berkshelf::CookbookGenerator.new([target, name], maintainer_email: "jamie@vialstudios.com").invoke_all
+      end
     end
 
     it "generates a metadata.rb with the 'maintainer_email' value set" do
       email = email
       expect(target).to have_structure {
-        file 'metadata.rb' do
+        file "metadata.rb" do
           contains "maintainer_email 'jamie@vialstudios.com'"
         end
       }
@@ -100,7 +100,7 @@ describe Berkshelf::CookbookGenerator do
 
   context "given an invalid option for :license" do
     subject(:run) do
-      capture(:stdout) { described_class.new([target, name], license: 'not-there').invoke_all }
+      capture(:stdout) { described_class.new([target, name], license: "not-there").invoke_all }
     end
 
     it "raises a LicenseNotFound error" do

data/spec/unit/berkshelf/cookbook_store_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::CookbookStore do
   describe "ClassMethods" do
@@ -6,8 +6,8 @@ describe Berkshelf::CookbookStore do
     describe "::import"
 
     describe "::new" do
-      it 'creates the storage_path' do
-        storage_path = tmp_path.join('random_storage')
+      it "creates the storage_path" do
+        storage_path = tmp_path.join("random_storage")
         Berkshelf::CookbookStore.new(storage_path)
 
         expect(storage_path).to exist
@@ -17,103 +17,103 @@ describe Berkshelf::CookbookStore do
 
   subject { Berkshelf::CookbookStore.new(tmp_path.join("cbstore_rspec")) }
 
-  describe '#cookbook_path' do
-    let(:cookbook_name) { 'nginx' }
-    let(:cookbook_version) { '0.101.2' }
+  describe "#cookbook_path" do
+    let(:cookbook_name) { "nginx" }
+    let(:cookbook_version) { "0.101.2" }
     let(:path) { subject.cookbook_path(cookbook_name, cookbook_version) }
 
-    it 'returns an instance of Pathname' do
+    it "returns an instance of Pathname" do
       expect(path).to be_a(Pathname)
     end
 
-    it 'returns a the filepath within the storage path' do
+    it "returns a the filepath within the storage path" do
       expect(path.dirname).to eq(subject.storage_path)
     end
 
-    it 'returns a basename containing the cookbook name and version separated by a dash' do
+    it "returns a basename containing the cookbook name and version separated by a dash" do
       expect(path.basename.to_s).to eq("#{cookbook_name}-#{cookbook_version}")
     end
   end
 
-  describe '#satisfy' do
-    let(:name) { 'nginx' }
-    let(:version) { '0.101.4' }
-    let(:constraint) { Semverse::Constraint.new('~> 0.101.2') }
-    let(:cached_one) { double('cached-one', name: name, version: Semverse::Version.new(version)) }
-    let(:cached_two) { double('cached-two', name: 'mysql', version: Semverse::Version.new('1.2.6')) }
+  describe "#satisfy" do
+    let(:name) { "nginx" }
+    let(:version) { "0.101.4" }
+    let(:constraint) { Semverse::Constraint.new("~> 0.101.2") }
+    let(:cached_one) { double("cached-one", name: name, version: Semverse::Version.new(version)) }
+    let(:cached_two) { double("cached-two", name: "mysql", version: Semverse::Version.new("1.2.6")) }
 
     before { allow(subject).to receive(:cookbooks).and_return([cached_one, cached_two]) }
 
-    it 'gets and returns the the CachedCookbook best matching the name and constraint' do
+    it "gets and returns the the CachedCookbook best matching the name and constraint" do
       expect(subject).to receive(:cookbook).with(name, version).and_return(cached_one)
       result = subject.satisfy(name, constraint)
 
       expect(result).to eq(cached_one)
     end
 
-    context 'when there are no cookbooks in the cookbook store' do
+    context "when there are no cookbooks in the cookbook store" do
       before { allow(subject).to receive(:cookbooks).and_return([]) }
 
-      it 'returns nil' do
+      it "returns nil" do
         result = subject.satisfy(name, constraint)
         expect(result).to be_nil
       end
     end
 
-    context 'when there is no matching cookbook for the given name and constraint' do
-      let(:version) { Semverse::Version.new('1.0.0') }
-      let(:constraint) { Semverse::Constraint.new('= 0.1.0') }
+    context "when there is no matching cookbook for the given name and constraint" do
+      let(:version) { Semverse::Version.new("1.0.0") }
+      let(:constraint) { Semverse::Constraint.new("= 0.1.0") }
 
-      before { allow(subject).to receive(:cookbooks).and_return([ double('badcache', name: 'none', version: version) ]) }
+      before { allow(subject).to receive(:cookbooks).and_return([ double("badcache", name: "none", version: version) ]) }
 
-      it 'returns nil if there is no matching cookbook for the name and constraint' do
+      it "returns nil if there is no matching cookbook for the name and constraint" do
         result = subject.satisfy(name, constraint)
         expect(result).to be_nil
       end
     end
   end
 
-  describe '#cookbook' do
-    subject { Berkshelf::CookbookStore.new(fixtures_path.join('cookbooks')) }
+  describe "#cookbook" do
+    subject { Berkshelf::CookbookStore.new(fixtures_path.join("cookbooks")) }
 
-    it 'returns a CachedCookbook if the specified cookbook version exists' do
-      expect(subject.cookbook('example_cookbook', '0.5.0')).to be_a(Berkshelf::CachedCookbook)
+    it "returns a CachedCookbook if the specified cookbook version exists" do
+      expect(subject.cookbook("example_cookbook", "0.5.0")).to be_a(Berkshelf::CachedCookbook)
     end
 
-    it 'returns nil if the specified cookbook version does not exist' do
-      expect(subject.cookbook('doesnotexist', '0.1.0')).to be_nil
+    it "returns nil if the specified cookbook version does not exist" do
+      expect(subject.cookbook("doesnotexist", "0.1.0")).to be_nil
     end
   end
 
-  describe '#cookbooks' do
+  describe "#cookbooks" do
     before do
-      generate_cookbook(subject.storage_path, 'nginx', '0.101.2')
-      generate_cookbook(subject.storage_path, 'mysql', '1.2.6')
+      generate_cookbook(subject.storage_path, "nginx", "0.101.2")
+      generate_cookbook(subject.storage_path, "mysql", "1.2.6")
     end
 
-    it 'returns a list of CachedCookbooks' do
+    it "returns a list of CachedCookbooks" do
       subject.cookbooks.each do |cookbook|
         expect(cookbook).to be_a(Berkshelf::CachedCookbook)
       end
     end
 
-    it 'contains a CachedCookbook for every cookbook in the storage path' do
+    it "contains a CachedCookbook for every cookbook in the storage path" do
       expect(subject.cookbooks.size).to eq(2)
     end
 
-    context 'given a value for the filter parameter' do
-      it 'returns only the CachedCookbooks whose name match the filter' do
-        expect(subject.cookbooks('mysql').size).to eq(1)
+    context "given a value for the filter parameter" do
+      it "returns only the CachedCookbooks whose name match the filter" do
+        expect(subject.cookbooks("mysql").size).to eq(1)
       end
     end
 
-    context 'when a there is a cookbook without a name attribute' do
+    context "when a there is a cookbook without a name attribute" do
       before do
-        generate_cookbook(subject.storage_path, 'foo', '3.0.1', without_name: true)
+        generate_cookbook(subject.storage_path, "foo", "3.0.1", without_name: true)
       end
 
-      it 'omits the broken cookbook' do
-        expect(subject.cookbooks('foo')).to be_empty
+      it "omits the broken cookbook" do
+        expect(subject.cookbooks("foo")).to be_empty
       end
     end
   end

data/spec/unit/berkshelf/core_ext/file_utils_spec.rb

@@ -1,9 +1,9 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe FileUtils do
-  describe '#mv' do
-    let(:src) { 'src' }
-    let(:dest) { 'dest' }
+  describe "#mv" do
+    let(:src) { "src" }
+    let(:dest) { "dest" }
     let(:options) { {} }
 
     it "uses mv by default" do
@@ -11,8 +11,7 @@ describe FileUtils do
       FileUtils.mv(src, dest, options)
     end
 
-
-    it 'replaces mv with cp_r and rm_rf' do
+    it "replaces mv with cp_r and rm_rf" do
       expect(FileUtils).to receive(:cp_r).with(src, dest, options)
       expect(FileUtils).to receive(:rm_rf).with(src)
 

data/spec/unit/berkshelf/core_ext/pathname_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Pathname do
   describe "#cookbook?" do

data/spec/unit/berkshelf/dependency_spec.rb

@@ -1,88 +1,88 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::Dependency do
-  let(:cookbook_name) { 'nginx' }
-  let(:berksfile) { double('berksfile', filepath: fixtures_path.join('Berksfile').to_s) }
+  let(:cookbook_name) { "nginx" }
+  let(:berksfile) { double("berksfile", filepath: fixtures_path.join("Berksfile").to_s) }
 
   describe "ClassMethods" do
     describe "::new" do
       let(:source) { described_class.new(berksfile, cookbook_name) }
 
-      context 'given no location key (i.e. :git, :path, :site)' do
-        it 'sets a nil valie for location' do
+      context "given no location key (i.e. :git, :path, :site)" do
+        it "sets a nil valie for location" do
           expect(source.location).to be_nil
         end
       end
 
-      context 'given no value for :locked_version' do
-        it 'returns a wildcard match for any version' do
+      context "given no value for :locked_version" do
+        it "returns a wildcard match for any version" do
           expect(source.locked_version).to be_nil
         end
       end
 
-      context 'given no value for :constraint' do
-        it 'returns a wildcard match for any version' do
-          expect(source.version_constraint.to_s).to eq('>= 0.0.0')
+      context "given no value for :constraint" do
+        it "returns a wildcard match for any version" do
+          expect(source.version_constraint.to_s).to eq(">= 0.0.0")
         end
       end
 
-      context 'given a value for :constraint' do
-        let(:source) { described_class.new(berksfile, cookbook_name, constraint: '~> 1.0.84') }
+      context "given a value for :constraint" do
+        let(:source) { described_class.new(berksfile, cookbook_name, constraint: "~> 1.0.84") }
 
-        it 'returns a Semverse::Constraint for the given version for version_constraint' do
-          expect(source.version_constraint.to_s).to eq('~> 1.0.84')
+        it "returns a Semverse::Constraint for the given version for version_constraint" do
+          expect(source.version_constraint.to_s).to eq("~> 1.0.84")
         end
       end
 
-      context 'given a location key :git' do
-        let(:url) { 'git://url_to_git' }
+      context "given a location key :git" do
+        let(:url) { "git://url_to_git" }
         let(:source) { described_class.new(berksfile, cookbook_name, git: url) }
 
-        it 'initializes a GitLocation for location' do
+        it "initializes a GitLocation for location" do
           expect(source.location).to be_a(Berkshelf::GitLocation)
         end
 
-        it 'points to the given Git URL' do
+        it "points to the given Git URL" do
           expect(source.location.uri).to eq(url)
         end
       end
 
-      context 'given a location key :path' do
-        context 'given a value for path that contains a cookbook' do
-          let(:path) { fixtures_path.join('cookbooks', 'example_cookbook').to_s }
+      context "given a location key :path" do
+        context "given a value for path that contains a cookbook" do
+          let(:path) { fixtures_path.join("cookbooks", "example_cookbook").to_s }
           let(:location) { described_class.new(berksfile, cookbook_name, path: path).location }
 
-          it 'initializes a PathLocation for location' do
+          it "initializes a PathLocation for location" do
             expect(location).to be_a(Berkshelf::PathLocation)
           end
 
-          it 'points to the specified path' do
+          it "points to the specified path" do
             expect(location.options[:path]).to eq(path)
           end
         end
 
-        context 'given a group option containing a single group' do
+        context "given a group option containing a single group" do
           let(:group) { :production }
           let(:source) { described_class.new(berksfile, cookbook_name, group: group) }
 
-          it 'assigns the single group to the groups attribute' do
+          it "assigns the single group to the groups attribute" do
             expect(source.groups).to include(group)
           end
         end
 
-        context 'given a group option containing an array of groups' do
+        context "given a group option containing an array of groups" do
           let(:groups) { [ :development, :test ] }
           let(:source) { described_class.new(berksfile, cookbook_name, group: groups) }
 
-          it 'assigns all the groups to the group attribute' do
+          it "assigns all the groups to the group attribute" do
             expect(source.groups).to eq(groups)
           end
         end
 
-        context 'given no group option' do
+        context "given no group option" do
           let(:source) { described_class.new(berksfile, cookbook_name) }
 
-          it 'has the default group assigned' do
+          it "has the default group assigned" do
             expect(source.groups).to include(:default)
           end
         end
@@ -92,26 +92,26 @@ describe Berkshelf::Dependency do
 
   subject { described_class.new(berksfile, cookbook_name) }
 
-  describe '#add_group' do
-    it 'stores strings as symbols' do
-      subject.add_group 'foo'
+  describe "#add_group" do
+    it "stores strings as symbols" do
+      subject.add_group "foo"
       expect(subject.groups).to eq([:default, :foo])
     end
 
-    it 'does not store duplicate groups' do
-      subject.add_group 'bar'
-      subject.add_group 'bar'
+    it "does not store duplicate groups" do
+      subject.add_group "bar"
+      subject.add_group "bar"
       subject.add_group :bar
       expect(subject.groups).to eq([:default, :bar])
     end
 
-    it 'adds multiple groups' do
-      subject.add_group 'baz', 'quux'
+    it "adds multiple groups" do
+      subject.add_group "baz", "quux"
       expect(subject.groups).to eq([:default, :baz, :quux])
     end
 
-    it 'handles multiple groups as an array' do
-      subject.add_group ['baz', 'quux']
+    it "handles multiple groups as an array" do
+      subject.add_group %w{baz quux}
       expect(subject.groups).to eq([:default, :baz, :quux])
     end
   end
@@ -119,13 +119,13 @@ describe Berkshelf::Dependency do
   describe "#cached_cookbook"
   describe "#download"
 
-  describe '#installed?' do
-    it 'returns true if self.cached_cookbook is not nil' do
-      allow(subject).to receive(:cached_cookbook) { double('cb') }
+  describe "#installed?" do
+    it "returns true if self.cached_cookbook is not nil" do
+      allow(subject).to receive(:cached_cookbook) { double("cb") }
       expect(subject.installed?).to be(true)
     end
 
-    it 'returns false if self.cached_cookbook is nil' do
+    it "returns false if self.cached_cookbook is nil" do
       allow(subject).to receive(:cached_cookbook) { nil }
       expect(subject.installed?).to be(false)
     end