berkshelf 5.5.0 → 5.6.0

data/spec/unit/berkshelf/downloader_spec.rb

@@ -1,11 +1,11 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Berkshelf
   describe Downloader do
     let(:berksfile) do
       double(Berksfile,
         lockfile: lockfile,
-        dependencies: [],
+        dependencies: []
       )
     end
 
@@ -16,7 +16,7 @@ module Berkshelf
     end
 
     let(:graph) { double(Lockfile::Graph, locks: {}) }
-    let(:self_signed_crt_path) { File.join(BERKS_SPEC_DATA, 'trusted_certs') }
+    let(:self_signed_crt_path) { File.join(BERKS_SPEC_DATA, "trusted_certs") }
     let(:self_signed_crt) { OpenSSL::X509::Certificate.new(IO.read("#{self_signed_crt_path}/example.crt")) }
     let(:cert_store) { OpenSSL::X509::Store.new.add_cert(self_signed_crt) }
     let(:ssl_policy) { double(SSLPolicy, store: cert_store) }
@@ -28,9 +28,9 @@ module Berkshelf
     end
 
     describe "#try_download" do
-      let(:remote_cookbook) { double('remote-cookbook') }
+      let(:remote_cookbook) { double("remote-cookbook") }
       let(:source) do
-        source = double('source')
+        source = double("source")
         allow(source).to receive(:cookbook) { remote_cookbook }
         source
       end
@@ -40,7 +40,7 @@ module Berkshelf
       it "supports the 'opscode' location type" do
         allow(remote_cookbook).to receive(:location_type) { :opscode }
         allow(remote_cookbook).to receive(:location_path) { "http://api.opscode.com" }
-        rest = double('community-rest')
+        rest = double("community-rest")
         expect(CommunityREST).to receive(:new).with("http://api.opscode.com") { rest }
         expect(rest).to receive(:download).with(name, version)
         subject.try_download(source, name, version)
@@ -49,32 +49,32 @@ module Berkshelf
       it "supports the 'supermarket' location type" do
         allow(remote_cookbook).to receive(:location_type) { :supermarket }
         allow(remote_cookbook).to receive(:location_path) { "http://api.supermarket.com" }
-        rest = double('community-rest')
+        rest = double("community-rest")
         expect(CommunityREST).to receive(:new).with("http://api.supermarket.com") { rest }
         expect(rest).to receive(:download).with(name, version)
         subject.try_download(source, name, version)
       end
 
-      describe 'chef_server location type' do
-        let(:chef_server_url) { 'http://configured-chef-server/' }
+      describe "chef_server location type" do
+        let(:chef_server_url) { "http://configured-chef-server/" }
         let(:ridley_client) do
           double(Ridley::Client,
-            cookbook: double('cookbook', download: "fake")
+            cookbook: double("cookbook", download: "fake")
           )
         end
         let(:chef_config) do
           double(Ridley::Chef::Config,
-            node_name: 'fake-client',
-            client_key: 'client-key',
+            node_name: "fake-client",
+            client_key: "client-key",
             chef_server_url: chef_server_url,
-            validation_client_name: 'validator',
-            validation_key: 'validator.pem',
-            cookbook_copyright: 'user',
-            cookbook_email: 'user@example.com',
-            cookbook_license: 'apachev2',
+            validation_client_name: "validator",
+            validation_key: "validator.pem",
+            cookbook_copyright: "user",
+            cookbook_email: "user@example.com",
+            cookbook_license: "apachev2",
             trusted_certs_dir: self_signed_crt_path,
             knife: {
-              chef_guard: false
+              chef_guard: false,
             }
           )
         end
@@ -100,8 +100,8 @@ module Berkshelf
             client_key: chef_config.client_key,
             ssl: {
               verify: berkshelf_config.ssl.verify,
-              cert_store: cert_store
-            }
+              cert_store: cert_store,
+            },
           }
           expect(Ridley).to receive(:open).with(credentials) { ridley_client }
           subject.try_download(source, name, version)

data/spec/unit/berkshelf/errors_spec.rb

@@ -1,12 +1,12 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::BerkshelfError do
   skip
 end
 
 describe Berkshelf::CommunitySiteError do
-  let(:api_uri) { 'https://infra.as.code' }
-  let(:message) { 'Cookbook name' }
+  let(:api_uri) { "https://infra.as.code" }
+  let(:message) { "Cookbook name" }
 
   subject { described_class.new(api_uri, message) }
 

data/spec/unit/berkshelf/file_syncer_spec.rb

@@ -1,107 +1,107 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Berkshelf
   describe FileSyncer do
-    describe '#glob' do
+    describe "#glob" do
       before do
-        FileUtils.mkdir_p(File.join(tmp_path, 'folder'))
-        FileUtils.mkdir_p(File.join(tmp_path, '.hidden_folder'))
+        FileUtils.mkdir_p(File.join(tmp_path, "folder"))
+        FileUtils.mkdir_p(File.join(tmp_path, ".hidden_folder"))
 
-        FileUtils.touch(File.join(tmp_path, 'folder', 'file'))
-        FileUtils.touch(File.join(tmp_path, '.hidden_file'))
+        FileUtils.touch(File.join(tmp_path, "folder", "file"))
+        FileUtils.touch(File.join(tmp_path, ".hidden_file"))
       end
 
       let(:list) do
         described_class
           .glob("#{tmp_path}/**/*")
-          .map { |item| item.sub("#{tmp_path}/", '') }
+          .map { |item| item.sub("#{tmp_path}/", "") }
       end
 
-      it 'includes regular files' do
-        expect(list).to include('folder')
-        expect(list).to include('folder/file')
+      it "includes regular files" do
+        expect(list).to include("folder")
+        expect(list).to include("folder/file")
       end
 
-      it 'ignores .' do
-        expect(list).to_not include('.')
+      it "ignores ." do
+        expect(list).to_not include(".")
       end
 
-      it 'ignores ..' do
-        expect(list).to_not include('..')
+      it "ignores .." do
+        expect(list).to_not include("..")
       end
 
-      it 'includes hidden files' do
-        expect(list).to include('.hidden_file')
+      it "includes hidden files" do
+        expect(list).to include(".hidden_file")
       end
 
-      it 'includes hidden folders' do
-        expect(list).to include('.hidden_folder')
+      it "includes hidden folders" do
+        expect(list).to include(".hidden_folder")
       end
     end
 
-    describe '#sync' do
+    describe "#sync" do
       let(:source) do
-        source = File.join(tmp_path, 'source')
+        source = File.join(tmp_path, "source")
         FileUtils.mkdir_p(source)
 
-        FileUtils.touch(File.join(source, 'file_a'))
-        FileUtils.touch(File.join(source, 'file_b'))
-        FileUtils.touch(File.join(source, 'file_c'))
+        FileUtils.touch(File.join(source, "file_a"))
+        FileUtils.touch(File.join(source, "file_b"))
+        FileUtils.touch(File.join(source, "file_c"))
 
-        FileUtils.mkdir_p(File.join(source, 'folder'))
-        FileUtils.touch(File.join(source, 'folder', 'file_d'))
-        FileUtils.touch(File.join(source, 'folder', 'file_e'))
+        FileUtils.mkdir_p(File.join(source, "folder"))
+        FileUtils.touch(File.join(source, "folder", "file_d"))
+        FileUtils.touch(File.join(source, "folder", "file_e"))
 
-        FileUtils.mkdir_p(File.join(source, '.dot_folder'))
-        FileUtils.touch(File.join(source, '.dot_folder', 'file_f'))
+        FileUtils.mkdir_p(File.join(source, ".dot_folder"))
+        FileUtils.touch(File.join(source, ".dot_folder", "file_f"))
 
-        FileUtils.touch(File.join(source, '.file_g'))
+        FileUtils.touch(File.join(source, ".file_g"))
 
         # VCS files: Arch
-        FileUtils.mkdir_p(File.join(source, '.arch-ids'))
-        FileUtils.mkdir_p(File.join(source, '{arch}'))
+        FileUtils.mkdir_p(File.join(source, ".arch-ids"))
+        FileUtils.mkdir_p(File.join(source, "{arch}"))
 
         # VCS files: Bazaar
-        FileUtils.touch(File.join(source, '.bzr'))
-        FileUtils.touch(File.join(source, '.bzrignore'))
-        FileUtils.touch(File.join(source, '.bzrtags'))
+        FileUtils.touch(File.join(source, ".bzr"))
+        FileUtils.touch(File.join(source, ".bzrignore"))
+        FileUtils.touch(File.join(source, ".bzrtags"))
 
         # VCS files: CVS
-        FileUtils.mkdir_p(File.join(source, 'CVS'))
-        FileUtils.touch(File.join(source, '.cvsignore'))
+        FileUtils.mkdir_p(File.join(source, "CVS"))
+        FileUtils.touch(File.join(source, ".cvsignore"))
 
         # VCS files: Darcs
-        FileUtils.touch(File.join(source, '_darcs'))
+        FileUtils.touch(File.join(source, "_darcs"))
 
         # VCS files: git
-        FileUtils.mkdir_p(File.join(source, '.git', 'objects', '08'))
-        FileUtils.touch(File.join(source, '.git', 'HEAD'))
-        git_readonly_file = File.join(source, '.git', 'objects', '08', '01ddba0b1237b2e0e602cf5fdb6544561950cb')
+        FileUtils.mkdir_p(File.join(source, ".git", "objects", "08"))
+        FileUtils.touch(File.join(source, ".git", "HEAD"))
+        git_readonly_file = File.join(source, ".git", "objects", "08", "01ddba0b1237b2e0e602cf5fdb6544561950cb")
         FileUtils.touch(File.join(git_readonly_file))
         FileUtils.chmod("ugo=r", git_readonly_file)
-        FileUtils.touch(File.join(source, '.gitignore'))
+        FileUtils.touch(File.join(source, ".gitignore"))
 
         # VCS files: Mercurial
-        FileUtils.touch(File.join(source, '.hg'))
-        FileUtils.touch(File.join(source, '.hgignore'))
-        FileUtils.touch(File.join(source, '.hgrags'))
+        FileUtils.touch(File.join(source, ".hg"))
+        FileUtils.touch(File.join(source, ".hgignore"))
+        FileUtils.touch(File.join(source, ".hgrags"))
 
         # VCS files: RCS
-        FileUtils.mkdir_p(File.join(source, 'RCS'))
+        FileUtils.mkdir_p(File.join(source, "RCS"))
 
         # VCS files: SCCS
-        FileUtils.mkdir_p(File.join(source, 'SCCS'))
+        FileUtils.mkdir_p(File.join(source, "SCCS"))
 
         # VCS files: Subversion
-        FileUtils.mkdir_p(File.join(source, '.svn'))
+        FileUtils.mkdir_p(File.join(source, ".svn"))
 
         source
       end
 
-      let(:destination) { File.join(tmp_path, 'destination') }
+      let(:destination) { File.join(tmp_path, "destination") }
 
-      context 'when the destination is empty' do
-        it 'syncs the directories' do
+      context "when the destination is empty" do
+        it "syncs the directories" do
           described_class.sync(source, destination)
 
           expect("#{destination}/file_a").to be_a_file
@@ -114,10 +114,10 @@ module Berkshelf
         end
       end
 
-      context 'when the directory exists' do
+      context "when the directory exists" do
         before { FileUtils.mkdir_p(destination) }
 
-        it 'does not delete existing files and folders' do
+        it "does not delete existing files and folders" do
           FileUtils.mkdir_p("#{destination}/existing_folder")
           FileUtils.mkdir_p("#{destination}/.existing_folder")
           FileUtils.touch("#{destination}/existing_file")
@@ -139,7 +139,7 @@ module Berkshelf
           expect("#{destination}/.existing_file").to be_a_file
         end
 
-        it 'optionally deletes existing files and folders' do
+        it "optionally deletes existing files and folders" do
           FileUtils.mkdir_p("#{destination}/existing_folder")
           FileUtils.mkdir_p("#{destination}/.existing_folder")
           FileUtils.touch("#{destination}/existing_file")
@@ -161,7 +161,7 @@ module Berkshelf
           expect("#{destination}/.existing_file").to_not be_a_file
         end
 
-        it 'skips excluded VCS files' do
+        it "skips excluded VCS files" do
           described_class.sync(source, destination, exclude: Berksfile::EXCLUDED_VCS_FILES_WHEN_VENDORING)
 
           # VCS files: Arch
@@ -202,41 +202,41 @@ module Berkshelf
         end
       end
 
-      context 'with deeply nested paths and symlinks', :not_supported_on_windows do
+      context "with deeply nested paths and symlinks", :not_supported_on_windows do
         let(:source) do
-          source = File.join(tmp_path, 'source')
+          source = File.join(tmp_path, "source")
           FileUtils.mkdir_p(source)
 
-          FileUtils.mkdir_p(File.join(source, 'bin'))
-               FileUtils.touch(File.join(source, 'bin', 'apt'))
-               FileUtils.touch(File.join(source, 'bin', 'yum'))
+          FileUtils.mkdir_p(File.join(source, "bin"))
+          FileUtils.touch(File.join(source, "bin", "apt"))
+          FileUtils.touch(File.join(source, "bin", "yum"))
 
-          FileUtils.touch(File.join(source, 'LICENSE'))
+          FileUtils.touch(File.join(source, "LICENSE"))
 
-          FileUtils.mkdir_p(File.join(source, 'include'))
-          FileUtils.mkdir_p(File.join(source, 'include', 'linux'))
-               FileUtils.touch(File.join(source, 'include', 'linux', 'init.ini'))
+          FileUtils.mkdir_p(File.join(source, "include"))
+          FileUtils.mkdir_p(File.join(source, "include", "linux"))
+          FileUtils.touch(File.join(source, "include", "linux", "init.ini"))
 
-          FileUtils.mkdir_p(File.join(source, 'source'))
-          FileUtils.mkdir_p(File.join(source, 'source', 'bin'))
-               FileUtils.touch(File.join(source, 'source', 'bin', 'apt'))
-               FileUtils.touch(File.join(source, 'source', 'bin', 'yum'))
-               FileUtils.touch(File.join(source, 'source', 'LICENSE'))
+          FileUtils.mkdir_p(File.join(source, "source"))
+          FileUtils.mkdir_p(File.join(source, "source", "bin"))
+          FileUtils.touch(File.join(source, "source", "bin", "apt"))
+          FileUtils.touch(File.join(source, "source", "bin", "yum"))
+          FileUtils.touch(File.join(source, "source", "LICENSE"))
 
-          FileUtils.mkdir_p(File.join(source, 'empty_directory'))
+          FileUtils.mkdir_p(File.join(source, "empty_directory"))
 
-          FileUtils.mkdir_p(File.join(source, 'links'))
-                 FileUtils.touch(File.join(source, 'links', 'home.html'))
-                 FileUtils.ln_s("./home.html", "#{source}/links/index.html")
-                 FileUtils.ln_s("./home.html", "#{source}/links/default.html")
-                 FileUtils.ln_s("../source/bin/apt", "#{source}/links/apt")
+          FileUtils.mkdir_p(File.join(source, "links"))
+          FileUtils.touch(File.join(source, "links", "home.html"))
+          FileUtils.ln_s("./home.html", "#{source}/links/index.html")
+          FileUtils.ln_s("./home.html", "#{source}/links/default.html")
+          FileUtils.ln_s("../source/bin/apt", "#{source}/links/apt")
 
-          FileUtils.ln_s('/foo/bar', "#{source}/root")
+          FileUtils.ln_s("/foo/bar", "#{source}/root")
 
           source
         end
 
-        it 'copies relative and absolute symlinks' do
+        it "copies relative and absolute symlinks" do
           described_class.sync(source, destination)
 
           expect("#{destination}/bin").to be_a_directory
@@ -263,23 +263,23 @@ module Berkshelf
           expect("#{destination}/links/default.html").to be_a_symlink_to("./home.html")
           expect("#{destination}/links/apt").to be_a_symlink_to("../source/bin/apt")
 
-          expect("#{destination}/root").to be_a_symlink_to('/foo/bar')
+          expect("#{destination}/root").to be_a_symlink_to("/foo/bar")
         end
 
-        it 'copies relative and absolute symlinks when destination is a relative path' do
+        it "copies relative and absolute symlinks when destination is a relative path" do
           described_class.sync(source, "#{destination.gsub(Dir.pwd, '.')}")
 
           expect("#{destination}/links/index.html").to be_a_symlink_to("./home.html")
           expect("#{destination}/links/default.html").to be_a_symlink_to("./home.html")
           expect("#{destination}/links/apt").to be_a_symlink_to("../source/bin/apt")
-          expect("#{destination}/root").to be_a_symlink_to('/foo/bar')
+          expect("#{destination}/root").to be_a_symlink_to("/foo/bar")
         end
 
       end
 
-      context 'when :exclude is given' do
-        it 'does not copy files and folders that match the pattern' do
-          described_class.sync(source, destination, exclude: '.dot_folder')
+      context "when :exclude is given" do
+        it "does not copy files and folders that match the pattern" do
+          described_class.sync(source, destination, exclude: ".dot_folder")
 
           expect("#{destination}/file_a").to be_a_file
           expect("#{destination}/file_b").to be_a_file
@@ -291,8 +291,8 @@ module Berkshelf
           expect("#{destination}/.file_g").to be_a_file
         end
 
-        it 'does not copy files and folder matching a pattern with a wildcard' do
-          described_class.sync(source, destination, exclude: '**/file_e')
+        it "does not copy files and folder matching a pattern with a wildcard" do
+          described_class.sync(source, destination, exclude: "**/file_e")
 
           expect("#{destination}/file_a").to be_a_file
           expect("#{destination}/file_b").to be_a_file
@@ -304,13 +304,13 @@ module Berkshelf
           expect("#{destination}/.file_g").to be_a_file
         end
 
-        it 'removes existing files and folders in destination' do
+        it "removes existing files and folders in destination" do
           FileUtils.mkdir_p("#{destination}/existing_folder")
           FileUtils.touch("#{destination}/existing_file")
           FileUtils.mkdir_p("#{destination}/.dot_folder")
           FileUtils.touch("#{destination}/.dot_folder/file_f")
 
-          described_class.sync(source, destination, delete: true, exclude: '.dot_folder')
+          described_class.sync(source, destination, delete: true, exclude: ".dot_folder")
 
           expect("#{destination}/file_a").to be_a_file
           expect("#{destination}/file_b").to be_a_file

data/spec/unit/berkshelf/formatters/base_spec.rb

@@ -1,35 +1,35 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Berkshelf
   describe BaseFormatter do
-    it 'has abstract methods for all the messaging modes' do
-      expect {
-        subject.install('my_coobook','1.2.3','http://community')
-      }.to raise_error(AbstractFunction)
+    it "has abstract methods for all the messaging modes" do
+      expect do
+        subject.install("my_coobook", "1.2.3", "http://community")
+      end.to raise_error(AbstractFunction)
 
-      expect {
-        subject.use('my_coobook','1.2.3')
-      }.to raise_error(AbstractFunction)
+      expect do
+        subject.use("my_coobook", "1.2.3")
+      end.to raise_error(AbstractFunction)
 
-      expect {
-        subject.use('my_coobook','1.2.3','http://community')
-      }.to raise_error(AbstractFunction)
+      expect do
+        subject.use("my_coobook", "1.2.3", "http://community")
+      end.to raise_error(AbstractFunction)
 
-      expect {
-        subject.uploaded('my_coobook','1.2.3','http://chef_server')
-      }.to raise_error(AbstractFunction)
+      expect do
+        subject.uploaded("my_coobook", "1.2.3", "http://chef_server")
+      end.to raise_error(AbstractFunction)
 
-      expect {
-        subject.msg('something you to know')
-      }.to raise_error(AbstractFunction)
+      expect do
+        subject.msg("something you to know")
+      end.to raise_error(AbstractFunction)
 
-      expect {
-        subject.error('whoa this is bad')
-      }.to raise_error(AbstractFunction)
+      expect do
+        subject.error("whoa this is bad")
+      end.to raise_error(AbstractFunction)
 
-      expect {
-        subject.fetch(double('dependency'))
-      }.to raise_error(AbstractFunction)
+      expect do
+        subject.fetch(double("dependency"))
+      end.to raise_error(AbstractFunction)
     end
   end
 end