bento_search 1.3.0 → 1.4.2

data/app/search_engines/bento_search/journal_tocs_for_journal.rb

@@ -50,8 +50,13 @@ module BentoSearch
           url = request_url(issn)
           response = http_client.get(url)
 
+          # In some cases, status 401 seems to be bad email
           unless response.ok?
-            raise FetchError.new("#{url}: returns #{response.status} response")
+            # trim some XML boilerplate and remove newlines
+            # from response body, for better error message
+            response_body = response.body.gsub(/[\n\t]/, '').sub(/\A<\?xml[^>]*\>/, '')
+
+            raise FetchError.new("#{url}: returns #{response.status} response: #{response_body}")
           end
 
           Nokogiri::XML(response.body)
@@ -76,7 +81,7 @@ module BentoSearch
       xml = fetch_xml(issn)
 
 
-      BentoSearch::Results.new.concat(
+      results = BentoSearch::Results.new.concat(
         xml.xpath("./rdf:RDF/rss:item", xml_ns).collect do |node|
           item = BentoSearch::ResultItem.new
 
@@ -128,6 +133,9 @@ module BentoSearch
           date_node = xml_text(node, "prism:coverDate") || xml_text(node, "dc:date") || xml_text(node, "prism:publicationDate")
           if date_node && date_node =~ /\A(\d\d\d\d-\d\d-\d\d)/
             item.publication_date = Date.strptime( $1, "%Y-%m-%d")
+          elsif date_node
+            # Let's try a random parse, they give us all kinds of things I'm afraid
+            item.publication_date = Date.parse(date_node) rescue ArgumentError
           end
 
           # abstract, we need to strip possible HTML tags (sometimes they're
@@ -139,6 +147,16 @@ module BentoSearch
           item
         end
       )
+
+      # Items seem to come back in arbitrary order, we want to sort
+      # by date reverse if we can
+      if results.all? {|i| i.publication_date.present? }
+        results.sort_by! {|i| i.publication_date}.reverse!
+      end
+
+      fill_in_search_metadata_for(results)
+
+      return results
     end
 
     # just a convenience method
@@ -172,7 +190,7 @@ module BentoSearch
       ["registered_email"]
     end
 
-    class FetchError < ::StandardError ; end
+    class FetchError < BentoSearch::FetchError ; end
 
 
   end

data/lib/bento_search/version.rb

@@ -1,3 +1,3 @@
 module BentoSearch
-  VERSION = "1.3.0"
+  VERSION = "1.4.2"
 end

data/lib/bento_search.rb

@@ -1,5 +1,9 @@
 require 'confstruct'
 
+module BentoSearch
+  class Error < ::StandardError ; end
+end 
+
 require "bento_search/engine"
 require 'bento_search/routes'
 
@@ -20,8 +24,7 @@ if Hashie::Mash.instance_methods(false).include?(:id)
 end
 
 
-module BentoSearch  
-  
+module BentoSearch      
   def self.global_registrar
     @@global_registrar ||= BentoSearch::Registrar.new
   end

data/test/search_engines/journal_tocs_for_journal_test.rb

@@ -1,93 +1,117 @@
-require 'test_helper'
-
-class JournalTocsForJournalTest < ActiveSupport::TestCase
-  extend TestWithCassette
-
-  JournalTocsForJournal = BentoSearch::JournalTocsForJournal
-
-  @@registered_email   = (ENV['JOURNAL_TOCS_REGISTERED_EMAIL'] || 'nobody@example.com')
-
-
-  VCR.configure do |c|
-    c.filter_sensitive_data("nobody@example.com", :journal_tocs) { @@registered_email }
-  end
-
-  def setup
-  	@engine = JournalTocsForJournal.new(:registered_email => @@registered_email)
-  end
-
-
- test_with_cassette("fetch_xml with hits", :journal_tocs) do
-    xml = @engine.fetch_xml("1533290X")
-
-    assert_not_nil xml
-    assert_kind_of Nokogiri::XML::Document, xml
-  end
-
-  test_with_cassette("error on bad base url", :journal_tocs) do
-  	engine = JournalTocsForJournal.new(:base_url => "http://doesnotexist.jhu.edu/", :registered_email => @@registered_email)
-
-    assert_raise JournalTocsForJournal::FetchError do
-      xml = engine.fetch_xml("1533290X")
-    end
-  end
-
-  test_with_cassette("error on error response", :journal_tocs) do
-    engine = JournalTocsForJournal.new(:base_url => "http://www.journaltocs.ac.uk/bad_url", :registered_email => @@registered_email)
-
-    assert_raise JournalTocsForJournal::FetchError do
-      xml = engine.fetch_xml("1533290X")
-    end
-  end
-
-  test_with_cassette("error on bad registered email", :journal_tocs) do
-    engine = JournalTocsForJournal.new(:registered_email => "unregistered@nowhere.com")
-
-    assert_raise JournalTocsForJournal::FetchError do
-      xml = engine.fetch_xml("1533290X")
-    end
-  end
-
-  test_with_cassette("smoke test", :journal_tocs) do
-    items = @engine.fetch_by_issn("1533290X")
-
-    assert_present items
-    assert_kind_of Array, items
-    assert_kind_of BentoSearch::Results, items
-    items.each do |item|
-      assert_kind_of BentoSearch::ResultItem, item
-    end
-  end
-
-  test_with_cassette("fills out metadata", :journal_tocs) do
-    # this ISSN has reasonably complete data in RSS feed
-    items = @engine.fetch_by_issn("1600-5740")
-
-    assert_present items.first
-
-    first = items.first
-
-    assert_present first.title
-    assert_present first.authors
-    assert_present first.authors.first.display
-    assert_present first.abstract
-    assert_present first.link
-    assert_present first.doi
-    assert_present first.publisher
-    assert_present first.source_title
-    assert_present first.volume
-    assert_present first.issue
-    assert_present first.start_page
-    assert_present first.end_page
-    assert_present first.publication_date
-
-  end
-
-  test_with_cassette("empty results on bad ISSN", :journal_tocs) do
-    items = @engine.fetch_by_issn("badissn")
-
-    assert items.empty?
-  end
-
-end
-
+require 'test_helper'
+
+class JournalTocsForJournalTest < ActiveSupport::TestCase
+  extend TestWithCassette
+
+  JournalTocsForJournal = BentoSearch::JournalTocsForJournal
+
+  @@registered_email   = (ENV['JOURNAL_TOCS_REGISTERED_EMAIL'] || 'nobody@example.com')
+
+
+  VCR.configure do |c|
+    c.filter_sensitive_data("nobody@example.com", :journal_tocs) { @@registered_email }
+  end
+
+  def setup
+    @test_engine_id       = "test_journal_tocs_engine_id"
+    @test_decorator_name  = "MockDecorator"
+  	@engine = JournalTocsForJournal.new(:registered_email => @@registered_email, 
+      :id => @test_engine_id,
+      :for_display => {:one => "one", :two => "two", :decorator => @test_decorator_name})
+    @test_display_config = @engine.configuration.for_display
+  end
+
+
+ test_with_cassette("fetch_xml with hits", :journal_tocs) do
+    xml = @engine.fetch_xml("1533290X")
+
+    assert_not_nil xml
+    assert_kind_of Nokogiri::XML::Document, xml
+  end
+
+  test_with_cassette("error on bad base url", :journal_tocs) do
+  	engine = JournalTocsForJournal.new(:base_url => "http://doesnotexist.jhu.edu/", :registered_email => @@registered_email)
+
+    assert_raise JournalTocsForJournal::FetchError do
+      xml = engine.fetch_xml("1533290X")
+    end
+  end
+
+  test_with_cassette("error on error response", :journal_tocs) do
+    engine = JournalTocsForJournal.new(:base_url => "http://www.journaltocs.ac.uk/bad_url", :registered_email => @@registered_email)
+
+    assert_raise JournalTocsForJournal::FetchError do
+      xml = engine.fetch_xml("1533290X")
+    end
+  end
+
+  test_with_cassette("error on bad registered email", :journal_tocs) do
+    engine = JournalTocsForJournal.new(:registered_email => "unregistered@nowhere.com")
+
+    error = assert_raise JournalTocsForJournal::FetchError do
+      xml = engine.fetch_xml("1533290X")
+    end
+
+    assert error.message =~ /account is invalid/
+  end
+
+  test_with_cassette("smoke test", :journal_tocs) do
+    items = @engine.fetch_by_issn("1533290X")
+
+    assert_present items
+    assert_kind_of Array, items
+    assert_kind_of BentoSearch::Results, items
+
+    assert_equal @test_engine_id,           items.engine_id
+    assert_equal @test_display_config.to_h, items.display_configuration.to_h
+
+    items.each do |item|
+      assert_kind_of BentoSearch::ResultItem, item
+
+      assert_equal @test_engine_id, item.engine_id
+      assert_equal @test_display_config.to_h, item.display_configuration.to_h
+      assert_equal @test_decorator_name, item.decorator
+    end
+  end
+
+  test_with_cassette("fills out metadata", :journal_tocs) do
+    # this ISSN has reasonably complete data in RSS feed
+    items = @engine.fetch_by_issn("1600-5740")
+
+    assert_present items.first
+
+    first = items.first
+
+    assert_present first.title
+    assert_present first.authors
+    assert_present first.authors.first.display
+    assert_present first.abstract
+    assert_present first.link
+    assert_present first.doi
+    assert_present first.publisher
+    assert_present first.source_title
+    assert_present first.volume
+    assert_present first.issue
+    assert_present first.start_page
+    assert_present first.end_page
+    assert_present first.publication_date
+
+  end
+
+  test_with_cassette("empty results on bad ISSN", :journal_tocs) do
+    items = @engine.fetch_by_issn("badissn")
+
+    assert items.empty?
+  end
+
+  test_with_cassette("sorts by date", :journal_tocs) do
+    items = @engine.fetch_by_issn("0026-2617")
+
+    (1..(items.length - 1)).each do |i|
+      assert items[i].publication_date <= items[i-1].publication_date, "Expected sorted in reverse date order"
+    end
+  end
+
+
+end
+

data/test/search_engines/search_engine_test.rb

@@ -174,5 +174,5 @@ class SearchEngineTest < ActiveSupport::TestCase
       assert_present  results.display_configuration.foo      
       assert_present  results.display_configuration.nested.one                  
     end
-
+    
 end

data/test/unit/serialization_test.rb

@@ -0,0 +1,249 @@
+require 'test_helper'
+
+
+
+class SerializationTest < ActiveSupport::TestCase
+  ResultItem = BentoSearch::ResultItem
+  MockEngine = BentoSearch::MockEngine
+
+  setup do
+    @init_hash = {:title => "something", 
+                  :unique_id => "AAA11212",
+                  :openurl_disabled => true,
+                  :link => "http://www.example.org/something",
+                  :link_is_fulltext => true,
+                  :format => "Article",
+                  :year => 2000,
+                  :publication_date => Date.new(2000,1,1),
+                  :volume => "10",
+                  :issue => "22",
+                  :start_page => "122",
+                  :end_page => "124",
+                  :language_code => "en",
+                  :language_str => "English 22",
+                  :source_title => "Journal of Things",
+                  :issn => "12345678",
+                  :isbn => "1234567890",
+                  :oclcnum => "1",
+                  :doi => "10.2.whatever",
+                  :pmid => "12121212",
+                  :publisher => "Joe Blow",
+                  :abstract => "something or other",
+                  :openurl_kev_co => "&rft.fake=fake",
+                  :format_str => "Something or other",
+                  :custom_data => {'foo' => "bar"},
+                  :snippets => ["snippet one", "snippet two"]}
+    @result_item = ResultItem.new(@init_hash)
+  end
+
+  def test_item_serialization
+    r = ResultItem.new(@init_hash)
+
+    hash = r.internal_state_hash
+
+    r2 = ResultItem.from_internal_state_hash(hash)
+
+    assert_kind_of ResultItem, r2
+
+    @init_hash.each_pair do |key, value|
+      assert_equal value, r2.instance_variable_get("@#{key}")
+    end
+  end
+
+  class ::SerializationTest::ExampleDecorator < BentoSearch::StandardDecorator
+    def title
+      "DECORATED TITLE"
+    end        
+  end
+
+  def test_item_serialization_not_decorated      
+    r = ::SerializationTest::ExampleDecorator.new(ResultItem.new(@init_hash), nil)
+    
+    assert_equal "DECORATED TITLE", r.title
+
+    hash = r.internal_state_hash
+
+    assert_present hash["title"]
+    refute_equal "DECORATED TITLE", hash["title"]
+  end
+
+  def test_author_serialization
+    hash = {:first => "Jonathan", :last => "Rochkind", :middle => "A", :display => "Rochkind, Jonathan A."}
+    a = BentoSearch::Author.new(hash)
+
+    a2 = BentoSearch::Author.load_json( a.dump_to_json )
+
+    hash.each_pair do |key, value|
+      assert_equal value, a2.send(key)
+    end
+  end
+
+  def test_item_json_serialization
+    json_str = @result_item.dump_to_json
+
+    assert_kind_of String, json_str
+
+    r2 = ResultItem.load_json(json_str)
+
+    @init_hash.each_pair do |key, value|
+      assert_equal value, r2.instance_variable_get("@#{key}")
+    end
+  end
+
+  def test_item_html_safe_serialization
+    r = ResultItem.new(:title => "<b>foo</b>".html_safe)
+
+    r2 = ResultItem.load_json( r.dump_to_json )
+
+    assert r2.title.html_safe?
+    assert_equal "<b>foo</b>", r2.title
+  end
+
+  def test_result_item_authors
+    r = ResultItem.new(:title => "foo")
+    r.authors << BentoSearch::Author.new(:first => "Jonathan", :last => "Rochkind")
+
+    hash = r.internal_state_hash
+    assert_kind_of Array, hash['authors']
+    hash['authors'].each do |item|
+      assert_kind_of Hash, item
+    end
+
+    json_str = r.dump_to_json
+    assert_kind_of String, json_str
+
+    r2 = ResultItem.load_json( json_str )
+    assert_kind_of Array, r2.authors
+    assert r2.authors.length == 1
+
+    au = r2.authors.first
+    assert_kind_of BentoSearch::Author, au
+    assert_equal "Jonathan", au.first
+    assert_equal "Rochkind", au.last
+  end
+
+  def test_result_item_other_links
+    r = ResultItem.new(:title => "foo")
+    r.other_links << BentoSearch::Link.new(:url => "http://example.org")
+
+    r2 = ResultItem.load_json(  r.dump_to_json  )
+    assert_kind_of Array, r2.other_links
+    assert r2.other_links.length == 1
+
+    l = r2.other_links.first
+    assert_kind_of BentoSearch::Link, l
+    assert_equal "http://example.org", l.url
+  end
+
+  def test_item_year_and_date
+    r = ResultItem.new(:title => "foo", :year => 1991, :publication_date => Date.new(1991, 5, 1))
+
+    r2 = ResultItem.load_json(  r.dump_to_json )
+
+    assert_equal 1991, r2.year
+    assert_equal Date.new(1991, 5, 1), r2.publication_date
+  end
+
+  class Results < ActionController::TestCase
+    test "serialize" do
+      engine = MockEngine.new(:id => "foo", 
+        :for_display => {:foo => "bar", :nested => {"one" => "two"}}
+      )
+      
+      results = engine.search("foo")
+
+      assert_kind_of Hash, results.internal_state_hash
+      assert_equal "foo", results.internal_state_hash["engine_id"]
+      assert_kind_of Array, results.internal_state_hash["result_items"]
+
+      assert_kind_of String, results.dump_to_json
+      assert_equal results.internal_state_hash, JSON.parse(results.dump_to_json)
+    end
+
+    test "de-serialize with no engine ID" do
+      engine = MockEngine.new(
+        :for_display => {:foo => "bar", :nested => {"one" => "two"}}
+      )      
+      results = engine.search("foo")
+
+      hash = results.internal_state_hash
+      restored = BentoSearch::Results.from_internal_state_hash(hash)
+      assert_kind_of BentoSearch::Results, restored
+      assert_equal results.size, restored.size
+      #assert_equal "foo", restored.engine_id
+
+      json_str = results.dump_to_json
+      assert_kind_of String, json_str
+      assert_kind_of BentoSearch::Results, BentoSearch::Results.load_json(json_str)
+    end
+
+    test "de-serialized can be configured for any engine" do
+      create_engine = MockEngine.new()
+      restore_engine = MockEngine.new(
+        :id => "MyMockEngine",
+        :for_display => {:foo => "bar", :nested => {"one" => "two"}, :decorator => "SomeDecorator"}
+      )
+
+      json = create_engine.search("foo").dump_to_json
+
+      restored = BentoSearch::Results.load_json(json)
+      restore_engine.fill_in_search_metadata_for(restored)
+
+      assert_equal "MyMockEngine", restored.engine_id
+      assert_equal restore_engine.configuration.for_display, restored.display_configuration
+
+      assert restored.length > 0
+
+      restored.each do |item|
+        assert_equal "MyMockEngine", item.engine_id
+        assert_equal restore_engine.configuration.for_display, item.display_configuration
+        assert_equal "SomeDecorator", item.decorator
+      end
+    end
+
+    class RegisteredEngineTest < ActionController::TestCase
+      def setup
+        BentoSearch.register_engine("mock") do |config|
+          config.engine = "MockEngine"
+          config.for_display = {:foo => "bar", :nested => {"one" => "two"}, :decorator => "SomeDecorator"}
+        end
+      end      
+
+    
+      def teardown     
+        BentoSearch.reset_engine_registrations!
+      end
+
+      test "de-serializes with a registered engine ID, restoring context" do
+        mock_engine = BentoSearch.get_engine("mock")
+        results     = mock_engine.search("query")
+
+        json_str = results.dump_to_json
+        assert_kind_of String, json_str
+
+        restored = BentoSearch::Results.load_json(json_str)
+
+        assert_kind_of BentoSearch::Results, restored
+
+        assert_equal "mock", restored.engine_id
+        assert_equal mock_engine.configuration.for_display, restored.display_configuration
+
+        assert restored.length > 0
+
+        restored.each do |item|
+          assert_equal "mock", item.engine_id
+          assert_equal mock_engine.configuration.for_display, item.display_configuration
+          assert_equal "SomeDecorator", item.decorator
+        end
+
+      end
+
+    end
+
+  end
+
+
+
+  
+
+end

data/test/vcr_cassettes/journal_tocs/empty_results_on_bad_ISSN.yml

@@ -4,33 +4,27 @@ http_interactions:
     method: get
     uri: http://www.journaltocs.ac.uk/api/journals/badissn?output=articles&user=nobody@example.com
     body:
-      encoding: US-ASCII
+      encoding: UTF-8
       string: ''
     headers: {}
   response:
     status:
       code: 200
-      message: !binary |-
-        T0s=
+      message: OK
     headers:
-      !binary "RGF0ZQ==":
-      - !binary |-
-        TW9uLCAxMSBNYXIgMjAxMyAyMDoxMjozOCBHTVQ=
-      !binary "U2VydmVy":
-      - !binary |-
-        QXBhY2hlLzIuMi4xNSAoQ2VudE9TKQ==
-      !binary "WC1Qb3dlcmVkLUJ5":
-      - !binary |-
-        UEhQLzUuMy4z
-      !binary "Q29udGVudC1MZW5ndGg=":
-      - !binary |-
-        MTIwMQ==
-      !binary "Q29udGVudC1UeXBl":
-      - !binary |-
-        YXBwbGljYXRpb24veG1sOyBjaGFyc2V0PXV0Zi04
+      Date:
+      - Tue, 01 Sep 2015 21:20:10 GMT
+      Server:
+      - Apache
+      X-Powered-By:
+      - PHP/5.3.3
+      Content-Length:
+      - '1189'
+      Content-Type:
+      - application/xml; charset=utf-8
     body:
-      encoding: US-ASCII
-      string: ! "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<rdf:RDF xmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\"\r\n
+      encoding: UTF-8
+      string: "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<rdf:RDF xmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\"\r\n
         \        xmlns=\"http://purl.org/rss/1.0/\"\r\n         xmlns:mn=\"http://usefulinc.com/rss/manifest/\"\r\n
         \        xmlns:dc=\"http://purl.org/dc/elements/1.1/\">\n\n  <channel rdf:about=\"http://www.journaltocs.hw.ac.uk/api/journals\">\r\n
         \   <title>JournalTOCs API - Found 0 journals for: badissn (0 articles)</title>\r\n
@@ -39,11 +33,11 @@ http_interactions:
         for this journal. Please report to S.Chumbe@hw.ac.uk]]></description>\r\n
         \   <dc:publisher>JournalTOCs API</dc:publisher>\r\n    <dc:creator>JOURNALTOCS
         API PROJECT</dc:creator>\r\n\t\t<dc:coverage>1</dc:coverage>\r\n    <image
-        rdf:resource=\"http://www.journaltocs.hw.ac.uk/images/xtralogo.gif\" />\r\n
-        \   <items>\r\n      <rdf:Seq>\r\n        \r\n      </rdf:Seq>\r\n    </items>\r\n
-        \ </channel>\r\n  \r\n\t\r\n  <rdf:Description rdf:ID=\"manifest\">\r\n    <mn:channels>\r\n
+        rdf:resource=\"http://www.journaltocs.ac.uk/images/jtocslogo.gif\" />\r\n
+        \   <items>\r\n      <rdf:Seq>\r\n      </rdf:Seq>\r\n    </items>\r\n  </channel>\r\n
+        \ \r\n\t\r\n  <rdf:Description rdf:ID=\"manifest\">\r\n    <mn:channels>\r\n
         \     <rdf:Seq>\r\n        <rdf:li rdf:resource=\"http://www.journaltocs.hw.ac.uk/api/journals\"
         />\r\n      </rdf:Seq>\r\n    </mn:channels>\r\n  </rdf:Description>\r\n\r\n</rdf:RDF>"
     http_version: 
-  recorded_at: Mon, 11 Mar 2013 20:12:38 GMT
-recorded_with: VCR 2.3.0
+  recorded_at: Tue, 01 Sep 2015 21:20:10 GMT
+recorded_with: VCR 2.9.3

data/test/vcr_cassettes/journal_tocs/error_on_bad_registered_email.yml

@@ -4,38 +4,31 @@ http_interactions:
     method: get
     uri: http://www.journaltocs.ac.uk/api/journals/1533290X?output=articles&user=unregistered@nowhere.com
     body:
-      encoding: US-ASCII
+      encoding: UTF-8
       string: ''
     headers: {}
   response:
     status:
       code: 401
-      message: !binary |-
-        VW5hdXRob3JpemVk
+      message: Unauthorized
     headers:
-      !binary "RGF0ZQ==":
-      - !binary |-
-        TW9uLCAxMSBNYXIgMjAxMyAyMDoxMjozOCBHTVQ=
-      !binary "U2VydmVy":
-      - !binary |-
-        QXBhY2hlLzIuMi4xNSAoQ2VudE9TKQ==
-      !binary "WC1Qb3dlcmVkLUJ5":
-      - !binary |-
-        UEhQLzUuMy4z
-      !binary "Q29udGVudC1MZW5ndGg=":
-      - !binary |-
-        MjQx
-      !binary "Q29ubmVjdGlvbg==":
-      - !binary |-
-        Y2xvc2U=
-      !binary "Q29udGVudC1UeXBl":
-      - !binary |-
-        dGV4dC94bWw7IGNoYXJzZXQ9dXRmLTg=
+      Date:
+      - Tue, 01 Sep 2015 21:20:10 GMT
+      Server:
+      - Apache
+      X-Powered-By:
+      - PHP/5.3.3
+      Content-Length:
+      - '237'
+      Connection:
+      - close
+      Content-Type:
+      - text/xml; charset=utf-8
     body:
-      encoding: US-ASCII
-      string: ! "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n<notice>\r\n\t<noticeCode>1</noticeCode>\r\n\t<noticeDescription>:-(
+      encoding: UTF-8
+      string: "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<notice>\n\t<noticeCode>1</noticeCode>\n\t<noticeDescription>:-(
         Sorry, your account is invalid. If you think it is my fault, pl let know by
-        email to: journaltocs@hw.ac.uk</noticeDescription>\r\n</notice> "
+        email to: journaltocs@hw.ac.uk</noticeDescription>\n</notice> "
     http_version: 
-  recorded_at: Mon, 11 Mar 2013 20:12:38 GMT
-recorded_with: VCR 2.3.0
+  recorded_at: Tue, 01 Sep 2015 21:20:10 GMT
+recorded_with: VCR 2.9.3