aruba 1.0.0 → 1.0.1

data/lib/aruba/matchers/base/object_formatter.rb

@@ -12,8 +12,6 @@ module Aruba
         prepare_for_inspection(object).inspect
       end
 
-      # rubocop:disable Metrics/CyclomaticComplexity
-
       # @private
       # Prepares the provided object to be formatted by wrapping it as needed
       # in something that, when `inspect` is called on it, will produce the
@@ -46,7 +44,6 @@ module Aruba
 
         InspectableItem.new(inspection)
       end
-      # rubocop:enable Metrics/CyclomaticComplexity
 
       # @private
       def self.prepare_hash(input)

data/lib/aruba/matchers/collection/include_an_object.rb

@@ -29,9 +29,7 @@ module Aruba
       # @api private
       # @return [String]
       def failure_message
-        unless iterable?
-          return "#{improve_hash_formatting(super)}, but was not iterable"
-        end
+        return "#{improve_hash_formatting(super)}, but was not iterable" unless iterable?
 
         return failed_objects.first if failed_objects.size == 1
 
@@ -91,7 +89,9 @@ module Aruba
 
       def failure_message_for_item(index, failure_message)
         failure_message = indent_multiline_message(add_new_line_if_needed(failure_message))
-        indent_multiline_message("object at index #{index} failed to match:#{failure_message}")
+        indent_multiline_message(
+          "object at index #{index} failed to match:#{failure_message}"
+        )
       end
 
       def add_new_line_if_needed(message)

data/lib/aruba/matchers/command/be_successfully_executed.rb

@@ -29,7 +29,9 @@ RSpec::Matchers.define :be_successfully_executed do
   end
 
   failure_message do |_actual|
-    "Expected `#{@actual}` to succeed but got non-zero exit status and the following output:\n\n#{@old_actual.output}\n"
+    "Expected `#{@actual}` to succeed" \
+      ' but got non-zero exit status and the following output:' \
+      "\n\n#{@old_actual.output}\n"
   end
 end
 

data/lib/aruba/matchers/command/have_exit_status.rb

@@ -23,7 +23,9 @@ RSpec::Matchers.define :have_exit_status do |expected|
     @old_actual.stop
     @actual = actual.exit_status
 
-    raise "Expected #{@old_actual} to respond to #exit_status" unless @old_actual.respond_to? :exit_status
+    unless @old_actual.respond_to? :exit_status
+      raise "Expected #{@old_actual} to respond to #exit_status"
+    end
 
     values_match? expected, @actual
   end

data/lib/aruba/matchers/command/have_finished_in_time.rb

@@ -24,7 +24,9 @@ RSpec::Matchers.define :have_finished_in_time do
     @old_actual = actual
     @actual     = @old_actual.commandline
 
-    raise "Expected #{@old_actual} to respond to #timed_out?" unless @old_actual.respond_to? :timed_out?
+    unless @old_actual.respond_to? :timed_out?
+      raise "Expected #{@old_actual} to respond to #timed_out?"
+    end
 
     @old_actual.stop
 

data/lib/aruba/matchers/command/have_output.rb

@@ -19,7 +19,9 @@ RSpec::Matchers.define :have_output do |expected|
   match do |actual|
     @old_actual = actual
 
-    raise "Expected #{@old_actual} to respond to #output" unless @old_actual.respond_to? :output
+    unless @old_actual.respond_to? :output
+      raise "Expected #{@old_actual} to respond to #output"
+    end
 
     @old_actual.stop
 

data/lib/aruba/matchers/command/have_output_on_stderr.rb

@@ -17,7 +17,9 @@ RSpec::Matchers.define :have_output_on_stderr do |expected|
   match do |actual|
     @old_actual = actual
 
-    raise "Expected #{@old_actual} to respond to #stderr" unless @old_actual.respond_to? :stderr
+    unless @old_actual.respond_to? :stderr
+      raise "Expected #{@old_actual} to respond to #stderr"
+    end
 
     @old_actual.stop
 

data/lib/aruba/matchers/command/have_output_on_stdout.rb

@@ -17,7 +17,9 @@ RSpec::Matchers.define :have_output_on_stdout do |expected|
   match do |actual|
     @old_actual = actual
 
-    raise "Expected #{@old_actual} to respond to #stdout" unless @old_actual.respond_to? :stdout
+    unless @old_actual.respond_to? :stdout
+      raise "Expected #{@old_actual} to respond to #stdout"
+    end
 
     @old_actual.stop
 

data/lib/aruba/matchers/directory/have_sub_directory.rb

@@ -23,7 +23,8 @@ require 'rspec/expectations/version'
 #
 #     RSpec.describe do
 #       it { expect('dir1.d').to have_sub_directory(['subdir.1.d', 'subdir.2.d']) }
-#       it { expect(directories).to include a_directory_with_sub_directory(['subdir.1.d', 'subdir.2.d']) }
+#       it { expect(directories)
+#       .  to include a_directory_with_sub_directory(['subdir.1.d', 'subdir.2.d']) }
 #     end
 RSpec::Matchers.define :have_sub_directory do |expected|
   match do |actual|
@@ -40,11 +41,15 @@ RSpec::Matchers.define :have_sub_directory do |expected|
   diffable
 
   failure_message do |actual|
-    format('expected that directory "%s" has the following sub-directories: %s.', actual.join(', '), expected)
+    format('expected that directory "%s" has the following sub-directories: %s.',
+           actual.join(', '),
+           expected)
   end
 
   failure_message_when_negated do |actual|
-    format('expected that directory "%s" does not have the following sub-directories: %s.', actual.join(', '), expected)
+    format('expected that directory "%s" does not have the following sub-directories: %s.',
+           actual.join(', '),
+           expected)
   end
 end
 

data/lib/aruba/matchers/file/have_file_size.rb

@@ -34,11 +34,13 @@ RSpec::Matchers.define :have_file_size do |expected|
   end
 
   failure_message do |_actual|
-    format('expected that file "%s" has size "%s", but has "%s"', @old_actual, @actual, @expected)
+    format('expected that file "%s" has size "%s", but has "%s"',
+           @old_actual, @actual, @expected)
   end
 
   failure_message_when_negated do |_actual|
-    format('expected that file "%s" does not have size "%s", but has "%s"', @old_actual, @actual, @expected)
+    format('expected that file "%s" does not have size "%s", but has "%s"',
+           @old_actual, @actual, @expected)
   end
 end
 

data/lib/aruba/matchers/path/have_permissions.rb

@@ -51,11 +51,13 @@ RSpec::Matchers.define :have_permissions do |expected|
   end
 
   failure_message do |_actual|
-    format('expected that path "%s" has permissions "%s", but has "%s".', @old_actual, @expected, @actual)
+    format('expected that path "%s" has permissions "%s", but has "%s".',
+           @old_actual, @expected, @actual)
   end
 
   failure_message_when_negated do |_actual|
-    format('expected that path "%s" does not have permissions "%s", but has "%s".', @old_actual, @expected, @actual)
+    format('expected that path "%s" does not have permissions "%s", but has "%s".',
+           @old_actual, @expected, @actual)
   end
 end
 

data/lib/aruba/platforms/announcer.rb

@@ -21,7 +21,9 @@ module Aruba
     #
     #   before do
     #     current_example = context.example
-    #     aruba.announcer.activate :my_channel if current_example.metadata[:announce_my_channel]
+    #     if current_example.metadata[:announce_my_channel]
+    #       aruba.announcer.activate :my_channel
+    #     end
     #   end
     #
     #   Aruba.announcer.announce(:my_channel, 'my message')
@@ -80,16 +82,26 @@ module Aruba
 
       def after_init
         output_format :changed_configuration, proc { |n, v| format('# %s = %s', n, v) }
-        output_format :changed_environment, proc { |n, v| format('$ export %s=%s', n, Shellwords.escape(v)) }
+        output_format :changed_environment,
+                      proc { |n, v| format('$ export %s=%s', n, Shellwords.escape(v)) }
         output_format :command, '$ %s'
         output_format :directory, '$ cd %s'
-        output_format :environment, proc { |n, v| format('$ export %s=%s', n, Shellwords.escape(v)) }
-        output_format :full_environment, proc { |h| format("<<-ENVIRONMENT\n%s\nENVIRONMENT", Aruba.platform.simple_table(h)) }
-        output_format :modified_environment, proc { |n, v| format('$ export %s=%s', n, Shellwords.escape(v)) }
+        output_format :environment,
+                      proc { |n, v| format('$ export %s=%s', n, Shellwords.escape(v)) }
+        output_format :full_environment,
+                      proc { |h|
+                        format("<<-ENVIRONMENT\n%s\nENVIRONMENT",
+                               Aruba.platform.simple_table(h))
+                      }
+        output_format :modified_environment,
+                      proc { |n, v| format('$ export %s=%s', n, Shellwords.escape(v)) }
         output_format :stderr, "<<-STDERR\n%s\nSTDERR"
         output_format :stdout, "<<-STDOUT\n%s\nSTDOUT"
         output_format :command_content, "<<-COMMAND\n%s\nCOMMAND"
-        output_format :stop_signal, proc { |p, s| format('Command will be stopped with `kill -%s %s`', s, p) }
+        output_format :stop_signal,
+                      proc { |p, s|
+                        format('Command will be stopped with `kill -%s %s`', s, p)
+                      }
         output_format :timeout, '# %s-timeout: %s seconds'
         output_format :wait_time, '# %s: %s seconds'
         output_format :command_filesystem_status,

data/lib/aruba/platforms/aruba_file_creator.rb

@@ -18,7 +18,9 @@ module Aruba
       # @param [Boolean] check_presence (false)
       #   Check if file exist
       def call(path, content, check_presence = false)
-        fail "Expected #{path} to be present" if check_presence && !Aruba.platform.file?(path)
+        if check_presence && !Aruba.platform.file?(path)
+          raise "Expected #{path} to be present"
+        end
 
         Aruba.platform.mkdir(File.dirname(path))
 

data/lib/aruba/platforms/aruba_fixed_size_file_creator.rb

@@ -22,11 +22,16 @@ module Aruba
       # @param [Boolean] check_presence (false)
       #   Check if file exist
       def call(path, size, check_presence)
-        fail "Expected #{path} to be present" if check_presence && !Aruba.platform.file?(path)
+        if check_presence && !Aruba.platform.file?(path)
+          raise "Expected #{path} to be present"
+        end
 
         Aruba.platform.mkdir(File.dirname(path))
 
-        File.open(path, 'wb') { |f| f.seek(size - 1); f.write("\0") }
+        File.open(path, 'wb') do |f|
+          f.seek(size - 1)
+          f.write("\0")
+        end
 
         self
       end

data/lib/aruba/platforms/command_monitor.rb

@@ -20,7 +20,7 @@ module Aruba
       end
 
       def method_missing(*)
-        fail NoCommandHasBeenStoppedError, 'No last command stopped available'
+        raise NoCommandHasBeenStoppedError, 'No last command stopped available'
       end
 
       def respond_to_missing?(*)
@@ -34,7 +34,7 @@ module Aruba
       end
 
       def method_missing(*)
-        fail NoCommandHasBeenStartedError, 'No last command started available'
+        raise NoCommandHasBeenStartedError, 'No last command started available'
       end
 
       def respond_to_missing?(*)
@@ -78,7 +78,7 @@ module Aruba
       cmd = cmd.commandline if cmd.respond_to? :commandline
       command = registered_commands.reverse.find { |c| c.commandline == cmd }
 
-      fail CommandNotFoundError, "No command named '#{cmd}' has been started" if command.nil?
+      raise CommandNotFoundError, "No command named '#{cmd}' has been started" if command.nil?
 
       command
     end

data/lib/aruba/platforms/unix_environment_variables.rb

@@ -9,11 +9,9 @@ module Aruba
         attr_reader :other_env, :block
 
         def initialize(other_env, &block)
-          @other_env = other_env.to_h.each_with_object({}) { |(k, v), a| a[k] = v.to_s }
+          @other_env = other_env.to_h.transform_values(&:to_s)
 
-          @block = if block_given?
-                     block
-                   end
+          @block = (block if block_given?)
         end
 
         def call(env)

data/lib/aruba/platforms/unix_which.rb

@@ -13,7 +13,7 @@ module Aruba
         end
 
         def call(program, path)
-          fail %(Invalid input program "#{program}" and/or path "#{path}".)
+          raise %(Invalid input program "#{program}" and/or path "#{path}".)
         end
       end
 

data/lib/aruba/platforms/windows_environment_variables.rb

@@ -16,7 +16,8 @@ module Aruba
     #   C:>set PATH
     #   C:>Path=.;.\bin;c:\rubys\ruby-2.1.6-p336\bin;
     #
-    # @example If you access environment variables through ENV, you can access values no matter the case of the key:
+    # @example If you access environment variables through ENV, you can access
+    # values no matter the case of the key:
     #     ENV["Path"] # => ".;.\bin;c:\rubys\ruby-2.1.6-p336\bin;"
     #     ENV["PATH"] # => ".;.\bin;c:\rubys\ruby-2.1.6-p336\bin;"
     #

data/lib/aruba/platforms/windows_which.rb

@@ -13,7 +13,7 @@ module Aruba
         end
 
         def call(program, path)
-          fail %(Invalid input program "#{program}" and/or path "#{path}".)
+          raise %(Invalid input program "#{program}" and/or path "#{path}".)
         end
       end
 
@@ -96,7 +96,11 @@ module Aruba
       private
 
       def windows_executable_extentions
-        ENV['PATHEXT'] ? format('.{%s}', ENV['PATHEXT'].tr(';', ',').tr('.', '')).downcase : '.{exe,com,bat}'
+        if ENV['PATHEXT']
+          format('.{%s}', ENV['PATHEXT'].tr(';', ',').tr('.', '')).downcase
+        else
+          '.{exe,com,bat}'
+        end
       end
     end
   end

data/lib/aruba/processes/debug_process.rb

@@ -41,7 +41,8 @@ module Aruba
       # @return [String]
       #   A predefined string to make users aware they are using the DebugProcess
       def stdout(*)
-        'This is the debug launcher on STDOUT. If this output is unexpected, please check your setup.'
+        'This is the debug launcher on STDOUT.' \
+          ' If this output is unexpected, please check your setup.'
       end
 
       # Return stderr
@@ -49,7 +50,8 @@ module Aruba
       # @return [String]
       #   A predefined string to make users aware they are using the DebugProcess
       def stderr(*)
-        'This is the debug launcher on STDERR. If this output is unexpected, please check your setup.'
+        'This is the debug launcher on STDERR.' \
+          ' If this output is unexpected, please check your setup.'
       end
 
       # Write to nothing

data/lib/aruba/processes/in_process.rb

@@ -61,7 +61,7 @@ module Aruba
 
       # Start command
       def start
-        fail 'You need to call aruba.config.main_class = YourMainClass' unless main_class
+        raise 'You need to call aruba.config.main_class = YourMainClass' unless main_class
 
         @started = true
 
@@ -109,7 +109,9 @@ module Aruba
 
       # Close io
       def close_io(name)
-        fail ArgumentError, 'Only stdin stdout and stderr are allowed to close' unless [:stdin, :stdout, :stderr].include? name
+        unless [:stdin, :stdout, :stderr].include? name
+          raise ArgumentError, 'Only stdin stdout and stderr are allowed to close'
+        end
 
         get_instance_variable(name.to_sym).close
       end

data/lib/aruba/processes/spawn_process.rb

@@ -63,16 +63,15 @@ module Aruba
       # @yield [SpawnProcess]
       #   Run code for process which was started
       #
-      # rubocop:disable Metrics/MethodLength
       def start
-        # rubocop:disable Layout/LineLength
         if started?
-          error_message = %(Command "#{commandline}" has already been started. Please `#stop` the command first and `#start` it again. Alternatively use `#restart`.\n#{caller.join("\n")})
-          fail CommandAlreadyStartedError, error_message
+          error_message =
+            "Command \"#{commandline}\" has already been started." \
+            ' Please `#stop` the command first and `#start` it again.' \
+            ' Alternatively use `#restart`.'
+          raise CommandAlreadyStartedError, error_message
         end
 
-        # rubocop:enable Layout/LineLength
-
         @started = true
 
         @process = ChildProcess.build(*command_string.to_a)
@@ -113,7 +112,6 @@ module Aruba
 
         yield self if block_given?
       end
-      # rubocop:enable Metrics/MethodLength
 
       # Access to stdin of process
       def stdin
@@ -236,7 +234,7 @@ module Aruba
       #   The signal, i.e. 'TERM'
       def send_signal(signal)
         error_message = %(Command "#{commandline}" with PID "#{pid}" has already stopped.)
-        fail CommandAlreadyStoppedError, error_message if @process.exited?
+        raise CommandAlreadyStoppedError, error_message if @process.exited?
 
         Process.kill signal, pid
       rescue Errno::ESRCH
@@ -267,13 +265,23 @@ module Aruba
       private
 
       def command_string
-        fail LaunchError, %(Command "#{command}" not found in PATH-variable "#{environment['PATH']}".) if command_path.nil?
+        if command_path.nil?
+          raise LaunchError,
+                %(Command "#{command}" not found in PATH-variable "#{environment['PATH']}".)
+        end
 
         Aruba.platform.command_string.new(command_path, *arguments)
       end
 
       def command_path
-        @command_path ||= (Aruba.platform.builtin_shell_commands.include?(command) ? command : Aruba.platform.which(command, environment['PATH']))
+        @command_path ||=
+          begin
+            if Aruba.platform.builtin_shell_commands.include?(command)
+              command
+            else
+              Aruba.platform.which(command, environment['PATH'])
+            end
+          end
       end
 
       def wait_for_io(time_to_wait)

data/lib/aruba/rspec.rb

@@ -13,8 +13,10 @@ RSpec.configure do |config|
       setup_aruba
 
       # Modify PATH to include project/bin
-      prepend_environment_variable 'PATH',
-                                   aruba.config.command_search_paths.join(File::PATH_SEPARATOR) + File::PATH_SEPARATOR
+      prepend_environment_variable(
+        'PATH',
+        aruba.config.command_search_paths.join(File::PATH_SEPARATOR) + File::PATH_SEPARATOR
+      )
 
       # Use configured home directory as HOME
       set_environment_variable 'HOME', aruba.config.home_directory
@@ -47,19 +49,27 @@ RSpec.configure do |config|
   config.before :each do |example|
     next unless self.class.include?(Aruba::Api)
 
-    aruba.announcer.activate(:full_environment)     if example.metadata[:announce_full_environment]
-    aruba.announcer.activate(:changed_environment)  if example.metadata[:announce_changed_environment]
-
-    aruba.announcer.activate(:command)                   if example.metadata[:announce_command]
-    aruba.announcer.activate(:directory)                 if example.metadata[:announce_directory]
-    aruba.announcer.activate(:full_environment)          if example.metadata[:announce_full_environment]
-    aruba.announcer.activate(:stderr)                    if example.metadata[:announce_stderr]
-    aruba.announcer.activate(:stdout)                    if example.metadata[:announce_stdout]
-    aruba.announcer.activate(:stop_signal)               if example.metadata[:announce_stop_signal]
-    aruba.announcer.activate(:timeout)                   if example.metadata[:announce_timeout]
-    aruba.announcer.activate(:wait_time)                 if example.metadata[:announce_wait_time]
-    aruba.announcer.activate(:command_content)           if example.metadata[:announce_command_content]
-    aruba.announcer.activate(:command_filesystem_status) if example.metadata[:announce_command_filesystem_status]
+    if example.metadata[:announce_full_environment]
+      aruba.announcer.activate(:full_environment)
+    end
+    if example.metadata[:announce_changed_environment]
+      aruba.announcer.activate(:changed_environment)
+    end
+
+    aruba.announcer.activate(:command) if example.metadata[:announce_command]
+    aruba.announcer.activate(:directory) if example.metadata[:announce_directory]
+    if example.metadata[:announce_full_environment]
+      aruba.announcer.activate(:full_environment)
+    end
+    aruba.announcer.activate(:stderr) if example.metadata[:announce_stderr]
+    aruba.announcer.activate(:stdout) if example.metadata[:announce_stdout]
+    aruba.announcer.activate(:stop_signal) if example.metadata[:announce_stop_signal]
+    aruba.announcer.activate(:timeout) if example.metadata[:announce_timeout]
+    aruba.announcer.activate(:wait_time) if example.metadata[:announce_wait_time]
+    aruba.announcer.activate(:command_content) if example.metadata[:announce_command_content]
+    if example.metadata[:announce_command_filesystem_status]
+      aruba.announcer.activate(:command_filesystem_status)
+    end
 
     if example.metadata[:announce_output]
       aruba.announcer.activate(:stderr)