aruba 1.0.0 → 1.0.1

data/lib/aruba/cucumber/file.rb

@@ -3,11 +3,13 @@ Given(/^I use (?:a|the) fixture(?: named)? "([^"]*)"$/) do |name|
   cd name
 end
 
-Given(/^I copy (?:a|the) (?:file|directory)(?: (?:named|from))? "([^"]*)" to "([^"]*)"$/) do |source, destination|
+Given(/^I copy (?:a|the) (?:file|directory)(?: (?:named|from))? "([^"]*)" to "([^"]*)"$/) \
+  do |source, destination|
   copy source, destination
 end
 
-Given(/^I move (?:a|the) (?:file|directory)(?: (?:named|from))? "([^"]*)" to "([^"]*)"$/) do |source, destination|
+Given(/^I move (?:a|the) (?:file|directory)(?: (?:named|from))? "([^"]*)" to "([^"]*)"$/) \
+  do |source, destination|
   move source, destination
 end
 
@@ -15,7 +17,8 @@ Given(/^(?:a|the|(?:an empty)) directory(?: named)? "([^"]*)"$/) do |dir_name|
   create_directory(dir_name)
 end
 
-Given(/^(?:a|the) directory(?: named)? "([^"]*)" with mode "([^"]*)"$/) do |dir_name, dir_mode|
+Given(/^(?:a|the) directory(?: named)? "([^"]*)" with mode "([^"]*)"$/) \
+  do |dir_name, dir_mode|
   create_directory(dir_name)
   chmod(dir_mode, dir_name)
 end
@@ -32,7 +35,8 @@ Given(/^(?:a|the) file(?: named)? "([^"]*)" with "([^"]*)"$/) do |file_name, fil
   write_file(file_name, unescape_text(file_content))
 end
 
-Given(/^(?:a|the) file(?: named)? "([^"]*)" with mode "([^"]*)" and with:$/) do |file_name, file_mode, file_content|
+Given(/^(?:a|the) file(?: named)? "([^"]*)" with mode "([^"]*)" and with:$/) \
+  do |file_name, file_mode, file_content|
   write_file(file_name, unescape_text(file_content))
   chmod(file_mode, file_name)
 end
@@ -45,7 +49,8 @@ Given(/^(?:an|the) empty file(?: named)? "([^"]*)"$/) do |file_name|
   write_file(file_name, '')
 end
 
-Given(/^(?:an|the) empty file(?: named)? "([^"]*)" with mode "([^"]*)"$/) do |file_name, file_mode|
+Given(/^(?:an|the) empty file(?: named)? "([^"]*)" with mode "([^"]*)"$/) \
+  do |file_name, file_mode|
   write_file(file_name, '')
   chmod(file_mode, file_name)
 end
@@ -54,7 +59,8 @@ When(/^I write to "([^"]*)" with:$/) do |file_name, file_content|
   write_file(file_name, file_content)
 end
 
-When(/^I overwrite(?: (?:a|the) file(?: named)?)? "([^"]*)" with:$/) do |file_name, file_content|
+When(/^I overwrite(?: (?:a|the) file(?: named)?)? "([^"]*)" with:$/) \
+  do |file_name, file_content|
   overwrite_file(file_name, file_content)
 end
 
@@ -66,7 +72,8 @@ When(/^I append to "([^"]*)" with "([^"]*)"$/) do |file_name, file_content|
   append_to_file(file_name, file_content)
 end
 
-When(/^I remove (?:a|the) (?:file|directory)(?: named)? "([^"]*)"( with full force)?$/) do |name, force_remove|
+When(/^I remove (?:a|the) (?:file|directory)(?: named)? "([^"]*)"( with full force)?$/) \
+  do |name, force_remove|
   remove(name, force: force_remove.nil? ? false : true)
 end
 
@@ -88,7 +95,8 @@ Then(/^the following files should (not )?exist:$/) do |negated, files|
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?exist(?: anymore)?$/) do |path, expect_match|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?exist(?: anymore)?$/) \
+  do |path, expect_match|
   if expect_match
     expect(path).not_to be_an_existing_file
   else
@@ -96,7 +104,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?exist(?: anymore)?$/) d
   end
 end
 
-Then(/^(?:a|the) directory(?: named)? "([^"]*)" should (not )?exist(?: anymore)?$/) do |path, expect_match|
+Then(/^(?:a|the) directory(?: named)? "([^"]*)" should (not )?exist(?: anymore)?$/) \
+  do |path, expect_match|
   if expect_match
     expect(path).not_to be_an_existing_directory
   else
@@ -112,7 +121,8 @@ Then(/^(?:a|the) file matching %r<(.*?)> should (not )?exist$/) do |pattern, exp
   end
 end
 
-Then(/^(?:a|the) (\d+) byte file(?: named)? "([^"]*)" should (not )?exist$/) do |size, file, negated|
+Then(/^(?:a|the) (\d+) byte file(?: named)? "([^"]*)" should (not )?exist$/) \
+  do |size, file, negated|
   if negated
     expect(file).not_to have_file_size(size)
   else
@@ -130,7 +140,8 @@ Then(/^the following directories should (not )?exist:$/) do |negated, directorie
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain "([^"]*)"$/) do |file, negated, content|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain "([^"]*)"$/) \
+  do |file, negated, content|
   if negated
     expect(file).not_to have_file_content file_content_including(content.chomp)
   else
@@ -138,7 +149,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain "([^"]*)"$/) do
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain:$/) do |file, negated, content|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain:$/) \
+  do |file, negated, content|
   if negated
     expect(file).not_to have_file_content file_content_including(content.chomp)
   else
@@ -146,7 +158,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain:$/) do |file, n
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain exactly:$/) do |file, negated, content|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain exactly:$/) \
+  do |file, negated, content|
   if negated
     expect(file).not_to have_file_content content
   else
@@ -154,7 +167,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain exactly:$/) do
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?match %r<([^>]*)>$/) do |file, negated, content|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?match %r<([^>]*)>$/) \
+  do |file, negated, content|
   if negated
     expect(file).not_to have_file_content file_content_matching(content)
   else
@@ -162,7 +176,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?match %r<([^>]*)>$/) do
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?match \/([^\/]*)\/$/) do |file, negated, content|
+Then(%r{^(?:a|the) file(?: named)? "([^"]*)" should (not )?match /([^/]*)/$}) \
+  do |file, negated, content|
   if negated
     expect(file).not_to have_file_content file_content_matching(content)
   else
@@ -170,7 +185,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?match \/([^\/]*)\/$/) d
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?be equal to file "([^"]*)"/) do |file, negated, reference_file|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?be equal to file "([^"]*)"/) \
+  do |file, negated, reference_file|
   if negated
     expect(file).not_to have_same_file_content_as(reference_file)
   else
@@ -178,10 +194,14 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?be equal to file "([^"]
   end
 end
 
-Then(/^(?:a|the) (?:file|directory)(?: named)? "([^"]*)" should( not)? have permissions "([^"]*)"$/) do |path, negated, permissions|
-  if negated
-    expect(path).not_to have_permissions(permissions)
-  else
-    expect(path).to have_permissions(permissions)
-  end
+Then(
+  /^(?:a|the) (?:file|directory)(?: named)? "([^"]*)" should have permissions "([^"]*)"$/
+) do |path, permissions|
+  expect(path).to have_permissions(permissions)
+end
+
+Then(
+  /^(?:a|the) (?:file|directory)(?: named)? "([^"]*)" should not have permissions "([^"]*)"$/
+) do |path, permissions|
+  expect(path).not_to have_permissions(permissions)
 end

data/lib/aruba/cucumber/hooks.rb

@@ -9,7 +9,10 @@ end
 
 Before do
   # ... so every change needs to be done later
-  prepend_environment_variable 'PATH', aruba.config.command_search_paths.join(File::PATH_SEPARATOR) + File::PATH_SEPARATOR
+  prepend_environment_variable(
+    'PATH',
+    aruba.config.command_search_paths.join(File::PATH_SEPARATOR) + File::PATH_SEPARATOR
+  )
   set_environment_variable 'HOME', aruba.config.home_directory
 end
 

data/lib/aruba/cucumber/testing_frameworks.rb

@@ -1,18 +1,18 @@
 # Cucumber
-Then /^the feature(?:s)? should not(?: all)? pass$/ do
+Then(/^the feature(?:s)? should not(?: all)? pass$/) do
   step 'the output should contain " failed)"'
   step 'the exit status should be 1'
 end
 
 # Cucumber
-Then /^the feature(?:s)? should(?: all)? pass$/ do
+Then(/^the feature(?:s)? should(?: all)? pass$/) do
   step 'the output should not contain " failed)"'
   step 'the output should not contain " undefined)"'
   step 'the exit status should be 0'
 end
 
 # Cucumber
-Then /^the feature(?:s)? should not(?: all)? pass with( regex)?:$/ do |regex, string|
+Then(/^the feature(?:s)? should not(?: all)? pass with( regex)?:$/) do |regex, string|
   step 'the output should contain " failed)"'
   step 'the exit status should be 1'
 
@@ -24,7 +24,7 @@ Then /^the feature(?:s)? should not(?: all)? pass with( regex)?:$/ do |regex, st
 end
 
 # Cucumber
-Then /^the feature(?:s)? should(?: all)? pass with( regex)?:$/ do |regex, string|
+Then(/^the feature(?:s)? should(?: all)? pass with( regex)?:$/) do |regex, string|
   step 'the output should not contain " failed)"'
   step 'the output should not contain " undefined)"'
   step 'the exit status should be 0'
@@ -37,7 +37,8 @@ Then /^the feature(?:s)? should(?: all)? pass with( regex)?:$/ do |regex, string
 end
 
 # RSpec
-Then /^the spec(?:s)? should not(?: all)? pass(?: with (\d+) failures?)?$/ do |count_failures|
+Then(/^the spec(?:s)? should not(?: all)? pass(?: with (\d+) failures?)?$/) \
+  do |count_failures|
   if count_failures.nil?
     step 'the output should not contain "0 failures"'
   else
@@ -48,13 +49,13 @@ Then /^the spec(?:s)? should not(?: all)? pass(?: with (\d+) failures?)?$/ do |c
 end
 
 # RSpec
-Then /^the spec(?:s)? should all pass$/ do
+Then(/^the spec(?:s)? should all pass$/) do
   step 'the output should contain "0 failures"'
   step 'the exit status should be 0'
 end
 
 # RSpec
-Then /^the spec(?:s)? should not(?: all)? pass with( regex)?:$/ do |regex, string|
+Then(/^the spec(?:s)? should not(?: all)? pass with( regex)?:$/) do |regex, string|
   step 'the output should not contain "0 failures"'
   step 'the exit status should be 1'
 
@@ -66,7 +67,7 @@ Then /^the spec(?:s)? should not(?: all)? pass with( regex)?:$/ do |regex, strin
 end
 
 # RSpec
-Then /^the spec(?:s)? should(?: all)? pass with( regex)?:$/ do |regex, string|
+Then(/^the spec(?:s)? should(?: all)? pass with( regex)?:$/) do |regex, string|
   step 'the output should contain "0 failures"'
   step 'the exit status should be 0'
 
@@ -78,7 +79,8 @@ Then /^the spec(?:s)? should(?: all)? pass with( regex)?:$/ do |regex, string|
 end
 
 # Minitest
-Then /^the tests(?:s)? should not(?: all)? pass(?: with (\d+) failures?)?$/ do |count_failures|
+Then(/^the tests(?:s)? should not(?: all)? pass(?: with (\d+) failures?)?$/) \
+  do |count_failures|
   if count_failures.nil?
     step 'the output should not contain "0 errors"'
   else
@@ -89,13 +91,13 @@ Then /^the tests(?:s)? should not(?: all)? pass(?: with (\d+) failures?)?$/ do |
 end
 
 # Minitest
-Then /^the tests(?:s)? should all pass$/ do
+Then(/^the tests(?:s)? should all pass$/) do
   step 'the output should contain "0 errors"'
   step 'the exit status should be 0'
 end
 
 # Minitest
-Then /^the test(?:s)? should not(?: all)? pass with( regex)?:$/ do |regex, string|
+Then(/^the test(?:s)? should not(?: all)? pass with( regex)?:$/) do |regex, string|
   step 'the output should contain "0 errors"'
   step 'the exit status should be 1'
 
@@ -107,7 +109,7 @@ Then /^the test(?:s)? should not(?: all)? pass with( regex)?:$/ do |regex, strin
 end
 
 # Minitest
-Then /^the test(?:s)? should(?: all)? pass with( regex)?:$/ do |regex, string|
+Then(/^the test(?:s)? should(?: all)? pass with( regex)?:$/) do |regex, string|
   step 'the output should not contain "0 errors"'
   step 'the exit status should be 0'
 

data/lib/aruba/event_bus.rb

@@ -33,7 +33,9 @@ module Aruba
     def register(event_ids, handler_object = nil, &handler_proc)
       handler = handler_proc || handler_object
 
-      fail ArgumentError, 'Please pass either an object#call or a handler block' if handler.nil? || !handler.respond_to?(:call)
+      if handler.nil? || !handler.respond_to?(:call)
+        raise ArgumentError, 'Please pass either an object#call or a handler block'
+      end
 
       Array(event_ids).flatten.each do |id|
         @handlers[
@@ -51,7 +53,7 @@ module Aruba
     #   handler.
     #
     def notify(event)
-      fail NoEventError, 'Please pass an event object, not a class' if event.is_a?(Class)
+      raise NoEventError, 'Please pass an event object, not a class' if event.is_a?(Class)
 
       @handlers[event.class.to_s].each { |handler| handler.call(event) }
     end

data/lib/aruba/event_bus/name_resolver.rb

@@ -15,11 +15,11 @@ module Aruba
 
         # Thanks ActiveSupport
         # (Only needed to support Ruby 1.9.3 and JRuby)
-        # rubocop:disable Metrics/CyclomaticComplexity
         def constantize(camel_cased_word)
           names = camel_cased_word.split('::')
 
-          # Trigger a built-in NameError exception including the ill-formed constant in the message.
+          # Trigger a built-in NameError exception including the ill-formed
+          # constant in the message.
           Object.const_get(camel_cased_word) if names.empty?
 
           # Remove the first blank element in case of '::ClassName' notation.
@@ -49,7 +49,6 @@ module Aruba
             end
           end
         end
-        # rubocop:enable Metrics/CyclomaticComplexity
       end
 
       # @private
@@ -120,7 +119,8 @@ module Aruba
       class FailingResolver
         class << self
           def match?(event_id)
-            fail ArgumentError, %(Input type "#{event_id.class}" of event_id "#{event_id}" is invalid)
+            raise ArgumentError,
+                  %(Input type "#{event_id.class}" of event_id "#{event_id}" is invalid)
           end
 
           def supports
@@ -147,10 +147,11 @@ module Aruba
 
       def transform(event_id)
         resolvers.find { |r| r.match? event_id }.new.transform(default_namespace, event_id)
-      rescue => e
-        # rubocop:disable Layout/LineLength
-        raise EventNameResolveError, %(Transforming "#{event_id}" into an event class failed. Supported types are: #{@resolvers.map(&:supports).flatten.join(', ')}. #{e.message}.\n\n#{e.backtrace.join("\n")})
-        # rubocop:enable Layout/LineLength
+      rescue StandardError => e
+        types = @resolvers.map(&:supports).flatten.join(', ')
+        message = "Transforming \"#{event_id}\" into an event class failed." \
+          " Supported types are: #{types}. #{e.message}."
+        raise EventNameResolveError, message, cause: e
       end
     end
   end

data/lib/aruba/events.rb

@@ -4,7 +4,8 @@ module Aruba
   module Events
     # Basic event
     #
-    # This is not meant for direct use - BasicEvent.new - by users. It is inherited by normal events
+    # This is not meant for direct use - BasicEvent.new - by users. It is
+    # inherited by normal events
     #
     # @private
     class BasicEvent

data/lib/aruba/hooks.rb

@@ -21,12 +21,10 @@ module Aruba
     # @param [Proc] block
     #   The block which should be run for the hook
     def append(label, block)
-      if store.key?(label.to_sym) && store[label.to_sym].respond_to?(:<<)
-        store[label.to_sym] << block
-      else
+      unless store.key?(label.to_sym) && store[label.to_sym].respond_to?(:<<)
         store[label.to_sym] = []
-        store[label.to_sym] << block
       end
+      store[label.to_sym] << block
     end
 
     # Run hook

data/lib/aruba/in_config_wrapper.rb

@@ -15,14 +15,17 @@ module Aruba
     end
 
     def method_missing(name, *args)
-      fail ArgumentError, 'Options take no argument' if args.any?
-      fail UnknownOptionError, %(Option "#{name}" is unknown. Please use only earlier defined options) unless config.key? name
+      if config.key? name
+        raise ArgumentError, 'Options take no argument' if args.any?
 
-      config[name]
+        config[name]
+      else
+        super
+      end
     end
 
-    def respond_to_missing?(*)
-      true
+    def respond_to_missing?(name, _include_private)
+      config.key? name
     end
   end
 end

data/lib/aruba/initializer.rb

@@ -23,7 +23,8 @@ module Aruba
                   end
 
         content = if File.exist? file
-                    file_ends_with_carriage_return = File.open(file, 'r').readlines.last.match(/.*\n$/)
+                    file_ends_with_carriage_return =
+                      File.open(file, 'r').readlines.last.match(/.*\n$/)
 
                     prefix = file_ends_with_carriage_return ? '' : "\n"
 
@@ -53,7 +54,8 @@ module Aruba
         end
 
         def start(*)
-          fail ArgumentError, %(Unknown test framework. Please use one of :rspec, :cucumber or :minitest)
+          raise ArgumentError,
+                %(Unknown test framework. Please use one of :rspec, :cucumber or :minitest)
         end
       end
     end
@@ -206,7 +208,7 @@ module Aruba
       begin
         initializers.find { |i| i.match? test_framework }.start [], {}
       rescue ArgumentError => e
-        $stderr.puts e.message
+        warn e.message
         exit 0
       end
 

data/lib/aruba/matchers/base/base_matcher.rb

@@ -33,6 +33,8 @@ module Aruba
 
       # @private
       module HashFormatting
+        module_function
+
         # `{ :a => 5, :b => 2 }.inspect` produces:
         #
         #     {:a=>5, :b=>2}
@@ -45,7 +47,6 @@ module Aruba
         def improve_hash_formatting(inspect_string)
           inspect_string.gsub(/(\S)=>(\S)/, '\1 => \2')
         end
-        module_function :improve_hash_formatting
       end
 
       include HashFormatting
@@ -70,16 +71,6 @@ module Aruba
         def failure_message_when_negated
           "expected #{description_of @actual} not to #{description}"
         end
-
-        # @private
-        # rubocop:disable Naming/PredicateName
-        def self.has_default_failure_messages?(matcher)
-          matcher.method(:failure_message).owner == self &&
-            matcher.method(:failure_message_when_negated).owner == self
-        rescue NameError
-          false
-        end
-        # rubocop:enable Naming/PredicateName
       end
 
       include DefaultFailureMessages