aruba 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63d0e00b28a69fa235c0586425c501669cb313ce3dae63a76a33386eb358085e
-  data.tar.gz: be16476fe85c35d571574194c46c426cbb5805fff5fe2277b04b3f32f7098dc8
+  metadata.gz: 78af1111ebd1c66984dd8ad454318e6eba06e183cfd844bcf1e5e794103ea756
+  data.tar.gz: a4821903017781b016eb1510833e31c9421e79589a69b804d7fab1bc646e8d1c
 SHA512:
-  metadata.gz: 77fcdcd8b492e23fc72be16b48dd9913a3e7615ade362006cff3754661c0176c4483ce9d78ac7aa9d0c4da08ff1ae2c4f741b0f80ff93a221b10f7f2806b7c5f
-  data.tar.gz: 1d8f1f0f2879f5fef29c3baeee8d2041cd2d130e8cdfed5e77dac075960c0fd6ee0c813f6be1400e176b3a6846819946f1e5b56a02be2933b1e1b7682c313102
+  metadata.gz: 11b800a1afc27d83cd804685793e1ddc2cba21151b648a2f62ebc4016566d7cacc7c3f9fef578259ed0a00b50dd5ab6d0fd0a45c11f454b88a4648af3b4138e9
+  data.tar.gz: af2fc428c1fc809e39e87e7060be821a44a5fcba1b3cc131f7334e8ad2a516dc90375aea4d28b13299b51c5147c820a2bc765c936fee5095182b58a1ac1d3de3

data/.rubocop.yml

@@ -1,5 +1,6 @@
 require:
   - rubocop-performance
+  - rubocop-rspec
 
 AllCops:
   Exclude:
@@ -13,19 +14,39 @@ Style/PercentLiteralDelimiters:
   PreferredDelimiters:
     '%w': ()
 
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
 # Code is currently broken with frozen string literal comments applied.
 # TODO: Enable and fix build
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-# TODO: This is placed in here so the auto-gen-config doesn't destroy these.
-# Most of these need to be manually tackled, the LineLength value currently is good enough to stop most of
-# these leaking through into the codebase
-# Offense count: 375+
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
+# Be relatively lenient with line length
 Layout/LineLength:
-  Max: 150
+  Max: 94
+
+# Enable new cops from RuboCop 0.80, 0.81 and 0.84
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
 
 inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-01-01 19:49:41 +0100 using RuboCop version 0.78.0.
+# on 2020-05-31 23:12:24 +0200 using RuboCop version 0.84.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -11,11 +11,6 @@ Lint/AmbiguousBlockAssociation:
   Exclude:
     - 'lib/aruba/platforms/announcer.rb'
 
-# Offense count: 12
-Lint/AmbiguousRegexpLiteral:
-  Exclude:
-    - 'lib/aruba/cucumber/testing_frameworks.rb'
-
 # Offense count: 2
 # Configuration parameters: CheckForMethodsWithNoSideEffects.
 Lint/Void:
@@ -23,7 +18,8 @@ Lint/Void:
     - 'lib/aruba/platforms/announcer.rb'
     - 'lib/aruba/platforms/unix_environment_variables.rb'
 
-# Offense count: 29
+# Offense count: 26
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 116
 
@@ -31,31 +27,37 @@ Metrics/AbcSize:
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 587
+  Max: 594
 
 # Offense count: 2
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 145
+  Max: 158
 
-# Offense count: 20
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
+Metrics/CyclomaticComplexity:
+  Max: 12
+
+# Offense count: 28
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 22
+  Max: 59
 
-# Offense count: 2
+# Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 175
+  Max: 182
 
 # Offense count: 3
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 8
 
-# Offense count: 4
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 10
+  Max: 13
 
 # Offense count: 1
 Naming/ConstantName:
@@ -76,14 +78,13 @@ Naming/MemoizedInstanceVariableName:
   Exclude:
     - 'lib/aruba/api/core.rb'
 
-# Offense count: 16
+# Offense count: 14
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db, os
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
 Naming/MethodParameterName:
   Exclude:
     - 'lib/aruba/aruba_path.rb'
     - 'lib/aruba/config_wrapper.rb'
-    - 'lib/aruba/matchers/base/object_formatter.rb'
     - 'lib/aruba/platforms/announcer.rb'
     - 'lib/aruba/platforms/aruba_logger.rb'
     - 'lib/aruba/platforms/unix_platform.rb'
@@ -94,44 +95,101 @@ Performance/Caller:
   Exclude:
     - 'lib/aruba/platforms/unix_platform.rb'
 
+# Offense count: 51
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/aruba/api/filesystem_spec.rb'
+    - 'spec/aruba/api/runtime_spec.rb'
+    - 'spec/aruba/api_spec.rb'
+    - 'spec/aruba/matchers/command_spec.rb'
+    - 'spec/aruba/matchers/file_spec.rb'
+    - 'spec/aruba/matchers/path_spec.rb'
+    - 'spec/aruba/platform/windows_environment_variables_spec.rb'
+    - 'spec/support/shared_contexts/aruba.rb'
+
+# Offense count: 10
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/aruba/api/runtime_spec.rb'
+    - 'spec/aruba/jruby_spec.rb'
+    - 'spec/aruba/matchers/collection_spec.rb'
+    - 'spec/aruba/matchers/command/have_output_size_spec.rb'
+    - 'spec/aruba/matchers/command_spec.rb'
+    - 'spec/aruba/matchers/directory_spec.rb'
+    - 'spec/aruba/matchers/file_spec.rb'
+    - 'spec/aruba/matchers/path_spec.rb'
+    - 'spec/aruba/platform/simple_table_spec.rb'
+    - 'spec/aruba/rspec_spec.rb'
+
+# Offense count: 19
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/aruba/api/core_spec.rb'
+    - 'spec/aruba/api/filesystem_spec.rb'
+    - 'spec/aruba/aruba_path_spec.rb'
+    - 'spec/aruba/matchers/collection_spec.rb'
+
+# Offense count: 4
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/aruba/platform/windows_environment_variables_spec.rb'
+    - 'spec/aruba/platforms/command_monitor_spec.rb'
+    - 'spec/event_bus/name_resolver_spec.rb'
+    - 'spec/event_bus_spec.rb'
+
+# Offense count: 298
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/aruba/api/bundler_spec.rb'
+    - 'spec/aruba/api/commands_spec.rb'
+    - 'spec/aruba/api/core_spec.rb'
+    - 'spec/aruba/api/filesystem_spec.rb'
+    - 'spec/aruba/api_spec.rb'
+    - 'spec/aruba/matchers/command/have_output_size_spec.rb'
+    - 'spec/aruba/matchers/command_spec.rb'
+    - 'spec/aruba/matchers/directory_spec.rb'
+    - 'spec/aruba/matchers/file_spec.rb'
+    - 'spec/aruba/matchers/path_spec.rb'
+    - 'spec/aruba/processes/in_process_spec.rb'
+    - 'spec/event_bus_spec.rb'
+    - 'spec/support/shared_contexts/aruba.rb'
+
+# Offense count: 32
+RSpec/MultipleExpectations:
+  Max: 5
+
+# Offense count: 187
+RSpec/NestedGroups:
+  Max: 6
+
+# Offense count: 1
+RSpec/UnspecifiedException:
+  Exclude:
+    - 'spec/aruba/runtime_spec.rb'
+
 # Offense count: 2
 Security/Open:
   Exclude:
     - 'lib/aruba/processes/spawn_process.rb'
 
-# Offense count: 3
-# Configuration parameters: EnforcedStyle.
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols.
 # SupportedStyles: inline, group
 Style/AccessModifierDeclarations:
   Exclude:
-    - 'lib/aruba/in_config_wrapper.rb'
-    - 'lib/aruba/matchers/base/base_matcher.rb'
     - 'lib/aruba/matchers/collection/all.rb'
 
 # Offense count: 3
+# Configuration parameters: AllowOnConstant.
 Style/CaseEquality:
   Exclude:
     - 'lib/aruba/matchers/base/object_formatter.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/CharacterLiteral:
-  Exclude:
-    - 'spec/support/shared_contexts/aruba.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: is_a?, kind_of?
-Style/ClassCheck:
-  Exclude:
-    - 'lib/aruba/api/filesystem.rb'
-
-# Offense count: 1
-Style/CommentedKeyword:
-  Exclude:
-    - 'spec/aruba/api_spec.rb'
-
 # Offense count: 12
 Style/Documentation:
   Exclude:
@@ -146,117 +204,13 @@ Style/Documentation:
     - 'lib/aruba/setup.rb'
     - 'lib/aruba/tasks/docker_helpers.rb'
 
-# Offense count: 1
-Style/EvalWithLocation:
-  Exclude:
-    - 'spec/support/helpers/reporting.rb'
-
-# Offense count: 84
+# Offense count: 83
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   Enabled: false
 
 # Offense count: 2
-Style/IdenticalConditionalBranches:
-  Exclude:
-    - 'lib/aruba/hooks.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
-  Exclude:
-    - 'lib/aruba/cucumber/command.rb'
-    - 'lib/aruba/matchers/collection/include_an_object.rb'
-    - 'lib/aruba/platforms/unix_environment_variables.rb'
-    - 'lib/aruba/setup.rb'
-    - 'spec/aruba/platform/windows_environment_variables_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: line_count_dependent, lambda, literal
-Style/Lambda:
-  Exclude:
-    - 'spec/aruba/hooks_spec.rb'
-
-# Offense count: 5
 Style/MethodMissingSuper:
   Exclude:
-    - 'lib/aruba/config_wrapper.rb'
-    - 'lib/aruba/in_config_wrapper.rb'
     - 'lib/aruba/platforms/command_monitor.rb'
-    - 'lib/aruba/tasks/docker_helpers.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
-Style/NestedParenthesizedCalls:
-  Exclude:
-    - 'spec/aruba/matchers/collection_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
-# SupportedStyles: predicate, comparison
-Style/NumericPredicate:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/aruba/contracts/is_power_of_two.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'Rakefile'
-    - 'lib/aruba/api/bundler.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/aruba/cucumber/command.rb'
-    - 'lib/aruba/cucumber/file.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, explicit
-Style/RescueStandardError:
-  Exclude:
-    - 'lib/aruba/contracts/absolute_path.rb'
-    - 'lib/aruba/contracts/is_power_of_two.rb'
-    - 'lib/aruba/contracts/relative_path.rb'
-    - 'lib/aruba/event_bus/name_resolver.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAsExpressionSeparator.
-Style/Semicolon:
-  Exclude:
-    - 'lib/aruba/platforms/aruba_fixed_size_file_creator.rb'
-
-# Offense count: 40
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: only_raise, only_fail, semantic
-Style/SignalException:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/StderrPuts:
-  Exclude:
-    - 'Rakefile'
-    - 'lib/aruba/initializer.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: MinSize.
-# SupportedStyles: percent, brackets
-Style/SymbolArray:
-  EnforcedStyle: brackets

data/CHANGELOG.md

@@ -6,6 +6,19 @@ This project adheres to [Semantic Versioning][1].
 
 This document is formatted according to the principles of [Keep A CHANGELOG][2].
 
+## [1.0.1]
+
+### Bug fixes
+
+* Allow use of Aruba with Cucumber 4 ([#715] by [mvz])
+
+### Code quality and documentation improvements
+
+* Fix RuboCop offenses ([#693] and [#708] by [luke-hill], [#710], [#711] and
+  [#712] by [mvz])
+* Use recent Rake version in fixtures ([#709] by [mvz])
+* Repair YARD annotations ([#707] by [olleolleolle])
+
 ## [1.0.0]
 
 ### Breaking changes compared to Aruba 0.14.x
@@ -922,12 +935,20 @@ Note: These are changes w.r.t. Aruba version 0.14.1.
 
 <!-- issues & pull requests -->
 
+[#715]: https://github.com/cucumber/aruba/pull/715
+[#712]: https://github.com/cucumber/aruba/pull/712
+[#711]: https://github.com/cucumber/aruba/pull/711
+[#710]: https://github.com/cucumber/aruba/pull/710
+[#709]: https://github.com/cucumber/aruba/pull/709
+[#708]: https://github.com/cucumber/aruba/pull/708
+[#707]: https://github.com/cucumber/aruba/pull/707
 [#704]: https://github.com/cucumber/aruba/pull/704
 [#703]: https://github.com/cucumber/aruba/pull/703
 [#702]: https://github.com/cucumber/aruba/pull/702
 [#701]: https://github.com/cucumber/aruba/pull/701
 [#698]: https://github.com/cucumber/aruba/pull/698
 [#696]: https://github.com/cucumber/aruba/pull/696
+[#693]: https://github.com/cucumber/aruba/pull/693
 [#692]: https://github.com/cucumber/aruba/pull/692
 [#690]: https://github.com/cucumber/aruba/pull/690
 [#689]: https://github.com/cucumber/aruba/pull/689
@@ -1186,7 +1207,8 @@ Note: These are changes w.r.t. Aruba version 0.14.1.
 
 <!-- Releases -->
 
-[Unreleased]:     https://github.com/cucumber/aruba/compare/v1.0.0...master
+[Unreleased]:     https://github.com/cucumber/aruba/compare/v1.0.1...master
+[1.0.1]:          https://github.com/cucumber/aruba/compare/v1.0.0...v1.0.1
 [1.0.0]:          https://github.com/cucumber/aruba/compare/v1.0.0.pre.alpha.5...v1.0.0
 [1.0.0.pre.alpha.5]: https://github.com/cucumber/aruba/compare/v1.0.0.pre.alpha.4...v1.0.0.pre.alpha.5
 [1.0.0.pre.alpha.4]: https://github.com/cucumber/aruba/compare/v1.0.0.pre.alpha.3...v1.0.0.pre.alpha.4