api-auth 1.5.0 → 2.0.0

data/spec/request_drivers/rest_client_spec.rb

@@ -1,60 +1,59 @@
 require 'spec_helper'
 
 describe ApiAuth::RequestDrivers::RestClientRequest do
+  let(:timestamp) { Time.now.utc.httpdate }
 
-  let(:timestamp){ Time.now.utc.httpdate }
+  let(:request_path) { '/resource.xml?foo=bar&bar=foo' }
 
-  let(:request_path){ "/resource.xml?foo=bar&bar=foo" }
-
-  let(:request_headers){
+  let(:request_headers) do
     {
-      'Authorization'  => 'APIAuth 1044:12345',
+      'Authorization' => 'APIAuth 1044:12345',
       'Content-MD5' => '1B2M2Y8AsgTpgAmY7PhCfg==',
       'Content-Type' => 'text/plain',
       'Date' => timestamp
     }
-  }
+  end
 
   let(:request) do
     RestClient::Request.new(
-      :url => "/resource.xml?foo=bar&bar=foo",
+      :url => '/resource.xml?foo=bar&bar=foo',
       :headers => request_headers,
       :method => :put,
       :payload => "hello\nworld"
     )
   end
 
-  subject(:driven_request){ ApiAuth::RequestDrivers::RestClientRequest.new(request) }
+  subject(:driven_request) { ApiAuth::RequestDrivers::RestClientRequest.new(request) }
 
-  describe "getting headers correctly" do
-    it "gets the content_type" do
+  describe 'getting headers correctly' do
+    it 'gets the content_type' do
       expect(driven_request.content_type).to eq('text/plain')
     end
 
-    it "gets the content_md5" do
+    it 'gets the content_md5' do
       expect(driven_request.content_md5).to eq('1B2M2Y8AsgTpgAmY7PhCfg==')
     end
 
-    it "gets the request_uri" do
+    it 'gets the request_uri' do
       expect(driven_request.request_uri).to eq('/resource.xml?foo=bar&bar=foo')
     end
 
-    it "gets the timestamp" do
+    it 'gets the timestamp' do
       expect(driven_request.timestamp).to eq(timestamp)
     end
 
-    it "gets the authorization_header" do
+    it 'gets the authorization_header' do
       expect(driven_request.authorization_header).to eq('APIAuth 1044:12345')
     end
 
-    describe "#calculated_md5" do
-      it "calculates md5 from the body" do
+    describe '#calculated_md5' do
+      it 'calculates md5 from the body' do
         expect(driven_request.calculated_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
       end
 
-      it "treats no body as empty string" do
+      it 'treats no body as empty string' do
         request = RestClient::Request.new(
-          :url => "/resource.xml?foo=bar&bar=foo",
+          :url => '/resource.xml?foo=bar&bar=foo',
           :headers => request_headers,
           :method => :put
         )
@@ -63,49 +62,49 @@ describe ApiAuth::RequestDrivers::RestClientRequest do
       end
     end
 
-    describe "http_method" do
-      context "when put request" do
+    describe 'http_method' do
+      context 'when put request' do
         let(:request) do
           RestClient::Request.new(
-            :url => "/resource.xml?foo=bar&bar=foo",
+            :url => '/resource.xml?foo=bar&bar=foo',
             :headers => request_headers,
             :method => :put
           )
         end
 
-        it "returns upcased put" do
+        it 'returns upcased put' do
           expect(driven_request.http_method).to eq('PUT')
         end
       end
 
-      context "when get request" do
+      context 'when get request' do
         let(:request) do
           RestClient::Request.new(
-            :url => "/resource.xml?foo=bar&bar=foo",
+            :url => '/resource.xml?foo=bar&bar=foo',
             :headers => request_headers,
             :method => :get
           )
         end
 
-        it "returns upcased get" do
+        it 'returns upcased get' do
           expect(driven_request.http_method).to eq('GET')
         end
       end
     end
   end
 
-  describe "setting headers correctly" do
-    let(:request_headers){
+  describe 'setting headers correctly' do
+    let(:request_headers) do
       {
         'Content-Type' => 'text/plain'
       }
-    }
+    end
 
-    describe "#populate_content_md5" do
-      context "when getting" do
+    describe '#populate_content_md5' do
+      context 'when getting' do
         let(:request) do
           RestClient::Request.new(
-            :url => "/resource.xml?foo=bar&bar=foo",
+            :url => '/resource.xml?foo=bar&bar=foo',
             :headers => request_headers,
             :method => :get
           )
@@ -113,56 +112,56 @@ describe ApiAuth::RequestDrivers::RestClientRequest do
 
         it "doesn't populate content-md5" do
           driven_request.populate_content_md5
-          expect(request.headers["Content-MD5"]).to be_nil
+          expect(request.headers['Content-MD5']).to be_nil
         end
       end
 
-      context "when posting" do
+      context 'when posting' do
         let(:request) do
           RestClient::Request.new(
-            :url => "/resource.xml?foo=bar&bar=foo",
+            :url => '/resource.xml?foo=bar&bar=foo',
             :headers => request_headers,
             :method => :post,
             :payload => "hello\nworld"
           )
         end
 
-        it "populates content-md5" do
+        it 'populates content-md5' do
           driven_request.populate_content_md5
-          expect(request.headers["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          expect(request.headers['Content-MD5']).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
 
-        it "refreshes the cached headers" do
+        it 'refreshes the cached headers' do
           driven_request.populate_content_md5
           expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
       end
 
-      context "when putting" do
+      context 'when putting' do
         let(:request) do
           RestClient::Request.new(
-            :url => "/resource.xml?foo=bar&bar=foo",
+            :url => '/resource.xml?foo=bar&bar=foo',
             :headers => request_headers,
             :method => :put,
             :payload => "hello\nworld"
           )
         end
 
-        it "populates content-md5" do
+        it 'populates content-md5' do
           driven_request.populate_content_md5
-          expect(request.headers["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          expect(request.headers['Content-MD5']).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
 
-        it "refreshes the cached headers" do
+        it 'refreshes the cached headers' do
           driven_request.populate_content_md5
           expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
       end
 
-      context "when deleting" do
+      context 'when deleting' do
         let(:request) do
           RestClient::Request.new(
-            :url => "/resource.xml?foo=bar&bar=foo",
+            :url => '/resource.xml?foo=bar&bar=foo',
             :headers => request_headers,
             :method => :delete
           )
@@ -170,160 +169,158 @@ describe ApiAuth::RequestDrivers::RestClientRequest do
 
         it "doesn't populate content-md5" do
           driven_request.populate_content_md5
-          expect(request.headers["Content-MD5"]).to be_nil
+          expect(request.headers['Content-MD5']).to be_nil
         end
       end
-
     end
 
-    describe "#set_date" do
+    describe '#set_date' do
       before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
       end
 
-      it "sets the date header of the request" do
+      it 'sets the date header of the request' do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
         driven_request.set_date
         expect(request.headers['DATE']).to eq(timestamp)
       end
 
-      it "refreshes the cached headers" do
+      it 'refreshes the cached headers' do
         driven_request.set_date
         expect(driven_request.timestamp).to eq(timestamp)
       end
     end
 
-    describe "#set_auth_header" do
-      it "sets the auth header" do
+    describe '#set_auth_header' do
+      it 'sets the auth header' do
         driven_request.set_auth_header('APIAuth 1044:54321')
         expect(request.headers['Authorization']).to eq('APIAuth 1044:54321')
       end
     end
   end
 
-  describe "md5_mismatch?" do
-
-    context "when getting" do
+  describe 'md5_mismatch?' do
+    context 'when getting' do
       let(:request) do
         RestClient::Request.new(
-          :url => "/resource.xml?foo=bar&bar=foo",
+          :url => '/resource.xml?foo=bar&bar=foo',
           :headers => request_headers,
           :method => :get
         )
       end
 
-      it "is false" do
+      it 'is false' do
         expect(driven_request.md5_mismatch?).to be false
       end
     end
 
-    context "when posting" do
+    context 'when posting' do
       let(:request) do
         RestClient::Request.new(
-          :url => "/resource.xml?foo=bar&bar=foo",
+          :url => '/resource.xml?foo=bar&bar=foo',
           :headers => request_headers,
           :method => :post,
           :payload => "hello\nworld"
         )
       end
 
-      context "when calculated matches sent" do
-        let(:request_headers){
+      context 'when calculated matches sent' do
+        let(:request_headers) do
           {
-            'Authorization'  => 'APIAuth 1044:12345',
+            'Authorization' => 'APIAuth 1044:12345',
             'Content-MD5' => 'kZXQvrKoieG+Be1rsZVINw==',
             'Content-Type' => 'text/plain',
             'Date' => timestamp
           }
-        }
+        end
 
-        it "is false" do
+        it 'is false' do
           expect(driven_request.md5_mismatch?).to be false
         end
       end
 
       context "when calculated doesn't match sent" do
-        let(:request_headers){
+        let(:request_headers) do
           {
-            'Authorization'  => 'APIAuth 1044:12345',
+            'Authorization' => 'APIAuth 1044:12345',
             'Content-MD5' => '3',
             'Content-Type' => 'text/plain',
             'Date' => timestamp
           }
-        }
+        end
 
-        it "is true" do
+        it 'is true' do
           expect(driven_request.md5_mismatch?).to be true
         end
       end
     end
 
-    context "when putting" do
+    context 'when putting' do
       let(:request) do
         RestClient::Request.new(
-          :url => "/resource.xml?foo=bar&bar=foo",
+          :url => '/resource.xml?foo=bar&bar=foo',
           :headers => request_headers,
           :method => :put,
           :payload => "hello\nworld"
         )
       end
 
-      context "when calculated matches sent" do
-        let(:request_headers){
+      context 'when calculated matches sent' do
+        let(:request_headers) do
           {
-            'Authorization'  => 'APIAuth 1044:12345',
+            'Authorization' => 'APIAuth 1044:12345',
             'Content-MD5' => 'kZXQvrKoieG+Be1rsZVINw==',
             'Content-Type' => 'text/plain',
             'Date' => timestamp
           }
-        }
+        end
 
-        it "is false" do
+        it 'is false' do
           expect(driven_request.md5_mismatch?).to be false
         end
       end
 
       context "when calculated doesn't match sent" do
-        let(:request_headers){
+        let(:request_headers) do
           {
-            'Authorization'  => 'APIAuth 1044:12345',
+            'Authorization' => 'APIAuth 1044:12345',
             'Content-MD5' => '3',
             'Content-Type' => 'text/plain',
             'Date' => timestamp
           }
-        }
+        end
 
-        it "is true" do
+        it 'is true' do
           expect(driven_request.md5_mismatch?).to be true
         end
       end
     end
 
-    context "when deleting" do
+    context 'when deleting' do
       let(:request) do
         RestClient::Request.new(
-          :url => "/resource.xml?foo=bar&bar=foo",
+          :url => '/resource.xml?foo=bar&bar=foo',
           :headers => request_headers,
           :method => :delete
         )
       end
 
-      it "is false" do
+      it 'is false' do
         expect(driven_request.md5_mismatch?).to be false
       end
     end
   end
 
-  describe "edge cases" do
+  describe 'edge cases' do
     it "doesn't mess up symbol based headers" do
-      headers = { 'Content-MD5' => "e59ff97941044f85df5297e1c302d260",
-                  :content_type => "text/plain",
-                  'Date' => "Mon, 23 Jan 1984 03:29:56 GMT" }
-      request = RestClient::Request.new(:url => "/resource.xml?foo=bar&bar=foo",
-        :headers => headers,
-        :method => :put)
+      headers = { 'Content-MD5' => 'e59ff97941044f85df5297e1c302d260',
+                  :content_type => 'text/plain',
+                  'Date' => 'Mon, 23 Jan 1984 03:29:56 GMT' }
+      request = RestClient::Request.new(:url => '/resource.xml?foo=bar&bar=foo',
+                                        :headers => headers,
+                                        :method => :put)
       headers = ApiAuth::Headers.new(request)
-      ApiAuth.sign!(request, "some access id", "some secret key")
+      ApiAuth.sign!(request, 'some access id', 'some secret key')
       expect(request.processed_headers).to have_key('Content-Type')
     end
   end

data/spec/spec_helper.rb

@@ -1,13 +1,6 @@
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'rspec'
-require 'api_auth'
-require 'amatch'
-require 'rest_client'
-require 'curb'
-require 'httpi'
-require 'faraday'
-require 'net/http/post/multipart'
 
 require 'active_support'
 require 'active_support/test_case'
@@ -16,10 +9,17 @@ require 'action_controller/test_case'
 require 'active_resource'
 require 'active_resource/http_mock'
 
+require 'api_auth'
+require 'amatch'
+require 'rest_client'
+require 'curb'
+require 'httpi'
+require 'faraday'
+require 'net/http/post/multipart'
+
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 RSpec.configure do |config|
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: api-auth
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Mauricio Gomes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-21 00:00:00.000000000 Z
+date: 2016-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -199,30 +199,23 @@ files:
 - ".document"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Appraisals
 - CHANGELOG.md
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
 - VERSION
 - api_auth.gemspec
 - gemfiles/rails_23.gemfile
-- gemfiles/rails_23.gemfile.lock
 - gemfiles/rails_30.gemfile
-- gemfiles/rails_30.gemfile.lock
 - gemfiles/rails_31.gemfile
-- gemfiles/rails_31.gemfile.lock
 - gemfiles/rails_32.gemfile
-- gemfiles/rails_32.gemfile.lock
 - gemfiles/rails_4.gemfile
-- gemfiles/rails_4.gemfile.lock
 - gemfiles/rails_41.gemfile
-- gemfiles/rails_41.gemfile.lock
 - gemfiles/rails_42.gemfile
-- gemfiles/rails_42.gemfile.lock
 - lib/api-auth.rb
 - lib/api_auth.rb
 - lib/api_auth/base.rb
@@ -271,7 +264,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Simple HMAC authentication for your APIs