api-auth 1.5.0 → 2.0.0

data/spec/request_drivers/curb_spec.rb

@@ -1,96 +1,93 @@
 require 'spec_helper'
 
 describe ApiAuth::RequestDrivers::CurbRequest do
-
-  let(:timestamp){ Time.now.utc.httpdate }
+  let(:timestamp) { Time.now.utc.httpdate }
 
   let(:request) do
     headers = {
       'Authorization' => 'APIAuth 1044:12345',
-      'Content-MD5'   => "1B2M2Y8AsgTpgAmY7PhCfg==",
-      'Content-Type'  => "text/plain",
+      'Content-MD5'   => '1B2M2Y8AsgTpgAmY7PhCfg==',
+      'Content-Type'  => 'text/plain',
       'Date'          => timestamp
     }
-    Curl::Easy.new("/resource.xml?foo=bar&bar=foo") do |curl|
+    Curl::Easy.new('/resource.xml?foo=bar&bar=foo') do |curl|
       curl.headers = headers
     end
   end
 
+  subject(:driven_request) { ApiAuth::RequestDrivers::CurbRequest.new(request) }
 
-  subject(:driven_request){ ApiAuth::RequestDrivers::CurbRequest.new(request) }
-
-  describe "getting headers correctly" do
-    it "gets the content_type" do
+  describe 'getting headers correctly' do
+    it 'gets the content_type' do
       expect(driven_request.content_type).to eq('text/plain')
     end
 
-    it "gets the content_md5" do
+    it 'gets the content_md5' do
       expect(driven_request.content_md5).to eq('1B2M2Y8AsgTpgAmY7PhCfg==')
     end
 
-    it "gets the request_uri" do
+    it 'gets the request_uri' do
       expect(driven_request.request_uri).to eq('/resource.xml?foo=bar&bar=foo')
     end
 
-    it "gets the timestamp" do
+    it 'gets the timestamp' do
       expect(driven_request.timestamp).to eq(timestamp)
     end
 
-    it "gets the authorization_header" do
+    it 'gets the authorization_header' do
       expect(driven_request.authorization_header).to eq('APIAuth 1044:12345')
     end
 
-    describe "http_method" do
-      it "is always nil" do
+    describe 'http_method' do
+      it 'is always nil' do
         expect(driven_request.http_method).to be_nil
       end
     end
   end
 
-  describe "setting headers correctly" do
+  describe 'setting headers correctly' do
     let(:request) do
       headers = {
-        'Content-Type'  => "text/plain"
+        'Content-Type' => 'text/plain'
       }
-      Curl::Easy.new("/resource.xml?foo=bar&bar=foo") do |curl|
+      Curl::Easy.new('/resource.xml?foo=bar&bar=foo') do |curl|
         curl.headers = headers
       end
     end
 
-    describe "#populate_content_md5" do
-      it "is a no-op" do
+    describe '#populate_content_md5' do
+      it 'is a no-op' do
         expect(driven_request.populate_content_md5).to be_nil
         expect(request.headers['Content-MD5']).to be_nil
       end
-
     end
 
-    describe "#set_date" do
+    describe '#set_date' do
       before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
       end
 
-      it "sets the date header of the request" do
+      it 'sets the date header of the request' do
         driven_request.set_date
         expect(request.headers['DATE']).to eq(timestamp)
       end
 
-      it "refreshes the cached headers" do
+      it 'refreshes the cached headers' do
         driven_request.set_date
         expect(driven_request.timestamp).to eq(timestamp)
       end
     end
 
-    describe "#set_auth_header" do
-      it "sets the auth header" do
+    describe '#set_auth_header' do
+      it 'sets the auth header' do
         driven_request.set_auth_header('APIAuth 1044:54321')
         expect(request.headers['Authorization']).to eq('APIAuth 1044:54321')
       end
     end
   end
 
-  describe "md5_mismatch?" do
-    it "is always false" do
+  describe 'md5_mismatch?' do
+    it 'is always false' do
       expect(driven_request.md5_mismatch?).to be false
     end
   end

data/spec/request_drivers/faraday_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
 describe ApiAuth::RequestDrivers::FaradayRequest do
-
-  let(:timestamp){ Time.now.utc.httpdate }
+  let(:timestamp) { Time.now.utc.httpdate }
 
   let(:faraday_stubs) do
     Faraday::Adapter::Test::Stubs.new do |stub|
@@ -20,8 +19,8 @@ describe ApiAuth::RequestDrivers::FaradayRequest do
 
   let(:request_headers) do
     {
-      'Authorization'  => 'APIAuth 1044:12345',
-      'Content-MD5' => "1B2M2Y8AsgTpgAmY7PhCfg==",
+      'Authorization' => 'APIAuth 1044:12345',
+      'Content-MD5' => '1B2M2Y8AsgTpgAmY7PhCfg==',
       'content-type' => 'text/plain',
       'DATE' => timestamp
     }
@@ -38,42 +37,42 @@ describe ApiAuth::RequestDrivers::FaradayRequest do
     faraday_request
   end
 
-  subject(:driven_request){ ApiAuth::RequestDrivers::FaradayRequest.new(request) }
+  subject(:driven_request) { ApiAuth::RequestDrivers::FaradayRequest.new(request) }
 
-  describe "getting headers correctly" do
-    it "gets the content_type" do
+  describe 'getting headers correctly' do
+    it 'gets the content_type' do
       expect(driven_request.content_type).to eq('text/plain')
     end
 
-    it "gets the content_md5" do
+    it 'gets the content_md5' do
       expect(driven_request.content_md5).to eq('1B2M2Y8AsgTpgAmY7PhCfg==')
     end
 
-    it "gets the request_uri" do
+    it 'gets the request_uri' do
       expect(driven_request.request_uri).to eq('/resource.xml?bar=foo&foo=bar')
     end
 
-    it "gets the timestamp" do
+    it 'gets the timestamp' do
       expect(driven_request.timestamp).to eq(timestamp)
     end
 
-    it "gets the authorization_header" do
+    it 'gets the authorization_header' do
       expect(driven_request.authorization_header).to eq('APIAuth 1044:12345')
     end
 
-    describe "#calculated_md5" do
-      it "calculates md5 from the body" do
+    describe '#calculated_md5' do
+      it 'calculates md5 from the body' do
         expect(driven_request.calculated_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
       end
 
-      it "treats no body as empty string" do
+      it 'treats no body as empty string' do
         request.body = nil
         expect(driven_request.calculated_md5).to eq('1B2M2Y8AsgTpgAmY7PhCfg==')
       end
     end
 
-    describe "http_method" do
-      context "when put request" do
+    describe 'http_method' do
+      context 'when put request' do
         let(:request) do
           faraday_request = nil
 
@@ -85,12 +84,12 @@ describe ApiAuth::RequestDrivers::FaradayRequest do
           faraday_request
         end
 
-        it "returns upcased put" do
+        it 'returns upcased put' do
           expect(driven_request.http_method).to eq('PUT')
         end
       end
 
-      context "when get request" do
+      context 'when get request' do
         let(:request) do
           faraday_request = nil
 
@@ -102,158 +101,157 @@ describe ApiAuth::RequestDrivers::FaradayRequest do
           faraday_request
         end
 
-        it "returns upcased get" do
+        it 'returns upcased get' do
           expect(driven_request.http_method).to eq('GET')
         end
       end
     end
   end
 
-  describe "setting headers correctly" do
+  describe 'setting headers correctly' do
     let(:request_headers) do
       {
         'content-type' => 'text/plain'
       }
     end
 
-    describe "#populate_content_md5" do
-      context "when getting" do
+    describe '#populate_content_md5' do
+      context 'when getting' do
         it "doesn't populate content-md5" do
           request.method = :get
           driven_request.populate_content_md5
-          expect(request.headers["Content-MD5"]).to be_nil
+          expect(request.headers['Content-MD5']).to be_nil
         end
       end
 
-      context "when posting" do
-        it "populates content-md5" do
+      context 'when posting' do
+        it 'populates content-md5' do
           request.method = :post
           driven_request.populate_content_md5
-          expect(request.headers["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          expect(request.headers['Content-MD5']).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
 
-        it "refreshes the cached headers" do
+        it 'refreshes the cached headers' do
           driven_request.populate_content_md5
           expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
       end
 
-      context "when putting" do
-        it "populates content-md5" do
+      context 'when putting' do
+        it 'populates content-md5' do
           request.method = :put
           driven_request.populate_content_md5
-          expect(request.headers["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          expect(request.headers['Content-MD5']).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
 
-        it "refreshes the cached headers" do
+        it 'refreshes the cached headers' do
           driven_request.populate_content_md5
           expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
       end
 
-      context "when deleting" do
+      context 'when deleting' do
         it "doesn't populate content-md5" do
           request.method = :delete
           driven_request.populate_content_md5
-          expect(request.headers["Content-MD5"]).to be_nil
+          expect(request.headers['Content-MD5']).to be_nil
         end
       end
-
     end
 
-    describe "#set_date" do
+    describe '#set_date' do
       before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
       end
 
-      it "sets the date header of the request" do
+      it 'sets the date header of the request' do
         driven_request.set_date
         expect(request.headers['DATE']).to eq(timestamp)
       end
 
-      it "refreshes the cached headers" do
+      it 'refreshes the cached headers' do
         driven_request.set_date
         expect(driven_request.timestamp).to eq(timestamp)
       end
     end
 
-    describe "#set_auth_header" do
-      it "sets the auth header" do
+    describe '#set_auth_header' do
+      it 'sets the auth header' do
         driven_request.set_auth_header('APIAuth 1044:54321')
         expect(request.headers['Authorization']).to eq('APIAuth 1044:54321')
       end
     end
   end
 
-  describe "md5_mismatch?" do
-    context "when getting" do
+  describe 'md5_mismatch?' do
+    context 'when getting' do
       before do
         request.method = :get
       end
 
-      it "is false" do
+      it 'is false' do
         expect(driven_request.md5_mismatch?).to be false
       end
     end
 
-    context "when posting" do
+    context 'when posting' do
       before do
         request.method = :post
       end
 
-      context "when calculated matches sent" do
+      context 'when calculated matches sent' do
         before do
-          request.headers["Content-MD5"] = 'kZXQvrKoieG+Be1rsZVINw=='
+          request.headers['Content-MD5'] = 'kZXQvrKoieG+Be1rsZVINw=='
         end
 
-        it "is false" do
+        it 'is false' do
           expect(driven_request.md5_mismatch?).to be false
         end
       end
 
       context "when calculated doesn't match sent" do
         before do
-          request.headers["Content-MD5"] = "3"
+          request.headers['Content-MD5'] = '3'
         end
 
-        it "is true" do
+        it 'is true' do
           expect(driven_request.md5_mismatch?).to be true
         end
       end
     end
 
-    context "when putting" do
+    context 'when putting' do
       before do
         request.method = :put
       end
 
-      context "when calculated matches sent" do
+      context 'when calculated matches sent' do
         before do
-          request.headers["Content-MD5"] = 'kZXQvrKoieG+Be1rsZVINw=='
+          request.headers['Content-MD5'] = 'kZXQvrKoieG+Be1rsZVINw=='
         end
 
-        it "is false" do
+        it 'is false' do
           expect(driven_request.md5_mismatch?).to be false
         end
       end
 
       context "when calculated doesn't match sent" do
         before do
-          request.headers["Content-MD5"] = "3"
+          request.headers['Content-MD5'] = '3'
         end
 
-        it "is true" do
+        it 'is true' do
           expect(driven_request.md5_mismatch?).to be true
         end
       end
     end
 
-    context "when deleting" do
+    context 'when deleting' do
       before do
         request.method = :delete
       end
 
-      it "is false" do
+      it 'is false' do
         expect(driven_request.md5_mismatch?).to be false
       end
     end

data/spec/request_drivers/httpi_spec.rb

@@ -1,157 +1,151 @@
 require 'spec_helper'
 
 describe ApiAuth::RequestDrivers::HttpiRequest do
-
-  let(:timestamp){ Time.now.utc.httpdate }
+  let(:timestamp) { Time.now.utc.httpdate }
 
   let(:request) do
-    httpi_request = HTTPI::Request.new("http://localhost/resource.xml?foo=bar&bar=foo")
-    httpi_request.headers.merge!({
-        'Authorization'  => 'APIAuth 1044:12345',
-        'content-md5' => '1B2M2Y8AsgTpgAmY7PhCfg==',
-        'content-type' => 'text/plain',
-        'date' => timestamp
-    })
+    httpi_request = HTTPI::Request.new('http://localhost/resource.xml?foo=bar&bar=foo')
+    httpi_request.headers.merge!('Authorization' => 'APIAuth 1044:12345',
+                                 'content-md5' => '1B2M2Y8AsgTpgAmY7PhCfg==',
+                                 'content-type' => 'text/plain',
+                                 'date' => timestamp)
     httpi_request.body = "hello\nworld"
     httpi_request
   end
 
-  subject(:driven_request){ ApiAuth::RequestDrivers::HttpiRequest.new(request) }
+  subject(:driven_request) { ApiAuth::RequestDrivers::HttpiRequest.new(request) }
 
-  describe "getting headers correctly" do
-    it "gets the content_type" do
+  describe 'getting headers correctly' do
+    it 'gets the content_type' do
       expect(driven_request.content_type).to eq('text/plain')
     end
 
-    it "gets the content_md5" do
+    it 'gets the content_md5' do
       expect(driven_request.content_md5).to eq('1B2M2Y8AsgTpgAmY7PhCfg==')
     end
 
-    it "gets the request_uri" do
+    it 'gets the request_uri' do
       expect(driven_request.request_uri).to eq('/resource.xml?foo=bar&bar=foo')
     end
 
-    it "gets the timestamp" do
+    it 'gets the timestamp' do
       expect(driven_request.timestamp).to eq(timestamp)
     end
 
-    it "gets the authorization_header" do
+    it 'gets the authorization_header' do
       expect(driven_request.authorization_header).to eq('APIAuth 1044:12345')
     end
 
-    describe "#calculated_md5" do
-      it "calculates md5 from the body" do
+    describe '#calculated_md5' do
+      it 'calculates md5 from the body' do
         expect(driven_request.calculated_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
       end
 
-      it "treats no body as empty string" do
+      it 'treats no body as empty string' do
         request.body = nil
         expect(driven_request.calculated_md5).to eq('1B2M2Y8AsgTpgAmY7PhCfg==')
       end
     end
 
-    describe "http_method" do
-      it "is always nil" do
+    describe 'http_method' do
+      it 'is always nil' do
         expect(driven_request.http_method).to be_nil
       end
     end
   end
 
-  describe "setting headers correctly" do
+  describe 'setting headers correctly' do
     let(:request) do
-      httpi_request = HTTPI::Request.new("http://localhost/resource.xml?foo=bar&bar=foo")
-      httpi_request.headers.merge!({
-        'content-type' => 'text/plain'
-      })
+      httpi_request = HTTPI::Request.new('http://localhost/resource.xml?foo=bar&bar=foo')
+      httpi_request.headers['content-type'] = 'text/plain'
       httpi_request
     end
 
-    describe "#populate_content_md5" do
-      context "when there is no content body" do
+    describe '#populate_content_md5' do
+      context 'when there is no content body' do
         before do
           request.body = nil
         end
 
         it "doesn't populate content-md5" do
           driven_request.populate_content_md5
-          expect(request.headers["Content-MD5"]).to be_nil
+          expect(request.headers['Content-MD5']).to be_nil
         end
       end
 
-      context "when there is a content body" do
+      context 'when there is a content body' do
         before do
           request.body = "hello\nworld"
         end
 
-        it "populates content-md5" do
+        it 'populates content-md5' do
           driven_request.populate_content_md5
-          expect(request.headers["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          expect(request.headers['Content-MD5']).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
 
-        it "refreshes the cached headers" do
+        it 'refreshes the cached headers' do
           driven_request.populate_content_md5
           expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
       end
     end
 
-    describe "#set_date" do
+    describe '#set_date' do
       before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
       end
 
-      it "sets the date header of the request" do
+      it 'sets the date header of the request' do
         driven_request.set_date
         expect(request.headers['DATE']).to eq(timestamp)
       end
 
-      it "refreshes the cached headers" do
+      it 'refreshes the cached headers' do
         driven_request.set_date
         expect(driven_request.timestamp).to eq(timestamp)
       end
     end
 
-    describe "#set_auth_header" do
-      it "sets the auth header" do
+    describe '#set_auth_header' do
+      it 'sets the auth header' do
         driven_request.set_auth_header('APIAuth 1044:54321')
         expect(request.headers['Authorization']).to eq('APIAuth 1044:54321')
       end
     end
   end
 
-  describe "md5_mismatch?" do
-    context "when there is no content body" do
+  describe 'md5_mismatch?' do
+    context 'when there is no content body' do
       before do
         request.body = nil
       end
 
-
-      it "is false" do
+      it 'is false' do
         expect(driven_request.md5_mismatch?).to be false
       end
     end
 
-    context "when there is a content body" do
+    context 'when there is a content body' do
       before do
         request.body = "hello\nworld"
       end
 
-      context "when calculated matches sent" do
+      context 'when calculated matches sent' do
         before do
-          request.headers["Content-MD5"] = 'kZXQvrKoieG+Be1rsZVINw=='
+          request.headers['Content-MD5'] = 'kZXQvrKoieG+Be1rsZVINw=='
         end
 
-        it "is false" do
+        it 'is false' do
           expect(driven_request.md5_mismatch?).to be false
         end
       end
 
       context "when calculated doesn't match sent" do
         before do
-          request.headers["Content-MD5"] = "3"
+          request.headers['Content-MD5'] = '3'
         end
 
-        it "is true" do
+        it 'is true' do
           expect(driven_request.md5_mismatch?).to be true
         end
       end