api-auth 1.5.0 → 2.0.0

data/spec/request_drivers/net_http_spec.rb

@@ -1,19 +1,18 @@
 require 'spec_helper'
 
 describe ApiAuth::RequestDrivers::NetHttpRequest do
+  let(:timestamp) { Time.now.utc.httpdate }
 
-  let(:timestamp){ Time.now.utc.httpdate }
+  let(:request_path) { '/resource.xml?foo=bar&bar=foo' }
 
-  let(:request_path){ "/resource.xml?foo=bar&bar=foo" }
-
-  let(:request_headers){
+  let(:request_headers) do
     {
-      'Authorization'  => 'APIAuth 1044:12345',
+      'Authorization' => 'APIAuth 1044:12345',
       'content-md5' => '1B2M2Y8AsgTpgAmY7PhCfg==',
       'content-type' => 'text/plain',
       'date' => timestamp
     }
-  }
+  end
 
   let(:request) do
     net_http_request = Net::HTTP::Put.new(request_path, request_headers)
@@ -21,175 +20,174 @@ describe ApiAuth::RequestDrivers::NetHttpRequest do
     net_http_request
   end
 
-  subject(:driven_request){ ApiAuth::RequestDrivers::NetHttpRequest.new(request) }
+  subject(:driven_request) { ApiAuth::RequestDrivers::NetHttpRequest.new(request) }
 
-  describe "getting headers correctly" do
-    describe "#content_type" do
-      it "gets the content_type" do
+  describe 'getting headers correctly' do
+    describe '#content_type' do
+      it 'gets the content_type' do
         expect(driven_request.content_type).to eq('text/plain')
       end
 
-      it "gets multipart content_type" do
-        request = Net::HTTP::Put::Multipart.new("/resource.xml?foo=bar&bar=foo",
-          'file' => UploadIO.new(File.new('spec/fixtures/upload.png'), 'image/png', 'upload.png'))
+      it 'gets multipart content_type' do
+        request = Net::HTTP::Put::Multipart.new('/resource.xml?foo=bar&bar=foo',
+                                                'file' => UploadIO.new(File.new('spec/fixtures/upload.png'), 'image/png', 'upload.png'))
         driven_request = ApiAuth::RequestDrivers::NetHttpRequest.new(request)
         expect(driven_request.content_type).to match 'multipart/form-data; boundary='
       end
     end
 
-    it "gets the content_md5" do
+    it 'gets the content_md5' do
       expect(driven_request.content_md5).to eq('1B2M2Y8AsgTpgAmY7PhCfg==')
     end
 
-    it "gets the request_uri" do
+    it 'gets the request_uri' do
       expect(driven_request.request_uri).to eq('/resource.xml?foo=bar&bar=foo')
     end
 
-    it "gets the timestamp" do
+    it 'gets the timestamp' do
       expect(driven_request.timestamp).to eq(timestamp)
     end
 
-    it "gets the authorization_header" do
+    it 'gets the authorization_header' do
       expect(driven_request.authorization_header).to eq('APIAuth 1044:12345')
     end
 
-    describe "#calculated_md5" do
-      it "calculates md5 from the body" do
+    describe '#calculated_md5' do
+      it 'calculates md5 from the body' do
         expect(driven_request.calculated_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
       end
 
-      it "treats no body as empty string" do
+      it 'treats no body as empty string' do
         request.body = nil
         expect(driven_request.calculated_md5).to eq('1B2M2Y8AsgTpgAmY7PhCfg==')
       end
 
-      it "calculates correctly for multipart content" do
+      it 'calculates correctly for multipart content' do
         request.body = nil
         request.body_stream = File.new('spec/fixtures/upload.png')
         expect(driven_request.calculated_md5).to eq('k4U8MTA3RHDcewBzymVNEQ==')
       end
     end
 
-    describe "http_method" do
-      context "when put request" do
-        let(:request){ Net::HTTP::Put.new(request_path, request_headers) }
+    describe 'http_method' do
+      context 'when put request' do
+        let(:request) { Net::HTTP::Put.new(request_path, request_headers) }
 
-        it "returns upcased put" do
+        it 'returns upcased put' do
           expect(driven_request.http_method).to eq('PUT')
         end
       end
 
-      context "when get request" do
-        let(:request){ Net::HTTP::Get.new(request_path, request_headers) }
+      context 'when get request' do
+        let(:request) { Net::HTTP::Get.new(request_path, request_headers) }
 
-        it "returns upcased get" do
+        it 'returns upcased get' do
           expect(driven_request.http_method).to eq('GET')
         end
       end
     end
   end
 
-  describe "setting headers correctly" do
-    let(:request_headers){
+  describe 'setting headers correctly' do
+    let(:request_headers) do
       {
         'content-type' => 'text/plain'
       }
-    }
+    end
 
     let(:request) do
       Net::HTTP::Put.new(request_path, request_headers)
     end
 
-    describe "#populate_content_md5" do
-      context "when request type has no body" do
+    describe '#populate_content_md5' do
+      context 'when request type has no body' do
         let(:request) do
           Net::HTTP::Get.new(request_path, request_headers)
         end
 
         it "doesn't populate content-md5" do
           driven_request.populate_content_md5
-          expect(request["Content-MD5"]).to be_nil
+          expect(request['Content-MD5']).to be_nil
         end
       end
 
-      context "when request type has a body" do
+      context 'when request type has a body' do
         let(:request) do
           net_http_request = Net::HTTP::Put.new(request_path, request_headers)
           net_http_request.body = "hello\nworld"
           net_http_request
         end
 
-        it "populates content-md5" do
+        it 'populates content-md5' do
           driven_request.populate_content_md5
-          expect(request["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          expect(request['Content-MD5']).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
 
-        it "refreshes the cached headers" do
+        it 'refreshes the cached headers' do
           driven_request.populate_content_md5
           expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
       end
     end
 
-    describe "#set_date" do
+    describe '#set_date' do
       before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
       end
 
-      it "sets the date header of the request" do
+      it 'sets the date header of the request' do
         driven_request.set_date
         expect(request['DATE']).to eq(timestamp)
       end
 
-      it "refreshes the cached headers" do
+      it 'refreshes the cached headers' do
         driven_request.set_date
         expect(driven_request.timestamp).to eq(timestamp)
       end
     end
 
-    describe "#set_auth_header" do
-      it "sets the auth header" do
+    describe '#set_auth_header' do
+      it 'sets the auth header' do
         driven_request.set_auth_header('APIAuth 1044:54321')
         expect(request['Authorization']).to eq('APIAuth 1044:54321')
       end
     end
   end
 
-  describe "md5_mismatch?" do
-    context "when request type has no body" do
+  describe 'md5_mismatch?' do
+    context 'when request type has no body' do
       let(:request) do
         Net::HTTP::Get.new(request_path, request_headers)
       end
 
-
-      it "is false" do
+      it 'is false' do
         expect(driven_request.md5_mismatch?).to be false
       end
     end
 
-    context "when request type has a body" do
+    context 'when request type has a body' do
       let(:request) do
         net_http_request = Net::HTTP::Put.new(request_path, request_headers)
         net_http_request.body = "hello\nworld"
         net_http_request
       end
 
-      context "when calculated matches sent" do
+      context 'when calculated matches sent' do
         before do
-          request["Content-MD5"] = 'kZXQvrKoieG+Be1rsZVINw=='
+          request['Content-MD5'] = 'kZXQvrKoieG+Be1rsZVINw=='
         end
 
-        it "is false" do
+        it 'is false' do
           expect(driven_request.md5_mismatch?).to be false
         end
       end
 
       context "when calculated doesn't match sent" do
         before do
-          request["Content-MD5"] = "3"
+          request['Content-MD5'] = '3'
         end
 
-        it "is true" do
+        it 'is true' do
           expect(driven_request.md5_mismatch?).to be true
         end
       end

data/spec/request_drivers/rack_spec.rb

@@ -1,19 +1,18 @@
 require 'spec_helper'
 
 describe ApiAuth::RequestDrivers::RackRequest do
+  let(:timestamp) { Time.now.utc.httpdate }
 
-  let(:timestamp){ Time.now.utc.httpdate }
+  let(:request_path) { '/resource.xml?foo=bar&bar=foo' }
 
-  let(:request_path){ "/resource.xml?foo=bar&bar=foo" }
-
-  let(:request_headers){
+  let(:request_headers) do
     {
-      'Authorization'  => 'APIAuth 1044:12345',
+      'Authorization' => 'APIAuth 1044:12345',
       'Content-MD5' => '1B2M2Y8AsgTpgAmY7PhCfg==',
       'Content-Type' => 'text/plain',
       'Date' => timestamp
     }
-  }
+  end
 
   let(:request) do
     Rack::Request.new(
@@ -25,35 +24,35 @@ describe ApiAuth::RequestDrivers::RackRequest do
     )
   end
 
-  subject(:driven_request){ ApiAuth::RequestDrivers::RackRequest.new(request) }
+  subject(:driven_request) { ApiAuth::RequestDrivers::RackRequest.new(request) }
 
-  describe "getting headers correctly" do
-    it "gets the content_type" do
+  describe 'getting headers correctly' do
+    it 'gets the content_type' do
       expect(driven_request.content_type).to eq('text/plain')
     end
 
-    it "gets the content_md5" do
+    it 'gets the content_md5' do
       expect(driven_request.content_md5).to eq('1B2M2Y8AsgTpgAmY7PhCfg==')
     end
 
-    it "gets the request_uri" do
+    it 'gets the request_uri' do
       expect(driven_request.request_uri).to eq('/resource.xml?foo=bar&bar=foo')
     end
 
-    it "gets the timestamp" do
+    it 'gets the timestamp' do
       expect(driven_request.timestamp).to eq(timestamp)
     end
 
-    it "gets the authorization_header" do
+    it 'gets the authorization_header' do
       expect(driven_request.authorization_header).to eq('APIAuth 1044:12345')
     end
 
-    describe "#calculated_md5" do
-      it "calculates md5 from the body" do
+    describe '#calculated_md5' do
+      it 'calculates md5 from the body' do
         expect(driven_request.calculated_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
       end
 
-      it "treats no body as empty string" do
+      it 'treats no body as empty string' do
         request = Rack::Request.new(
           Rack::MockRequest.env_for(
             request_path,
@@ -65,8 +64,8 @@ describe ApiAuth::RequestDrivers::RackRequest do
       end
     end
 
-    describe "http_method" do
-      context "when put request" do
+    describe 'http_method' do
+      context 'when put request' do
         let(:request) do
           Rack::Request.new(
             Rack::MockRequest.env_for(
@@ -76,12 +75,12 @@ describe ApiAuth::RequestDrivers::RackRequest do
           )
         end
 
-        it "returns upcased put" do
+        it 'returns upcased put' do
           expect(driven_request.http_method).to eq('PUT')
         end
       end
 
-      context "when get request" do
+      context 'when get request' do
         let(:request) do
           Rack::Request.new(
             Rack::MockRequest.env_for(
@@ -91,22 +90,22 @@ describe ApiAuth::RequestDrivers::RackRequest do
           )
         end
 
-        it "returns upcased get" do
+        it 'returns upcased get' do
           expect(driven_request.http_method).to eq('GET')
         end
       end
     end
   end
 
-  describe "setting headers correctly" do
-    let(:request_headers){
+  describe 'setting headers correctly' do
+    let(:request_headers) do
       {
         'content-type' => 'text/plain'
       }
-    }
+    end
 
-    describe "#populate_content_md5" do
-      context "when getting" do
+    describe '#populate_content_md5' do
+      context 'when getting' do
         let(:request) do
           Rack::Request.new(
             Rack::MockRequest.env_for(
@@ -118,11 +117,11 @@ describe ApiAuth::RequestDrivers::RackRequest do
 
         it "doesn't populate content-md5" do
           driven_request.populate_content_md5
-          expect(request.env["Content-MD5"]).to be_nil
+          expect(request.env['Content-MD5']).to be_nil
         end
       end
 
-      context "when posting" do
+      context 'when posting' do
         let(:request) do
           Rack::Request.new(
             Rack::MockRequest.env_for(
@@ -133,18 +132,18 @@ describe ApiAuth::RequestDrivers::RackRequest do
           )
         end
 
-        it "populates content-md5" do
+        it 'populates content-md5' do
           driven_request.populate_content_md5
-          expect(request.env["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          expect(request.env['Content-MD5']).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
 
-        it "refreshes the cached headers" do
+        it 'refreshes the cached headers' do
           driven_request.populate_content_md5
           expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
       end
 
-      context "when putting" do
+      context 'when putting' do
         let(:request) do
           Rack::Request.new(
             Rack::MockRequest.env_for(
@@ -155,18 +154,18 @@ describe ApiAuth::RequestDrivers::RackRequest do
           )
         end
 
-        it "populates content-md5" do
+        it 'populates content-md5' do
           driven_request.populate_content_md5
-          expect(request.env["Content-MD5"]).to eq('kZXQvrKoieG+Be1rsZVINw==')
+          expect(request.env['Content-MD5']).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
 
-        it "refreshes the cached headers" do
+        it 'refreshes the cached headers' do
           driven_request.populate_content_md5
           expect(driven_request.content_md5).to eq('kZXQvrKoieG+Be1rsZVINw==')
         end
       end
 
-      context "when deleting" do
+      context 'when deleting' do
         let(:request) do
           Rack::Request.new(
             Rack::MockRequest.env_for(
@@ -178,38 +177,37 @@ describe ApiAuth::RequestDrivers::RackRequest do
 
         it "doesn't populate content-md5" do
           driven_request.populate_content_md5
-          expect(request.env["Content-MD5"]).to be_nil
+          expect(request.env['Content-MD5']).to be_nil
         end
       end
-
     end
 
-    describe "#set_date" do
+    describe '#set_date' do
       before do
         allow(Time).to receive_message_chain(:now, :utc, :httpdate).and_return(timestamp)
       end
 
-      it "sets the date header of the request" do
+      it 'sets the date header of the request' do
         driven_request.set_date
         expect(request.env['DATE']).to eq(timestamp)
       end
 
-      it "refreshes the cached headers" do
+      it 'refreshes the cached headers' do
         driven_request.set_date
         expect(driven_request.timestamp).to eq(timestamp)
       end
     end
 
-    describe "#set_auth_header" do
-      it "sets the auth header" do
+    describe '#set_auth_header' do
+      it 'sets the auth header' do
         driven_request.set_auth_header('APIAuth 1044:54321')
         expect(request.env['Authorization']).to eq('APIAuth 1044:54321')
       end
     end
   end
 
-  describe "md5_mismatch?" do
-    context "when getting" do
+  describe 'md5_mismatch?' do
+    context 'when getting' do
       let(:request) do
         Rack::Request.new(
           Rack::MockRequest.env_for(
@@ -219,12 +217,12 @@ describe ApiAuth::RequestDrivers::RackRequest do
         )
       end
 
-      it "is false" do
+      it 'is false' do
         expect(driven_request.md5_mismatch?).to be false
       end
     end
 
-    context "when posting" do
+    context 'when posting' do
       let(:request) do
         Rack::Request.new(
           Rack::MockRequest.env_for(
@@ -235,28 +233,28 @@ describe ApiAuth::RequestDrivers::RackRequest do
         )
       end
 
-      context "when calculated matches sent" do
+      context 'when calculated matches sent' do
         before do
-          request.env["Content-MD5"] = 'kZXQvrKoieG+Be1rsZVINw=='
+          request.env['Content-MD5'] = 'kZXQvrKoieG+Be1rsZVINw=='
         end
 
-        it "is false" do
+        it 'is false' do
           expect(driven_request.md5_mismatch?).to be false
         end
       end
 
       context "when calculated doesn't match sent" do
         before do
-          request.env["Content-MD5"] = "3"
+          request.env['Content-MD5'] = '3'
         end
 
-        it "is true" do
+        it 'is true' do
           expect(driven_request.md5_mismatch?).to be true
         end
       end
     end
 
-    context "when putting" do
+    context 'when putting' do
       let(:request) do
         Rack::Request.new(
           Rack::MockRequest.env_for(
@@ -267,28 +265,28 @@ describe ApiAuth::RequestDrivers::RackRequest do
         )
       end
 
-      context "when calculated matches sent" do
+      context 'when calculated matches sent' do
         before do
-          request.env["Content-MD5"] = 'kZXQvrKoieG+Be1rsZVINw=='
+          request.env['Content-MD5'] = 'kZXQvrKoieG+Be1rsZVINw=='
         end
 
-        it "is false" do
+        it 'is false' do
           expect(driven_request.md5_mismatch?).to be false
         end
       end
 
       context "when calculated doesn't match sent" do
         before do
-          request.env["Content-MD5"] = "3"
+          request.env['Content-MD5'] = '3'
         end
 
-        it "is true" do
+        it 'is true' do
           expect(driven_request.md5_mismatch?).to be true
         end
       end
     end
 
-    context "when deleting" do
+    context 'when deleting' do
       let(:request) do
         Rack::Request.new(
           Rack::MockRequest.env_for(
@@ -298,7 +296,7 @@ describe ApiAuth::RequestDrivers::RackRequest do
         )
       end
 
-      it "is false" do
+      it 'is false' do
         expect(driven_request.md5_mismatch?).to be false
       end
     end