alexandria-book-collection-manager 0.7.8 → 0.7.9

data/share/gnome/help/alexandria/fr/alexandria.xml

@@ -165,27 +165,6 @@ Date : 30 décembre 2005
       		<!--retrieves and displays book information (including cover pictures) from online libraries:-->
       		</para>
 				<itemizedlist>
-					<listitem>
-						<para>
-							<orgname>Amazon</orgname> (.com, .co.uk, .de et .jp)&nbsp;;
-						</para>
-					</listitem>
-					<listitem>
-						<para>
-							<orgname>Proxis</orgname>&nbsp;;
-						</para>
-					</listitem>
-					<listitem>
-						<para>
-							<orgname>Barnes and Noble</orgname>&nbsp;;
-						</para>
-					</listitem> 
-					<listitem>
-						<para>
-							<orgname>Ministère de la Culture espagnole</orgname>&nbsp;;
-							<!--the Spanish Ministry of Culture-->
-						</para>
-					</listitem>
 					<listitem>
 						<para>
 							<orgname>Amadeus Buch</orgname>&nbsp;;
@@ -618,15 +597,14 @@ Date : 30 décembre 2005
 			ajouter, vous pouvez rechercher par le titre, 
 			les auteurs ou des mots clés.
 			&app; recherche les livres qui correspondent aux critères définis
-			à partir de fournisseurs d&#8217;informations en ligne tel 
-			qu&#8217;<ulink url="http://www.amazon.fr">Amazon</ulink>.
+			à partir de fournisseurs d&#8217;informations en ligne.
 			Vous pouvez ensuite sélectionner le livre désiré à partir de la liste
 			affichée et cliquer sur le bouton 
 			<guibutton>A<accel>j</accel>outer</guibutton> pour
 			l&#8217;intégrer à votre bibliothèque.
 			<!--If you do not know the ISBN of the book you wish to add, you can specify
 			either the Title, the Authors or the Keywords, and &app; will search
-			your online information provider, such as Amazon, for books that match.
+			your online information provider for books that match.
 			You can then select the desired book from the displayed list and
 			click <guibutton>Add</guibutton> to the book to the selected library.-->
 		</para>
@@ -1610,55 +1588,21 @@ Date : 30 décembre 2005
 		</title>
 		<para>
 			Pour trouver plus d&#8217;informations au sujet de vos livres, vous
-			pouvez utiliser &app; pour ouvrir une page web sur 
-			<orgname>Amazon</orgname>, <orgname>Barnes and Noble</orgname>
-			ou chez l&#8217;un des autres fournisseurs d&#8217;informations en ligne
+			pouvez utiliser &app; pour ouvrir une page web
+			chez l&#8217;un des fournisseurs d&#8217;informations en ligne
 			et être dirigé directement à la page du livre concerné.
 			Pour cela, sélectionnez le livre, cliquez dessus avec le bouton 
 			<mousebutton>droit</mousebutton> de la souris,
 			et à partir du menu contextuel choisissez
 			<guimenu>Afficher les <accel>i</accel>nformations en ligne</guimenu>
 			puis sélectionnez le fournisseur dans la liste présentée.
-			<!--If you want to find out more information about your book, you 
-			can use &app; to open the web page of Amazon, Barnes and Noble, 
-			or one of the other online information providers and be 
-			taken directly to the relevant book. Simply select the book you 
-			wish to know more about, right-click on it, and from the menu 
-			<guimenuitem>Display Online Information</guimenuitem>, choose 
-			from either Amazon, Barnes and Nobel, Proxis, 
-			Spanish Culture Ministry, Amadeus Buch, or 
-			Internet Bookshop Italia.-->
 		</para>
-		<tip>
-			<para>
-				Le menu
-				<menuchoice>
-				<guimenu>Afficher les <accel>i</accel>nformations en ligne</guimenu>
-				<guimenuitem>Sur <accel>A</accel>mazon</guimenuitem>
-				</menuchoice>
-				vous envoie sur le site d&#8217;<orgname>Amazon</orgname> .com, 
-				.ca, .co.uk, .de, .fr, ou .jp en fonction de votre 
-				configuration pour ce fournisseur (voir 
-				<xref linkend="alexandria-amazon-prefs"/>).
-				<!--The 
-				<menuchoice>
-				<guimenu>Display Online Information</guimenu>
-				<guimenuitem>At Amazon</guimenuitem>
-				</menuchoice> 
-				choice will take you to the Amazon .com, .co.uk, .de, or jp 
-				site, as set up in the 
-				<xref linkend="alexandria-amazon-prefs"/>.-->
-			</para>
-		</tip>
 		<caution>
 			<para>
 				Les sources d&#8217;informations en ligne n&#8217;ont pas une liste
 				complète de livres et il est possible que vous deviez
 				essayer plusieurs fournisseurs pour trouver
 				l&#8217;information recherchée.
-				<!--Not every online information source has a complete list of 
-				books and you may have to try several different providers 
-				to find the information you want.-->
 			</para>
 		</caution>
 	</sect2>
@@ -1964,35 +1908,7 @@ Date : 30 décembre 2005
       	en déplaçant chaque source en utilisant
       	les boutons <guibutton><accel>V</accel>ers le haut</guibutton>
       	ou <guibutton><accel>V</accel>ers le bas</guibutton>.
-      	<!--&app; can download information from a variety of different 
-      	online sources; some of these sources have additional options 
-      	to control how the information is downloaded. &app; will 
-      	search each of the sources in turn, in the order displayed in 
-      	the list. You can change the order in which the sources are 
-      	searched by moving each source up or down using the 
-      	<guibutton>Up</guibutton> and <guibutton>Down</guibutton> buttons.-->
 			<itemizedlist>
-				<listitem>
-					<para>
-						<xref linkend="alexandria-amazon-prefs"/>&nbsp;;
-					</para>
-				</listitem>
-				<listitem>
-					<para>
-						<xref linkend="alexandria-proxis-prefs"/>&nbsp;;
-					</para>
-				</listitem>
-				<listitem>
-					<para>
-						Ministère de la Culture espagnol&nbsp;;
-						<!--The Spanish Culture Ministry-->
-					</para>
-				</listitem>
-				<listitem>
-					<para>
-						Barnes and Noble&nbsp;;
-					</para>
-				</listitem>
 				<listitem>
 					<para>
 						Amadeus Buch&nbsp;;
@@ -2035,77 +1951,6 @@ Date : 30 décembre 2005
 		</para>
 
 
-      <sect3 id="alexandria-amazon-prefs">
-        	<title>
-        		Préférences pour <orgname>Amazon</orgname>
-        		<!-- Amazon preferences-->
-        	</title>
-        	<para>
-        		&app; peut télécharger les informations d&#8217;un livre à partir
-        		de différents sites web d&#8217;<orgname>Amazon</orgname>. 
-        		Les sites actuellement supportés sont&nbsp;:
-        		amazon.com (us), .ca, .co.uk (uk), .de, .fr et .jp.
-        		Pour changer le site utilisé, sélectionnez 
-        		<guilabel>Amazon</guilabel> à partir de la liste des 
-        		fournisseurs et cliquez sur 
-        		<guibutton><accel>C</accel>onfigurer</guibutton>.
-        		Ensuite choisissez dans le menu déroulant 
-        		<guilabel><accel>L</accel>angue</guilabel> le site 
-        		qui vous convient.
-        		<!--&app; can download book information from different amazon 
-        		websites - currently, amazon.com, .co.uk, .de and .jp. 
-        		To change which site to use, select Amazon from the 
-        		Provider list, and click on <guibutton>Setup</guibutton>. 
-        		Then choose either <guilabel>UK, DE, JP</guilabel> or 
-        		<guilabel>US</guilabel> from the drop-down menu.-->
-        	</para>
-	  	
-	  		<warning>
-				<para>
-					<guilabel><accel>J</accel>eton de développeur</guilabel>
-					et <guilabel><accel>I</accel>dentifiant d&#8217;associé</guilabel>
-					peuvent être changés si vous avez un compte de service web
-					d&#8217;<orgname>Amazon</orgname>. Vous pouvez obtenir
-					un compte à l&#8217;adresse 
-					<ulink url="https://aws-portal.amazon.com/gp/aws/developer/registration/index.html/002-9602971-5248069">aws-portal.amazon.com</ulink>.
-					Si vous ne savez pas ce que cela signifie, alors vous pouvez 
-					laisser ces champs tels quels.
-					<!--The <guilabel>Development token</guilabel> and 
-					<guilabel>Associate ID</guilabel> can be changed if you 
-					have an amazon web services account. You sign for an 
-					Amazon Web Services account at 
-					<ulink url="https://aws-portal.amazon.com/gp/aws/developer/registration/index.html/002-9602971-5248069">aws-portal.amazon.com</ulink>. 
-					If you don&#8217;t know what this means, then you can leave 
-					these values alone.-->
-				</para>
-			</warning>
-      </sect3>
-
-
-      <sect3 id="alexandria-proxis-prefs">
-        	<title>
-        		Préférences <orgname>Proxis</orgname>
-        		<!--Proxis preferences-->
-        	</title>
-        	<para>
-        		&app; peut chercher dans le site web de 
-        		<orgname>Proxis</orgname> pour des livres en 
-        		anglais (en), français (fr) ou néerlandais (nl). Pour changer
-        		la langue utilisée, sélectionnez <guilabel>Proxis</guilabel>
-        		dans la liste 
-        		<guilabel><accel>F</accel>ournisseurs</guilabel> et cliquez
-        		sur <guibutton><accel>C</accel>onfigurer</guibutton>.
-        		Ensuite, sélectionnez la langue dans le menu déroulant
-        		<guilabel><accel>L</accel>angue</guilabel>.
-        		<!--&app; can search the Proxis website for books in either 
-        		English, French or Dutch. To change which language to use, 
-        		select Proxis from the Provider list, and click on 
-        		<guibutton>Setup</guibutton>. Then chose either 
-        		<guilabel>en, fr</guilabel> or <guilabel>nl</guilabel> from 
-        		the drop-down menu.-->
-        	</para>
-      </sect3>
-	  
 	  <sect3 id="alexandria-britlib-prefs">
 		  	<title>
 		  		Préférences <orgname>Bibliothèque Britannique</orgname>

data/share/gnome/help/alexandria/ja/adding-books.xml

@@ -101,7 +101,7 @@
     
     <para>
 追加したい本のISBNが分からない場合には、本のタイトルや作者、キーワードを入力すると、
-&app; はAmazonなどのオンライン情報のプロバイダーから本を検索します。
+&app; はオンライン情報のプロバイダーから本を検索します。
 リストに表示された検索結果から追加したい本を選択し、<guibutton>追加</guibutton>
 のボタンを押して選択したライブラリに本を追加できます。</para>
     

data/share/gnome/help/alexandria/ja/introduction.xml

@@ -21,21 +21,6 @@
 	  オンラインの図書館や書店から本の情報（や本の表紙）を検索して表示できます。
 	  例として、
 	  <itemizedlist>
-	    <listitem>
-	      <para>
-		<ulink url="http://www.amazon.com">Amazon</ulink>
-		（amazon.comの他に .co.uk, .fr, .de, .ja, .caのウェブサイトを検索できます）
-	      </para>
-	    </listitem>
-	    
-	    <listitem>
-	      <para><ulink url="http://www.proxis.be">Proxis</ulink></para>
-	    </listitem>
-	    
-	    <listitem>
-	      <para><ulink url="http://www.barnesandnoble.com">Barnes and Noble</ulink></para>
-	    </listitem>
-
 	    <listitem>
 	      <para><ulink url="http://www.thalia.de">Thalia</ulink></para>
 	    </listitem>

data/share/gnome/help/alexandria/ja/searching.xml

@@ -87,15 +87,11 @@
   <!-- ========= Finding out more online =========== -->
   <section id="searching-more-online">
     <title>オンラインで本に関する詳細な情報を探すには</title>
-    <para>もし本について詳細な情報を知りたければ、&app; はAmazonやBarnes and Noble
-などのオンライン情報プロバイダーのウェブページを開いて、その本に関する情報を直接得ることが
+    <para>もし本について詳細な情報を知りたければ、&app; は
+オンライン情報プロバイダーのウェブページを開いて、その本に関する情報を直接得ることが
 出来ます。より詳しく知りたい本を選択して右クリックし、
-<guimenuitem>オンライン情報の表示</guimenuitem>を選択して、Amazonなどのプロバイダーを
+<guimenuitem>オンライン情報の表示</guimenuitem>を選択して、プロバイダーを
 選択してください。</para>
-    <tip>
-      <para><menuchoice><guimenu>オンライン情報の表示</guimenu><guimenuitem>Amazon</guimenuitem></menuchoice>を選択した時は、<xref linkend="alexandria-amazon-prefs"/>で
-設定した amazon.com, co.uk, .de, .jpのいずれかのサイトが選択されます。</para>
-    </tip>
     <caution>
       <para>すべてのオンライン情報源が、本に関する完璧な情報を持っているわけではありません。
 欲しい情報を得るために、別のプロバイダーをいくつか試す必要があるかもしれません。</para>

data/share/gnome/help/alexandria/ja/settings.xml

@@ -37,10 +37,7 @@
 <guibutton>上へ</guibutton>と<guibutton>下へ</guibutton>のボタンを使って
 検索する情報源の順番を変えることができます。
     <itemizedlist>
-      <listitem><para><xref linkend="alexandria-amazon-prefs"/></para></listitem>
-      <listitem><para><xref linkend="alexandria-proxis-prefs"/></para></listitem>
       <listitem><para>スペイン文化省</para></listitem>
-      <listitem><para>Barnes and Noble</para></listitem>
       <listitem><para>Amadeus Buch</para></listitem>
       <listitem><para>Internet Bookshop Italia</para></listitem>
       <listitem><para><xref linkend="alexandria-britlib-prefs"/></para></listitem>
@@ -55,30 +52,6 @@
     </para>
 
 
-    <sect3 id="alexandria-amazon-prefs">
-      <title>Amazonの設定</title>
-      <para>&app; はいくつかの異なるAmazonのサイトから本の情報をダウンロード出来ます。
-現時点では、amazon.com, .co.uk, .de, .jp, .fr, .ca です。使用するサイトを
-変更するには、プロバイダーの一覧からAmazonを選択し、<guibutton>セットアップ</guibutton>
-をクリックします。次にドロップダウンメニューから<guilabel>UK, DE, JP, FR, CA, US</guilabel>
-のいずれかを選択します。</para>
-      <warning>
-	<para><guilabel>デベロッパートークン</guilabel>と <guilabel>アソシエイトID</guilabel>は、もしあなたがAmazonのウェブサービスアカウントを持っていればそれに変更できます。
- <ulink url="https://aws-portal.amazon.com/gp/aws/developer/registration/index.html/002-9602971-5248069">aws-portal.amazon.com</ulink>でAmazon
-ウェブサービスアカウントのサインアップをしてください。もしこの意味が分からなければ、
-変更せずにデフォルトのままにしておいてください。</para>
-      </warning>
-    </sect3>
-
-
-    <sect3 id="alexandria-proxis-prefs">
-      <title>Proxisの設定</title>
-      <para>&app; は Proxisのウェブサイトで英語またはフランス語、またはオランダ語で
-本を検索できます。どの言語で検索するかを選択するには、プロバイダーの一覧からProxisを
-選択し、<guibutton>セットアップ</guibutton>をクリックします。次にドロップダウンメニュー
-から<guilabel>en, fr, nl</guilabel>のいずれかを選択します。</para>
-    </sect3>
-    
     <sect3 id="alexandria-britlib-prefs">
       <title>大英図書館の設定</title>
       <para>大英図書館のアカウントを持っているなら、ダイアログでz39.50サービス用の

data/spec/alexandria/book_providers/bl_provider_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require "spec_helper"
+
+describe Alexandria::BookProviders::BLProvider do
+  it "works" do
+    assert_correct_search_result(described_class, "9781853260803")
+  end
+end

data/spec/alexandria/book_providers/loc_provider_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require "spec_helper"
+
+describe Alexandria::BookProviders::LOCProvider do
+  it "works for a book with ASCII title" do
+    assert_correct_search_result(described_class, "9780805335583")
+  end
+
+  it "works for a book with a title with non-ASCII letters" do
+    assert_correct_search_result(described_class, "9782070379248")
+  end
+end

data/spec/alexandria/book_providers/sbn_provider_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require "spec_helper"
+
+describe Alexandria::BookProviders::SBNProvider do
+  it "works" do
+    assert_correct_search_result(described_class, "9788835926436")
+  end
+end

data/spec/alexandria/book_providers_spec.rb

@@ -8,85 +8,4 @@ require "spec_helper"
 
 describe Alexandria::BookProviders do
   it "should be less clever"
-
-  describe Alexandria::BookProviders::AmazonProvider do
-    before do
-      skip "Amazon requires an API key. Remove it altogether as a provider?"
-    end
-
-    it "does not piss off Rich Burridge" do
-      assert_correct_search_result(described_class, "033025068X")
-    end
-
-    it "works" do
-      assert_correct_search_result(described_class, "9780385504201")
-    end
-
-    it "works when searching for title" do
-      assert_correct_search_result(described_class, "A Confederacy of Dunces",
-                                   Alexandria::BookProviders::SEARCH_BY_TITLE)
-    end
-
-    it "amazon authors should work" do
-      assert_correct_search_result(described_class, "John Kennedy Toole",
-                                   Alexandria::BookProviders::SEARCH_BY_AUTHORS)
-    end
-
-    it "amazon keyword should work" do
-      assert_correct_search_result(described_class, "Confederacy Dunces",
-                                   Alexandria::BookProviders::SEARCH_BY_KEYWORD)
-    end
-  end
-
-  describe Alexandria::BookProviders::LOCProvider do
-    it "works for a book with ASCII title" do
-      assert_correct_search_result(described_class, "9780805335583")
-    end
-
-    it "works for a book with a title with non-ASCII letters" do
-      assert_correct_search_result(described_class, "9782070379248")
-    end
-  end
-
-  describe Alexandria::BookProviders::BLProvider do
-    it "works" do
-      skip "Not working: connect failed"
-      assert_correct_search_result(described_class, "9781853260803")
-    end
-  end
-
-  describe Alexandria::BookProviders::SBNProvider do
-    it "works" do
-      assert_correct_search_result(described_class, "9788835926436")
-    end
-  end
-
-  describe Alexandria::BookProviders::BarnesAndNobleProvider do
-    it "works" do
-      skip "Barnes and Noble is not operational at the moment"
-      assert_correct_search_result(described_class, "9780961328917") # see #1433
-    end
-  end
-
-  describe Alexandria::BookProviders::ProxisProvider do
-    it "works" do
-      skip "Needs fixing"
-      assert_correct_search_result(described_class, "9789026965746")
-      assert_correct_search_result(described_class, "9780586071403")
-    end
-  end
-
-  describe Alexandria::BookProviders::AdLibrisProvider do
-    it "works" do
-      skip "Needs fixing: site has changed"
-      assert_correct_search_result(described_class, "9789100109332")
-    end
-  end
-
-  describe Alexandria::BookProviders::SicilianoProvider do
-    it "works" do
-      skip "Needs fixing: no results found"
-      assert_correct_search_result(described_class, "9788599170380")
-    end
-  end
 end

data/spec/alexandria/library_spec.rb

@@ -150,7 +150,7 @@ describe Alexandria::Library do
       # Guide to LaTeX
       latex_book = my_library.find { |b| b.title.include? "Latex" }
       expect(latex_book.isbn).to eq("9780201398250")
-      expect(latex_book.publisher).to eq("Addison Wesley") # note, no Ruby-Amazon cruft
+      expect(latex_book.publisher).to eq("Addison Wesley")
     end
   end
 
@@ -176,7 +176,7 @@ describe Alexandria::Library do
       # Guide to LaTeX
       latex_book = my_library.find { |b| b.title.include? "Latex" }
       expect(latex_book.isbn).to eq("9780201398250")
-      expect(latex_book.publisher).to eq("Addison Wesley") # note, no Ruby-Amazon cruft
+      expect(latex_book.publisher).to eq("Addison Wesley")
       expect(latex_book.version).to eq(Alexandria::DATA_VERSION)
     end
 
@@ -231,4 +231,22 @@ describe Alexandria::Library do
       end
     end
   end
+
+  describe "#name=" do
+    let(:my_library) { loader.load_library("Empty") }
+
+    before do
+      FileUtils.mkdir(TESTDIR) unless File.exist? TESTDIR
+    end
+
+    it "changes the library's name" do
+      my_library.name = "Really Empty"
+      expect(my_library.name).to eq "Really Empty"
+    end
+
+    it "moves the library's directory" do
+      my_library.name = "Really Empty"
+      expect(File.exist?(File.join(TESTDIR, "Really Empty"))).to be_truthy
+    end
+  end
 end

data/spec/alexandria/ui/import_dialog_spec.rb

@@ -32,7 +32,7 @@ describe Alexandria::UI::ImportDialog do
 
     it "works when response is cancel" do
       allow(chooser).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
-      import_dialog.acquire {}
+      import_dialog.acquire { nil }
     end
 
     it "works when response is OK" do

data/spec/alexandria/ui/new_smart_library_dialog_spec.rb

@@ -26,7 +26,7 @@ describe Alexandria::UI::NewSmartLibraryDialog do
       allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
 
       # Make sure entered rule is valid
-      rules_box = properties_dialog.instance_variable_get("@rules_box")
+      rules_box = properties_dialog.instance_variable_get(:@rules_box)
       entry = rules_box.children.first.children[2]
       entry.text = "foo"
 

data/spec/alexandria/ui/preferences_dialog_spec.rb

@@ -9,6 +9,6 @@ require_relative "../../spec_helper"
 describe Alexandria::UI::PreferencesDialog do
   it "works" do
     parent = Gtk::Window.new :toplevel
-    described_class.new(parent) {}
+    described_class.new(parent) { nil }
   end
 end

data/spec/alexandria/ui/ui_manager_spec.rb

@@ -16,7 +16,7 @@ describe Alexandria::UI::UIManager do
   describe "#on_new" do
     it "works" do
       ui = described_class.new main_app
-      libraries = ui.instance_variable_get("@libraries")
+      libraries = ui.instance_variable_get(:@libraries)
       libraries_count = libraries.all_libraries.count
       ui.on_new
       expect(libraries.all_libraries.count).to eq libraries_count + 1
@@ -26,7 +26,7 @@ describe Alexandria::UI::UIManager do
   describe "#on_books_selection_changed" do
     let(:lib_version) { File.join(LIBDIR, "0.6.2") }
     let(:ui) { described_class.new main_app }
-    let(:libraries) { ui.instance_variable_get("@libraries") }
+    let(:libraries) { ui.instance_variable_get(:@libraries) }
     let(:regular_library) { libraries.all_regular_libraries.last }
 
     before do
@@ -49,4 +49,80 @@ describe Alexandria::UI::UIManager do
       expect(ui.iconview.selected_items).not_to be_empty
     end
   end
+
+  describe "#select_a_book" do
+    let(:ui) { described_class.new main_app }
+    let(:libraries) { ui.instance_variable_get(:@libraries) }
+    let(:filter_entry) { ui.instance_variable_get(:@filter_entry) }
+    let(:regular_library) { libraries.all_regular_libraries.last }
+
+    before do
+      lib_version = File.join(LIBDIR, "0.6.2")
+      FileUtils.cp_r(lib_version, TESTDIR)
+
+      ui.select_a_library regular_library
+      # Make books appear in the view
+      regular_library.each { |book| ui.append_book book }
+    end
+
+    context "when selecting in the icon view" do
+      before do
+        # Make view model re-appear
+        ui.iconview.unfreeze
+      end
+
+      it "selects book if it is in view" do
+        ui.select_a_book regular_library.first
+
+        selected = ui.iconview.selected_items
+        expect(selected.count).to eq 1
+      end
+
+      it "selects nothing if book is not in view due to a filter" do
+        filter_entry.text = regular_library.last.title
+        ui.filtered_model.refilter
+
+        ui.select_a_book regular_library.first
+
+        selected = ui.iconview.selected_items
+        expect(selected.count).to eq 0
+      end
+    end
+
+    context "when selecting in the list view" do
+      before do
+        # Make view model re-appear
+        ui.listview.unfreeze
+      end
+
+      it "selects book if it is in view" do
+        ui.select_a_book regular_library.first
+
+        selected, _model = ui.listview.selection.selected_rows
+        expect(selected.count).to eq 1
+      end
+
+      it "selects nothing if book is not in view due to a filter" do
+        filter_entry.text = regular_library.last.title
+        ui.filtered_model.refilter
+
+        ui.select_a_book regular_library.first
+
+        selected = ui.listview.selection.to_a
+        expect(selected).to be_empty
+      end
+
+      it "selects nothing if a new book is not in view due to a filter" do
+        filter_entry.text = regular_library.last.title
+        ui.filtered_model.refilter
+
+        book = an_artist_of_the_floating_world
+        ui.append_book book
+        ui.select_a_book book
+
+        selected = ui.listview.selection.to_a
+        expect(selected).to be_empty
+      end
+    end
+  end
 end

data/spec/data/libraries/0.6.2/My Library/9780571147168.yaml

@@ -18,3 +18,5 @@ tags: []
 title: An Artist of the Floating World
 version: 0.6.2b1
 want: true
+library: !ruby/array:Alexandria:Library
+  internal: []

data/util/rake/fileinstall.rb

@@ -182,7 +182,7 @@ class FileInstallTask < Rake::TaskLib
     if @prefix == ruby_prefix
       @rubylib = ruby_libdir
     elsif ruby_libdir.index(ruby_prefix).zero?
-      libpart = ruby_libdir[ruby_prefix.size..-1]
+      libpart = ruby_libdir[ruby_prefix.size..]
       @rubylib = File.join(@prefix, libpart)
     else
       @rubylib = ruby_libdir
@@ -193,9 +193,9 @@ class FileInstallTask < Rake::TaskLib
     pathglob += "/" if pathglob.end_with?("**")
     real_parts = pathglob.split("**/")
     real_parts.each do |part|
-      part.gsub!(".", '\\.')
-      part.gsub!("*", '[^\\/]*')
-      part.gsub!("?", '[^\\/]')
+      part.gsub!(".", "\\.")
+      part.gsub!("*", "[^\\/]*")
+      part.gsub!("?", "[^\\/]")
     end
     pattern = real_parts.join("([^\/]+\/)*")
     /(#{pattern})/

data/util/rake/omfgenerate.rb

@@ -67,7 +67,7 @@ class OmfGenerateTask < Rake::TaskLib
     rule ".omf" => [".omf.in"] do |t|
       path = File.join(@gnome_helpfiles_dir, @projectname,
                        locale_for(t.name), "#{@projectname}.xml")
-      data = IO.read(t.source)
+      data = File.read(t.source)
       data.sub!(/PATH_TO_DOC_FILE/, path)
       puts "Generating #{t.name}..."
       File.open(t.name, "w") { |io| io.puts data }