alexandria-book-collection-manager 0.7.8 → 0.7.10

data/spec/alexandria/library_spec.rb

@@ -12,62 +12,71 @@ describe Alexandria::Library do
   describe "::EXT" do
     it "has symbolic references to file extensions" do
       extensions = Alexandria::Library::EXT
-      expect(extensions[:book]).not_to be_nil
-      expect(extensions[:cover]).not_to be_nil
+      aggregate_failures do
+        expect(extensions[:book]).not_to be_nil
+        expect(extensions[:cover]).not_to be_nil
+      end
     end
   end
 
   describe "#valid_isbn?" do
     it "returns a true value for valid isbns" do
       ["014143984X", "0-345-43192-8"].each do |x|
-        expect(described_class.valid_isbn?(x)).to be_truthy
+        expect(described_class.valid_isbn?(x)).to be true
       end
     end
   end
 
   describe "#valid_ean?" do
     it "returns a true value for valid EANs" do
-      expect(described_class.valid_ean?("9780345431929")).to be_truthy
-      expect(described_class.valid_ean?("978034543192912345")).to be_truthy
+      aggregate_failures do
+        expect(described_class.valid_ean?("9780345431929")).to be true
+        expect(described_class.valid_ean?("978034543192912345")).to be true
 
-      # Regression test: this EAN has a checksum of 10, which should be
-      # treated like a checksum of 0.
-      expect(described_class.valid_ean?("9784047041790")).to be_truthy
+        # Regression test: this EAN has a checksum of 10, which should be
+        # treated like a checksum of 0.
+        expect(described_class.valid_ean?("9784047041790")).to be true
+      end
     end
 
     it "returns a false value for invalid EANs" do
-      expect(described_class.valid_ean?("780345431929")).to be_falsey
-      expect(described_class.valid_ean?("97803454319290")).to be_falsey
-      expect(described_class.valid_ean?("97803454319291234")).to be_falsey
-      expect(described_class.valid_ean?("9780345431929123456")).to be_falsey
-      expect(described_class.valid_ean?("9780345431928")).to be_falsey
-      expect(described_class.valid_ean?("9780345431929A")).to be_falsey
+      invalid_eans = ["780345431929", "97803454319290", "97803454319291234",
+                      "9780345431929123456", "9780345431928", "9780345431929A",
+                      "9784047041791"]
 
-      expect(described_class.valid_ean?("9784047041791")).to be_falsey
+      aggregate_failures do
+        invalid_eans.each do |ean|
+          expect(described_class.valid_ean?(ean)).to be false
+        end
+      end
     end
   end
 
   describe "#valid_upc?" do
     it "returns a true value for valid UPCs" do
-      expect(described_class.valid_upc?("97803454319312356")).to be_truthy
+      expect(described_class.valid_upc?("97803454319312356")).to be true
     end
 
     it "returns a false value for invalid UPCs" do
-      expect(described_class.valid_upc?("978034543193123567")).to be_falsey
-      expect(described_class.valid_upc?("9780345431931235")).to be_falsey
+      aggregate_failures do
+        expect(described_class.valid_upc?("978034543193123567")).to be false
+        expect(described_class.valid_upc?("9780345431931235")).to be false
 
-      expect(described_class.valid_upc?("97803454319412356")).to be_falsey
-      expect(described_class.valid_upc?("97803454319212356")).to be_falsey
+        expect(described_class.valid_upc?("97803454319412356")).to be false
+        expect(described_class.valid_upc?("97803454319212356")).to be false
+      end
     end
   end
 
   describe "#canonicalise_isbn" do
     it "returns the correct value for several examples" do
-      expect(described_class.canonicalise_isbn("014143984X")).to eq "014143984X"
-      expect(described_class.canonicalise_isbn("0-345-43192-8")).to eq "0345431928"
-      expect(described_class.canonicalise_isbn("3522105907")).to eq "3522105907"
-      # EAN number
-      expect(described_class.canonicalise_isbn("9780345431929")).to eq "0345431928"
+      aggregate_failures do
+        expect(described_class.canonicalise_isbn("014143984X")).to eq "014143984X"
+        expect(described_class.canonicalise_isbn("0-345-43192-8")).to eq "0345431928"
+        expect(described_class.canonicalise_isbn("3522105907")).to eq "3522105907"
+        # EAN number
+        expect(described_class.canonicalise_isbn("9780345431929")).to eq "0345431928"
+      end
     end
   end
 
@@ -75,7 +84,7 @@ describe Alexandria::Library do
     let(:my_library) { loader.load_library("Empty") }
 
     before do
-      FileUtils.mkdir(TESTDIR) unless File.exist? TESTDIR
+      FileUtils.mkdir_p(TESTDIR)
     end
 
     it "disallows multiple deletion of the same copy of a book" do
@@ -136,21 +145,27 @@ describe Alexandria::Library do
     end
 
     it "can be loaded" do
-      expect(libs.size).to eq(1)
-      expect(my_library.size).to eq(3)
+      aggregate_failures do
+        expect(libs.size).to eq(1)
+        expect(my_library.size).to eq(3)
+      end
     end
 
-    it "imports cleanly from version 0.6.1 data format" do
-      # Malory
+    it "imports Malory book cleanly from version 0.6.1 data format" do
       malory_book = my_library.find { |b| b.isbn == "9780192812179" }
-      expect(malory_book.publisher).to eq("Oxford University Press")
-      expect(malory_book.authors.include?("Vinaver")).to be_truthy
-      expect(malory_book.version).to eq(Alexandria::DATA_VERSION)
+      aggregate_failures do
+        expect(malory_book.publisher).to eq("Oxford University Press")
+        expect(malory_book.authors).to include "Vinaver"
+        expect(malory_book.version).to eq(Alexandria::DATA_VERSION)
+      end
+    end
 
-      # Guide to LaTeX
+    it "imports Guide to LaTeX cleanly from version 0.6.1 data format" do
       latex_book = my_library.find { |b| b.title.include? "Latex" }
-      expect(latex_book.isbn).to eq("9780201398250")
-      expect(latex_book.publisher).to eq("Addison Wesley") # note, no Ruby-Amazon cruft
+      aggregate_failures do
+        expect(latex_book.isbn).to eq("9780201398250")
+        expect(latex_book.publisher).to eq("Addison Wesley")
+      end
     end
   end
 
@@ -168,16 +183,20 @@ describe Alexandria::Library do
     end
 
     it "can be loaded" do
-      expect(libs.size).to eq(1)
-      expect(my_library.size).to eq(2)
+      aggregate_failures do
+        expect(libs.size).to eq(1)
+        expect(my_library.size).to eq(2)
+      end
     end
 
     it "loads a book with ISBN" do
       # Guide to LaTeX
       latex_book = my_library.find { |b| b.title.include? "Latex" }
-      expect(latex_book.isbn).to eq("9780201398250")
-      expect(latex_book.publisher).to eq("Addison Wesley") # note, no Ruby-Amazon cruft
-      expect(latex_book.version).to eq(Alexandria::DATA_VERSION)
+      aggregate_failures do
+        expect(latex_book.isbn).to eq("9780201398250")
+        expect(latex_book.publisher).to eq("Addison Wesley")
+        expect(latex_book.version).to eq(Alexandria::DATA_VERSION)
+      end
     end
 
     it "loads a book without ISBN" do
@@ -189,13 +208,8 @@ describe Alexandria::Library do
     it "saves loaded books properly" do
       my_library.each { |book| my_library.save(book, true) }
       my_library_reloaded = loader.load_all_libraries[0]
-      expect(my_library_reloaded.size).to eq(2)
 
-      latex_book = my_library_reloaded.find { |b| b.title.include? "Latex" }
-      expect(latex_book.publisher).to eq("Addison Wesley")
-
-      lex_and_yacc_book = my_library_reloaded.find { |b| b.title.include? "Lex" }
-      expect(lex_and_yacc_book.publisher).to eq("O'Reilley")
+      expect(my_library_reloaded.map(&:publisher)).to eq ["O'Reilley", "Addison Wesley"]
     end
   end
 
@@ -224,11 +238,29 @@ describe Alexandria::Library do
       described_class.move(source, target, book)
 
       aggregate_failures do
-        expect(File.exist?(source.yaml(book))).to be_falsey
-        expect(File.exist?(source.cover(book))).to be_falsey
-        expect(File.exist?(target.yaml(book))).to be_truthy
-        expect(File.exist?(target.cover(book))).to be_truthy
+        expect(source.yaml(book)).not_to be_an_existing_file
+        expect(source.cover(book)).not_to be_an_existing_file
+        expect(target.yaml(book)).to be_an_existing_file
+        expect(target.cover(book)).to be_an_existing_file
       end
     end
   end
+
+  describe "#name=" do
+    let(:my_library) { loader.load_library("Empty") }
+
+    before do
+      FileUtils.mkdir_p(TESTDIR)
+    end
+
+    it "changes the library's name" do
+      my_library.name = "Really Empty"
+      expect(my_library.name).to eq "Really Empty"
+    end
+
+    it "moves the library's directory" do
+      my_library.name = "Really Empty"
+      expect(File.join(TESTDIR, "Really Empty")).to be_an_existing_file
+    end
+  end
 end

data/spec/alexandria/library_store_spec.rb

@@ -16,7 +16,7 @@ RSpec.describe Alexandria::LibraryStore do
         aggregate_failures do
           expect(smart_libs.size).to eq 5
           smart_libs.each do |lib|
-            expect(File.exist?(lib.yaml)).to be_truthy
+            expect(lib.yaml).to be_an_existing_file
           end
         end
       end

data/spec/alexandria/preferences_spec.rb

@@ -11,17 +11,17 @@ describe Alexandria::Preferences do
 
   describe "#get_variable" do
     it "returns nil fetching unknown setting" do
-      expect(instance.get_variable("does_not_exist")).to eq nil
+      expect(instance.get_variable("does_not_exist")).to be_nil
     end
 
     it "allows fetching by string" do
       instance.toolbar_visible = false
-      expect(instance.get_variable("toolbar_visible")).to eq false
+      expect(instance.get_variable("toolbar_visible")).to be false
     end
 
     it "allows fetching by symbol" do
       instance.toolbar_visible = true
-      expect(instance.get_variable(:toolbar_visible)).to eq true
+      expect(instance.get_variable(:toolbar_visible)).to be true
     end
   end
 
@@ -29,23 +29,23 @@ describe Alexandria::Preferences do
     it "allows setting by string" do
       instance.toolbar_visible = false
       instance.set_variable("toolbar_visible", true)
-      expect(instance.toolbar_visible).to eq true
+      expect(instance.toolbar_visible).to be true
     end
 
     it "allows setting by symbol" do
       instance.toolbar_visible = false
       instance.set_variable(:toolbar_visible, true)
-      expect(instance.toolbar_visible).to eq true
+      expect(instance.toolbar_visible).to be true
     end
   end
 
   it "allows setting known setting to false" do
     instance.toolbar_visible = false
-    expect(instance.toolbar_visible).to eq false
+    expect(instance.toolbar_visible).to be false
   end
 
   it "resets known setting by setting to nil" do
     instance.toolbar_visible = nil
-    expect(instance.toolbar_visible).to eq true
+    expect(instance.toolbar_visible).to be true
   end
 end

data/spec/alexandria/pseudo_marc_parser_spec.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+# Copyright (C) 2022 Matijs van Zuijlen
+#
+# Alexandria is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of the
+# License, or (at your option) any later version.
+#
+# Alexandria is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public
+# License along with Alexandria; see the file COPYING.  If not,
+# write to the Free Software Foundation, Inc., 51 Franklin Street,
+# Fifth Floor, Boston, MA 02110-1301 USA.
+
+require "spec_helper"
+
+RSpec.describe Alexandria::PseudoMarcParser do
+  describe ".marc_text_to_book" do
+    let(:marc_text) do
+      <<~MARC
+        00991pam  2200289 a 4500
+        001 426456
+        005 19820209000000.0
+        008 811005s1981    maua     b    001 0 eng#{'  '}
+        035    $9 (DLC)   81017108
+        906    $a 7 $b cbc $c orignew $d 1 $e ocip $f 19 $g y-gencatlg
+        010    $a    81017108#{' '}
+        020    $a 0805335587
+        020    $a 0805335579 (pbk.)
+        040    $a DLC $c DLC $d DLC
+        050 00 $a QA612 $b .G7
+        082 00 $a 514/.2 $2 19
+        100 1  $a Greenberg, Marvin J.
+        245 10 $a Algebraic topology : $b a first course / $c Marvin J. Greenberg, John R. Harper.
+        260    $a Reading, Mass. : $b Benjamin/Cummings Pub. Co., $c 1981.
+        300    $a xi, 311 p. : $b ill. ; $c 24 cm.
+        440  0 $a Mathematics lecture note series ; $v 58
+        500    $a "A revision of the first author's Lectures on algebraic topology"--P.
+        504    $a Bibliography: p. 303-307.
+        500    $a Includes index.
+        650  0 $a Algebraic topology.
+        700 1  $a Harper, John R., $d 1941-
+        991    $b c-GenColl $h QA612 $i .G7 $p 00035736761 $t Copy 1 $w BOOKS
+      MARC
+    end
+
+    it "returns a book with the correct attributes" do
+      result = described_class.marc_text_to_book(marc_text,
+                                                 described_class::USMARC_MAPPINGS)
+      aggregate_failures do
+        expect(result.title).to eq "Algebraic topology: a first course"
+        expect(result.authors).to eq ["Greenberg, Marvin J."]
+      end
+    end
+
+    it "returns nil when passed a blank string" do
+      result = described_class.marc_text_to_book("", described_class::USMARC_MAPPINGS)
+      expect(result).to be_nil
+    end
+
+    it "returns nil when passed nil" do
+      result = described_class.marc_text_to_book(nil, described_class::USMARC_MAPPINGS)
+      expect(result).to be_nil
+    end
+  end
+end

data/spec/alexandria/scanners/cue_cat_spec.rb

@@ -27,10 +27,17 @@ describe Alexandria::Scanners::CueCat do
     expect(cuecat.name).to match(/CueCat/i)
   end
 
-  it "detects a complete scan only" do
-    partials.each { |scan| expect(cuecat.match?(scan)).not_to be_truthy }
-    expect(cuecat.match?(scans[:isbn])).to be_truthy
-    expect(cuecat.match?(scans[:ib5])).to be_truthy
+  it "refuses to detect incomplete scans" do
+    aggregate_failures do
+      partials.each { |scan| expect(cuecat.match?(scan)).to be false }
+    end
+  end
+
+  it "detects complete scans" do
+    aggregate_failures do
+      expect(cuecat.match?(scans[:isbn])).to be true
+      expect(cuecat.match?(scans[:ib5])).to be true
+    end
   end
 
   it "decodes ISBN barcodes" do

data/spec/alexandria/smart_library_spec.rb

@@ -16,8 +16,10 @@ RSpec.describe Alexandria::SmartLibrary do
     it "normalizes the encoding" do
       bad_name = (+"Prêts").force_encoding("ascii")
       lib = described_class.new(bad_name, [], :all)
-      expect(lib.name.encoding.name).to eq "UTF-8"
-      expect(bad_name.encoding.name).to eq "US-ASCII"
+      aggregate_failures do
+        expect(lib.name.encoding.name).to eq "UTF-8"
+        expect(bad_name.encoding.name).to eq "US-ASCII"
+      end
     end
   end
 
@@ -25,15 +27,15 @@ RSpec.describe Alexandria::SmartLibrary do
     let(:lib) { described_class.new("Hello", [], :all) }
 
     it "works when given no parameters" do
-      lib.update
+      expect { lib.update }.not_to raise_error
     end
 
     it "works when given a LibraryCollection" do
-      lib.update Alexandria::LibraryCollection.instance
+      expect { lib.update Alexandria::LibraryCollection.instance }.not_to raise_error
     end
 
     it "works when given a Library" do
-      lib.update Alexandria::Library.new("Hi")
+      expect { lib.update Alexandria::Library.new("Hi") }.not_to raise_error
     end
   end
 end

data/spec/alexandria/ui/about_dialog_spec.rb

@@ -9,6 +9,6 @@ require_relative "../../spec_helper"
 describe Alexandria::UI::AboutDialog do
   it "works" do
     parent = Gtk::Window.new :toplevel
-    described_class.new parent
+    expect { described_class.new parent }.not_to raise_error
   end
 end

data/spec/alexandria/ui/acquire_dialog_spec.rb

@@ -9,6 +9,6 @@ require_relative "../../spec_helper"
 describe Alexandria::UI::AcquireDialog do
   it "works" do
     parent = Gtk::Window.new :toplevel
-    described_class.new parent
+    expect { described_class.new parent }.not_to raise_error
   end
 end

data/spec/alexandria/ui/alert_dialog_spec.rb

@@ -9,8 +9,10 @@ require_relative "../../spec_helper"
 describe Alexandria::UI::AlertDialog do
   it "works" do
     parent = Gtk::Window.new :toplevel
-    described_class.new(parent, "Hello",
-                        Gtk::Stock::DIALOG_QUESTION,
-                        [[Gtk::Stock::CANCEL, :cancel]], "Hi there")
+    expect do
+      described_class.new(parent, "Hello",
+                          Gtk::Stock::DIALOG_QUESTION,
+                          [[Gtk::Stock::CANCEL, :cancel]], "Hi there")
+    end.not_to raise_error
   end
 end

data/spec/alexandria/ui/bad_isbns_dialog_spec.rb

@@ -9,6 +9,6 @@ require_relative "../../spec_helper"
 describe Alexandria::UI::BadIsbnsDialog do
   it "works" do
     parent = Gtk::Window.new :toplevel
-    described_class.new parent, "Careful", []
+    expect { described_class.new parent, "Careful", [] }.not_to raise_error
   end
 end

data/spec/alexandria/ui/book_properties_dialog_spec.rb

@@ -22,7 +22,7 @@ describe Alexandria::UI::BookPropertiesDialog do
   end
 
   it "works" do
-    described_class.new parent, library, book
+    expect { described_class.new parent, library, book }.not_to raise_error
   end
 
   describe "#on_change_cover" do
@@ -39,21 +39,21 @@ describe Alexandria::UI::BookPropertiesDialog do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
 
     it "works when response is reject" do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::REJECT)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
 
     it "works when response is cancel" do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::CANCEL)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
   end
 end

data/spec/alexandria/ui/confirm_erase_dialog_spec.rb

@@ -7,8 +7,24 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::ConfirmEraseDialog do
+  let(:parent) { Gtk::Window.new :toplevel }
+
   it "works" do
-    parent = Gtk::Window.new :toplevel
-    described_class.new parent, "foo-file"
+    expect { described_class.new parent, "foo-file" }.not_to raise_error
+  end
+
+  describe "erase?" do
+    let(:instance) { described_class.new parent, "foo-file" }
+    let(:dialog) { instance.dialog }
+
+    it "returns false when response is cancel" do
+      allow(dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      expect(instance.erase?).to be false
+    end
+
+    it "returns true when response is OK" do
+      allow(dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
+      expect(instance.erase?).to be true
+    end
   end
 end

data/spec/alexandria/ui/conflict_while_copying_dialog_spec.rb

@@ -11,6 +11,6 @@ describe Alexandria::UI::ConflictWhileCopyingDialog do
     parent = Gtk::Window.new :toplevel
     library = instance_double(Alexandria::Library, name: "Bar Library")
     book = instance_double(Alexandria::Book, title: "Foo Book")
-    described_class.new parent, library, book
+    expect { described_class.new parent, library, book }.not_to raise_error
   end
 end

data/spec/alexandria/ui/error_dialog_spec.rb

@@ -7,8 +7,19 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::ErrorDialog do
+  let(:parent) { Gtk::Window.new :toplevel }
+
   it "works" do
-    parent = Gtk::Window.new :toplevel
-    described_class.new parent, "Boom", "It went boom"
+    expect { described_class.new parent, "Boom", "It went boom" }.not_to raise_error
+  end
+
+  describe "display" do
+    let(:instance) { described_class.new parent, "Boom", "It went boom" }
+    let(:dialog) { instance.dialog }
+
+    it "works when response is OK" do
+      allow(dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
+      expect { instance.display }.not_to raise_error
+    end
   end
 end

data/spec/alexandria/ui/export_dialog_spec.rb

@@ -12,7 +12,7 @@ describe Alexandria::UI::ExportDialog do
   let(:sort_order) { Alexandria::LibrarySortOrder::Unsorted.new }
 
   it "works" do
-    described_class.new parent, library, sort_order
+    expect { described_class.new parent, library, sort_order }.not_to raise_error
   end
 
   describe "#perform" do
@@ -21,14 +21,14 @@ describe Alexandria::UI::ExportDialog do
 
     it "works when response is cancel" do
       allow(chooser).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
-      export_dialog.perform
+      expect { export_dialog.perform }.not_to raise_error
     end
 
     it "works when response is OK" do
       dir = Dir.mktmpdir
       allow(chooser).to receive(:run).and_return(Gtk::ResponseType::OK)
       allow(chooser).to receive(:filename).and_return File.join(dir, "export")
-      export_dialog.perform
+      expect { export_dialog.perform }.not_to raise_error
     ensure
       FileUtils.remove_entry dir
     end

data/spec/alexandria/ui/iconview_spec.rb

@@ -10,6 +10,6 @@ describe Alexandria::UI::IconViewManager do
   it "works" do
     iconview = instance_double(Gtk::IconView).as_null_object
     parent = instance_double(Alexandria::UI::UIManager, iconview: iconview).as_null_object
-    described_class.new iconview, parent
+    expect { described_class.new iconview, parent }.not_to raise_error
   end
 end

data/spec/alexandria/ui/import_dialog_spec.rb

@@ -10,12 +10,12 @@ describe Alexandria::UI::ImportDialog do
   let(:parent) { Gtk::Window.new :toplevel }
 
   it "can be instantiated" do
-    described_class.new parent
+    expect { described_class.new parent }.not_to raise_error
   end
 
   it "handles a selection change" do
     importdialog = described_class.new parent
-    importdialog.dialog.signal_emit "selection_changed"
+    expect { importdialog.dialog.signal_emit "selection_changed" }.not_to raise_error
   end
 
   describe "#acquire" do
@@ -32,7 +32,7 @@ describe Alexandria::UI::ImportDialog do
 
     it "works when response is cancel" do
       allow(chooser).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
-      import_dialog.acquire {}
+      expect { import_dialog.acquire { nil } }.not_to raise_error
     end
 
     it "works when response is OK" do

data/spec/alexandria/ui/keep_bad_isbn_dialog_spec.rb

@@ -12,6 +12,6 @@ describe Alexandria::UI::KeepBadISBNDialog do
     book = instance_double(Alexandria::Book,
                            title: "Foo Book",
                            isbn: "98765432")
-    described_class.new parent, book
+    expect { described_class.new parent, book }.not_to raise_error
   end
 end

data/spec/alexandria/ui/new_book_dialog_manual_spec.rb

@@ -14,7 +14,7 @@ describe Alexandria::UI::NewBookDialogManual do
   end
 
   it "works" do
-    described_class.new parent, library
+    expect { described_class.new parent, library }.not_to raise_error
   end
 
   describe "#on_change_cover" do
@@ -31,21 +31,21 @@ describe Alexandria::UI::NewBookDialogManual do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
 
     it "works when response is reject" do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::REJECT)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
 
     it "works when response is cancel" do
       allow(filechooser)
         .to receive(:run).and_return(Gtk::ResponseType::CANCEL)
 
-      dialog.on_change_cover
+      expect { dialog.on_change_cover }.not_to raise_error
     end
   end
 end

data/spec/alexandria/ui/new_book_dialog_spec.rb

@@ -11,12 +11,12 @@ describe Alexandria::UI::NewBookDialog do
   let(:model) { Gtk::ListStore.new(String, String, GdkPixbuf::Pixbuf) }
 
   it "works" do
-    described_class.new parent
+    expect { described_class.new parent }.not_to raise_error
   end
 
   it "can copy search results into result treeview" do
     results = [[an_artist_of_the_floating_world, "cover-url"]]
     dialog = described_class.new parent
-    dialog.copy_results_to_treeview_model results, model
+    expect { dialog.copy_results_to_treeview_model results, model }.not_to raise_error
   end
 end