alexandria-book-collection-manager 0.7.5 → 0.7.9

data/spec/alexandria/ui/provider_preferences_dialog_spec.rb

@@ -4,16 +4,31 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ProviderPreferencesDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
-    preferences = instance_double(Alexandria::BookProviders::Preferences,
-                                  length: 0, read: [])
-    provider = instance_double(Alexandria::BookProviders::GenericProvider,
-                               fullname: "FooProvider",
-                               prefs: preferences)
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:preferences) do
+    instance_double(Alexandria::BookProviders::Preferences,
+                    length: 0, read: [])
+  end
+  let(:provider) do
+    instance_double(Alexandria::BookProviders::GenericProvider,
+                    fullname: "FooProvider",
+                    prefs: preferences)
+  end
+
+  it "can be instantiated" do
     described_class.new parent, provider
   end
+
+  describe "#acquire" do
+    it "works" do
+      preferences_dialog = described_class.new parent, provider
+      gtk_dialog = preferences_dialog.dialog
+      allow(gtk_dialog).to receive(:run)
+
+      preferences_dialog.acquire
+    end
+  end
 end

data/spec/alexandria/ui/really_delete_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ReallyDeleteDialog do
   it "works" do

data/spec/alexandria/ui/sidepane_manager_spec.rb

@@ -4,9 +4,9 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
-describe Alexandria::UI::SidePaneManager do
+describe Alexandria::UI::SidepaneManager do
   it "works" do
     library_listview = instance_double(Gtk::TreeView).as_null_object
     parent = instance_double(Alexandria::UI::UIManager, main_app: nil, append_library: nil)

data/spec/alexandria/ui/skip_entry_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::SkipEntryDialog do
   it "works" do

data/spec/alexandria/ui/smart_library_properties_dialog_spec.rb

@@ -4,15 +4,46 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::SmartLibraryPropertiesDialog do
-  it "works" do
+  let(:properties_dialog) do
     parent = Gtk::Window.new :toplevel
-    smart_library = instance_double(Alexandria::SmartLibrary,
-                                    name: "Foo",
-                                    rules: [],
-                                    predicate_operator_rule: :any)
+    loader = Alexandria::LibraryStore.new(TESTDIR)
+    smart_library = Alexandria::SmartLibrary.new("Foo", [], :all, loader)
     described_class.new parent, smart_library
   end
+  let(:gtk_dialog) { properties_dialog.dialog }
+
+  describe "#acquire" do
+    it "works when response is cancel" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      properties_dialog.acquire
+    end
+
+    it "works when response is ok" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
+      properties_dialog.acquire
+    end
+  end
+
+  describe "#handle_date_icon_press" do
+    let(:date_entry) do
+      rule_boxes = properties_dialog.handle_add_rule_clicked
+      rule_box = rule_boxes.first
+      rule_box.children[3]
+    end
+
+    before do
+      gtk_dialog.show_all
+    end
+
+    it "pops up the calendar widget" do
+      properties_dialog.handle_date_icon_press(date_entry,
+                                               Gtk::EntryIconPosition::PRIMARY,
+                                               nil)
+      popup = properties_dialog.instance_variable_get(:@calendar_popup)
+      expect(popup).to be_visible
+    end
+  end
 end

data/spec/alexandria/ui/ui_manager_spec.rb

@@ -4,11 +4,125 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::UIManager do
+  let(:main_app) { instance_double(Alexandria::UI::MainApp) }
+
   it "works" do
-    main_app = instance_double(Alexandria::UI::MainApp)
     described_class.new main_app
   end
+
+  describe "#on_new" do
+    it "works" do
+      ui = described_class.new main_app
+      libraries = ui.instance_variable_get(:@libraries)
+      libraries_count = libraries.all_libraries.count
+      ui.on_new
+      expect(libraries.all_libraries.count).to eq libraries_count + 1
+    end
+  end
+
+  describe "#on_books_selection_changed" do
+    let(:lib_version) { File.join(LIBDIR, "0.6.2") }
+    let(:ui) { described_class.new main_app }
+    let(:libraries) { ui.instance_variable_get(:@libraries) }
+    let(:regular_library) { libraries.all_regular_libraries.last }
+
+    before do
+      FileUtils.cp_r(lib_version, TESTDIR)
+    end
+
+    it "works when single book is selected" do
+      ui.select_a_library regular_library
+
+      # FIXME: This is needed because right now UIManager#refresh_books doesn't
+      # work without Gtk loop.
+      regular_library.each { |book| ui.append_book book }
+      # This makes the iconview model re-appear
+      ui.iconview.unfreeze
+      expect(ui.model.iter_n_children).to eq regular_library.count
+
+      # This triggers the #on_books_selection_changed callback
+      ui.select_a_book regular_library.first
+
+      expect(ui.iconview.selected_items).not_to be_empty
+    end
+  end
+
+  describe "#select_a_book" do
+    let(:ui) { described_class.new main_app }
+    let(:libraries) { ui.instance_variable_get(:@libraries) }
+    let(:filter_entry) { ui.instance_variable_get(:@filter_entry) }
+    let(:regular_library) { libraries.all_regular_libraries.last }
+
+    before do
+      lib_version = File.join(LIBDIR, "0.6.2")
+      FileUtils.cp_r(lib_version, TESTDIR)
+
+      ui.select_a_library regular_library
+      # Make books appear in the view
+      regular_library.each { |book| ui.append_book book }
+    end
+
+    context "when selecting in the icon view" do
+      before do
+        # Make view model re-appear
+        ui.iconview.unfreeze
+      end
+
+      it "selects book if it is in view" do
+        ui.select_a_book regular_library.first
+
+        selected = ui.iconview.selected_items
+        expect(selected.count).to eq 1
+      end
+
+      it "selects nothing if book is not in view due to a filter" do
+        filter_entry.text = regular_library.last.title
+        ui.filtered_model.refilter
+
+        ui.select_a_book regular_library.first
+
+        selected = ui.iconview.selected_items
+        expect(selected.count).to eq 0
+      end
+    end
+
+    context "when selecting in the list view" do
+      before do
+        # Make view model re-appear
+        ui.listview.unfreeze
+      end
+
+      it "selects book if it is in view" do
+        ui.select_a_book regular_library.first
+
+        selected, _model = ui.listview.selection.selected_rows
+        expect(selected.count).to eq 1
+      end
+
+      it "selects nothing if book is not in view due to a filter" do
+        filter_entry.text = regular_library.last.title
+        ui.filtered_model.refilter
+
+        ui.select_a_book regular_library.first
+
+        selected = ui.listview.selection.to_a
+        expect(selected).to be_empty
+      end
+
+      it "selects nothing if a new book is not in view due to a filter" do
+        filter_entry.text = regular_library.last.title
+        ui.filtered_model.refilter
+
+        book = an_artist_of_the_floating_world
+        ui.append_book book
+        ui.select_a_book book
+
+        selected = ui.listview.selection.to_a
+        expect(selected).to be_empty
+      end
+    end
+  end
 end

data/spec/data/libraries/0.6.2/My Library/9780571147168.yaml

@@ -18,3 +18,5 @@ tags: []
 title: An Artist of the Floating World
 version: 0.6.2b1
 want: true
+library: !ruby/array:Alexandria:Library
+  internal: []

data/spec/end_to_end/basic_run_spec.rb

@@ -19,13 +19,6 @@ describe "The Alexandria application" do
     driver.cleanup
   end
 
-  it "starts and can be quit with Ctrl-q" do
-    driver.press_ctrl_q
-
-    status = driver.cleanup
-    expect(status.exitstatus).to eq 0
-  end
-
   it "starts and can be quit with the menu" do
     frame = driver.frame
     menu = frame.find_role :menu_item, /Quit/
@@ -49,7 +42,9 @@ describe "The Alexandria application" do
       table_cell.do_action idx if name == "activate"
     end
 
-    driver.press_ctrl_q
+    frame = driver.frame
+    menu = frame.find_role :menu_item, /Quit/
+    menu.do_action 0
 
     status = driver.cleanup
     expect(status.exitstatus).to eq 0

data/spec/spec_helper.rb

@@ -4,11 +4,12 @@
 #
 # See the file README.md for authorship and licensing information.
 
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "/../lib"))
-
+require "rspec"
 require "alexandria"
+require "webmock/rspec"
+require "pry"
 
-LIBDIR = File.expand_path(File.join(File.dirname(__FILE__), "/data/libraries"))
+LIBDIR = File.expand_path("data/libraries", __dir__)
 TESTDIR = File.join(LIBDIR, "test")
 
 def an_artist_of_the_floating_world
@@ -19,12 +20,55 @@ def an_artist_of_the_floating_world
                        "Paperback")
 end
 
+def assert_correct_search_result(provider, query,
+                                 search_type = Alexandria::BookProviders::SEARCH_BY_ISBN)
+  begin
+    results = provider.instance.search(query, search_type)
+  rescue SocketError
+    skip "Service is offline"
+  end
+
+  expect(results).to be_instance_of(Array), "Results are not an array for #{provider}"
+  expect(results).not_to be_empty, "Results are empty for #{provider}"
+
+  if search_type == Alexandria::BookProviders::SEARCH_BY_ISBN
+    expect(results.length).to be <= 2, "Results are greater than 2 for #{provider}"
+
+    book = results.first
+
+    expect(book).to be_instance_of(Alexandria::Book),
+                    "Result is not a Book for #{provider}"
+
+    canonical_query = Alexandria::Library.canonicalise_ean(query)
+    canonical_result = Alexandria::Library.canonicalise_ean(book.isbn)
+    expect(canonical_query)
+      .to eq(canonical_result),
+          "Result's isbn #{book.isbn} is not equivalent" \
+          " to the requested isbn #{query} for #{provider}"
+
+    if results.length == 2
+      cover_url = results.last
+      if cover_url
+        expect(cover_url)
+          .to be_instance_of(String),
+              "Unexpected cover_url #{cover_url.inspect} for #{provider}"
+      end
+    end
+  else
+    expect(results.first.first)
+      .to be_instance_of(Alexandria::Book), "Result item is not a Book for #{provider}"
+  end
+  results
+end
+
 Alexandria::UI::Icons.init
 
 test_store = Alexandria::LibraryStore.new(TESTDIR)
 Alexandria::LibraryCollection.instance.library_store = test_store
 
 RSpec.configure do |config|
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
   config.before do
     FileUtils.rm_rf(TESTDIR)
   end

data/tasks/spec.rake

@@ -2,7 +2,7 @@
 
 # -*- ruby -*-
 #--
-# Copyright (C) 2011-2019 Matijs van Zuijlen
+# Copyright (C) 2011 Matijs van Zuijlen
 #
 # This file is part of the Alexandria build system.
 #
@@ -39,10 +39,8 @@ namespace "spec" do
     t.ruby_opts = ["-rbundler/setup -rsimplecov -Ilib -w"]
   end
 
-  RSpec::Core::RakeTask.new("all") do |t|
-    t.pattern = "spec/**/*_spec.rb"
-    t.ruby_opts = ["-rbundler/setup -rsimplecov -Ilib -w"]
-  end
+  desc "Runs all unit and end-to-end specs"
+  task "all" => ["spec:unit", "spec:end_to_end"]
 end
 
 task spec: "spec:all"

data/util/rake/fileinstall.rb

@@ -3,7 +3,7 @@
 # -*- ruby -*-
 #--
 # Copyright (C) 2009 Cathal Mc Ginley
-# Copyright (C) 2011 Matijs van Zuijlen
+# Copyright (C) 2011, 2020 Matijs van Zuijlen
 #
 # This file is part of the Alexandria build system.
 #
@@ -105,7 +105,7 @@ class FileInstallTask < Rake::TaskLib
       @dirs_to_remove_globs.each do |glob|
         regex = glob2regex(glob)
         all_dirs.each do |dir|
-          dir += "/" unless dir =~ %r{/$}
+          dir += "/" unless dir.end_with?("/")
           to_delete << Regexp.last_match[1] if regex =~ dir
         end
       end
@@ -182,7 +182,7 @@ class FileInstallTask < Rake::TaskLib
     if @prefix == ruby_prefix
       @rubylib = ruby_libdir
     elsif ruby_libdir.index(ruby_prefix).zero?
-      libpart = ruby_libdir[ruby_prefix.size..-1]
+      libpart = ruby_libdir[ruby_prefix.size..]
       @rubylib = File.join(@prefix, libpart)
     else
       @rubylib = ruby_libdir
@@ -190,12 +190,12 @@ class FileInstallTask < Rake::TaskLib
   end
 
   def glob2regex(pathglob)
-    pathglob += "/" if /\*\*$/.match?(pathglob)
+    pathglob += "/" if pathglob.end_with?("**")
     real_parts = pathglob.split("**/")
     real_parts.each do |part|
-      part.gsub!(".", '\\.')
-      part.gsub!("*", '[^\\/]*')
-      part.gsub!("?", '[^\\/]')
+      part.gsub!(".", "\\.")
+      part.gsub!("*", "[^\\/]*")
+      part.gsub!("?", "[^\\/]")
     end
     pattern = real_parts.join("([^\/]+\/)*")
     /(#{pattern})/
@@ -210,16 +210,16 @@ class FileInstallTask < Rake::TaskLib
     end
   end
 
-  # Delete the directory at the given Pathname +p+ if all its children
+  # Delete the directory at the given Pathname +path+ if all its children
   # can be similarly deleted, and if it is then empty.
-  def delete_if_empty(p)
-    return false unless p.directory?
+  def delete_if_empty(path)
+    return false unless path.directory?
 
-    p.children.each do |c|
+    path.children.each do |c|
       delete_if_empty(c)
     end
-    if p.children.empty?
-      p.delete # TODO: optional verbose output here
+    if path.children.empty?
+      path.delete # TODO: optional verbose output here
       true
     else
       false
@@ -229,6 +229,7 @@ class FileInstallTask < Rake::TaskLib
   class FileGroup
     attr_reader :mode
     attr_accessor :description
+
     def initialize(src_dir, file_glob, dest_dir, mode = 0o644)
       @src_dir = src_dir
       @file_glob = file_glob
@@ -290,5 +291,5 @@ class FileInstallTask < Rake::TaskLib
         all_dirs_set << File.dirname(file)
       end
     end
-  end # class FileGroup
-end # class FileInstallTask
+  end
+end

data/util/rake/omfgenerate.rb

@@ -67,7 +67,7 @@ class OmfGenerateTask < Rake::TaskLib
     rule ".omf" => [".omf.in"] do |t|
       path = File.join(@gnome_helpfiles_dir, @projectname,
                        locale_for(t.name), "#{@projectname}.xml")
-      data = IO.read(t.source)
+      data = File.read(t.source)
       data.sub!(/PATH_TO_DOC_FILE/, path)
       puts "Generating #{t.name}..."
       File.open(t.name, "w") { |io| io.puts data }