alexandria-book-collection-manager 0.7.5 → 0.7.9

data/spec/alexandria/library_spec.rb

@@ -78,10 +78,6 @@ describe Alexandria::Library do
       FileUtils.mkdir(TESTDIR) unless File.exist? TESTDIR
     end
 
-    after do
-      FileUtils.rm_rf(TESTDIR)
-    end
-
     it "disallows multiple deletion of the same copy of a book" do
       first_copy = an_artist_of_the_floating_world
       my_library << first_copy
@@ -104,53 +100,64 @@ describe Alexandria::Library do
   end
 
   describe ".import_as_isbn_list" do
-    def __test_fake_import_isbns
+    before do
       libraries = Alexandria::LibraryCollection.instance
-      library = Alexandria::Library.new("Test Library")
+      library = described_class.new("Test Library")
       libraries.add_library(library)
-      [library, libraries]
+
+      allow(Alexandria::BookProviders)
+        .to receive(:isbn_search)
+        .and_raise Alexandria::BookProviders::SearchEmptyError
+      allow(Alexandria::BookProviders)
+        .to receive(:isbn_search).with("0595371086")
+        .and_return(an_artist_of_the_floating_world)
     end
 
-    it "doesn't work quite yet" do
-      skip
-      # Doesn't work quite yet.
-      on_iterate_cb = proc {}
-      on_error_cb = proc {}
-      library, _libraries = __test_fake_import_isbns
-      test_file = "data/isbns.txt"
-      library.import_as_isbn_list("Test Library", test_file, on_iterate_cb, on_error_cb)
+    it "imports books with correct isbn and search result" do
+      library, bad_isbns, failed_lookup_isbns =
+        described_class.import_as_isbn_list("Test Library", "spec/data/isbns.txt",
+                                            proc {}, proc {})
+
+      aggregate_failures do
+        expect(library.to_a).to eq [an_artist_of_the_floating_world]
+        expect(bad_isbns).to eq ["0911826449"]
+        expect(failed_lookup_isbns).to eq ["0740704923"]
+      end
     end
   end
 
   context "when importing from 0.6.1 data files" do
+    let(:libs) { loader.load_all_libraries }
+    let(:my_library) { libs[0] }
+
     before do
       lib_version = File.join(LIBDIR, "0.6.1")
       FileUtils.cp_r(lib_version, TESTDIR)
     end
 
-    after do
-      FileUtils.rm_rf(TESTDIR)
+    it "can be loaded" do
+      expect(libs.size).to eq(1)
+      expect(my_library.size).to eq(3)
     end
 
     it "imports cleanly from version 0.6.1 data format" do
-      libs = loader.load_all_libraries
-      expect(libs.size).to eq(1)
-      my_library = libs[0]
-      expect(my_library.size).to eq(3)
       # Malory
-      malory_book = my_library.select { |b| b.isbn == "9780192812179" }[0]
+      malory_book = my_library.find { |b| b.isbn == "9780192812179" }
       expect(malory_book.publisher).to eq("Oxford University Press")
       expect(malory_book.authors.include?("Vinaver")).to be_truthy
       expect(malory_book.version).to eq(Alexandria::DATA_VERSION)
 
       # Guide to LaTeX
-      latex_book = my_library.select { |b| b.title.include? "Latex" }[0]
+      latex_book = my_library.find { |b| b.title.include? "Latex" }
       expect(latex_book.isbn).to eq("9780201398250")
-      expect(latex_book.publisher).to eq("Addison Wesley") # note, no Ruby-Amazon cruft
+      expect(latex_book.publisher).to eq("Addison Wesley")
     end
   end
 
   context "when importing from 0.6.1 with books without an ISBN" do
+    let(:libs) { loader.load_all_libraries }
+    let(:my_library) { libs[0] }
+
     before do
       lib_version = File.join(LIBDIR, "0.6.1-noisbn")
       FileUtils.cp_r(lib_version, TESTDIR)
@@ -160,58 +167,63 @@ describe Alexandria::Library do
       FileUtils.rm_rf(TESTDIR)
     end
 
-    it "allows books to have no ISBN" do
-      libs = loader.load_all_libraries
+    it "can be loaded" do
       expect(libs.size).to eq(1)
-      my_library = libs[0]
       expect(my_library.size).to eq(2)
+    end
 
+    it "loads a book with ISBN" do
       # Guide to LaTeX
-      latex_book = my_library.select { |b| b.title.include? "Latex" }[0]
+      latex_book = my_library.find { |b| b.title.include? "Latex" }
       expect(latex_book.isbn).to eq("9780201398250")
-      expect(latex_book.publisher).to eq("Addison Wesley") # note, no Ruby-Amazon cruft
+      expect(latex_book.publisher).to eq("Addison Wesley")
       expect(latex_book.version).to eq(Alexandria::DATA_VERSION)
+    end
 
+    it "loads a book without ISBN" do
       # Lex and Yacc
-      lex_and_yacc_book = my_library.select { |b| b.title.include? "Lex" }[0]
+      lex_and_yacc_book = my_library.find { |b| b.title.include? "Lex" }
       expect(lex_and_yacc_book.publisher).to eq("O'Reilley")
+    end
 
-      my_library.each do |book|
-        my_library.save(book, true)
-      end
-
-      libraries_reloaded = loader.load_all_libraries
-      my_library_reloaded = libraries_reloaded[0]
-
+    it "saves loaded books properly" do
+      my_library.each { |book| my_library.save(book, true) }
+      my_library_reloaded = loader.load_all_libraries[0]
       expect(my_library_reloaded.size).to eq(2)
 
-      latex_book = my_library_reloaded.select { |b| b.title.include? "Latex" }[0]
-      expect(latex_book).not_to be_nil
+      latex_book = my_library_reloaded.find { |b| b.title.include? "Latex" }
       expect(latex_book.publisher).to eq("Addison Wesley")
 
-      lex_and_yacc_book = my_library_reloaded.select { |b| b.title.include? "Lex" }[0]
-      expect(lex_and_yacc_book).not_to be_nil
+      lex_and_yacc_book = my_library_reloaded.find { |b| b.title.include? "Lex" }
       expect(lex_and_yacc_book.publisher).to eq("O'Reilley")
     end
   end
 
   describe ".move" do
+    let(:source) { loader.load_library("My Library") }
+    let(:target) { loader.load_library("Target") }
+    let(:book) { source.first }
+
     before do
       lib_version = File.join(LIBDIR, "0.6.2")
       FileUtils.cp_r(lib_version, TESTDIR)
     end
 
-    it "moves the given book from source to target" do
-      source = loader.load_library("My Library")
+    it "changes the number of books in the source and target libraries" do
       count = source.count
-      book = source.first
-      target = loader.load_library("Target")
 
-      described_class.move(source, target, source.first)
+      described_class.move(source, target, book)
 
       aggregate_failures do
         expect(source.count).to eq count - 1
         expect(target.count).to eq 1
+      end
+    end
+
+    it "moves the book files from source to target" do
+      described_class.move(source, target, book)
+
+      aggregate_failures do
         expect(File.exist?(source.yaml(book))).to be_falsey
         expect(File.exist?(source.cover(book))).to be_falsey
         expect(File.exist?(target.yaml(book))).to be_truthy
@@ -219,4 +231,22 @@ describe Alexandria::Library do
       end
     end
   end
+
+  describe "#name=" do
+    let(:my_library) { loader.load_library("Empty") }
+
+    before do
+      FileUtils.mkdir(TESTDIR) unless File.exist? TESTDIR
+    end
+
+    it "changes the library's name" do
+      my_library.name = "Really Empty"
+      expect(my_library.name).to eq "Really Empty"
+    end
+
+    it "moves the library's directory" do
+      my_library.name = "Really Empty"
+      expect(File.exist?(File.join(TESTDIR, "Really Empty"))).to be_truthy
+    end
+  end
 end

data/spec/alexandria/preferences_spec.rb

@@ -4,13 +4,39 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../spec_helper"
+require_relative "../spec_helper"
 
 describe Alexandria::Preferences do
   let(:instance) { described_class.instance }
 
-  it "returns nil fetching unknown setting" do
-    expect(instance.does_not_exist).to eq nil
+  describe "#get_variable" do
+    it "returns nil fetching unknown setting" do
+      expect(instance.get_variable("does_not_exist")).to eq nil
+    end
+
+    it "allows fetching by string" do
+      instance.toolbar_visible = false
+      expect(instance.get_variable("toolbar_visible")).to eq false
+    end
+
+    it "allows fetching by symbol" do
+      instance.toolbar_visible = true
+      expect(instance.get_variable(:toolbar_visible)).to eq true
+    end
+  end
+
+  describe "#set_variable" do
+    it "allows setting by string" do
+      instance.toolbar_visible = false
+      instance.set_variable("toolbar_visible", true)
+      expect(instance.toolbar_visible).to eq true
+    end
+
+    it "allows setting by symbol" do
+      instance.toolbar_visible = false
+      instance.set_variable(:toolbar_visible, true)
+      expect(instance.toolbar_visible).to eq true
+    end
   end
 
   it "allows setting known setting to false" do

data/spec/alexandria/scanners/cue_cat_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::Scanners::CueCat do
   let(:cuecat) { described_class.new }

data/spec/alexandria/ui/about_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::AboutDialog do
   it "works" do

data/spec/alexandria/ui/acquire_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::AcquireDialog do
   it "works" do

data/spec/alexandria/ui/alert_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::AlertDialog do
   it "works" do

data/spec/alexandria/ui/bad_isbns_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::BadIsbnsDialog do
   it "works" do

data/spec/alexandria/ui/book_properties_dialog_spec.rb

@@ -4,14 +4,56 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::BookPropertiesDialog do
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:library) do
+    store = Alexandria::LibraryCollection.instance.library_store
+    store.load_library("Bar Library")
+  end
+  let(:book) do
+    Alexandria::Book.new("Foo Book", ["Jane Doe"], "98765432", "Bar Publisher",
+                         1972, "edition")
+  end
+
+  before do
+    library << book
+  end
+
   it "works" do
-    parent = Gtk::Window.new :toplevel
-    library = instance_double(Alexandria::Library, name: "Bar Library", cover: "")
-    book = Alexandria::Book.new("Foo Book", ["Jane Doe"], "98765432", "Bar Publisher",
-                                1972, "edition")
     described_class.new parent, library, book
   end
+
+  describe "#on_change_cover" do
+    let(:dialog) { described_class.new parent, library, book }
+    let(:filechooser) { instance_double(Gtk::FileChooserDialog).as_null_object }
+
+    before do
+      allow(Gtk::FileChooserDialog).to receive(:new).and_return(filechooser)
+      allow(filechooser).to receive(:filename)
+        .and_return File.join(__dir__, "../../fixtures/cover.jpg")
+    end
+
+    it "works when response is accept" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
+
+      dialog.on_change_cover
+    end
+
+    it "works when response is reject" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::REJECT)
+
+      dialog.on_change_cover
+    end
+
+    it "works when response is cancel" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+
+      dialog.on_change_cover
+    end
+  end
 end

data/spec/alexandria/ui/confirm_erase_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ConfirmEraseDialog do
   it "works" do

data/spec/alexandria/ui/conflict_while_copying_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ConflictWhileCopyingDialog do
   it "works" do

data/spec/alexandria/ui/error_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ErrorDialog do
   it "works" do

data/spec/alexandria/ui/export_dialog_spec.rb

@@ -4,12 +4,33 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ExportDialog do
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:library) { Alexandria::Library.new "Bar Library" }
+  let(:sort_order) { Alexandria::LibrarySortOrder::Unsorted.new }
+
   it "works" do
-    parent = Gtk::Window.new :toplevel
-    library = instance_double(Alexandria::Library, name: "Bar Library")
-    described_class.new parent, library, :ascending
+    described_class.new parent, library, sort_order
+  end
+
+  describe "#perform" do
+    let(:export_dialog) { described_class.new parent, library, sort_order }
+    let(:chooser) { export_dialog.dialog }
+
+    it "works when response is cancel" do
+      allow(chooser).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      export_dialog.perform
+    end
+
+    it "works when response is OK" do
+      dir = Dir.mktmpdir
+      allow(chooser).to receive(:run).and_return(Gtk::ResponseType::OK)
+      allow(chooser).to receive(:filename).and_return File.join(dir, "export")
+      export_dialog.perform
+    ensure
+      FileUtils.remove_entry dir
+    end
   end
 end

data/spec/alexandria/ui/icons_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require "spec_helper"
+
+RSpec.describe Alexandria::UI::Icons do
+  describe ".tag_icon" do
+    let(:loader) { Alexandria::LibraryStore.new(TESTDIR) }
+    let(:lib_version) { File.join(LIBDIR, "0.6.2") }
+
+    before do
+      FileUtils.cp_r(lib_version, TESTDIR)
+    end
+
+    it "returns a pixbuf" do
+      library = loader.load_all_libraries.first
+      icon = described_class.cover(library, library.first)
+
+      tagged_icon = described_class.tag_icon(icon, described_class::FAVORITE_TAG)
+      expect(tagged_icon).to be_a GdkPixbuf::Pixbuf
+    end
+  end
+end

data/spec/alexandria/ui/iconview_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::IconViewManager do
   it "works" do

data/spec/alexandria/ui/import_dialog_spec.rb

@@ -4,11 +4,43 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ImportDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
+  let(:parent) { Gtk::Window.new :toplevel }
+
+  it "can be instantiated" do
     described_class.new parent
   end
+
+  it "handles a selection change" do
+    importdialog = described_class.new parent
+    importdialog.dialog.signal_emit "selection_changed"
+  end
+
+  describe "#acquire" do
+    let(:import_dialog) { described_class.new parent }
+    let(:chooser) { import_dialog.dialog }
+
+    before do
+      allow(chooser).to receive(:filename).and_return("spec/data/isbns.txt")
+      allow(Alexandria::BookProviders).to receive(:isbn_search)
+        .and_raise Alexandria::BookProviders::SearchEmptyError
+      allow(Alexandria::BookProviders).to receive(:isbn_search).with("0595371086")
+        .and_return(an_artist_of_the_floating_world)
+    end
+
+    it "works when response is cancel" do
+      allow(chooser).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      import_dialog.acquire { nil }
+    end
+
+    it "works when response is OK" do
+      allow(chooser).to receive(:run).and_return(Gtk::ResponseType::OK)
+
+      result = nil
+      import_dialog.acquire { |*args| result = args }
+      expect(result.first.to_a).to eq [an_artist_of_the_floating_world]
+    end
+  end
 end

data/spec/alexandria/ui/keep_bad_isbn_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::KeepBadISBNDialog do
   it "works" do

data/spec/alexandria/ui/main_app_spec.rb

@@ -6,7 +6,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::MainApp do
   it "is a singleton" do

data/spec/alexandria/ui/new_book_dialog_manual_spec.rb

@@ -4,12 +4,48 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::NewBookDialogManual do
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:library) do
+    store = Alexandria::LibraryCollection.instance.library_store
+    store.load_library("Bar Library")
+  end
+
   it "works" do
-    parent = Gtk::Window.new :toplevel
-    library = instance_double(Alexandria::Library)
     described_class.new parent, library
   end
+
+  describe "#on_change_cover" do
+    let(:dialog) { described_class.new parent, library }
+    let(:filechooser) { instance_double(Gtk::FileChooserDialog).as_null_object }
+
+    before do
+      allow(Gtk::FileChooserDialog).to receive(:new).and_return(filechooser)
+      allow(filechooser).to receive(:filename)
+        .and_return File.join(__dir__, "../../fixtures/cover.jpg")
+    end
+
+    it "works when response is accept" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
+
+      dialog.on_change_cover
+    end
+
+    it "works when response is reject" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::REJECT)
+
+      dialog.on_change_cover
+    end
+
+    it "works when response is cancel" do
+      allow(filechooser)
+        .to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+
+      dialog.on_change_cover
+    end
+  end
 end

data/spec/alexandria/ui/new_provider_dialog_spec.rb

@@ -4,11 +4,27 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::NewProviderDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
+  let(:parent) { Gtk::Window.new :toplevel }
+
+  it "can be instantiated" do
     described_class.new parent
   end
+
+  describe "#acquire" do
+    let(:provider_dialog) { described_class.new parent }
+    let(:gtk_dialog) { provider_dialog.dialog }
+
+    it "works when response is cancel" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      provider_dialog.acquire
+    end
+
+    it "works when response is accept" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
+      provider_dialog.acquire
+    end
+  end
 end

data/spec/alexandria/ui/new_smart_library_dialog_spec.rb

@@ -4,11 +4,36 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::NewSmartLibraryDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
+  let(:parent) { Gtk::Window.new :toplevel }
+
+  it "can be instantiated" do
     described_class.new parent
   end
+
+  describe "#acquire" do
+    let(:properties_dialog) { described_class.new parent }
+    let(:gtk_dialog) { properties_dialog.dialog }
+
+    it "works when response is cancel" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      properties_dialog.acquire
+    end
+
+    it "returns a smart library that can be saved when response is ok" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
+
+      # Make sure entered rule is valid
+      rules_box = properties_dialog.instance_variable_get(:@rules_box)
+      entry = rules_box.children.first.children[2]
+      entry.text = "foo"
+
+      result = properties_dialog.acquire
+
+      expect(result).to be_a Alexandria::SmartLibrary
+      expect { result.save }.not_to raise_error
+    end
+  end
 end

data/spec/alexandria/ui/preferences_dialog_spec.rb

@@ -4,11 +4,11 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::PreferencesDialog do
   it "works" do
     parent = Gtk::Window.new :toplevel
-    described_class.new(parent) {}
+    described_class.new(parent) { nil }
   end
 end