alexandria-book-collection-manager 0.7.2 → 0.7.3

data/spec/alexandria/smart_library_spec.rb

@@ -1,34 +1,39 @@
 # frozen_string_literal: true
 
-# Copyright (C) 2007 Joseph Method
+# This file is part of Alexandria.
 #
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
-describe Alexandria::SmartLibrary do
+RSpec.describe Alexandria::SmartLibrary do
   it 'can be instantiated simply' do
     lib = described_class.new('Hello', [], :all)
     expect(lib.name).to eq 'Hello'
   end
 
-  it 'normalizes the encoding for name' do
-    bad_name = (+'Prêts').force_encoding('ascii')
-    lib = described_class.new(bad_name, [], :all)
-    expect(lib.name.encoding.name).to eq 'UTF-8'
-    expect(bad_name.encoding.name).to eq 'US-ASCII'
+  describe '#name' do
+    it 'normalizes the encoding' do
+      bad_name = (+'Prêts').force_encoding('ascii')
+      lib = described_class.new(bad_name, [], :all)
+      expect(lib.name.encoding.name).to eq 'UTF-8'
+      expect(bad_name.encoding.name).to eq 'US-ASCII'
+    end
+  end
+
+  describe '#update' do
+    let(:lib) { described_class.new('Hello', [], :all) }
+
+    it 'works when given no parameters' do
+      lib.update
+    end
+
+    it 'works when given a LibraryCollection' do
+      lib.update Alexandria::LibraryCollection.instance
+    end
+
+    it 'works when given a Library' do
+      lib.update Alexandria::Library.new('Hi')
+    end
   end
 end

data/spec/alexandria/ui/dialogs/new_book_dialog_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require 'spec_helper'
+
+describe Alexandria::UI::NewBookDialog do
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:model) { Gtk::ListStore.new(String, String, GdkPixbuf::Pixbuf) }
+
+  it 'should work' do
+    described_class.new parent
+  end
+
+  it 'can copy search results into result treeview' do
+    results = [[an_artist_of_the_floating_world, 'cover-url']]
+    dialog = described_class.new parent
+    dialog.copy_results_to_treeview_model results, model
+  end
+end

data/spec/alexandria/ui/dialogs_spec.rb

@@ -1,96 +1,162 @@
 # frozen_string_literal: true
 
-# Copyright (C) 2007 Joseph Method
-# Copyright (C) 2015, 2016 Matijs van Zuijlen
+# This file is part of Alexandria.
 #
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
 require File.dirname(__FILE__) + '/../../spec_helper'
 
 describe Alexandria::UI::SmartLibraryPropertiesDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    smart_library = instance_double(Alexandria::SmartLibrary,
+                                    name: 'Foo',
+                                    rules: [],
+                                    predicate_operator_rule: :any)
+    described_class.new parent, smart_library
+  end
+end
+
+describe Alexandria::UI::ProviderPreferencesDialog do
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    preferences = instance_double(Alexandria::BookProviders::Preferences,
+                                  length: 0, read: [])
+    provider = instance_double(Alexandria::BookProviders::GenericProvider,
+                               fullname: 'FooProvider',
+                               prefs: preferences)
+    described_class.new parent, provider
+  end
 end
 
-describe Alexandria::UI::ProviderPreferencesBaseDialog do
-  it 'should work'
+describe Alexandria::UI::NewProviderDialog do
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    described_class.new parent
+  end
 end
 
 describe Alexandria::UI::PreferencesDialog do
-  it 'should be renamed to ProviderPreferencesDialog'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    described_class.new(parent) {}
+  end
 end
 
 describe Alexandria::UI::NewSmartLibraryDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    described_class.new parent
+  end
 end
 
 describe Alexandria::UI::NewBookDialogManual do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    library = instance_double(Alexandria::Library)
+    described_class.new parent, library
+  end
 end
 
 describe Alexandria::UI::KeepBadISBNDialog do
-  it 'should work'
-end
-
-describe Alexandria::UI::NewBookDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    book = instance_double(Alexandria::Book,
+                           title: 'Foo Book',
+                           isbn: '98765432')
+    described_class.new parent, book
+  end
 end
 
 describe Alexandria::UI::ConflictWhileCopyingDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    library = instance_double(Alexandria::Library, name: 'Bar Library')
+    book = instance_double(Alexandria::Book, title: 'Foo Book')
+    described_class.new parent, library, book
+  end
 end
 
 describe Alexandria::UI::ReallyDeleteDialog do
-  it 'should work'
+  it 'should work' do
+    library = instance_double(Alexandria::Library, name: 'Bar Library', empty?: false, size: 12)
+    parent = Gtk::Window.new :toplevel
+    described_class.new parent, library
+  end
 end
 
 describe Alexandria::UI::SkipEntryDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    described_class.new parent, 'Foo'
+  end
 end
 
 describe Alexandria::UI::ImportDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    described_class.new parent
+  end
 end
 
 describe Alexandria::UI::ConfirmEraseDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    described_class.new parent, 'foo-file'
+  end
 end
 
 describe Alexandria::UI::ExportDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    library = instance_double(Alexandria::Library, name: 'Bar Library')
+    described_class.new parent, library, :ascending
+  end
 end
 
 describe Alexandria::UI::BookPropertiesDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    library = instance_double(Alexandria::Library, name: 'Bar Library', cover: '')
+    book = Alexandria::Book.new('Foo Book', ['Jane Doe'], '98765432', 'Bar Publisher',
+                                1972, 'edition')
+    described_class.new parent, library, book
+  end
 end
 
 describe Alexandria::UI::BadIsbnsDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    described_class.new parent, 'Careful', []
+  end
+end
+
+describe Alexandria::UI::ErrorDialog do
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    described_class.new parent, 'Boom', 'It went boom'
+  end
 end
 
 describe Alexandria::UI::AlertDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    described_class.new(parent, 'Hello',
+                        Gtk::Stock::DIALOG_QUESTION,
+                        [[Gtk::Stock::CANCEL, :cancel]], 'Hi there')
+  end
 end
 
 describe Alexandria::UI::AcquireDialog do
   it 'should work' do
     parent = Gtk::Window.new :toplevel
-    Alexandria::UI::AcquireDialog.new parent
+    described_class.new parent
   end
 end
 
 describe Alexandria::UI::AboutDialog do
-  it 'should work'
+  it 'should work' do
+    parent = Gtk::Window.new :toplevel
+    described_class.new parent
+  end
 end

data/spec/end_to_end/basic_run_spec.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+# Copyright (C) 2018 Matijs van Zuijlen
+#
+# Alexandria is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of the
+# License, or (at your option) any later version.
+#
+# Alexandria is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public
+# License along with Alexandria; see the file COPYING.  If not,
+# write to the Free Software Foundation, Inc., 51 Franklin Street,
+# Fifth Floor, Boston, MA 02110-1301 USA.
+
+require 'gnome_app_driver'
+require 'tmpdir'
+
+describe 'The Alexandria application' do
+  before do
+    ENV['HOME'] = Dir.mktmpdir
+    @driver = GnomeAppDriver.new 'alexandria'
+    @driver.boot
+  end
+
+  it 'starts and can be quit with Ctrl-q' do
+    @driver.press_ctrl_q
+
+    status = @driver.cleanup
+    expect(status.exitstatus).to eq 0
+  end
+
+  it 'starts and can be quit with the menu' do
+    frame = @driver.frame
+    menu = frame.find_role :menu_item, /Quit/
+    menu.do_action 0
+
+    status = @driver.cleanup
+    expect(status.exitstatus).to eq 0
+  end
+
+  it 'can be interacted with' do
+    frame = @driver.frame
+    frame.find_role(:menu_item, /Title contains/).do_action 0
+    frame.find_role(:menu_item, /View as Icons/).do_action 0
+    frame.find_role(:menu_item, /View as List/).do_action 0
+    frame.find_role(:table_column_header, /Title/).do_action 0
+
+    table_cell = frame.find_role(:table_cell)
+
+    table_cell.n_actions.times do |idx|
+      name = table_cell.get_action_name idx
+      table_cell.do_action idx if name == 'activate'
+    end
+
+    @driver.press_ctrl_q
+
+    status = @driver.cleanup
+    expect(status.exitstatus).to eq 0
+  end
+
+  after do
+    @driver.cleanup
+  end
+end

data/spec/spec_helper.rb

@@ -1,22 +1,8 @@
 # frozen_string_literal: true
 
-# Copyright (C) 2007 Joseph Method
-# Copyright (C) 2014, 2016 Matijs van Zuijlen
+# This file is part of Alexandria.
 #
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '/../lib'))
 
@@ -25,14 +11,9 @@ require 'alexandria'
 LIBDIR = File.expand_path(File.join(File.dirname(__FILE__), '/data/libraries'))
 TESTDIR = File.join(LIBDIR, 'test')
 
-# def useTestLibrary(version)
-#  libVersion = File.join(LIBDIR, version)
-#  FileUtils.cp_r(libVersion, TESTDIR)
-# end
-
 def an_artist_of_the_floating_world
   Alexandria::Book.new('An Artist of the Floating World',
-                       'Kazuo Ishiguro',
+                       ['Kazuo Ishiguro'],
                        '9780571147168',
                        'Faber and Faber', 1999,
                        'Paperback')
@@ -40,8 +21,15 @@ end
 
 Alexandria::UI::Icons.init
 
-module Alexandria
-  class Library
-    DIR.replace TESTDIR
+test_store = Alexandria::LibraryStore.new(TESTDIR)
+Alexandria::LibraryCollection.instance.library_store = test_store
+
+RSpec.configure do |config|
+  config.before do
+    FileUtils.rm_rf(TESTDIR)
+  end
+
+  config.after do
+    FileUtils.rm_rf(TESTDIR)
   end
 end

data/tasks/spec.rake

@@ -28,6 +28,19 @@
 
 require 'rspec/core/rake_task'
 
-RSpec::Core::RakeTask.new(:spec) do |t|
-  t.ruby_opts = ['-rbundler/setup -rsimplecov -Ilib -w']
+namespace 'spec' do
+  RSpec::Core::RakeTask.new('unit') do |t|
+    t.pattern = 'spec/alexandria/**/*_spec.rb'
+    t.ruby_opts = ['-rbundler/setup -rsimplecov -Ilib -w']
+  end
+
+  RSpec::Core::RakeTask.new('end_to_end') do |t|
+    t.pattern = 'spec/end_to_end/**/*_spec.rb'
+    t.ruby_opts = ['-rbundler/setup -rsimplecov -Ilib -w']
+  end
+
+  desc 'Runs all unit and end-to-end specs'
+  task 'all' => ['spec:unit', 'spec:end_to_end']
 end
+
+task default: 'spec:all'

data/util/rake/fileinstall.rb

@@ -214,6 +214,7 @@ class FileInstallTask < Rake::TaskLib
   # can be similarly deleted, and if it is then empty.
   def delete_if_empty(p)
     return false unless p.directory?
+
     p.children.each do |c|
       delete_if_empty(c)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: alexandria-book-collection-manager
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Alexander McCormmach
@@ -28,7 +28,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-18 00:00:00.000000000 Z
+date: 2019-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gettext
@@ -48,30 +48,30 @@ dependencies:
   name: gstreamer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.1
+        version: 3.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.1
+        version: 3.3.0
 - !ruby/object:Gem::Dependency
   name: gtk3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.1
+        version: 3.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.1
+        version: 3.3.0
 - !ruby/object:Gem::Dependency
   name: hpricot
   requirement: !ruby/object:Gem::Requirement
@@ -106,14 +106,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: marc
   requirement: !ruby/object:Gem::Requirement
@@ -142,6 +142,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.5.0
+- !ruby/object:Gem::Dependency
+  name: gnome_app_driver
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.1
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -193,6 +207,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".hound.yml"
 - ".reek"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
@@ -227,9 +242,7 @@ files:
 - lib/alexandria/book_providers/amazon_aws.rb
 - lib/alexandria/book_providers/amazon_ecs_util.rb
 - lib/alexandria/book_providers/barnes_and_noble.rb
-- lib/alexandria/book_providers/deastore.rb
 - lib/alexandria/book_providers/douban.rb
-- lib/alexandria/book_providers/mcu.rb
 - lib/alexandria/book_providers/proxis.rb
 - lib/alexandria/book_providers/pseudomarc.rb
 - lib/alexandria/book_providers/renaud.rb
@@ -242,9 +255,13 @@ files:
 - lib/alexandria/console.rb
 - lib/alexandria/default_preferences.rb
 - lib/alexandria/execution_queue.rb
+- lib/alexandria/export_format.rb
 - lib/alexandria/export_library.rb
 - lib/alexandria/import_library.rb
 - lib/alexandria/import_library_csv.rb
+- lib/alexandria/library_collection.rb
+- lib/alexandria/library_sort_order.rb
+- lib/alexandria/library_store.rb
 - lib/alexandria/logging.rb
 - lib/alexandria/models/book.rb
 - lib/alexandria/models/library.rb
@@ -268,6 +285,7 @@ files:
 - lib/alexandria/ui/dialogs/book_properties_dialog_base.rb
 - lib/alexandria/ui/dialogs/export_dialog.rb
 - lib/alexandria/ui/dialogs/import_dialog.rb
+- lib/alexandria/ui/dialogs/keep_bad_isbn_dialog.rb
 - lib/alexandria/ui/dialogs/misc_dialogs.rb
 - lib/alexandria/ui/dialogs/new_book_dialog.rb
 - lib/alexandria/ui/dialogs/new_book_dialog_manual.rb
@@ -445,10 +463,14 @@ files:
 - share/sounds/alexandria/scanning.wav
 - spec/alexandria/book_providers_spec.rb
 - spec/alexandria/book_spec.rb
+- spec/alexandria/console_spec.rb
+- spec/alexandria/export_library_spec.rb
 - spec/alexandria/library_spec.rb
+- spec/alexandria/library_store_spec.rb
 - spec/alexandria/preferences_spec.rb
 - spec/alexandria/scanners/cuecat_spec.rb
 - spec/alexandria/smart_library_spec.rb
+- spec/alexandria/ui/dialogs/new_book_dialog_spec.rb
 - spec/alexandria/ui/dialogs_spec.rb
 - spec/alexandria/ui/iconview_spec.rb
 - spec/alexandria/ui/main_app_spec.rb
@@ -474,6 +496,7 @@ files:
 - spec/data/libraries/0.6.2/My Library/9780575079038.yaml
 - spec/data/libraries/0.6.2/My Library/9780755322800.cover
 - spec/data/libraries/0.6.2/My Library/9780755322800.yaml
+- spec/end_to_end/basic_run_spec.rb
 - spec/spec_helper.rb
 - tasks/dogtail.rake
 - tasks/setup.rb
@@ -502,8 +525,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: GNOME application for managing collections of books