alexandria-book-collection-manager 0.7.2 → 0.7.3

data/share/gnome/help/alexandria/C/introduction.xml

@@ -44,10 +44,6 @@
 	      <para><ulink url="http://www.barnesandnoble.com">Barnes and Noble</ulink></para>
 	    </listitem>
 
-	    <listitem>
-	      <para><ulink url="http://www.mcu.es">Spanish Ministry of Culture</ulink></para>
-	    </listitem>
-
 	    <listitem>
 	      <para><ulink url="http://www.thalia.de">Thalia</ulink></para>
 	    </listitem>

data/share/gnome/help/alexandria/ja/introduction.xml

@@ -36,10 +36,6 @@
 	      <para><ulink url="http://www.barnesandnoble.com">Barnes and Noble</ulink></para>
 	    </listitem>
 
-	    <listitem>
-	      <para><ulink url="http://www.mcu.es">Spanish Ministry of Culture</ulink></para>
-	    </listitem>
-
 	    <listitem>
 	      <para><ulink url="http://www.thalia.de">Thalia</ulink></para>
 	    </listitem>

data/spec/alexandria/book_providers_spec.rb

@@ -96,16 +96,6 @@ describe Alexandria::BookProviders do
                                  'Confederacy Dunces', Alexandria::BookProviders::SEARCH_BY_KEYWORD)
   end
 
-  it 'dea should work' do
-    skip 'DEAStore is not operational at the moment'
-    assert_correct_search_result(Alexandria::BookProviders::DeaStoreProvider,
-                                 '9788817012980')
-    assert_correct_search_result(Alexandria::BookProviders::DeaStoreProvider,
-                                 '9788806134747')
-  end
-
-  # Right? Don't test if dependency isn't present.
-
   it 'LOC should work' do
     assert_correct_search_result(Alexandria::BookProviders::LOCProvider,
                                  '9780805335583')
@@ -115,6 +105,7 @@ describe Alexandria::BookProviders do
   end
 
   it 'BL should work' do
+    skip 'Not working: connect failed'
     assert_correct_search_result(Alexandria::BookProviders::BLProvider,
                                  '9781853260803')
   end
@@ -130,16 +121,6 @@ describe Alexandria::BookProviders do
                                  '9780961328917') # see #1433
   end
 
-  it 'MCU should work' do
-    skip 'Needs fixing'
-    # this book is without binding information, see bug [#2533]
-    assert_correct_search_result(Alexandria::BookProviders::MCUProvider,
-                                 '9788487982033')
-    # this book is "agotado" (out of print), see bug [#2518]
-    assert_correct_search_result(Alexandria::BookProviders::MCUProvider,
-                                 '9788496075856')
-  end
-
   it 'Proxis should work' do
     skip 'Needs fixing'
     assert_correct_search_result(Alexandria::BookProviders::ProxisProvider,

data/spec/alexandria/console_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require 'spec_helper'
+
+RSpec.describe Alexandria do
+  let(:lib_version) { File.join(LIBDIR, '0.6.2') }
+
+  before do
+    FileUtils.rm_rf(TESTDIR)
+    FileUtils.cp_r(lib_version, TESTDIR)
+  end
+
+  describe '.list_books_on_console' do
+    it 'returns a string containing a list of all books' do
+      expect(Alexandria.list_books_on_console).to eq <<~LIST
+        The Dispossessed, Ursula Le Guin
+        Pattern Recognition, William Gibson
+        Bonjour Tristesse, Francoise Sagan & Irene Ash
+        An Artist of the Floating World, Kazuo Ishiguro
+        Neverwhere, Neil Gaiman
+      LIST
+    end
+  end
+
+  after do
+    FileUtils.rm_rf(TESTDIR)
+  end
+end

data/spec/alexandria/export_library_spec.rb

@@ -0,0 +1,141 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require 'spec_helper'
+
+RSpec.describe Alexandria::ExportLibrary do
+  let(:lib_version) { File.join(LIBDIR, '0.6.2') }
+
+  let(:loader) { Alexandria::LibraryStore.new(TESTDIR) }
+
+  let(:format) { Alexandria::ExportFormat.all.find { |it| it.message == message } }
+  let(:outfile_base) { format.ext ? "my-library.#{format.ext}" : 'my-library' }
+  let(:outfile) { File.join(Dir.tmpdir, outfile_base) }
+
+  let(:unsorted) { Alexandria::LibrarySortOrder::Unsorted.new }
+
+  before do
+    FileUtils.cp_r(lib_version, TESTDIR)
+    @my_library = loader.load_library('My Library')
+    expect(@my_library.size).to eq 5
+  end
+
+  describe '#export_as_csv_list' do
+    let(:message) { :export_as_csv_list }
+
+    def load_rows_from_csv
+      CSV.read(outfile, col_sep: ';')
+    end
+
+    it 'can sort by title' do
+      sort_by_title = Alexandria::LibrarySortOrder.new(:title)
+      format.invoke(@my_library, sort_by_title, outfile)
+      expect(File.exist?(outfile)).to be_truthy
+      rows = load_rows_from_csv
+      rows.shift
+      expect(rows.size).to eq(@my_library.size)
+      TITLE = 0
+      comparisons = rows.size - 1
+      comparisons.times do |index|
+        expect(rows[index][TITLE]).to be <= rows[index + 1][TITLE]
+      end
+    end
+
+    it 'can sort in descending order' do
+      sort_by_date_desc = Alexandria::LibrarySortOrder.new(:publishing_year, false)
+      format.invoke(@my_library, sort_by_date_desc, outfile)
+      expect(File.exist?(outfile)).to be_truthy
+      rows = load_rows_from_csv
+      rows.shift
+      expect(rows.size).to eq(@my_library.size)
+      DATE = 5
+      comparisons = rows.size - 1
+      comparisons.times do |index|
+        expect(rows[index][DATE]).to be >= rows[index + 1][DATE]
+      end
+    end
+  end
+
+  describe '#export_as_html' do
+    let(:message) { :export_as_html }
+    let(:index) { File.join(outfile, 'index.html') }
+
+    it 'can export unsorted' do
+      format.invoke(@my_library, unsorted, outfile, Alexandria::WebTheme.all.first)
+      aggregate_failures do
+        expect(File.exist?(outfile)).to be_truthy
+        expect(File.exist?(index)).to be_truthy
+        expect(File.size(index)).to be_nonzero
+      end
+    end
+  end
+
+  describe '#export_as_onix_xml_archive' do
+    let(:message) { :export_as_onix_xml_archive }
+
+    it 'can export unsorted' do
+      format.invoke(@my_library, unsorted, outfile)
+      aggregate_failures do
+        expect(File.exist?(outfile)).to be_truthy
+        expect(File.size(outfile)).to be_nonzero
+      end
+    end
+  end
+
+  describe '#export_as_tellico_xml_archive' do
+    let(:message) { :export_as_tellico_xml_archive }
+
+    it 'can export unsorted' do
+      format.invoke(@my_library, unsorted, outfile)
+      aggregate_failures do
+        expect(File.exist?(outfile)).to be_truthy
+        expect(File.size(outfile)).to be_nonzero
+      end
+    end
+  end
+
+  describe '#export_as_bibtex' do
+    let(:message) { :export_as_bibtex }
+
+    it 'can export unsorted' do
+      format.invoke(@my_library, unsorted, outfile)
+      aggregate_failures do
+        expect(File.exist?(outfile)).to be_truthy
+        expect(File.size(outfile)).to be_nonzero
+      end
+    end
+  end
+
+  describe '#export_as_isbn_list' do
+    let(:message) { :export_as_isbn_list }
+
+    it 'can export unsorted' do
+      format.invoke(@my_library, unsorted, outfile)
+      aggregate_failures do
+        expect(File.exist?(outfile)).to be_truthy
+        expect(File.size(outfile)).to be_nonzero
+      end
+    end
+  end
+
+  describe '#export_as_ipod_notes' do
+    let(:message) { :export_as_ipod_notes }
+    let(:index) { File.join(outfile, 'index.linx') }
+
+    it 'can export unsorted' do
+      format.invoke(@my_library, unsorted, outfile, nil)
+      aggregate_failures do
+        expect(File.exist?(outfile)).to be_truthy
+        expect(File.size(index)).to be_nonzero
+      end
+    end
+  end
+
+  after(:each) do
+    FileUtils.rm_rf(TESTDIR)
+    FileUtils.rm_rf(outfile) if File.exist? outfile
+  end
+end

data/spec/alexandria/library_spec.rb

@@ -1,28 +1,14 @@
 # frozen_string_literal: true
 
-#-- -*- ruby -*-
-# Copyright (C) 2004-2006 Dafydd Harries
-# Copyright (C) 2007 Cathal Mc Ginley
-# Copyright (C) 2011, 2014-2016 Matijs van Zuijlen
+# This file is part of Alexandria.
 #
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
 require 'spec_helper'
 
 describe Alexandria::Library do
+  let(:loader) { Alexandria::LibraryStore.new(TESTDIR) }
+
   describe '::EXT' do
     it 'has symbolic references to file extensions' do
       extensions = Alexandria::Library::EXT
@@ -86,12 +72,13 @@ describe Alexandria::Library do
   end
 
   context 'with an empty library' do
+    let(:my_library) { loader.load_library('Empty') }
+
     before(:each) do
       FileUtils.mkdir(TESTDIR) unless File.exist? TESTDIR
     end
 
     it 'disallows multiple deletion of the same copy of a book' do
-      my_library = Alexandria::Library.loadall[0]
       first_copy = an_artist_of_the_floating_world
       my_library << first_copy
       my_library.delete(first_copy)
@@ -99,9 +86,7 @@ describe Alexandria::Library do
     end
 
     it 'allows multiple copies of a book to be added and deleted in turn' do
-      my_library = Alexandria::Library.loadall[0]
       first_copy = an_artist_of_the_floating_world
-      # puts "first_copy #{first_copy.object_id}"
       my_library << first_copy
       my_library.delete(first_copy)
 
@@ -110,13 +95,7 @@ describe Alexandria::Library do
       third_copy = an_artist_of_the_floating_world
       my_library << third_copy
 
-      # puts "AAA my_library.size #{my_library.size}"
-
-      # puts "second_copy #{second_copy.object_id}"
       expect { my_library.delete(second_copy) }.not_to raise_error
-
-      # puts "BBB my_library.size #{my_library.size}"
-      # my_library.size.should == 1 # not yet an established feature...
     end
 
     after(:each) do
@@ -125,12 +104,8 @@ describe Alexandria::Library do
   end
 
   describe '.import_as_isbn_list' do
-    before :all do
-      require 'alexandria/import_library'
-    end
-
     def __test_fake_import_isbns
-      libraries = Alexandria::Libraries.instance
+      libraries = Alexandria::LibraryCollection.instance
       library = Alexandria::Library.new('Test Library')
       libraries.add_library(library)
       [library, libraries]
@@ -154,7 +129,7 @@ describe Alexandria::Library do
     end
 
     it 'imports cleanly from version 0.6.1 data format' do
-      libs = Alexandria::Library.loadall
+      libs = loader.load_all_libraries
       expect(libs.size).to eq(1)
       my_library = libs[0]
       expect(my_library.size).to eq(3)
@@ -182,7 +157,7 @@ describe Alexandria::Library do
     end
 
     it 'allows books to have no ISBN' do
-      libs = Alexandria::Library.loadall
+      libs = loader.load_all_libraries
       expect(libs.size).to eq(1)
       my_library = libs[0]
       expect(my_library.size).to eq(2)
@@ -197,13 +172,11 @@ describe Alexandria::Library do
       lex_and_yacc_book = my_library.select { |b| b.title.include? 'Lex' }[0]
       expect(lex_and_yacc_book.publisher).to eq("O'Reilley")
 
-      # puts "ident -> " + lex_and_yacc_book.ident
-
       my_library.each do |book|
         my_library.save(book, true)
       end
 
-      libraries_reloaded = Alexandria::Library.loadall
+      libraries_reloaded = loader.load_all_libraries
       my_library_reloaded = libraries_reloaded[0]
 
       expect(my_library_reloaded.size).to eq(2)
@@ -211,12 +184,10 @@ describe Alexandria::Library do
       latex_book = my_library_reloaded.select { |b| b.title.include? 'Latex' }[0]
       expect(latex_book).not_to be_nil
       expect(latex_book.publisher).to eq('Addison Wesley')
-      # puts latex_book.title
 
       lex_and_yacc_book = my_library_reloaded.select { |b| b.title.include? 'Lex' }[0]
       expect(lex_and_yacc_book).not_to be_nil
       expect(lex_and_yacc_book.publisher).to eq("O'Reilley")
-      # puts lex_and_yacc_book.title
     end
 
     after(:each) do
@@ -224,55 +195,28 @@ describe Alexandria::Library do
     end
   end
 
-  context 'when exporting' do
-    before(:all) do
-      require 'tmpdir'
-      require 'csv'
-    end
-
+  describe '.move' do
     before(:each) do
       lib_version = File.join(LIBDIR, '0.6.2')
       FileUtils.cp_r(lib_version, TESTDIR)
-      @format = Alexandria::ExportFormat.new('CSV list', 'csv', :export_as_csv_list)
-      @outfile = File.join(Dir.tmpdir, 'my_library-0.6.2.csv')
-      @my_library = Alexandria::Library.loadall[0]
     end
 
-    def load_rows_from_csv
-      CSV.read(@outfile, col_sep: ';')
-    end
+    it 'moves the given book from source to target' do
+      source = loader.load_library('My Library')
+      count = source.count
+      book = source.first
+      target = loader.load_library('Target')
 
-    it 'can sort by title' do
-      sort_by_title = Alexandria::LibrarySortOrder.new(:title)
-      @format.invoke(@my_library, sort_by_title, @outfile)
-      expect(File.exist?(@outfile)).to be_truthy
-      rows = load_rows_from_csv
-      rows.shift
-      expect(rows.size).to eq(@my_library.size)
-      TITLE = 0
-      comparisons = rows.size - 1
-      comparisons.times do |index|
-        expect(rows[index][TITLE]).to be <= rows[index + 1][TITLE]
-      end
-    end
+      described_class.move(source, target, source.first)
 
-    it 'can sort in descending order' do
-      sort_by_date_desc = Alexandria::LibrarySortOrder.new(:publishing_year, false)
-      @format.invoke(@my_library, sort_by_date_desc, @outfile)
-      expect(File.exist?(@outfile)).to be_truthy
-      rows = load_rows_from_csv
-      rows.shift
-      expect(rows.size).to eq(@my_library.size)
-      DATE = 5
-      comparisons = rows.size - 1
-      comparisons.times do |index|
-        expect(rows[index][DATE]).to be >= rows[index + 1][DATE]
+      aggregate_failures do
+        expect(source.count).to eq count - 1
+        expect(target.count).to eq 1
+        expect(File.exist? source.yaml(book)).to be_falsey
+        expect(File.exist? source.cover(book)).to be_falsey
+        expect(File.exist? target.yaml(book)).to be_truthy
+        expect(File.exist? target.cover(book)).to be_truthy
       end
     end
-
-    after(:each) do
-      FileUtils.rm_rf(TESTDIR)
-      File.unlink @outfile if File.exist? @outfile
-    end
   end
 end

data/spec/alexandria/library_store_spec.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require 'spec_helper'
+
+RSpec.describe Alexandria::LibraryStore do
+  let(:loader) { described_class.new(TESTDIR) }
+
+  describe '#load_all_smart_libraries' do
+    context 'when none exist' do
+      it 'creates and saves some' do
+        smart_libs = loader.load_all_smart_libraries
+        aggregate_failures do
+          expect(smart_libs.size).to eq 5
+          smart_libs.each do |lib|
+            expect(File.exist? lib.yaml).to be_truthy
+          end
+        end
+      end
+    end
+
+    context 'when one exists' do
+      it 'returns the existing smart library' do
+        existing = Alexandria::SmartLibrary.new('Hi', [], :all, loader)
+        existing.save
+        smart_libs = loader.load_all_smart_libraries
+        aggregate_failures do
+          expect(smart_libs.size).to eq 1
+          expect(smart_libs.first.yaml).to eq existing.yaml
+        end
+      end
+    end
+  end
+end