alexandria-book-collection-manager 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68616d81acb2df9a9457285c4393b569a4d217c9e5b25371ad0e2addf3e24d93
-  data.tar.gz: 2f3f920293bfc91c7d23cb380c2b0a9806ca0eecf3112639ff859db8fee10faf
+  metadata.gz: c5ce199935fd434ee40793e79cf4f8ad31c4f140e26844ae0bad7f6d111d5486
+  data.tar.gz: 76f857b281f0b11c6485d4196b2f47e3980eb4ff8ea7fe89797e7321388f0cf2
 SHA512:
-  metadata.gz: e80f5e730a5d0e81e776968853974043cd672abf8e9aaffd568a9ae82c80c70c5a6ff86a6306072809690743e96fb473b32c292a09f2fc349b6a5b60abdbf07c
-  data.tar.gz: a7a037e7ac5cb5c91cf2f707fa77a34996fd1935cce22113fd0555868d146e47da892d64206bc61f065a3c853e4603d6e80c1e117be347d378e0ee9c989a4f32
+  metadata.gz: 4f49799facc13291bac2d34f82af36fc2cd9461eddf21b0f2cb30fa089517f4f5f2ed41713cba354c72a9143df5273059614969257834836ea604213fe05f47a
+  data.tar.gz: 89ab1a4b55b5df6b1ae9c2ec5f0ebcf82ad79e10208c6ff51572f59ccfa59ebeed51dfecac96b15e4442ffe081c5f717b2491478d3cad870aa1ae9be0012572e

data/.gitignore

@@ -12,3 +12,4 @@ pkg/
 coverage/
 tmp/
 *.gem
+*.glade~

data/.hound.yml

@@ -0,0 +1,2 @@
+ruby:
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -25,6 +25,10 @@ Layout/MultilineMethodCallIndentation:
 Layout/SpaceBeforeBlockBraces:
   EnforcedStyleForEmptyBraces: space
 
+Layout/AlignHash:
+  EnforcedColonStyle: key
+  EnforcedHashRocketStyle: table
+
 # Allow if (foo = get_foo) style
 Lint/AssignmentInCondition:
   AllowSafeAssignment: true
@@ -49,10 +53,6 @@ Style/BlockDelimiters:
 Style/AndOr:
   Enabled: conditionals
 
-# Prefer old school format strings
-Style/FormatStringToken:
-  EnforcedStyle: unannotated
-
 # Require at least two dependent lines before suggesting a guard clause
 Style/GuardClause:
   MinBodyLength: 2

data/.rubocop_todo.yml

@@ -1,41 +1,17 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-03-18 12:56:55 +0100 using RuboCop version 0.53.0.
+# on 2019-02-27 08:50:25 +0100 using RuboCop version 0.65.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 12
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
-Layout/IndentHeredoc:
-  Exclude:
-    - 'Rakefile'
-    - 'bin/alexandria'
-    - 'lib/alexandria/export_library.rb'
-    - 'lib/alexandria/ui/dialogs/about_dialog.rb'
-
-# Offense count: 6
-Lint/HandleExceptions:
-  Exclude:
-    - 'lib/alexandria/import_library_csv.rb'
-    - 'lib/alexandria/models/library.rb'
-    - 'lib/alexandria/ui/dialogs/book_properties_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/import_dialog.rb'
-
 # Offense count: 2
 Lint/IneffectiveAccessModifier:
   Exclude:
     - 'lib/alexandria/logging.rb'
     - 'lib/alexandria/web_themes.rb'
 
-# Offense count: 1
-Lint/UnreachableCode:
-  Exclude:
-    - 'lib/alexandria/ui/dialogs/export_dialog.rb'
-
 # Offense count: 1
 Lint/UriEscapeUnescape:
   Exclude:
@@ -47,20 +23,15 @@ Lint/UselessAccessModifier:
   Exclude:
     - 'lib/alexandria/logging.rb'
 
-# Offense count: 2
-Lint/UselessAssignment:
-  Exclude:
-    - 'lib/alexandria/models/library.rb'
-    - 'lib/alexandria/smart_library.rb'
-
 # Offense count: 165
 Metrics/AbcSize:
   Max: 161
 
-# Offense count: 22
+# Offense count: 21
 # Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 67
+  Max: 66
 
 # Offense count: 13
 # Configuration parameters: CountBlocks.
@@ -70,30 +41,30 @@ Metrics/BlockNesting:
 # Offense count: 32
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 994
+  Max: 985
 
-# Offense count: 68
+# Offense count: 65
 Metrics/CyclomaticComplexity:
-  Max: 28
+  Max: 22
 
-# Offense count: 219
-# Configuration parameters: CountComments.
+# Offense count: 212
+# Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 109
 
-# Offense count: 2
+# Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 348
+  Max: 338
 
 # Offense count: 10
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 69
+# Offense count: 62
 Metrics/PerceivedComplexity:
-  Max: 29
+  Max: 23
 
 # Offense count: 8
 Naming/BinaryOperatorParameterName:
@@ -105,9 +76,9 @@ Naming/BinaryOperatorParameterName:
     - 'lib/alexandria/smart_library.rb'
     - 'lib/alexandria/ui/multi_drag_treeview.rb'
 
-# Offense count: 15
+# Offense count: 13
 # Configuration parameters: Blacklist.
-# Blacklist: END, (?-mix:EO[A-Z]{1})
+# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
   Exclude:
     - 'Rakefile'
@@ -116,17 +87,12 @@ Naming/HeredocDelimiterNaming:
     - 'lib/alexandria/ui/dialogs/about_dialog.rb'
 
 # Offense count: 2
+# Configuration parameters: EnforcedStyleForLeadingUnderscores.
+# SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
   Exclude:
     - 'lib/alexandria/logging.rb'
 
-# Offense count: 1
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: snake_case, camelCase
-Naming/MethodName:
-  Exclude:
-    - 'lib/alexandria/book_providers/mcu.rb'
-
 # Offense count: 4
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
@@ -142,7 +108,7 @@ Naming/PredicateName:
 
 # Offense count: 10
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id
+# AllowedNames: io, id, to, by, on, in, at, ip, db
 Naming/UncommunicativeMethodParamName:
   Exclude:
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
@@ -176,21 +142,21 @@ Style/ClassVars:
     - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
     - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
 
-# Offense count: 12
+# Offense count: 11
 Style/CommentedKeyword:
   Exclude:
     - 'lib/alexandria/book_providers.rb'
     - 'lib/alexandria/book_providers/barnes_and_noble.rb'
     - 'lib/alexandria/book_providers/worldcat.rb'
-    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
     - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
     - 'util/rake/fileinstall.rb'
 
-# Offense count: 118
+# Offense count: 112
 Style/Documentation:
   Enabled: false
 
 # Offense count: 6
+# Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: each, for
 Style/For:
@@ -200,37 +166,58 @@ Style/For:
     - 'lib/alexandria/book_providers/renaud.rb'
     - 'spec/alexandria/library_spec.rb'
 
+# Offense count: 65
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
+  Exclude:
+    - 'lib/alexandria/book_providers.rb'
+    - 'lib/alexandria/ui/callbacks.rb'
+    - 'lib/alexandria/ui/dialogs/acquire_dialog.rb'
+    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
+    - 'lib/alexandria/ui/dialogs/export_dialog.rb'
+    - 'lib/alexandria/ui/dialogs/keep_bad_isbn_dialog.rb'
+    - 'lib/alexandria/ui/dialogs/misc_dialogs.rb'
+    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
+    - 'lib/alexandria/ui/dialogs/new_book_dialog_manual.rb'
+    - 'lib/alexandria/ui/dialogs/preferences_dialog.rb'
+    - 'lib/alexandria/ui/dialogs/smart_library_properties_dialog.rb'
+    - 'lib/alexandria/ui/dndable.rb'
+    - 'lib/alexandria/ui/listview.rb'
+    - 'lib/alexandria/ui/sidepane.rb'
+    - 'lib/alexandria/ui/ui_manager.rb'
+
 # Offense count: 34
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
 
-# Offense count: 4
+# Offense count: 2
 Style/IdenticalConditionalBranches:
   Exclude:
     - 'lib/alexandria/book_providers/amazon_aws.rb'
-    - 'lib/alexandria/ui/ui_manager.rb'
 
-# Offense count: 4
-Style/IfInsideElse:
+# Offense count: 1
+Style/MethodMissingSuper:
   Exclude:
-    - 'lib/alexandria/book_providers/proxis.rb'
-    - 'lib/alexandria/book_providers/web.rb'
     - 'lib/alexandria/preferences.rb'
-    - 'lib/alexandria/ui/ui_manager.rb'
 
 # Offense count: 2
-Style/MethodMissing:
+Style/MissingRespondToMissing:
   Exclude:
     - 'lib/alexandria/book_providers.rb'
     - 'lib/alexandria/preferences.rb'
 
-# Offense count: 1
-Style/MultilineTernaryOperator:
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: Whitelist.
+# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
+Style/NestedParenthesizedCalls:
   Exclude:
-    - 'lib/alexandria/ui/listview.rb'
+    - 'spec/alexandria/library_spec.rb'
+    - 'spec/alexandria/library_store_spec.rb'
 
-# Offense count: 23
+# Offense count: 21
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed
@@ -239,27 +226,13 @@ Style/RegexpLiteral:
     - 'lib/alexandria/book_providers/adlibris.rb'
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
     - 'lib/alexandria/book_providers/douban.rb'
-    - 'lib/alexandria/book_providers/mcu.rb'
     - 'lib/alexandria/book_providers/proxis.rb'
     - 'lib/alexandria/book_providers/pseudomarc.rb'
     - 'lib/alexandria/book_providers/renaud.rb'
     - 'lib/alexandria/book_providers/siciliano.rb'
     - 'lib/alexandria/book_providers/thalia.rb'
-    - 'lib/alexandria/models/library.rb'
+    - 'lib/alexandria/library_store.rb'
     - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
     - 'lib/alexandria/ui/sidepane.rb'
     - 'util/rake/fileinstall.rb'
     - 'util/rake/gettextgenerate.rb'
-
-# Offense count: 78
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, explicit
-Style/RescueStandardError:
-  Enabled: false
-
-# Offense count: 3
-Style/StructInheritance:
-  Exclude:
-    - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/multi_drag_treeview.rb'

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 0.7.3 / 2019-02-27
+
+* Remove DeaStore provider since the site is no longer online
+* Remove MCU provider since the site is no longer online
+* Various code cleanups
+* Update dependencies on `gstreamer`, `gtk3` and `image_size`
+* Call `#set_active` with `false` instead of `nil` (Fixes [#19])
+* Spec and fix export functionality
+* Do not hard-code storage location
+* Silence some Gtk+ warnings
+* Fix setup of default scanner when no scanner is configured
+* Update `YAML.safe_load` calls to new API, silencing deprecation warnings
+
 ## 0.7.2 / 2018-03-18
 
 * Update dependencies
@@ -50,3 +63,7 @@
 * Amazon queries now use a Associate Tag, a new requirement of
   Amazon's Product Advertising API. Thanks to Stephen McCamant for
   providing the patch.
+
+<!-- references -->
+
+[#19]: https://github.com/mvz/alexandria-book-collection-manager/issues/19

data/INSTALL.md

@@ -26,13 +26,13 @@ Requires version `~> 3.1`.
 ### Hpricot
 
 Alexandria uses [hpricot](https://github.com/hpricot/hpricot) to
-parse the HTML from web pages for providers such as DeaStore and
-Siciliano. It is also used to parse the XML for the Amazon web
+parse the HTML from web pages for providers such as Siciliano.
+It is also used to parse the XML for the Amazon web
 service.
 
 ## HTMLEntities
 
-This is used by all website-based providers except MCU.
+This is used by all website-based providers.
 [htmlentities](https://github.com/threedaymonk/htmlentities) is used to
 provide more flexible HTML parsing.
 

data/README.md

@@ -43,7 +43,6 @@ keep track of books which are on loan.
       pictures) from several online libraries and bookshops, such as
           o Amazon
           o Proxis
-          o DeaStore
           o AdLibris
           o Spanish Ministry of Culture
           o Livraria Siciliano
@@ -152,7 +151,7 @@ Unless otherwise noted, the following license applies to all files that are
 part of Alexandria:
 
 Copyright (C) 2004-2006 Laurent Sansonetti
-Copyright (C) 2007-2010,2014-2016 Alexandria Contributors
+Copyright (C) 2007-2010,2014-2018 Alexandria Contributors
 
 Alexandria is free software; you can redistribute it and/or modify it under the
 terms of the GNU General Public License as published by the Free Software

data/Rakefile

@@ -1,31 +1,8 @@
 # frozen_string_literal: true
 
-# -*- ruby -*-
-#--
-# Copyright (C) 2009 Cathal Mc Ginley
-# Copyright (C) 2011, 2014, 2016 Matijs van Zuijlen
-#
 # This file is part of the Alexandria build system.
 #
-# Permission is hereby granted, free of charge, to any person obtaining
-# a copy of this software and associated documentation files (the
-# "Software"), to deal in the Software without restriction, including
-# without limitation the rights to use, copy, modify, merge, publish,
-# distribute, sublicense, and/or sell copies of the Software, and to
-# permit persons to whom the Software is furnished to do so, subject to
-# the following conditions:
-#
-# The above copyright notice and this permission notice shall be
-# included in all copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-#++
+# See the file README.md for authorship and licensing information.
 
 load 'tasks/setup.rb'
 
@@ -148,17 +125,20 @@ file 'lib/alexandria/default_preferences.rb' => [SCHEMA_PATH] do |f|
   doc.elements.each('gconfschemafile/schemalist/schema') do |element|
     default = element.elements['default'].text
     next unless default
+
     varname = File.basename(element.elements['key'].text)
     type = element.elements['type'].text
 
     if (type == 'list') || (type == 'pair')
       ary = default[1..-2].split(',')
       next if ary.empty?
+
       if type == 'list'
         list_type = element.elements['list_type'].text
         ary.map! { |x| convert_with_type(x, list_type) }
       elsif type == 'pair'
         next if ary.length != 2
+
         ary[0] = convert_with_type(ary[0],
                                    element.elements['car_type'].text)
         ary[1] = convert_with_type(ary[1],
@@ -173,15 +153,15 @@ file 'lib/alexandria/default_preferences.rb' => [SCHEMA_PATH] do |f|
   end
 
   generate(f.name) do
-    <<EOS
-module Alexandria
-  class Preferences
-    DEFAULT_VALUES = {
-      #{generated_lines.join(",\n      ")}
-    }
-  end
-end
-EOS
+    <<~EOS
+      module Alexandria
+        class Preferences
+          DEFAULT_VALUES = {
+            #{generated_lines.join(",\n      ")}
+          }
+        end
+      end
+    EOS
   end
 end
 
@@ -237,6 +217,7 @@ task :scrollkeeper do
   unless system('which scrollkeeper-update')
     raise 'scrollkeeper-update cannot be found, is Scrollkeeper correctly installed?'
   end
+
   system('scrollkeeper-update -q') || raise('Scrollkeeper update failed')
 end