alexandria-book-collection-manager 0.7.1 → 0.7.6

data/doc/cuecat_support.rdoc

@@ -0,0 +1,67 @@
+= CueCat Barcode Scanner Support
+
+Alexandria now supports the use of unmodified CueCat barcode scanners
+for scanning ISBN barcodes.
+
+
+== What is a CueCat?
+
+The CueCat is a wand-style barcode scanner, available with either a
+PS/2 keyboard connector (and a PS/2 keyboard pass-through), or with a
+standard keyboard-type USB connector. 
+
+You scan a barcode by placing the 'nose' of the scanner on one side of
+the barcode, in the clear area before the first black bar, and waiting
+until the flashing red light stops flashing and illuminates the
+surface brightly, then swiftly passing the scanner across the barcode
+and into the clear area on the far side. The scan data is then input
+into your computer as if through a keyboard. You can test the
+operation of your CueCat by placing your keyboard cursor inside any
+text editor and scanning a barcode.
+
+By default the scan data is scrambled. There are instructions, widely
+available on the Internet, detailing how to modify the circuit board to
+disable scrambling, but some barcode scanning applications, including
+Alexandria, can automatically decode scrambled data from a CueCat.
+
+
+== The History of CueCat?
+
+Millions of CueCat scanners were distributed free of charge by their
+creator the Digital Convergence Corporation in the late 1990s and
+early 2000s. The intention was that customers would use the scanners
+to scan special barcodes in magazine advertisments and articles, and
+software would take the customers to a related web page.
+
+Dozens of eager hackers, upon recieving these barcode scanners,
+immediately set about finding a way to use them for a wider variety of
+purposes, such as book cataloging. They decoded the very simple
+scrambling of the scanner output data (it was a form of Base64
+encoding), and even reported on how to lift a single microchip pin to
+circumvent the scrambling in hardware. They also discovered that each
+CueCat has a unique serial number (which could have allowed
+DigitalConvergence to build up profiles of the products customers were
+interested in) and showed how to zero-out or avoid the serial number.
+
+Digital Convergence attempted to restrict such activities, but
+eventually the company went bust, leaving several electronics
+warehouses to buy up hundreds of thousands of unshipped CueCats in the
+ensuing liquidation sale.
+
+Today, PS/2 and USB CueCat scanners are available cheaply over the
+internet (about US$12 in 2007). Apart from the slight inconvenience
+caused by the data scrambling, they are eminently usable as cheap,
+robust, wand-style barcode scanners.
+
+== The Old Linux Driver
+
+A kernel driver for the CueCat was developed as a patch for the 2.4
+Linux kernel series. This provided decoding of the scrambled input,
+and made input data available from <tt>/dev/scanners/cuecat</tt>.
+
+Since this driver is currently unmaintained and does not work with 2.6
+kernels, support for this has been dropped from Alexandria. However,
+since Alexandria 0.6.2, there is so-called 'userland' support for the
+CueCat, which simply means that modifications to the kernel are not
+necessary. Instead, the decoding of the simple data scrambling is done
+by the application software.

data/doc/dependency_decisions.yml

@@ -0,0 +1,80 @@
+---
+- - :permit
+  - LGPL-3+
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2017-07-23 05:51:53.629753437 Z
+- - :permit
+  - LGPL-2.1+
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2017-07-23 05:52:02.088395832 Z
+- - :permit
+  - MIT
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2017-07-23 05:52:06.806192042 Z
+- - :permit
+  - LGPLv2+
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2017-07-23 05:52:24.618189811 Z
+- - :permit
+  - ruby
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2017-07-23 05:52:36.986497403 Z
+- - :approve
+  - alexandria-book-collection-manager
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2017-07-23 05:53:02.657760962 Z
+- - :approve
+  - unf
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2017-07-23 05:54:45.171526986 Z
+- - :approve
+  - gettext
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2017-07-23 05:54:51.349832715 Z
+- - :approve
+  - cairo
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2017-07-23 05:54:54.822319735 Z
+- - :license
+  - zoom
+  - LGPL-2.1
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2020-07-30 06:44:22.960902375 Z
+- - :permit
+  - Simplified BSD
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2020-07-30 06:45:58.599399721 Z
+- - :permit
+  - Apache 2.0
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2020-07-30 06:46:08.280121582 Z
+- - :permit
+  - LGPL-2.1
+  - :who: 
+    :why: 
+    :versions: []
+    :when: 2020-07-30 06:46:32.729325577 Z

data/lib/alexandria.rb

@@ -1,22 +1,10 @@
-# Copyright (C) 2004-2006 Laurent Sansonetti
-# Copyright (C) 2011, 2016 Matijs van Zuijlen
-#
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
 #
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
-require 'gettext'
+require "gettext"
 
 # XXX: Gettext hotfix
 module Gem
@@ -28,18 +16,20 @@ module Gem
   end
 end
 
-require 'logger'
-require 'alexandria/logging'
-require 'alexandria/about'
+require "logger"
+require "alexandria/logging"
+require "alexandria/about"
 
 module Alexandria
   def self.set_proxy
-    ENV['http_proxy'] = nil if !ENV['http_proxy'].nil? && URI.parse(ENV['http_proxy']).userinfo.nil?
+    if !ENV["http_proxy"].nil? && URI.parse(ENV["http_proxy"]).userinfo.nil?
+      ENV["http_proxy"] = nil
+    end
   end
 
   def self.set_log_level
-    Alexandria.log.level = Logger::DEBUG if $DEBUG
-    Alexandria.log.debug { 'Initializing Alexandria...' }
+    log.level = Logger::DEBUG if $DEBUG
+    log.debug { "Initializing Alexandria" }
   end
 
   def self.main
@@ -51,8 +41,8 @@ end
 
 # lrz says 'macui' is obsolete (may be supported again some day)
 # unless $MACOSX
-require 'alexandria/config'
-require 'alexandria/version'
+require "alexandria/config"
+require "alexandria/version"
 
 # else
 #  module Alexandria
@@ -63,20 +53,22 @@ require 'alexandria/version'
 #  end
 # end
 
-require 'alexandria/models/book'
-require 'alexandria/models/library'
+require "alexandria/models/book"
+require "alexandria/library_store"
+require "alexandria/library_collection"
+require "alexandria/models/library"
 
-require 'alexandria/smart_library'
-require 'alexandria/execution_queue'
-require 'alexandria/import_library'
-require 'alexandria/export_library'
-require 'alexandria/book_providers'
-require 'alexandria/preferences'
-require 'alexandria/undo_manager'
-require 'alexandria/web_themes'
+require "alexandria/smart_library"
+require "alexandria/execution_queue"
+require "alexandria/import_library"
+require "alexandria/export_library"
+require "alexandria/book_providers"
+require "alexandria/preferences"
+require "alexandria/undo_manager"
+require "alexandria/web_themes"
 
 # lrz says 'macui' is obsolete (may be supported again some day)
 # require $MACOSX ? 'alexandria/macui' : 'alexandria/ui'
 
-require 'alexandria/ui'
-require 'alexandria/console'
+require "alexandria/ui"
+require "alexandria/console"

data/lib/alexandria/about.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 # Copyright (C) 2004-2006 Laurent Sansonetti
 # Copyright (C) 2008 Joseph Method
 # Copyright (C) 2015 Matijs van Zuijlen
@@ -19,64 +20,64 @@
 # Fifth Floor, Boston, MA 02110-1301 USA.
 
 module Alexandria
-  TITLE = 'Alexandria'.freeze
-  TEXTDOMAIN = 'alexandria'.freeze
+  TITLE = "Alexandria"
+  TEXTDOMAIN = "alexandria"
   extend GetText
-  bindtextdomain(Alexandria::TEXTDOMAIN, charset: 'UTF-8')
-  DESCRIPTION = _('A program to help you manage your book collection.')
+  bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
+  DESCRIPTION = _("A program to help you manage your book collection.")
   COPYRIGHT = "Copyright (C) 2004-2006 Laurent Sansonetti\n" \
-    'Copyright (C) 2007-2010,2014,2015 Alexandria Contributors'.freeze
+    "Copyright (C) 2007-2010,2014,2015 Alexandria Contributors"
   AUTHORS = [
-    'Alexander McCormmach <alexander@tunicate.org>',
-    'Aymeric Nys <aymeric@nnx.com>',
-    'Cathal Mc Ginley <cathal.alexandria@gnostai.org>',
-    'Claudio Belotti <bel8@lilik.it>',
-    'Constantine Evans <cevans@costinet.org>',
-    'Dafydd Harries <daf@muse.19inch.net>',
-    'Javier Fernandez-Sanguino Pena <jfs@debian.org>',
-    'Joseph Method <tristil@gmail.com>',
-    'Kevin Schultz <schultkl@ieee.org>',
-    'Laurent Sansonetti <lrz@gnome.org>',
-    'Marco Costantini <costanti@science.unitn.it>',
-    'Mathieu Leduc-Hamel <arrak@arrak.org>',
-    'Matijs van Zuijlen <matijs@matijs.net>',
-    'Owain Evans <o.evans@gmail.com>',
-    'Pascal Terjan <pterjan@linuxfr.org>',
-    'Rene Samselnig <sandman@sdm-net.org>',
-    'Robby Stephenson <robby@periapsis.org>',
-    'Sun Ning <classicning@gmail.com>',
-    'Takayuki Kusano <AE5T-KSN@asahi-net.or.jp>',
-    'Timothy Malone <timothy.malone@gmail.com>',
-    'Zachary P. Landau <kapheine@hypa.net>'
+    "Alexander McCormmach <alexander@tunicate.org>",
+    "Aymeric Nys <aymeric@nnx.com>",
+    "Cathal Mc Ginley <cathal.alexandria@gnostai.org>",
+    "Claudio Belotti <bel8@lilik.it>",
+    "Constantine Evans <cevans@costinet.org>",
+    "Dafydd Harries <daf@muse.19inch.net>",
+    "Javier Fernandez-Sanguino Pena <jfs@debian.org>",
+    "Joseph Method <tristil@gmail.com>",
+    "Kevin Schultz <schultkl@ieee.org>",
+    "Laurent Sansonetti <lrz@gnome.org>",
+    "Marco Costantini <costanti@science.unitn.it>",
+    "Mathieu Leduc-Hamel <arrak@arrak.org>",
+    "Matijs van Zuijlen <matijs@matijs.net>",
+    "Owain Evans <o.evans@gmail.com>",
+    "Pascal Terjan <pterjan@linuxfr.org>",
+    "Rene Samselnig <sandman@sdm-net.org>",
+    "Robby Stephenson <robby@periapsis.org>",
+    "Sun Ning <classicning@gmail.com>",
+    "Takayuki Kusano <AE5T-KSN@asahi-net.or.jp>",
+    "Timothy Malone <timothy.malone@gmail.com>",
+    "Zachary P. Landau <kapheine@hypa.net>"
   ].freeze
   DOCUMENTERS = [
-    'Cathal Mc Ginley <cathal.alexandria@gnostai.org>',
-    'Liam Davison <registrations@liamjdavison.info>'
+    "Cathal Mc Ginley <cathal.alexandria@gnostai.org>",
+    "Liam Davison <registrations@liamjdavison.info>"
   ].freeze
   TRANSLATORS = [
-    'Adrián Chaves Fernández <adriyetichaves@gmail.com> (gl)',
-    'Cathal Mc Ginley <cathal.alexandria@gnostai.org> (ga)',
-    'CHIKAMA Masaki <masaki.chikama@gmail.com> (ja)',
-    'Dafydd Harries <daf@muse.19inch.net> (cy)',
-    'Damjan Dimitrioski <damjandimitrioski@gmail.com> (mk)',
-    'Giacomo Margarito <giacomomargarito@gmail.com> (it)',
-    'Jack Myrseh <jack@enkom.no> (nb)',
-    'Joachim Breitner <mail@joachim-breitner.de> (de)',
-    'José Ling <jlgdot369@gmail.com> (zh_TW)',
-    'Lennart Karssen <lennart@karssen.org> (nl)',
-    'Lígia Moreira <ligia.moreira@netvisao.pt> (fr, pt, pt_BR)',
-    'Martin Karlsson <martinkarlsson81@hotmail.com> (sv)',
-    'Michael Kotsarinis <mkotsari1@pre.forthnet.gr> (el)',
-    'Miguel Ángel García <magmax@ieee.org> (es)',
-    'Peter Kováč <kovac.peter@fotopriestor.sk> (sk)',
-    'Petr Vanek <vanous@penguin.cz> (cs)',
-    'Piotr Drąg <piotrdrag@gmail.com> (pl)',
-    'Serhij Dubyk <dubyk@library.lviv.ua> (uk)'
+    "Adrián Chaves Fernández <adriyetichaves@gmail.com> (gl)",
+    "Cathal Mc Ginley <cathal.alexandria@gnostai.org> (ga)",
+    "CHIKAMA Masaki <masaki.chikama@gmail.com> (ja)",
+    "Dafydd Harries <daf@muse.19inch.net> (cy)",
+    "Damjan Dimitrioski <damjandimitrioski@gmail.com> (mk)",
+    "Giacomo Margarito <giacomomargarito@gmail.com> (it)",
+    "Jack Myrseh <jack@enkom.no> (nb)",
+    "Joachim Breitner <mail@joachim-breitner.de> (de)",
+    "José Ling <jlgdot369@gmail.com> (zh_TW)",
+    "Lennart Karssen <lennart@karssen.org> (nl)",
+    "Lígia Moreira <ligia.moreira@netvisao.pt> (fr, pt, pt_BR)",
+    "Martin Karlsson <martinkarlsson81@hotmail.com> (sv)",
+    "Michael Kotsarinis <mkotsari1@pre.forthnet.gr> (el)",
+    "Miguel Ángel García <magmax@ieee.org> (es)",
+    "Peter Kováč <kovac.peter@fotopriestor.sk> (sk)",
+    "Petr Vanek <vanous@penguin.cz> (cs)",
+    "Piotr Drąg <piotrdrag@gmail.com> (pl)",
+    "Serhij Dubyk <dubyk@library.lviv.ua> (uk)"
   ].freeze
   ARTISTS = [
-    'Andreas Nilsson <nisses.mail@home.se>',
-    'Stefanie Dijoux <stefanie.dijoux@gmail.com>'
+    "Andreas Nilsson <nisses.mail@home.se>",
+    "Stefanie Dijoux <stefanie.dijoux@gmail.com>"
   ].freeze
-  BUGREPORT_URL = 'http://www.github.com/mvz/alexandria-book-collection-manager/issues'.freeze
-  WEBSITE_URL = 'http://www.github.com/mvz/alexandria-book-collection-manager'.freeze
+  BUGREPORT_URL = "http://www.github.com/mvz/alexandria-book-collection-manager/issues"
+  WEBSITE_URL = "http://www.github.com/mvz/alexandria-book-collection-manager"
 end

data/lib/alexandria/book_providers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (C) 2004-2006 Laurent Sansonetti
 # Copyright (C) 2009 Cathal Mc Ginley
 # Copyright (C) 2011, 2014 Matijs van Zuijlen
@@ -17,8 +19,8 @@
 # write to the Free Software Foundation, Inc., 51 Franklin Street,
 # Fifth Floor, Boston, MA 02110-1301 USA.
 
-require 'singleton'
-require 'observer'
+require "singleton"
+require "observer"
 
 module Alexandria
   # FIXME: Use delegation instead of inheritance.
@@ -27,27 +29,28 @@ module Alexandria
     include Singleton
     include Observable
     include GetText
-    GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: 'UTF-8')
+    GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
 
     SEARCH_BY_ISBN, SEARCH_BY_TITLE, SEARCH_BY_AUTHORS,
     SEARCH_BY_KEYWORD = (0..3).to_a
 
     class SearchError < StandardError; end
     class NoResultsError < SearchError; end
-    class ProviderSkippedError < NoResultsError; end # not an error :^(
-    class SearchEmptyError < SearchError; end # sigh, again not really an error
     class TooManyResultsError < SearchError; end
     class InvalidSearchTypeError < SearchError; end
 
+    # These errors are not really errors
+    class ProviderSkippedError < NoResultsError; end
+    class SearchEmptyError < SearchError; end
+
     def self.search(criterion, type)
       factory_n = 0
-      # puts "book_providers search #{self.instance.count_observers}"
 
       begin
         factory = instance[factory_n]
-        puts factory.fullname + ' lookup' if $DEBUG
+        log.debug { factory.fullname + " lookup" }
         unless factory.enabled
-          puts factory.fullname + ' disabled!, skipping...' if $DEBUG
+          log.debug { factory.fullname + " disabled!, skipping..." }
           raise ProviderSkippedError
         end
         instance.changed
@@ -62,14 +65,14 @@ module Alexandria
           instance.notify_observers(:not_found, factory.fullname) # new
           raise NoResultsError
         else
-          log.info { 'found at ' + factory.fullname }
+          log.info { "found at " + factory.fullname }
           instance.changed
           instance.notify_observers(:found, factory.fullname) # new
-          return results
+          results
         end
-      rescue => boom
-        if boom.is_a? NoResultsError
-          unless boom.instance_of? ProviderSkippedError
+      rescue StandardError => ex
+        if ex.is_a? NoResultsError
+          unless ex.instance_of? ProviderSkippedError
             instance.changed
             instance.notify_observers(:not_found, factory.fullname) # new
             Thread.new { sleep(0.5) }.join
@@ -78,41 +81,41 @@ module Alexandria
           instance.changed
           instance.notify_observers(:error, factory.fullname) # new
           Thread.new { sleep(0.5) }.join # hrmmmm, to make readable...
-          trace = boom.backtrace.join("\n >")
-          log.warn { "Provider #{factory.name} encountered error: #{boom.message} #{trace}" }
+          trace = ex.backtrace.join("\n >")
+          log.warn { "Provider #{factory.name} encountered error: #{ex.message} #{trace}" }
         end
-        if last == factory
+        if factory == instance.last
           log.warn { "Error while searching #{criterion}" }
-          message = case boom
+          message = case ex
                     when Timeout::Error
                       _("Couldn't reach the provider '%s': timeout " \
-                        'expired.') % factory.name
+                        "expired.") % factory.name
 
                     when SocketError
-                      _("Couldn't reach the provider '%s': socket " \
-                        'error (%s).') % [factory.name, boom.message]
+                      format(_("Couldn't reach the provider '%s': socket " \
+                        "error (%s)."), factory.name, ex.message)
 
                     when NoResultsError
-                      _('No results were found.  Make sure your ' \
-                        'search criterion is spelled correctly, and ' \
-                        'try again.')
+                      _("No results were found.  Make sure your " \
+                        "search criterion is spelled correctly, and " \
+                        "try again.")
 
                     when ProviderSkippedError
-                      _('No results were found.  Make sure your ' \
-                        'search criterion is spelled correctly, and ' \
-                        'try again.')
+                      _("No results were found.  Make sure your " \
+                        "search criterion is spelled correctly, and " \
+                        "try again.")
 
                     when TooManyResultsError
-                      _('Too many results for that search.')
+                      _("Too many results for that search.")
 
                     when InvalidSearchTypeError
-                      _('Invalid search type.')
+                      _("Invalid search type.")
 
                     else
-                      boom.message
+                      ex.message
                     end
-          puts "raising empty error #{message}"
-          raise SearchEmptyError, message
+          log.debug { "raising empty error #{message}" }
+          raise SearchEmptyError, message # rubocop:disable GetText/DecorateFunctionMessage
         else
           factory_n += 1
           retry
@@ -150,9 +153,8 @@ module Alexandria
         end
 
         def new_value=(new_value)
-          message = @provider.variable_name(self) + '='
-          Alexandria::Preferences.instance.send(message,
-                                                new_value)
+          name = @provider.variable_name(self)
+          Alexandria::Preferences.instance.set_variable(name, new_value)
           self.value = new_value
         end
 
@@ -185,9 +187,9 @@ module Alexandria
 
       def read
         each do |var|
-          message = @provider.variable_name(var)
-          val = Alexandria::Preferences.instance.send(message)
-          var.value = val unless val.nil? || ((val == '') && var.mandatory?)
+          name = @provider.variable_name(var)
+          val = Alexandria::Preferences.instance.get_variable(name)
+          var.value = val unless val.nil? || ((val == "") && var.mandatory?)
         end
       end
     end
@@ -201,35 +203,35 @@ module Alexandria
         @name = name
         @fullname = (fullname || name)
         @prefs = Preferences.new(self)
-        @prefs.add('enabled', _('Enabled'), true, [true, false])
+        @prefs.add("enabled", _("Enabled"), true, [true, false])
       end
 
       def enabled
-        @prefs['enabled']
+        @prefs["enabled"]
       end
 
       def toggle_enabled
         old_value = enabled
-        @prefs.variable_named('enabled').new_value = !old_value
+        @prefs.variable_named("enabled").new_value = !old_value
       end
 
       def reinitialize(fullname)
-        @name << '_' << fullname.hash.to_s
+        @name = "#{name}_#{fullname.hash}"
         @fullname = fullname
         prefs = Alexandria::Preferences.instance
-        ary = prefs.abstract_providers
+        ary = prefs.get_variable :abstract_providers
         ary ||= []
         ary << @name
-        prefs.abstract_providers = ary
-        message = variable_name('name') + '='
-        prefs.send(message, @fullname)
+        prefs.set_variable :abstract_providers, ary
+        message = variable_name("name")
+        prefs.set_variable(message, @fullname)
       end
 
       def remove
         prefs = Alexandria::Preferences.instance
-        if (ary = prefs.abstract_providers)
+        if (ary = prefs.get_variable :abstract_providers)
           ary.delete(@name)
-          prefs.abstract_providers = ary
+          prefs.set_variable :abstract_providers, ary
         end
         if (ary = prefs.providers_priority) && ary.include?(@name)
           ary.delete(@name)
@@ -239,7 +241,7 @@ module Alexandria
           name = variable_name(variable)
           prefs.remove_preference(name)
         end
-        name = variable_name('name')
+        name = variable_name("name")
         prefs.remove_preference(name)
         prefs.save!
       end
@@ -253,7 +255,7 @@ module Alexandria
             else
               raise
             end
-        @name.downcase + '_' + s
+        @name.downcase + "_" + s
       end
 
       def transport
@@ -269,10 +271,11 @@ module Alexandria
         !included_modules.include?(Singleton)
       end
 
-      def <=>(provider)
-        fullname <=> provider.fullname
+      def <=>(other)
+        fullname <=> other.fullname
       end
 
+      # FIXME: Clean up this complex abstract/concrete class system
       def self.unabstract
         include Singleton
         undef_method :reinitialize
@@ -286,29 +289,21 @@ module Alexandria
       unabstract
     end
 
-    require 'alexandria/book_providers/mcu' # yep, still mostly works !
-    require 'alexandria/book_providers/douban' # only requires YAML
-
-    # require 'alexandria/book_providers/ibs_it'
-    # require 'alexandria/book_providers/renaud'
-    # require 'alexandria/book_providers/bol_it'
-    # require 'alexandria/book_providers/webster_it'
-    log.info { 'Not loading IBS, Renaud, BOL, Webster (providers not functional)' }
+    require "alexandria/book_providers/douban" # only requires YAML
 
     # Amazon AWS (Amazon Associates Web Services) provider, needs hpricot
-    require 'alexandria/book_providers/amazon_aws'
+    require "alexandria/book_providers/amazon_aws"
 
     # Website based providers
-    require 'alexandria/book_providers/adlibris'
-    require 'alexandria/book_providers/barnes_and_noble'
-    require 'alexandria/book_providers/deastore'
-    require 'alexandria/book_providers/proxis'
-    require 'alexandria/book_providers/siciliano'
-    require 'alexandria/book_providers/thalia'
-    require 'alexandria/book_providers/worldcat'
+    require "alexandria/book_providers/adlibris"
+    require "alexandria/book_providers/barnes_and_noble"
+    require "alexandria/book_providers/proxis"
+    require "alexandria/book_providers/siciliano"
+    require "alexandria/book_providers/thalia"
+    require "alexandria/book_providers/worldcat"
 
     # Z39.50 based providers
-    require 'alexandria/book_providers/z3950'
+    require "alexandria/book_providers/z3950"
 
     attr_reader :abstract_classes
 
@@ -328,11 +323,11 @@ module Alexandria
       self.class.constants.each do |constant|
         md = /(.+)Provider$/.match(constant)
         next unless md
+
         klass = self.class.module_eval(constant.to_s)
-        if klass.ancestors.include?(AbstractProvider) &&
+        if klass < AbstractProvider &&
             (klass != GenericProvider) &&
-            (klass != WebsiteBasedProvider) &&
-            (klass != AbstractProvider)
+            (klass != WebsiteBasedProvider)
 
           if klass.abstract?
             @abstract_classes << klass
@@ -341,15 +336,18 @@ module Alexandria
           end
         end
       end
-      if (ary = @prefs.abstract_providers)
+      if (ary = @prefs.get_variable :abstract_providers)
         ary.each do |name|
           md = /^(.+)_/.match(name)
           next unless md
-          klass_name = md[1] + 'Provider'
+
+          klass_name = md[1] + "Provider"
           klass = @abstract_classes.find { |x| x.name.include?(klass_name) }
           next unless klass
-          fullname = @prefs.send(name.downcase + '_name')
+
+          fullname = @prefs.send(name.downcase + "_name")
           next unless fullname
+
           instance = klass.new
           instance.name = name
           instance.fullname = fullname
@@ -367,41 +365,36 @@ module Alexandria
       compact!
     end
 
-    # FIXME: Define the handful of methods that use this.
-    def self.method_missing(id, *args, &block)
-      if instance.respond_to? id
-        instance.method(id).call(*args, &block)
-      else
-        super
-      end
+    def self.list
+      instance
+    end
+
+    def self.abstract_classes
+      instance.abstract_classes
     end
 
     private
 
     def rejig_providers_priority
       priority = (@prefs.providers_priority || [])
-      unless priority.empty?
-        changed = false
+      return if priority.empty?
 
-        if (ecs_index = priority.index('AmazonECS'))
-          priority[ecs_index] = 'Amazon' # replace legacy "AmazonECS" name
-          priority.uniq! # remove any other "Amazon" from the list
-          changed = true
-        end
-        if (deastore_index = priority.index('DeaStore_it'))
-          priority[deastore_index] = 'DeaStore'
-          changed = true
-        end
-        if (worldcat_index = priority.index('Worldcat'))
-          priority[worldcat_index] = 'WorldCat'
-          changed = true
-        end
-        if (adlibris_index = priority.index('Adlibris'))
-          priority[adlibris_index] = 'AdLibris'
-          changed = true
-        end
-        @prefs.providers_priority = priority if changed
+      changed = false
+
+      if (ecs_index = priority.index("AmazonECS"))
+        priority[ecs_index] = "Amazon" # replace legacy "AmazonECS" name
+        priority.uniq! # remove any other "Amazon" from the list
+        changed = true
+      end
+      if (worldcat_index = priority.index("Worldcat"))
+        priority[worldcat_index] = "WorldCat"
+        changed = true
+      end
+      if (adlibris_index = priority.index("Adlibris"))
+        priority[adlibris_index] = "AdLibris"
+        changed = true
       end
+      @prefs.providers_priority = priority if changed
     end
   end
 end