alexandria-book-collection-manager 0.7.1 → 0.7.6

data/lib/alexandria/config.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module Alexandria
   module Config
-    SHARE_DIR = File.expand_path('../../share', File.dirname(__FILE__))
-    SOUNDS_DIR = "#{SHARE_DIR}/sounds/alexandria".freeze
-    DATA_DIR = "#{SHARE_DIR}/alexandria".freeze
+    SHARE_DIR = File.expand_path("../../share", File.dirname(__FILE__))
+    SOUNDS_DIR = "#{SHARE_DIR}/sounds/alexandria"
+    DATA_DIR = "#{SHARE_DIR}/alexandria"
     MAIN_DATA_DIR = DATA_DIR
   end
 end

data/lib/alexandria/console.rb

@@ -1,30 +1,19 @@
-# Copyright (C) 2008 Joseph Method
-#
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
 #
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
 
 module Alexandria
   def self.list_books_on_console(_title = true, authors = true)
-    libraries_simpleton = Alexandria::Libraries.instance
-    libraries_simpleton.reload
-    libraries = Alexandria::Library.loadall
-    output_string = ''
+    collection = Alexandria::LibraryCollection.instance
+    collection.reload
+    libraries = collection.all_regular_libraries
+    output_string = ""
     @books = libraries.flatten
     @books.each do |book|
-      book_authors = book.authors.join(' & ') if authors
-      output_string += [book.title, book_authors].join(', ') + "\n"
+      book_authors = book.authors.join(" & ") if authors
+      output_string += [book.title, book_authors].join(", ") + "\n"
     end
     output_string
   end

data/lib/alexandria/default_preferences.rb

@@ -0,0 +1,37 @@
+# This file is automatically generated by the alexandria installer.
+# Do not edit it directly.
+
+module Alexandria
+  class Preferences
+    DEFAULT_VALUES = {
+      "position" => [0, 0],
+      "size" => [640, 480],
+      "maximized" => false,
+      "sidepane_position" => 140,
+      "view_as" => 0,
+      "arrange_icons_mode" => 0,
+      "reverse_icons" => false,
+      "selected_library" => "",
+      "barcode_scanner" => "CueCat",
+      "play_scanning_sound" => true,
+      "play_scan_sound" => true,
+      "toolbar_visible" => true,
+      "sidepane_visible" => true,
+      "statusbar_visible" => true,
+      "col_authors_visible" => true,
+      "col_edition_visible" => true,
+      "col_isbn_visible" => true,
+      "col_publisher_visible" => true,
+      "col_publish_date_visible" => true,
+      "col_loaned_to_visible" => true,
+      "col_rating_visible" => true,
+      "col_redd_visible" => true,
+      "col_own_visible" => true,
+      "col_want_visible" => true,
+      "col_tags_visible" => true,
+      "cols_width" => "{}",
+      "providers_priority" => ["Amazon", "BarnesAndNoble", "AdLibris", "Proxis", "Thalia", "Siciliano", "WorldCat", "LOC", "BL", "SBN"],
+      "view_advanced_settings" => false
+    }
+  end
+end

data/lib/alexandria/execution_queue.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (C) 2005-2006 Laurent Sansonetti
 #
 # Alexandria is free software; you can redistribute it and/or
@@ -15,8 +17,6 @@
 # write to the Free Software Foundation, Inc., 51 Franklin Street,
 # Fifth Floor, Boston, MA 02110-1301 USA.
 
-require 'thread'
-
 # Provides a way for two threads to communicate via Proc objects.
 #
 # Thread A can request calls, providing a Proc object and runtime arguments,
@@ -41,7 +41,7 @@ module Alexandria
 
     def self.current
       @@current_queue
-    rescue
+    rescue StandardError
       nil
     end
 
@@ -60,12 +60,14 @@ module Alexandria
         break @pending_calls.pop
       end
       return if ary.nil?
+
       id, procedure, args, need_retval = ary
       retval = procedure.call(*args)
-      if need_retval
-        @protect_pending_retvals.synchronize do
-          @pending_retvals << [id, retval]
-        end
+
+      return unless need_retval
+
+      @protect_pending_retvals.synchronize do
+        @pending_retvals << [id, retval]
       end
     end
 
@@ -80,14 +82,14 @@ module Alexandria
         @id += 1
         @pending_calls << [@id, procedure, args, need_retval]
       end
-      if need_retval
-        loop do
-          @protect_pending_retvals.synchronize do
-            ary = @pending_retvals.find { |id, _retval| id == @id }
-            if ary
-              @pending_retvals.delete(ary)
-              return ary[1]
-            end
+      return unless need_retval
+
+      loop do
+        @protect_pending_retvals.synchronize do
+          ary = @pending_retvals.find { |id, _retval| id == @id }
+          if ary
+            @pending_retvals.delete(ary)
+            return ary[1]
           end
         end
       end

data/lib/alexandria/export_format.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+module Alexandria
+  class ExportFormat
+    attr_reader :name, :ext, :message
+
+    include GetText
+    include Logging
+    extend GetText
+    bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
+
+    def self.all
+      [
+        new(_("Archived ONIX XML"), "onix.tbz2", :export_as_onix_xml_archive),
+        new(_("Archived Tellico XML"), "tc", :export_as_tellico_xml_archive),
+        new(_("BibTeX"), "bib", :export_as_bibtex),
+        new(_("CSV list"), "csv", :export_as_csv_list),
+        new(_("ISBN List"), "txt", :export_as_isbn_list),
+        new(_("iPod Notes"), nil, :export_as_ipod_notes),
+        new(_("HTML Web Page"), nil, :export_as_html, true)
+      ]
+    end
+
+    def invoke(library, sort_order, filename, *args)
+      sorted = ExportLibrary.new(library, sort_order)
+      log.debug { "Exporting library sorted by #{sort_order}" }
+      sorted.send(@message, filename, *args)
+    end
+
+    def needs_preview?
+      @needs_preview
+    end
+
+    private
+
+    def initialize(name, ext, message, needs_preview = false)
+      @name = name
+      @ext = ext
+      @message = message
+      @needs_preview = needs_preview
+    end
+  end
+end

data/lib/alexandria/export_library.rb

@@ -1,75 +1,18 @@
-# Copyright (C) 2004-2006 Laurent Sansonetti
-# Copyright (C) 2007 Cathal Mc Ginley
-# Copyright (C) 2014, 2016 Matijs van Zuijlen
-#
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# frozen_string_literal: true
 
-# Export sorting added 23 Oct 2007 by Cathal Mc Ginley
-# Classes LibrarySortOrder and SortedLibrary, and changed ExportFormat#invoke
-# iPod Notes support added 20 January 2008 by Tim Malone
-# require 'cgi'
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
 
-require 'csv'
-require 'image_size'
+require "csv"
+require "image_size"
+require "tmpdir"
 
 module Alexandria
-  class LibrarySortOrder
-    include Logging
-
-    def initialize(book_attribute, ascending = true)
-      @book_attribute = book_attribute
-      @ascending = ascending
-    end
-
-    def sort(library)
-      sorted = library.sort_by do |book|
-        book.send(@book_attribute)
-      end
-      sorted.reverse! unless @ascending
-      sorted
-    rescue => ex
-      log.warn { "Could not sort library by #{@book_attribute.inspect}: #{ex.message}" }
-      library
-    end
-
-    def to_s
-      "#{@book_attribute} #{@ascending ? '(ascending)' : '(descending)'}"
-    end
-
-    class Unsorted < LibrarySortOrder
-      def initialize; end
-
-      def sort(library)
-        library
-      end
-
-      def to_s
-        'default order'
-      end
-    end
-  end
-
-  class SortedLibrary < Library
+  class ExportLibrary
     def initialize(library, sort_order)
-      super(library.name)
       @library = library
-      sorted = sort_order.sort(library)
-      sorted.each do |book|
-        self << book
-      end
+      @sorted = sort_order.sort(library)
     end
 
     def cover(book)
@@ -83,89 +26,45 @@ module Alexandria
     def copy_covers(dest)
       @library.copy_covers(dest)
     end
-  end
-
-  class ExportFormat
-    attr_reader :name, :ext, :message
-
-    include GetText
-    include Logging
-    extend GetText
-    bindtextdomain(Alexandria::TEXTDOMAIN, charset: 'UTF-8')
-
-    def self.all
-      [
-        new(_('Archived ONIX XML'), 'onix.tbz2', :export_as_onix_xml_archive),
-        new(_('Archived Tellico XML'), 'tc', :export_as_tellico_xml_archive),
-        new(_('BibTeX'), 'bib', :export_as_bibtex),
-        new(_('CSV list'), 'csv', :export_as_csv_list),
-        new(_('ISBN List'), 'txt', :export_as_isbn_list),
-        new(_('iPod Notes'), nil, :export_as_ipod_notes),
-        new(_('HTML Web Page'), nil, :export_as_html, true)
-      ]
-    end
 
-    def invoke(library, sort_order, filename, *args)
-      if sort_order
-        sorted = SortedLibrary.new(library, sort_order)
-        log.debug { "Exporting library sorted by #{sort_order}" }
-        sorted.send(@message, filename, *args)
-      else
-        library.send(@message, filename, *args)
-      end
-    end
-
-    def needs_preview?
-      @needs_preview
+    def name
+      @library.name
     end
 
-    private
-
-    def initialize(name, ext, message, needs_preview = false)
-      @name = name
-      @ext = ext
-      @message = message
-      @needs_preview = needs_preview
+    def each(&block)
+      @sorted.each(&block)
     end
-  end
 
-  module Exportable
     def export_as_onix_xml_archive(filename)
-      File.open(File.join(Dir.tmpdir, 'onix.xml'), 'w') do |io|
+      File.open(File.join(Dir.tmpdir, "onix.xml"), "w") do |io|
         to_onix_document.write(io, 0)
       end
-      copy_covers(File.join(Dir.tmpdir, 'images'))
+      copy_covers(File.join(Dir.tmpdir, "images"))
       Dir.chdir(Dir.tmpdir) do
         output = `tar -cjf \"#{filename}\" onix.xml images 2>&1`
         raise output unless $CHILD_STATUS.success?
       end
-      FileUtils.rm_rf(File.join(Dir.tmpdir, 'images'))
-      FileUtils.rm(File.join(Dir.tmpdir, 'onix.xml'))
+      FileUtils.rm_rf(File.join(Dir.tmpdir, "images"))
+      FileUtils.rm(File.join(Dir.tmpdir, "onix.xml"))
     end
 
     def export_as_tellico_xml_archive(filename)
-      File.open(File.join(Dir.tmpdir, 'tellico.xml'), 'w') do |io|
-        begin
-          to_tellico_document.write(io, 0)
-        rescue => ex
-          puts ex.message
-          puts ex.backtrace
-          raise ex
-        end
+      File.open(File.join(Dir.tmpdir, "tellico.xml"), "w") do |io|
+        to_tellico_document.write(io, 0)
       end
-      copy_covers(File.join(Dir.tmpdir, 'images'))
+      copy_covers(File.join(Dir.tmpdir, "images"))
       Dir.chdir(Dir.tmpdir) do
         output = `zip -q -r \"#{filename}\" tellico.xml images 2>&1`
         raise output unless $CHILD_STATUS.success?
       end
-      FileUtils.rm_rf(File.join(Dir.tmpdir, 'images'))
-      FileUtils.rm(File.join(Dir.tmpdir, 'tellico.xml'))
+      FileUtils.rm_rf(File.join(Dir.tmpdir, "images"))
+      FileUtils.rm(File.join(Dir.tmpdir, "tellico.xml"))
     end
 
     def export_as_isbn_list(filename)
-      File.open(filename, 'w') do |io|
+      File.open(filename, "w") do |io|
         each do |book|
-          io.puts((book.isbn || ''))
+          io.puts((book.isbn || ""))
         end
       end
     end
@@ -173,19 +72,17 @@ module Alexandria
     def export_as_html(filename, theme)
       FileUtils.mkdir(filename) unless File.exist?(filename)
       Dir.chdir(filename) do
-        copy_covers('pixmaps')
-        if theme.has_pixmaps?
-          FileUtils.cp_r(theme.pixmaps_directory, 'pixmaps')
-        end
-        FileUtils.cp(theme.css_file, '.')
-        File.open('index.html', 'w') do |io|
+        copy_covers("pixmaps")
+        FileUtils.cp_r(theme.pixmaps_directory, "pixmaps") if theme.has_pixmaps?
+        FileUtils.cp(theme.css_file, ".")
+        File.open("index.html", "w") do |io|
           io << to_xhtml(File.basename(theme.css_file))
         end
       end
     end
 
     def export_as_bibtex(filename)
-      File.open(filename, 'w') do |io|
+      File.open(filename, "w") do |io|
         io << to_bibtex
       end
     end
@@ -194,27 +91,28 @@ module Alexandria
       FileUtils.mkdir(filename) unless File.exist?(filename)
       tempdir = Dir.getwd
       Dir.chdir(filename)
-      copy_covers('pixmaps')
-      File.open('index.linx', 'w') do |io|
-        io.puts '<TITLE>' + name + '</TITLE>'
+      copy_covers("pixmaps")
+      File.open("index.linx", "w") do |io|
+        io.puts "<TITLE>" + name + "</TITLE>"
         each do |book|
-          io.puts '<A HREF="' + book.ident + '">' + book.title + '</A>'
+          io.puts '<A HREF="' + book.ident + '">' + book.title + "</A>"
         end
         io.close
       end
       each do |book|
-        File.open(book.ident, 'w') do |io|
+        File.open(book.ident, "w") do |io|
           io.puts "<TITLE>#{book.title} </TITLE>"
           # put a link to the book's cover. only works on iPod 5G and above(?).
           if File.exist?(cover(book))
-            io.puts '<A HREF="pixmaps/' + book.ident + '.jpg' + '">' + book.title + '</A>'
+            io.puts '<A HREF="pixmaps/' + book.ident + ".jpg" + '">' + book.title + "</A>"
           else
             io.puts book.title
           end
-          io.puts book.authors.join(', ')
+          io.puts book.authors.join(", ")
           io.puts book.edition
-          io.puts((book.isbn || ''))
-          # we need to close the files so the iPod can be ejected/unmounted without us closing Alexandria
+          io.puts((book.isbn || ""))
+          # we need to close the files so the iPod can be ejected/unmounted
+          # without us closing Alexandria
           io.close
         end
       end
@@ -223,85 +121,83 @@ module Alexandria
     end
 
     def export_as_csv_list(filename)
-      CSV.open(filename, 'w', col_sep: ';') do |csv|
-        csv << ['Title', 'Authors', 'Publisher', 'Edition', 'ISBN', 'Year Published',
-                "Rating(#{Book::DEFAULT_RATING} to #{Book::MAX_RATING_STARS})", 'Notes',
-                'Want?', 'Read?', 'Own?', 'Tags']
+      CSV.open(filename, "w", col_sep: ";") do |csv|
+        csv << ["Title", "Authors", "Publisher", "Edition", "ISBN", "Year Published",
+                "Rating(#{Book::DEFAULT_RATING} to #{Book::MAX_RATING_STARS})", "Notes",
+                "Want?", "Read?", "Own?", "Tags"]
         each do |book|
-          csv << [book.title, book.authors.join(', '), book.publisher, book.edition, book.isbn,
-                  book.publishing_year, book.rating, book.notes,
-                  (book.want ? '1' : '0'), (book.redd ? '1' : '0'), (book.own ? '1' : '0'),
-                  (book.tags ? book.tags.join(', ') : '')]
+          csv << [book.title, book.authors.join(", "), book.publisher, book.edition,
+                  book.isbn, book.publishing_year, book.rating, book.notes,
+                  (book.want ? "1" : "0"), (book.redd ? "1" : "0"), (book.own ? "1" : "0"),
+                  (book.tags ? book.tags.join(", ") : "")]
         end
       end
     end
 
     private
 
-    ONIX_DTD_URL = 'http://www.editeur.org/onix/2.1/reference/onix-international.dtd'.freeze
+    ONIX_DTD_URL = "http://www.editeur.org/onix/2.1/reference/onix-international.dtd"
     def to_onix_document
       doc = REXML::Document.new
       doc << REXML::XMLDecl.new
-      doc << REXML::DocType.new('ONIXMessage',
+      doc << REXML::DocType.new("ONIXMessage",
                                 "SYSTEM \"#{ONIX_DTD_URL}\"")
-      msg = doc.add_element('ONIXMessage')
-      header = msg.add_element('Header')
-      header.add_element('FromCompany').text = 'Alexandria'
-      header.add_element('FromPerson').text = Etc.getlogin
+      msg = doc.add_element("ONIXMessage")
+      header = msg.add_element("Header")
+      header.add_element("FromCompany").text = "Alexandria"
+      header.add_element("FromPerson").text = Etc.getlogin
       now = Time.now
-      header.add_element('SentDate').text = '%.4d%.2d%.2d%.2d%.2d' % [
-        now.year, now.month, now.day, now.hour, now.min
-      ]
-      header.add_element('MessageNote').text = name
-      each_with_index do |book, idx|
+      header.add_element("SentDate").text = now.strftime("%Y%m%d%H%M")
+      header.add_element("MessageNote").text = name
+      @sorted.each_with_index do |book, idx|
         # fields that are missing: edition and rating.
-        prod = msg.add_element('Product')
-        prod.add_element('RecordReference').text = idx
-        prod.add_element('NotificationType').text = '03'  # confirmed
-        prod.add_element('RecordSourceName').text =
-          'Alexandria ' + Alexandria::DISPLAY_VERSION
-        prod.add_element('ISBN').text = (book.isbn || '')
-        prod.add_element('ProductForm').text = 'BA'       # book
-        prod.add_element('DistinctiveTitle').text = book.title
+        prod = msg.add_element("Product")
+        prod.add_element("RecordReference").text = idx
+        prod.add_element("NotificationType").text = "03"  # confirmed
+        prod.add_element("RecordSourceName").text =
+          "Alexandria " + Alexandria::DISPLAY_VERSION
+        prod.add_element("ISBN").text = (book.isbn || "")
+        prod.add_element("ProductForm").text = "BA"       # book
+        prod.add_element("DistinctiveTitle").text = book.title
         unless book.authors.empty?
           book.authors.each do |author|
-            elem = prod.add_element('Contributor')
+            elem = prod.add_element("Contributor")
             # author
-            elem.add_element('ContributorRole').text = 'A01'
-            elem.add_element('PersonName').text = author
+            elem.add_element("ContributorRole").text = "A01"
+            elem.add_element("PersonName").text = author
           end
         end
         if book.notes && !book.notes.empty?
-          elem = prod.add_element('OtherText')
+          elem = prod.add_element("OtherText")
           # reader description
-          elem.add_element('TextTypeCode').text = '12'
-          elem.add_element('TextFormat').text = '00' # ASCII
-          elem.add_element('Text').text = book.notes
+          elem.add_element("TextTypeCode").text = "12"
+          elem.add_element("TextFormat").text = "00" # ASCII
+          elem.add_element("Text").text = book.notes
         end
         if File.exist?(cover(book))
-          elem = prod.add_element('MediaFile')
+          elem = prod.add_element("MediaFile")
           # front cover image
-          elem.add_element('MediaFileTypeCode').text = '04'
-          elem.add_element('MediaFileFormatCode').text =
-            (Library.jpeg?(cover(book)) ? '03' : '02')
+          elem.add_element("MediaFileTypeCode").text = "04"
+          elem.add_element("MediaFileFormatCode").text =
+            (Library.jpeg?(cover(book)) ? "03" : "02")
           # filename
-          elem.add_element('MediaFileLinkTypeCode').text = '06'
-          elem.add_element('MediaFileLink').text =
-            File.join('images', final_cover(book))
+          elem.add_element("MediaFileLinkTypeCode").text = "06"
+          elem.add_element("MediaFileLink").text =
+            File.join("images", final_cover(book))
         end
         if book.isbn
-          BookProviders.each do |provider|
-            elem = prod.add_element('ProductWebsite')
-            elem.add_element('ProductWebsiteDescription').text =
+          BookProviders.list.each do |provider|
+            elem = prod.add_element("ProductWebsite")
+            elem.add_element("ProductWebsiteDescription").text =
               provider.fullname
-            elem.add_element('ProductWebsiteLink').text =
+            elem.add_element("ProductWebsiteLink").text =
               provider.url(book)
           end
         end
-        elem = prod.add_element('Publisher')
-        elem.add_element('PublishingRole').text = '01'
-        elem.add_element('PublisherName').text = book.publisher
-        prod.add_element('PublicationDate').text = book.publishing_year
+        elem = prod.add_element("Publisher")
+        elem.add_element("PublishingRole").text = "01"
+        elem.add_element("PublisherName").text = book.publisher
+        prod.add_element("PublicationDate").text = book.publishing_year
       end
       doc
     end
@@ -311,51 +207,51 @@ module Alexandria
       # http://periapsis.org/tellico/doc/hacking.html
       doc = REXML::Document.new
       doc << REXML::XMLDecl.new
-      doc << REXML::DocType.new('tellico', 'PUBLIC "-//Robby Stephenson/DTD Tellico V7.0//EN" "http://periapsis.org/tellico/dtd/v7/tellico.dtd"')
-      tellico = doc.add_element('tellico')
-      tellico.add_attribute('syntaxVersion', '7')
-      tellico.add_namespace('http://periapsis.org/tellico/')
-      collection = tellico.add_element('collection')
-      collection.add_attribute('title', name)
-      collection.add_attribute('type', '2')
-      fields = collection.add_element('fields')
-      field1 = fields.add_element('field')
+      doc << REXML::DocType.new("tellico",
+                                'PUBLIC "-//Robby Stephenson/DTD Tellico V7.0//EN"' \
+                                ' "http://periapsis.org/tellico/dtd/v7/tellico.dtd"')
+      tellico = doc.add_element("tellico")
+      tellico.add_attribute("syntaxVersion", "7")
+      tellico.add_namespace("http://periapsis.org/tellico/")
+      collection = tellico.add_element("collection")
+      collection.add_attribute("title", name)
+      collection.add_attribute("type", "2")
+      fields = collection.add_element("fields")
+      field1 = fields.add_element("field")
       # a field named _default implies adding all default book
       # collection fields
-      field1.add_attribute('name', '_default')
-      images = collection.add_element('images')
-      each_with_index do |book, idx|
-        entry = collection.add_element('entry')
+      field1.add_attribute("name", "_default")
+      images = collection.add_element("images")
+      @sorted.each_with_index do |book, idx|
+        entry = collection.add_element("entry")
         new_index = (idx + 1).to_s
-        entry.add_attribute('id', new_index)
+        entry.add_attribute("id", new_index)
         # translate the binding
-        entry.add_element('title').text = book.title
-        entry.add_element('isbn').text = (book.isbn || '')
-        entry.add_element('pub_year').text = book.publishing_year
-        entry.add_element('binding').text = book.edition
-        entry.add_element('publisher').text = book.publisher
+        entry.add_element("title").text = book.title
+        entry.add_element("isbn").text = (book.isbn || "")
+        entry.add_element("pub_year").text = book.publishing_year
+        entry.add_element("binding").text = book.edition
+        entry.add_element("publisher").text = book.publisher
         unless book.authors.empty?
-          authors = entry.add_element('authors')
+          authors = entry.add_element("authors")
           book.authors.each do |author|
-            authors.add_element('author').text = author
+            authors.add_element("author").text = author
           end
         end
-        entry.add_element('read').text = book.redd.to_s if book.redd
-        entry.add_element('loaned').text = book.loaned.to_s if book.loaned
+        entry.add_element("read").text = book.redd.to_s if book.redd
+        entry.add_element("loaned").text = book.loaned.to_s if book.loaned
         unless book.rating == Book::DEFAULT_RATING
-          entry.add_element('rating').text = book.rating
-        end
-        if book.notes && !book.notes.empty?
-          entry.add_element('comments').text = book.notes
+          entry.add_element("rating").text = book.rating
         end
+        entry.add_element("comments").text = book.notes if book.notes && !book.notes.empty?
         if File.exist?(cover(book))
-          entry.add_element('cover').text = final_cover(book)
-          image = images.add_element('image')
-          image.add_attribute('id', final_cover(book))
+          entry.add_element("cover").text = final_cover(book)
+          image = images.add_element("image")
+          image.add_attribute("id", final_cover(book))
           image_s = ImageSize.new(IO.read(cover(book)))
-          image.add_attribute('height', image_s.get_height.to_s)
-          image.add_attribute('width', image_s.get_width.to_s)
-          image.add_attribute('format', image_s.get_type)
+          image.add_attribute("height", image_s.height.to_s)
+          image.add_attribute("width", image_s.width.to_s)
+          image.add_attribute("format", image_s.format)
         end
       end
       doc
@@ -364,110 +260,107 @@ module Alexandria
     def xhtml_escape(str)
       escaped = str.dup
       # used to occasionally use CGI.escapeHTML
-      escaped.gsub!(/&/, '&amp;')
-      escaped.gsub!(/</, '&lt;')
-      escaped.gsub!(/>/, '&gt;')
-      escaped.gsub!(/\"/, '&quot;')
+      escaped.gsub!(/&/, "&amp;")
+      escaped.gsub!(/</, "&lt;")
+      escaped.gsub!(/>/, "&gt;")
+      escaped.gsub!(/"/, "&quot;")
       escaped
     end
 
     def to_xhtml(css)
-      generator = 'Alexandria ' + Alexandria::DISPLAY_VERSION
-      xhtml = ''
-      xhtml << <<EOS
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
-                      "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
-<html>
-<head>
-  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
-  <meta name="Author" content="#{Etc.getlogin}"/>
-  <meta name="Description" content="List of books"/>
-  <meta name="Keywords" content="books"/>
-  <meta name="Generator" content="#{xhtml_escape(generator)}"/>
-  <title>#{xhtml_escape(name)}</title>
-  <link rel="stylesheet" href="#{xhtml_escape(css)}" type="text/css"/>
-</head>
-<body>
-<h1 class="library_name">#{xhtml_escape(name)}</h1>
-EOS
+      generator = "Alexandria " + Alexandria::DISPLAY_VERSION
+      xhtml = +""
+      xhtml << <<~EOS
+        <?xml version="1.0" encoding="UTF-8"?>
+        <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
+                              "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
+        <html>
+        <head>
+          <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
+          <meta name="Author" content="#{Etc.getlogin}"/>
+          <meta name="Description" content="List of books"/>
+          <meta name="Keywords" content="books"/>
+          <meta name="Generator" content="#{xhtml_escape(generator)}"/>
+          <title>#{xhtml_escape(name)}</title>
+          <link rel="stylesheet" href="#{xhtml_escape(css)}" type="text/css"/>
+        </head>
+        <body>
+        <h1 class="library_name">#{xhtml_escape(name)}</h1>
+      EOS
 
       each do |book|
-        xhtml << <<EOS
-<div class="book">
-  <p class="book_isbn">#{book.isbn}</p>
-EOS
+        xhtml << <<~EOS
+          <div class="book">
+            <p class="book_isbn">#{book.isbn}</p>
+        EOS
 
         if File.exist?(cover(book))
-          xhtml << <<EOS
-  <img class="book_cover"
-       src="#{File.join('pixmaps', final_cover(book))}"
-       alt="Cover file for '#{xhtml_escape(book.title)}'"
-EOS
           image_s = ImageSize.new(IO.read(cover(book)))
-          xhtml << <<EOS
-       height="#{image_s.get_height}" width="#{image_s.get_width}"
-EOS
-          xhtml << <<EOS
-  />
-EOS
+          xhtml << <<~EOS
+            <img class="book_cover"
+                 src="#{File.join('pixmaps', final_cover(book))}"
+                 alt="Cover file for '#{xhtml_escape(book.title)}'"
+                 height="#{image_s.height}" width="#{image_s.width}"
+            />
+          EOS
         else
-          xhtml << <<EOS
-<div class="no_book_cover"></div>
-EOS
+          xhtml << <<~EOS
+            <div class="no_book_cover"></div>
+          EOS
         end
 
         unless book.title.nil?
-          xhtml << <<EOS
-<p class="book_title">#{xhtml_escape(book.title)}</p>
-EOS
+          xhtml << <<~EOS
+            <p class="book_title">#{xhtml_escape(book.title)}</p>
+          EOS
         end
 
         unless book.authors.empty?
           xhtml << '<ul class="book_authors">'
           book.authors.each do |author|
-            xhtml << <<EOS
-<li class="book_author">#{xhtml_escape(author)}</li>
-EOS
+            xhtml << <<~EOS
+              <li class="book_author">#{xhtml_escape(author)}</li>
+            EOS
           end
-          xhtml << '</ul>'
+          xhtml << "</ul>"
         end
 
         unless book.edition.nil?
-          xhtml << <<EOS
-<p class="book_binding">#{xhtml_escape(book.edition)}</p>
-EOS
+          xhtml << <<~EOS
+            <p class="book_binding">#{xhtml_escape(book.edition)}</p>
+          EOS
         end
 
         unless book.publisher.nil?
-          xhtml << <<EOS
-<p class="book_publisher">#{xhtml_escape(book.publisher)}</p>
-EOS
+          xhtml << <<~EOS
+            <p class="book_publisher">#{xhtml_escape(book.publisher)}</p>
+          EOS
         end
 
-        xhtml << <<EOS
-</div>
-EOS
+        xhtml << <<~EOS
+          </div>
+        EOS
       end
-      xhtml << <<EOS
-<p class="copyright">
-  Generated on #{xhtml_escape(Date.today.to_s)} by <a href="#{xhtml_escape(Alexandria::WEBSITE_URL)}">#{xhtml_escape(generator)}</a>.
-</p>
-</body>
-</html>
-EOS
+      xhtml << <<~EOS
+        <p class="copyright">
+          Generated on #{xhtml_escape(Date.today.to_s)}
+          by <a href="#{xhtml_escape(Alexandria::WEBSITE_URL)}">#{xhtml_escape(generator)}</a>.
+        </p>
+        </body>
+        </html>
+      EOS
     end
 
     def to_bibtex
-      generator = 'Alexandria ' + Alexandria::DISPLAY_VERSION
-      bibtex = ''
+      generator = "Alexandria " + Alexandria::DISPLAY_VERSION
+      bibtex = +""
       bibtex << "\%Generated on #{Date.today} by: #{generator}\n"
       bibtex << "\%\n"
       bibtex << "\n"
 
       auths = Hash.new(0)
       each do |book|
-        k = (book.authors[0] || 'Anonymous').split[0]
+        k = (book.authors[0] || "Anonymous").split[0]
         if auths.key?(k)
           auths[k] += 1
         else
@@ -489,33 +382,26 @@ EOS
           bibtex << "OPTnote = \"#{latex_escape(book.notes)}\",\n"
         end
         # year is a required field in bibtex @BOOK
-        bibtex << 'year = ' + (book.publishing_year || '"n/a"').to_s + "\n"
+        bibtex << "year = " + (book.publishing_year || '"n/a"').to_s + "\n"
         bibtex << "}\n\n"
       end
       bibtex
     end
 
     def latex_escape(str)
-      return '' if str.nil?
+      return "" if str.nil?
+
       my_str = str.dup
       my_str.gsub!(/%/, '\\%')
       my_str.gsub!(/~/, '\\textasciitilde')
-      my_str.gsub!(/\&/, '\\\\&')
+      my_str.gsub!(/&/, '\\\\&')
       my_str.gsub!(/\#/, '\\\\#')
       my_str.gsub!(/\{/, '\\{')
       my_str.gsub!(/\}/, '\\}')
       my_str.gsub!(/_/, '\\_')
       my_str.gsub!(/\$/, "\\\$")
-      my_str.gsub!(/\"(.+)\"/, "``\1''")
+      my_str.gsub!(/"(.+)"/, "``\1''")
       my_str
     end
   end
-
-  class Library
-    include Exportable
-  end
-
-  class SmartLibrary
-    include Exportable
-  end
 end