alexandria-book-collection-manager 0.7.1 → 0.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0ee9c80a67f5db92fba609abcc676763cea3caa7
-  data.tar.gz: 845f6aada1d8241f8b9401cee1964e0d5a411b7f
+SHA256:
+  metadata.gz: 0c194c4c3c57f9f5f3c5168f2e59cbe0f26be22040392ba5cc6640b2fe6bb917
+  data.tar.gz: a76de1e82e89789ffdf419a10fa601d3bdb4b507c58ea76e9ad8b4123627da04
 SHA512:
-  metadata.gz: 6e4f738354ff4521abd4fafb0c70cb6467991083ca2b1d641070c2dbfaa0d516c93e79f98507c8500726447c9d03a284f94e3193b8e9c5d40c5fbd94a11a8f7a
-  data.tar.gz: cbf664f9496c5703da2892f935b93836f6eec3688ffc1f45c6772b28c35f036f4ca1a1744238a2b7f731821b25e9dd4e3bc433a12ed52046cee9ffa2ffaa2c9e
+  metadata.gz: 367b0d80c25a8ece61d580cedb7806db56f9627c5adb151b63da5655b8495cf988a1e780fa27c88927c02c07b645ff5db452b96896d1720d82df542fb3cd3f1c
+  data.tar.gz: 88570773f1454e1f36c5d0268040f6ab30fd4acb41eb8c90fba9c3bb3488bc980d124705995493f7d7640f7dd9ee7e5355950b594759fd58ffc69a54e1302cbb

data/.github/dependabot.yml

@@ -0,0 +1,9 @@
+# Documentation for all configuration options:
+# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "bundler"
+    directory: "/"
+    schedule:
+      interval: "daily"

data/.gitignore

@@ -3,13 +3,16 @@ config.save
 alexandria.desktop
 alexandria.desktop.in.h
 .svn-authors
-lib/alexandria/default_preferences.rb
 Gemfile.lock
 .yardoc/
 share/locale/
 share/omf/alexandria/*.omf
+spec/examples.txt
 pkg/
 coverage/
-doc/
 tmp/
+po/*.po~
+po/*.mo
+po/*.pot
 *.gem
+*.glade~

data/.hound.yml

@@ -0,0 +1,2 @@
+ruby:
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -1,86 +1,154 @@
+inherit_from: .rubocop_todo.yml
+
+require:
+  - rubocop-performance
+  - rubocop-rspec
+  - rubocop-i18n
+
 AllCops:
   Exclude:
+    - 'lib/alexandria/default_preferences.rb'
     - 'pkg/**/*'
+    - 'vendor/bundle/**/*'
+  NewCops: enable
+  TargetRubyVersion: 2.5
+
+# Choose GetText-style I18n cops
+GetText:
+  Enabled: true
+  # Exclude non-user-facing code
+  Exclude:
+    - Rakefile
+    - 'util/**/*'
+    - 'spec/**/*'
+RailsI18n:
+  Enabled: false
+
+# This code has a lot of pre-existing translations with percent-style
+# formatting. Maybe one day someone will re-do all of them ...
+GetText/DecorateStringFormattingUsingPercent:
+  Enabled: false
+
+# Make BeginEndAlignment behavior match EndAlignment
+Layout/BeginEndAlignment:
+  EnforcedStyleAlignWith: begin
+
+Layout/HashAlignment:
+  EnforcedColonStyle: key
+  EnforcedHashRocketStyle: table
+
+# Be lenient with line length
+Layout/LineLength:
+  Max: 92
+
+# Don't force lonely closing parentheses
+Layout/MultilineMethodCallBraceLayout:
+  EnforcedStyle: same_line
+
+# Multi-line method calls should be simply indented. Aligning them makes it
+# even harder to keep a sane line length.
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+# Multi-line assignment should be simply indented. Aligning them makes it even
+# harder to keep a sane line length.
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+# Force consistent spacing independent of block contents
+Layout/SpaceBeforeBlockBraces:
+  EnforcedStyleForEmptyBraces: space
+
+# Assume the programmer knows how bracketed block syntax works
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
 
 # Allow if (foo = get_foo) style
 Lint/AssignmentInCondition:
   AllowSafeAssignment: true
 
-# Require lines to fit in pull requests.
-# This config is commented out temporarily to allow .rubocop_todo.yml to
-# configure this cop.
-#Metrics/LineLength:
-  #Max: 92
-
-Style/AccessorMethodName:
+# This cop's reach is too broad
+# See https://github.com/rubocop-hq/rubocop/pull/8480
+Lint/MissingSuper:
   Enabled: false
 
-# Allow multi-line blocks of all sorts
-Style/BlockDelimiters:
+# Blocks in specs can be any size
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+
+Naming/AccessorMethodName:
   Enabled: false
 
+# Avoid one-letter exception variable name
+Naming/RescuedExceptionsVariableName:
+  PreferredName: ex
+
+Performance/EndWith:
+  AutoCorrect: true
+
+Performance/StartWith:
+  AutoCorrect: true
+
+# End-to-end specs do not describe classes
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/end_to_end/**/*_spec.rb'
+
+RSpec/ExampleLength:
+  Max: 8
+  Exclude:
+    - 'spec/end_to_end/**/*_spec.rb'
+
 # Allow and/or for control flow only
 Style/AndOr:
-  Enabled: conditionals
-
-# Dot at end of line makes it clearer that the line is not done
-Style/DotPosition:
-  EnforcedStyle: trailing
+  EnforcedStyle: conditionals
 
 # Require at least two dependent lines before suggesting a guard clause
 Style/GuardClause:
   MinBodyLength: 2
 
-# Don't use if or unless as modifier if the line gets too long
-Style/IfUnlessModifier:
-  MaxLineLength: 60
-
-# Multi-line assignment should be simply indented. Aligning them makes it even
-# harder to keep a sane line length.
-Style/MultilineOperationIndentation:
-  EnforcedStyle: indented
-
-Style/MultilineMethodCallBraceLayout:
-  EnforcedStyle: same_line
-
-# Multi-line method calls should be simply indented. Aligning them makes it
-# even harder to keep a sane line length.
-Style/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
+# Sometimes an if statement just looks better than next with a guard clause
+Style/Next:
+  Enabled: false
 
 # Not all objects that handle #== 0 also handle #zero?
 Style/NumericPredicate:
   Enabled: false
 
-# Sometimes an if statement just looks better than next with a guard clause
-Style/Next:
-  Enabled: false
+# Use older RuboCop default
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%W': ()
+    '%w': ()
 
 # Allow explicit return with multiple return values
 Style/RedundantReturn:
   AllowMultipleReturnValues: true
 
-# Always use raise to raise exceptions
-Style/SignalException:
-  EnforcedStyle: only_raise
-
 Style/SingleLineBlockParams:
   Enabled: false
 
-# Accessors are only trivial if they match the ivar name.
+# Allow all ways to construct strings for now
+Style/StringConcatenation:
+  Enabled: false
+
+# Do not commit to use of interpolation
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+# Prefer symbols to look like symbols
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# Accessors are only trivial if they match the ivar name
 Style/TrivialAccessors:
   ExactNameMatch: true
 
 # Allow semantic choice of trailing comma
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArrayLiteral:
   Enabled: false
 
 # Alexandria uses regular arrays
 Style/WordArray:
   Enabled: false
-
-# Not all objects that handle #length also handle #empty?
-Style/ZeroLengthPredicate:
-  Enabled: false
-
-inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -1,106 +1,100 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2016-11-01 21:29:40 +0100 using RuboCop version 0.45.0.
+# `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
+# using RuboCop version 0.93.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 6
-Lint/HandleExceptions:
-  Exclude:
-    - 'lib/alexandria/import_library_csv.rb'
-    - 'lib/alexandria/models/library.rb'
-    - 'lib/alexandria/ui/dialogs/book_properties_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/import_dialog.rb'
-
-# Offense count: 2
-Lint/IneffectiveAccessModifier:
-  Exclude:
-    - 'lib/alexandria/logging.rb'
-    - 'lib/alexandria/web_themes.rb'
-
-# Offense count: 1
-Lint/LiteralInCondition:
-  Exclude:
-    - 'util/rake/gettextgenerate.rb'
-
-# Offense count: 1
-Lint/UnreachableCode:
-  Exclude:
-    - 'lib/alexandria/ui/dialogs/export_dialog.rb'
-
-# Offense count: 2
-# Configuration parameters: ContextCreatingMethods.
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'lib/alexandria/logging.rb'
-
-# Offense count: 172
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
-  Max: 161
+  Max: 111
 
-# Offense count: 21
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
+# ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 68
+  Max: 64
 
-# Offense count: 14
+# Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 
-# Offense count: 33
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 994
+  Max: 990
 
-# Offense count: 75
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
-  Max: 28
-
-# Offense count: 353
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 294
+  Max: 27
 
-# Offense count: 228
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 113
+  Max: 98
 
-# Offense count: 2
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 356
+  Max: 361
 
-# Offense count: 10
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 74
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 29
+  Max: 27
+
+Naming/BinaryOperatorParameterName:
+  Exclude:
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
+
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'Rakefile'
+    - 'bin/alexandria'
+    - 'lib/alexandria/export_library.rb'
+    - 'lib/alexandria/ui/about_dialog.rb'
+
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
+# NamePrefix: is_, has_, have_
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
+# MethodDefinitionMacros: define_method, define_singleton_method
+Naming/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
+    - 'lib/alexandria/ui/smart_library_properties_dialog_base.rb'
+    - 'lib/alexandria/web_themes.rb'
+
+# Configuration parameters: CustomTransform, IgnoreMethods, SpecSuffixOnly.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/alexandria/ui/iconview_spec.rb'
+    - 'spec/alexandria/ui/sound_spec.rb'
+
+RSpec/MultipleExpectations:
+  Max: 7
 
-# Offense count: 3
-Style/ClassAndModuleCamelCase:
+# Cop supports --auto-correct.
+# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
+# SupportedStyles: inflected, explicit
+RSpec/PredicateMatcher:
   Exclude:
-    - 'lib/alexandria/book_providers/bol_it.rb'
-    - 'lib/alexandria/book_providers/ibs_it.rb'
-    - 'lib/alexandria/book_providers/webster_it.rb'
+    - 'spec/alexandria/export_library_spec.rb'
+    - 'spec/alexandria/library_spec.rb'
+    - 'spec/alexandria/library_store_spec.rb'
+    - 'spec/alexandria/scanners/cue_cat_spec.rb'
 
-# Offense count: 8
-# Configuration parameters: EnforcedStyle, SupportedStyles.
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
-    - 'lib/alexandria/ui/dialogs/import_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/preferences_dialog.rb'
-    - 'lib/alexandria/ui/icons.rb'
     - 'lib/alexandria/ui/init.rb'
+    - 'lib/alexandria/ui/provider_preferences_base_dialog.rb'
 
-# Offense count: 17
 Style/ClassVars:
   Exclude:
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
@@ -108,117 +102,35 @@ Style/ClassVars:
     - 'lib/alexandria/logging.rb'
     - 'lib/alexandria/models/library.rb'
     - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/dialogs/acquire_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
+    - 'lib/alexandria/ui/acquire_dialog.rb'
+    - 'lib/alexandria/ui/book_properties_dialog_base.rb'
+    - 'lib/alexandria/ui/new_book_dialog.rb'
 
-# Offense count: 121
 Style/Documentation:
   Enabled: false
 
-# Offense count: 6
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: for, each
-Style/For:
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
   Exclude:
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/book_providers/douban.rb'
-    - 'lib/alexandria/book_providers/renaud.rb'
-    - 'spec/alexandria/library_spec.rb'
+    - 'lib/alexandria/ui/acquire_dialog.rb'
+    - 'lib/alexandria/ui/dndable.rb'
+    - 'lib/alexandria/ui/listview.rb'
+    - 'lib/alexandria/ui/new_book_dialog.rb'
 
-# Offense count: 25
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: format, sprintf, percent
-Style/FormatString:
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
   Exclude:
     - 'lib/alexandria/book_providers.rb'
-    - 'lib/alexandria/book_providers/adlibris.rb'
     - 'lib/alexandria/book_providers/barnes_and_noble.rb'
-    - 'lib/alexandria/book_providers/deastore.rb'
     - 'lib/alexandria/book_providers/siciliano.rb'
     - 'lib/alexandria/book_providers/thalia.rb'
     - 'lib/alexandria/book_providers/worldcat.rb'
-    - 'lib/alexandria/export_library.rb'
-    - 'lib/alexandria/ui/dialogs/acquire_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/misc_dialogs.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
-    - 'lib/alexandria/ui/dndable.rb'
-    - 'lib/alexandria/ui/listview.rb'
-    - 'lib/alexandria/ui/ui_manager.rb'
-
-# Offense count: 34
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Offense count: 4
-Style/IdenticalConditionalBranches:
-  Exclude:
-    - 'lib/alexandria/book_providers/amazon_aws.rb'
-    - 'lib/alexandria/ui/ui_manager.rb'
-
-# Offense count: 4
-Style/IfInsideElse:
-  Exclude:
-    - 'lib/alexandria/book_providers/proxis.rb'
-    - 'lib/alexandria/book_providers/web.rb'
-    - 'lib/alexandria/preferences.rb'
-    - 'lib/alexandria/ui/ui_manager.rb'
-
-# Offense count: 2
-Style/MethodMissing:
-  Exclude:
-    - 'lib/alexandria/book_providers.rb'
-    - 'lib/alexandria/preferences.rb'
-
-# Offense count: 1
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: snake_case, camelCase
-Style/MethodName:
-  Exclude:
-    - 'lib/alexandria/book_providers/mcu.rb'
-
-# Offense count: 1
-Style/MultilineTernaryOperator:
-  Exclude:
-    - 'lib/alexandria/ui/listview.rb'
-
-# Offense count: 1
-Style/NestedTernaryOperator:
-  Exclude:
-    - 'lib/alexandria/ui/ui_manager.rb'
-
-# Offense count: 8
-Style/OpMethod:
-  Exclude:
-    - 'lib/alexandria/book_providers.rb'
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/models/book.rb'
+    - 'lib/alexandria/console.rb'
+    - 'lib/alexandria/execution_queue.rb'
+    - 'lib/alexandria/export_format.rb'
+    - 'lib/alexandria/library_sort_order.rb'
     - 'lib/alexandria/models/library.rb'
-    - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/multi_drag_treeview.rb'
-
-# Offense count: 4
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
-# NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
-Style/PredicateName:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/ui/dialogs/smart_library_properties_dialog_base.rb'
-    - 'lib/alexandria/web_themes.rb'
-
-# Offense count: 41
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Enabled: false
-
-# Offense count: 3
-Style/StructInheritance:
-  Exclude:
-    - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/multi_drag_treeview.rb'
+    - 'lib/alexandria/ui/ui_manager.rb'
+    - 'util/rake/fileinstall.rb'