activeadmin 0.2.2 → 0.3.0

data/features/step_definitions/action_item_steps.rb

@@ -1,7 +1,7 @@
 Then /^I should see an action item button "([^"]*)"$/ do |content|
-  Then %{I should see "#{content}" within ".action_items a"}
+  page.should have_css(".action_items a", :text => content)
 end
 
 Then /^I should not see an action item button "([^"]*)"$/ do |content|
-  Then %{I should not see "#{content}" within ".action_items"}
+  page.should_not have_css(".action_items", :text => content)
 end

data/features/step_definitions/additional_web_steps.rb

@@ -1,35 +1,40 @@
 Then /^I should see a table header with "([^"]*)"$/ do |content|
-  Then "I should see \"#{content}\" within \"th\""
+  page.should have_xpath('//th', :text => content)
 end
 
 Then /^I should not see a table header with "([^"]*)"$/ do |content|
-  Then "I should not see \"#{content}\" within \"th\""
+  page.should_not have_xpath('//th', :text => content)
 end
 
 Then /^I should see a sortable table header with "([^"]*)"$/ do |content|
-  Then "I should see \"#{content}\" within \"th.sortable\""
+  page.should have_css('th.sortable', :text => content)
+end
+
+Then /^I should not see a sortable table header$/ do
+  Then "I should not see \"th.sortable\""
 end
 
 Then /^the table "([^"]*)" should have (\d+) rows/ do |selector, count|
-  with_scope(selector) do
-    page.all(:css, 'tr').size.should == count.to_i
-  end
+  table = page.find(selector)
+  table.all(:css, 'tr').size.should == count.to_i
 end
 
 Then /^the table "([^"]*)" should have (\d+) columns/ do |selector, count|
-  with_scope(selector + " tr:first") do
-    page.all(:css, "td").size.should == count.to_i
-  end
+  table = page.find(selector)
+  row = table.find('tr:first')
+  row.all(:css, "td").size.should == count.to_i
 end
 
-Then /^there should be (\d+) "([^"]*)" tags within "([^"]*)"$/ do |count, tag, selector|
-  with_scope(selector) do
-    page.all(:css, tag).size.should == count.to_i
-  end
+Then /^there should be (\d+) "([^"]*)" tags$/ do |count, tag|
+  page.all(:css, tag).size.should == count.to_i
 end
 
 Then /^I should see a link to "([^"]*)"$/ do |link|
-  Then "I should see \"#{link}\" within \"a\""
+  if page.respond_to? :should
+    page.should have_xpath('//a', :text => link)
+  else
+    assert page.has_xpath?('//a', :text => link)
+  end
 end
 
 Then /^I should see a link to \/([^\/]*)\/$/ do |regexp|
@@ -59,9 +64,14 @@ Then /^I should wait and see "([^"]*)"(?: within "([^"]*)")?$/ do |text, selecto
 end
 
 Then /^I should see the page title "([^"]*)"$/ do |title|
-  Then %{I should see "#{title}" within "h2#page_title"}
+  page.should have_css('h2#page_title', :text => title)
 end
 
 Then /^I should see a fieldset titled "([^"]*)"$/ do |title|
-  Then %{I should see "#{title}" within "fieldset legend"}
+  page.should have_css('fieldset legend', :text => title)
+end
+
+Then /^the "([^"]*)" field should contain the option "([^"]*)"$/ do |field, option|
+  field = find_field(field)
+  field.should have_css("option", :text => option)
 end

data/features/step_definitions/attribute_steps.rb

@@ -1,15 +1,13 @@
 Then /^I should see the attribute "([^"]*)" with "([^"]*)"$/ do |title, value|
-  Then "I should see \"#{title}\" within \".attributes_table th\""
-  And "I should see \"#{value}\" within \".attributes_table td\""
+  page.should have_css('.attributes_table th', :text => title)
+  page.should have_css('.attributes_table td', :text => value)
 end
 
 Then /^I should see the attribute "([^"]*)" with a nicely formatted datetime$/ do |title|
-  Then "I should see \"#{title}\" within \".attributes_table th\""
-  with_scope ".attributes_table td" do
-    page.body.should =~ /\w+ \d{1,2}, \d{4} \d{2}:\d{2}/
-  end
+  th = page.find('.attributes_table th', :text => title)
+  page.find(:xpath, th.path.gsub(/th$/, 'td')).text.should =~ /\w+ \d{1,2}, \d{4} \d{2}:\d{2}/
 end
 
 Then /^I should not see the attribute "([^"]*)"$/ do |title|
-  Then "I should not see \"#{title}\" within \".attributes_table th\""
+  page.should_not have_css('.attributes_table th', :text => title)
 end

data/features/step_definitions/configuration_steps.rb

@@ -1,22 +1,22 @@
-Given /^a configuration of:$/ do |config|
-  ActiveAdmin.unload!
-  File.open(ACTIVE_ADMIN_TEST_CONFIG, 'w+'){|f| f << config }
+Given /^a configuration of:$/ do |configuration_content|
+  eval configuration_content
   Rails.application.reload_routes!
+  ActiveAdmin.application.namespaces.values.each{|n| n.load_menu! }
 end
 
-Given /^an index configuration of:$/ do |config|
-  ActiveAdmin.unload!
-  File.open(ACTIVE_ADMIN_TEST_CONFIG, 'w+'){|f| f << config }
+Given /^an index configuration of:$/ do |configuration_content|
+  eval configuration_content
   Rails.application.reload_routes!
+  ActiveAdmin.application.namespaces.values.each{|n| n.load_menu! }
 
   And 'I am logged in'
   When "I am on the index page for posts"
 end
 
-Given /^a show configuration of:$/ do |config|
-  ActiveAdmin.unload!
-  File.open(ACTIVE_ADMIN_TEST_CONFIG, 'w+'){|f| f << config }
+Given /^a show configuration of:$/ do |configuration_content|
+  eval configuration_content
   Rails.application.reload_routes!
+  ActiveAdmin.application.namespaces.values.each{|n| n.load_menu! }
 
   And 'I am logged in'
   When "I am on the index page for posts"

data/features/step_definitions/factory_steps.rb

@@ -12,7 +12,7 @@ Given /^a post with the title "([^"]*)" written by "([^"]*)" exists$/ do |title,
   Post.create! :title => title, :author => author
 end
 
-Given /^(\d+) posts exist/ do |count|
+Given /^(\d+) posts? exists?/ do |count|
   (0...count.to_i).each do |i|
     Post.create! :title => "Hello World #{i}"
   end
@@ -22,7 +22,8 @@ Given /^a category named "([^"]*)" exists$/ do |name|
   Category.create! :name => name
 end
 
-Given /^a user named "([^"]*)" exists$/ do |name|
+Given /^a (user|publisher) named "([^"]*)" exists$/ do |type, name|
   first, last = name.split(" ")
-  User.create! :first_name => first, :last_name => last, :username => name
+  type = type.camelize.constantize
+  type.create! :first_name => first, :last_name => last, :username => name
 end

data/features/step_definitions/format_steps.rb

@@ -3,5 +3,33 @@ Then "I should see nicely formatted datetimes" do
 end
 
 Then /^I should see a link to download "([^"]*)"$/ do |format_type|
-  Then %{I should see "#{format_type}" within "#index_footer a"}
+  page.should have_css("#index_footer a", :text => format_type)
+end
+
+# Check first rows of the displayed CSV.
+Then /^I should download a CSV file for "([^"]*)" containing:$/ do |resource_name, table|
+  page.response_headers['Content-Type'].should == 'text/csv; charset=utf-8'
+  csv_filename = "#{resource_name}-#{Time.now.strftime("%Y-%m-%d")}.csv"
+  page.response_headers['Content-Disposition'].should == %{attachment; filename="#{csv_filename}"}
+  body = page.driver.response.body
+
+  begin
+    csv = CSV.parse(body)
+    table.raw.each_with_index do |expected_row, row_index|
+      expected_row.each_with_index do |expected_cell, col_index|
+        cell = csv.try(:[], row_index).try(:[], col_index)
+        if expected_cell.blank?
+          cell.should be_nil
+        else
+          (cell || '').should match(/#{expected_cell}/)
+        end
+      end
+    end
+  rescue
+    puts "Expecting:"
+    p table.raw
+    puts "to match:"
+    p csv
+    raise $!
+  end
 end

data/features/step_definitions/layout_steps.rb

@@ -0,0 +1,3 @@
+Then /^I should see the Active Admin layout$/ do
+  page.should have_css("#active_admin_content #main_content_wrapper")
+end

data/features/step_definitions/menu_steps.rb

@@ -1,7 +1,7 @@
 Then /^I should see a menu item for "([^"]*)"$/ do |name|
-  Then %{I should see "#{name}" within "#tabs li a"}
+  page.should have_css('#tabs li a', :text => name)
 end
 
 Then /^I should not see a menu item for "([^"]*)"$/ do |name|
-  Then %{I should not see "#{name}" within "#tabs li a"}
+  page.should_not have_css('#tabs li a', :text => name)
 end

data/features/step_definitions/sidebar_steps.rb

@@ -1,11 +1,7 @@
 Then /^I should see a sidebar titled "([^"]*)"$/ do |title|
-  Then %{I should see "#{title}" within ".sidebar_section h3"}
+  page.should have_css(".sidebar_section h3", :text => title)
 end
 
 Then /^I should not see a sidebar titled "([^"]*)"$/ do |title|
   page.all(:css, "##{title.gsub(" ", '').underscore}_sidebar_section").count.should == 0
 end
-
-Then /^I should see \/([^\/]*)\/ within the sidebar "([^"]*)"$/ do |regexp, title|
-  Then %{I should see /#{regexp}/ within "##{title.gsub(" ", '').underscore}_sidebar_section"}
-end

data/features/step_definitions/user_steps.rb

@@ -1,10 +1,16 @@
 Given /^I am logged out$/ do
-  visit destroy_admin_user_session_path
+  if page.all(:css, "a", :text => "Logout").size > 0
+    click_link "Logout"
+  end
 end
 
 Given /^I am logged in$/ do
   Given 'an admin user "admin@example.com" exists'
-  visit destroy_admin_user_session_path
+
+  if page.all(:css, "a", :text => "Logout").size > 0
+    click_link "Logout"
+  end
+
   visit new_admin_user_session_path
   fill_in "Email", :with => "admin@example.com"
   fill_in "Password", :with => "password"

data/features/step_definitions/web_steps.rb

@@ -1,21 +1,46 @@
-# IMPORTANT: This file is generated by cucumber-rails - edit at your own peril.
-# It is recommended to regenerate this file in the future when you upgrade to a 
-# newer version of cucumber-rails. Consider adding your own code to a new file 
-# instead of editing this one. Cucumber will automatically load all features/**/*.rb
-# files.
+# TL;DR: YOU SHOULD DELETE THIS FILE
+#
+# This file was generated by Cucumber-Rails and is only here to get you a head start
+# These step definitions are thin wrappers around the Capybara/Webrat API that lets you
+# visit pages, interact with widgets and make assertions about page content.
+#
+# If you use these step definitions as basis for your features you will quickly end up
+# with features that are:
+#
+# * Hard to maintain
+# * Verbose to read
+#
+# A much better approach is to write your own higher level step definitions, following
+# the advice in the following blog posts:
+#
+# * http://benmabey.com/2008/05/19/imperative-vs-declarative-scenarios-in-user-stories.html
+# * http://dannorth.net/2011/01/31/whose-domain-is-it-anyway/
+# * http://elabs.se/blog/15-you-re-cuking-it-wrong
+#
 
 
 require 'uri'
 require 'cgi'
 require File.expand_path(File.join(File.dirname(__FILE__), "..", "support", "paths"))
+require File.expand_path(File.join(File.dirname(__FILE__), "..", "support", "selectors"))
 
 module WithinHelpers
   def with_scope(locator)
-    locator ? within(locator) { yield } : yield
+    locator ? within(*selector_for(locator)) { yield } : yield
   end
 end
 World(WithinHelpers)
 
+# Single-line step scoper
+When /^(.*) within (.*[^:])$/ do |step, parent|
+  with_scope(parent) { When step }
+end
+
+# Multi-line step scoper
+When /^(.*) within (.*[^:]):$/ do |step, parent, table_or_string|
+  with_scope(parent) { When "#{step}:", table_or_string }
+end
+
 Given /^(?:|I )am on (.+)$/ do |page_name|
   visit path_to(page_name)
 end
@@ -24,28 +49,20 @@ When /^(?:|I )go to (.+)$/ do |page_name|
   visit path_to(page_name)
 end
 
-When /^(?:|I )press "([^"]*)"(?: within "([^"]*)")?$/ do |button, selector|
-  with_scope(selector) do
-    click_button(button)
-  end
+When /^(?:|I )press "([^"]*)"$/ do |button|
+  click_button(button)
 end
 
-When /^(?:|I )follow "([^"]*)"(?: within "([^"]*)")?$/ do |link, selector|
-  with_scope(selector) do
-    click_link(link)
-  end
+When /^(?:|I )follow "([^"]*)"$/ do |link|
+  click_link(link)
 end
 
-When /^(?:|I )fill in "([^"]*)" with "([^"]*)"(?: within "([^"]*)")?$/ do |field, value, selector|
-  with_scope(selector) do
-    fill_in(field, :with => value)
-  end
+When /^(?:|I )fill in "([^"]*)" with "([^"]*)"$/ do |field, value|
+  fill_in(field, :with => value)
 end
 
-When /^(?:|I )fill in "([^"]*)" for "([^"]*)"(?: within "([^"]*)")?$/ do |value, field, selector|
-  with_scope(selector) do
-    fill_in(field, :with => value)
-  end
+When /^(?:|I )fill in "([^"]*)" for "([^"]*)"$/ do |value, field|
+  fill_in(field, :with => value)
 end
 
 # Use this to fill in an entire form with data from a table. Example:
@@ -59,95 +76,70 @@ end
 # TODO: Add support for checkbox, select og option
 # based on naming conventions.
 #
-When /^(?:|I )fill in the following(?: within "([^"]*)")?:$/ do |selector, fields|
-  with_scope(selector) do
-    fields.rows_hash.each do |name, value|
-      When %{I fill in "#{name}" with "#{value}"}
-    end
-  end
-end
-
-When /^(?:|I )select "([^"]*)" from "([^"]*)"(?: within "([^"]*)")?$/ do |value, field, selector|
-  with_scope(selector) do
-    select(value, :from => field)
+When /^(?:|I )fill in the following:$/ do |fields|
+  fields.rows_hash.each do |name, value|
+    When %{I fill in "#{name}" with "#{value}"}
   end
 end
 
-When /^(?:|I )check "([^"]*)"(?: within "([^"]*)")?$/ do |field, selector|
-  with_scope(selector) do
-    check(field)
-  end
+When /^(?:|I )select "([^"]*)" from "([^"]*)"$/ do |value, field|
+  select(value, :from => field)
 end
 
-When /^(?:|I )uncheck "([^"]*)"(?: within "([^"]*)")?$/ do |field, selector|
-  with_scope(selector) do
-    uncheck(field)
-  end
+When /^(?:|I )check "([^"]*)"$/ do |field|
+  check(field)
 end
 
-When /^(?:|I )choose "([^"]*)"(?: within "([^"]*)")?$/ do |field, selector|
-  with_scope(selector) do
-    choose(field)
-  end
+When /^(?:|I )uncheck "([^"]*)"$/ do |field|
+  uncheck(field)
 end
 
-When /^(?:|I )attach the file "([^"]*)" to "([^"]*)"(?: within "([^"]*)")?$/ do |path, field, selector|
-  with_scope(selector) do
-    attach_file(field, path)
-  end
+When /^(?:|I )choose "([^"]*)"$/ do |field|
+  choose(field)
 end
 
-Then /^(?:|I )should see JSON:$/ do |expected_json|
-  require 'json'
-  expected = JSON.pretty_generate(JSON.parse(expected_json))
-  actual   = JSON.pretty_generate(JSON.parse(response.body))
-  expected.should == actual
+When /^(?:|I )attach the file "([^"]*)" to "([^"]*)"$/ do |path, field|
+  attach_file(field, File.expand_path(path))
 end
 
-Then /^(?:|I )should see "([^"]*)"(?: within "([^"]*)")?$/ do |text, selector|
-  with_scope(selector) do
-    if page.respond_to? :should
-      page.should have_content(text)
-    else
-      assert page.has_content?(text)
-    end
+Then /^(?:|I )should see "([^"]*)"$/ do |text|
+  if page.respond_to? :should
+    page.should have_content(text)
+  else
+    assert page.has_content?(text)
   end
 end
 
-Then /^(?:|I )should see \/([^\/]*)\/(?: within "([^"]*)")?$/ do |regexp, selector|
+Then /^(?:|I )should see \/([^\/]*)\/$/ do |regexp|
   regexp = Regexp.new(regexp)
-  with_scope(selector) do
-    if page.respond_to? :should
-      page.should have_xpath('//*', :text => regexp)
-    else
-      assert page.has_xpath?('//*', :text => regexp)
-    end
+
+  if page.respond_to? :should
+    page.should have_xpath('//*', :text => regexp)
+  else
+    assert page.has_xpath?('//*', :text => regexp)
   end
 end
 
-Then /^(?:|I )should not see "([^"]*)"(?: within "([^"]*)")?$/ do |text, selector|
-  with_scope(selector) do
-    if page.respond_to? :should
-      page.should have_no_content(text)
-    else
-      assert page.has_no_content?(text)
-    end
+Then /^(?:|I )should not see "([^"]*)"$/ do |text|
+  if page.respond_to? :should
+    page.should have_no_content(text)
+  else
+    assert page.has_no_content?(text)
   end
 end
 
-Then /^(?:|I )should not see \/([^\/]*)\/(?: within "([^"]*)")?$/ do |regexp, selector|
+Then /^(?:|I )should not see \/([^\/]*)\/$/ do |regexp|
   regexp = Regexp.new(regexp)
-  with_scope(selector) do
-    if page.respond_to? :should
-      page.should have_no_xpath('//*', :text => regexp)
-    else
-      assert page.has_no_xpath?('//*', :text => regexp)
-    end
+
+  if page.respond_to? :should
+    page.should have_no_xpath('//*', :text => regexp)
+  else
+    assert page.has_no_xpath?('//*', :text => regexp)
   end
 end
 
-Then /^the "([^"]*)" field(?: within "([^"]*)")? should contain "([^"]*)"$/ do |field, selector, value|
-  with_scope(selector) do
+Then /^the "([^"]*)" field(?: within (.*))? should contain "([^"]*)"$/ do |field, parent, value|
+  with_scope(parent) do
     field = find_field(field)
     field_value = (field.tag_name == 'textarea') ? field.text : field.value
     if field_value.respond_to? :should
@@ -158,8 +150,8 @@ Then /^the "([^"]*)" field(?: within "([^"]*)")? should contain "([^"]*)"$/ do |
   end
 end
 
-Then /^the "([^"]*)" field(?: within "([^"]*)")? should not contain "([^"]*)"$/ do |field, selector, value|
-  with_scope(selector) do
+Then /^the "([^"]*)" field(?: within (.*))? should not contain "([^"]*)"$/ do |field, parent, value|
+  with_scope(parent) do
     field = find_field(field)
     field_value = (field.tag_name == 'textarea') ? field.text : field.value
     if field_value.respond_to? :should_not
@@ -170,8 +162,8 @@ Then /^the "([^"]*)" field(?: within "([^"]*)")? should not contain "([^"]*)"$/
   end
 end
 
-Then /^the "([^"]*)" checkbox(?: within "([^"]*)")? should be checked$/ do |label, selector|
-  with_scope(selector) do
+Then /^the "([^"]*)" checkbox(?: within (.*))? should be checked$/ do |label, parent|
+  with_scope(parent) do
     field_checked = find_field(label)['checked']
     if field_checked.respond_to? :should
       field_checked.should be_true
@@ -181,8 +173,8 @@ Then /^the "([^"]*)" checkbox(?: within "([^"]*)")? should be checked$/ do |labe
   end
 end
 
-Then /^the "([^"]*)" checkbox(?: within "([^"]*)")? should not be checked$/ do |label, selector|
-  with_scope(selector) do
+Then /^the "([^"]*)" checkbox(?: within (.*))? should not be checked$/ do |label, parent|
+  with_scope(parent) do
     field_checked = find_field(label)['checked']
     if field_checked.respond_to? :should
       field_checked.should be_false