activeadmin 0.2.2 → 0.3.0

data/spec/unit/resource_controller/collection_spec.rb

@@ -26,7 +26,7 @@ describe ActiveAdmin::ResourceController::Collection do
     let(:params){ {:order => "id_asc" }}
     it "should prepend the table name" do
       chain = mock("ChainObj")
-      chain.should_receive(:order).with("posts.id asc").once.and_return(Post.search)
+      chain.should_receive(:order).with("\"posts\".id asc").once.and_return(Post.search)
       controller.send :sort_order, chain
     end
   end

data/spec/unit/resource_controller_spec.rb

@@ -45,31 +45,36 @@ describe ActiveAdmin::ResourceController do
     end
   end
 
-  ActiveAdmin.register Post do
-    after_build :call_after_build
-    before_save :call_before_save
-    after_save :call_after_save
-    before_create :call_before_create
-    after_create :call_after_create
-    before_update :call_before_update
-    after_update :call_after_update
-    before_destroy :call_before_destroy
-    after_destroy :call_after_destroy
-  end
-
-  class Admin::PostsController < ActiveAdmin::ResourceController
-    def call_after_build(obj); end
-    def call_before_save(obj); end
-    def call_after_save(obj); end
-    def call_before_create(obj); end
-    def call_after_create(obj); end
-    def call_before_update(obj); end
-    def call_after_update(obj); end
-    def call_before_destroy(obj); end
-    def call_after_destroy(obj); end
-  end
-
   describe "callbacks" do
+    let(:application){ ::ActiveAdmin::Application.new }
+    let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
+
+    before :all do
+      namespace.register Post do
+        after_build :call_after_build
+        before_save :call_before_save
+        after_save :call_after_save
+        before_create :call_before_create
+        after_create :call_after_create
+        before_update :call_before_update
+        after_update :call_after_update
+        before_destroy :call_before_destroy
+        after_destroy :call_after_destroy
+
+        controller do
+          def call_after_build(obj); end
+          def call_before_save(obj); end
+          def call_after_save(obj); end
+          def call_before_create(obj); end
+          def call_after_create(obj); end
+          def call_before_update(obj); end
+          def call_after_update(obj); end
+          def call_before_destroy(obj); end
+          def call_after_destroy(obj); end
+        end
+      end
+    end
+
     describe "performing create" do
       let(:controller){ Admin::PostsController.new }
       let(:resource){ mock("Resource", :save => true) }

data/spec/unit/resource_spec.rb

@@ -5,58 +5,20 @@ module ActiveAdmin
 
     before { load_defaults! }
 
-    let(:namespace){ Namespace.new(:admin) }
+    let(:application){ ActiveAdmin::Application.new }
+    let(:namespace){ Namespace.new(application, :admin) }
 
     def config(options = {})
       @config ||= Resource.new(namespace, Category, options)
     end
 
-    describe "underscored resource name" do
-      context "when class" do
-        it "should be the underscored singular resource name" do
-          config.underscored_resource_name.should == "category"
-        end
-      end
-      context "when a class in a module" do
-        it "should underscore the module and the class" do
-          module ::Mock; class Resource; end; end
-          Resource.new(namespace, Mock::Resource).underscored_resource_name.should == "mock_resource"
-        end
-      end
-      context "when you pass the 'as' option" do
-        it "should underscore the passed through string and singulralize" do
-          config(:as => "Blog Categories").underscored_resource_name.should == "blog_category"
-        end
-      end
-    end
-
-    describe "camelized resource name" do
-      it "should return a camelized version of the underscored resource name" do
-        config(:as => "Blog Categories").camelized_resource_name.should == "BlogCategory"
-      end
-    end
-
-    describe "resource name" do
-      it "should return a pretty name" do
-        config.resource_name.should == "Category"
-      end
-      it "should return the plural version" do
-        config.plural_resource_name.should == "Categories"
-      end
-      context "when the :as option is given" do
-        it "should return the custom name" do
-          config(:as => "My Category").resource_name.should == "My Category"
-        end
-      end
-    end
-
     describe "#resource_table_name" do
       it "should return the resource's table name" do
-        config.resource_table_name.should == 'categories'
+        config.resource_table_name.should == '"categories"'
       end
       context "when the :as option is given" do
         it "should return the resource's table name" do
-          config(:as => "My Category").resource_table_name.should == 'categories'
+          config(:as => "My Category").resource_table_name.should == '"categories"'
         end
       end
     end
@@ -72,7 +34,7 @@ module ActiveAdmin
         config.controller_name.should == "Admin::CategoriesController"
       end
       context "when non namespaced controller" do
-        let(:namespace){ ActiveAdmin::Namespace.new(:root) }
+        let(:namespace){ ActiveAdmin::Namespace.new(application, :root) }
         it "should return a non namespaced controller name" do
           config.controller_name.should == "CategoriesController"
         end
@@ -80,7 +42,7 @@ module ActiveAdmin
     end
 
     describe "#include_in_menu?" do
-      let(:namespace){ ActiveAdmin::Namespace.new(:admin) }
+      let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
       subject{ resource }
 
       context "when regular resource" do
@@ -121,9 +83,30 @@ module ActiveAdmin
         end.parent_menu_item_name.should == "Blog"
       end
     end
+    
+    describe "menu item priority" do
+      it "should be 10 when not set" do
+        config.menu_item_priority.should == 10
+      end
+      it "should be settable" do
+        config.menu :priority => 2
+        config.menu_item_priority.should == 2
+      end
+    end
+    
+    describe "menu item display if" do
+      it "should be a proc always returning true if not set" do
+        config.menu_item_display_if.should be_instance_of(Proc)
+        config.menu_item_display_if.call.should == true
+      end
+      it "should be settable" do
+        config.menu :if => proc { false }
+        config.menu_item_display_if.call.should == false
+      end
+    end
 
     describe "route names" do
-      let(:config){ ActiveAdmin.register Category }
+      let(:config){ application.register Category }
       it "should return the route prefix" do
         config.route_prefix.should == "admin"
       end
@@ -132,11 +115,20 @@ module ActiveAdmin
       end
 
       context "when in the root namespace" do
-        let(:config){ ActiveAdmin.register Category, :namespace => false}
+        let(:config){ application.register Category, :namespace => false}
         it "should have a nil route_prefix" do
           config.route_prefix.should == nil
         end
       end
+
+      context "when registering a plural resource" do
+        class ::News; def self.has_many(*); end end
+
+        let(:config){ application.register News }
+        it "should return the plurali route with _index" do
+          config.route_collection_path.should == :admin_news_index_path
+        end
+      end
     end
 
     describe "page configs" do
@@ -152,43 +144,43 @@ module ActiveAdmin
     end
 
     describe "scoping" do
-      let(:controller){ Admin::CategoriesController.new }
-      let(:begin_of_association_chain){ controller.send(:begin_of_association_chain) }
-
       context "when using a block" do
         before do
-          ActiveAdmin.register Category do
+          @resource = application.register Category do
             scope_to do
               "scoped"
             end
           end
         end
         it "should call the proc for the begin of association chain" do
+          begin_of_association_chain = @resource.controller.new.send(:begin_of_association_chain)
           begin_of_association_chain.should == "scoped"
         end
       end
 
       context "when using a symbol" do
         before do
-          ActiveAdmin.register Category do
+          @resource = application.register Category do
             scope_to :current_user
           end
         end
         it "should call the method for the begin of association chain" do
+          controller = @resource.controller.new
           controller.should_receive(:current_user).and_return(true)
+          begin_of_association_chain = controller.send(:begin_of_association_chain)
           begin_of_association_chain.should == true
         end
       end
 
       context "when not using a block or symbol" do
         before do
-          ActiveAdmin.register Category do
+          @resource = application.register Category do
             scope_to "Some string"
           end
         end
         it "should raise and exception" do
           lambda {
-            begin_of_association_chain
+            @resource.controller.new.send(:begin_of_association_chain)
           }.should raise_error(ArgumentError)
         end
       end
@@ -196,22 +188,22 @@ module ActiveAdmin
       describe "getting the method for the association chain" do
         context "when a simple registration" do
           before do
-            ActiveAdmin.register Category do
+            @resource = application.register Category do
               scope_to :current_user
             end
           end
           it "should return the pluralized collection name" do
-            controller.send(:method_for_association_chain).should == :categories
+            @resource.controller.new.send(:method_for_association_chain).should == :categories
           end
         end
         context "when passing in the method as an option" do
           before do
-            ActiveAdmin.register Category do
+            @resource = application.register Category do
               scope_to :current_user, :association_method => :blog_categories
             end
           end
           it "should return the method from the option" do
-            controller.send(:method_for_association_chain).should == :blog_categories
+            @resource.controller.new.send(:method_for_association_chain).should == :blog_categories
           end
         end
       end
@@ -219,20 +211,29 @@ module ActiveAdmin
 
 
     describe "sort order" do
-      subject { resource_config.sort_order }
 
-      context "by default" do
-        let(:resource_config) { config }
-
-        it { should == ActiveAdmin.default_sort_order }
+      context "when resource class responds to primary_key" do
+        it "should sort by primary key desc by default" do
+          mock_resource = mock
+          mock_resource.should_receive(:primary_key).and_return("pk")
+          config = Resource.new(namespace, mock_resource)
+          config.sort_order.should == "pk_desc"
+        end
       end
 
-      context "when default_sort_order is set" do
-        let(:sort_order)      { "name_desc"                      }
-        let(:resource_config) { config :sort_order => sort_order }
+      context "when resource class does not respond to primary_key" do
+        it "should default to id" do
+          mock_resource = mock
+          config = Resource.new(namespace, mock_resource)
+          config.sort_order.should == "id_desc"
+        end
+      end
 
-        it { should == sort_order }
+      it "should be set-able" do
+        config.sort_order = "task_id_desc"
+        config.sort_order.should == "task_id_desc"
       end
+
     end
 
     describe "adding a scope" do
@@ -248,36 +249,19 @@ module ActiveAdmin
         config.get_scope_by_id(:published).name.should == "Published"
       end
     end
-    
-    describe "admin notes" do
-      context "when not set" do
-        context "when global is true" do
-          before(:each) do
-            ActiveAdmin.admin_notes = true
-          end
-          it "should default to true" do
-            config.admin_notes?.should be_true
-          end
-        end
-        context "when global is false" do
-          before(:each) do
-            ActiveAdmin.admin_notes = false
-          end
-          it "should default to false" do
-            config.admin_notes?.should be_false
-          end
+
+    describe "#csv_builder" do
+      context "when no csv builder set" do
+        it "should return a default column builder with id and content columns" do
+          config.csv_builder.columns.size.should == Category.content_columns.size + 1
         end
       end
-      context "when set" do
-        it "should be set to the local value true" do
-          ActiveAdmin.admin_notes = false
-          config.admin_notes = true
-          config.admin_notes?.should be_true
-        end
-        it "should be set to the local value false" do
-          ActiveAdmin.admin_notes = true
-          config.admin_notes = false
-          config.admin_notes?.should be_false
+
+      context "when csv builder set" do
+        it "shuld return the csv_builder we set" do
+          csv_builder = CSVBuilder.new
+          config.csv_builder = csv_builder
+          config.csv_builder.should == csv_builder
         end
       end
     end

data/spec/unit/sass/helpers_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe ActiveAdmin::Sass::Helpers do
+
+  include ActiveAdmin::Sass::Helpers
+
+  context "when not using the asset pipeline" do
+
+    before(:all)do
+      @actual_rails_version = Rails::VERSION::MINOR
+      silence_warnings { Rails::VERSION::MINOR = 0 }
+    end
+
+    after(:all) do
+      silence_warnings { Rails::VERSION::MINOR = @actual_rails_version }
+    end
+
+    it "should generate an image asset path to /images/active_admin" do
+      active_admin_image_path(Sass::Script::String.new('test.jpg')).should ==
+          Sass::Script::String.new("/images/active_admin/test.jpg", true)
+    end
+
+  end
+
+  context "when using the asset pipeline" do
+    before(:all)do
+      @actual_rails_version = Rails::VERSION::MINOR
+      silence_warnings { Rails::VERSION::MINOR = 1 }
+    end
+
+    after(:all) do
+      silence_warnings { Rails::VERSION::MINOR = @actual_rails_version }
+    end
+
+    before do
+      assets = mock(:enabled => true)
+      Rails.application.config.stub!(:assets => assets)
+    end
+
+    it "should call the sass-rails asset helper" do
+      self.should_receive(:asset_path).with(Sass::Script::String.new("active_admin/test.jpg"), Sass::Script::String.new('image'))
+      active_admin_image_path(::Sass::Script::String.new('test.jpg'))
+    end
+
+  end
+
+end

data/spec/unit/scope_spec.rb

@@ -12,6 +12,16 @@ describe ActiveAdmin::Scope do
       its(:scope_method) { should == :published }
     end
 
+    context "when scope method is :all" do
+      let(:scope)        { ActiveAdmin::Scope.new :all }
+      its(:name)         { should == "All"}
+      its(:id)           { should == "all"}
+      # :all does not return a chain but an array of active record
+      # instances. We set the scope_method to nil then.
+      its(:scope_method) { should == nil }
+      its(:scope_block)  { should == nil }
+    end
+
     context "when a name and scope method" do
       let(:scope)        { ActiveAdmin::Scope.new "My Scope", :scope_method }
       its(:name)         { should == "My Scope"}
@@ -26,6 +36,6 @@ describe ActiveAdmin::Scope do
       its(:scope_method) { should == nil }
       its(:scope_block)  { should be_a(Proc)}
     end
-  end
+  end # describe "creating a scope"
 
 end

data/spec/unit/view_factory_spec.rb

@@ -8,9 +8,12 @@ end
 
 describe ActiveAdmin::ViewFactory do
 
-  it_should_have_view :global_navigation, ActiveAdmin::Views::TabsRenderer
+  it_should_have_view :global_navigation, ActiveAdmin::Views::TabbedNavigation
   it_should_have_view :action_items,      ActiveAdmin::Views::ActionItems
   it_should_have_view :header,            ActiveAdmin::Views::HeaderRenderer
+  it_should_have_view :blank_slate,       ActiveAdmin::Views::BlankSlate
+
   it_should_have_view :dashboard_page,    ActiveAdmin::Views::Pages::Dashboard
+  it_should_have_view :layout,            ActiveAdmin::Views::Pages::Layout
 
 end