activeadmin 0.2.2 → 0.3.0

data/spec/support/detect_rails_version.rb

@@ -0,0 +1,10 @@
+# Detects the current version of Rails that is being used
+#
+# You can pass it in as an ENV variable or it will use
+# the current Gemfile.lock to find it
+def detect_rails_version
+  return nil unless (File.exists?("Gemfile.lock") || File.symlink?("Gemfile.lock"))
+
+  File.read("Gemfile.lock").match(/^\W*rails \(([a-z\d.]*)\)/)
+  return $1
+end

data/spec/support/integration_example_group.rb

@@ -10,7 +10,7 @@ module RSpec
       include ActionDispatch::Integration::Runner
       include RSpec::Rails::TestUnitAssertionAdapter
       include ActionDispatch::Assertions
-      include Capybara
+      include Capybara::DSL
       include RSpec::Matchers
 
       module InstanceMethods

data/spec/support/jslint.yml

@@ -0,0 +1,80 @@
+# ------------ rake task options ------------
+
+# JS files to check by default, if no parameters are passed to rake jslint
+# (you may want to limit this only to your own scripts and exclude any external scripts and frameworks)
+
+# this can be overridden by adding 'paths' and 'exclude_paths' parameter to rake command:
+#   rake jslint paths=path1,path2,... exclude_paths=library1,library2,...
+
+paths:
+  - app/assets/javascripts/active_admin/**/*.js
+
+exclude_paths:
+  - app/assets/javascripts/active_admin/vendor.js
+
+# ------------ jslint options ------------
+# see http://www.jslint.com/lint.html#options for more detailed explanations
+
+# "enforce" type options (true means potentially more warnings)
+
+adsafe:   false     # true if ADsafe rules should be enforced. See http://www.ADsafe.org/
+bitwise:  true      # true if bitwise operators should not be allowed
+newcap:   true      # true if Initial Caps must be used with constructor functions
+eqeqeq:   false     # true if === should be required (for ALL equality comparisons)
+immed:    false     # true if immediate function invocations must be wrapped in parens
+nomen:    false     # true if initial or trailing underscore in identifiers should be forbidden
+onevar:   false     # true if only one var statement per function should be allowed
+plusplus: false     # true if ++ and -- should not be allowed
+regexp:   false     # true if . and [^...] should not be allowed in RegExp literals
+safe:     false     # true if the safe subset rules are enforced (used by ADsafe)
+strict:   false     # true if the ES5 "use strict"; pragma is required
+undef:    false     # true if variables must be declared before used
+white:    false     # true if strict whitespace rules apply (see also 'indent' option)
+
+# "allow" type options (false means potentially more warnings)
+
+cap:      false     # true if upper case HTML should be allowed
+css:      true      # true if CSS workarounds should be tolerated
+debug:    false     # true if debugger statements should be allowed (set to false before going into production)
+es5:      false     # true if ECMAScript 5 syntax should be allowed
+evil:     false     # true if eval should be allowed
+forin:    true      # true if unfiltered 'for in' statements should be allowed
+fragment: true      # true if HTML fragments should be allowed
+laxbreak: false     # true if statement breaks should not be checked
+on:       false     # true if HTML event handlers (e.g. onclick="...") should be allowed
+sub:      false     # true if subscript notation may be used for expressions better expressed in dot notation
+
+# other options
+
+maxlen:   300       # Maximum line length
+indent:   2         # Number of spaces that should be used for indentation - used only if 'white' option is set
+maxerr:   50        # The maximum number of warnings reported (per file)
+passfail: false     # true if the scan should stop on first error (per file)
+# following are relevant only if undef = true
+predef:   ''        # Names of predefined global variables - comma-separated string or a YAML array
+browser:  true      # true if the standard browser globals should be predefined
+rhino:    false     # true if the Rhino environment globals should be predefined
+windows:  false     # true if Windows-specific globals should be predefined
+widget:   false     # true if the Yahoo Widgets globals should be predefined
+devel:    true      # true if functions like alert, confirm, console, prompt etc. are predefined
+
+
+# ------------ jslint_on_rails custom lint options (switch to true to disable some annoying warnings) ------------
+
+# ignores "missing semicolon" warning at the end of a function; this lets you write one-liners
+# like: x.map(function(i) { return i + 1 }); without having to put a second semicolon inside the function
+lastsemic: false
+
+# allows you to use the 'new' expression as a statement (without assignment)
+# so you can call e.g. new Ajax.Request(...), new Effect.Highlight(...) without assigning to a dummy variable
+newstat: false
+
+# ignores the "Expected an assignment or function call and instead saw an expression" warning,
+# if the expression contains a proper statement and makes sense; this lets you write things like:
+#    element && element.show();
+#    valid || other || lastChance || alert('OMG!');
+#    selected ? show() : hide();
+# although these will still cause a warning:
+#    element && link;
+#    selected ? 5 : 10;
+statinexp: false

data/spec/support/rails_template.rb

@@ -8,7 +8,7 @@ gsub_file 'config/database.yml', /\z/, "\ncucumber:\n  <<: *test\n  database: db
 # Generate some test models
 generate :model, "post title:string body:text published_at:datetime author_id:integer category_id:integer"
 inject_into_file 'app/models/post.rb', "  belongs_to :author, :class_name => 'User'\n  belongs_to :category\n  accepts_nested_attributes_for :author\n", :after => "class Post < ActiveRecord::Base\n"
-generate :model, "user type:string first_name:string last_name:string username:string"
+generate :model, "user type:string first_name:string last_name:string username:string age:integer"
 inject_into_file 'app/models/user.rb', "  has_many :posts, :foreign_key => 'author_id'\n", :after => "class User < ActiveRecord::Base\n"
 generate :model, "publisher --migration=false --parent=User"
 generate :model, 'category name:string description:text'

data/spec/support/rails_template_with_data.rb

@@ -12,7 +12,8 @@ append_file "db/seeds.rb", <<-EOF
     first, last = name.split(" ")
     User.create!  :first_name => first,
                   :last_name => last,
-                  :username => [first,last].join('-').downcase
+                  :username => [first,last].join('-').downcase,
+                  :age => rand(80)
   end
 
   categories = ["Rock", "Pop Rock", "Alt-Country", "Blues", "Dub-Step"].collect do |name|

data/spec/support/templates/cucumber.rb

@@ -1,9 +1,5 @@
 require File.expand_path('config/environments/test', Rails.root)
 
-Rails.application.class.configure do
-  config.cache_classes = false
-end
-
 # rails/railties/lib/rails/test_help.rb aborts if the environment is not 'test'. (Rails 3.0.0.beta3)
 # We can't run Cucumber/RSpec/Test_Unit tests in different environments then.
 #

data/spec/unit/active_admin_spec.rb

@@ -1,53 +1,17 @@
 require 'spec_helper'
-require 'fileutils'
 
 describe ActiveAdmin do
+  describe "#default_namespace" do
+    it "should delegate to ActiveAdmin.application" do
+      ActiveAdmin.application.should_receive(:default_namespace)
 
-  it "should have a default load path of ['app/admin']" do
-    ActiveAdmin.load_paths.should == [File.expand_path('app/admin', Rails.root)]
-  end
-
-  it "should remove app/admin from the autoload path to remove the possibility of conflicts" do
-    ActiveSupport::Dependencies.autoload_paths.should_not include(File.join(Rails.root, "app/admin"))
-  end
-
-  it "should remove app/admin from the eager load paths (Active Admin deals with loading)" do
-    Rails.application.config.eager_load_paths.should_not include(File.join(Rails.root, "app/admin"))
-  end
-
-  it "should default the application name" do
-    ActiveAdmin.site_title.should == Rails.application.class.to_s.split('::').first
-  end
-
-  it "should set the site title" do
-    old_title = ActiveAdmin.site_title.dup
-    ActiveAdmin.site_title = "New Title"
-    ActiveAdmin.site_title.should == "New Title"
-    ActiveAdmin.site_title = old_title
-  end
-
-  it "should have a view factory" do
-    ActiveAdmin.view_factory.should be_an_instance_of(ActiveAdmin::ViewFactory)
-  end
-
-  it "should have admin notes by default" do
-    ActiveAdmin.admin_notes.should be_true
-  end
+      ActiveAdmin.default_namespace
+    end
 
-  it "should have a default current_user_method" do
-    ActiveAdmin.current_user_method.should == false
-  end
+    it "should be deprecated" do
+      ActiveAdmin::Deprecation.should_receive(:warn)
 
-  describe "files in load path" do
-    it "should load files in the first level directory" do
-      ActiveAdmin.files_in_load_path.should include(File.expand_path("app/admin/dashboards.rb", Rails.root))
-    end
-    it "should load files from subdirectories" do
-      FileUtils.mkdir_p(File.expand_path("app/admin/public", Rails.root))
-      test_file = File.expand_path("app/admin/public/posts.rb", Rails.root)
-      FileUtils.touch(test_file)
-      ActiveAdmin.files_in_load_path.should include(test_file)
+      ActiveAdmin.default_namespace
     end
   end
-
 end

data/spec/unit/application_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+require 'fileutils'
+
+describe ActiveAdmin::Application do
+
+  let(:application) do
+    ActiveAdmin::Application.new.tap do |app|
+      # Manually override the load paths becuase RSpec messes these up
+      app.load_paths = [File.expand_path('app/admin', Rails.root)]
+    end
+  end
+
+  it "should have a default load path of ['app/admin']" do
+    application.load_paths.should == [File.expand_path('app/admin', Rails.root)]
+  end
+
+  it "should remove app/admin from the autoload path to remove the possibility of conflicts" do
+    ActiveSupport::Dependencies.autoload_paths.should_not include(File.join(Rails.root, "app/admin"))
+  end
+
+  it "should remove app/admin from the eager load paths (Active Admin deals with loading)" do
+    Rails.application.config.eager_load_paths.should_not include(File.join(Rails.root, "app/admin"))
+  end
+
+  it "should store the site's title" do
+    application.site_title.should == ""
+  end
+
+  it "should set the site title" do
+    application.site_title = "New Title"
+    application.site_title.should == "New Title"
+  end
+
+  it "should have a view factory" do
+    application.view_factory.should be_an_instance_of(ActiveAdmin::ViewFactory)
+  end
+
+  it "should have deprecated admin notes by default" do 
+    application.admin_notes.should be_nil
+  end
+
+  it "should have admin notes in admin namespace by default" do
+    application.allow_comments_in.should == [:admin]
+  end
+
+  describe "authentication settings" do
+
+    it "should have no default current_user_method" do
+      application.current_user_method.should == false
+    end
+
+    it "should have no default authentication method" do
+      application.authentication_method.should == false
+    end
+
+    it "should have a logout link path (Devise's default)" do
+      application.logout_link_path.should == :destroy_admin_user_session_path
+    end
+
+    it "should have a logout link method (Devise's default)" do
+      application.logout_link_method.should == :get
+    end
+  end
+
+  describe "files in load path" do
+    it "should load files in the first level directory" do
+      application.files_in_load_path.should include(File.expand_path("app/admin/dashboards.rb", Rails.root))
+    end
+
+    it "should load files from subdirectories" do
+      FileUtils.mkdir_p(File.expand_path("app/admin/public", Rails.root))
+      test_file = File.expand_path("app/admin/public/posts.rb", Rails.root)
+      FileUtils.touch(test_file)
+      application.files_in_load_path.should include(test_file)
+    end
+  end
+
+end

data/spec/unit/arbre/context_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe Arbre::Context do
+
+  setup_arbre_context!
+
+  before do
+    h1 # Add some HTML to the context
+  end
+
+  it "should return a bytesize" do
+    current_dom_context.bytesize.should == 10
+  end
+
+  it "should return a length" do
+    current_dom_context.length.should == 10
+  end
+
+  it "should not increment the indent_level" do
+    current_dom_context.indent_level.should == -1
+  end
+end

data/spec/unit/arbre/html/element_finder_methods_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 describe Arbre::HTML::Element, "Finder Methods" do
-  include Arbre::HTML
-  let(:assigns){ {} }
+
+  setup_arbre_context!
 
   describe "finding elements by tag name" do
 

data/spec/unit/arbre/html/element_spec.rb

@@ -1,10 +1,9 @@
 require 'spec_helper'
-require 'active_admin/arbre/element'
 
 describe Arbre::HTML::Element do
-  include Arbre::HTML
 
-  let(:assigns){ {} }
+  setup_arbre_context!
+
   let(:element){ Arbre::HTML::Element.new }
 
   context "when initialized" do

data/spec/unit/arbre/html/tag_attributes_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 describe Arbre::HTML::Tag, "Attributes" do
-  include Arbre::HTML
-  let(:assigns){ {} }
+
+  setup_arbre_context!
 
   let(:tag){ Arbre::HTML::Tag.new }
 

data/spec/unit/arbre/html/tag_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 describe Arbre::HTML::Tag do
-  include Arbre::HTML
-  let(:assigns){ {} }
+
+  setup_arbre_context!
 
   let(:tag){ Arbre::HTML::Tag.new }
 

data/spec/unit/arbre/html_spec.rb

@@ -1,9 +1,8 @@
 require 'spec_helper'
 
-describe Arbre::HTML do
-  include Arbre::HTML
+describe Arbre do
 
-  let(:assigns){ {} }
+  setup_arbre_context!
 
   it "should render a single element" do
     content = span("Hello World")

data/spec/unit/auto_link_spec.rb

@@ -8,11 +8,12 @@ class AutoLinkMockResource
 end
 
 describe "auto linking resources" do
+  include ActiveAdmin::ViewHelpers::ActiveAdminApplicationHelper
   include ActiveAdmin::ViewHelpers::AutoLinkHelper
   include ActiveAdmin::ViewHelpers::DisplayHelper
 
   let(:active_admin_config) { AutoLinkMockResource.new(namespace) }
-  let(:namespace){ ActiveAdmin::Namespace.new(:admin) }
+  let(:namespace){ ActiveAdmin::Namespace.new(ActiveAdmin::Application.new, :admin) }
   let(:post){ Post.create! :title => "Hello World" }
 
   def admin_post_path(post)

data/spec/unit/belongs_to_spec.rb

@@ -4,7 +4,8 @@ module ActiveAdmin
   class Resource
     describe BelongsTo do
 
-      let(:namespace){ Namespace.new(:admin) }
+      let(:application){ ActiveAdmin::Application.new }
+      let(:namespace){ Namespace.new(application, :admin) }
       let(:post){ namespace.register(Post) }
       let(:belongs_to){ BelongsTo.new(post, :user) }
 

data/spec/unit/comments_spec.rb

@@ -1,53 +1,57 @@
 require 'spec_helper'
 
-describe "Configuration" do
-  it "should have an array of namespaces which allow comments" do
-    ActiveAdmin.allow_comments_in.should be_an_instance_of(Array)
-  end
+describe "Comments" do
+  let(:application){ ActiveAdmin::Application.new }
+
+  describe "Configuration" do
+    it "should have an array of namespaces which allow comments" do
+      application.allow_comments_in.should be_an_instance_of(Array)
+    end
 
-  it "should allow comments in the default namespace by default" do
-    ActiveAdmin.allow_comments_in.should include(ActiveAdmin.default_namespace)
+    it "should allow comments in the default namespace by default" do
+      application.allow_comments_in.should include(application.default_namespace)
+    end
   end
-end
 
-describe ActiveAdmin::Comment do
-  describe "Associations and Validations" do
-    it { should belong_to :resource }
-    it { should belong_to :author }
+  describe ActiveAdmin::Comment do
+    describe "Associations and Validations" do
+      it { should belong_to :resource }
+      it { should belong_to :author }
 
-    it { should validate_presence_of :resource_id }
-    it { should validate_presence_of :resource_type }
-    it { should validate_presence_of :body }
-    it { should validate_presence_of :namespace }
+      it { should validate_presence_of :resource_id }
+      it { should validate_presence_of :resource_type }
+      it { should validate_presence_of :body }
+      it { should validate_presence_of :namespace }
+    end
   end
-end
 
-describe ActiveAdmin::Comments::NamespaceHelper do
-  describe "#comments?" do
-    it "should have comments if the namespace is in the settings" do
-      ns = ActiveAdmin::Namespace.new(ActiveAdmin.default_namespace)
-      ns.comments?.should be_true
-    end
-    it "should not have comments if the namespace is not in the settings" do
-      ns = ActiveAdmin::Namespace.new(:not_in_comments)
-      ns.comments?.should be_false
+  describe ActiveAdmin::Comments::NamespaceHelper do
+    describe "#comments?" do
+      it "should have comments if the namespace is in the settings" do
+        ns = ActiveAdmin::Namespace.new(application, :admin)
+        ns.comments?.should be_true
+      end
+      it "should not have comments if the namespace is not in the settings" do
+        ns = ActiveAdmin::Namespace.new(application, :not_in_comments)
+        ns.comments?.should be_false
+      end
     end
   end
-end
 
-describe ActiveAdmin::Comments::ResourceHelper do
-  it "should add an attr_accessor :comments to ActiveAdmin::Resource" do
-    ns = ActiveAdmin::Namespace.new(:admin)
-    resource = ActiveAdmin::Resource.new(ns, Post)
-    resource.comments.should be_nil
-    resource.comments = true
-    resource.comments.should be_true
-  end
+  describe ActiveAdmin::Comments::ResourceHelper do
+    it "should add an attr_accessor :comments to ActiveAdmin::Resource" do
+      ns = ActiveAdmin::Namespace.new(application, :admin)
+      resource = ActiveAdmin::Resource.new(ns, Post)
+      resource.comments.should be_nil
+      resource.comments = true
+      resource.comments.should be_true
+    end
 
-  it "should not have comment if set to false by in allow_comments_in" do
-    ns = ActiveAdmin::Namespace.new(ActiveAdmin.default_namespace)
-    resource = ActiveAdmin::Resource.new(ns, Post)
-    resource.comments = false
-    resource.comments?.should be_false
+    it "should not have comment if set to false by in allow_comments_in" do
+      ns = ActiveAdmin::Namespace.new(application, application.default_namespace)
+      resource = ActiveAdmin::Resource.new(ns, Post)
+      resource.comments = false
+      resource.comments?.should be_false
+    end
   end
 end