activeadmin-rb 1.4.0

data/spec/unit/scope_spec.rb

@@ -0,0 +1,225 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::Scope do
+
+  describe "creating a scope" do
+    subject{ scope }
+
+    context "when just a scope method" do
+      let(:scope) { ActiveAdmin::Scope.new :published }
+
+      describe '#name' do
+        subject { super().name }
+        it      { is_expected.to eq("Published")}
+      end
+
+      describe '#id' do
+        subject { super().id }
+        it      { is_expected.to eq("published")}
+      end
+
+      describe '#scope_method' do
+        subject { super().scope_method }
+        it      { is_expected.to eq(:published) }
+      end
+    end
+
+    context "when scope method is :all" do
+      let(:scope) { ActiveAdmin::Scope.new :all }
+
+      describe '#name' do
+        subject { super().name }
+        it      { is_expected.to eq("All")}
+      end
+
+      describe '#id' do
+        subject { super().id }
+        it      { is_expected.to eq("all")}
+      end
+      # :all does not return a chain but an array of active record
+      # instances. We set the scope_method to nil then.
+
+      describe '#scope_method' do
+        subject { super().scope_method }
+        it      { is_expected.to eq(nil) }
+      end
+
+      describe '#scope_block' do
+        subject { super().scope_block }
+        it      { is_expected.to eq(nil) }
+      end
+    end
+
+    context 'when a name and scope method is :all' do
+      let(:scope) { ActiveAdmin::Scope.new 'Tous', :all }
+
+      describe '#name' do
+        subject { super().name }
+        it      { is_expected.to eq 'Tous' }
+      end
+
+      describe '#scope_method' do
+        subject { super().scope_method }
+        it      { is_expected.to eq nil }
+      end
+
+      describe '#scope_block' do
+        subject { super().scope_block }
+        it      { is_expected.to eq nil }
+      end
+    end
+
+    context "when a name and scope method" do
+      let(:scope) { ActiveAdmin::Scope.new "With API Access", :with_api_access }
+
+      describe '#name' do
+        subject { super().name }
+        it      { is_expected.to eq("With API Access")}
+      end
+
+      describe '#id' do
+        subject { super().id }
+        it      { is_expected.to eq("with_api_access")}
+      end
+
+      describe '#scope_method' do
+        subject { super().scope_method }
+        it      { is_expected.to eq(:with_api_access) }
+      end
+    end
+
+    context "when a name and scope block" do
+      let(:scope) { ActiveAdmin::Scope.new("My Scope"){|s| s } }
+
+      describe '#name' do
+        subject { super().name }
+        it      { is_expected.to eq("My Scope")}
+      end
+
+      describe '#id' do
+        subject { super().id }
+        it      { is_expected.to eq("my_scope")}
+      end
+
+      describe '#scope_method' do
+        subject { super().scope_method }
+        it      { is_expected.to eq(nil) }
+      end
+
+      describe '#scope_block' do
+        subject { super().scope_block }
+        it      { is_expected.to be_a(Proc)}
+      end
+    end
+
+    context "when a name has a space and lowercase" do
+      let(:scope) { ActiveAdmin::Scope.new("my scope") }
+
+      describe '#name' do
+        subject { super().name }
+        it      { is_expected.to eq("my scope")}
+      end
+
+      describe '#id' do
+        subject { super().id }
+        it      { is_expected.to eq("my_scope")}
+      end
+    end
+
+    context "with a proc as the label" do
+      it "should raise an exception if a second argument isn't provided" do
+        expect{
+          ActiveAdmin::Scope.new proc{ Date.today.strftime '%A' }
+        }.to raise_error 'A string/symbol is required as the second argument if your label is a proc.'
+      end
+
+      it "should properly render the proc" do
+        scope = ActiveAdmin::Scope.new proc{ Date.today.strftime '%A' }, :foobar
+        expect(scope.name.call).to eq Date.today.strftime '%A'
+      end
+    end
+
+    context "with scope method and localizer" do
+      let(:localizer) do
+        loc = double(:localizer)
+        allow(loc).to receive(:t).with(:published, scope: 'scopes').and_return("All published")
+        loc
+      end
+      let(:scope) { ActiveAdmin::Scope.new :published, :published, localizer: localizer }
+
+      describe '#name' do
+        subject { super().name }
+        it { is_expected.to eq("All published")}
+      end
+
+      describe '#id' do
+        subject { super().id }
+        it { is_expected.to eq("published")}
+      end
+
+      describe '#scope_method' do
+        subject { super().scope_method }
+        it { is_expected.to eq(:published) }
+      end
+    end
+
+  end # describe "creating a scope"
+
+  describe "#display_if_block" do
+    it "should return true by default" do
+      scope = ActiveAdmin::Scope.new(:default)
+      expect(scope.display_if_block.call).to eq true
+    end
+
+    it "should return the :if block if set" do
+      scope = ActiveAdmin::Scope.new(:with_block, nil, if: proc{ false })
+      expect(scope.display_if_block.call).to eq false
+    end
+  end
+
+  describe "#default" do
+    it "should accept a boolean" do
+      scope = ActiveAdmin::Scope.new(:method, nil, default: true)
+      expect(scope.default_block).to eq true
+    end
+
+    it "should default to a false #default_block" do
+      scope = ActiveAdmin::Scope.new(:method, nil)
+      expect(scope.default_block.call).to eq false
+    end
+
+    it "should store the :default proc" do
+      scope = ActiveAdmin::Scope.new(:with_block, nil, default: proc{ true })
+      expect(scope.default_block.call).to eq true
+    end
+  end
+
+  describe "show_count" do
+    it "should allow setting of show_count to prevent showing counts" do
+      scope = ActiveAdmin::Scope.new(:default, nil, show_count: false)
+      expect(scope.show_count).to eq false
+    end
+
+    it "should set show_count to true if not passed in" do
+      scope = ActiveAdmin::Scope.new(:default)
+      expect(scope.show_count).to eq true
+    end
+  end
+
+  describe "group" do
+    it "should default to nil" do
+      scope = ActiveAdmin::Scope.new(:default)
+      expect(scope.group).to eq nil
+    end
+
+    it "should accept a symbol to assign a group to the scope" do
+      scope = ActiveAdmin::Scope.new(:default, nil, group: :test)
+      expect(scope.group).to eq :test
+    end
+
+    it "should accept a string to assign a group to the scope" do
+      scope = ActiveAdmin::Scope.new(:default, nil, group: "test")
+      expect(scope.group).to eq :test
+    end
+  end
+end

data/spec/unit/settings_node_spec.rb

@@ -0,0 +1,26 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::SettingsNode do
+  subject { ActiveAdmin::SettingsNode.build }
+  let!(:child) { ActiveAdmin::SettingsNode.build(subject) }
+
+  context 'parent setting includes foo' do
+    before { subject.register :foo, true }
+
+    it 'returns parent settings' do
+      expect(child.foo).to eq true
+    end
+
+    it 'fails if setting undefined' do
+      expect do
+        child.bar
+      end.to raise_error(NoMethodError)
+    end
+
+    context 'child overrides foo' do
+      before { child.foo = false }
+
+      it { expect(child.foo).to eq false }
+    end
+  end
+end

data/spec/unit/view_factory_spec.rb

@@ -0,0 +1,19 @@
+require 'rails_helper'
+
+def it_should_have_view(key, value)
+  it "should have #{value} for view key '#{key}'" do
+    expect(subject.send(key)).to eq value
+  end
+end
+
+RSpec.describe ActiveAdmin::ViewFactory do
+
+  it_should_have_view :global_navigation,    ActiveAdmin::Views::TabbedNavigation
+  it_should_have_view :utility_navigation,   ActiveAdmin::Views::TabbedNavigation
+  it_should_have_view :site_title,           ActiveAdmin::Views::SiteTitle
+  it_should_have_view :action_items,         ActiveAdmin::Views::ActionItems
+  it_should_have_view :header,               ActiveAdmin::Views::Header
+  it_should_have_view :blank_slate,          ActiveAdmin::Views::BlankSlate
+  it_should_have_view :layout,               ActiveAdmin::Views::Pages::Layout
+
+end

data/spec/unit/view_helpers/breadcrumbs_spec.rb

@@ -0,0 +1,253 @@
+require 'rails_helper'
+
+RSpec.describe "Breadcrumbs" do
+
+  include ActiveAdmin::ViewHelpers
+  include ActionView::Helpers::SanitizeHelper
+
+  describe "generating a trail from paths" do
+
+    def params; {}; end
+    def link_to(name, url); {name: name, path: url}; end
+
+    actions = ActiveAdmin::BaseController::ACTIVE_ADMIN_ACTIONS
+
+    let(:user)        { double display_name: 'Jane Doe' }
+    let(:user_config) { double find_resource: user, resource_name: double(route_key: 'users'),
+                               defined_actions: actions }
+    let(:post)        { double display_name: 'Hello World' }
+    let(:post_config) { double find_resource: post, resource_name: double(route_key: 'posts'),
+                               defined_actions: actions, belongs_to_config: double(target: user_config) }
+
+    let :active_admin_config do
+      post_config
+    end
+
+    let(:trail) { breadcrumb_links(path) }
+
+    context "when request '/admin'" do
+      let(:path) { "/admin" }
+
+      it "should not have any items" do
+        expect(trail.size).to eq 0
+      end
+    end
+
+    context "when path 'admin/users'" do
+      let(:path) { 'admin/users' }
+
+      it 'should have one item' do
+        expect(trail.size).to eq 1
+      end
+      it 'should have a link to /admin' do
+        expect(trail[0][:name]).to eq 'Admin'
+        expect(trail[0][:path]).to eq '/admin'
+      end
+    end
+
+    context "when path '/admin/users'" do
+      let(:path) { "/admin/users" }
+
+      it "should have one item" do
+        expect(trail.size).to eq 1
+      end
+      it "should have a link to /admin" do
+        expect(trail[0][:name]).to eq "Admin"
+        expect(trail[0][:path]).to eq "/admin"
+      end
+    end
+
+    context "when path '/admin/users/1'" do
+      let(:path) { "/admin/users/1" }
+
+      it "should have 2 items" do
+        expect(trail.size).to eq 2
+      end
+      it "should have a link to /admin" do
+        expect(trail[0][:name]).to eq "Admin"
+        expect(trail[0][:path]).to eq "/admin"
+      end
+      it "should have a link to /admin/users" do
+        expect(trail[1][:name]).to eq "Users"
+        expect(trail[1][:path]).to eq "/admin/users"
+      end
+    end
+
+    context "when path '/admin/users/1/posts'" do
+      let(:path) { "/admin/users/1/posts" }
+
+      it "should have 3 items" do
+        expect(trail.size).to eq 3
+      end
+      it "should have a link to /admin" do
+        expect(trail[0][:name]).to eq "Admin"
+        expect(trail[0][:path]).to eq "/admin"
+      end
+      it "should have a link to /admin/users" do
+        expect(trail[1][:name]).to eq "Users"
+        expect(trail[1][:path]).to eq "/admin/users"
+      end
+
+      context "when User.find(1) doesn't exist" do
+        before { allow(user_config).to receive(:find_resource) }
+        it "should have a link to /admin/users/1" do
+          expect(trail[2][:name]).to eq "1"
+          expect(trail[2][:path]).to eq "/admin/users/1"
+        end
+      end
+
+      context "when User.find(1) does exist" do
+        it "should have a link to /admin/users/1 using display name" do
+          expect(trail[2][:name]).to eq "Jane Doe"
+          expect(trail[2][:path]).to eq "/admin/users/1"
+        end
+      end
+    end
+
+    context "when path '/admin/users/4e24d6249ccf967313000000/posts'" do
+      let(:path) { "/admin/users/4e24d6249ccf967313000000/posts" }
+
+      it "should have 3 items" do
+        expect(trail.size).to eq 3
+      end
+      it "should have a link to /admin" do
+        expect(trail[0][:name]).to eq "Admin"
+        expect(trail[0][:path]).to eq "/admin"
+      end
+      it "should have a link to /admin/users" do
+        expect(trail[1][:name]).to eq "Users"
+        expect(trail[1][:path]).to eq "/admin/users"
+      end
+
+      context "when User.find(4e24d6249ccf967313000000) doesn't exist" do
+        before { allow(user_config).to receive(:find_resource) }
+        it "should have a link to /admin/users/4e24d6249ccf967313000000" do
+          expect(trail[2][:name]).to eq "4e24d6249ccf967313000000"
+          expect(trail[2][:path]).to eq "/admin/users/4e24d6249ccf967313000000"
+        end
+      end
+
+      context "when User.find(4e24d6249ccf967313000000) does exist" do
+        before do
+          display_name = double(display_name: 'Hello :)')
+          allow(user_config).to receive(:find_resource).and_return(display_name)
+        end
+        it "should have a link to /admin/users/4e24d6249ccf967313000000 using display name" do
+          expect(trail[2][:name]).to eq "Hello :)"
+          expect(trail[2][:path]).to eq "/admin/users/4e24d6249ccf967313000000"
+        end
+      end
+    end
+
+    context "when path '/admin/users/2b2f0fc2-9a0d-41b8-b39d-aa21963aaee4/posts'" do
+      let(:path) { "/admin/users/2b2f0fc2-9a0d-41b8-b39d-aa21963aaee4/posts" }
+
+      it "should have 3 items" do
+        expect(trail.size).to eq 3
+      end
+      it "should have a link to /admin" do
+        expect(trail[0][:name]).to eq "Admin"
+        expect(trail[0][:path]).to eq "/admin"
+      end
+      it "should have a link to /admin/users" do
+        expect(trail[1][:name]).to eq "Users"
+        expect(trail[1][:path]).to eq "/admin/users"
+      end
+
+      context "when User.find(2b2f0fc2-9a0d-41b8-b39d-aa21963aaee4) doesn't exist" do
+        before { allow(user_config).to receive(:find_resource) }
+        it "should have a link to /admin/users/2b2f0fc2-9a0d-41b8-b39d-aa21963aaee4" do
+          expect(trail[2][:name]).to eq "2b2f0fc2-9a0d-41b8-b39d-aa21963aaee4".titlecase
+          expect(trail[2][:path]).to eq "/admin/users/2b2f0fc2-9a0d-41b8-b39d-aa21963aaee4"
+        end
+      end
+
+      context "when User.find(2b2f0fc2-9a0d-41b8-b39d-aa21963aaee4) does exist" do
+        before do
+          display_name = double(display_name: 'Hello :)')
+          allow(user_config).to receive(:find_resource).and_return(display_name)
+        end
+        it "should have a link to /admin/users/2b2f0fc2-9a0d-41b8-b39d-aa21963aaee4 using display name" do
+          expect(trail[2][:name]).to eq "Hello :)"
+          expect(trail[2][:path]).to eq "/admin/users/2b2f0fc2-9a0d-41b8-b39d-aa21963aaee4"
+        end
+      end
+    end
+
+    context "when path '/admin/users/1/coments/1'" do
+      let(:path) { "/admin/users/1/posts/1" }
+
+      it "should have 4 items" do
+        expect(trail.size).to eq 4
+      end
+      it "should have a link to /admin" do
+        expect(trail[0][:name]).to eq "Admin"
+        expect(trail[0][:path]).to eq "/admin"
+      end
+      it "should have a link to /admin/users" do
+        expect(trail[1][:name]).to eq "Users"
+        expect(trail[1][:path]).to eq "/admin/users"
+      end
+      it "should have a link to /admin/users/1" do
+        expect(trail[2][:name]).to eq "Jane Doe"
+        expect(trail[2][:path]).to eq "/admin/users/1"
+      end
+      it "should have a link to /admin/users/1/posts" do
+        expect(trail[3][:name]).to eq "Posts"
+        expect(trail[3][:path]).to eq "/admin/users/1/posts"
+      end
+    end
+
+    context "when path '/admin/users/1/coments/1/edit'" do
+      let(:path) { "/admin/users/1/posts/1/edit" }
+
+      it "should have 5 items" do
+        expect(trail.size).to eq 5
+      end
+      it "should have a link to /admin" do
+        expect(trail[0][:name]).to eq "Admin"
+        expect(trail[0][:path]).to eq "/admin"
+      end
+      it "should have a link to /admin/users" do
+        expect(trail[1][:name]).to eq "Users"
+        expect(trail[1][:path]).to eq "/admin/users"
+      end
+      it "should have a link to /admin/users/1" do
+        expect(trail[2][:name]).to eq "Jane Doe"
+        expect(trail[2][:path]).to eq "/admin/users/1"
+      end
+      it "should have a link to /admin/users/1/posts" do
+        expect(trail[3][:name]).to eq "Posts"
+        expect(trail[3][:path]).to eq "/admin/users/1/posts"
+      end
+      it "should have a link to /admin/users/1/posts/1" do
+        expect(trail[4][:name]).to eq "Hello World"
+        expect(trail[4][:path]).to eq "/admin/users/1/posts/1"
+      end
+    end
+
+    context "when the 'show' action is disabled" do
+      let(:post_config) { double find_resource: post, resource_name: double(route_key: 'posts'),
+                                 defined_actions: actions - [:show], # this is the change
+                                 belongs_to_config: double(target: user_config) }
+
+      let(:path) { "/admin/posts/1/edit" }
+
+      it "should have 3 items" do
+        expect(trail.size).to eq 3
+      end
+      it "should have a link to /admin" do
+        expect(trail[0][:name]).to eq "Admin"
+        expect(trail[0][:path]).to eq "/admin"
+      end
+      it "should have a link to /admin/posts" do
+        expect(trail[1][:name]).to eq "Posts"
+        expect(trail[1][:path]).to eq "/admin/posts"
+      end
+      it "should not link to the show view for the post" do
+        expect(trail[2]).to eq "Hello World"
+      end
+    end
+
+  end
+end