activeadmin-rb 1.4.0

data/spec/unit/belongs_to_spec.rb

@@ -0,0 +1,76 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::Resource::BelongsTo do
+  before do
+    load_resources do
+      ActiveAdmin.register User
+      ActiveAdmin.register Post do belongs_to :user end
+    end
+  end
+
+  let(:namespace) { ActiveAdmin.application.namespace(:admin) }
+  let(:user_config){ ActiveAdmin.register User }
+  let(:post_config){ ActiveAdmin.register Post do belongs_to :user end }
+  let(:belongs_to){ post_config.belongs_to_config }
+
+  it "should have an owner" do
+    expect(belongs_to.owner).to eq post_config
+  end
+
+  describe "finding the target" do
+    context "when the resource has been registered" do
+      it "should return the target resource" do
+        expect(belongs_to.target).to eq user_config
+      end
+    end
+
+    context "when the resource has not been registered" do
+      let(:belongs_to){ ActiveAdmin::Resource::BelongsTo.new post_config, :missing }
+
+      it "should raise a ActiveAdmin::BelongsTo::TargetNotFound" do
+        expect {
+          belongs_to.target
+        }.to raise_error(ActiveAdmin::Resource::BelongsTo::TargetNotFound)
+      end
+    end
+
+    context "when the resource is on a namespace" do
+      let(:blog_post_config){ ActiveAdmin.register Blog::Post do; end }
+      let(:belongs_to) { ActiveAdmin::Resource::BelongsTo.new blog_post_config, :blog_author, class_name: "Blog::Author" }
+      before do
+        class Blog::Author
+          include ActiveModel::Naming
+        end
+        @blog_author_config = ActiveAdmin.register Blog::Author do; end
+      end
+      it "should return the target resource" do
+        expect(belongs_to.target).to eq @blog_author_config
+      end
+    end
+  end
+
+  it "should be optional" do
+    belongs_to = ActiveAdmin::Resource::BelongsTo.new post_config, :user, optional: true
+    expect(belongs_to).to be_optional
+  end
+
+  describe "controller" do
+    let(:controller) { post_config.controller.new }
+    let(:http_params) { {user_id: user.id} }
+    let(:user) { User.create! }
+
+    before do
+      request = double 'Request', format: 'application/json'
+      allow(controller).to receive(:params) { ActionController::Parameters.new(http_params) }
+      allow(controller).to receive(:request){ request }
+    end
+
+    it 'should be able to access the collection' do
+      expect(controller.send :collection).to be_a ActiveRecord::Relation
+
+    end
+    it 'should be able to build a new resource' do
+      expect(controller.send :build_resource).to be_a Post
+    end
+  end
+end

data/spec/unit/cancan_adapter_spec.rb

@@ -0,0 +1,43 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::CanCanAdapter do
+
+  describe "full integration" do
+
+    let(:application){ ActiveAdmin::Application.new }
+    let(:namespace){ ActiveAdmin::Namespace.new(application, "Admin") }
+    let(:resource){ namespace.register(Post) }
+
+    let :ability_class do
+      Class.new do
+        include CanCan::Ability
+
+        def initialize(user)
+          can :read, Post
+          cannot :update, Post
+        end
+
+      end
+    end
+
+    let(:auth) { namespace.authorization_adapter.new(resource, double) }
+
+    before do
+      namespace.authorization_adapter = ActiveAdmin::CanCanAdapter
+      namespace.cancan_ability_class = ability_class
+    end
+
+    it "should initialize the ability stored in the namespace configuration" do
+      expect(auth.authorized?(:read, Post)).to eq true
+      expect(auth.authorized?(:update, Post)).to eq false
+    end
+
+    it "should scope the collection with accessible_by" do
+      collection = double
+      expect(collection).to receive(:accessible_by).with(auth.cancan_ability, :edit)
+      auth.scope_collection(collection, :edit)
+    end
+
+  end
+
+end

data/spec/unit/comments_spec.rb

@@ -0,0 +1,189 @@
+require 'rails_helper'
+
+RSpec.describe "Comments" do
+  let(:application) { ActiveAdmin::Application.new }
+
+  describe ActiveAdmin::Comment do
+    let(:comment){ ActiveAdmin::Comment.new }
+
+    let(:user) { User.create!(first_name: "John", last_name: "Doe") }
+
+    it "has valid Associations and Validations" do
+      expect(comment).to belong_to :resource
+      expect(comment).to belong_to :author
+      expect(comment).to validate_presence_of :resource
+      expect(comment).to validate_presence_of :body
+      expect(comment).to validate_presence_of :namespace
+    end
+
+    it "needs a resource" do
+      expect(comment).to_not be_valid
+      expect(comment.errors[:resource]).to eq(["can't be blank"])
+    end
+
+    describe ".find_for_resource_in_namespace" do
+      let(:post) { Post.create!(title: "Hello World") }
+      let(:namespace_name) { "admin" }
+
+      before do
+        @comment = ActiveAdmin::Comment.create! author: user,
+                                                resource: post,
+                                                body: "A Comment",
+                                                namespace: namespace_name
+      end
+
+      it "should return a comment for the resource in the same namespace" do
+        expect(ActiveAdmin::Comment.find_for_resource_in_namespace(post, namespace_name)).to eq [@comment]
+      end
+
+      it "should not return a comment for the same resource in a different namespace" do
+        ActiveAdmin.application.namespaces[:public] = ActiveAdmin.application.namespaces[:admin]
+        expect(ActiveAdmin::Comment.find_for_resource_in_namespace(post, 'public')).to eq []
+        ActiveAdmin.application.namespaces.instance_variable_get(:@namespaces).delete(:public)
+      end
+
+      it "should not return a comment for a different resource" do
+        another_post = Post.create! title: "Another Hello World"
+        expect(ActiveAdmin::Comment.find_for_resource_in_namespace(another_post, namespace_name)).to eq []
+      end
+
+      it "should return the most recent comment first by default" do
+        another_comment = ActiveAdmin::Comment.create! author: user,
+                                                       resource: post,
+                                                       body: "Another Comment",
+                                                       namespace: namespace_name,
+                                                       created_at: @comment.created_at + 20.minutes
+
+        yet_another_comment = ActiveAdmin::Comment.create! author: user,
+                                                           resource: post,
+                                                           body: "Yet Another Comment",
+                                                           namespace: namespace_name,
+                                                           created_at: @comment.created_at + 10.minutes
+
+        comments = ActiveAdmin::Comment.find_for_resource_in_namespace(post, namespace_name)
+        expect(comments.size).to eq 3
+        expect(comments.first).to eq(@comment)
+        expect(comments.second).to eq(yet_another_comment)
+        expect(comments.last).to eq(another_comment)
+      end
+
+      context "when custom ordering configured" do
+        around do |example|
+          previous_order = ActiveAdmin.application.comments_order
+          ActiveAdmin.application.comments_order = "created_at DESC"
+
+          example.call
+
+          ActiveAdmin.application.comments_order = previous_order
+        end
+
+        it "should return the correctly ordered comments" do
+          another_comment = ActiveAdmin::Comment.create!(
+            author: user,
+            resource: post,
+            body: "Another Comment",
+            namespace: namespace_name,
+            created_at: @comment.created_at + 20.minutes
+          )
+
+          comments = ActiveAdmin::Comment.find_for_resource_in_namespace(
+            post, namespace_name
+          )
+          expect(comments.size).to eq 2
+          expect(comments.first).to eq(another_comment)
+          expect(comments.last).to eq(@comment)
+        end
+      end
+    end
+
+    describe ".resource_type" do
+      let(:post) { Post.create!(title: "Testing.") }
+      let(:post_decorator) { double 'PostDecorator' }
+
+      before do
+        allow(post_decorator).to receive(:model).and_return(post)
+        allow(post_decorator).to receive(:decorated?).and_return(true)
+      end
+
+      context "when a decorated object is passed" do
+        let(:resource) { post_decorator }
+
+        it "returns undeorated object class string" do
+          expect(ActiveAdmin::Comment.resource_type resource).to eql 'Post'
+        end
+      end
+
+      context "when an undecorated object is passed" do
+        let(:resource) { post }
+
+        it "returns object class string" do
+          expect(ActiveAdmin::Comment.resource_type resource).to eql 'Post'
+        end
+      end
+    end
+
+    describe "Commenting on resource with string id" do
+      let(:tag) { Tag.create!(name: "cooltags") }
+      let(:namespace_name) { "admin" }
+
+      it "should allow commenting" do
+        comment = ActiveAdmin::Comment.create!(
+          author: user,
+          resource: tag,
+          body: "Another Comment",
+          namespace: namespace_name)
+
+        expect(ActiveAdmin::Comment.find_for_resource_in_namespace(tag, namespace_name)).to eq [comment]
+      end
+    end
+
+    describe "commenting on child of STI resource" do
+      let(:publisher) { Publisher.create!(username: "tenderlove") }
+      let(:namespace_name) { "admin" }
+
+      it "should assign child class as commented resource" do
+        comment = ActiveAdmin::Comment.create!(
+          author: user,
+          resource: publisher,
+          body: "Lorem Ipsum",
+          namespace: namespace_name)
+
+        expect(ActiveAdmin::Comment.find_for_resource_in_namespace(publisher, namespace_name).last.resource_type).
+          to eq("User")
+      end
+    end
+  end
+
+  describe ActiveAdmin::Comments::NamespaceHelper do
+    describe "#comments?" do
+
+      it "should have comments when the namespace allows comments" do
+        ns = ActiveAdmin::Namespace.new(application, :admin)
+        ns.comments = true
+        expect(ns.comments?).to eq true
+      end
+
+      it "should not have comments when the namespace does not allow comments" do
+        ns = ActiveAdmin::Namespace.new(application, :admin)
+        ns.comments = false
+        expect(ns.comments?).to eq false
+      end
+    end
+  end
+
+  describe ActiveAdmin::Comments::ResourceHelper do
+    it "should add an attr_accessor :comments to ActiveAdmin::Resource" do
+      ns = ActiveAdmin::Namespace.new(application, :admin)
+      resource = ActiveAdmin::Resource.new(ns, Post)
+      expect(resource.comments).to eq nil
+      resource.comments = true
+      expect(resource.comments).to eq true
+    end
+    it "should disable comments if set to false" do
+      ns = ActiveAdmin::Namespace.new(application, :admin)
+      resource = ActiveAdmin::Resource.new(ns, Post)
+      resource.comments = false
+      expect(resource.comments?).to eq false
+    end
+  end
+end

data/spec/unit/component_spec.rb

@@ -0,0 +1,18 @@
+require 'rails_helper'
+
+class MockComponentClass < ActiveAdmin::Component; end
+
+RSpec.describe ActiveAdmin::Component do
+
+  let(:component_class){ MockComponentClass }
+  let(:component){ component_class.new }
+
+  it "should be a subclass of an html div" do
+    expect(ActiveAdmin::Component.ancestors).to include(Arbre::HTML::Div)
+  end
+
+  it "should render to a div, even as a subclass" do
+    expect(component.tag_name).to eq 'div'
+  end
+
+end

data/spec/unit/config_shared_examples.rb

@@ -0,0 +1,59 @@
+RSpec.shared_examples_for "ActiveAdmin::Resource" do
+  describe "namespace" do
+    it "should return the namespace" do
+      expect(config.namespace).to eq(namespace)
+    end
+  end
+
+  describe "page_presenters" do
+    it "should return an empty hash by default" do
+      expect(config.page_presenters).to eq({})
+    end
+  end
+
+  it { respond_to :controller_name }
+  it { respond_to :controller }
+  it { respond_to :route_prefix }
+  it { respond_to :route_collection_path }
+  it { respond_to :comments? }
+  it { respond_to :belongs_to? }
+  it { respond_to :action_items? }
+  it { respond_to :sidebar_sections? }
+
+  describe "Naming" do
+    it "implements #resource_label" do
+      expect { config.resource_label }.to_not raise_error
+    end
+
+    it "implements #plural_resource_label" do
+      expect { config.plural_resource_label }.to_not raise_error
+    end
+  end
+
+  describe "Menu" do
+    describe "#menu_item_options" do
+
+      it "initializes a new menu item with defaults" do
+        expect(config.menu_item_options[:label].call).to eq(config.plural_resource_label)
+      end
+
+      it "initialize a new menu item with custom options" do
+        config.menu_item_options = { label: "Hello" }
+        expect(config.menu_item_options[:label]).to eq("Hello")
+      end
+
+    end
+
+    describe "#include_in_menu?" do
+      it "should be included in menu by default" do
+        expect(config.include_in_menu?).to eq(true)
+      end
+
+      it "should not be included in menu when menu set to false" do
+        config.menu_item_options = false
+        expect(config.include_in_menu?).to eq(false)
+      end
+    end
+
+  end
+end

data/spec/unit/controller_filters_spec.rb

@@ -0,0 +1,41 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::Application do
+  let(:application){ ActiveAdmin::Application.new }
+  let(:controllers){ application.controllers_for_filters }
+
+  it 'controllers_for_filters' do
+    expect(application.controllers_for_filters).to eq [
+      ActiveAdmin::BaseController, ActiveAdmin::Devise::SessionsController,
+      ActiveAdmin::Devise::PasswordsController, ActiveAdmin::Devise::UnlocksController,
+      ActiveAdmin::Devise::RegistrationsController, ActiveAdmin::Devise::ConfirmationsController
+    ]
+  end
+
+  expected_actions = (
+    prefixes = %w(skip append prepend) << nil
+    positions = %w(before around after)
+    suffixes = %w(action)
+    base = %w()
+    if ActiveAdmin::Dependency.rails? '< 5.1.x'
+      suffixes += %w(filter)
+      base += %w(skip_filter skip_action_callback)
+    end
+
+    prefixes.each_with_object(base) do |prefix, stack|
+      positions.each do |position|
+        suffixes.each do |suffix|
+          stack << [prefix, position, suffix].compact.join("_").to_sym
+        end
+      end
+    end
+  )
+
+  expected_actions.each do |action|
+    it action do
+      args = [:my_filter, { only: :show }]
+      controllers.each { |c| expect(c).to receive(action).with(args) }
+      application.public_send action, args
+    end
+  end
+end

data/spec/unit/csv_builder_spec.rb

@@ -0,0 +1,313 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::CSVBuilder do
+
+  describe '.default_for_resource using Post' do
+    let(:application){ ActiveAdmin::Application.new }
+    let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
+    let(:resource){ ActiveAdmin::Resource.new(namespace, Post, {}) }
+    let(:csv_builder) { ActiveAdmin::CSVBuilder.default_for_resource(resource).tap(&:exec_columns) }
+
+    it 'returns a default csv_builder for Post' do
+      expect(csv_builder).to be_a(ActiveAdmin::CSVBuilder)
+    end
+
+    it 'defines Id as the first column' do
+      expect(csv_builder.columns.first.name).to eq 'Id'
+      expect(csv_builder.columns.first.data).to eq :id
+    end
+
+    it "has Post's content_columns" do
+      csv_builder.columns[1..-1].each_with_index do |column, index|
+        expect(column.name).to eq resource.content_columns[index].to_s.humanize
+        expect(column.data).to eq resource.content_columns[index]
+      end
+    end
+
+    context 'when column has a localized name' do
+      let(:localized_name) { 'Titulo' }
+
+      before do
+        allow(Post).to receive(:human_attribute_name).and_call_original
+        allow(Post).to receive(:human_attribute_name).with(:title){ localized_name }
+      end
+
+      it 'gets name from I18n' do
+        title_index =  resource.content_columns.index(:title) + 1 # First col is always id
+        expect(csv_builder.columns[title_index].name).to eq localized_name
+      end
+    end
+  end
+
+  context 'when empty' do
+    let(:builder){ ActiveAdmin::CSVBuilder.new.tap(&:exec_columns) }
+
+    it "should have no columns" do
+      expect(builder.columns).to eq []
+    end
+  end
+
+  context "with a symbol column (:title)" do
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new do
+        column :title
+      end.tap(&:exec_columns)
+    end
+
+    it "should have one column" do
+      expect(builder.columns.size).to eq 1
+    end
+
+    describe "the column" do
+      let(:column){ builder.columns.first }
+
+      it "should have a name of 'Title'" do
+        expect(column.name).to eq "Title"
+      end
+
+      it "should have the data :title" do
+        expect(column.data).to eq :title
+      end
+    end
+  end
+
+  context "with a block and title" do
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new do
+        column "My title" do
+          # nothing
+        end
+      end.tap(&:exec_columns)
+    end
+
+    it "should have one column" do
+      expect(builder.columns.size).to eq 1
+    end
+
+    describe "the column" do
+      let(:column){ builder.columns.first }
+
+      it "should have a name of 'My title'" do
+        expect(column.name).to eq "My title"
+      end
+
+      it "should have the data :title" do
+        expect(column.data).to be_an_instance_of(Proc)
+      end
+    end
+  end
+
+  context "with a humanize_name column option" do
+    context "with symbol column name" do
+      let(:builder) do
+        ActiveAdmin::CSVBuilder.new do
+          column :my_title, humanize_name: false
+        end.tap(&:exec_columns)
+      end
+
+      describe "the column" do
+        let(:column){ builder.columns.first }
+
+        it "should have a name of 'my_title'" do
+          expect(column.name).to eq "my_title"
+        end
+      end
+    end
+
+    context "with string column name" do
+      let(:builder) do
+        ActiveAdmin::CSVBuilder.new do
+          column "my_title", humanize_name: false
+        end.tap(&:exec_columns)
+      end
+
+      describe "the column" do
+        let(:column){ builder.columns.first }
+
+        it "should have a name of 'my_title'" do
+          expect(column.name).to eq "my_title"
+        end
+      end
+    end
+  end
+
+  context "with a separator" do
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new(col_sep: ";").tap(&:exec_columns)
+    end
+
+    it "should have proper separator" do
+      expect(builder.options).to eq({col_sep: ";"})
+    end
+  end
+
+  context "with humanize_name option" do
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new(humanize_name: false) do
+        column :my_title
+      end.tap(&:exec_columns)
+    end
+
+    describe "the column" do
+      let(:column){ builder.columns.first }
+
+      it "should have humanize_name option set" do
+        expect(column.options).to eq humanize_name: false
+      end
+
+      it "should have a name of 'my_title'" do
+        expect(column.name).to eq "my_title"
+      end
+    end
+  end
+
+  context "with csv_options" do
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new(force_quotes: true).tap(&:exec_columns)
+    end
+
+    it "should have proper separator" do
+      expect(builder.options).to eq({force_quotes: true})
+    end
+  end
+
+  context "with access to the controller" do
+    let(:dummy_view_context) { double(controller: dummy_controller) }
+    let(:dummy_controller) { double(names: %w(title summary updated_at created_at))}
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new do
+        column "id"
+        controller.names.each do |name|
+          column(name)
+        end
+      end.tap{ |b| b.exec_columns(dummy_view_context) }
+    end
+
+    it "should build columns provided by the controller" do
+      expect(builder.columns.map(&:data)).to match_array([:id, :title, :summary, :updated_at, :created_at])
+    end
+  end
+
+  context "build csv using the supplied order" do
+    before do
+      @post1 = Post.create!(title: "Hello1", published_date: Date.today - 2.day)
+      @post2 = Post.create!(title: "Hello2", published_date: Date.today - 1.day)
+    end
+    let(:dummy_controller) {
+      class DummyController
+        def find_collection(*)
+          collection
+        end
+
+        def collection
+          Post.order('published_date DESC')
+        end
+
+        def apply_decorator(resource)
+          resource
+        end
+
+        def view_context
+        end
+      end
+      DummyController.new
+    }
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new do
+        column "id"
+        column "title"
+        column "published_date"
+      end
+    end
+
+    it "should generate data with the supplied order" do
+      expect(builder).to receive(:build_row).and_return([]).once.ordered { |post| expect(post.id).to eq @post2.id }
+      expect(builder).to receive(:build_row).and_return([]).once.ordered { |post| expect(post.id).to eq @post1.id }
+      builder.build dummy_controller, []
+    end
+
+    it "should generate data ignoring pagination" do
+      expect(dummy_controller).to receive(:find_collection).
+        with(except: :pagination).once.
+        and_call_original
+      expect(builder).to receive(:build_row).and_return([]).twice
+      builder.build dummy_controller, []
+    end
+
+    it "should disable the ActiveRecord query cache" do
+      expect(builder).to receive(:build_row).twice do
+        expect(ActiveRecord::Base.connection.query_cache_enabled).to be_falsy
+        []
+      end
+      ActiveRecord::Base.cache do
+        builder.build dummy_controller, []
+      end
+    end
+  end
+
+  context "build csv using specified encoding and encoding_options" do
+    let(:dummy_controller) do
+      class DummyController
+        def find_collection(*)
+          collection
+        end
+
+        def collection
+          Post
+        end
+
+        def apply_decorator(resource)
+          resource
+        end
+
+        def view_context
+        end
+      end
+      DummyController.new
+    end
+    let(:encoding) { Encoding::ASCII }
+    let(:opts) { {} }
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new(encoding: encoding, encoding_options: opts) do
+        column "おはようございます"
+        column "title"
+      end
+    end
+
+    context "Shift-JIS with options" do
+      let(:encoding) { Encoding::Shift_JIS }
+      let(:opts) { { invalid: :replace, undef: :replace, replace: "?" } }
+
+      it "encodes the CSV" do
+        receiver = []
+        builder.build dummy_controller, receiver
+        line = receiver.last
+        expect(line.encoding).to eq(encoding)
+      end
+    end
+
+    context "ASCII with options" do
+      let(:encoding) { Encoding::ASCII }
+      let(:opts) do
+        { invalid: :replace, undef: :replace, replace: "__REPLACED__" }
+      end
+
+      it "encodes the CSV without errors" do
+        receiver = []
+        builder.build dummy_controller, receiver
+        line = receiver.last
+        expect(line.encoding).to eq(encoding)
+        expect(line).to include("__REPLACED__")
+      end
+    end
+  end
+
+  skip '#exec_columns'
+
+  skip '#build_row' do
+    it 'renders non-strings'
+    it 'encodes values correctly'
+    it 'passes custom encoding options to String#encode!'
+  end
+
+end