activeadmin-rb 1.4.0

data/spec/unit/resource_controller/decorators_spec.rb

@@ -0,0 +1,94 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::ResourceController::Decorators do
+  let(:controller_class) do
+    Class.new do
+      def self.name
+        "Test Controller using Decorators"
+      end
+
+      include ActiveAdmin::ResourceController::Decorators
+
+      public :apply_decorator, :apply_collection_decorator
+    end
+  end
+
+  let(:controller) { controller_class.new }
+  let(:active_admin_config) { double(decorator_class: decorator_class) }
+  before do
+    allow(controller).to receive(:active_admin_config).and_return(active_admin_config)
+    allow(controller).to receive(:action_name).and_return(action)
+  end
+
+  describe '#apply_decorator' do
+    let(:action) { 'show' }
+    let(:resource) { Post.new }
+    subject(:applied) { controller.apply_decorator(resource) }
+
+    context 'with a decorator configured' do
+      let(:decorator_class) { PostDecorator }
+      it { is_expected.to be_kind_of(PostDecorator) }
+
+      context 'with form' do
+        let(:action) { 'update' }
+
+        it "does not decorate when :decorate is set to false" do
+          form = double
+          allow(form).to receive(:options).and_return(decorate: false)
+          allow(active_admin_config).to receive(:get_page_presenter).and_return(form)
+          is_expected.not_to be_kind_of(PostDecorator)
+        end
+      end
+    end
+
+    context 'with no decorator configured' do
+      let(:decorator_class) { nil }
+      it { is_expected.to be_kind_of(Post) }
+    end
+  end
+
+  describe '#apply_collection_decorator' do
+    before { Post.create! }
+    let(:action) { 'index' }
+    let(:collection) { Post.where nil }
+    subject(:applied) { controller.apply_collection_decorator(collection) }
+
+    context 'when a decorator is configured' do
+      context 'and it is using a recent version of draper' do
+        let(:decorator_class) { PostDecorator }
+
+        it 'calling certain scope collections work' do
+          # This is an example of one of the methods that was consistently
+          # failing before this feature existed
+          expect(applied.reorder('').count).to eq applied.count
+        end
+
+        it 'has a good description for the generated class' do
+          expect(applied.class.name).to eq "Draper::CollectionDecorator of PostDecorator + ActiveAdmin"
+        end
+
+      end
+    end
+  end
+
+  describe 'form actions' do
+    let(:action) { 'edit' }
+    let(:resource) { Post.new }
+    let(:form_presenter) { double options: { decorate: decorate_form } }
+    let(:decorator_class) { PostDecorator }
+    before { allow(active_admin_config).to receive(:get_page_presenter).with(:form).and_return form_presenter }
+
+    subject(:applied) { controller.apply_decorator(resource) }
+
+    context 'when the form is not configured to decorate' do
+      let(:decorate_form) { false }
+      it { is_expected.to be_kind_of(Post) }
+    end
+
+    context 'when the form is configured to decorate' do
+      let(:decorate_form) { true }
+      it { is_expected.to be_kind_of(PostDecorator) }
+    end
+
+  end
+end

data/spec/unit/resource_controller/sidebars_spec.rb

@@ -0,0 +1,37 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::ResourceController::Sidebars, type: :controller do
+  let(:klass){ Admin::PostsController }
+
+  shared_context 'with post config' do
+    before do
+      load_resources { post_config }
+
+      @controller = klass.new
+
+      get :index
+    end
+  end
+
+  context 'without skip_sidebar! before filter' do
+    include_context 'with post config' do
+      let(:post_config) { ActiveAdmin.register Post }
+    end
+
+    it 'does not set @skip_sidebar' do
+      expect(controller.instance_variable_get(:@skip_sidebar)).to eq nil
+    end
+  end
+
+  context 'with skip_sidebar! before_action' do
+    include_context 'with post config' do
+      let(:post_config) do
+        ActiveAdmin.register(Post) { before_action :skip_sidebar! }
+      end
+    end
+
+    it 'works' do
+      expect(controller.instance_variable_get(:@skip_sidebar)).to eq true
+    end
+  end
+end

data/spec/unit/resource_controller_spec.rb

@@ -0,0 +1,273 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::ResourceController do
+
+  let(:controller) { Admin::PostsController.new }
+
+  describe "callbacks" do
+    before :all do
+      application = ::ActiveAdmin::Application.new
+      namespace = ActiveAdmin::Namespace.new(application, :admin)
+      namespace.register Post do
+        after_build :call_after_build
+        before_save :call_before_save
+        after_save :call_after_save
+        before_create :call_before_create
+        after_create :call_after_create
+        before_update :call_before_update
+        after_update :call_after_update
+        before_destroy :call_before_destroy
+        after_destroy :call_after_destroy
+
+        controller do
+          def call_after_build(obj); end
+          def call_before_save(obj); end
+          def call_after_save(obj); end
+          def call_before_create(obj); end
+          def call_after_create(obj); end
+          def call_before_update(obj); end
+          def call_after_update(obj); end
+          def call_before_destroy(obj); end
+          def call_after_destroy(obj); end
+        end
+      end
+    end
+
+    describe "performing create" do
+      let(:resource){ double("Resource", save: true) }
+
+      before do
+        expect(resource).to receive(:save)
+      end
+
+      it "should call the before create callback" do
+        expect(controller).to receive(:call_before_create).with(resource)
+        controller.send :create_resource, resource
+      end
+      it "should call the before save callback" do
+        expect(controller).to receive(:call_before_save).with(resource)
+        controller.send :create_resource, resource
+      end
+      it "should call the after save callback" do
+        expect(controller).to receive(:call_after_save).with(resource)
+        controller.send :create_resource, resource
+      end
+      it "should call the after create callback" do
+        expect(controller).to receive(:call_after_create).with(resource)
+        controller.send :create_resource, resource
+      end
+    end
+
+    describe "performing update" do
+      let(:resource){ double("Resource", :attributes= => true, save: true) }
+      let(:attributes){ [{}] }
+
+      before do
+        expect(resource).to receive(:attributes=).with(attributes[0])
+        expect(resource).to receive(:save)
+      end
+
+      it "should call the before update callback" do
+        expect(controller).to receive(:call_before_update).with(resource)
+        controller.send :update_resource, resource, attributes
+      end
+      it "should call the before save callback" do
+        expect(controller).to receive(:call_before_save).with(resource)
+        controller.send :update_resource, resource, attributes
+      end
+      it "should call the after save callback" do
+        expect(controller).to receive(:call_after_save).with(resource)
+        controller.send :update_resource, resource, attributes
+      end
+      it "should call the after create callback" do
+        expect(controller).to receive(:call_after_update).with(resource)
+        controller.send :update_resource, resource, attributes
+      end
+    end
+
+    describe "performing destroy" do
+      let(:resource){ double("Resource", destroy: true) }
+
+      before do
+        expect(resource).to receive(:destroy)
+      end
+
+      it "should call the before destroy callback" do
+        expect(controller).to receive(:call_before_destroy).with(resource)
+        controller.send :destroy_resource, resource
+      end
+
+      it "should call the after destroy callback" do
+        expect(controller).to receive(:call_after_destroy).with(resource)
+        controller.send :destroy_resource, resource
+      end
+    end
+  end
+end
+
+RSpec.describe "A specific resource controller", type: :controller do
+  before do
+    load_resources { ActiveAdmin.register Post }
+
+    @controller = Admin::PostsController.new
+  end
+
+  describe "authenticating the user" do
+    it "should do nothing when no authentication_method set" do
+      namespace = controller.class.active_admin_config.namespace
+      expect(namespace).to receive(:authentication_method).once.and_return(nil)
+
+      controller.send(:authenticate_active_admin_user)
+    end
+
+    it "should call the authentication_method when set" do
+      namespace = controller.class.active_admin_config.namespace
+
+      expect(namespace).to receive(:authentication_method).twice.
+        and_return(:authenticate_admin_user!)
+
+      expect(controller).to receive(:authenticate_admin_user!).and_return(true)
+
+      controller.send(:authenticate_active_admin_user)
+    end
+
+  end
+
+  describe "retrieving the current user" do
+    it "should return nil when no current_user_method set" do
+      namespace = controller.class.active_admin_config.namespace
+      expect(namespace).to receive(:current_user_method).once.and_return(nil)
+
+      expect(controller.send(:current_active_admin_user)).to eq nil
+    end
+
+    it "should call the current_user_method when set" do
+      user = double
+      namespace = controller.class.active_admin_config.namespace
+
+      expect(namespace).to receive(:current_user_method).twice.
+        and_return(:current_admin_user)
+
+      expect(controller).to receive(:current_admin_user).and_return(user)
+
+      expect(controller.send(:current_active_admin_user)).to eq user
+    end
+  end
+
+  describe 'retrieving the resource' do
+    let(:post) { Post.new title: "An incledibly unique Post Title" }
+    let(:http_params){ { id: '1' } }
+
+    before do
+      allow(Post).to receive(:find).and_return(post)
+      controller.class_eval { public :resource }
+      allow(controller).to receive(:params).and_return(ActionController::Parameters.new(http_params))
+    end
+
+    subject { controller.resource }
+
+    it "returns a Post" do
+      expect(subject).to be_kind_of(Post)
+    end
+
+    context 'with a decorator' do
+      let(:config) { controller.class.active_admin_config }
+      before { config.decorator_class_name = '::PostDecorator' }
+      it 'returns a PostDecorator' do
+        expect(subject).to be_kind_of(PostDecorator)
+      end
+
+      it 'returns a PostDecorator that wraps the post' do
+        expect(subject.title).to eq post.title
+      end
+    end
+  end
+
+  describe 'retrieving the resource collection' do
+    let(:config) { controller.class.active_admin_config }
+    before do
+      Post.create!(title: "An incledibly unique Post Title")
+      config.decorator_class_name = nil
+      request = double 'Request', format: 'application/json'
+      allow(controller).to receive(:params) { {} }
+      allow(controller).to receive(:request){ request }
+    end
+
+    subject { controller.send :collection }
+
+    it {
+      is_expected.to be_a ActiveRecord::Relation
+    }
+
+    it "returns a collection of posts" do
+      expect(subject.first).to be_kind_of(Post)
+    end
+
+    context 'with a decorator' do
+      before { config.decorator_class_name = 'PostDecorator' }
+
+      it 'returns a collection decorator using PostDecorator' do
+        expect(subject).to be_a Draper::CollectionDecorator
+        expect(subject.decorator_class).to eq PostDecorator
+      end
+
+      it 'returns a collection decorator that wraps the post' do
+        expect(subject.first.title).to eq Post.first.title
+      end
+    end
+  end
+
+  describe "performing batch_action" do
+    let(:batch_action) { ActiveAdmin::BatchAction.new :flag, "Flag", &batch_action_block }
+    let(:batch_action_block) { proc { self.instance_variable_set :@block_context, self.class } }
+    let(:params) { ActionController::Parameters.new(http_params) }
+
+    before do
+      allow(controller.class.active_admin_config).to receive(:batch_actions).and_return([batch_action])
+      allow(controller).to receive(:params) { params }
+    end
+
+    describe "when params batch_action matches existing BatchAction" do
+
+      let(:http_params) do
+        { batch_action: "flag", collection_selection: ["1"] }
+      end
+
+      it "should call the block with args" do
+        expect(controller).to receive(:instance_exec).with(["1"], {})
+        controller.batch_action
+      end
+
+      it "should call the block in controller scope" do
+        controller.batch_action
+        expect(controller.instance_variable_get(:@block_context)).to eq Admin::PostsController
+      end
+    end
+
+    describe "when params batch_action doesn't match a BatchAction" do
+      let(:http_params) do
+        { batch_action: "derp", collection_selection: ["1"] }
+      end
+
+      it "should raise an error" do
+        expect {
+          controller.batch_action
+        }.to raise_error("Couldn't find batch action \"derp\"")
+      end
+    end
+
+    describe "when params batch_action is blank" do
+      let(:http_params) do
+        { collection_selection: ["1"] }
+      end
+
+      it "should raise an error" do
+        expect {
+          controller.batch_action
+        }.to raise_error("Couldn't find batch action \"\"")
+      end
+    end
+
+  end
+
+end

data/spec/unit/resource_registration_spec.rb

@@ -0,0 +1,61 @@
+require 'rails_helper'
+
+RSpec.describe "Registering an object to administer" do
+  let(:application) { ActiveAdmin::Application.new }
+
+  context "with no configuration" do
+    let(:namespace) { ActiveAdmin::Namespace.new(application, :admin) }
+
+    before do
+      application.namespaces[namespace.name] = namespace
+    end
+
+    it "should call register on the namespace" do
+      expect(namespace).to receive(:register)
+
+      application.register Category
+    end
+
+    it "should dispatch a Resource::RegisterEvent" do
+      expect(ActiveSupport::Notifications).to receive(:publish).with(ActiveAdmin::Resource::RegisterEvent, an_instance_of(ActiveAdmin::Resource))
+
+      application.register Category
+    end
+  end
+
+  context "with a different namespace" do
+    it "should call register on the namespace" do
+      namespace = ActiveAdmin::Namespace.new(application, :hello_world)
+      application.namespaces[namespace.name] = namespace
+      expect(namespace).to receive(:register)
+
+      application.register Category, namespace: :hello_world
+    end
+
+    it "should generate a Namespace::RegisterEvent and a Resource::RegisterEvent" do
+      expect(ActiveSupport::Notifications).to receive(:publish).with(ActiveAdmin::Namespace::RegisterEvent, an_instance_of(ActiveAdmin::Namespace))
+      expect(ActiveSupport::Notifications).to receive(:publish).with(ActiveAdmin::Resource::RegisterEvent, an_instance_of(ActiveAdmin::Resource))
+      application.register Category, namespace: :not_yet_created
+    end
+  end
+
+  context "with no namespace" do
+    it "should call register on the root namespace" do
+      namespace = ActiveAdmin::Namespace.new(application, :root)
+      application.namespaces[namespace.name] = namespace
+      expect(namespace).to receive(:register)
+
+      application.register Category, namespace: false
+    end
+  end
+
+  context "when being registered multiple times" do
+    it "should run the dsl in the same config object" do
+      config_1 = ActiveAdmin.register(Category) { filter :name }
+      config_2 = ActiveAdmin.register(Category) { filter :id }
+      expect(config_1).to eq config_2
+      expect(config_1.filters.size).to eq 2
+    end
+  end
+
+end