activeadmin-rb 1.4.0

data/spec/unit/generators/install_spec.rb

@@ -0,0 +1,31 @@
+require 'rails_helper'
+
+RSpec.describe "AA installation" do
+  context "should create" do
+
+    it "active_admin.scss" do
+      path = Rails.root + "app/assets/stylesheets/active_admin.scss"
+
+      expect(File.exist?(path)).to eq true
+    end
+
+    it "active_admin.js.coffee" do
+      path = Rails.root + "app/assets/javascripts/active_admin.js.coffee"
+
+      expect(File.exist?(path)).to eq true
+    end
+
+    it "the dashboard" do
+      path = Rails.root + "app/admin/dashboard.rb"
+
+      expect(File.exist?(path)).to eq true
+    end
+
+    it "the initializer" do
+      path = Rails.root + "config/initializers/active_admin.rb"
+
+      expect(File.exist?(path)).to eq true
+    end
+
+  end
+end

data/spec/unit/helpers/collection_spec.rb

@@ -0,0 +1,68 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::Helpers::Collection do
+
+  include ActiveAdmin::Helpers::Collection
+
+  before do
+    Post.create!(title: "A post")
+    Post.create!(title: "A post")
+    Post.create!(title: "An other post")
+  end
+
+  describe "#collection_size" do
+    it "should return the collection size for an ActiveRecord class" do
+      expect(collection_size(Post.where(nil))).to eq 3
+    end
+
+    it "should return the collection size for an ActiveRecord::Relation" do
+      expect(collection_size(Post.where(title: "A post"))).to eq 2
+    end
+
+    it "should return the collection size for a collection with group by" do
+      expect(collection_size(Post.group(:title))).to eq 2
+    end
+
+    it "should return the collection size for a collection with group by, select and custom order" do
+      expect(collection_size(Post.select("title, count(*) as nb_posts").group(:title).order("nb_posts"))).to eq 2
+    end
+
+    it "should return the collection size for an Array" do
+      expect(collection_size(Post.where(title: "A post").to_a)).to eq 2
+    end
+
+    it "should take the defined collection by default" do
+      def collection; Post.where(nil); end
+
+      expect(collection_size).to eq 3
+
+      def collection; Post.where(title: "An other post"); end
+
+      expect(collection_size).to eq 1
+
+      def collection; Post.where(title: "A post").to_a end
+
+      expect(collection_size).to eq 2
+    end
+  end
+
+  describe "#collection_is_empty?" do
+    it "should return true when the collection is empty" do
+      expect(collection_is_empty?(Post.where(title: "Non existing post"))).to eq true
+    end
+
+    it "should return false when the collection is not empty" do
+      expect(collection_is_empty?(Post.where(title: "A post"))).to eq false
+    end
+
+    it "should take the defined collection by default" do
+      def collection; Post.where(nil); end
+
+      expect(collection_is_empty?).to eq false
+
+      def collection; Post.where(title: "Non existing post"); end
+
+      expect(collection_is_empty?).to eq true
+    end
+  end
+end

data/spec/unit/helpers/output_safety_helper_spec.rb

@@ -0,0 +1,79 @@
+require 'rails_helper'
+
+# Adapted from Rails 5 to support Rails 4.
+# https://github.com/rails/rails/blob/9c35bf2a6a27431c6aa283db781c19f61c5155be/actionview/test/template/output_safety_helper_test.rb
+RSpec.describe ActiveAdmin::OutputSafetyHelper, type: :view do
+  include described_class
+
+  before do
+    @string = "hello"
+  end
+
+  describe "to_sentence" do
+    it "escapes non-html_safe values" do
+      actual = to_sentence(%w(< > & ' "))
+      assert actual.html_safe?
+      assert_equal("&lt;, &gt;, &amp;, &#39;, and &quot;", actual)
+
+      actual = to_sentence(%w(<script>))
+      assert actual.html_safe?
+      assert_equal("&lt;script&gt;", actual)
+    end
+
+    it "does not double escape if single value is html_safe" do
+      assert_equal("&lt;script&gt;", to_sentence([ERB::Util.html_escape("<script>")]))
+      assert_equal("&lt;script&gt;", to_sentence(["&lt;script&gt;".html_safe]))
+      assert_equal("&amp;lt;script&amp;gt;", to_sentence(["&lt;script&gt;"]))
+    end
+
+    it "checks connector words for html safety" do
+      assert_equal "one & two, and three", to_sentence(["one", "two", "three"], words_connector: " & ".html_safe)
+      assert_equal "one & two", to_sentence(["one", "two"], two_words_connector: " & ".html_safe)
+      assert_equal "one, two &lt;script&gt;alert(1)&lt;/script&gt; three", to_sentence(["one", "two", "three"], last_word_connector: " <script>alert(1)</script> ")
+    end
+
+    it "does not escape html_safe values" do
+      ptag = content_tag("p") do
+        safe_join(["<marquee>shady stuff</marquee>", tag("br")])
+      end
+      url = "https://example.com"
+      expected = %(<a href="#{url}">#{url}</a> and <p>&lt;marquee&gt;shady stuff&lt;/marquee&gt;<br /></p>)
+      actual = to_sentence([link_to(url, url), ptag])
+      assert actual.html_safe?
+      assert_equal(expected, actual)
+    end
+
+    it "handles blank strings" do
+      actual = to_sentence(["", "two", "three"])
+      assert actual.html_safe?
+      assert_equal ", two, and three", actual
+    end
+
+    it "handles nil values" do
+      actual = to_sentence([nil, "two", "three"])
+      assert actual.html_safe?
+      assert_equal ", two, and three", actual
+    end
+
+    it "still supports ActiveSupports Array#to_sentence arguments" do
+      assert_equal "one two, and three", to_sentence(["one", "two", "three"], words_connector: " ")
+      assert_equal "one & two, and three", to_sentence(["one", "two", "three"], words_connector: " & ".html_safe)
+      assert_equal "onetwo, and three", to_sentence(["one", "two", "three"], words_connector: nil)
+      assert_equal "one, two, and also three", to_sentence(["one", "two", "three"], last_word_connector: ", and also ")
+      assert_equal "one, twothree", to_sentence(["one", "two", "three"], last_word_connector: nil)
+      assert_equal "one, two three", to_sentence(["one", "two", "three"], last_word_connector: " ")
+      assert_equal "one, two and three", to_sentence(["one", "two", "three"], last_word_connector: " and ")
+    end
+
+    it "is not affected by $," do
+      separator_was = $,
+      $, = "|"
+      begin
+        assert_equal "one and two", to_sentence(["one", "two"])
+        assert_equal "one, two, and three", to_sentence(["one", "two", "three"])
+      ensure
+        $, = separator_was
+      end
+    end
+  end
+end

data/spec/unit/helpers/scope_chain_spec.rb

@@ -0,0 +1,35 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::ScopeChain do
+
+  include ActiveAdmin::ScopeChain
+
+  describe "#scope_chain" do
+    let(:relation) { double }
+
+    context "when Scope has a scope method" do
+      let(:scope) { ActiveAdmin::Scope.new :published }
+
+      it "should call the method on the relation and return it" do
+        expect(relation).to receive(:published).and_return(:scoped_relation)
+        expect(scope_chain(scope, relation)).to eq :scoped_relation
+      end
+    end
+
+    context "when Scope has the scope method method ':all'" do
+      let(:scope) { ActiveAdmin::Scope.new :all }
+
+      it "should return the relation" do
+        expect(scope_chain(scope, relation)).to eq relation
+      end
+    end
+
+    context "when Scope has a name and a scope block" do
+      let(:scope) { ActiveAdmin::Scope.new("My Scope"){|s| :scoped_relation } }
+
+      it "should instance_exec the block and return it" do
+        expect(scope_chain(scope, relation)).to eq :scoped_relation
+      end
+    end
+  end
+end

data/spec/unit/i18n_spec.rb

@@ -0,0 +1,29 @@
+require 'rails_helper'
+require 'i18n/tasks'
+
+Dir.glob('config/locales/*.yml') do |locale_file|
+  RSpec.describe locale_file do
+    it { is_expected.to be_parseable }
+    it { is_expected.to have_one_top_level_namespace }
+    it { is_expected.to be_named_like_top_level_namespace }
+    it { is_expected.to_not have_legacy_interpolations }
+    it { is_expected.to have_a_valid_locale }
+    it { is_expected.to be_a_subset_of 'config/locales/en.yml' }
+  end
+end
+
+RSpec.describe 'I18n' do
+  let(:i18n) { I18n::Tasks::BaseTask.new }
+  let(:unused_keys) { i18n.unused_keys }
+
+  let(:failure_msg) do
+    <<-MSG.squish
+      #{unused_keys.leaves.count} unused i18n keys, run `i18n-tasks unused' to
+      show them
+    MSG
+  end
+
+  it 'does not have unused keys' do
+    expect(unused_keys).to be_empty, failure_msg
+  end
+end

data/spec/unit/localizers/resource_localizer_spec.rb

@@ -0,0 +1,36 @@
+require 'rails_helper'
+
+RSpec.shared_examples_for "ActiveAdmin::Localizers::ResourceLocalizer" do
+  it "should use proper translation" do
+    string = ActiveAdmin::Localizers::ResourceLocalizer.t(action, model: model, model_name: model_name)
+    expect(string).to eq translation
+  end
+
+  it "should accessible via ActiveAdmin::Localizers" do
+    resource = double(resource_label: model, resource_name: double(i18n_key: model_name))
+    localizer = ActiveAdmin::Localizers.resource(resource)
+    expect(localizer.t(action)).to eq translation
+  end
+end
+
+RSpec.describe ActiveAdmin::Localizers::ResourceLocalizer do
+  let(:action) { 'new_model' }
+  let(:model) { 'Comment' }
+  let(:model_name) { 'comment' }
+
+  it_behaves_like "ActiveAdmin::Localizers::ResourceLocalizer" do
+    let(:translation) { 'New Comment' }
+  end
+
+  describe "model action specified" do
+    around do |example|
+      with_translation active_admin: {resources: {comment: {new_model: 'Write comment'}}} do
+        example.call
+      end
+    end
+
+    it_behaves_like "ActiveAdmin::Localizers::ResourceLocalizer" do
+      let(:translation) { 'Write comment' }
+    end
+  end
+end

data/spec/unit/menu_collection_spec.rb

@@ -0,0 +1,62 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::MenuCollection do
+
+  let(:menus) { ActiveAdmin::MenuCollection.new }
+
+  describe "#add" do
+
+    it "should initialize a new menu when first item" do
+      menus.add :default, label: "Hello World"
+
+      expect(menus.fetch(:default).items.size).to eq 1
+      expect(menus.fetch(:default)["Hello World"]).to be_an_instance_of(ActiveAdmin::MenuItem)
+    end
+
+    it "should add items to an existing menu" do
+      menus.add :default, label: "Hello World"
+      menus.add :default, label: "Hello World Again"
+
+      expect(menus.fetch(:default).items.size).to eq 2
+    end
+
+  end
+
+  describe "#clear!" do
+
+    it "should remove all menus" do
+      menus.add :default, label: "Hello World"
+
+      menus.clear!
+
+      expect {
+        menus.fetch(:non_default_menu)
+      }.to raise_error(ActiveAdmin::NoMenuError)
+
+    end
+
+  end
+
+  describe "#on_build" do
+
+    it "runs a callback when fetching a menu" do
+      menus.on_build do |m|
+        m.add :default, label: "Hello World"
+      end
+
+      expect(menus.fetch(:default)["Hello World"]).to_not eq nil
+    end
+
+    it "re-runs the callbacks when the menu is cleared" do
+      menus.on_build do |m|
+        m.add :default, label: "Hello World"
+      end
+
+      expect(menus.fetch(:default)["Hello World"]).to_not eq nil
+      menus.clear!
+      expect(menus.fetch(:default)["Hello World"]).to_not eq nil
+    end
+
+  end
+
+end

data/spec/unit/menu_item_spec.rb

@@ -0,0 +1,82 @@
+require 'rails_helper'
+require 'active_admin/menu'
+require 'active_admin/menu_item'
+
+module ActiveAdmin
+  RSpec.describe MenuItem do
+
+    it "should have a label" do
+      item = MenuItem.new(label: "Dashboard")
+      expect(item.label).to eq "Dashboard"
+    end
+
+    it "should have a url" do
+      item = MenuItem.new(url: "/admin")
+      expect(item.url).to eq "/admin"
+    end
+
+    it "should have a priority of 10 by default" do
+      item = MenuItem.new
+      expect(item.priority).to eq 10
+    end
+
+    it "should default to an empty hash for html_options" do
+      item = MenuItem.new
+      expect(item.html_options).to be_empty
+    end
+
+    it "should accept an options hash for link_to" do
+      item = MenuItem.new html_options: { target: :blank }
+      expect(item.html_options).to include(target: :blank)
+    end
+
+    context "with no items" do
+      it "should be empty" do
+        item = MenuItem.new
+        expect(item.items).to be_empty
+      end
+
+      it "should accept new children" do
+        item = MenuItem.new label: "Dashboard"
+        item.add            label: "My Child Dashboard"
+        expect(item.items.first).to be_a MenuItem
+        expect(item.items.first.label).to eq "My Child Dashboard"
+      end
+    end
+
+    context "with many children" do
+      let(:item) do
+        i = MenuItem.new(label: "Dashboard")
+        i.add label: "Blog"
+        i.add label: "Cars"
+        i.add label: "Users", priority: 1
+        i.add label: "Settings", priority: 2
+        i.add label: "Analytics", priority: 44
+        i
+      end
+
+      it "should contain 5 submenu items" do
+        expect(item.items.count).to eq 5
+      end
+
+      it "should give access to the menu item as an array" do
+        expect(item['Blog'].label).to eq 'Blog'
+      end
+
+      it "children should hold a reference to their parent" do
+        expect(item["Blog"].parent).to eq item
+      end
+    end
+
+    describe "#id" do
+      it "should be normalized" do
+        expect(MenuItem.new(id: "Foo Bar").id).to eq "foo_bar"
+      end
+
+      it "should not accept Procs" do
+        expect{ MenuItem.new(id: proc{"Dynamic"}).id }.to raise_error TypeError
+      end
+    end
+
+  end
+end

data/spec/unit/menu_spec.rb

@@ -0,0 +1,60 @@
+require 'rails_helper'
+require 'active_admin/menu'
+require 'active_admin/menu_item'
+
+include ActiveAdmin
+
+RSpec.describe ActiveAdmin::Menu do
+
+  context "with no items" do
+    it "should have an empty item collection" do
+      menu = Menu.new
+      expect(menu.items).to be_empty
+    end
+
+    it "should accept new items" do
+      menu = Menu.new
+      menu.add label: "Dashboard"
+      expect(menu.items.first.label).to eq "Dashboard"
+    end
+  end
+
+  context "with many items" do
+    let(:menu) do
+      Menu.new do |m|
+        m.add label: "Dashboard"
+        m.add label: "Blog"
+      end
+    end
+
+    it "should give access to the menu item as an array" do
+      expect(menu['Dashboard'].label).to eq 'Dashboard'
+    end
+  end
+
+  describe "adding items with children" do
+    it "should add an empty item if the parent does not exist" do
+      menu = Menu.new
+      menu.add parent: "Admin", label: "Users"
+
+      expect(menu["Admin"]["Users"]).to be_an_instance_of(ActiveAdmin::MenuItem)
+    end
+
+    it "should add a child to a parent if it exists" do
+      menu = Menu.new
+      menu.add parent: "Admin", label: "Users"
+      menu.add parent: "Admin", label: "Projects"
+
+      expect(menu["Admin"]["Projects"]).to be_an_instance_of(ActiveAdmin::MenuItem)
+    end
+
+    it "should assign children regardless of resource file load order" do
+      menu = Menu.new
+      menu.add parent: "Users", label: "Posts"
+      menu.add label: "Users", url: "/some/url"
+
+      expect(menu["Users"].url).to eq "/some/url"
+      expect(menu["Users"]["Posts"]).to be_a ActiveAdmin::MenuItem
+    end
+  end
+end