active_interaction 3.8.3 → 4.0.0

data/spec/active_interaction/{modules/input_processor_spec.rb → inputs_spec.rb}

@@ -1,14 +1,13 @@
-# coding: utf-8
-
 require 'spec_helper'
 
-describe ActiveInteraction::InputProcessor do
+describe ActiveInteraction::Inputs do
+  subject(:inputs) { described_class.new }
+
   describe '.reserved?(name)' do
     it 'returns true for anything starting with "_interaction_"' do
       expect(described_class.reserved?('_interaction_')).to be_truthy
     end
 
-    # rubocop:disable Metrics/LineLength
     it 'returns true for existing instance methods' do
       (
         (ActiveInteraction::Base.instance_methods - Object.instance_methods) +
@@ -17,7 +16,6 @@ describe ActiveInteraction::InputProcessor do
         expect(described_class.reserved?(method)).to be_truthy
       end
     end
-    # rubocop:enable Metrics/LineLength
 
     it 'returns false for anything else' do
       expect(described_class.reserved?(SecureRandom.hex)).to be_falsey

data/spec/active_interaction/integration/array_interaction_spec.rb

@@ -1,29 +1,27 @@
-# coding: utf-8
-
 require 'spec_helper'
 require 'active_record'
-unless defined?(JRUBY_VERSION) # rubocop:disable Style/IfUnlessModifier
+if defined?(JRUBY_VERSION)
+  require 'activerecord-jdbcsqlite3-adapter'
+else
   require 'sqlite3'
 end
 
-unless defined?(JRUBY_VERSION)
-  ActiveRecord::Base.establish_connection(
-    adapter: 'sqlite3',
-    database: ':memory:'
-  )
+ActiveRecord::Base.establish_connection(
+  adapter: 'sqlite3',
+  database: ':memory:'
+)
 
-  ActiveRecord::Schema.define do
-    create_table(:lists)
-    create_table(:elements) { |t| t.column(:list_id, :integer) }
-  end
+ActiveRecord::Schema.define do
+  create_table(:lists)
+  create_table(:elements) { |t| t.column(:list_id, :integer) }
+end
 
-  class List < ActiveRecord::Base
-    has_many :elements
-  end
+class List < ActiveRecord::Base
+  has_many :elements
+end
 
-  class Element < ActiveRecord::Base
-    belongs_to :list
-  end
+class Element < ActiveRecord::Base
+  belongs_to :list
 end
 
 ArrayInteraction = Class.new(TestInteraction) do
@@ -38,10 +36,8 @@ end
 describe ArrayInteraction do
   include_context 'interactions'
   it_behaves_like 'an interaction', :array, -> { [] }
-  unless defined?(JRUBY_VERSION)
-    it_behaves_like 'an interaction', :array, -> { Element.where('1 = 1') }
-    it_behaves_like 'an interaction', :array, -> { List.create!.elements }
-  end
+  it_behaves_like 'an interaction', :array, -> { Element.where('1 = 1') }
+  it_behaves_like 'an interaction', :array, -> { List.create!.elements }
 
   context 'with inputs[:a]' do
     let(:a) { [[]] }

data/spec/active_interaction/integration/boolean_interaction_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe 'BooleanInteraction' do

data/spec/active_interaction/integration/date_interaction_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe 'DateInteraction' do

data/spec/active_interaction/integration/date_time_interaction_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe 'DateTimeInteraction' do

data/spec/active_interaction/integration/file_interaction_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 require 'action_dispatch'
 

data/spec/active_interaction/integration/float_interaction_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe 'FloatInteraction' do

data/spec/active_interaction/integration/hash_interaction_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 HashInteraction = Class.new(TestInteraction) do

data/spec/active_interaction/integration/integer_interaction_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe 'IntegerInteraction' do

data/spec/active_interaction/integration/interface_interaction_spec.rb

@@ -1,11 +1,9 @@
-# coding: utf-8
-
 require 'spec_helper'
 require 'json'
 require 'yaml'
 
 InterfaceInteraction = Class.new(TestInteraction) do
-  interface :anything
+  interface :anything, methods: []
 end
 
 describe InterfaceInteraction do

data/spec/active_interaction/integration/object_interaction_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 ObjectInteraction = Class.new(TestInteraction) do

data/spec/active_interaction/integration/string_interaction_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe 'StringInteraction' do

data/spec/active_interaction/integration/symbol_interaction_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe 'SymbolInteraction' do

data/spec/active_interaction/integration/time_interaction_spec.rb

@@ -1,19 +1,5 @@
-# coding: utf-8
-
 require 'spec_helper'
 
-TimeZone = Class.new do
-  def self.at(*args)
-    TimeWithZone.new(Time.at(*args))
-  end
-
-  def self.parse(*args)
-    TimeWithZone.new(Time.parse(*args))
-  rescue ArgumentError
-    nil
-  end
-end
-
 TimeWithZone = Class.new do
   attr_reader :time
 
@@ -22,7 +8,17 @@ TimeWithZone = Class.new do
   end
 
   def ==(other)
-    time == other.time
+    !other.nil? && time == other.time
+  end
+
+  def at(*args)
+    Time.at(*args)
+  end
+
+  def parse(*args)
+    Time.parse(*args)
+  rescue ArgumentError
+    nil
   end
 end
 
@@ -40,14 +36,14 @@ describe TimeInteraction do
     before do
       inputs[:a] = a
 
-      allow(Time).to receive(:zone).and_return(TimeZone)
+      allow(Time).to receive(:zone).and_return(TimeWithZone.new(0))
     end
 
     context 'with an integer' do
       let(:a) { rand(1 << 16) }
 
       it 'returns the correct value' do
-        expect(result[:a]).to eq TimeZone.at(a)
+        expect(result[:a]).to eq Time.zone.at(a)
       end
     end
 
@@ -55,7 +51,7 @@ describe TimeInteraction do
       let(:a) { '2011-12-13T14:15:16Z' }
 
       it 'returns the correct value' do
-        expect(result[:a]).to eq TimeZone.parse(a)
+        expect(result[:a]).to eq Time.zone.parse(a)
       end
     end
 

data/spec/active_interaction/modules/validation_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::Validation do
@@ -50,7 +48,7 @@ describe ActiveInteraction::Validation do
             "#{ActiveInteraction::Base.i18n_scope}.types.#{filter.class.slug}"
           )
 
-          expect(result).to eql [[filter.name, :invalid_type, type: type]]
+          expect(result).to eql [[filter.name, :invalid_type, { type: type }]]
         end
       end
 

data/spec/spec_helper.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 # Disable code coverage for JRuby because it always reports 0% coverage.
 if RUBY_ENGINE != 'jruby'
   require 'coveralls'
@@ -7,13 +5,11 @@ if RUBY_ENGINE != 'jruby'
 end
 
 require 'i18n'
-if I18n.config.respond_to?(:enforce_available_locales)
-  I18n.config.enforce_available_locales = true
-end
+I18n.config.enforce_available_locales = true if I18n.config.respond_to?(:enforce_available_locales)
 
 require 'active_interaction'
 
-Dir['./spec/support/**/*.rb'].each { |f| require f }
+Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
 
 RSpec.configure do |config|
   config.run_all_when_everything_filtered = true

data/spec/support/concerns.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 shared_context 'concerns' do |concern|
   let(:klass) do
     Class.new do

data/spec/support/filters.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 shared_context 'filters' do
   let(:block) { nil }
   let(:name) { SecureRandom.hex.to_sym }
@@ -49,12 +47,13 @@ shared_examples_for 'a filter' do
 
   describe '#cast' do
     let(:value) { nil }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'optional' do
       include_context 'optional'
 
       it 'returns nil' do
-        expect(filter.cast(value, nil)).to be_nil
+        expect(result).to be_nil
       end
     end
 
@@ -62,21 +61,26 @@ shared_examples_for 'a filter' do
       include_context 'required'
 
       it 'raises an error' do
-        expect do
-          filter.cast(value, nil)
-        end.to raise_error ActiveInteraction::MissingValueError
+        expect { result }.to raise_error ActiveInteraction::MissingValueError
       end
 
       context 'with an invalid default' do
         let(:value) { Object.new }
 
         it 'raises an error' do
-          expect do
-            filter.cast(value, nil)
-          end.to raise_error ActiveInteraction::InvalidValueError
+          expect { result }.to raise_error ActiveInteraction::InvalidValueError
         end
       end
     end
+
+    # BasicObject is missing a lot of methods
+    context 'with a BasicObject' do
+      let(:value) { BasicObject.new }
+
+      it 'raises an error' do
+        expect { result }.to raise_error ActiveInteraction::InvalidValueError
+      end
+    end
   end
 
   describe '#clean' do

data/spec/support/interactions.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 TestInteraction = Class.new(ActiveInteraction::Base) do
   def self.name
     SecureRandom.hex
@@ -22,15 +20,25 @@ shared_examples_for 'an interaction' do |type, generator, filter_options = {}|
   let(:described_class) do
     Class.new(TestInteraction) do
       public_send(type, :required, filter_options)
-      public_send(type, :optional, filter_options.merge(default: nil))
+      public_send(type, :optional,
+        filter_options.merge(
+          default: nil
+        )
+      )
       public_send(type, :default,
-        filter_options.merge(default: generator.call)
+        filter_options.merge(
+          default: generator.call
+        )
       )
-      public_send(type, :defaults_1, :defaults_2,
-        filter_options.merge(default: generator.call)
+      public_send(type, :defaults1, :defaults2,
+        filter_options.merge(
+          default: generator.call
+        )
       )
-      public_send(type, :defaults_3,
-        filter_options.merge(default: -> { required })
+      public_send(type, :defaults3,
+        filter_options.merge(
+          default: -> { required }
+        )
       )
     end
   end
@@ -81,16 +89,16 @@ shared_examples_for 'an interaction' do |type, generator, filter_options = {}|
       expect(result[:default]).to_not be_nil
     end
 
-    it 'does not return nil for :defaults_1' do
-      expect(result[:defaults_1]).to_not be_nil
+    it 'does not return nil for :defaults1' do
+      expect(result[:defaults1]).to_not be_nil
     end
 
-    it 'does not return nil for :defaults_2' do
-      expect(result[:defaults_2]).to_not be_nil
+    it 'does not return nil for :defaults2' do
+      expect(result[:defaults2]).to_not be_nil
     end
 
-    it 'evaluates :defaults_3 in the interaction binding' do
-      expect(result[:defaults_3]).to eql result[:required]
+    it 'evaluates :defaults3 in the interaction binding' do
+      expect(result[:defaults3]).to eql result[:required]
     end
 
     context 'with inputs[:optional]' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_interaction
 version: !ruby/object:Gem::Version
-  version: 3.8.3
+  version: 4.0.0
 platform: ruby
 authors:
 - Aaron Lasseigne
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-23 00:00:00.000000000 Z
+date: 2021-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -17,7 +17,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '5'
     - - "<"
       - !ruby/object:Gem::Version
         version: '7'
@@ -27,7 +27,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '5'
     - - "<"
       - !ruby/object:Gem::Version
         version: '7'
@@ -93,28 +93,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.3'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -135,14 +135,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.44.0
+        version: '1.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.44.0
+        version: '1.8'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -161,16 +189,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.2
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.2
+        version: '0'
 description: |2
       ActiveInteraction manages application-specific business logic. It is an
       implementation of the command pattern in Ruby.
@@ -186,7 +214,6 @@ files:
 - LICENSE.md
 - README.md
 - lib/active_interaction.rb
-- lib/active_interaction/backports.rb
 - lib/active_interaction/base.rb
 - lib/active_interaction/concerns/active_modelable.rb
 - lib/active_interaction/concerns/active_recordable.rb
@@ -197,7 +224,6 @@ files:
 - lib/active_interaction/filter.rb
 - lib/active_interaction/filter_column.rb
 - lib/active_interaction/filters/abstract_date_time_filter.rb
-- lib/active_interaction/filters/abstract_filter.rb
 - lib/active_interaction/filters/abstract_numeric_filter.rb
 - lib/active_interaction/filters/array_filter.rb
 - lib/active_interaction/filters/boolean_filter.rb
@@ -215,6 +241,7 @@ files:
 - lib/active_interaction/filters/symbol_filter.rb
 - lib/active_interaction/filters/time_filter.rb
 - lib/active_interaction/grouped_input.rb
+- lib/active_interaction/inputs.rb
 - lib/active_interaction/locale/en.yml
 - lib/active_interaction/locale/fr.yml
 - lib/active_interaction/locale/it.yml
@@ -233,7 +260,6 @@ files:
 - spec/active_interaction/filter_column_spec.rb
 - spec/active_interaction/filter_spec.rb
 - spec/active_interaction/filters/abstract_date_time_filter_spec.rb
-- spec/active_interaction/filters/abstract_filter_spec.rb
 - spec/active_interaction/filters/abstract_numeric_filter_spec.rb
 - spec/active_interaction/filters/array_filter_spec.rb
 - spec/active_interaction/filters/boolean_filter_spec.rb
@@ -252,6 +278,7 @@ files:
 - spec/active_interaction/filters/time_filter_spec.rb
 - spec/active_interaction/grouped_input_spec.rb
 - spec/active_interaction/i18n_spec.rb
+- spec/active_interaction/inputs_spec.rb
 - spec/active_interaction/integration/array_interaction_spec.rb
 - spec/active_interaction/integration/boolean_interaction_spec.rb
 - spec/active_interaction/integration/date_interaction_spec.rb
@@ -265,7 +292,6 @@ files:
 - spec/active_interaction/integration/string_interaction_spec.rb
 - spec/active_interaction/integration/symbol_interaction_spec.rb
 - spec/active_interaction/integration/time_interaction_spec.rb
-- spec/active_interaction/modules/input_processor_spec.rb
 - spec/active_interaction/modules/validation_spec.rb
 - spec/spec_helper.rb
 - spec/support/concerns.rb
@@ -286,63 +312,62 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
 summary: Manage application specific business logic.
 test_files:
-- spec/spec_helper.rb
-- spec/active_interaction/grouped_input_spec.rb
-- spec/active_interaction/filters/hash_filter_spec.rb
+- spec/active_interaction/base_spec.rb
+- spec/active_interaction/concerns/active_modelable_spec.rb
+- spec/active_interaction/concerns/active_recordable_spec.rb
+- spec/active_interaction/concerns/hashable_spec.rb
+- spec/active_interaction/concerns/missable_spec.rb
+- spec/active_interaction/concerns/runnable_spec.rb
+- spec/active_interaction/errors_spec.rb
+- spec/active_interaction/filter_column_spec.rb
+- spec/active_interaction/filter_spec.rb
 - spec/active_interaction/filters/abstract_date_time_filter_spec.rb
-- spec/active_interaction/filters/boolean_filter_spec.rb
+- spec/active_interaction/filters/abstract_numeric_filter_spec.rb
 - spec/active_interaction/filters/array_filter_spec.rb
-- spec/active_interaction/filters/time_filter_spec.rb
-- spec/active_interaction/filters/abstract_filter_spec.rb
-- spec/active_interaction/filters/float_filter_spec.rb
+- spec/active_interaction/filters/boolean_filter_spec.rb
 - spec/active_interaction/filters/date_filter_spec.rb
-- spec/active_interaction/filters/integer_filter_spec.rb
-- spec/active_interaction/filters/object_filter_spec.rb
-- spec/active_interaction/filters/symbol_filter_spec.rb
-- spec/active_interaction/filters/string_filter_spec.rb
-- spec/active_interaction/filters/abstract_numeric_filter_spec.rb
+- spec/active_interaction/filters/date_time_filter_spec.rb
 - spec/active_interaction/filters/decimal_filter_spec.rb
 - spec/active_interaction/filters/file_filter_spec.rb
+- spec/active_interaction/filters/float_filter_spec.rb
+- spec/active_interaction/filters/hash_filter_spec.rb
+- spec/active_interaction/filters/integer_filter_spec.rb
 - spec/active_interaction/filters/interface_filter_spec.rb
+- spec/active_interaction/filters/object_filter_spec.rb
 - spec/active_interaction/filters/record_filter_spec.rb
-- spec/active_interaction/filters/date_time_filter_spec.rb
+- spec/active_interaction/filters/string_filter_spec.rb
+- spec/active_interaction/filters/symbol_filter_spec.rb
+- spec/active_interaction/filters/time_filter_spec.rb
+- spec/active_interaction/grouped_input_spec.rb
 - spec/active_interaction/i18n_spec.rb
+- spec/active_interaction/inputs_spec.rb
+- spec/active_interaction/integration/array_interaction_spec.rb
 - spec/active_interaction/integration/boolean_interaction_spec.rb
 - spec/active_interaction/integration/date_interaction_spec.rb
-- spec/active_interaction/integration/symbol_interaction_spec.rb
-- spec/active_interaction/integration/interface_interaction_spec.rb
-- spec/active_interaction/integration/time_interaction_spec.rb
-- spec/active_interaction/integration/float_interaction_spec.rb
-- spec/active_interaction/integration/integer_interaction_spec.rb
-- spec/active_interaction/integration/string_interaction_spec.rb
-- spec/active_interaction/integration/array_interaction_spec.rb
-- spec/active_interaction/integration/hash_interaction_spec.rb
 - spec/active_interaction/integration/date_time_interaction_spec.rb
 - spec/active_interaction/integration/file_interaction_spec.rb
+- spec/active_interaction/integration/float_interaction_spec.rb
+- spec/active_interaction/integration/hash_interaction_spec.rb
+- spec/active_interaction/integration/integer_interaction_spec.rb
+- spec/active_interaction/integration/interface_interaction_spec.rb
 - spec/active_interaction/integration/object_interaction_spec.rb
-- spec/active_interaction/filter_column_spec.rb
-- spec/active_interaction/errors_spec.rb
+- spec/active_interaction/integration/string_interaction_spec.rb
+- spec/active_interaction/integration/symbol_interaction_spec.rb
+- spec/active_interaction/integration/time_interaction_spec.rb
 - spec/active_interaction/modules/validation_spec.rb
-- spec/active_interaction/modules/input_processor_spec.rb
-- spec/active_interaction/filter_spec.rb
-- spec/active_interaction/base_spec.rb
-- spec/active_interaction/concerns/active_modelable_spec.rb
-- spec/active_interaction/concerns/hashable_spec.rb
-- spec/active_interaction/concerns/active_recordable_spec.rb
-- spec/active_interaction/concerns/missable_spec.rb
-- spec/active_interaction/concerns/runnable_spec.rb
+- spec/spec_helper.rb
+- spec/support/concerns.rb
 - spec/support/filters.rb
 - spec/support/interactions.rb
-- spec/support/concerns.rb