active_interaction 3.8.3 → 4.0.0

data/spec/active_interaction/filters/object_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 class ObjectThing
@@ -11,7 +9,8 @@ class ObjectThing
     raise 'error'
   end
 end
-class ObjectThings; end
+
+class ObjectThings; end # rubocop:disable Lint/EmptyClass
 BackupObjectThing = ObjectThing
 
 describe ActiveInteraction::ObjectFilter, :filter do
@@ -24,86 +23,51 @@ describe ActiveInteraction::ObjectFilter, :filter do
 
   describe '#cast' do
     let(:value) { ObjectThing.new }
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
-    context 'with class as a Class' do
+    context 'with an instance of the class' do
       it 'returns the instance' do
         expect(result).to eql value
       end
 
+      context 'with an instance that is a subclass' do
+        let(:subclass) { Class.new(ObjectThing) }
+        let(:value) { subclass.new }
+
+        it 'returns the instance' do
+          expect(result).to eql value
+        end
+      end
+
       it 'handles reconstantizing' do
         expect(result).to eql value
 
         Object.send(:remove_const, :ObjectThing)
-        ObjectThing = BackupObjectThing
+        ObjectThing = BackupObjectThing # rubocop:disable Lint/ConstantDefinitionInBlock
         value = ObjectThing.new
 
-        expect(filter.cast(value, nil)).to eql value
+        expect(filter.send(:cast, value, nil)).to eql value
       end
 
       it 'handles reconstantizing subclasses' do
         filter
 
         Object.send(:remove_const, :ObjectThing)
-        ObjectThing = BackupObjectThing
-        class SubObjectThing < ObjectThing; end
+        ObjectThing = BackupObjectThing # rubocop:disable Lint/ConstantDefinitionInBlock
+        class SubObjectThing < ObjectThing; end # rubocop:disable Lint/ConstantDefinitionInBlock
         value = SubObjectThing.new
 
-        expect(filter.cast(value, nil)).to eql value
+        expect(filter.send(:cast, value, nil)).to eql value
       end
 
       context 'without the class available' do
         before { Object.send(:remove_const, :ObjectThing) }
-        after { ObjectThing = BackupObjectThing }
+        after { ObjectThing = BackupObjectThing } # rubocop:disable Lint/ConstantDefinitionInBlock
 
         it 'does not raise an error on initialization' do
           expect { filter }.to_not raise_error
         end
       end
-
-      context 'with bidirectional class comparisons' do
-        let(:case_equality) { false }
-        let(:class_equality) { false }
-
-        before do
-          allow(ObjectThing).to receive(:===).and_return(case_equality)
-          allow(value).to receive(:is_a?).and_return(class_equality)
-        end
-
-        context 'without case or class equality' do
-          it 'raises an error' do
-            expect do
-              result
-            end.to raise_error ActiveInteraction::InvalidValueError
-          end
-        end
-
-        context 'with case equality' do
-          let(:case_equality) { true }
-
-          it 'returns the instance' do
-            expect(result).to eql value
-          end
-        end
-
-        context 'with class equality' do
-          let(:class_equality) { true }
-
-          it 'returns the instance' do
-            expect(result).to eql value
-          end
-        end
-      end
-    end
-
-    context 'with class as a superclass' do
-      before do
-        options[:class] = ObjectThing.superclass
-      end
-
-      it 'returns the instance' do
-        expect(result).to eql value
-      end
     end
 
     context 'with class as a String' do
@@ -134,7 +98,7 @@ describe ActiveInteraction::ObjectFilter, :filter do
       it 'raises an error' do
         expect do
           result
-        end.to raise_error ActiveInteraction::InvalidClassError
+        end.to raise_error ActiveInteraction::InvalidNameError
       end
     end
 
@@ -161,7 +125,7 @@ describe ActiveInteraction::ObjectFilter, :filter do
         end
       end
 
-      context 'with a object of the correct class' do
+      context 'with an object of the correct class' do
         let(:value) { ObjectThing.new }
 
         it 'does not call the converter' do
@@ -170,7 +134,7 @@ describe ActiveInteraction::ObjectFilter, :filter do
         end
       end
 
-      context 'with a object is a subclass' do
+      context 'with an object that is a subclass' do
         let(:subclass) { Class.new(ObjectThing) }
         let(:value) { subclass.new }
 
@@ -223,7 +187,7 @@ describe ActiveInteraction::ObjectFilter, :filter do
 
         before do
           options[:default] = ObjectThing.new
-          options[:converter] = ->(_) { nil }
+          options[:converter] = ->(_) {}
         end
 
         it 'raises an error' do

data/spec/active_interaction/filters/record_filter_spec.rb

@@ -6,7 +6,7 @@ class RecordThing
   end
 
   def self.finder(_)
-    @record2 ||= new
+    @finder ||= new
   end
 
   def self.finds_nil(_)
@@ -17,11 +17,12 @@ class RecordThing
     ''
   end
 
-  def self.passthrough(x)
-    x
+  def self.passthrough(obj)
+    obj
   end
 end
-class RecordThings; end
+
+class RecordThings; end # rubocop:disable Lint/EmptyClass
 BackupRecordThing = RecordThing
 
 describe ActiveInteraction::RecordFilter, :filter do
@@ -38,78 +39,51 @@ describe ActiveInteraction::RecordFilter, :filter do
     end
 
     let(:value) { RecordThing.new }
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
-    context 'with class as a Class' do
+    context 'with an instance of the class' do
       it 'returns the instance' do
         expect(result).to eql value
       end
 
+      context 'with an instance that is a subclass' do
+        let(:subclass) { Class.new(RecordThing) }
+        let(:value) { subclass.new }
+
+        it 'returns the instance' do
+          expect(result).to eql value
+        end
+      end
+
       it 'handles reconstantizing' do
         expect(result).to eql value
 
         Object.send(:remove_const, :RecordThing)
-        RecordThing = BackupRecordThing
+        RecordThing = BackupRecordThing # rubocop:disable Lint/ConstantDefinitionInBlock
         value = RecordThing.new
 
-        expect(filter.cast(value, nil)).to eql value
+        expect(filter.send(:cast, value, nil)).to eql value
       end
 
       it 'handles reconstantizing subclasses' do
         filter
 
         Object.send(:remove_const, :RecordThing)
-        RecordThing = BackupRecordThing
-        class SubRecordThing < RecordThing; end
+        RecordThing = BackupRecordThing # rubocop:disable Lint/ConstantDefinitionInBlock
+        class SubRecordThing < RecordThing; end # rubocop:disable Lint/ConstantDefinitionInBlock
         value = SubRecordThing.new
 
-        expect(filter.cast(value, nil)).to eql value
+        expect(filter.send(:cast, value, nil)).to eql value
       end
 
       context 'without the class available' do
         before { Object.send(:remove_const, :RecordThing) }
-        after { RecordThing = BackupRecordThing }
+        after { RecordThing = BackupRecordThing } # rubocop:disable Lint/ConstantDefinitionInBlock
 
         it 'does not raise an error on initialization' do
           expect { filter }.to_not raise_error
         end
       end
-
-      context 'with bidirectional class comparisons' do
-        let(:case_equality) { false }
-        let(:class_equality) { false }
-
-        before do
-          options[:finder] = :passthrough
-
-          allow(RecordThing).to receive(:===).and_return(case_equality)
-          allow(value).to receive(:is_a?).and_return(class_equality)
-        end
-
-        context 'without case or class equality' do
-          it 'raises an error' do
-            expect do
-              result
-            end.to raise_error ActiveInteraction::InvalidValueError
-          end
-        end
-
-        context 'with case equality' do
-          let(:case_equality) { true }
-
-          it 'returns the instance' do
-            expect(result).to eql value
-          end
-        end
-
-        context 'with class equality' do
-          let(:class_equality) { true }
-
-          it 'returns the instance' do
-            expect(result).to eql value
-          end
-        end
-      end
     end
 
     context 'with class as a superclass' do
@@ -150,7 +124,7 @@ describe ActiveInteraction::RecordFilter, :filter do
       it 'raises an error' do
         expect do
           result
-        end.to raise_error ActiveInteraction::InvalidClassError
+        end.to raise_error ActiveInteraction::InvalidNameError
       end
     end
 

data/spec/active_interaction/filters/string_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::StringFilter, :filter do
@@ -13,7 +11,7 @@ describe ActiveInteraction::StringFilter, :filter do
   end
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a String' do
       let(:value) { SecureRandom.hex }
@@ -23,6 +21,20 @@ describe ActiveInteraction::StringFilter, :filter do
       end
     end
 
+    context 'with an implicit String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            @to_str ||= SecureRandom.hex
+          end
+        end.new
+      end
+
+      it 'returns the String' do
+        expect(result).to eql value.to_str
+      end
+    end
+
     context 'with a strippable String' do
       let(:value) { " #{SecureRandom.hex} " }
 

data/spec/active_interaction/filters/symbol_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::SymbolFilter, :filter do
@@ -7,7 +5,7 @@ describe ActiveInteraction::SymbolFilter, :filter do
   it_behaves_like 'a filter'
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a Symbol' do
       let(:value) { SecureRandom.hex.to_sym }
@@ -17,6 +15,20 @@ describe ActiveInteraction::SymbolFilter, :filter do
       end
     end
 
+    context 'with an implicit Symbol' do
+      let(:value) do
+        Class.new do
+          def to_sym
+            :symbol
+          end
+        end.new
+      end
+
+      it 'returns a symbol' do
+        expect(result).to eql value.to_sym
+      end
+    end
+
     context 'with a String' do
       let(:value) { SecureRandom.hex }
 

data/spec/active_interaction/filters/time_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::TimeFilter, :filter do
@@ -37,7 +35,7 @@ describe ActiveInteraction::TimeFilter, :filter do
   end
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a Time' do
       let(:value) { Time.new }
@@ -85,6 +83,70 @@ describe ActiveInteraction::TimeFilter, :filter do
       end
     end
 
+    context 'with an implicit String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            '2011-12-13 14:15:16 +1718'
+          end
+        end.new
+      end
+
+      it 'returns a Time' do
+        expect(result).to eql Time.parse(value)
+      end
+    end
+
+    context 'with a blank String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            ' '
+          end
+        end.new
+      end
+
+      context 'optional' do
+        include_context 'optional'
+
+        it 'returns the default' do
+          expect(result).to eql options[:default]
+        end
+      end
+
+      context 'required' do
+        include_context 'required'
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::MissingValueError
+        end
+      end
+    end
+
+    context 'with an Integer' do
+      let(:value) { rand(1 << 16) }
+
+      it 'returns the Time' do
+        expect(result).to eql Time.at(value)
+      end
+    end
+
+    context 'with an implicit Integer' do
+      let(:value) do
+        Class.new do
+          def to_int
+            @to_int ||= rand(1 << 16)
+          end
+        end.new
+      end
+
+      it 'returns the Time' do
+        expect(result).to eql Time.at(value)
+      end
+    end
+
     context 'with a GroupedInput' do
       let(:year) { 2012 }
       let(:month) { 1 }

data/spec/active_interaction/grouped_input_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::GroupedInput do

data/spec/active_interaction/i18n_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction do
@@ -20,7 +18,7 @@ end
 describe I18nInteraction do
   include_context 'interactions'
 
-  TYPES = ActiveInteraction::Filter
+  TYPES = ActiveInteraction::Filter # rubocop:disable Lint/ConstantDefinitionInBlock
     .const_get(:CLASSES)
     .map { |slug, _| slug.to_s }
 
@@ -87,9 +85,7 @@ describe I18nInteraction do
       # This must appear before including the translation examples so that the
       # locale is available before it is assigned.
       locale = :hsilgne
-      unless I18n.locale_available?(locale)
-        I18n.config.available_locales = I18n.config.available_locales + [locale]
-      end
+      I18n.config.available_locales = I18n.config.available_locales + [locale] unless I18n.locale_available?(locale)
     end
 
     include_examples 'translation', :hsilgne
@@ -100,7 +96,7 @@ describe I18nInteraction do
           errors: {
             messages: {
               invalid: 'is invalid'.reverse,
-              invalid_type: "%{type} #{'is not a valid'.reverse}",
+              invalid_type: "%<type>s} #{'is not a valid'.reverse}",
               missing: 'missing'.reverse
             }
           },