active_interaction 3.8.3 → 4.0.0

data/spec/active_interaction/filters/file_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::FileFilter, :filter do
@@ -7,7 +5,7 @@ describe ActiveInteraction::FileFilter, :filter do
   it_behaves_like 'a filter'
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a File' do
       let(:value) { File.new(__FILE__) }

data/spec/active_interaction/filters/float_filter_spec.rb

@@ -1,5 +1,4 @@
-# coding: utf-8
-
+require 'bigdecimal'
 require 'spec_helper'
 
 describe ActiveInteraction::FloatFilter, :filter do
@@ -7,7 +6,7 @@ describe ActiveInteraction::FloatFilter, :filter do
   it_behaves_like 'a filter'
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a Float' do
       let(:value) { rand }
@@ -17,8 +16,22 @@ describe ActiveInteraction::FloatFilter, :filter do
       end
     end
 
+    context 'with an implicit Integer' do
+      let(:value) do
+        Class.new do
+          def to_int
+            @to_int ||= rand(1 << 16)
+          end
+        end.new
+      end
+
+      it 'returns a Float' do
+        expect(result).to eql value.to_int.to_f
+      end
+    end
+
     context 'with a Numeric' do
-      let(:value) { rand(1 << 16) }
+      let(:value) { BigDecimal('1.2') }
 
       it 'returns a Float' do
         expect(result).to eql value.to_f
@@ -42,6 +55,49 @@ describe ActiveInteraction::FloatFilter, :filter do
         end.to raise_error ActiveInteraction::InvalidValueError
       end
     end
+
+    context 'with an implicit String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            '1.1'
+          end
+        end.new
+      end
+
+      it 'returns a Float' do
+        # apparently `Float()` doesn't do this even though `Integer()` does
+        expect(result).to eql Float(value.to_str)
+      end
+    end
+
+    context 'with a blank String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            ' '
+          end
+        end.new
+      end
+
+      context 'optional' do
+        include_context 'optional'
+
+        it 'returns the default' do
+          expect(result).to eql options[:default]
+        end
+      end
+
+      context 'required' do
+        include_context 'required'
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::MissingValueError
+        end
+      end
+    end
   end
 
   describe '#database_column_type' do

data/spec/active_interaction/filters/hash_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::HashFilter, :filter do
@@ -15,7 +13,7 @@ describe ActiveInteraction::HashFilter, :filter do
   end
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a Hash' do
       let(:value) { {} }
@@ -25,6 +23,20 @@ describe ActiveInteraction::HashFilter, :filter do
       end
     end
 
+    context 'with an implicit Hash' do
+      let(:value) do
+        Class.new do
+          def to_hash
+            {}
+          end
+        end.new
+      end
+
+      it 'returns the Hash' do
+        expect(result).to eql value.to_hash
+      end
+    end
+
     context 'with a non-empty Hash' do
       let(:value) { { a: {} } }
 
@@ -66,12 +78,10 @@ describe ActiveInteraction::HashFilter, :filter do
         end
 
         it 'populates the error' do
-          begin
-            result
-          rescue ActiveInteraction::InvalidNestedValueError => e
-            expect(e.filter_name).to eql k
-            expect(e.input_value).to eql v
-          end
+          result
+        rescue ActiveInteraction::InvalidNestedValueError => e
+          expect(e.filter_name).to eql k
+          expect(e.input_value).to eql v
         end
       end
     end

data/spec/active_interaction/filters/integer_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::IntegerFilter, :filter do
@@ -7,7 +5,7 @@ describe ActiveInteraction::IntegerFilter, :filter do
   it_behaves_like 'a filter'
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with an Integer' do
       let(:value) { rand(1 << 16) }
@@ -29,7 +27,7 @@ describe ActiveInteraction::IntegerFilter, :filter do
       let(:value) { rand(1 << 16).to_s }
 
       it 'returns an Integer' do
-        expect(result).to eql Integer(value)
+        expect(result).to eql Integer(value, 10)
       end
     end
 
@@ -43,12 +41,56 @@ describe ActiveInteraction::IntegerFilter, :filter do
       end
     end
 
+    context 'with an implicit String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            '1'
+          end
+        end.new
+      end
+
+      it 'returns an Integer' do
+        # jRuby freezes on the implicit string value
+        expect(result).to eql Integer(value.to_str, 10)
+      end
+    end
+
+    context 'with a blank String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            ' '
+          end
+        end.new
+      end
+
+      context 'optional' do
+        include_context 'optional'
+
+        it 'returns the default' do
+          expect(result).to eql options[:default]
+        end
+      end
+
+      context 'required' do
+        include_context 'required'
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::MissingValueError
+        end
+      end
+    end
+
     it 'supports different bases' do
-      expect(filter.cast('07', nil)).to eql 7
+      expect(
+        described_class.new(name, base: 8).send(:cast, '071', nil)
+      ).to eql 57
       expect do
-        filter.cast('08', nil)
+        described_class.new(name, base: 8).send(:cast, '081', nil)
       end.to raise_error ActiveInteraction::InvalidValueError
-      expect(described_class.new(name, base: 10).cast('08', nil)).to eql 8
     end
   end
 

data/spec/active_interaction/filters/interface_filter_spec.rb

@@ -1,47 +1,420 @@
-# coding: utf-8
-
 require 'spec_helper'
-require 'json'
-require 'yaml'
+
+module InterfaceModule; end
+
+class InterfaceClass; end # rubocop:disable Lint/EmptyClass
 
 describe ActiveInteraction::InterfaceFilter, :filter do
   include_context 'filters'
-  it_behaves_like 'a filter'
-
-  before { options[:methods] = %i[dump load] }
+  it_behaves_like 'a filter' do
+    let(:name) { :interface_module }
+  end
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
-    context 'with a BasicObject' do
-      let(:value) { BasicObject.new }
+    context 'with an implicit constant name' do
+      context 'passed an instance' do
+        context 'with the module included' do
+          let(:name) { :interface_module }
+          let(:value) do
+            Class.new do
+              include InterfaceModule
+            end.new
+          end
 
-      it 'raises an error' do
-        expect { result }.to raise_error ActiveInteraction::InvalidValueError
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'with the class inherited from' do
+          let(:name) { :interface_class }
+          let(:value) do
+            Class.new(InterfaceClass) {}.new # rubocop:disable Lint/EmptyBlock
+          end
+
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'that is extended by the ancestor' do
+          let(:name) { :interface_module }
+          let(:value) do
+            Class.new {}.new.extend(InterfaceModule) # rubocop:disable Lint/EmptyBlock
+          end
+
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'that does not match' do
+          let(:name) { :interface_module }
+          let(:value) { Class.new }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+
+        context 'with the class itself' do
+          let(:name) { :interface_class }
+          let(:value) do
+            InterfaceClass.new
+          end
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+      end
+
+      context 'passed a class' do
+        context 'with the class inherited from' do
+          let(:name) { :interface_class }
+          let(:value) do
+            Class.new(InterfaceClass) {} # rubocop:disable Lint/EmptyBlock
+          end
+
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'that is extended by the ancestor' do
+          let(:name) { :interface_module }
+          let(:value) do
+            Class.new do
+              extend InterfaceModule
+            end
+          end
+
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'that does not match' do
+          let(:name) { :interface_class }
+          let(:value) { Class }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+
+        context 'with the class itself' do
+          let(:name) { :interface_class }
+          let(:value) { InterfaceClass }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+      end
+
+      context 'passed a module' do
+        context 'that is extended by the ancestor' do
+          let(:name) { :interface_module }
+          let(:value) do
+            Module.new do
+              extend InterfaceModule
+            end
+          end
+
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'that does not match' do
+          let(:name) { :interface_module }
+          let(:value) { Module.new }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+
+        context 'with the module itself' do
+          let(:name) { :interface_module }
+          let(:value) { InterfaceModule }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+      end
+
+      context 'given an invalid name' do
+        let(:name) { :invalid }
+        let(:value) { Object }
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::InvalidNameError
+        end
       end
     end
 
-    context 'with an Object' do
-      let(:value) { Object.new }
+    context 'with a constant given' do
+      context 'passed an instance' do
+        context 'with the module included' do
+          before { options.merge!(from: :interface_module) }
+          let(:value) do
+            Class.new do
+              include InterfaceModule
+            end.new
+          end
 
-      it 'raises an error' do
-        expect { result }.to raise_error ActiveInteraction::InvalidValueError
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'with the class inherited from' do
+          before { options.merge!(from: :interface_class) }
+          let(:value) do
+            Class.new(InterfaceClass) {}.new # rubocop:disable Lint/EmptyBlock
+          end
+
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'that is extended by the ancestor' do
+          before { options.merge!(from: :interface_module) }
+          let(:value) do
+            Class.new {}.new.extend(InterfaceModule) # rubocop:disable Lint/EmptyBlock
+          end
+
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'that does not match' do
+          let(:name) { :interface_class }
+          let(:value) { Class.new }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+
+        context 'with the class itself' do
+          let(:name) { :interface_class }
+          let(:value) { InterfaceClass.new }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+      end
+
+      context 'passed a class' do
+        context 'with the class inherited from' do
+          before { options.merge!(from: :interface_class) }
+          let(:value) do
+            Class.new(InterfaceClass) {} # rubocop:disable Lint/EmptyBlock
+          end
+
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'that is extended by the ancestor' do
+          before { options.merge!(from: :interface_module) }
+          let(:value) do
+            Class.new do
+              extend InterfaceModule
+            end
+          end
+
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'that does not match' do
+          let(:name) { :interface_class }
+          let(:value) { Class }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+
+        context 'with the class itself' do
+          let(:name) { :interface_class }
+          let(:value) { InterfaceClass }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+      end
+
+      context 'passed a module' do
+        context 'that is extended by the ancestor' do
+          before { options.merge!(from: :interface_module) }
+          let(:value) do
+            Module.new do
+              extend InterfaceModule
+            end
+          end
+
+          it 'returns a the value' do
+            expect(result).to eql value
+          end
+        end
+
+        context 'that does not match' do
+          let(:name) { :interface_module }
+          let(:value) { Module.new }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+
+        context 'with the module itself' do
+          let(:name) { :interface_module }
+          let(:value) { InterfaceModule }
+
+          it 'raises an error' do
+            expect do
+              result
+            end.to raise_error ActiveInteraction::InvalidValueError
+          end
+        end
+      end
+
+      context 'given an invalid name' do
+        before { options.merge!(from: :invalid) }
+        let(:value) { Object }
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::InvalidNameError
+        end
       end
     end
 
-    context 'with JSON' do
-      let(:value) { JSON }
+    context 'with methods passed' do
+      before { options[:methods] = %i[dump load] }
+
+      context 'passed an valid instance' do
+        let(:value) do
+          Class.new do
+            def dump; end
 
-      it 'returns an Array' do
-        expect(result).to eql value
+            def load; end
+          end.new
+        end
+
+        it 'returns a the value' do
+          expect(result).to eql value
+        end
+      end
+
+      context 'passed an invalid instance' do
+        let(:value) { Class.new }
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::InvalidValueError
+        end
+      end
+
+      context 'passed a class' do
+        let(:value) do
+          Class.new do
+            def self.dump; end
+
+            def self.load; end
+          end
+        end
+
+        it 'returns a the value' do
+          expect(result).to eql value
+        end
+      end
+
+      context 'passed an invalid class' do
+        let(:value) { Class }
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::InvalidValueError
+        end
+      end
+
+      context 'passed a module' do
+        let(:value) do
+          Module.new do
+            def self.dump; end
+
+            def self.load; end
+          end
+        end
+
+        it 'returns a the value' do
+          expect(result).to eql value
+        end
+      end
+
+      context 'passed an invalid module' do
+        let(:value) { Module.new }
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::InvalidValueError
+        end
       end
     end
 
-    context 'with YAML' do
-      let(:value) { YAML }
+    context 'with from and methods passed' do
+      before do
+        options[:from] = :module
+        options[:methods] = %i[dump load]
+      end
 
-      it 'returns an Hash' do
-        expect(result).to eql value
+      it 'raises an error' do
+        expect do
+          filter
+        end.to raise_error ActiveInteraction::InvalidFilterError
       end
     end
   end