actionpack 1.13.6 → 2.0.0

data/test/template/form_helper_test.rb

@@ -1,4 +1,34 @@
-require File.dirname(__FILE__) + '/../abstract_unit'
+require "#{File.dirname(__FILE__)}/../abstract_unit"
+
+silence_warnings do
+  Post = Struct.new(:title, :author_name, :body, :secret, :written_on, :cost)
+  Post.class_eval do
+    alias_method :title_before_type_cast, :title unless respond_to?(:title_before_type_cast)
+    alias_method :body_before_type_cast, :body unless respond_to?(:body_before_type_cast)
+    alias_method :author_name_before_type_cast, :author_name unless respond_to?(:author_name_before_type_cast)
+    
+    def new_record=(boolean)
+      @new_record = boolean
+    end
+    
+    def new_record?
+      @new_record
+    end
+  end
+
+  class Comment
+    attr_reader :id
+    attr_reader :post_id
+    def save; @id = 1; @post_id = 1 end
+    def new_record?; @id.nil? end
+    def name
+      @id.nil? ? 'new comment' : "comment ##{@id}"
+    end
+  end
+end
+
+class Comment::Nested < Comment; end
+
 
 class FormHelperTest < Test::Unit::TestCase
   include ActionView::Helpers::FormHelper
@@ -6,22 +36,24 @@ class FormHelperTest < Test::Unit::TestCase
   include ActionView::Helpers::UrlHelper
   include ActionView::Helpers::TagHelper
   include ActionView::Helpers::TextHelper
-
-  silence_warnings do
-    Post = Struct.new("Post", :title, :author_name, :body, :secret, :written_on, :cost)
-    Post.class_eval do
-      alias_method :title_before_type_cast, :title unless respond_to?(:title_before_type_cast)
-      alias_method :body_before_type_cast, :body unless respond_to?(:body_before_type_cast)
-      alias_method :author_name_before_type_cast, :author_name unless respond_to?(:author_name_before_type_cast)
-    end
-  end
+  include ActionView::Helpers::ActiveRecordHelper
+  include ActionView::Helpers::RecordIdentificationHelper
+  include ActionController::PolymorphicRoutes
 
   def setup
     @post = Post.new
-    def @post.errors() Class.new{ def on(field) field == "author_name" end }.new end
-
+    @comment = Comment.new
+    def @post.errors() 
+      Class.new{ 
+        def on(field); "can't be empty" if field == "author_name"; end 
+        def empty?() false end 
+        def count() 1 end
+        def full_messages() [ "Author name can't be empty" ] end  
+      }.new 
+    end
     def @post.id; 123; end
     def @post.id_before_type_cast; 123; end
+    def @post.to_param; '123'; end
 
     @post.title       = "Hello World"
     @post.author_name = ""
@@ -31,7 +63,7 @@ class FormHelperTest < Test::Unit::TestCase
 
     @controller = Class.new do
       attr_reader :url_for_options
-      def url_for(options, *parameters_for_method_reference)
+      def url_for(options)
         @url_for_options = options
         "http://www.example.com"
       end
@@ -39,6 +71,19 @@ class FormHelperTest < Test::Unit::TestCase
     @controller = @controller.new
   end
 
+  def test_label
+    assert_dom_equal('<label for="post_title">Title</label>', label("post", "title"))
+    assert_dom_equal('<label for="post_title">The title goes here</label>', label("post", "title", "The title goes here"))
+    assert_dom_equal(
+      '<label class="title_label" for="post_title">Title</label>',
+      label("post", "title", nil, :class => 'title_label')
+    )
+  end
+  
+  def test_label_with_symbols
+    assert_dom_equal('<label for="post_title">Title</label>', label(:post, :title))
+  end
+
   def test_text_field
     assert_dom_equal(
       '<input id="post_title" name="post[title]" size="30" type="text" value="Hello World" />', text_field("post", "title")
@@ -70,6 +115,12 @@ class FormHelperTest < Test::Unit::TestCase
     assert_dom_equal expected, text_field("post", "title", :maxlength => 35)
   end
 
+  def test_text_field_removing_size
+    expected = '<input id="post_title" maxlength="35" name="post[title]" type="text" value="Hello World" />'
+    assert_dom_equal expected, text_field("post", "title", "maxlength" => 35, "size" => nil)
+    assert_dom_equal expected, text_field("post", "title", :maxlength => 35, :size => nil)
+  end
+
   def test_text_field_doesnt_change_param_values
     object_name = 'post[]'
     expected = '<input id="post_123_title" name="post[123][title]" size="30" type="text" value="Hello World" />'
@@ -77,6 +128,22 @@ class FormHelperTest < Test::Unit::TestCase
     assert_equal object_name, "post[]"
   end
 
+  def test_hidden_field
+    assert_dom_equal '<input id="post_title" name="post[title]" type="hidden" value="Hello World" />',
+      hidden_field("post", "title")
+  end
+
+  def test_hidden_field_with_escapes
+    @post.title = "<b>Hello World</b>"
+    assert_dom_equal '<input id="post_title" name="post[title]" type="hidden" value="&lt;b&gt;Hello World&lt;/b&gt;" />',
+      hidden_field("post", "title")
+  end
+
+  def test_text_field_with_options
+    assert_dom_equal '<input id="post_title" name="post[title]" type="hidden" value="Something Else" />',
+      hidden_field("post", "title", :value => "Something Else")
+  end
+
   def test_check_box
     assert_dom_equal(
       '<input checked="checked" id="post_secret" name="post[secret]" type="checkbox" value="1" /><input name="post[secret]" type="hidden" value="0" />',
@@ -106,6 +173,13 @@ class FormHelperTest < Test::Unit::TestCase
     )
   end
 
+  def test_checkbox_disabled_still_submits_checked_value
+    assert_dom_equal(
+      '<input checked="checked" disabled="disabled" id="post_secret" name="post[secret]" type="checkbox" value="1" /><input name="post[secret]" type="hidden" value="1" />',
+      check_box("post", "secret", { :disabled => :true })
+    )
+  end
+
   def test_radio_button
     assert_dom_equal('<input checked="checked" id="post_title_hello_world" name="post[title]" type="radio" value="Hello World" />',
       radio_button("post", "title", "Hello World")
@@ -120,7 +194,7 @@ class FormHelperTest < Test::Unit::TestCase
       radio_button("post", "secret", "1")
    )
   end
-  
+
   def test_radio_button_respects_passed_in_id
      assert_dom_equal('<input checked="checked" id="foo" name="post[secret]" type="radio" value="1" />',
        radio_button("post", "secret", "1", :id=>"foo")
@@ -141,27 +215,20 @@ class FormHelperTest < Test::Unit::TestCase
       text_area("post", "body")
     )
   end
-  
+
   def test_text_area_with_alternate_value
     assert_dom_equal(
       '<textarea cols="40" id="post_body" name="post[body]" rows="20">Testing alternate values.</textarea>',
       text_area("post", "body", :value => 'Testing alternate values.')
     )
   end
-  
+
   def test_text_area_with_size_option
     assert_dom_equal(
       '<textarea cols="183" id="post_body" name="post[body]" rows="820">Back to the hill and over it again!</textarea>',
       text_area("post", "body", :size => "183x820")
     )
   end
-  
-  def test_date_selects
-    assert_dom_equal(
-      '<textarea cols="40" id="post_body" name="post[body]" rows="20">Back to the hill and over it again!</textarea>',
-      text_area("post", "body")
-    )
-  end
 
   def test_explicit_name
     assert_dom_equal(
@@ -205,6 +272,10 @@ class FormHelperTest < Test::Unit::TestCase
 
   def test_auto_index
     pid = @post.id
+    assert_dom_equal(
+      "<label for=\"post_#{pid}_title\">Title</label>",
+      label("post[]", "title")
+    )
     assert_dom_equal(
       "<input id=\"post_#{pid}_title\" name=\"post[#{pid}][title]\" size=\"30\" type=\"text\" value=\"Hello World\" />", text_field("post[]","title")
     )
@@ -229,17 +300,21 @@ class FormHelperTest < Test::Unit::TestCase
     _erbout = ''
 
     form_for(:post, @post, :html => { :id => 'create-post' }) do |f|
+      _erbout.concat f.label(:title)
       _erbout.concat f.text_field(:title)
       _erbout.concat f.text_area(:body)
       _erbout.concat f.check_box(:secret)
+      _erbout.concat f.submit('Create post')
     end
 
     expected = 
       "<form action='http://www.example.com' id='create-post' method='post'>" +
+      "<label for='post_title'>Title</label>" +
       "<input name='post[title]' size='30' type='text' id='post_title' value='Hello World' />" +
       "<textarea name='post[body]' id='post_body' rows='20' cols='40'>Back to the hill and over it again!</textarea>" +
       "<input name='post[secret]' checked='checked' type='checkbox' id='post_secret' value='1' />" +
       "<input name='post[secret]' type='hidden' value='0' />" +
+      "<input name='commit' id='post_submit' type='submit' value='Create post' />" +
       "</form>"
 
     assert_dom_equal expected, _erbout
@@ -285,11 +360,12 @@ class FormHelperTest < Test::Unit::TestCase
 
     assert_dom_equal expected, _erbout
   end
-  
+
   def test_form_for_with_index
     _erbout = ''
     
     form_for("post[]", @post) do |f|
+      _erbout.concat f.label(:title)
       _erbout.concat f.text_field(:title)
       _erbout.concat f.text_area(:body)
       _erbout.concat f.check_box(:secret)
@@ -297,11 +373,29 @@ class FormHelperTest < Test::Unit::TestCase
     
     expected = 
       "<form action='http://www.example.com' method='post'>" +
-      "<input name='post[123][title]' size='30' type='text' id='post_title' value='Hello World' />" +
-      "<textarea name='post[123][body]' id='post_body' rows='20' cols='40'>Back to the hill and over it again!</textarea>" +
-      "<input name='post[123][secret]' checked='checked' type='checkbox' id='post_secret' value='1' />" +
+      "<label for=\"post_123_title\">Title</label>" +
+      "<input name='post[123][title]' size='30' type='text' id='post_123_title' value='Hello World' />" +
+      "<textarea name='post[123][body]' id='post_123_body' rows='20' cols='40'>Back to the hill and over it again!</textarea>" +
+      "<input name='post[123][secret]' checked='checked' type='checkbox' id='post_123_secret' value='1' />" +
       "<input name='post[123][secret]' type='hidden' value='0' />" +
       "</form>"
+
+    assert_dom_equal expected, _erbout
+  end
+
+  def test_nested_fields_for
+    _erbout = ''
+    form_for(:post, @post) do |f|
+      f.fields_for(:comment, @post) do |c|
+        _erbout.concat c.text_field(:title)
+      end
+    end
+
+    expected = "<form action='http://www.example.com' method='post'>" +
+               "<input name='post[comment][title]' size='30' type='text' id='post_comment_title' value='Hello World' />" +
+               "</form>"
+
+    assert_dom_equal expected, _erbout
   end
 
   def test_fields_for
@@ -339,10 +433,39 @@ class FormHelperTest < Test::Unit::TestCase
     assert_dom_equal expected, _erbout
   end
 
+  def test_fields_for_with_only_object
+    _erbout = ''
+    fields_for(@post) do |f|
+      _erbout.concat f.text_field(:title)
+      _erbout.concat f.text_area(:body)
+      _erbout.concat f.check_box(:secret)
+    end
+
+    expected = 
+      "<input name='post[title]' size='30' type='text' id='post_title' value='Hello World' />" +
+      "<textarea name='post[body]' id='post_body' rows='20' cols='40'>Back to the hill and over it again!</textarea>" +
+      "<input name='post[secret]' checked='checked' type='checkbox' id='post_secret' value='1' />" +
+      "<input name='post[secret]' type='hidden' value='0' />"
+
+    assert_dom_equal expected, _erbout
+  end
+
+  def test_fields_for_object_with_bracketed_name
+    _erbout = ''
+    fields_for("author[post]", @post) do |f|
+      _erbout.concat f.label(:title)
+      _erbout.concat f.text_field(:title)
+    end
+
+    assert_dom_equal "<label for=\"author_post_title\">Title</label>" +
+    "<input name='author[post][title]' size='30' type='text' id='author_post_title' value='Hello World' />",
+      _erbout
+  end
+
   def test_form_builder_does_not_have_form_for_method
     assert ! ActionView::Helpers::FormBuilder.instance_methods.include?('form_for')
   end
-  
+
   def test_form_for_and_fields_for
     _erbout = ''
 
@@ -365,7 +488,29 @@ class FormHelperTest < Test::Unit::TestCase
 
     assert_dom_equal expected, _erbout
   end
-  
+
+  def test_form_for_and_fields_for_with_object
+    _erbout = ''
+
+    form_for(:post, @post, :html => { :id => 'create-post' }) do |post_form|
+      _erbout.concat post_form.text_field(:title)
+      _erbout.concat post_form.text_area(:body)
+
+      post_form.fields_for(@comment) do |comment_fields|
+        _erbout.concat comment_fields.text_field(:name)
+      end
+    end
+
+    expected = 
+      "<form action='http://www.example.com' id='create-post' method='post'>" +
+      "<input name='post[title]' size='30' type='text' id='post_title' value='Hello World' />" +
+      "<textarea name='post[body]' id='post_body' rows='20' cols='40'>Back to the hill and over it again!</textarea>" +
+      "<input name='post[comment][name]' type='text' id='post_comment_name' value='new comment' size='30' />" +
+      "</form>"
+
+    assert_dom_equal expected, _erbout
+  end
+
   class LabelledFormBuilder < ActionView::Helpers::FormBuilder
     (field_helpers - %w(hidden_field)).each do |selector|
       src = <<-END_SRC
@@ -376,7 +521,7 @@ class FormHelperTest < Test::Unit::TestCase
       class_eval src, __FILE__, __LINE__
     end
   end
-  
+
   def test_form_for_with_labelled_builder
     _erbout = ''
 
@@ -421,6 +566,42 @@ class FormHelperTest < Test::Unit::TestCase
     ActionView::Base.default_form_builder = old_default_form_builder
   end
 
+  def test_default_form_builder_with_active_record_helpers
+     
+    _erbout = '' 
+    form_for(:post, @post) do |f|
+       _erbout.concat f.error_message_on('author_name')
+       _erbout.concat f.error_messages
+    end    
+    
+    expected = %(<form action='http://www.example.com' method='post'>) + 
+               %(<div class='formError'>can't be empty</div>) + 
+               %(<div class="errorExplanation" id="errorExplanation"><h2>1 error prohibited this post from being saved</h2><p>There were problems with the following fields:</p><ul><li>Author name can't be empty</li></ul></div>) +
+               %(</form>)
+    
+    assert_dom_equal expected, _erbout
+
+  end
+  
+  def test_default_form_builder_no_instance_variable
+    post = @post
+    @post = nil
+    
+    _erbout = '' 
+    form_for(:post, post) do |f|
+       _erbout.concat f.error_message_on('author_name')
+       _erbout.concat f.error_messages
+    end    
+    
+    expected = %(<form action='http://www.example.com' method='post'>) + 
+               %(<div class='formError'>can't be empty</div>) + 
+               %(<div class="errorExplanation" id="errorExplanation"><h2>1 error prohibited this post from being saved</h2><p>There were problems with the following fields:</p><ul><li>Author name can't be empty</li></ul></div>) +
+               %(</form>)
+    
+    assert_dom_equal expected, _erbout
+    
+  end
+
   # Perhaps this test should be moved to prototype helper tests.
   def test_remote_form_for_with_labelled_builder
     self.extend ActionView::Helpers::PrototypeHelper
@@ -460,7 +641,7 @@ class FormHelperTest < Test::Unit::TestCase
     
     assert_dom_equal expected, _erbout
   end
-  
+
   def test_form_for_with_html_options_adds_options_to_form_tag
     _erbout = ''
     
@@ -469,13 +650,13 @@ class FormHelperTest < Test::Unit::TestCase
     
     assert_dom_equal expected, _erbout
   end
-  
+
   def test_form_for_with_string_url_option
     _erbout = ''
 
     form_for(:post, @post, :url => 'http://www.otherdomain.com') do |f| end
 
-    assert_equal 'http://www.otherdomain.com', @controller.url_for_options
+    assert_equal '<form action="http://www.otherdomain.com" method="post"></form>', _erbout
   end
 
   def test_form_for_with_hash_url_option
@@ -486,7 +667,85 @@ class FormHelperTest < Test::Unit::TestCase
     assert_equal 'controller', @controller.url_for_options[:controller]
     assert_equal 'action', @controller.url_for_options[:action]
   end
+
+  def test_form_for_with_record_url_option
+    _erbout = ''
+
+    form_for(:post, @post, :url => @post) do |f| end
+
+    expected = "<form action=\"/posts/123\" method=\"post\"></form>"
+    assert_equal expected, _erbout
+  end
+
+  def test_form_for_with_existing_object
+    _erbout = ''
+
+    form_for(@post) do |f| end
+
+    expected = "<form action=\"/posts/123\" class=\"edit_post\" id=\"edit_post_123\" method=\"post\"><div style=\"margin:0;padding:0\"><input name=\"_method\" type=\"hidden\" value=\"put\" /></div></form>"
+    assert_equal expected, _erbout
+  end
+
+  def test_form_for_with_new_object
+    _erbout = ''
+
+    post = Post.new
+    post.new_record = true
+    def post.id() nil end
+
+    form_for(post) do |f| end
+
+    expected = "<form action=\"/posts\" class=\"new_post\" id=\"new_post\" method=\"post\"></form>"
+    assert_equal expected, _erbout
+  end
+
+  def test_form_for_with_existing_object_in_list
+    @post.new_record = false
+    @comment.save
+    _erbout = ''
+    form_for([@post, @comment]) {}
+
+    expected = %(<form action="#{comment_path(@post, @comment)}" class="edit_comment" id="edit_comment_1" method="post"><div style="margin:0;padding:0"><input name="_method" type="hidden" value="put" /></div></form>)
+    assert_dom_equal expected, _erbout
+  end
+
+  def test_form_for_with_new_object_in_list
+    @post.new_record = false
+    _erbout = ''
+    form_for([@post, @comment]) {}
+
+    expected = %(<form action="#{comments_path(@post)}" class="new_comment" id="new_comment" method="post"></form>)
+    assert_dom_equal expected, _erbout
+  end
+
+  def test_form_for_with_existing_object_and_namespace_in_list
+    @post.new_record = false
+    @comment.save
+    _erbout = ''
+    form_for([:admin, @post, @comment]) {}
+  
+    expected = %(<form action="#{admin_comment_path(@post, @comment)}" class="edit_comment" id="edit_comment_1" method="post"><div style="margin:0;padding:0"><input name="_method" type="hidden" value="put" /></div></form>)
+    assert_dom_equal expected, _erbout
+  end
+  
+  def test_form_for_with_new_object_and_namespace_in_list
+    @post.new_record = false
+    _erbout = ''
+    form_for([:admin, @post, @comment]) {}
   
+    expected = %(<form action="#{admin_comments_path(@post)}" class="new_comment" id="new_comment" method="post"></form>)
+    assert_dom_equal expected, _erbout
+  end
+
+  def test_form_for_with_existing_object_and_custom_url
+    _erbout = ''
+
+    form_for(@post, :url => "/super_posts") do |f| end
+
+    expected = "<form action=\"/super_posts\" class=\"edit_post\" id=\"edit_post_123\" method=\"post\"><div style=\"margin:0;padding:0\"><input name=\"_method\" type=\"hidden\" value=\"put\" /></div></form>"
+    assert_equal expected, _erbout
+  end
+
   def test_remote_form_for_with_html_options_adds_options_to_form_tag
     self.extend ActionView::Helpers::PrototypeHelper
     _erbout = ''
@@ -496,4 +755,38 @@ class FormHelperTest < Test::Unit::TestCase
     
     assert_dom_equal expected, _erbout
   end
+
+
+  protected
+    def comments_path(post)
+      "/posts/#{post.id}/comments"
+    end
+    alias_method :post_comments_path, :comments_path
+
+    def comment_path(post, comment)
+      "/posts/#{post.id}/comments/#{comment.id}"
+    end
+    alias_method :post_comment_path, :comment_path
+    
+    def admin_comments_path(post)
+      "/admin/posts/#{post.id}/comments"
+    end
+    alias_method :admin_post_comments_path, :admin_comments_path
+    
+    def admin_comment_path(post, comment)
+      "/admin/posts/#{post.id}/comments/#{comment.id}"
+    end
+    alias_method :admin_post_comment_path, :admin_comment_path
+    
+    def posts_path
+      "/posts"
+    end 
+    
+    def post_path(post)
+      "/posts/#{post.id}"
+    end
+
+    def protect_against_forgery?
+      false
+    end
 end