actionpack 1.13.6 → 2.0.0

data/test/controller/components_test.rb

@@ -14,15 +14,15 @@ class CallerController < ActionController::Base
   end
 
   def calling_from_template
-    render_template "Ring, ring: <%= render_component(:controller => 'callee', :action => 'being_called') %>"
+    render :inline => "Ring, ring: <%= render_component(:controller => 'callee', :action => 'being_called') %>"
   end
 
   def internal_caller
-    render_template "Are you there? <%= render_component(:action => 'internal_callee') %>"
+    render :inline => "Are you there? <%= render_component(:action => 'internal_callee') %>"
   end
-  
+
   def internal_callee
-    render_text "Yes, ma'am"
+    render :text => "Yes, ma'am"
   end
 
   def set_flash
@@ -32,13 +32,13 @@ class CallerController < ActionController::Base
   def use_flash
     render_component(:controller => "callee", :action => "use_flash")
   end
-  
+
   def calling_redirected
     render_component(:controller => "callee", :action => "redirected")
   end
-  
+
   def calling_redirected_as_string
-    render_template "<%= render_component(:controller => 'callee', :action => 'redirected') %>"
+    render :inline => "<%= render_component(:controller => 'callee', :action => 'redirected') %>"
   end
 
   def rescue_action(e) raise end
@@ -46,22 +46,22 @@ end
 
 class CalleeController < ActionController::Base
   def being_called
-    render_text "#{params[:name] || "Lady"} of the House, speaking"
+    render :text => "#{params[:name] || "Lady"} of the House, speaking"
   end
-  
+
   def blowing_up
-    render_text "It's game over, man, just game over, man!", "500 Internal Server Error"
+    render :text => "It's game over, man, just game over, man!", :status => 500
   end
-  
+
   def set_flash
     flash[:notice] = 'My stoney baby'
     render :text => 'flash is set'
   end
-  
+
   def use_flash
     render :text => flash[:notice] || 'no flash'
   end
-  
+
   def redirected
     redirect_to :controller => "callee", :action => "being_called"
   end
@@ -85,7 +85,7 @@ class ComponentsTest < Test::Unit::TestCase
     get :calling_from_controller_with_params
     assert_equal "David of the House, speaking", @response.body
   end
-  
+
   def test_calling_from_controller_with_different_status_code
     get :calling_from_controller_with_different_status_code
     assert_equal 500, @response.response_code
@@ -95,12 +95,18 @@ class ComponentsTest < Test::Unit::TestCase
     get :calling_from_template
     assert_equal "Ring, ring: Lady of the House, speaking", @response.body
   end
-  
+
+  def test_etag_is_set_for_parent_template_when_calling_from_template
+    get :calling_from_template
+    expected_etag = etag_for("Ring, ring: Lady of the House, speaking")
+    assert_equal expected_etag, @response.headers['ETag']
+  end
+
   def test_internal_calling
     get :internal_caller
     assert_equal "Are you there? Yes, ma'am", @response.body
   end
-  
+
   def test_flash
     get :set_flash
     assert_equal 'My stoney baby', flash[:notice]
@@ -109,43 +115,26 @@ class ComponentsTest < Test::Unit::TestCase
     get :use_flash
     assert_equal 'no flash', @response.body
   end
-  
+
   def test_component_redirect_redirects
     get :calling_redirected
-    
+
     assert_redirected_to :action => "being_called"
   end
-  
+
   def test_component_multiple_redirect_redirects
     test_component_redirect_redirects
     test_internal_calling
   end
-  
-  def test_component_as_string_redirect_renders_redirecte_action
+
+  def test_component_as_string_redirect_renders_redirected_action
     get :calling_redirected_as_string
-    
-    assert_equal "Lady of the House, speaking", @response.body
-  end
-end
 
-module A
-  module B
-    module C
-      class NestedController < ActionController::Base
-        # Stub for uses_component_template_root
-        def self.caller
-          [ '/path/to/active_support/deprecation.rb:93:in `uses_component_template_root',
-            './test/fixtures/a/b/c/nested_controller.rb' ]
-        end
-      end
-    end
+    assert_equal "Lady of the House, speaking", @response.body
   end
-end
 
-class UsesComponentTemplateRootTest < Test::Unit::TestCase
-  def test_uses_component_template_root
-    assert_deprecated 'uses_component_template_root' do
-      assert_equal './test/fixtures/', A::B::C::NestedController.uses_component_template_root
+  protected
+    def etag_for(text)
+      %("#{Digest::MD5.hexdigest(text)}")
     end
-  end
 end

data/test/controller/content_type_test.rb

@@ -45,7 +45,7 @@ class ContentTypeController < ActionController::Base
   def rescue_action(e) raise end
 end
 
-ContentTypeController.template_root = File.dirname(__FILE__) + "/../fixtures/"
+ContentTypeController.view_paths = [ File.dirname(__FILE__) + "/../fixtures/" ]
 
 class ContentTypeTest < Test::Unit::TestCase
   def setup

data/test/controller/cookie_test.rb

@@ -2,19 +2,15 @@ require File.dirname(__FILE__) + '/../abstract_unit'
 
 class CookieTest < Test::Unit::TestCase
   class TestController < ActionController::Base
-    def authenticate_with_deprecated_writer
-      cookie "name" => "user_name", "value" => "david"
-    end
-
     def authenticate
       cookies["user_name"] = "david"
     end
 
-    def authenticate_for_fourten_days
+    def authenticate_for_fourteen_days
       cookies["user_name"] = { "value" => "david", "expires" => Time.local(2005, 10, 10) }
     end
 
-    def authenticate_for_fourten_days_with_symbols
+    def authenticate_for_fourteen_days_with_symbols
       cookies[:user_name] = { :value => "david", :expires => Time.local(2005, 10, 10) }
     end
 
@@ -33,7 +29,11 @@ class CookieTest < Test::Unit::TestCase
 
     def delete_cookie_with_path
       cookies.delete("user_name", :path => '/beaten')
-      render_text "hello world"
+      render :text => "hello world"
+    end
+
+    def authenticate_with_http_only
+      cookies["user_name"] = { :value => "david", :http_only => true }
     end
 
     def rescue_action(e) 
@@ -49,26 +49,27 @@ class CookieTest < Test::Unit::TestCase
     @request.host = "www.nextangle.com"
   end
 
-  def test_setting_cookie_with_deprecated_writer
-    get :authenticate_with_deprecated_writer
-    assert_equal [ CGI::Cookie::new("name" => "user_name", "value" => "david") ], @response.headers["cookie"]
-  end
-
   def test_setting_cookie
     get :authenticate
     assert_equal [ CGI::Cookie::new("name" => "user_name", "value" => "david") ], @response.headers["cookie"]
   end
 
   def test_setting_cookie_for_fourteen_days
-    get :authenticate_for_fourten_days
+    get :authenticate_for_fourteen_days
     assert_equal [ CGI::Cookie::new("name" => "user_name", "value" => "david", "expires" => Time.local(2005, 10, 10)) ], @response.headers["cookie"]
   end
 
   def test_setting_cookie_for_fourteen_days_with_symbols
-    get :authenticate_for_fourten_days
+    get :authenticate_for_fourteen_days
     assert_equal [ CGI::Cookie::new("name" => "user_name", "value" => "david", "expires" => Time.local(2005, 10, 10)) ], @response.headers["cookie"]
   end
 
+  def test_setting_cookie_with_http_only
+    get :authenticate_with_http_only
+    assert_equal [ CGI::Cookie::new("name" => "user_name", "value" => "david", "http_only" => true) ], @response.headers["cookie"]
+    assert_equal CGI::Cookie::new("name" => "user_name", "value" => "david", "path" => "/", "http_only" => true).to_s, @response.headers["cookie"].to_s
+  end
+
   def test_multiple_cookies
     get :set_multiple_cookies
     assert_equal 2, @response.cookies.size
@@ -104,4 +105,31 @@ class CookieTest < Test::Unit::TestCase
     assert_equal "/beaten", @response.headers["cookie"].first.path
     assert_not_equal "/", @response.headers["cookie"].first.path
   end
+
+  def test_cookie_to_s_simple_values
+    assert_equal 'myname=myvalue; path=', CGI::Cookie.new('myname', 'myvalue').to_s
+  end
+
+  def test_cookie_to_s_hash
+    cookie_str = CGI::Cookie.new(
+      'name' => 'myname',
+      'value' => 'myvalue',
+      'domain' => 'mydomain',
+      'path' => 'mypath',
+      'expires' => Time.utc(2007, 10, 20),
+      'secure' => true,
+      'http_only' => true).to_s
+    assert_equal 'myname=myvalue; domain=mydomain; path=mypath; expires=Sat, 20 Oct 2007 00:00:00 GMT; secure; HttpOnly', cookie_str
+  end
+
+  def test_cookie_to_s_hash_default_not_secure_not_http_only
+    cookie_str = CGI::Cookie.new(
+      'name' => 'myname',
+      'value' => 'myvalue',
+      'domain' => 'mydomain',
+      'path' => 'mypath',
+      'expires' => Time.utc(2007, 10, 20))
+    assert cookie_str !~ /secure/
+    assert cookie_str !~ /HttpOnly/
+  end
 end

data/test/controller/deprecation/deprecated_base_methods_test.rb

@@ -1,20 +1,7 @@
 require File.dirname(__FILE__) + '/../../abstract_unit'
 
 class DeprecatedBaseMethodsTest < Test::Unit::TestCase
-  # ActiveRecord model mock to test pagination deprecation
-  class DummyModel
-    def self.find(*args) [] end
-    def self.count(*args) 0 end
-  end
-
   class Target < ActionController::Base
-    def deprecated_symbol_parameter_to_url_for
-      redirect_to(url_for(:home_url, "superstars"))
-    end
-    
-    def deprecated_render_parameters
-      render "fun/games/hello_world"
-    end
     
     def home_url(greeting)
       "http://example.com/#{greeting}"
@@ -24,37 +11,15 @@ class DeprecatedBaseMethodsTest < Test::Unit::TestCase
       this_method_doesnt_exist
     end
 
-    def pagination
-      paginate :dummy_models, :class_name => 'DeprecatedBaseMethodsTest::DummyModel'
-      render :nothing => true
-    end
-
     def rescue_action(e) raise e end
   end
 
-  Target.template_root = File.dirname(__FILE__) + "/../../fixtures"
+  Target.view_paths = [ File.dirname(__FILE__) + "/../../fixtures" ]
 
   def setup
     @request    = ActionController::TestRequest.new
     @response   = ActionController::TestResponse.new
     @controller = Target.new
-    @controller.logger = Logger.new(nil) unless @controller.logger
-  end
-
-  def test_deprecated_symbol_parameter_to_url_for
-    assert_deprecated("url_for(:home_url)") do
-      get :deprecated_symbol_parameter_to_url_for
-    end
-
-    assert_redirected_to "http://example.com/superstars"
-  end
-  
-  def test_deprecated_render_parameters
-    assert_deprecated("render('fun/games/hello_world')") do
-      get :deprecated_render_parameters
-    end
-
-    assert_equal "Living in a nested world", @response.body
   end
 
   def test_log_error_silences_deprecation_warnings
@@ -69,10 +34,4 @@ class DeprecatedBaseMethodsTest < Test::Unit::TestCase
     error = Test::Unit::Error.new('testing ur doodz', e)
     assert_not_deprecated { error.message }
   end
-
-  def test_pagination_deprecation
-    assert_deprecated('svn://errtheblog.com/svn/plugins/classic_pagination') do
-      get :pagination
-    end
-  end
 end

data/test/controller/dispatcher_test.rb

@@ -0,0 +1,123 @@
+require "#{File.dirname(__FILE__)}/../abstract_unit"
+
+uses_mocha 'dispatcher tests' do
+
+require 'action_controller/dispatcher'
+
+class DispatcherTest < Test::Unit::TestCase
+  Dispatcher = ActionController::Dispatcher
+
+  def setup
+    @output = StringIO.new
+    ENV['REQUEST_METHOD'] = 'GET'
+
+    Dispatcher.callbacks[:prepare].clear
+    @dispatcher = Dispatcher.new(@output)
+  end
+
+  def teardown
+    ENV['REQUEST_METHOD'] = nil
+  end
+
+  def test_clears_dependencies_after_dispatch_if_in_loading_mode
+    Dependencies.stubs(:load?).returns(true)
+
+    ActionController::Routing::Routes.expects(:reload).once
+    Dependencies.expects(:clear).once
+
+    dispatch
+  end
+
+  def test_leaves_dependencies_after_dispatch_if_not_in_loading_mode
+    Dependencies.stubs(:load?).returns(false)
+
+    ActionController::Routing::Routes.expects(:reload).never
+    Dependencies.expects(:clear).never
+
+    dispatch
+  end
+
+  def test_failsafe_response
+    CGI.expects(:new).raises('some multipart parsing failure')
+
+    ActionController::Routing::Routes.stubs(:reload)
+    Dispatcher.stubs(:log_failsafe_exception)
+
+    assert_nothing_raised { dispatch }
+
+    assert_equal "Status: 400 Bad Request\r\nContent-Type: text/html\r\n\r\n<html><body><h1>400 Bad Request</h1></body></html>", @output.string
+  end
+
+  def test_reload_application_sets_unprepared_if_loading_dependencies
+    Dependencies.stubs(:load?).returns(false)
+    ActionController::Routing::Routes.expects(:reload).never
+    @dispatcher.unprepared = false
+    @dispatcher.send!(:reload_application)
+    assert !@dispatcher.unprepared
+
+    Dependencies.stubs(:load?).returns(true)
+    ActionController::Routing::Routes.expects(:reload).once
+    @dispatcher.send!(:reload_application)
+    assert @dispatcher.unprepared
+  end
+
+  def test_prepare_application_runs_callbacks_if_unprepared
+    a = b = c = nil
+    Dispatcher.to_prepare { a = b = c = 1 }
+    Dispatcher.to_prepare { b = c = 2 }
+    Dispatcher.to_prepare { c = 3 }
+
+    # Skip the callbacks when already prepared.
+    @dispatcher.unprepared = false
+    @dispatcher.send! :prepare_application
+    assert_nil a || b || c
+
+    # Perform the callbacks when unprepared.
+    @dispatcher.unprepared = true
+    @dispatcher.send! :prepare_application
+    assert_equal 1, a
+    assert_equal 2, b
+    assert_equal 3, c
+
+    # But when not :load, make sure they are only run once
+    a = b = c = nil
+    @dispatcher.send! :prepare_application
+    assert_nil a || b || c
+  end
+
+  def test_to_prepare_with_identifier_replaces
+    a = b = nil
+    Dispatcher.to_prepare(:unique_id) { a = b = 1 }
+    Dispatcher.to_prepare(:unique_id) { a = 2 }
+
+    @dispatcher.unprepared = true
+    @dispatcher.send! :prepare_application
+    assert_equal 2, a
+    assert_equal nil, b
+  end
+
+  def test_to_prepare_only_runs_once_if_not_loading_dependencies
+    Dependencies.stubs(:load?).returns(false)
+    called = 0
+    Dispatcher.to_prepare(:unprepared_test) { called += 1 }
+    2.times { dispatch }
+    assert_equal 1, called
+  end
+
+  private
+    def dispatch(output = @output)
+      controller = mock
+      controller.stubs(:process).returns(controller)
+      controller.stubs(:out).with(output).returns('response')
+
+      ActionController::Routing::Routes.stubs(:recognize).returns(controller)
+
+      Dispatcher.dispatch(nil, {}, output)
+    end
+
+    def assert_subclasses(howmany, klass, message = klass.subclasses.inspect)
+      assert_equal howmany, klass.subclasses.size, message
+    end
+end
+
+end