actionpack 1.13.6 → 2.0.0

data/test/controller/new_render_test.rb

@@ -1,6 +1,8 @@
 require File.dirname(__FILE__) + '/../abstract_unit'
+require File.dirname(__FILE__) + '/fake_models'
 
-silence_warnings { Customer = Struct.new("Customer", :name) }
+class CustomersController < ActionController::Base
+end
 
 module Fun
   class GamesController < ActionController::Base
@@ -60,12 +62,12 @@ class NewRenderTestController < ActionController::Base
 
   def render_file_with_instance_variables
     @secret = 'in the sauce'
-    path = File.join(File.dirname(__FILE__), '../fixtures/test/render_file_with_ivar.rhtml')
+    path = File.join(File.dirname(__FILE__), '../fixtures/test/render_file_with_ivar.erb')
     render :file => path
   end
 
   def render_file_with_locals
-    path = File.join(File.dirname(__FILE__), '../fixtures/test/render_file_with_locals.rhtml')
+    path = File.join(File.dirname(__FILE__), '../fixtures/test/render_file_with_locals.erb')
     render :file => path, :locals => {:secret => 'in the sauce'} 
   end
 
@@ -150,15 +152,27 @@ class NewRenderTestController < ActionController::Base
   def partial_with_hash_object
     render :partial => "hash_object", :object => {:first_name => "Sam"}
   end
-
+  
+  def partial_hash_collection
+    render :partial => "hash_object", :collection => [ {:first_name => "Pratik"}, {:first_name => "Amy"} ]
+  end
+  
+  def partial_hash_collection_with_locals
+    render :partial => "hash_greeting", :collection => [ {:first_name => "Pratik"}, {:first_name => "Amy"} ], :locals => { :greeting => "Hola" }
+  end
+  
   def partial_with_implicit_local_assignment
     @customer = Customer.new("Marcel")
     render :partial => "customer"
   end
   
+  def missing_partial
+    render :partial => 'thisFileIsntHere'
+  end
+  
   def hello_in_a_string
     @customers = [ Customer.new("david"), Customer.new("mary") ]
-    render :text =>  "How's there? #{render_to_string("test/list")}"
+    render :text =>  "How's there? " << render_to_string(:template => "test/list")
   end
   
   def render_to_string_with_assigns
@@ -197,7 +211,7 @@ class NewRenderTestController < ActionController::Base
   end
 
   def render_with_explicit_template
-    render "test/hello_world"
+    render :template => "test/hello_world"
   end
 
   def double_render
@@ -227,11 +241,11 @@ class NewRenderTestController < ActionController::Base
   end
 
   def hello_world_from_rxml_using_action
-    render :action => "hello_world.rxml"
+    render :action => "hello_world.builder"
   end
 
   def hello_world_from_rxml_using_template
-    render :template => "test/hello_world.rxml"
+    render :template => "test/hello_world.builder"
   end
 
   def head_with_location_header
@@ -258,6 +272,25 @@ class NewRenderTestController < ActionController::Base
     head :forbidden, :x_custom_header => "something"
   end
 
+  def render_with_location
+    render :xml => "<hello/>", :location => "http://example.com", :status => 201
+  end
+  
+  def render_with_object_location
+    customer = Customer.new("Some guy", 1)
+    render :xml => "<customer/>", :location => customer_url(customer), :status => :created
+  end
+
+  def render_with_to_xml
+    to_xmlable = Class.new do
+      def to_xml
+        "<i-am-xml/>"
+      end
+    end.new
+    
+    render :xml => to_xmlable
+  end
+
   helper NewRenderTestHelper
   helper do 
     def rjs_helper_method(value)
@@ -324,6 +357,14 @@ class NewRenderTestController < ActionController::Base
     render :text => "hello world!"
   end
 
+  def render_call_to_partial_with_layout
+    render :action => "calling_partial_with_layout"
+  end
+
+  def render_using_layout_around_block
+    render :action => "using_layout_around_block"
+  end
+
   def rescue_action(e) raise end
     
   private
@@ -350,8 +391,8 @@ class NewRenderTestController < ActionController::Base
     end
 end
 
-NewRenderTestController.template_root = File.dirname(__FILE__) + "/../fixtures/"
-Fun::GamesController.template_root = File.dirname(__FILE__) + "/../fixtures/"
+NewRenderTestController.view_paths = [ File.dirname(__FILE__) + "/../fixtures/" ]
+Fun::GamesController.view_paths = [ File.dirname(__FILE__) + "/../fixtures/" ]
 
 class NewRenderTest < Test::Unit::TestCase
   def setup
@@ -460,14 +501,9 @@ class NewRenderTest < Test::Unit::TestCase
     ActionController::Base.protected_variables_cache = nil
 
     get :hello_world
-    assert assigns.include?('request'), 'request should be in assigns'
-    assert_deprecated 'request' do
-      assert_kind_of ActionController::AbstractRequest, assigns['request']
-    end
-    assert_not_deprecated do
-      assert_kind_of ActionController::AbstractRequest, @response.template.request
-      assert_kind_of ActionController::AbstractRequest, assigns['_request']
-    end
+    assert !assigns.include?('request'), 'request should not be in assigns'
+    assert_kind_of ActionController::AbstractRequest, assigns['_request']
+    assert_kind_of ActionController::AbstractRequest, @response.template.request
 
   ensure
     ActionController::Base.view_controller_internals = view_internals_old_value
@@ -594,7 +630,7 @@ EOS
   end
 
   def test_render_with_explicit_template
-    assert_deprecated(/render/) { get :render_with_explicit_template }
+    get :render_with_explicit_template
     assert_response :success
   end
 
@@ -653,7 +689,17 @@ EOS
 
   def test_partial_with_hash_object
     get :partial_with_hash_object
-    assert_equal "Sam", @response.body
+    assert_equal "Sam\nmaS\n", @response.body
+  end
+  
+  def test_hash_partial_collection
+    get :partial_hash_collection
+    assert_equal "Pratik\nkitarP\nAmy\nymA\n", @response.body
+  end
+  
+  def test_partial_hash_collection_with_locals
+    get :partial_hash_collection_with_locals
+    assert_equal "Hola: PratikHola: Amy", @response.body
   end
 
   def test_partial_with_implicit_local_assignment
@@ -661,6 +707,12 @@ EOS
     assert_equal "Hello: Marcel", @response.body
   end
   
+  def test_render_missing_partial_template
+    assert_raises(ActionView::ActionViewError) do
+      get :missing_partial
+    end
+  end
+  
   def test_render_text_with_assigns
     get :render_text_with_assigns
     assert_equal "world", assigns["hello"]
@@ -669,14 +721,14 @@ EOS
   def test_update_page
     get :update_page
     assert_template nil
-    assert_equal 'text/javascript; charset=utf-8', @response.headers['Content-Type']
+    assert_equal 'text/javascript; charset=utf-8', @response.headers['type']
     assert_equal 2, @response.body.split($/).length
   end
   
   def test_update_page_with_instance_variables
     get :update_page_with_instance_variables
     assert_template nil
-    assert_equal 'text/javascript; charset=utf-8', @response.headers['Content-Type']
+    assert_equal 'text/javascript; charset=utf-8', @response.headers['type']
     assert_match /balance/, @response.body
     assert_match /\$37/, @response.body
   end
@@ -747,4 +799,34 @@ EOS
     assert_equal "something", @response.headers["X-Custom-Header"]
     assert_response :forbidden
   end
+
+  def test_rendering_with_location_should_set_header
+    get :render_with_location
+    assert_equal "http://example.com", @response.headers["Location"]
+  end
+  
+  def test_rendering_xml_should_call_to_xml_if_possible
+    get :render_with_to_xml
+    assert_equal "<i-am-xml/>", @response.body
+  end
+  
+  def test_rendering_with_object_location_should_set_header_with_url_for
+    ActionController::Routing::Routes.draw do |map|
+      map.resources :customers
+      map.connect ':controller/:action/:id'
+    end
+
+    get :render_with_object_location
+    assert_equal "http://www.nextangle.com/customers/1", @response.headers["Location"]
+  end
+
+  def test_render_call_to_partial_with_layout
+    get :render_call_to_partial_with_layout
+    assert_equal "Before (David)\nInside from partial (David)\nAfter", @response.body
+  end
+  
+  def test_using_layout_around_block
+    get :using_layout_around_block
+    assert_equal "Before (David)\nInside from block\nAfter", @response.body
+  end
 end

data/test/controller/polymorphic_routes_test.rb

@@ -0,0 +1,98 @@
+require File.dirname(__FILE__) + '/../abstract_unit'
+
+class Article
+  attr_reader :id
+  def save; @id = 1 end
+  def new_record?; @id.nil? end
+  def name
+    @id.nil? ? 'new post' : "post ##{@id}"
+  end
+end
+
+class Comment
+  attr_reader :id
+  def post_id; 1 end
+  def save; @id = 1 end
+  def new_record?; @id.nil? end
+  def name
+    @id.nil? ? 'new comment' : "comment ##{@id}"
+  end
+end
+
+class Comment::Nested < Comment; end
+
+class Test::Unit::TestCase
+  protected
+  def articles_url
+    'http://www.example.com/articles'
+  end
+  alias_method :new_article_url, :articles_url
+  
+  def article_url(article)
+    "http://www.example.com/articles/#{article.id}"
+  end
+
+  def article_comments_url(article)
+    "http://www.example.com/articles/#{article.id}/comments"
+  end
+  
+  def article_comment_url(article, comment)
+    "http://www.example.com/articles/#{article.id}/comments/#{comment.id}"
+  end
+  
+  def admin_articles_url
+    "http://www.example.com/admin/articles"
+  end
+  alias_method :new_admin_article_url, :admin_articles_url
+  
+  def admin_article_url(article)
+    "http://www.example.com/admin/articles/#{article.id}"
+  end
+  
+  def admin_article_comments_url(article)
+    "http://www.example.com/admin/articles/#{article.id}/comments"
+  end
+  
+  def admin_article_comment_url(article, comment)
+    "http://www.example.com/admin/test/articles/#{article.id}/comments/#{comment.id}"
+  end
+end
+
+
+class PolymorphicRoutesTest < Test::Unit::TestCase
+  include ActionController::PolymorphicRoutes
+
+  def setup
+    @article = Article.new
+    @comment = Comment.new
+  end
+  
+  def test_with_record
+    assert_equal(articles_url, polymorphic_url(@article, :action => 'new'))
+    assert_equal(articles_url, polymorphic_url(@article))
+    @article.save
+    assert_equal(article_url(@article), polymorphic_url(@article))
+  end
+  
+  # TODO: Needs to be updated to correctly know about whether the object is in a hash or not
+  def xtest_with_hash
+    @article.save
+    assert_equal(article_url(@article), polymorphic_url(:id => @article))
+  end
+
+  def test_with_array
+    assert_equal(article_comments_url(@article), polymorphic_url([@article, @comment]))
+    @comment.save
+    assert_equal(article_comment_url(@article, @comment), polymorphic_url([@article, @comment]))
+  end  
+  
+  def test_with_array_and_namespace
+    assert_equal(admin_articles_url, polymorphic_url([:admin, @article], :action => 'new'))
+    assert_equal(admin_articles_url, polymorphic_url([:admin, @article]))
+    @article.save
+    assert_equal(admin_article_url(@article), polymorphic_url([:admin, @article]))
+    assert_equal(admin_article_comments_url(@article), polymorphic_url([:admin, @article, @comment]))
+    @comment.save
+    assert_equal(admin_article_comment_url(@article, @comment), polymorphic_url([:admin, @article, @comment]))
+  end
+end

data/test/controller/record_identifier_test.rb

@@ -0,0 +1,103 @@
+require File.dirname(__FILE__) + '/../abstract_unit'
+
+class Comment
+  attr_reader :id
+  def save; @id = 1 end
+  def new_record?; @id.nil? end
+  def name
+    @id.nil? ? 'new comment' : "comment ##{@id}"
+  end
+end
+
+class Comment::Nested < Comment; end
+
+class Test::Unit::TestCase
+  protected
+    def comments_url
+      'http://www.example.com/comments'
+    end
+    
+    def comment_url(comment)
+      "http://www.example.com/comments/#{comment.id}"
+    end
+end
+
+
+class RecordIdentifierTest < Test::Unit::TestCase
+  include ActionController::RecordIdentifier
+
+  def setup
+    @klass  = Comment
+    @record = @klass.new
+    @singular = 'comment'
+    @plural = 'comments'
+  end
+
+  def test_dom_id_with_new_record
+    assert_equal "new_#{@singular}", dom_id(@record)
+  end
+
+  def test_dom_id_with_new_record_and_prefix
+    assert_equal "custom_prefix_#{@singular}", dom_id(@record, :custom_prefix)
+  end
+
+  def test_dom_id_with_saved_record
+    @record.save
+    assert_equal "#{@singular}_1", dom_id(@record)
+  end
+
+  def test_dom_id_with_prefix
+    @record.save
+    assert_equal "edit_#{@singular}_1", dom_id(@record, :edit)
+  end
+
+  def test_partial_path
+    expected = "#{@plural}/#{@singular}"
+    assert_equal expected, partial_path(@record)
+    assert_equal expected, partial_path(Comment)
+  end
+
+  def test_dom_class
+    assert_equal @singular, dom_class(@record)
+  end
+  
+  def test_dom_class_with_prefix
+    assert_equal "custom_prefix_#{@singular}", dom_class(@record, :custom_prefix)
+  end
+
+  def test_singular_class_name
+    assert_equal @singular, singular_class_name(@record)
+  end
+
+  def test_singular_class_name_for_class
+    assert_equal @singular, singular_class_name(@klass)
+  end
+
+  def test_plural_class_name
+    assert_equal @plural, plural_class_name(@record)
+  end
+
+  def test_plural_class_name_for_class
+    assert_equal @plural, plural_class_name(@klass)
+  end
+
+  private
+    def method_missing(method, *args)
+      RecordIdentifier.send(method, *args)
+    end
+end
+
+class NestedRecordIdentifierTest < RecordIdentifierTest
+  def setup
+    @klass  = Comment::Nested
+    @record = @klass.new
+    @singular = 'comment_nested'
+    @plural = 'comment_nesteds'
+  end
+
+  def test_partial_path
+    expected = "comment/nesteds/nested"
+    assert_equal expected, partial_path(@record)
+    assert_equal expected, partial_path(Comment::Nested)
+  end
+end

data/test/controller/redirect_test.rb

@@ -1,14 +1,57 @@
 require File.dirname(__FILE__) + '/../abstract_unit'
 
+class WorkshopsController < ActionController::Base
+end
+
+class Workshop
+  attr_accessor :id, :new_record
+
+  def initialize(id, new_record)
+    @id, @new_record = id, new_record
+  end
+  
+  def new_record?
+    @new_record
+  end
+  
+  def to_s
+    id.to_s
+  end
+end
+
 class RedirectController < ActionController::Base
   def simple_redirect
     redirect_to :action => "hello_world"
   end
-  
-  def method_redirect
-    redirect_to :dashbord_url, 1, "hello"
+
+  def redirect_with_status 
+    redirect_to({:action => "hello_world", :status => 301})
+  end 
+
+  def redirect_with_status_hash
+    redirect_to({:action => "hello_world"}, {:status => 301})
+  end 
+
+  def url_redirect_with_status 
+    redirect_to("http://www.example.com", :status => :moved_permanently)
+  end 
+   
+  def url_redirect_with_status_hash 
+    redirect_to("http://www.example.com", {:status => 301})
+  end 
+
+  def relative_url_redirect_with_status 
+    redirect_to("/things/stuff", :status => :found)
+  end 
+   
+  def relative_url_redirect_with_status_hash
+    redirect_to("/things/stuff", {:status => 301})
+  end 
+   
+  def redirect_to_back_with_status 
+    redirect_to :back, :status => 307 
   end
-  
+
   def host_redirect
     redirect_to :action => "other_host", :only_path => false, :host => 'other.test.host'
   end
@@ -26,6 +69,14 @@ class RedirectController < ActionController::Base
     redirect_to :back
   end
 
+  def redirect_to_existing_record
+    redirect_to Workshop.new(5, false)
+  end
+
+  def redirect_to_new_record
+    redirect_to Workshop.new(5, true)
+  end
+
   def rescue_errors(e) raise e end
     
   def rescue_action(e) raise end
@@ -49,10 +100,54 @@ class RedirectTest < Test::Unit::TestCase
     assert_equal "http://test.host/redirect/hello_world", redirect_to_url
   end
 
-  def test_redirect_with_method_reference_and_parameters
-    assert_deprecated(/redirect_to/) { get :method_redirect }
-    assert_response :redirect
-    assert_equal "http://test.host/redirect/dashboard/1?message=hello", redirect_to_url
+  def test_redirect_with_no_status
+    get :simple_redirect
+    assert_response 302
+    assert_equal "http://test.host/redirect/hello_world", redirect_to_url
+  end
+
+  def test_redirect_with_status 
+    get :redirect_with_status 
+    assert_response 301 
+    assert_equal "http://test.host/redirect/hello_world", redirect_to_url 
+  end 
+
+  def test_redirect_with_status_hash 
+    get :redirect_with_status_hash
+    assert_response 301 
+    assert_equal "http://test.host/redirect/hello_world", redirect_to_url 
+  end
+   
+  def test_url_redirect_with_status 
+    get :url_redirect_with_status 
+    assert_response 301 
+    assert_equal "http://www.example.com", redirect_to_url 
+  end 
+
+  def test_url_redirect_with_status_hash
+    get :url_redirect_with_status_hash
+    assert_response 301 
+    assert_equal "http://www.example.com", redirect_to_url 
+  end 
+
+  
+  def test_relative_url_redirect_with_status 
+    get :relative_url_redirect_with_status 
+    assert_response 302
+    assert_equal "http://test.host/things/stuff", redirect_to_url 
+  end 
+   
+  def test_relative_url_redirect_with_status_hash
+    get :relative_url_redirect_with_status_hash
+    assert_response 301 
+    assert_equal "http://test.host/things/stuff", redirect_to_url 
+  end   
+   
+  def test_redirect_to_back_with_status 
+    @request.env["HTTP_REFERER"] = "http://www.example.com/coming/from" 
+    get :redirect_to_back_with_status 
+    assert_response 307 
+    assert_equal "http://www.example.com/coming/from", redirect_to_url 
   end
 
   def test_simple_redirect_using_options
@@ -67,11 +162,11 @@ class RedirectTest < Test::Unit::TestCase
     begin
       assert_redirected_to :action => "other_host", :only_path => true
     rescue Test::Unit::AssertionFailedError => err
-      redirection_msg, diff_msg = err.message.scan(/<\{[^\}]+\}>/).collect { |s| s[2..-3] }
+      expected_msg, redirection_msg, diff_msg = err.message.scan(/<\{[^\}]+\}>/).collect { |s| s[2..-3] }
       assert_match %r("only_path"=>false),        redirection_msg
       assert_match %r("host"=>"other.test.host"), redirection_msg
       assert_match %r("action"=>"other_host"),    redirection_msg
-      assert_match %r("only_path"=>true),         diff_msg
+      assert_match %r("only_path"=>false),        diff_msg
       assert_match %r("host"=>"other.test.host"), diff_msg
     end
   end
@@ -107,6 +202,19 @@ class RedirectTest < Test::Unit::TestCase
       get :redirect_to_back
     }
   end
+  
+  def test_redirect_to_record
+    ActionController::Routing::Routes.draw do |map|
+      map.resources :workshops
+      map.connect ':controller/:action/:id'
+    end
+    
+    get :redirect_to_existing_record
+    assert_equal "http://test.host/workshops/5", redirect_to_url
+
+    get :redirect_to_new_record
+    assert_equal "http://test.host/workshops", redirect_to_url
+  end
 end
 
 module ModuleTest
@@ -122,19 +230,13 @@ module ModuleTest
       @request    = ActionController::TestRequest.new
       @response   = ActionController::TestResponse.new
     end
-  
+
     def test_simple_redirect
       get :simple_redirect
       assert_response :redirect
       assert_equal "http://test.host/module_test/module_redirect/hello_world", redirect_to_url
     end
-  
-    def test_redirect_with_method_reference_and_parameters
-      assert_deprecated(/redirect_to/) { get :method_redirect }
-      assert_response :redirect
-      assert_equal "http://test.host/module_test/module_redirect/dashboard/1?message=hello", redirect_to_url
-    end
-    
+
     def test_simple_redirect_using_options
       get :host_redirect
       assert_response :redirect