xai-review 0.26.0__py3-none-any.whl → 0.28.0__py3-none-any.whl

ai_review/tests/suites/services/vcs/gitlab/test_adapter.py

@@ -0,0 +1,105 @@
+from ai_review.clients.gitlab.mr.schema.discussions import (
+    GitLabDiscussionSchema,
+    GitLabDiscussionPositionSchema,
+)
+from ai_review.clients.gitlab.mr.schema.notes import GitLabNoteSchema
+from ai_review.clients.gitlab.mr.schema.user import GitLabUserSchema
+from ai_review.services.vcs.gitlab.adapter import get_review_comment_from_gitlab_note
+from ai_review.services.vcs.types import ReviewCommentSchema, UserSchema
+
+
+def test_maps_all_fields_correctly():
+    """Should map GitLab note and discussion into ReviewCommentSchema."""
+    note = GitLabNoteSchema(
+        id=123,
+        body="Looks good!",
+        author=GitLabUserSchema(id=10, name="Alice", username="alice"),
+    )
+    discussion = GitLabDiscussionSchema(
+        id="42",
+        notes=[note],
+        position=GitLabDiscussionPositionSchema(
+            base_sha="AAA000",
+            head_sha="BBB111",
+            start_sha="CCC222",
+            new_path="src/app.py",
+            new_line=15,
+        )
+    )
+
+    result = get_review_comment_from_gitlab_note(note, discussion)
+
+    assert isinstance(result, ReviewCommentSchema)
+    assert result.id == 123
+    assert result.body == "Looks good!"
+    assert result.file == "src/app.py"
+    assert result.line == 15
+    assert result.thread_id == "42"
+
+    assert isinstance(result.author, UserSchema)
+    assert result.author.id == 10
+    assert result.author.name == "Alice"
+    assert result.author.username == "alice"
+
+
+def test_maps_with_missing_author():
+    """Should handle note without author gracefully (default empty UserSchema)."""
+    note = GitLabNoteSchema(id=1, body="Anonymous comment", author=None)
+    discussion = GitLabDiscussionSchema(
+        id="7",
+        notes=[note],
+        position=GitLabDiscussionPositionSchema(
+            base_sha="AAA000",
+            head_sha="BBB111",
+            start_sha="CCC222",
+            new_path="main.py",
+            new_line=3,
+        ),
+    )
+
+    result = get_review_comment_from_gitlab_note(note, discussion)
+
+    assert isinstance(result.author, UserSchema)
+    assert result.author.id is None
+    assert result.author.name == ""
+    assert result.author.username == ""
+
+
+def test_maps_with_missing_position():
+    """Should handle discussion without position gracefully (file/line become None)."""
+    note = GitLabNoteSchema(
+        id=55,
+        body="General comment",
+        author=GitLabUserSchema(id=9, name="Bob", username="bob"),
+    )
+    discussion = GitLabDiscussionSchema(
+        id="999",
+        notes=[note],
+        position=None,
+    )
+
+    result = get_review_comment_from_gitlab_note(note, discussion)
+
+    assert isinstance(result, ReviewCommentSchema)
+    assert result.file is None
+    assert result.line is None
+    assert result.thread_id == "999"
+
+
+def test_maps_with_empty_body_and_defaults():
+    """Should default body to empty string when note.body is empty string."""
+    note = GitLabNoteSchema(id=12, body="", author=None)
+    discussion = GitLabDiscussionSchema(
+        id="100",
+        notes=[note],
+        position=None,
+    )
+
+    result = get_review_comment_from_gitlab_note(note, discussion)
+
+    assert isinstance(result, ReviewCommentSchema)
+    assert result.body == ""
+    assert result.file is None
+    assert result.line is None
+    assert result.thread_id == "100"
+    assert isinstance(result.author, UserSchema)

ai_review/tests/suites/services/vcs/gitlab/{test_service.py → test_client.py}

@@ -1,7 +1,7 @@
 import pytest
 
 from ai_review.services.vcs.gitlab.client import GitLabVCSClient
-from ai_review.services.vcs.types import ReviewInfoSchema, ReviewCommentSchema
+from ai_review.services.vcs.types import ReviewInfoSchema, ReviewCommentSchema, ReviewThreadSchema, ThreadKind
 from ai_review.tests.fixtures.clients.gitlab import FakeGitLabMergeRequestsHTTPClient
 
 
@@ -52,6 +52,15 @@ async def test_get_general_comments_returns_expected_list(
     assert "General comment" in bodies
     assert "Another note" in bodies
 
+    authors = {comment.author.username for comment in comments}
+    assert authors == {"charlie", "diana"}
+
+    for comment in comments:
+        assert comment.thread_id == comment.id
+        assert comment.author.id is not None
+        assert comment.author.name != ""
+        assert comment.author.username != ""
+
     called_methods = [name for name, _ in fake_gitlab_merge_requests_http_client.calls]
     assert called_methods == ["get_notes"]
 
@@ -121,3 +130,92 @@ async def test_create_inline_comment_posts_comment(
     assert call_args["body"] == "Looks good!"
     assert call_args["project_id"] == "project-id"
     assert call_args["merge_request_id"] == "merge-request-id"
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("gitlab_http_client_config")
+async def test_create_inline_reply_posts_comment(
+        gitlab_vcs_client: GitLabVCSClient,
+        fake_gitlab_merge_requests_http_client: FakeGitLabMergeRequestsHTTPClient,
+):
+    """Should reply to an existing inline discussion."""
+    thread_id = "discussion-1"
+    message = "I agree with this point."
+
+    await gitlab_vcs_client.create_inline_reply(thread_id, message)
+
+    call = next(
+        args for name, args in fake_gitlab_merge_requests_http_client.calls
+        if name == "create_discussion_reply"
+    )
+
+    assert call["discussion_id"] == thread_id
+    assert call["body"] == message
+    assert call["project_id"] == "project-id"
+    assert call["merge_request_id"] == "merge-request-id"
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("gitlab_http_client_config")
+async def test_create_summary_reply_uses_general_comment_method(
+        gitlab_vcs_client: GitLabVCSClient,
+        fake_gitlab_merge_requests_http_client: FakeGitLabMergeRequestsHTTPClient,
+):
+    """Should reuse create_general_comment when replying to summary thread."""
+    thread_id = "summary-1"
+    message = "Thanks for clarifying."
+
+    await gitlab_vcs_client.create_summary_reply(thread_id, message)
+
+    call = next(
+        args for name, args in fake_gitlab_merge_requests_http_client.calls
+        if name == "create_note"
+    )
+
+    assert call["body"] == message
+    assert call["project_id"] == "project-id"
+    assert call["merge_request_id"] == "merge-request-id"
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("gitlab_http_client_config")
+async def test_get_inline_threads_returns_valid_schema(
+        gitlab_vcs_client: GitLabVCSClient,
+        fake_gitlab_merge_requests_http_client: FakeGitLabMergeRequestsHTTPClient,
+):
+    """Should transform GitLab discussions into inline threads with proper fields."""
+    threads = await gitlab_vcs_client.get_inline_threads()
+
+    assert all(isinstance(t, ReviewThreadSchema) for t in threads)
+    assert len(threads) == 1
+
+    thread = threads[0]
+    assert thread.id == "discussion-1"
+    assert thread.kind == ThreadKind.INLINE
+    assert thread.file == "src/app.py"
+    assert thread.line == 12
+    assert len(thread.comments) == 2
+    assert isinstance(thread.comments[0], ReviewCommentSchema)
+
+    called = [name for name, _ in fake_gitlab_merge_requests_http_client.calls]
+    assert "get_discussions" in called
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("gitlab_http_client_config")
+async def test_get_general_threads_wraps_comments_in_threads(
+        gitlab_vcs_client: GitLabVCSClient,
+        fake_gitlab_merge_requests_http_client: FakeGitLabMergeRequestsHTTPClient,
+):
+    """Should wrap each general MR note into its own SUMMARY thread."""
+    threads = await gitlab_vcs_client.get_general_threads()
+
+    assert len(threads) == 2
+    for thread in threads:
+        assert isinstance(thread, ReviewThreadSchema)
+        assert thread.kind == ThreadKind.SUMMARY
+        assert len(thread.comments) == 1
+        assert isinstance(thread.comments[0], ReviewCommentSchema)
+
+    called = [name for name, _ in fake_gitlab_merge_requests_http_client.calls]
+    assert "get_notes" in called

{xai_review-0.26.0.dist-info → xai_review-0.28.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: xai-review
-Version: 0.26.0
+Version: 0.28.0
 Summary: AI-powered code review tool
 Author-email: Nikita Filonov <nikita.filonov@example.com>
 Maintainer-email: Nikita Filonov <nikita.filonov@example.com>
@@ -69,12 +69,14 @@ improve code quality, enforce consistency, and speed up the review process.
 - **Multiple LLM providers** — choose between **OpenAI**, **Claude**, **Gemini**, or **Ollama**, and switch anytime.
 - **VCS integration** — works out of the box with **GitLab**, **GitHub**, and **Bitbucket**.
 - **Customizable prompts** — adapt inline, context, and summary reviews to match your team’s coding guidelines.
+- **Reply modes** — AI can now **participate in existing review threads**, adding follow-up replies in both inline and
+  summary discussions.
 - **Flexible configuration** — supports `YAML`, `JSON`, and `ENV`, with seamless overrides in CI/CD pipelines.
 - **AI Review runs fully client-side** — it never proxies or inspects your requests.
 
-AI Review runs automatically in your CI/CD pipeline and posts both **inline comments** and **summary reviews** right
-inside your merge requests. This makes reviews faster, more consistent, and less error-prone — while still leaving the
-final decision to human reviewers.
+AI Review runs automatically in your CI/CD pipeline and posts both **inline comments**, **summary reviews**, and now *
+*AI-generated replies** directly inside your merge requests. This makes reviews faster, more conversational, and still
+fully under human control.
 
 ---
 
@@ -209,7 +211,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: Nikita-Filonov/ai-review@v0.26.0
+      - uses: Nikita-Filonov/ai-review@v0.28.0
         with:
           review-command: ${{ inputs.review-command }}
         env:
@@ -274,6 +276,7 @@ ai-review:
 See these folders for reference templates and full configuration options:
 
 - [./docs/ci](./docs/ci) — CI/CD integration templates (GitHub Actions, GitLab CI)
+- [./docs/cli](./docs/cli) — CLI command reference and usage examples
 - [./docs/hooks](./docs/hooks) — hook reference and lifecycle events
 - [./docs/configs](./docs/configs) — full configuration examples (`.yaml`, `.json`, `.env`)
 - [./docs/prompts](./docs/prompts) — prompt templates for Python/Go (light & strict modes)