xai-review 0.26.0__py3-none-any.whl → 0.28.0__py3-none-any.whl

ai_review/tests/suites/services/review/runner/test_context.py

@@ -0,0 +1,89 @@
+import pytest
+
+from ai_review.services.review.runner.context import ContextReviewRunner
+from ai_review.tests.fixtures.services.cost import FakeCostService
+from ai_review.tests.fixtures.services.diff import FakeDiffService
+from ai_review.tests.fixtures.services.prompt import FakePromptService
+from ai_review.tests.fixtures.services.review.gateway.comment import FakeReviewCommentGateway
+from ai_review.tests.fixtures.services.review.gateway.llm import FakeReviewLLMGateway
+from ai_review.tests.fixtures.services.review.internal.inline import FakeInlineCommentService
+from ai_review.tests.fixtures.services.review.internal.policy import FakeReviewPolicyService
+from ai_review.tests.fixtures.services.vcs import FakeVCSClient
+
+
+@pytest.mark.asyncio
+async def test_run_happy_path(
+        context_review_runner: ContextReviewRunner,
+        fake_vcs_client: FakeVCSClient,
+        fake_diff_service: FakeDiffService,
+        fake_cost_service: FakeCostService,
+        fake_prompt_service: FakePromptService,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_policy_service: FakeReviewPolicyService,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should render all changed files, call LLM and post inline comments."""
+    await context_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+
+    assert any(call[0] == "render_files" for call in fake_diff_service.calls)
+    assert any(call[0] == "apply_for_files" for call in fake_review_policy_service.calls)
+    assert any(call[0] == "build_context_request" for call in fake_prompt_service.calls)
+    assert any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert any(call[0] == "process_inline_comments" for call in fake_review_comment_gateway.calls)
+
+    assert any(call[0] == "aggregate" for call in fake_cost_service.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_skips_when_existing_comments(
+        context_review_runner: ContextReviewRunner,
+        fake_vcs_client: FakeVCSClient,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should skip context review if inline comments already exist."""
+    fake_review_comment_gateway.responses["has_existing_inline_comments"] = True
+
+    await context_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert vcs_calls == []
+    assert not any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_skips_when_no_changed_files(
+        context_review_runner: ContextReviewRunner,
+        fake_vcs_client: FakeVCSClient,
+        fake_review_policy_service: FakeReviewPolicyService,
+):
+    """Should skip when no changed files after policy filtering."""
+    fake_review_policy_service.responses["apply_for_files"] = []
+
+    await context_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+    assert any(call[0] == "apply_for_files" for call in fake_review_policy_service.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_skips_when_no_comments_after_llm(
+        context_review_runner: ContextReviewRunner,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_policy_service: FakeReviewPolicyService,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+        fake_inline_comment_service: FakeInlineCommentService,
+
+):
+    """Should not post comments if LLM output is empty."""
+    fake_inline_comment_service.comments = []
+
+    await context_review_runner.run()
+
+    assert any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert any(call[0] == "apply_for_context_comments" for call in fake_review_policy_service.calls)
+    assert not any(call[0] == "process_inline_comments" for call in fake_review_comment_gateway.calls)

ai_review/tests/suites/services/review/runner/test_inline.py

@@ -0,0 +1,100 @@
+import pytest
+
+from ai_review.services.review.runner.inline import InlineReviewRunner
+from ai_review.services.vcs.types import ReviewInfoSchema
+from ai_review.tests.fixtures.services.cost import FakeCostService
+from ai_review.tests.fixtures.services.diff import FakeDiffService
+from ai_review.tests.fixtures.services.git import FakeGitService
+from ai_review.tests.fixtures.services.prompt import FakePromptService
+from ai_review.tests.fixtures.services.review.gateway.comment import FakeReviewCommentGateway
+from ai_review.tests.fixtures.services.review.gateway.llm import FakeReviewLLMGateway
+from ai_review.tests.fixtures.services.review.internal.inline import FakeInlineCommentService
+from ai_review.tests.fixtures.services.review.internal.policy import FakeReviewPolicyService
+from ai_review.tests.fixtures.services.vcs import FakeVCSClient
+
+
+@pytest.mark.asyncio
+async def test_run_happy_path(
+        inline_review_runner: InlineReviewRunner,
+        fake_vcs_client: FakeVCSClient,
+        fake_git_service: FakeGitService,
+        fake_diff_service: FakeDiffService,
+        fake_cost_service: FakeCostService,
+        fake_prompt_service: FakePromptService,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_policy_service: FakeReviewPolicyService,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should process all changed files, call LLM and post inline comments."""
+    fake_git_service.responses["get_diff_for_file"] = "FAKE_DIFF"
+
+    await inline_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+
+    git_calls = [call[0] for call in fake_git_service.calls]
+    assert any(call == "get_diff_for_file" for call in git_calls)
+
+    assert any(call[0] == "render_file" for call in fake_diff_service.calls)
+    assert any(call[0] == "apply_for_files" for call in fake_review_policy_service.calls)
+    assert any(call[0] == "build_inline_request" for call in fake_prompt_service.calls)
+    assert any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert any(call[0] == "process_inline_comments" for call in fake_review_comment_gateway.calls)
+
+    assert any(call[0] == "aggregate" for call in fake_cost_service.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_skips_when_existing_comments(
+        inline_review_runner: InlineReviewRunner,
+        fake_vcs_client: FakeVCSClient,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should skip review if there are already existing inline comments."""
+    fake_review_comment_gateway.responses["has_existing_inline_comments"] = True
+
+    await inline_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert vcs_calls == []
+    assert not any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+
+
+@pytest.mark.asyncio
+async def test_process_file_skips_when_no_diff(
+        inline_review_runner: InlineReviewRunner,
+        fake_git_service: FakeGitService,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should skip processing file if no diff found."""
+    fake_git_service.responses["get_diff_for_file"] = ""
+
+    review_info = ReviewInfoSchema(base_sha="A", head_sha="B")
+    await inline_review_runner.process_file("file.py", review_info)
+
+    assert not any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert not any(call[0] == "process_inline_comments" for call in fake_review_comment_gateway.calls)
+
+
+@pytest.mark.asyncio
+async def test_process_file_skips_when_no_comments_after_llm(
+        inline_review_runner: InlineReviewRunner,
+        fake_git_service: FakeGitService,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_policy_service: FakeReviewPolicyService,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+        fake_inline_comment_service: FakeInlineCommentService,
+):
+    """Should not post comments if model output produces no inline comments."""
+    fake_git_service.responses["get_diff_for_file"] = "SOME_DIFF"
+    fake_inline_comment_service.comments = []
+
+    review_info = ReviewInfoSchema(base_sha="A", head_sha="B")
+    await inline_review_runner.process_file("file.py", review_info)
+
+    assert any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert any(call[0] == "apply_for_inline_comments" for call in fake_review_policy_service.calls)
+    assert not any(call[0] == "process_inline_comments" for call in fake_review_comment_gateway.calls)

ai_review/tests/suites/services/review/runner/test_inline_reply.py

@@ -0,0 +1,109 @@
+import pytest
+
+from ai_review.services.review.runner.inline_reply import InlineReplyReviewRunner
+from ai_review.services.vcs.types import ReviewInfoSchema, ReviewThreadSchema, ReviewCommentSchema, ThreadKind
+from ai_review.tests.fixtures.services.cost import FakeCostService
+from ai_review.tests.fixtures.services.diff import FakeDiffService
+from ai_review.tests.fixtures.services.git import FakeGitService
+from ai_review.tests.fixtures.services.prompt import FakePromptService
+from ai_review.tests.fixtures.services.review.gateway.comment import FakeReviewCommentGateway
+from ai_review.tests.fixtures.services.review.gateway.llm import FakeReviewLLMGateway
+from ai_review.tests.fixtures.services.review.internal.inline_reply import FakeInlineCommentReplyService
+from ai_review.tests.fixtures.services.vcs import FakeVCSClient
+
+
+@pytest.mark.asyncio
+async def test_run_happy_path(
+        inline_reply_review_runner: InlineReplyReviewRunner,
+        fake_vcs_client: FakeVCSClient,
+        fake_git_service: FakeGitService,
+        fake_cost_service: FakeCostService,
+        fake_diff_service: FakeDiffService,
+        fake_prompt_service: FakePromptService,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should process all threads, call LLM, and post replies."""
+    fake_git_service.responses["get_diff_for_file"] = "FAKE_DIFF"
+
+    await inline_reply_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+
+    assert any(call[0] == "get_inline_threads" for call in fake_review_comment_gateway.calls)
+    assert any(call[0] == "get_diff_for_file" for call in fake_git_service.calls)
+    assert any(call[0] == "render_file" for call in fake_diff_service.calls)
+    assert any(call[0] == "build_inline_reply_request" for call in fake_prompt_service.calls)
+    assert any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert any(call[0] == "process_inline_reply" for call in fake_review_comment_gateway.calls)
+    assert any(call[0] == "aggregate" for call in fake_cost_service.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_skips_when_no_threads(
+        fake_vcs_client: FakeVCSClient,
+        inline_reply_review_runner: InlineReplyReviewRunner,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should skip when there are no AI inline threads."""
+    fake_review_comment_gateway.responses["get_inline_threads"] = []
+
+    await inline_reply_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+    assert any(call[0] == "get_inline_threads" for call in fake_review_comment_gateway.calls)
+    assert not any(call[0] == "process_inline_reply" for call in fake_review_comment_gateway.calls)
+
+
+@pytest.mark.asyncio
+async def test_process_thread_reply_skips_when_no_diff(
+        inline_reply_review_runner: InlineReplyReviewRunner,
+        fake_git_service: FakeGitService,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should skip reply processing when no diff found for file."""
+    fake_git_service.responses["get_diff_for_file"] = ""
+
+    review_info = ReviewInfoSchema(base_sha="A", head_sha="B")
+    thread = ReviewThreadSchema(
+        id="1",
+        kind=ThreadKind.INLINE,
+        file="file.py",
+        line=1,
+        comments=[ReviewCommentSchema(id="c1", body="Some comment")]
+    )
+
+    await inline_reply_review_runner.process_thread_reply(thread, review_info)
+
+    assert not any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert not any(call[0] == "process_inline_reply" for call in fake_review_comment_gateway.calls)
+
+
+@pytest.mark.asyncio
+async def test_process_thread_reply_skips_when_no_reply(
+        inline_reply_review_runner: InlineReplyReviewRunner,
+        fake_git_service: FakeGitService,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+        fake_inline_comment_reply_service: FakeInlineCommentReplyService,
+):
+    """Should not post reply if model output produces no reply schema."""
+    fake_git_service.responses["get_diff_for_file"] = "SOME_DIFF"
+    fake_inline_comment_reply_service.reply = None
+
+    review_info = ReviewInfoSchema(base_sha="A", head_sha="B")
+    thread = ReviewThreadSchema(
+        id="42",
+        kind=ThreadKind.INLINE,
+        file="main.py",
+        line=12,
+        comments=[ReviewCommentSchema(id="cm1", body="Fix this!")]
+    )
+
+    await inline_reply_review_runner.process_thread_reply(thread, review_info)
+
+    assert any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert not any(call[0] == "process_inline_reply" for call in fake_review_comment_gateway.calls)

ai_review/tests/suites/services/review/runner/test_summary.py

@@ -0,0 +1,87 @@
+import pytest
+
+from ai_review.services.review.internal.summary.schema import SummaryCommentSchema
+from ai_review.services.review.runner.summary import SummaryReviewRunner
+from ai_review.tests.fixtures.services.cost import FakeCostService
+from ai_review.tests.fixtures.services.diff import FakeDiffService
+from ai_review.tests.fixtures.services.prompt import FakePromptService
+from ai_review.tests.fixtures.services.review.gateway.comment import FakeReviewCommentGateway
+from ai_review.tests.fixtures.services.review.gateway.llm import FakeReviewLLMGateway
+from ai_review.tests.fixtures.services.review.internal.policy import FakeReviewPolicyService
+from ai_review.tests.fixtures.services.review.internal.summary import FakeSummaryCommentService
+from ai_review.tests.fixtures.services.vcs import FakeVCSClient
+
+
+@pytest.mark.asyncio
+async def test_run_happy_path(
+        summary_review_runner: SummaryReviewRunner,
+        fake_vcs_client: FakeVCSClient,
+        fake_diff_service: FakeDiffService,
+        fake_cost_service: FakeCostService,
+        fake_prompt_service: FakePromptService,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_policy_service: FakeReviewPolicyService,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should render all changed files, call LLM and post summary comment."""
+    await summary_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+
+    assert any(call[0] == "render_files" for call in fake_diff_service.calls)
+    assert any(call[0] == "apply_for_files" for call in fake_review_policy_service.calls)
+    assert any(call[0] == "build_summary_request" for call in fake_prompt_service.calls)
+    assert any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert any(call[0] == "process_summary_comment" for call in fake_review_comment_gateway.calls)
+
+    assert any(call[0] == "aggregate" for call in fake_cost_service.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_skips_when_existing_summary_comments(
+        summary_review_runner: SummaryReviewRunner,
+        fake_vcs_client: FakeVCSClient,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should skip summary review if summary comment already exists."""
+    fake_review_comment_gateway.responses["has_existing_summary_comments"] = True
+
+    await summary_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert vcs_calls == []
+    assert not any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_skips_when_no_changed_files(
+        summary_review_runner: SummaryReviewRunner,
+        fake_vcs_client: FakeVCSClient,
+        fake_review_policy_service: FakeReviewPolicyService,
+):
+    """Should skip when no changed files remain after policy filtering."""
+    fake_review_policy_service.responses["apply_for_files"] = []
+
+    await summary_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+    assert any(call[0] == "apply_for_files" for call in fake_review_policy_service.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_skips_when_empty_summary_from_llm(
+        summary_review_runner: SummaryReviewRunner,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+        fake_summary_comment_service: FakeSummaryCommentService,
+):
+    """Should skip posting comment if LLM output is empty."""
+    fake_summary_comment_service.responses["parse_model_output"] = SummaryCommentSchema(text="")
+
+    await summary_review_runner.run()
+
+    assert any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert not any(call[0] == "process_summary_comment" for call in fake_review_comment_gateway.calls)

ai_review/tests/suites/services/review/runner/test_summary_reply.py

@@ -0,0 +1,97 @@
+import pytest
+
+from ai_review.services.review.runner.summary_reply import SummaryReplyReviewRunner
+from ai_review.services.vcs.types import ReviewInfoSchema, ReviewThreadSchema, ReviewCommentSchema, ThreadKind
+from ai_review.tests.fixtures.services.cost import FakeCostService
+from ai_review.tests.fixtures.services.diff import FakeDiffService
+from ai_review.tests.fixtures.services.prompt import FakePromptService
+from ai_review.tests.fixtures.services.review.gateway.comment import FakeReviewCommentGateway
+from ai_review.tests.fixtures.services.review.gateway.llm import FakeReviewLLMGateway
+from ai_review.tests.fixtures.services.review.internal.policy import FakeReviewPolicyService
+from ai_review.tests.fixtures.services.review.internal.summary_reply import FakeSummaryCommentReplyService
+from ai_review.tests.fixtures.services.vcs import FakeVCSClient
+
+
+@pytest.mark.asyncio
+async def test_run_happy_path(
+        summary_reply_review_runner: SummaryReplyReviewRunner,
+        fake_vcs_client: FakeVCSClient,
+        fake_diff_service: FakeDiffService,
+        fake_cost_service: FakeCostService,
+        fake_prompt_service: FakePromptService,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should process all summary threads, call LLM, and post replies."""
+    await summary_reply_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+
+    assert any(call[0] == "get_summary_threads" for call in fake_review_comment_gateway.calls)
+    assert any(call[0] == "render_files" for call in fake_diff_service.calls)
+    assert any(call[0] == "build_summary_reply_request" for call in fake_prompt_service.calls)
+    assert any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert any(call[0] == "process_summary_reply" for call in fake_review_comment_gateway.calls)
+    assert any(call[0] == "aggregate" for call in fake_cost_service.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_skips_when_no_threads(
+        summary_reply_review_runner: SummaryReplyReviewRunner,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+        fake_vcs_client: FakeVCSClient,
+):
+    """Should skip when there are no AI summary threads."""
+    fake_review_comment_gateway.responses["get_summary_threads"] = []
+
+    await summary_reply_review_runner.run()
+
+    vcs_calls = [call[0] for call in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+    assert any(call[0] == "get_summary_threads" for call in fake_review_comment_gateway.calls)
+    assert not any(call[0] == "process_summary_reply" for call in fake_review_comment_gateway.calls)
+
+
+@pytest.mark.asyncio
+async def test_process_thread_reply_skips_when_no_allowed_files(
+        summary_reply_review_runner: SummaryReplyReviewRunner,
+        fake_review_policy_service: FakeReviewPolicyService,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should skip processing thread if policy filtered out all files."""
+    fake_review_policy_service.responses["apply_for_files"] = []
+
+    review_info = ReviewInfoSchema(base_sha="A", head_sha="B", changed_files=["a.py"])
+    thread = ReviewThreadSchema(
+        id="99",
+        kind=ThreadKind.SUMMARY,
+        comments=[ReviewCommentSchema(id="c1", body="Summary comment")],
+    )
+
+    await summary_reply_review_runner.process_thread_reply(thread, review_info)
+
+    assert not any(call[0] == "process_summary_reply" for call in fake_review_comment_gateway.calls)
+
+
+@pytest.mark.asyncio
+async def test_process_thread_reply_skips_when_no_reply(
+        summary_reply_review_runner: SummaryReplyReviewRunner,
+        fake_summary_comment_reply_service: FakeSummaryCommentReplyService,
+        fake_review_llm_gateway: FakeReviewLLMGateway,
+        fake_review_comment_gateway: FakeReviewCommentGateway,
+):
+    """Should not post reply if model output produced no reply schema."""
+    fake_summary_comment_reply_service.reply = None
+
+    review_info = ReviewInfoSchema(base_sha="A", head_sha="B", changed_files=["x.py"])
+    thread = ReviewThreadSchema(
+        id="42",
+        kind=ThreadKind.SUMMARY,
+        comments=[ReviewCommentSchema(id="cm1", body="AI summary comment")],
+    )
+
+    await summary_reply_review_runner.process_thread_reply(thread, review_info)
+
+    assert any(call[0] == "ask" for call in fake_review_llm_gateway.calls)
+    assert not any(call[0] == "process_summary_reply" for call in fake_review_comment_gateway.calls)