wbcore 1.46.0__py2.py3-none-any.whl → 1.58.2__py2.py3-none-any.whl

wbcore/contrib/workflow/tests/test_models/step/test_step.py

@@ -23,7 +23,10 @@ class TestStep:
         process = process_factory(workflow=step.workflow)
         activate_step(step.pk, process.pk)
         process_step_qs = ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         )
         assert process_step_qs.count() == 1
         assert mock_run.call_args.args == (process_step_qs.first(),)
@@ -34,7 +37,10 @@ class TestStep:
         process = process_factory(workflow=step.workflow, instance=None, instance_id=None)
         activate_step(step.pk, process.pk)
         process_step_qs = ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         )
         assert process_step_qs.count() == 1
         assert mock_run.call_args.args == (process_step_qs.first(),)
@@ -45,7 +51,10 @@ class TestStep:
         process = process_factory(workflow=step.workflow)
         activate_step(step.pk, process.pk)
         process_step_qs = ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         )
         assert process_step_qs.count() == 1
         assert mock_run.call_args.args == (process_step_qs.first(),)
@@ -88,7 +97,10 @@ class TestStep:
         process = process_factory(workflow=step.workflow)
         activate_step(step.pk, process.pk)
         process_step_qs = ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         )
         assert process_step_qs.count() == 1
         assert Person.objects.get(id=process.instance.pk).first_name == step.status
@@ -100,7 +112,10 @@ class TestStep:
         process = process_factory(workflow=step.workflow)
         activate_step(step.pk, process.pk)
         process_step_qs = ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         )
         assert process_step_qs.count() == 1
         assert Person.objects.get(id=process.instance.pk).first_name == step.status
@@ -112,7 +127,10 @@ class TestStep:
         process = process_factory(workflow=step.workflow)
         activate_step(step.pk, process.pk)
         process_step_qs = ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         )
         assert process_step_qs.count() == 1
         assert Person.objects.get(id=process.instance.pk).first_name == step.status
@@ -124,7 +142,10 @@ class TestStep:
         process = process_factory(workflow=step.workflow)
         activate_step(step.pk, process.pk)
         process_step_qs = ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         )
         assert process_step_qs.count() == 1
         assert Person.objects.get(id=process.instance.pk).first_name == step.status
@@ -136,7 +157,10 @@ class TestStep:
         process = process_factory(workflow=step.workflow)
         activate_step(step.pk, process.pk)
         process_step_qs = ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         )
         assert process_step_qs.count() == 1
         assert Person.objects.get(id=process.instance.pk).first_name == step.status
@@ -146,12 +170,25 @@ class TestStep:
     def test_activate_join_step(self, mock_run, process_step_factory, join_step_factory, process_factory):
         step = join_step_factory()
         process = process_factory(workflow=step.workflow)
-        process_step_factory(state=ProcessStep.StepState.WAITING, step=step, status=step.status, process=process)
-        process_step_factory(state=ProcessStep.StepState.WAITING, step=step, status=step.status, finished=None)
+        process_step_factory(
+            state=ProcessStep.StepState.WAITING,
+            step=step,
+            status=step.status,
+            process=process,
+        )
+        process_step_factory(
+            state=ProcessStep.StepState.WAITING,
+            step=step,
+            status=step.status,
+            finished=None,
+        )
         process_step_factory()
         activate_step(step.pk, process.pk)
         process_step_qs = ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         )
         assert process_step_qs.count() == 1
         assert Person.objects.get(id=process.instance.pk).first_name == step.status
@@ -164,15 +201,26 @@ class TestStep:
         step = join_step_factory()
         process = process_factory(workflow=step.workflow)
         process_step_factory(
-            state=ProcessStep.StepState.WAITING, step=step, status=step.status, process=process, finished=None
+            state=ProcessStep.StepState.WAITING,
+            step=step,
+            status=step.status,
+            process=process,
+            finished=None,
         )
         process_step_factory(
-            state=ProcessStep.StepState.WAITING, step=step, status=step.status, process=process, finished=None
+            state=ProcessStep.StepState.WAITING,
+            step=step,
+            status=step.status,
+            process=process,
+            finished=None,
         )
         process_step_factory()
         activate_step(step.pk, process.pk)
         process_step_qs = ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         )
         assert process_step_qs.count() == 1
         assert Person.objects.get(id=process.instance.pk).first_name == step.status
@@ -182,14 +230,26 @@ class TestStep:
     def test_activate_waiting_join_step(self, mock_run, process_step_factory, join_step_factory, process_factory):
         step = join_step_factory()
         process = process_factory(workflow=step.workflow)
-        process_step_factory(state=ProcessStep.StepState.WAITING, step=step, status=step.status, process=process)
+        process_step_factory(
+            state=ProcessStep.StepState.WAITING,
+            step=step,
+            status=step.status,
+            process=process,
+        )
         waiting_process_step = process_step_factory(
-            state=ProcessStep.StepState.WAITING, step=step, status=step.status, process=process, finished=None
+            state=ProcessStep.StepState.WAITING,
+            step=step,
+            status=step.status,
+            process=process,
+            finished=None,
         )
         process_step_factory()
         activate_step(step.pk, process.pk)
         assert not ProcessStep.objects.filter(
-            state=ProcessStep.StepState.ACTIVE, process=process, step=step, status=step.status
+            state=ProcessStep.StepState.ACTIVE,
+            process=process,
+            step=step,
+            status=step.status,
         ).exists()
         assert Person.objects.get(id=process.instance.pk).first_name == step.status
         assert str(mock_run.call_args.args[0].pk) == waiting_process_step.pk
@@ -208,16 +268,32 @@ class TestStep:
         transition = transition_factory(to_step=step)
         assert list(step.get_incoming_transitions()) == [transition]
 
-    def test_get_previous_steps(self, random_child_step_factory, transition_factory):
-        step = random_child_step_factory()
-        transition1 = transition_factory(to_step=step)
-        transition2 = transition_factory(to_step=step)
-        transition_factory(from_step=step)
+    def test_get_previous_steps(
+        self,
+        join_step_factory,
+        split_step_factory,
+        finish_step_factory,
+        transition_factory,
+    ):
+        to_step = join_step_factory()
+        from_step = split_step_factory()
+        transition1 = transition_factory(to_step=to_step, from_step=from_step)
+        transition2 = transition_factory(to_step=to_step, from_step=from_step)
+        transition_factory(to_step=finish_step_factory(), from_step=to_step)
         transition_factory()
-        assert set(step.get_previous_steps()) == {transition1.from_step, transition2.from_step}
+        previous_steps = to_step.get_previous_steps()
+        previous_steps = [step.id for step in previous_steps]
+        assert set(previous_steps) == {
+            transition1.from_step.id,
+            transition2.from_step.id,
+        }
 
     def test_get_all_valid_outgoing_transitions(
-        self, random_child_step_factory, transition_factory, condition_factory, process_step_factory
+        self,
+        random_child_step_factory,
+        transition_factory,
+        condition_factory,
+        process_step_factory,
     ):
         person = PersonFactory()
         step = random_child_step_factory()
@@ -247,7 +323,10 @@ class TestStep:
         valid_transition_without_condition = transition_factory(from_step=step, to_step__workflow=step.workflow)
         process_step = process_step_factory(step=step, process__instance=person)
         transitions = step.get_all_valid_outgoing_transitions(process_step)
-        assert set(transitions) == {valid_transition, valid_transition_without_condition}
+        assert set(transitions) == {
+            valid_transition,
+            valid_transition_without_condition,
+        }
 
     def test_get_assigned_group(self, random_child_step_factory):
         random_step = random_child_step_factory(exclude_factories=[UserStepFactory])
@@ -343,7 +422,11 @@ class TestStep:
 
     @patch("wbcore.contrib.workflow.models.step.Step.start_next_step")
     def test_execute_single_next_step(
-        self, mock_next, process_step_factory, transition_factory, random_child_step_factory
+        self,
+        mock_next,
+        process_step_factory,
+        transition_factory,
+        random_child_step_factory,
     ):
         step = random_child_step_factory()
         process_step = process_step_factory(step=step)
@@ -354,7 +437,11 @@ class TestStep:
 
     @patch("wbcore.contrib.workflow.models.step.Step.set_failed")
     def test_execute_single_next_step_no_transitions(
-        self, mock_failed, process_step_factory, transition_factory, random_child_step_factory
+        self,
+        mock_failed,
+        process_step_factory,
+        transition_factory,
+        random_child_step_factory,
     ):
         step = random_child_step_factory(exclude_factories=[UserStepFactory])
         process_step = process_step_factory(step=step)
@@ -364,7 +451,11 @@ class TestStep:
 
     @patch("wbcore.contrib.workflow.models.step.Step.set_failed")
     def test_execute_single_next_step_multiple_transitions(
-        self, mock_failed, process_step_factory, transition_factory, random_child_step_factory
+        self,
+        mock_failed,
+        process_step_factory,
+        transition_factory,
+        random_child_step_factory,
     ):
         step = random_child_step_factory(exclude_factories=[UserStepFactory])
         process_step = process_step_factory(step=step)
@@ -403,7 +494,10 @@ class TestStep:
         process_step = process_step_factory()
         Step.start_next_step(process_step, transition)
         assert mock_finish.call_args.args == (process_step,)
-        assert mock_activate.call_args.args == (transition.to_step.pk, process_step.process.pk)
+        assert mock_activate.call_args.args == (
+            transition.to_step.pk,
+            process_step.process.pk,
+        )
 
     @patch("wbcore.contrib.workflow.models.process.Process.set_failed")
     def test_process_can_finish_no_active(self, mock_failed, process_step_factory):
@@ -417,7 +511,11 @@ class TestStep:
 
     @patch("wbcore.contrib.workflow.models.process.Process.set_failed")
     def test_process_can_finish_no_join_steps(
-        self, mock_failed, process_step_factory, random_child_step_factory, process_factory
+        self,
+        mock_failed,
+        process_step_factory,
+        random_child_step_factory,
+        process_factory,
     ):
         step = random_child_step_factory(exclude_factories=[JoinStepFactory])
         process = process_factory(workflow=step.workflow)
@@ -495,7 +593,19 @@ class TestStep:
         process = process_factory(workflow=workflow)
         process_step_factory(step=step12, state=ProcessStep.StepState.FAILED, process=process)
         process_step_factory(step=step11, state=ProcessStep.StepState.ACTIVE, process=process)
-        for step in [step1, step2, step3, step4, step5, step6, step7, step8, step9, step10, step14]:
+        for step in [
+            step1,
+            step2,
+            step3,
+            step4,
+            step5,
+            step6,
+            step7,
+            step8,
+            step9,
+            step10,
+            step14,
+        ]:
             process_step_factory(step=step, state=ProcessStep.StepState.FINISHED, process=process)
         process_can_finish(process.pk)
         assert not mock_failed.called
@@ -555,7 +665,21 @@ class TestStep:
         process = process_factory(workflow=workflow)
         process_step_factory(step=step8, state=ProcessStep.StepState.FAILED, process=process)
         process_step_factory(step=step14, state=ProcessStep.StepState.WAITING, process=process)
-        for step in [step1, step2, step3, step4, step5, step6, step7, step9, step10, step11, step12, step13, step15]:
+        for step in [
+            step1,
+            step2,
+            step3,
+            step4,
+            step5,
+            step6,
+            step7,
+            step9,
+            step10,
+            step11,
+            step12,
+            step13,
+            step15,
+        ]:
             process_step_factory(step=step, state=ProcessStep.StepState.FINISHED, process=process)
         process_can_finish(process.pk)
         assert mock_failed.called
@@ -615,7 +739,18 @@ class TestStep:
         process = process_factory(workflow=workflow)
         process_step_factory(step=step6, state=ProcessStep.StepState.FAILED, process=process)
         process_step_factory(step=step15, state=ProcessStep.StepState.ACTIVE, process=process)
-        for step in [step1, step2, step3, step4, step5, step10, step11, step12, step13, step15]:
+        for step in [
+            step1,
+            step2,
+            step3,
+            step4,
+            step5,
+            step10,
+            step11,
+            step12,
+            step13,
+            step15,
+        ]:
             process_step_factory(step=step, state=ProcessStep.StepState.FINISHED, process=process)
         process_can_finish(process.pk)
         assert mock_failed.called

wbcore/contrib/workflow/tests/test_models/test_condition.py

@@ -10,7 +10,7 @@ class TestCondition:
     def test_errors_satisfied_not_called(self, condition_factory):
         condition = condition_factory()
         with pytest.raises(ValueError):
-            condition.errors
+            assert condition.errors == []
 
     def test_errors(self, condition_factory):
         condition = condition_factory()

wbcore/contrib/workflow/tests/test_models/test_workflow.py

@@ -48,9 +48,9 @@ class TestWorkflow:
         default_value = "Test"
         data2 = data_factory(workflow=workflow, default=default_value)
         start_step = start_step_factory()
-        workflow_site.registered_model_classes_serializer_map[
-            Person
-        ] = "wbcore.contrib.directory.serializers.PersonModelSerializer"
+        workflow_site.registered_model_classes_serializer_map[Person] = (
+            "wbcore.contrib.directory.serializers.PersonModelSerializer"
+        )
         workflow.start_workflow(start_step, attached_person)
         process_qs = Process.objects.filter(
             workflow=workflow,