wagtail 6.2.2__py3-none-any.whl → 6.3rc1__py3-none-any.whl

wagtail/admin/tests/pages/test_content_type_use_view.py

@@ -1,7 +1,10 @@
+from django.contrib.auth import get_user_model
+from django.contrib.auth.models import Group, Permission
 from django.test import TestCase
 from django.urls import reverse
 from django.utils.http import urlencode
 
+from wagtail.models import GroupPagePermission, Page
 from wagtail.test.testapp.models import EventPage
 from wagtail.test.utils import WagtailTestUtils
 
@@ -13,6 +16,47 @@ class TestContentTypeUse(WagtailTestUtils, TestCase):
         self.user = self.login()
         self.christmas_page = EventPage.objects.get(title="Christmas")
 
+    def test_with_no_permission(self):
+        request_url = reverse(
+            "wagtailadmin_pages:type_use", args=("tests", "eventpage")
+        )
+        group = Group.objects.create(name="test group")
+        self.user.is_superuser = False
+        self.user.save()
+        self.user.groups.add(group)
+        group.permissions.add(
+            Permission.objects.get(
+                content_type__app_label="wagtailadmin", codename="access_admin"
+            )
+        )
+        # No GroupPagePermission created
+
+        response = self.client.get(request_url)
+        self.assertEqual(response.status_code, 302)
+        self.assertRedirects(response, reverse("wagtailadmin_home"))
+
+    def test_with_minimal_permissions(self):
+        request_url = reverse(
+            "wagtailadmin_pages:type_use", args=("tests", "eventpage")
+        )
+        group = Group.objects.create(name="test group")
+        self.user.is_superuser = False
+        self.user.save()
+        self.user.groups.add(group)
+        group.permissions.add(
+            Permission.objects.get(
+                content_type__app_label="wagtailadmin", codename="access_admin"
+            ),
+        )
+        GroupPagePermission.objects.create(
+            group=group,
+            page=Page.objects.first(),
+            permission_type="change",
+        )
+
+        response = self.client.get(request_url)
+        self.assertEqual(response.status_code, 200)
+
     def test_content_type_use(self):
         # Get use of event page
         request_url = reverse(
@@ -23,7 +67,7 @@ class TestContentTypeUse(WagtailTestUtils, TestCase):
         # Check response
         self.assertEqual(response.status_code, 200)
         self.assertTemplateUsed(response, "wagtailadmin/generic/listing.html")
-        self.assertTemplateUsed(response, "wagtailadmin/pages/usage_results.html")
+        self.assertTemplateUsed(response, "wagtailadmin/generic/listing_results.html")
         self.assertContains(response, "Christmas")
 
         # Links to 'delete' etc should include a 'next' URL parameter pointing back here
@@ -33,4 +77,40 @@ class TestContentTypeUse(WagtailTestUtils, TestCase):
             + urlencode({"next": request_url})
         )
         self.assertContains(response, delete_url)
-        self.assertNotContains(response, "data-bulk-action-select-all-checkbox")
+        self.assertContains(response, "data-bulk-action-select-all-checkbox")
+
+        with self.assertNumQueries(33):
+            self.client.get(request_url)
+
+    def test_content_type_use_results(self):
+        # Get the results view of event page use, with search and filter
+        ameristralia_page = EventPage.objects.get(title="Ameristralia Day")
+        user = get_user_model().objects.get(email="eventmoderator@example.com")
+        request_url = reverse(
+            "wagtailadmin_pages:type_use_results",
+            args=("tests", "eventpage"),
+        )
+        response = self.client.get(
+            request_url,
+            data={"q": "Ameristralia", "owner": user.pk},
+        )
+
+        # Check response
+        self.assertEqual(response.status_code, 200)
+        self.assertTemplateNotUsed(response, "wagtailadmin/generic/listing.html")
+        self.assertTemplateUsed(response, "wagtailadmin/generic/listing_results.html")
+        self.assertContains(response, "Ameristralia Day")
+
+        # Links to 'delete' etc should include a 'next' URL parameter pointing back
+        # to the full view, not the results-only view
+        full_view_url = reverse(
+            "wagtailadmin_pages:type_use",
+            args=("tests", "eventpage"),
+        )
+        delete_url = (
+            reverse("wagtailadmin_pages:delete", args=(ameristralia_page.id,))
+            + "?"
+            + urlencode({"next": full_view_url})
+        )
+        self.assertContains(response, delete_url)
+        self.assertContains(response, "data-bulk-action-select-all-checkbox")

wagtail/admin/tests/pages/test_edit_page.py

@@ -13,6 +13,7 @@ from django.urls import reverse
 from django.utils import timezone
 from django.utils.translation import gettext_lazy as _
 
+from wagtail.admin.action_menu import ActionMenuItem
 from wagtail.admin.admin_url_finder import AdminURLFinder
 from wagtail.exceptions import PageClassNotFoundError
 from wagtail.models import (
@@ -218,6 +219,75 @@ class TestPageEdit(WagtailTestUtils, TestCase):
         expected_url = "/admin/pages/%d/edit/" % self.event_page.id
         self.assertEqual(url_finder.get_edit_url(self.event_page), expected_url)
 
+    def test_construct_page_action_menu_hook_with_custom_default_button(self):
+        class CustomDefaultItem(ActionMenuItem):
+            label = "Custom button"
+            name = "custom-default"
+            classname = "custom-class"
+            icon_name = "check"
+
+            class Media:
+                js = ["js/custom-default.js"]
+                css = {"all": ["css/custom-default.css"]}
+
+        def add_custom_default_item(menu_items, request, context):
+            menu_items.insert(0, CustomDefaultItem())
+
+        with self.register_hook(
+            "construct_page_action_menu",
+            add_custom_default_item,
+        ):
+            response = self.client.get(
+                reverse("wagtailadmin_pages:edit", args=(self.event_page.id,))
+            )
+
+        self.assertEqual(response.status_code, 200)
+
+        soup = self.get_soup(response.content)
+        form = soup.select_one("form[data-edit-form]")
+        custom_action = form.select_one("button[name='custom-default']")
+        self.assertIsNotNone(custom_action)
+
+        # We're replacing the save button, so it should not be in a dropdown
+        # as it's the main action
+        dropdown_parent = custom_action.find_parent(attrs={"class": "w-dropdown"})
+        self.assertIsNone(dropdown_parent)
+
+        self.assertEqual(custom_action.text.strip(), "Custom button")
+        self.assertEqual(custom_action.attrs.get("class"), ["button", "custom-class"])
+        icon = custom_action.select_one("svg use[href='#icon-check']")
+        self.assertIsNotNone(icon)
+
+        # Should contain media files
+        js = soup.select_one("script[src='/static/js/custom-default.js']")
+        self.assertIsNotNone(js)
+        css = soup.select_one("link[href='/static/css/custom-default.css']")
+        self.assertIsNotNone(css)
+
+        # The save button should now be in the dropdown
+        save_item = form.select_one(".w-dropdown .action-save")
+        self.assertIsNotNone(save_item)
+
+    def test_construct_page_action_menu_hook_removes_all_buttons(self):
+        def remove_all_buttons(menu_items, request, context):
+            menu_items[:] = []
+
+        with self.register_hook(
+            "construct_page_action_menu",
+            remove_all_buttons,
+        ):
+            response = self.client.get(
+                reverse("wagtailadmin_pages:edit", args=(self.event_page.id,))
+            )
+
+        # It shouldn't crash due to assuming a default button is present
+        self.assertEqual(response.status_code, 200)
+
+        soup = self.get_soup(response.content)
+        form = soup.select_one("form[data-edit-form]")
+        actions = form.select("footer button")
+        self.assertEqual(len(actions), 0)
+
     def test_usage_count_information_shown(self):
         PageChooserModel.objects.create(page=self.event_page)
 

wagtail/admin/tests/pages/test_explorer_view.py

@@ -6,6 +6,7 @@ from django.urls import reverse
 from django.utils.http import urlencode
 
 from wagtail import hooks
+from wagtail.admin.staticfiles import versioned_static
 from wagtail.admin.widgets import Button
 from wagtail.models import GroupPagePermission, Locale, Page, Site, Workflow
 from wagtail.test.testapp.models import (
@@ -93,6 +94,13 @@ class TestPageExplorer(WagtailTestUtils, TestCase):
             count=3,
         )
 
+        bulk_actions_js = versioned_static("wagtailadmin/js/bulk-actions.js")
+        self.assertContains(
+            response,
+            f'<script defer src="{bulk_actions_js}"></script>',
+            html=True,
+        )
+
     def test_explore_results(self):
         explore_results_url = reverse(
             "wagtailadmin_explore_results", args=(self.root_page.id,)
@@ -396,7 +404,11 @@ class TestPageExplorer(WagtailTestUtils, TestCase):
         )
 
         # Check response
-        self.assertEqual(response.status_code, 404)
+        self.assertEqual(response.status_code, 200)
+        self.assertTemplateUsed(response, "wagtailadmin/pages/index.html")
+
+        # Check that we got page one
+        self.assertEqual(response.context["page_obj"].number, 1)
 
     def test_pagination_out_of_range(self):
         self.make_pages()
@@ -406,7 +418,14 @@ class TestPageExplorer(WagtailTestUtils, TestCase):
         )
 
         # Check response
-        self.assertEqual(response.status_code, 404)
+        self.assertEqual(response.status_code, 200)
+        self.assertTemplateUsed(response, "wagtailadmin/pages/index.html")
+
+        # Check that we got the last page
+        self.assertEqual(
+            response.context["page_obj"].number,
+            response.context["paginator"].num_pages,
+        )
 
     def test_no_pagination_with_custom_ordering(self):
         self.make_pages()
@@ -921,6 +940,25 @@ class TestPageExplorerSignposting(WagtailTestUtils, TestCase):
             response, """<a href="/admin/sites/">Configure a site now.</a>"""
         )
 
+    def test_searching_at_root(self):
+        self.login(username="superuser", password="password")
+
+        # Message about root level should not show when searching or filtering
+        response = self.client.get(reverse("wagtailadmin_explore_root"), {"q": "hello"})
+        self.assertEqual(response.status_code, 200)
+        self.assertNotContains(
+            response,
+            "The root level is where you can add new sites to your Wagtail installation.",
+        )
+        response = self.client.get(
+            reverse("wagtailadmin_explore_root"), {"has_child_pages": "true"}
+        )
+        self.assertEqual(response.status_code, 200)
+        self.assertNotContains(
+            response,
+            "The root level is where you can add new sites to your Wagtail installation.",
+        )
+
     def test_admin_at_non_site_page(self):
         self.login(username="superuser", password="password")
         response = self.client.get(
@@ -940,6 +978,29 @@ class TestPageExplorerSignposting(WagtailTestUtils, TestCase):
             response, """<a href="/admin/sites/">Configure a site now.</a>"""
         )
 
+    def test_searching_at_non_site_page(self):
+        self.login(username="superuser", password="password")
+
+        # Message about unroutable pages should not show when searching or filtering
+        response = self.client.get(
+            reverse("wagtailadmin_explore", args=(self.no_site_page.id,)),
+            {"q": "hello"},
+        )
+        self.assertEqual(response.status_code, 200)
+        self.assertNotContains(
+            response,
+            "There is no site set up for this location.",
+        )
+        response = self.client.get(
+            reverse("wagtailadmin_explore", args=(self.no_site_page.id,)),
+            {"has_child_pages": "true"},
+        )
+        self.assertEqual(response.status_code, 200)
+        self.assertNotContains(
+            response,
+            "There is no site set up for this location.",
+        )
+
     def test_admin_at_site_page(self):
         self.login(username="superuser", password="password")
         response = self.client.get(
@@ -1184,7 +1245,7 @@ class TestExplorablePageVisibility(WagtailTestUtils, TestCase):
         response = self.client.get(reverse("wagtailadmin_home"))
         self.assertEqual(response.status_code, 200)
         # Bob should only see the welcome for example.com, not testserver
-        self.assertContains(response, "Welcome to the example.com Wagtail CMS")
+        self.assertContains(response, "example.com")
         self.assertNotContains(response, "testserver")
 
     def test_breadcrumb_with_no_user_permissions(self):
@@ -1273,7 +1334,7 @@ class TestInWorkflowStatus(WagtailTestUtils, TestCase):
         # Warm up cache
         self.client.get(self.url)
 
-        with self.assertNumQueries(47):
+        with self.assertNumQueries(44):
             response = self.client.get(self.url)
 
         self.assertEqual(response.status_code, 200)

wagtail/admin/tests/pages/test_page_search.py

@@ -33,6 +33,9 @@ class TestPageSearch(WagtailTestUtils, TransactionTestCase):
         self.assertTemplateUsed(response, "wagtailadmin/pages/search.html")
         self.assertEqual(response.status_code, 200)
 
+        with self.assertNumQueries(22):
+            self.get()
+
     def test_search(self):
         # Find root page
         root_page = Page.objects.get(id=2)
@@ -110,13 +113,11 @@ class TestPageSearch(WagtailTestUtils, TransactionTestCase):
         self.assertContains(response, f'href="{expected_new_page_copy_url}"')
 
     def test_pagination(self):
-        # page numbers in range should be accepted
-        response = self.get({"q": "Hello", "p": 1})
-        self.assertEqual(response.status_code, 200)
-        self.assertTemplateUsed(response, "wagtailadmin/pages/search.html")
-        # page numbers out of range should return 404
-        response = self.get({"q": "Hello", "p": 9999})
-        self.assertEqual(response.status_code, 404)
+        pages = ["0", "1", "-1", "9999", "Not a page"]
+        for page in pages:
+            response = self.get({"q": "Hello", "p": page})
+            self.assertEqual(response.status_code, 200)
+            self.assertTemplateUsed(response, "wagtailadmin/pages/search.html")
 
     def test_root_can_appear_in_search_results(self):
         response = self.get({"q": "root"})

wagtail/admin/tests/pages/test_page_usage.py

@@ -103,7 +103,9 @@ class TestPageUsage(AdminTemplateTestUtils, WagtailTestUtils, TestCase):
 
         self.assertContains(response, "Contact us")
         self.assertContains(
-            response, reverse("wagtailadmin_pages:edit", args=(form_page.id,))
+            response,
+            reverse("wagtailadmin_pages:edit", args=(form_page.id,))
+            + "#:w:contentpath=thank_you_redirect_page",
         )
         self.assertContains(response, "Thank you redirect page")
         self.assertContains(response, "<td>Form page with redirect</td>", html=True)