udata 14.0.3.dev1__py3-none-any.whl → 14.7.3.dev4__py3-none-any.whl

udata/tests/test_transfer.py

@@ -10,11 +10,13 @@ from udata.core.user.factories import UserFactory
 from udata.core.user.metrics import (
     update_owner_metrics,  # noqa needed to register signals
 )
-from udata.features.transfer.actions import accept_transfer, request_transfer
+from udata.features.notifications.models import Notification
+from udata.features.transfer.actions import accept_transfer, refuse_transfer, request_transfer
 from udata.features.transfer.factories import TransferFactory
 from udata.features.transfer.notifications import transfer_request_notifications
 from udata.models import Member
-from udata.tests.api import PytestOnlyDBTestCase
+from udata.tests.api import DBTestCase, PytestOnlyDBTestCase
+from udata.tests.helpers import assert_equal_dates
 from udata.utils import faker
 
 
@@ -218,3 +220,180 @@ class TransferNotificationsTest(PytestOnlyDBTestCase):
             transfer = transfers[details["id"]]
             assert details["subject"]["class"] == "dataset"
             assert details["subject"]["id"] == transfer.subject.id
+
+
+class TransferRequestNotificationTest(DBTestCase):
+    def test_notification_created_for_user_recipient(self):
+        """Notification is created for user recipient when transfer is requested"""
+        owner = UserFactory()
+        recipient = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        login_user(owner)
+        transfer = request_transfer(dataset, recipient, faker.sentence())
+
+        notifications = Notification.objects.all()
+        assert len(notifications) == 1
+
+        notification = notifications[0]
+        assert notification.user == recipient
+        assert notification.details.transfer_owner == owner
+        assert notification.details.transfer_recipient == recipient
+        assert notification.details.transfer_subject == dataset
+        assert_equal_dates(notification.created_at, transfer.created)
+
+    def test_notification_created_for_org_admins_only(self):
+        """Notifications are created for all admin users of recipient org, not editors"""
+        owner = UserFactory()
+        admin1 = UserFactory()
+        admin2 = UserFactory()
+        editor = UserFactory()
+        members = [
+            Member(user=editor, role="editor"),
+            Member(user=admin1, role="admin"),
+            Member(user=admin2, role="admin"),
+        ]
+        org = OrganizationFactory(members=members)
+        dataset = DatasetFactory(owner=owner)
+
+        login_user(owner)
+        transfer = request_transfer(dataset, org, faker.sentence())
+
+        notifications = Notification.objects.all()
+        assert len(notifications) == 2
+
+        admin_users = [notif.user for notif in notifications]
+        self.assertIn(admin1, admin_users)
+        self.assertIn(admin2, admin_users)
+
+        for notification in notifications:
+            assert notification.details.transfer_owner == owner
+            assert notification.details.transfer_recipient == org
+            assert notification.details.transfer_subject == dataset
+            assert_equal_dates(notification.created_at, transfer.created)
+
+    def test_no_duplicate_notifications(self):
+        """Duplicate notifications are not created for same transfer"""
+        owner = UserFactory()
+        recipient = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        login_user(owner)
+        request_transfer(dataset, recipient, faker.sentence())
+        request_transfer(dataset, recipient, faker.sentence())
+
+        assert Notification.objects.count() == 1
+
+    def test_multiple_transfers_create_separate_notifications(self):
+        """Multiple transfer requests create separate notifications"""
+        owner = UserFactory()
+        recipient = UserFactory()
+        dataset1 = DatasetFactory(owner=owner)
+        dataset2 = DatasetFactory(owner=owner)
+
+        login_user(owner)
+        request_transfer(dataset1, recipient, faker.sentence())
+        request_transfer(dataset2, recipient, faker.sentence())
+
+        notifications = Notification.objects.all()
+        assert len(notifications) == 2
+
+        subjects = [notif.details.transfer_subject for notif in notifications]
+        self.assertIn(dataset1, subjects)
+        self.assertIn(dataset2, subjects)
+
+    def test_notification_not_created_if_previous_exists(self):
+        """Notification is created when transferring from org to user"""
+        admin = UserFactory()
+        org = OrganizationFactory(members=[Member(user=admin, role="admin")])
+        dataset = DatasetFactory(organization=org)
+        recipient = UserFactory()
+
+        login_user(admin)
+        request_transfer(dataset, recipient, faker.sentence())
+
+        notifications = Notification.objects.all()
+        assert len(notifications) == 1
+
+        request_transfer(dataset, recipient, faker.sentence())
+
+        notifications = Notification.objects.all()
+        assert len(notifications) == 1
+
+    def test_notification_created_if_previous_handled(self):
+        """Notification is created when transferring from org to user"""
+        admin = UserFactory()
+        org = OrganizationFactory(members=[Member(user=admin, role="admin")])
+        dataset = DatasetFactory(organization=org)
+        recipient = UserFactory()
+
+        login_user(admin)
+        transfer = request_transfer(dataset, recipient, faker.sentence())
+
+        login_user(recipient)
+        refuse_transfer(transfer)
+
+        notifications = Notification.objects.all()
+        assert len(notifications) == 1
+
+        login_user(admin)
+        request_transfer(dataset, recipient, faker.sentence())
+
+        notifications = Notification.objects.all()
+        assert len(notifications) == 2
+
+    def test_notification_created_for_org_to_user_transfer(self):
+        """Notification is created when transferring from org to user"""
+        admin = UserFactory()
+        org = OrganizationFactory(members=[Member(user=admin, role="admin")])
+        dataset = DatasetFactory(organization=org)
+        recipient = UserFactory()
+
+        login_user(admin)
+        transfer = request_transfer(dataset, recipient, faker.sentence())
+
+        notifications = Notification.objects.all()
+        assert len(notifications) == 1
+
+        notification = notifications[0]
+        assert notification.user == recipient
+        assert notification.details.transfer_owner == org
+        assert notification.details.transfer_recipient == recipient
+        assert notification.details.transfer_subject == dataset
+        assert_equal_dates(notification.created_at, transfer.created)
+
+    def test_notification_handled_when_transfer_accepted(self):
+        """Notification's handled_at is updated when transfer is accepted"""
+        owner = UserFactory()
+        recipient = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        login_user(owner)
+        # First create the notification by requesting the transfer
+        transfer = request_transfer(dataset, recipient, faker.sentence())
+        # Then accept the transfer
+        login_user(recipient)
+        accept_transfer(transfer)
+
+        # Check that the notification has been handled
+        notifications = Notification.objects.all()
+        assert len(notifications) == 1
+        assert notifications[0].handled_at is not None
+
+    def test_notification_handled_when_transfer_refused(self):
+        """Notification's handled_at is updated when transfer is refused"""
+        owner = UserFactory()
+        recipient = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        login_user(owner)
+        # First create the notification by requesting the transfer
+        transfer = request_transfer(dataset, recipient, faker.sentence())
+        # Then refuse the transfer
+        login_user(recipient)
+        refuse_transfer(transfer)
+
+        # Check that the notification has been handled
+        notifications = Notification.objects.all()
+        assert len(notifications) == 1
+        assert notifications[0].handled_at is not None

udata/tests/test_uris.py

@@ -2,6 +2,7 @@ import pytest
 
 from udata import uris
 from udata.settings import Defaults
+from udata.tests import PytestOnlyTestCase
 
 PUBLIC_HOSTS = [
     "http://foo.com/blah_blah",
@@ -289,3 +290,35 @@ def test_with_credentials(url):
 def test_with_credentials_disabled(url):
     with pytest.raises(uris.ValidationError, match="Credentials in URL are not allowed"):
         uris.validate(url, credentials=False)
+
+
+@pytest.mark.options(CDATA_BASE_URL="http://localhost:3000/")
+class CdataUrlTest(PytestOnlyTestCase):
+    def test_cdata_url_without_base_url(self, app):
+        app.config["CDATA_BASE_URL"] = None
+        assert uris.cdata_url("test") is None
+
+    def test_cdata_url_with_simple_uri(self):
+        assert uris.cdata_url("test") == "http://localhost:3000/test"
+
+    @pytest.mark.options(MAIL_CAMPAIGN="mail")
+    def test_cdata_url_with_mail_campaign(self):
+        assert (
+            uris.cdata_url("test", _mailCampaign=True)
+            == "http://localhost:3000/test?mtm_campaign=mail"
+        )
+
+    def test_cdata_url_with_trailing_slash(self):
+        assert uris.cdata_url("test/") == "http://localhost:3000/test"
+
+    def test_cdata_url_with_append(self):
+        assert (
+            uris.cdata_url("test/", append="/discussions")
+            == "http://localhost:3000/test/discussions"
+        )
+
+    def test_cdata_url_with_append_and_kwargs(self):
+        assert (
+            uris.cdata_url("test/", append="/discussions", discussion_id="disc_id")
+            == "http://localhost:3000/test/discussions?discussion_id=disc_id"
+        )