spec-kitty-cli 0.12.1__py3-none-any.whl

specify_cli/upgrade/migrations/m_0_11_0_workspace_per_wp.py

@@ -0,0 +1,182 @@
+"""Migration: Workspace-per-WP model with dependency tracking (0.11.0)."""
+
+from __future__ import annotations
+
+import re
+from importlib.resources import files
+from pathlib import Path
+from typing import Dict, List, Optional, Tuple
+
+from specify_cli.template.manager import get_local_repo_root
+
+from ..registry import MigrationRegistry
+from .base import BaseMigration, MigrationResult
+
+MIGRATION_ID = "0.11.0_workspace_per_wp"
+MIGRATION_VERSION = "0.11.0"
+MIGRATION_DESCRIPTION = "Workspace-per-WP model with dependency tracking"
+
+MISSION_NAME = "software-dev"
+TEMPLATE_FILES = ("specify.md", "plan.md", "tasks.md", "implement.md")
+
+
+def detect_legacy_worktrees(project_root: Path) -> List[Path]:
+    """Find legacy worktrees (pre-0.11.0)."""
+    worktrees_dir = project_root / ".worktrees"
+    if not worktrees_dir.exists():
+        return []
+
+    legacy_worktrees: List[Path] = []
+    for item in sorted(worktrees_dir.iterdir()):
+        if not item.is_dir():
+            continue
+
+        name = item.name
+        has_feature_pattern = re.match(r"^\d{3}-", name)
+        has_wp_suffix = re.search(r"-WP\d{2}$", name)
+
+        if has_feature_pattern and not has_wp_suffix:
+            legacy_worktrees.append(item)
+
+    return legacy_worktrees
+
+
+def validate_upgrade(project_root: Path) -> Tuple[bool, List[str]]:
+    """Validate project is ready for 0.11.0 upgrade."""
+    legacy_worktrees = detect_legacy_worktrees(project_root)
+    if not legacy_worktrees:
+        return True, []
+
+    errors = [
+        "Cannot upgrade to 0.11.0 - legacy worktrees detected:",
+        "",
+    ]
+    for worktree in legacy_worktrees:
+        errors.append(f"  - {worktree.name}")
+
+    errors.extend(
+        [
+            "",
+            "Action required before upgrade:",
+            "  1. Complete features: spec-kitty merge <feature>",
+            "  2. OR delete worktrees: git worktree remove .worktrees/<feature>",
+            "",
+            "Use: spec-kitty list-legacy-features to see all legacy worktrees",
+        ]
+    )
+    return False, errors
+
+
+def _load_template_sources(base) -> Optional[Dict[str, str]]:
+    contents: Dict[str, str] = {}
+    for name in TEMPLATE_FILES:
+        resource = base.joinpath(name)
+        if not resource.exists():
+            return None
+        contents[name] = resource.read_text(encoding="utf-8")
+    return contents
+
+
+def _resolve_template_sources() -> Optional[Dict[str, str]]:
+    local_repo = get_local_repo_root()
+    if local_repo:
+        candidates = [
+            local_repo / "src" / "specify_cli" / "missions" / MISSION_NAME / "command-templates",  # 011: New location
+            local_repo / ".kittify" / "missions" / MISSION_NAME / "command-templates",  # Legacy (pre-011)
+        ]
+        for candidate in candidates:
+            if candidate.exists():
+                contents = _load_template_sources(candidate)
+                if contents:
+                    return contents
+
+    # 011: Templates packaged in src/specify_cli/missions/
+    data_root = files("specify_cli")
+    candidate = data_root.joinpath("missions", MISSION_NAME, "command-templates")
+    if candidate.exists():
+        contents = _load_template_sources(candidate)
+        if contents:
+            return contents
+
+    return None
+
+
+def update_template_sources(project_root: Path, dry_run: bool = False) -> Tuple[List[str], List[str]]:
+    """Update mission command templates with workspace-per-WP workflow text."""
+    changes: List[str] = []
+    errors: List[str] = []
+
+    templates_dir = project_root / ".kittify" / "missions" / MISSION_NAME / "command-templates"
+    if not templates_dir.exists():
+        errors.append(f"Missing mission templates at {templates_dir}")
+        return changes, errors
+
+    source_templates = _resolve_template_sources()
+    if not source_templates:
+        errors.append("Unable to locate packaged mission templates for update")
+        return changes, errors
+
+    updated = 0
+    for name, content in source_templates.items():
+        dest_path = templates_dir / name
+        current = dest_path.read_text(encoding="utf-8") if dest_path.exists() else None
+        if current == content:
+            continue
+
+        if dry_run:
+            changes.append(f"Would update {dest_path}")
+        else:
+            dest_path.write_text(content, encoding="utf-8")
+            changes.append(f"Updated {dest_path}")
+        updated += 1
+
+    if updated == 0:
+        changes.append("Templates already up to date")
+
+    return changes, errors
+
+
+@MigrationRegistry.register
+class WorkspacePerWPMigration(BaseMigration):
+    """Upgrade templates for workspace-per-WP model with dependency tracking."""
+
+    migration_id = MIGRATION_ID
+    description = MIGRATION_DESCRIPTION
+    target_version = MIGRATION_VERSION
+
+    def detect(self, project_path: Path) -> bool:
+        """Detect if mission templates need workspace-per-WP updates."""
+        templates_dir = project_path / ".kittify" / "missions" / MISSION_NAME / "command-templates"
+        if not templates_dir.exists():
+            return False
+
+        source_templates = _resolve_template_sources()
+        if not source_templates:
+            return False
+
+        for name, content in source_templates.items():
+            dest_path = templates_dir / name
+            if not dest_path.exists():
+                return True
+            if dest_path.read_text(encoding="utf-8") != content:
+                return True
+
+        return False
+
+    def can_apply(self, project_path: Path) -> tuple[bool, str]:
+        """Block upgrade when legacy worktrees exist."""
+        is_valid, errors = validate_upgrade(project_path)
+        if not is_valid:
+            return False, "\n".join(errors)
+        return True, ""
+
+    def apply(self, project_path: Path, dry_run: bool = False) -> MigrationResult:
+        """Apply the workspace-per-WP migration."""
+        changes, errors = update_template_sources(project_path, dry_run=dry_run)
+        success = len(errors) == 0
+        return MigrationResult(
+            success=success,
+            changes_made=changes,
+            errors=errors,
+            warnings=[],
+        )

specify_cli/upgrade/migrations/m_0_11_1_improved_workflow_templates.py

@@ -0,0 +1,173 @@
+"""Migration: Update workflow templates with end-of-output instructions."""
+
+from __future__ import annotations
+
+import shutil
+from pathlib import Path
+from typing import List
+
+from ..registry import MigrationRegistry
+from .base import BaseMigration, MigrationResult
+from .m_0_9_1_complete_lane_migration import get_agent_dirs_for_project
+
+
+@MigrationRegistry.register
+class ImprovedWorkflowTemplatesMigration(BaseMigration):
+    """Update implement and review templates with improved agent guidance.
+
+    This migration addresses workflow command state corruption issues by:
+    1. Warning agents about long output (1000+ lines)
+    2. Instructing agents to scroll to bottom for completion commands
+    3. Emphasizing that Python scripts handle all file updates automatically
+    4. Removing manual file editing requirements from instructions
+
+    The workflow.py commands now repeat completion instructions at the END
+    of output, after the long WP prompt content.
+    """
+
+    migration_id = "0.11.1_improved_workflow_templates"
+    description = "Update workflow templates with end-of-output instructions"
+    target_version = "0.11.1"
+
+    def detect(self, project_path: Path) -> bool:
+        """Check if slash commands need updating with improved guidance."""
+        # Check if any agent directory has the old templates (without scroll warning)
+        agent_dirs = get_agent_dirs_for_project(project_path)
+
+        for agent_root, subdir in agent_dirs:
+            agent_dir = project_path / agent_root / subdir
+
+            if not agent_dir.exists():
+                continue
+
+            # Check implement.md for new structure
+            implement_file = agent_dir / "spec-kitty.implement.md"
+            if implement_file.exists():
+                content = implement_file.read_text(encoding="utf-8")
+                # New template has warning about scrolling to bottom
+                if "scroll to the BOTTOM" not in content.lower():
+                    return True
+
+            # Check review.md for new structure
+            review_file = agent_dir / "spec-kitty.review.md"
+            if review_file.exists():
+                content = review_file.read_text(encoding="utf-8")
+                # New template has warning about scrolling to bottom
+                if "scroll to the BOTTOM" not in content.lower():
+                    return True
+
+        return False
+
+    def can_apply(self, project_path: Path) -> tuple[bool, str]:
+        """Check if we can apply this migration."""
+        kittify_dir = project_path / ".kittify"
+        if not kittify_dir.exists():
+            return False, "No .kittify directory (not a spec-kitty project)"
+
+        return True, ""
+
+    def apply(self, project_path: Path, dry_run: bool = False) -> MigrationResult:
+        """Update implement and review slash commands with improved templates."""
+        changes: List[str] = []
+        warnings: List[str] = []
+        errors: List[str] = []
+
+        missions_dir = project_path / ".kittify" / "missions"
+        software_dev_templates = missions_dir / "software-dev" / "command-templates"
+
+        # Copy updated mission templates from package first (if available)
+        try:
+            import specify_cli
+        except ImportError as exc:
+            errors.append(f"Failed to import specify_cli: {exc}")
+            return MigrationResult(
+                success=False,
+                changes_made=changes,
+                errors=errors,
+                warnings=warnings,
+            )
+
+        pkg_root = Path(specify_cli.__file__).parent
+        pkg_templates = pkg_root / "missions" / "software-dev" / "command-templates"
+        if not pkg_templates.exists():
+            pkg_templates = pkg_root / ".kittify" / "missions" / "software-dev" / "command-templates"
+
+        if pkg_templates.exists():
+            if not dry_run:
+                software_dev_templates.mkdir(parents=True, exist_ok=True)
+            for template_name in ("implement.md", "review.md"):
+                src = pkg_templates / template_name
+                if not src.exists():
+                    warnings.append(f"Package template missing: {template_name}")
+                    continue
+                if dry_run:
+                    changes.append(f"Would update mission template: software-dev/{template_name}")
+                else:
+                    try:
+                        shutil.copy2(src, software_dev_templates / template_name)
+                        changes.append(f"Updated mission template: software-dev/{template_name}")
+                    except OSError as e:
+                        warnings.append(f"Failed to copy mission template {template_name}: {e}")
+        else:
+            warnings.append(
+                "Mission templates not found in package. "
+                "Slash commands may already be updated or require manual repair."
+            )
+
+        # Update implement.md and review.md in configured agent directories only
+        templates_to_update = ["implement.md", "review.md"]
+        total_updated = 0
+
+        # Get agent dirs respecting user's config
+        agent_dirs_to_process = get_agent_dirs_for_project(project_path)
+
+        for agent_root, subdir in agent_dirs_to_process:
+            agent_dir = project_path / agent_root / subdir
+
+            # Skip if directory doesn't exist (respect user deletions)
+            if not agent_dir.exists():
+                continue
+
+            updated_count = 0
+            for template_name in templates_to_update:
+                source_template = software_dev_templates / template_name
+                if not source_template.exists():
+                    continue
+
+                dest_filename = f"spec-kitty.{template_name}"
+                dest_path = agent_dir / dest_filename
+
+                if dry_run:
+                    changes.append(f"Would update {agent_root}: {dest_filename}")
+                else:
+                    try:
+                        dest_path.write_text(
+                            source_template.read_text(encoding="utf-8"),
+                            encoding="utf-8",
+                        )
+                        updated_count += 1
+                    except OSError as e:
+                        warnings.append(f"Failed to update {agent_root}/{dest_filename}: {e}")
+
+            if updated_count > 0:
+                agent_name = agent_root.strip(".")
+                changes.append(f"Updated {updated_count} templates for {agent_name}")
+                total_updated += updated_count
+
+        if total_updated > 0:
+            changes.append(f"Total: Updated {total_updated} slash command templates across all agents")
+            changes.append("Templates now warn agents to scroll to bottom of long output")
+            changes.append("Templates emphasize automated file updates (no manual editing)")
+            changes.append("Prevents state corruption from incomplete workflows")
+        elif not changes:
+            warnings.append(
+                "No templates were updated (already updated or mission templates missing)"
+            )
+
+        success = len(errors) == 0
+        return MigrationResult(
+            success=success,
+            changes_made=changes,
+            errors=errors,
+            warnings=warnings,
+        )

specify_cli/upgrade/migrations/m_0_11_1_update_implement_slash_command.py

@@ -0,0 +1,160 @@
+"""Migration: Update /spec-kitty.implement slash command across all agents.
+
+This migration fixes a critical bug where the /spec-kitty.implement slash command
+was severely outdated after the 0.11.0 workspace-per-WP migration.
+
+Issue: The slash command only documented step 1 (display prompt via workflow command)
+but did NOT tell agents to run step 2 (create worktree via implement command).
+
+This caused agents to see the prompt but never create the workspace, resulting in
+"no such file or directory" errors when trying to cd to .worktrees/.
+
+Fix: Copy the correct implement.md template from packaged missions to all 12
+agent directories.
+"""
+
+from __future__ import annotations
+
+import shutil
+from pathlib import Path
+from typing import List, Tuple
+
+try:
+    from importlib.resources import files
+except ImportError:
+    from importlib_resources import files  # type: ignore
+
+from ..registry import MigrationRegistry
+from .base import BaseMigration, MigrationResult
+from .m_0_9_1_complete_lane_migration import get_agent_dirs_for_project
+
+
+@MigrationRegistry.register
+class UpdateImplementSlashCommandMigration(BaseMigration):
+    """Update /spec-kitty.implement slash command to show 2-step workflow.
+
+    The 0.11.0 migration updated mission templates but did NOT update agent
+    slash commands. This migration copies the correct implement.md template
+    from packaged missions to all agent directories.
+    """
+
+    migration_id = "0.11.1_update_implement_slash_command"
+    description = "Update /spec-kitty.implement slash command to show 2-step workflow"
+    target_version = "0.11.1"
+
+    MISSION_NAME = "software-dev"
+    TEMPLATE_FILE = "implement.md"
+    SLASH_COMMAND_FILE = "spec-kitty.implement.md"
+
+    def detect(self, project_path: Path) -> bool:
+        """Check if any agent has outdated implement slash command."""
+        # Check for old single-step pattern that's missing the critical step 2
+        old_pattern = "spec-kitty agent workflow implement $ARGUMENTS"
+
+        agent_dirs = get_agent_dirs_for_project(project_path)
+        for agent_dir, subdir in agent_dirs:
+            slash_cmd = project_path / agent_dir / subdir / self.SLASH_COMMAND_FILE
+            if slash_cmd.exists():
+                content = slash_cmd.read_text(encoding="utf-8")
+                # If it has the old single-command pattern and NOT the two-step section
+                if old_pattern in content and "CRITICAL: This is a TWO-STEP Command" not in content:
+                    return True
+                # If it's missing step 2 entirely
+                if "spec-kitty implement WP##" not in content:
+                    return True
+
+        return False
+
+    def can_apply(self, project_path: Path) -> tuple[bool, str]:
+        """Check if we can read the template from packaged missions."""
+        # Try to load from packaged data
+        try:
+            data_root = files("specify_cli")
+            template_path = data_root.joinpath(
+                "missions", self.MISSION_NAME, "command-templates", self.TEMPLATE_FILE
+            )
+            if template_path.exists():
+                return True, ""
+        except Exception as e:
+            return False, f"Cannot access packaged missions: {e}"
+
+        return False, "Template not found in packaged missions"
+
+    def apply(self, project_path: Path, dry_run: bool = False) -> MigrationResult:
+        """Update implement slash command across all agent directories."""
+        changes: List[str] = []
+        warnings: List[str] = []
+        errors: List[str] = []
+
+        # Load template from packaged missions
+        try:
+            data_root = files("specify_cli")
+            template_path = data_root.joinpath(
+                "missions", self.MISSION_NAME, "command-templates", self.TEMPLATE_FILE
+            )
+
+            if not template_path.exists():
+                errors.append("Template not found in packaged missions")
+                return MigrationResult(
+                    success=False,
+                    changes_made=changes,
+                    errors=errors,
+                    warnings=warnings,
+                )
+
+            template_content = template_path.read_text(encoding="utf-8")
+        except Exception as e:
+            errors.append(f"Failed to read template: {e}")
+            return MigrationResult(
+                success=False,
+                changes_made=changes,
+                errors=errors,
+                warnings=warnings,
+            )
+
+        # Update configured agent directories
+        agents_updated = 0
+        agent_dirs = get_agent_dirs_for_project(project_path)
+        for agent_dir, subdir in agent_dirs:
+            agent_path = project_path / agent_dir / subdir
+            slash_cmd = agent_path / self.SLASH_COMMAND_FILE
+
+            # Skip if agent directory doesn't exist
+            if not agent_path.exists():
+                continue
+
+            # Check if command needs updating
+            needs_update = False
+            if slash_cmd.exists():
+                current_content = slash_cmd.read_text(encoding="utf-8")
+                if current_content != template_content:
+                    needs_update = True
+            else:
+                needs_update = True
+
+            if needs_update:
+                if dry_run:
+                    changes.append(f"Would update: {agent_dir}/{subdir}/{self.SLASH_COMMAND_FILE}")
+                else:
+                    try:
+                        slash_cmd.write_text(template_content, encoding="utf-8")
+                        changes.append(f"Updated: {agent_dir}/{subdir}/{self.SLASH_COMMAND_FILE}")
+                        agents_updated += 1
+                    except Exception as e:
+                        errors.append(f"Failed to update {agent_dir}/{subdir}: {e}")
+
+        if agents_updated > 0:
+            if dry_run:
+                changes.append(f"Would update {agents_updated} agent directories")
+            else:
+                changes.append(f"Updated {agents_updated} agent directories")
+        else:
+            changes.append("No agent directories needed updates")
+
+        success = len(errors) == 0
+        return MigrationResult(
+            success=success,
+            changes_made=changes,
+            errors=errors,
+            warnings=warnings,
+        )

specify_cli/upgrade/migrations/m_0_11_2_improved_workflow_templates.py

@@ -0,0 +1,173 @@
+"""Migration: Update workflow templates with end-of-output instructions."""
+
+from __future__ import annotations
+
+import shutil
+from pathlib import Path
+from typing import List
+
+from ..registry import MigrationRegistry
+from .base import BaseMigration, MigrationResult
+from .m_0_9_1_complete_lane_migration import get_agent_dirs_for_project
+
+
+@MigrationRegistry.register
+class ImprovedWorkflowTemplatesMigration(BaseMigration):
+    """Update implement and review templates with improved agent guidance.
+
+    This migration addresses workflow command state corruption issues by:
+    1. Warning agents about long output (1000+ lines)
+    2. Instructing agents to scroll to bottom for completion commands
+    3. Emphasizing that Python scripts handle all file updates automatically
+    4. Removing manual file editing requirements from instructions
+
+    The workflow.py commands now repeat completion instructions at the END
+    of output, after the long WP prompt content.
+    """
+
+    migration_id = "0.11.2_improved_workflow_templates"
+    description = "Update workflow templates with end-of-output instructions and --agent requirement"
+    target_version = "0.11.2"
+
+    def detect(self, project_path: Path) -> bool:
+        """Check if slash commands need updating with improved guidance."""
+        # Check if any agent directory has the old templates (without scroll warning)
+        agent_dirs = get_agent_dirs_for_project(project_path)
+
+        for agent_root, subdir in agent_dirs:
+            agent_dir = project_path / agent_root / subdir
+
+            if not agent_dir.exists():
+                continue
+
+            # Check implement.md for new structure
+            implement_file = agent_dir / "spec-kitty.implement.md"
+            if implement_file.exists():
+                content = implement_file.read_text(encoding="utf-8")
+                # New template has warning about scrolling to bottom
+                if "scroll to the BOTTOM" not in content.lower():
+                    return True
+
+            # Check review.md for new structure
+            review_file = agent_dir / "spec-kitty.review.md"
+            if review_file.exists():
+                content = review_file.read_text(encoding="utf-8")
+                # New template has warning about scrolling to bottom
+                if "scroll to the BOTTOM" not in content.lower():
+                    return True
+
+        return False
+
+    def can_apply(self, project_path: Path) -> tuple[bool, str]:
+        """Check if we can apply this migration."""
+        kittify_dir = project_path / ".kittify"
+        if not kittify_dir.exists():
+            return False, "No .kittify directory (not a spec-kitty project)"
+
+        return True, ""
+
+    def apply(self, project_path: Path, dry_run: bool = False) -> MigrationResult:
+        """Update implement and review slash commands with improved templates."""
+        changes: List[str] = []
+        warnings: List[str] = []
+        errors: List[str] = []
+
+        missions_dir = project_path / ".kittify" / "missions"
+        software_dev_templates = missions_dir / "software-dev" / "command-templates"
+
+        # Copy updated mission templates from package first (if available)
+        try:
+            import specify_cli
+        except ImportError as exc:
+            errors.append(f"Failed to import specify_cli: {exc}")
+            return MigrationResult(
+                success=False,
+                changes_made=changes,
+                errors=errors,
+                warnings=warnings,
+            )
+
+        pkg_root = Path(specify_cli.__file__).parent
+        pkg_templates = pkg_root / "missions" / "software-dev" / "command-templates"
+        if not pkg_templates.exists():
+            pkg_templates = pkg_root / ".kittify" / "missions" / "software-dev" / "command-templates"
+
+        if pkg_templates.exists():
+            if not dry_run:
+                software_dev_templates.mkdir(parents=True, exist_ok=True)
+            for template_name in ("implement.md", "review.md"):
+                src = pkg_templates / template_name
+                if not src.exists():
+                    warnings.append(f"Package template missing: {template_name}")
+                    continue
+                if dry_run:
+                    changes.append(f"Would update mission template: software-dev/{template_name}")
+                else:
+                    try:
+                        shutil.copy2(src, software_dev_templates / template_name)
+                        changes.append(f"Updated mission template: software-dev/{template_name}")
+                    except OSError as e:
+                        warnings.append(f"Failed to copy mission template {template_name}: {e}")
+        else:
+            warnings.append(
+                "Mission templates not found in package. "
+                "Slash commands may already be updated or require manual repair."
+            )
+
+        # Update implement.md and review.md in configured agent directories only
+        templates_to_update = ["implement.md", "review.md"]
+        total_updated = 0
+
+        # Get agent dirs respecting user's config
+        agent_dirs_to_process = get_agent_dirs_for_project(project_path)
+
+        for agent_root, subdir in agent_dirs_to_process:
+            agent_dir = project_path / agent_root / subdir
+
+            # Skip if directory doesn't exist (respect user deletions)
+            if not agent_dir.exists():
+                continue
+
+            updated_count = 0
+            for template_name in templates_to_update:
+                source_template = software_dev_templates / template_name
+                if not source_template.exists():
+                    continue
+
+                dest_filename = f"spec-kitty.{template_name}"
+                dest_path = agent_dir / dest_filename
+
+                if dry_run:
+                    changes.append(f"Would update {agent_root}: {dest_filename}")
+                else:
+                    try:
+                        dest_path.write_text(
+                            source_template.read_text(encoding="utf-8"),
+                            encoding="utf-8",
+                        )
+                        updated_count += 1
+                    except OSError as e:
+                        warnings.append(f"Failed to update {agent_root}/{dest_filename}: {e}")
+
+            if updated_count > 0:
+                agent_name = agent_root.strip(".")
+                changes.append(f"Updated {updated_count} templates for {agent_name}")
+                total_updated += updated_count
+
+        if total_updated > 0:
+            changes.append(f"Total: Updated {total_updated} slash command templates across all agents")
+            changes.append("Templates now warn agents to scroll to bottom of long output")
+            changes.append("Templates emphasize automated file updates (no manual editing)")
+            changes.append("Prevents state corruption from incomplete workflows")
+        elif not changes:
+            warnings.append(
+                "No templates were updated (already updated or mission templates missing)"
+            )
+
+        success = len(errors) == 0
+        return MigrationResult(
+            success=success,
+            changes_made=changes,
+            errors=errors,
+            warnings=warnings,
+        )