spec-kitty-cli 0.12.1__py3-none-any.whl

specify_cli/upgrade/migrations/m_0_10_14_update_implement_slash_command.py

@@ -0,0 +1,176 @@
+"""Migration: Update /spec-kitty.implement slash command across all agents (0.10.14).
+
+IMPORTANT: This is a backport of m_0_11_1_update_implement_slash_command.py
+for the 0.10.x release stream. It addresses the same bug for users on 0.10.x
+before they upgrade to 0.11.x.
+
+This migration fixes a critical bug where the /spec-kitty.implement slash command
+was severely outdated after the 0.10.0-0.10.13 releases.
+
+Issue: The slash command only documented step 1 (display prompt via workflow command)
+but did NOT tell agents to run step 2 (create worktree via implement command).
+
+This caused agents to see the prompt but never create the workspace, resulting in
+"no such file or directory" errors when trying to cd to .worktrees/.
+
+Fix: Copy the correct implement.md template from packaged missions to all 12
+agent directories.
+"""
+
+from __future__ import annotations
+
+import shutil
+from pathlib import Path
+from typing import List, Tuple
+
+try:
+    from importlib.resources import files
+except ImportError:
+    from importlib_resources import files  # type: ignore
+
+from ..registry import MigrationRegistry
+from .base import BaseMigration, MigrationResult
+from .m_0_9_1_complete_lane_migration import get_agent_dirs_for_project
+
+
+@MigrationRegistry.register
+class UpdateImplementSlashCommandMigration_0_10_14(BaseMigration):
+    """Update /spec-kitty.implement slash command to show 2-step workflow (0.10.x).
+
+    This is a backport of the 0.11.1 migration for the 0.10.x release stream.
+    """
+
+    migration_id = "0.10.14_update_implement_slash_command"
+    description = "Update /spec-kitty.implement slash command to show 2-step workflow (0.10.x backport)"
+    target_version = "0.10.14"
+
+    MISSION_NAME = "software-dev"
+    TEMPLATE_FILE = "implement.md"
+    SLASH_COMMAND_FILE = "spec-kitty.implement.md"
+
+    def detect(self, project_path: Path) -> bool:
+        """Check if any agent has outdated implement slash command."""
+        # Check for old single-step pattern that's missing the critical step 2
+        old_pattern = "spec-kitty agent workflow implement $ARGUMENTS"
+
+        agent_dirs = get_agent_dirs_for_project(project_path)
+        for agent_dir, subdir in agent_dirs:
+            slash_cmd = project_path / agent_dir / subdir / self.SLASH_COMMAND_FILE
+            if slash_cmd.exists():
+                content = slash_cmd.read_text(encoding="utf-8")
+                # If it has the old single-command pattern and NOT the two-step section
+                if old_pattern in content and "CRITICAL: This is a TWO-STEP Command" not in content:
+                    return True
+                # If it's missing step 2 entirely
+                if "spec-kitty implement WP##" not in content:
+                    return True
+
+        return False
+
+    def can_apply(self, project_path: Path) -> tuple[bool, str]:
+        """Check if we can read the template from packaged missions."""
+        # For 0.10.x: Try packaged missions (should work post-0.10.8)
+        try:
+            data_root = files("specify_cli")
+            template_path = data_root.joinpath(
+                "missions", self.MISSION_NAME, "command-templates", self.TEMPLATE_FILE
+            )
+            if template_path.exists():
+                return True, ""
+        except Exception as e:
+            return False, f"Cannot access packaged missions: {e}"
+
+        # Fallback: Try legacy .kittify location (pre-0.11.0)
+        legacy_path = project_path / ".kittify" / "missions" / self.MISSION_NAME / "command-templates" / self.TEMPLATE_FILE
+        if legacy_path.exists():
+            return True, ""
+
+        return False, "Template not found in packaged missions or legacy location"
+
+    def apply(self, project_path: Path, dry_run: bool = False) -> MigrationResult:
+        """Update implement slash command across all agent directories."""
+        changes: List[str] = []
+        warnings: List[str] = []
+        errors: List[str] = []
+
+        # Load template from packaged missions or legacy location
+        template_content = None
+        template_source = None
+
+        try:
+            # Try packaged missions first (0.10.8+)
+            data_root = files("specify_cli")
+            template_path = data_root.joinpath(
+                "missions", self.MISSION_NAME, "command-templates", self.TEMPLATE_FILE
+            )
+
+            if template_path.exists():
+                template_content = template_path.read_text(encoding="utf-8")
+                template_source = "packaged missions"
+        except Exception:
+            pass
+
+        # Fallback to legacy location (pre-0.11.0)
+        if not template_content:
+            legacy_path = project_path / ".kittify" / "missions" / self.MISSION_NAME / "command-templates" / self.TEMPLATE_FILE
+            if legacy_path.exists():
+                template_content = legacy_path.read_text(encoding="utf-8")
+                template_source = "legacy .kittify/missions"
+
+        if not template_content:
+            errors.append("Template not found in packaged missions or legacy location")
+            return MigrationResult(
+                success=False,
+                changes_made=changes,
+                errors=errors,
+                warnings=warnings,
+            )
+
+        changes.append(f"Using template from: {template_source}")
+
+        # Update configured agent directories
+        agents_updated = 0
+        agent_dirs = get_agent_dirs_for_project(project_path)
+        for agent_dir, subdir in agent_dirs:
+            agent_path = project_path / agent_dir / subdir
+            slash_cmd = agent_path / self.SLASH_COMMAND_FILE
+
+            # Skip if agent directory doesn't exist
+            if not agent_path.exists():
+                continue
+
+            # Check if command needs updating
+            needs_update = False
+            if slash_cmd.exists():
+                current_content = slash_cmd.read_text(encoding="utf-8")
+                if current_content != template_content:
+                    needs_update = True
+            else:
+                needs_update = True
+
+            if needs_update:
+                if dry_run:
+                    changes.append(f"Would update: {agent_dir}/{subdir}/{self.SLASH_COMMAND_FILE}")
+                else:
+                    try:
+                        slash_cmd.write_text(template_content, encoding="utf-8")
+                        changes.append(f"Updated: {agent_dir}/{subdir}/{self.SLASH_COMMAND_FILE}")
+                        agents_updated += 1
+                    except Exception as e:
+                        errors.append(f"Failed to update {agent_dir}/{subdir}: {e}")
+
+        if agents_updated > 0:
+            if dry_run:
+                changes.append(f"Would update {agents_updated} agent directories")
+            else:
+                changes.append(f"Updated {agents_updated} agent directories")
+        else:
+            changes.append("No agent directories needed updates")
+
+        success = len(errors) == 0
+        return MigrationResult(
+            success=success,
+            changes_made=changes,
+            errors=errors,
+            warnings=warnings,
+        )

specify_cli/upgrade/migrations/m_0_10_1_populate_slash_commands.py

@@ -0,0 +1,174 @@
+"""Migration: Populate missing slash commands from mission templates."""
+
+from __future__ import annotations
+
+from pathlib import Path
+from typing import List
+
+from ..registry import MigrationRegistry
+from .base import BaseMigration, MigrationResult
+from .m_0_9_1_complete_lane_migration import get_agent_dirs_for_project
+
+
+@MigrationRegistry.register
+class PopulateSlashCommandsMigration(BaseMigration):
+    """Populate agent command directories from mission templates if missing.
+
+    Some v0.9.x projects initialized before proper template extraction
+    may have empty agent command directories. This migration ensures
+    all projects have slash commands available.
+
+    This migration:
+    1. Checks if agent command directories are empty or missing slash commands
+    2. Finds mission command templates (software-dev or active mission)
+    3. Copies templates to all agent directories with spec-kitty. prefix
+    4. Handles all 12 supported agents
+    """
+
+    migration_id = "0.10.1_populate_slash_commands"
+    description = "Populate missing slash commands from mission templates"
+    target_version = "0.10.1"
+
+    def detect(self, project_path: Path) -> bool:
+        """Check if slash commands are missing from agent directories."""
+        # Check .claude/commands/ directory
+        claude_commands = project_path / ".claude" / "commands"
+
+        # If directory doesn't exist or is empty, migration needed
+        if not claude_commands.exists():
+            return True
+
+        # Check if it has spec-kitty commands
+        slash_commands = list(claude_commands.glob("spec-kitty.*.md"))
+        if len(slash_commands) == 0:
+            return True
+
+        # If we have fewer than expected commands (should be ~10+), migration needed
+        if len(slash_commands) < 8:
+            return True
+
+        return False
+
+    def can_apply(self, project_path: Path) -> tuple[bool, str]:
+        """Check if we have mission templates to copy from."""
+        # Check for mission templates
+        missions_dir = project_path / ".kittify" / "missions"
+        if not missions_dir.exists():
+            return False, "No missions directory found"
+
+        # Look for software-dev mission (most common)
+        software_dev_templates = missions_dir / "software-dev" / "command-templates"
+        if software_dev_templates.exists():
+            return True, ""
+
+        # Look for any mission with command-templates
+        for mission_dir in missions_dir.iterdir():
+            if mission_dir.is_dir():
+                templates = mission_dir / "command-templates"
+                if templates.exists():
+                    return True, ""
+
+        return False, "No mission command templates found"
+
+    def apply(self, project_path: Path, dry_run: bool = False) -> MigrationResult:
+        """Populate slash commands from mission templates."""
+        changes: List[str] = []
+        warnings: List[str] = []
+        errors: List[str] = []
+
+        # Find mission templates
+        missions_dir = project_path / ".kittify" / "missions"
+
+        # Prefer software-dev, fallback to first available mission
+        command_templates_dir = None
+        software_dev_templates = missions_dir / "software-dev" / "command-templates"
+
+        if software_dev_templates.exists():
+            command_templates_dir = software_dev_templates
+            mission_name = "software-dev"
+        else:
+            # Find first mission with templates
+            for mission_dir in sorted(missions_dir.iterdir()):
+                if mission_dir.is_dir():
+                    templates = mission_dir / "command-templates"
+                    if templates.exists():
+                        command_templates_dir = templates
+                        mission_name = mission_dir.name
+                        break
+
+        if not command_templates_dir:
+            errors.append("No mission command templates found")
+            return MigrationResult(
+                success=False,
+                changes_made=changes,
+                errors=errors,
+                warnings=warnings,
+            )
+
+        # Populate agent command directories (respecting user config)
+        total_created = 0
+        agent_dirs_to_process = get_agent_dirs_for_project(project_path)
+
+        for agent_root, subdir in agent_dirs_to_process:
+            agent_dir = project_path / agent_root / subdir
+
+            # Only process if parent directory exists (agent was configured during init)
+            if agent_dir.parent.exists():
+                created = self._populate_agent_commands(
+                    command_templates_dir,
+                    agent_dir,
+                    "md",
+                    dry_run,
+                    changes
+                )
+                if created > 0:
+                    agent_name = agent_root.strip(".")
+                    changes.append(f"Created {created} slash commands for {agent_name} from {mission_name}")
+                    total_created += created
+
+        success = len(errors) == 0
+        return MigrationResult(
+            success=success,
+            changes_made=changes,
+            errors=errors,
+            warnings=warnings,
+        )
+
+    def _populate_agent_commands(
+        self,
+        templates_dir: Path,
+        output_dir: Path,
+        extension: str,
+        dry_run: bool,
+        changes: List[str]
+    ) -> int:
+        """Copy command templates to agent directory."""
+        created_count = 0
+
+        # Create directory if needed
+        if not output_dir.exists():
+            if dry_run:
+                changes.append(f"Would create: {output_dir}")
+            else:
+                output_dir.mkdir(parents=True, exist_ok=True)
+                changes.append(f"Created: {output_dir}")
+
+        # Copy each template
+        for template_path in sorted(templates_dir.glob("*.md")):
+            filename = f"spec-kitty.{template_path.stem}.{extension}" if extension else f"spec-kitty.{template_path.stem}"
+            dest_path = output_dir / filename
+
+            # Skip if already exists
+            if dest_path.exists():
+                continue
+
+            if dry_run:
+                changes.append(f"Would create: {dest_path.name}")
+            else:
+                # Simple copy - no variable substitution needed for basic setup
+                dest_path.write_text(template_path.read_text(encoding="utf-8"), encoding="utf-8")
+                changes.append(f"Created: {dest_path.name}")
+
+            created_count += 1
+
+        return created_count

specify_cli/upgrade/migrations/m_0_10_2_update_slash_commands.py

@@ -0,0 +1,172 @@
+"""Migration: Update slash commands to Python CLI and flat structure."""
+
+from __future__ import annotations
+
+from pathlib import Path
+from typing import List
+
+from ..registry import MigrationRegistry
+from .base import BaseMigration, MigrationResult
+from .m_0_9_1_complete_lane_migration import get_agent_dirs_for_project
+
+
+@MigrationRegistry.register
+class UpdateSlashCommandsMigration(BaseMigration):
+    """Update all agent slash commands to use Python CLI and flat tasks/ structure.
+
+    This migration addresses two critical issues from feature 008 and 007:
+    1. Slash commands still referenced deleted bash scripts (feature 008 bug)
+    2. Slash commands instructed agents to create subdirectories (feature 007 violation)
+
+    This migration:
+    1. Detects if slash commands have old bash script references
+    2. Detects if slash commands have subdirectory instructions
+    3. Re-copies templates from mission to get latest Python CLI + flat structure
+    4. Updates ALL 12 supported agent directories
+    """
+
+    migration_id = "0.10.2_update_slash_commands"
+    description = "Update slash commands to Python CLI and flat structure"
+    target_version = "0.10.2"
+
+    def detect(self, project_path: Path) -> bool:
+        """Check if slash commands need updating."""
+        # Check agent directories respecting user config
+        agent_dirs = get_agent_dirs_for_project(project_path)
+
+        for agent_root, subdir in agent_dirs:
+            agent_dir = project_path / agent_root / subdir
+
+            if not agent_dir.exists():
+                continue
+
+            # Check for bash script references (old) or subdirectory references
+            for cmd_file in agent_dir.glob("spec-kitty.*.md"):
+                content = cmd_file.read_text(encoding="utf-8")
+                # Check for bash/PowerShell scripts
+                if ".kittify/scripts/bash/" in content or "scripts/bash/" in content:
+                    return True
+                if ".kittify/scripts/powershell/" in content or "scripts/powershell/" in content:
+                    return True
+                # Check for subdirectory violations (feature 007)
+                if "tasks/planned/" in content or "tasks/doing/" in content:
+                    # Exclude "WRONG" examples
+                    if "WRONG" not in content or content.count("tasks/planned/") > 2:
+                        return True
+
+        return False
+
+    def can_apply(self, project_path: Path) -> tuple[bool, str]:
+        """Check if we have mission templates to copy from."""
+        missions_dir = project_path / ".kittify" / "missions"
+        if not missions_dir.exists():
+            return False, "No missions directory found"
+
+        # Look for software-dev mission
+        software_dev_templates = missions_dir / "software-dev" / "command-templates"
+        if software_dev_templates.exists():
+            return True, ""
+
+        # Look for any mission with command-templates
+        for mission_dir in missions_dir.iterdir():
+            if mission_dir.is_dir():
+                templates = mission_dir / "command-templates"
+                if templates.exists():
+                    return True, ""
+
+        return False, "No mission command templates found"
+
+    def apply(self, project_path: Path, dry_run: bool = False) -> MigrationResult:
+        """Update slash commands with latest templates."""
+        changes: List[str] = []
+        warnings: List[str] = []
+        errors: List[str] = []
+
+        missions_dir = project_path / ".kittify" / "missions"
+        claude_commands = project_path / ".claude" / "commands"
+
+        # Find mission templates
+        command_templates_dir = None
+        software_dev_templates = missions_dir / "software-dev" / "command-templates"
+
+        if software_dev_templates.exists():
+            command_templates_dir = software_dev_templates
+            mission_name = "software-dev"
+        else:
+            # Find first mission with templates
+            for mission_dir in sorted(missions_dir.iterdir()):
+                if mission_dir.is_dir():
+                    templates = mission_dir / "command-templates"
+                    if templates.exists():
+                        command_templates_dir = templates
+                        mission_name = mission_dir.name
+                        break
+
+        if not command_templates_dir:
+            errors.append("No mission command templates found")
+            return MigrationResult(
+                success=False,
+                changes_made=changes,
+                errors=errors,
+                warnings=warnings,
+            )
+
+        # Update slash commands in configured agent directories (overwrite existing)
+        total_updated = 0
+        agent_dirs = get_agent_dirs_for_project(project_path)
+
+        for agent_root, subdir in agent_dirs:
+            agent_dir = project_path / agent_root / subdir
+
+            if not agent_dir.exists():
+                continue
+
+            updated_count = 0
+            for template_path in sorted(command_templates_dir.glob("*.md")):
+                filename = f"spec-kitty.{template_path.stem}.md"
+                dest_path = agent_dir / filename
+
+                if dry_run:
+                    changes.append(f"Would update {agent_root}: {dest_path.name}")
+                else:
+                    dest_path.write_text(template_path.read_text(encoding="utf-8"), encoding="utf-8")
+                    updated_count += 1
+
+            if updated_count > 0:
+                agent_name = agent_root.strip(".")
+                changes.append(f"Updated {updated_count} slash commands for {agent_name}")
+                total_updated += updated_count
+
+        if total_updated > 0:
+            changes.append(f"Total: Updated {total_updated} slash commands from {mission_name} mission")
+            changes.append("Slash commands now use Python CLI (no bash scripts)")
+            changes.append("Slash commands now enforce flat tasks/ structure (feature 007)")
+
+        commands_dir = project_path / ".kittify" / "commands"
+        if commands_dir.exists():
+            toml_files = list(commands_dir.glob("*.toml"))
+            for toml_file in toml_files:
+                if dry_run:
+                    changes.append(f"Would remove legacy {toml_file.name}")
+                else:
+                    try:
+                        toml_file.unlink()
+                        changes.append(f"Removed legacy {toml_file.name}")
+                    except OSError as e:
+                        warnings.append(f"Failed to remove {toml_file.name}: {e}")
+
+            if not dry_run:
+                try:
+                    if not any(commands_dir.iterdir()):
+                        commands_dir.rmdir()
+                        changes.append("Removed empty .kittify/commands/ directory")
+                except OSError as e:
+                    warnings.append(f"Failed to remove .kittify/commands/: {e}")
+
+        success = len(errors) == 0
+        return MigrationResult(
+            success=success,
+            changes_made=changes,
+            errors=errors,
+            warnings=warnings,
+        )