roms-tools 2.6.2__py3-none-any.whl → 3.0.0__py3-none-any.whl

roms_tools/setup/tides.py

@@ -1,28 +1,31 @@
-from datetime import datetime
-import xarray as xr
-import numpy as np
-from typing import Dict, Union, List
 import importlib.metadata
-import matplotlib.pyplot as plt
-from pathlib import Path
 from dataclasses import dataclass, field
+from datetime import datetime
+from pathlib import Path
+from typing import Dict, List, Union
+
+import matplotlib.pyplot as plt
+import numpy as np
+import xarray as xr
+
 from roms_tools import Grid
 from roms_tools.plot import _plot
 from roms_tools.regrid import LateralRegridToROMS
-from roms_tools.utils import save_datasets
-from roms_tools.setup.datasets import TPXODataset
+from roms_tools.setup.datasets import TPXOManager
 from roms_tools.setup.utils import (
-    nan_check,
-    substitute_nans_by_fillvalue,
+    _from_yaml,
+    _to_dict,
+    _write_to_yaml,
+    get_target_coords,
+    get_variable_metadata,
+    get_vector_pairs,
     interpolate_from_rho_to_u,
     interpolate_from_rho_to_v,
-    get_variable_metadata,
-    get_target_coords,
+    nan_check,
     rotate_velocities,
-    get_vector_pairs,
-    _to_yaml,
-    _from_yaml,
+    substitute_nans_by_fillvalue,
 )
+from roms_tools.utils import save_datasets
 
 
 @dataclass(kw_only=True)
@@ -33,20 +36,21 @@ class TidalForcing:
     ----------
     grid : Grid
         The grid object representing the ROMS grid associated with the tidal forcing data.
-    source : Dict[str, Union[str, Path, List[Union[str, Path]]]]
+    source : Dict[str, Union[str, Path, Dict[str, Union[str, Path]]]]
         Dictionary specifying the source of the tidal data. Keys include:
 
           - "name" (str): Name of the data source (e.g., "TPXO").
-          - "path" (Union[str, Path, List[Union[str, Path]]]): The path to the raw data file(s). This can be:
+          - "path" (Union[str, Path, Dict[str, Union[str, Path]]]):
 
-            - A single string (with or without wildcards).
-            - A single Path object.
-            - A list of strings or Path objects containing multiple files.
+            - If a string or Path is provided, it represents a single file.
+            - If "name" is "TPXO", "path" can also be a dictionary with the following keys:
+
+              - "grid" (Union[str, Path]): Path to the TPXO grid file.
+              - "h" (Union[str, Path]): Path to the TPXO h-file.
+              - "u" (Union[str, Path]): Path to the TPXO u-file.
 
     ntides : int, optional
-        Number of constituents to consider. Maximum number is 14. Default is 10.
-    allan_factor : float, optional
-        The Allan factor used in tidal model computation. Default is 2.0.
+        Number of constituents to consider. Maximum number is 15. Default is 10.
     model_reference_date : datetime, optional
         The reference date for the ROMS simulation. Default is datetime(2000, 1, 1).
     use_dask: bool, optional
@@ -58,15 +62,27 @@ class TidalForcing:
 
     Examples
     --------
+    Using a TPXO dataset with separate grid, h, and u files:
+
+    >>> tidal_forcing = TidalForcing(
+    ...     grid=grid,
+    ...     source={
+    ...         "name": "TPXO",
+    ...         "path": {"grid": "tpxo_grid.nc", "h": "tpxo_h.nc", "u": "tpxo_u.nc"},
+    ...     },
+    ... )
+
+    Using a single file as a source:
+
     >>> tidal_forcing = TidalForcing(
-    ...     grid=grid, source={"name": "TPXO", "path": "tpxo_data.nc"}
+    ...     grid=grid,
+    ...     source={"name": "TPXO", "path": "tpxo_merged.nc"},
     ... )
     """
 
     grid: Grid
     source: Dict[str, Union[str, Path, List[Union[str, Path]]]]
     ntides: int = 10
-    allan_factor: float = 2.0
     model_reference_date: datetime = datetime(2000, 1, 1)
     use_dask: bool = False
     bypass_validation: bool = False
@@ -78,32 +94,35 @@ class TidalForcing:
         self._input_checks()
         target_coords = get_target_coords(self.grid)
 
-        data = self._get_data()
-        data.check_number_constituents(self.ntides)
-        data.choose_subdomain(
-            target_coords,
-            buffer_points=20,
-        )
-        # Enforce double precision to ensure reproducibility
-        data.convert_to_float64()
+        tidal_data = self._get_data()
 
-        # select desired number of constituents
-        data.ds = data.ds.isel(ntides=slice(None, self.ntides))
-        self._correct_tides(data)
+        for key, data in tidal_data.datasets.items():
+            if key != "omega":
+                data.choose_subdomain(
+                    target_coords,
+                    buffer_points=20,
+                )
+                # Enforce double precision to ensure reproducibility
+                data.convert_to_float64()
 
-        data.apply_lateral_fill()
+        tidal_data.correct_tides(self.model_reference_date)
 
         self._set_variable_info()
         var_names = self.variable_info.keys()
 
         processed_fields = {}
-        # lateral regridding
-        lateral_regrid = LateralRegridToROMS(target_coords, data.dim_names)
-        for var_name in var_names:
-            if var_name in data.var_names.keys():
-                processed_fields[var_name] = lateral_regrid.apply(
-                    data.ds[data.var_names[var_name]]
-                )
+
+        # lateral fill and regridding
+        for key, data in tidal_data.datasets.items():
+            if key != "omega":
+                data.apply_lateral_fill()
+                lateral_regrid = LateralRegridToROMS(target_coords, data.dim_names)
+
+                for var_name in var_names:
+                    if var_name in data.var_names.keys():
+                        processed_fields[var_name] = lateral_regrid.apply(
+                            data.ds[data.var_names[var_name]]
+                        )
 
         # rotation of velocities and interpolation to u/v points
         vector_pairs = get_vector_pairs(self.variable_info)
@@ -133,13 +152,15 @@ class TidalForcing:
 
         d_meta = get_variable_metadata()
         ds = self._write_into_dataset(processed_fields, d_meta)
-        ds["omega"] = data.ds["omega"]
 
         ds = self._add_global_metadata(ds)
 
         if not self.bypass_validation:
             self._validate(ds)
 
+        ds = ds.assign_coords({"omega": tidal_data.datasets["omega"]})
+        ds["ntides"].attrs["long_name"] = "constituent label"
+
         # substitute NaNs over land by a fill value to avoid blow-up of ROMS
         for var_name in ds.data_vars:
             ds[var_name] = substitute_nans_by_fillvalue(ds[var_name])
@@ -152,13 +173,40 @@ class TidalForcing:
             raise ValueError("`source` must include a 'name'.")
         if "path" not in self.source.keys():
             raise ValueError("`source` must include a 'path'.")
+        if self.ntides > 15:
+            raise ValueError("`ntides` must be at most 15.")
 
     def _get_data(self):
+        """Loads tidal forcing data based on the specified source."""
 
         if self.source["name"] == "TPXO":
-            data = TPXODataset(filename=self.source["path"], use_dask=self.use_dask)
+            if isinstance(self.source["path"], dict):
+                fname_dict = {
+                    "grid": self.source["path"]["grid"],
+                    "h": self.source["path"]["h"],
+                    "u": self.source["path"]["u"],
+                }
+
+            elif isinstance(self.source["path"], (str, Path)):
+                fname_dict = {
+                    "grid": self.source["path"],
+                    "h": self.source["path"],
+                    "u": self.source["path"],
+                }
+            else:
+                raise ValueError(
+                    'For TPXO, source["path"] must be either a string, Path, or a dictionary with "grid", "h", and "u" keys.'
+                )
+
+            data = TPXOManager(
+                filenames=fname_dict,
+                ntides=self.ntides,
+                use_dask=self.use_dask,
+            )
+
         else:
             raise ValueError('Only "TPXO" is a valid option for source["name"].')
+
         return data
 
     def _set_variable_info(self):
@@ -168,7 +216,6 @@ class TidalForcing:
         - `location`: Where the variable resides in the grid (e.g., rho, u, or v points).
         - `is_vector`: Whether the variable is part of a vector (True for velocity components like 'u' and 'v').
         - `vector_pair`: For vector variables, this indicates the associated variable that forms the vector (e.g., 'u' and 'v').
-        - `is_3d`: Indicates whether the variable is 3D (True for variables like 'temp' and 'salt') or 2D (False for 'zeta').
 
         Returns
         -------
@@ -179,7 +226,6 @@ class TidalForcing:
             "location": "rho",
             "is_vector": False,
             "vector_pair": None,
-            "is_3d": False,
         }
 
         # Define a dictionary for variable names and their associated information
@@ -192,28 +238,24 @@ class TidalForcing:
                 "location": "u",
                 "is_vector": True,
                 "vector_pair": "v_Re",
-                "is_3d": False,
                 "validate": True,
             },
             "v_Re": {
                 "location": "v",
                 "is_vector": True,
                 "vector_pair": "u_Re",
-                "is_3d": False,
                 "validate": True,
             },
             "u_Im": {
                 "location": "u",
                 "is_vector": True,
                 "vector_pair": "v_Im",
-                "is_3d": False,
                 "validate": False,
             },
             "v_Im": {
                 "location": "v",
                 "is_vector": True,
                 "vector_pair": "u_Im",
-                "is_3d": False,
                 "validate": False,
             },
         }
@@ -247,7 +289,6 @@ class TidalForcing:
 
         ds.attrs["source"] = self.source["name"]
         ds.attrs["model_reference_date"] = str(self.model_reference_date)
-        ds.attrs["allan_factor"] = self.allan_factor
 
         return ds
 
@@ -355,7 +396,10 @@ class TidalForcing:
             lon_deg = xr.where(lon_deg > 180, lon_deg - 360, lon_deg)
         field = field.assign_coords({"lon": lon_deg, "lat": lat_deg})
 
-        title = "%s, ntides = %i" % (field.long_name, self.ds[var_name].ntides[ntides])
+        title = "%s, constituent: %s" % (
+            field.long_name,
+            self.ds[var_name].ntides[ntides].values.item().decode("utf-8"),
+        )
 
         vmax = max(field.max(), -field.min())
         vmin = -vmax
@@ -412,7 +456,8 @@ class TidalForcing:
             The path to the YAML file where the parameters will be saved.
         """
 
-        _to_yaml(self, filepath)
+        forcing_dict = _to_dict(self)
+        _write_to_yaml(forcing_dict, filepath)
 
     @classmethod
     def from_yaml(
@@ -443,374 +488,3 @@ class TidalForcing:
             **tidal_forcing_params,
             use_dask=use_dask,
         )
-
-    def _correct_tides(self, data):
-        """Apply tidal corrections to the dataset. This method corrects the dataset for
-        equilibrium tides, self-attraction and loading (SAL) effects, and adjusts phases
-        and amplitudes of tidal elevations and transports using Egbert's correction.
-
-        Parameters
-        ----------
-        data : Dataset
-            The dataset containing tidal data, including variables for sea surface height (ssh), zonal and meridional
-            currents (u, v), and self-attraction and loading corrections (sal).
-        Returns
-        -------
-        None
-            The dataset is modified in-place with corrected real and imaginary components for ssh, u, v, and the
-            potential field ('pot_Re', 'pot_Im').
-        """
-
-        # Get equilibrium tides
-        tpc = compute_equilibrium_tide(
-            data.ds[data.dim_names["longitude"]], data.ds[data.dim_names["latitude"]]
-        )
-        tpc = tpc.isel(ntides=data.ds["ntides"])
-        # Correct for SAL
-        tsc = self.allan_factor * (
-            data.ds[data.var_names["sal_Re"]] + 1j * data.ds[data.var_names["sal_Im"]]
-        )
-        tpc = tpc - tsc
-
-        # Elevations and transports
-        thc = data.ds[data.var_names["ssh_Re"]] + 1j * data.ds[data.var_names["ssh_Im"]]
-        tuc = data.ds[data.var_names["u_Re"]] + 1j * data.ds[data.var_names["u_Im"]]
-        tvc = data.ds[data.var_names["v_Re"]] + 1j * data.ds[data.var_names["v_Im"]]
-
-        # Apply correction for phases and amplitudes
-        pf, pu, aa = egbert_correction(self.model_reference_date)
-        pf = pf.isel(ntides=data.ds["ntides"])
-        pu = pu.isel(ntides=data.ds["ntides"])
-        aa = aa.isel(ntides=data.ds["ntides"])
-
-        dt = (self.model_reference_date - data.reference_date).days * 3600 * 24
-
-        thc = pf * thc * np.exp(1j * (data.ds["omega"] * dt + pu + aa))
-        tuc = pf * tuc * np.exp(1j * (data.ds["omega"] * dt + pu + aa))
-        tvc = pf * tvc * np.exp(1j * (data.ds["omega"] * dt + pu + aa))
-        tpc = pf * tpc * np.exp(1j * (data.ds["omega"] * dt + pu + aa))
-
-        data.ds[data.var_names["ssh_Re"]] = thc.real
-        data.ds[data.var_names["ssh_Im"]] = thc.imag
-        data.ds[data.var_names["u_Re"]] = tuc.real
-        data.ds[data.var_names["u_Im"]] = tuc.imag
-        data.ds[data.var_names["v_Re"]] = tvc.real
-        data.ds[data.var_names["v_Im"]] = tvc.imag
-        data.ds["pot_Re"] = tpc.real
-        data.ds["pot_Im"] = tpc.imag
-
-        # Update var_names dictionary
-        var_names = {**data.var_names, "pot_Re": "pot_Re", "pot_Im": "pot_Im"}
-        var_names.pop("sal_Re", None)  # Remove "sal_Re" if it exists
-        var_names.pop("sal_Im", None)  # Remove "sal_Im" if it exists
-
-        data.var_names = var_names
-
-
-def modified_julian_days(year, month, day, hour=0):
-    """Calculate the Modified Julian Day (MJD) for a given date and time.
-
-    The Modified Julian Day (MJD) is a modified Julian day count starting from
-    November 17, 1858 AD. It is commonly used in astronomy and geodesy.
-
-    Parameters
-    ----------
-    year : int
-        The year.
-    month : int
-        The month (1-12).
-    day : int
-        The day of the month.
-    hour : float, optional
-        The hour of the day as a fractional number (0 to 23.999...). Default is 0.
-
-    Returns
-    -------
-    mjd : float
-        The Modified Julian Day (MJD) corresponding to the input date and time.
-
-    Notes
-    -----
-    The algorithm assumes that the input date (year, month, day) is within the
-    Gregorian calendar, i.e., after October 15, 1582. Negative MJD values are
-    allowed for dates before November 17, 1858.
-
-    References
-    ----------
-    - Wikipedia article on Julian Day: https://en.wikipedia.org/wiki/Julian_day
-    - Wikipedia article on Modified Julian Day: https://en.wikipedia.org/wiki/Modified_Julian_day
-
-    Examples
-    --------
-    >>> modified_julian_days(2024, 5, 20, 12)
-    58814.0
-    >>> modified_julian_days(1858, 11, 17)
-    0.0
-    >>> modified_julian_days(1582, 10, 4)
-    -141428.5
-    """
-
-    if month < 3:
-        year -= 1
-        month += 12
-
-    A = year // 100
-    B = A // 4
-    C = 2 - A + B
-    E = int(365.25 * (year + 4716))
-    F = int(30.6001 * (month + 1))
-    jd = C + day + hour / 24 + E + F - 1524.5
-    mjd = jd - 2400000.5
-
-    return mjd
-
-
-def egbert_correction(date):
-    """Correct phases and amplitudes for real-time runs using parts of the post-
-    processing code from Egbert's & Erofeeva's (OSU) TPXO model.
-
-    Parameters
-    ----------
-    date : datetime.datetime
-        The date and time for which corrections are to be applied.
-
-    Returns
-    -------
-    pf : xr.DataArray
-        Amplitude scaling factor for each of the 15 tidal constituents.
-    pu : xr.DataArray
-        Phase correction [radians] for each of the 15 tidal constituents.
-    aa : xr.DataArray
-        Astronomical arguments [radians] associated with the corrections.
-
-    References
-    ----------
-    - Egbert, G.D., and S.Y. Erofeeva. "Efficient inverse modeling of barotropic ocean
-      tides." Journal of Atmospheric and Oceanic Technology 19, no. 2 (2002): 183-204.
-    """
-
-    year = date.year
-    month = date.month
-    day = date.day
-    hour = date.hour
-    minute = date.minute
-    second = date.second
-
-    rad = np.pi / 180.0
-    deg = 180.0 / np.pi
-    mjd = modified_julian_days(year, month, day)
-    tstart = mjd + hour / 24 + minute / (60 * 24) + second / (60 * 60 * 24)
-
-    # Determine nodal corrections pu & pf : these expressions are valid for period 1990-2010 (Cartwright 1990).
-    # Reset time origin for astronomical arguments to 4th of May 1860:
-    timetemp = tstart - 51544.4993
-
-    # mean longitude of lunar perigee
-    P = 83.3535 + 0.11140353 * timetemp
-    P = np.mod(P, 360.0)
-    if P < 0:
-        P = +360
-    P *= rad
-
-    # mean longitude of ascending lunar node
-    N = 125.0445 - 0.05295377 * timetemp
-    N = np.mod(N, 360.0)
-    if N < 0:
-        N = +360
-    N *= rad
-
-    sinn = np.sin(N)
-    cosn = np.cos(N)
-    sin2n = np.sin(2 * N)
-    cos2n = np.cos(2 * N)
-    sin3n = np.sin(3 * N)
-
-    pftmp = np.sqrt(
-        (1 - 0.03731 * cosn + 0.00052 * cos2n) ** 2
-        + (0.03731 * sinn - 0.00052 * sin2n) ** 2
-    )  # 2N2
-
-    pf = np.zeros(15)
-    pf[0] = pftmp  # M2
-    pf[1] = 1.0  # S2
-    pf[2] = pftmp  # N2
-    pf[3] = np.sqrt(
-        (1 + 0.2852 * cosn + 0.0324 * cos2n) ** 2
-        + (0.3108 * sinn + 0.0324 * sin2n) ** 2
-    )  # K2
-    pf[4] = np.sqrt(
-        (1 + 0.1158 * cosn - 0.0029 * cos2n) ** 2
-        + (0.1554 * sinn - 0.0029 * sin2n) ** 2
-    )  # K1
-    pf[5] = np.sqrt(
-        (1 + 0.189 * cosn - 0.0058 * cos2n) ** 2 + (0.189 * sinn - 0.0058 * sin2n) ** 2
-    )  # O1
-    pf[6] = 1.0  # P1
-    pf[7] = np.sqrt((1 + 0.188 * cosn) ** 2 + (0.188 * sinn) ** 2)  # Q1
-    pf[8] = 1.043 + 0.414 * cosn  # Mf
-    pf[9] = 1.0 - 0.130 * cosn  # Mm
-    pf[10] = pftmp**2  # M4
-    pf[11] = pftmp**2  # Mn4
-    pf[12] = pftmp**2  # Ms4
-    pf[13] = pftmp  # 2n2
-    pf[14] = 1.0  # S1
-    pf = xr.DataArray(pf, dims="ntides")
-
-    putmp = (
-        np.arctan(
-            (-0.03731 * sinn + 0.00052 * sin2n)
-            / (1.0 - 0.03731 * cosn + 0.00052 * cos2n)
-        )
-        * deg
-    )  # 2N2
-
-    pu = np.zeros(15)
-    pu[0] = putmp  # M2
-    pu[1] = 0.0  # S2
-    pu[2] = putmp  # N2
-    pu[3] = (
-        np.arctan(
-            -(0.3108 * sinn + 0.0324 * sin2n) / (1.0 + 0.2852 * cosn + 0.0324 * cos2n)
-        )
-        * deg
-    )  # K2
-    pu[4] = (
-        np.arctan(
-            (-0.1554 * sinn + 0.0029 * sin2n) / (1.0 + 0.1158 * cosn - 0.0029 * cos2n)
-        )
-        * deg
-    )  # K1
-    pu[5] = 10.8 * sinn - 1.3 * sin2n + 0.2 * sin3n  # O1
-    pu[6] = 0.0  # P1
-    pu[7] = np.arctan(0.189 * sinn / (1.0 + 0.189 * cosn)) * deg  # Q1
-    pu[8] = -23.7 * sinn + 2.7 * sin2n - 0.4 * sin3n  # Mf
-    pu[9] = 0.0  # Mm
-    pu[10] = putmp * 2.0  # M4
-    pu[11] = putmp * 2.0  # Mn4
-    pu[12] = putmp  # Ms4
-    pu[13] = putmp  # 2n2
-    pu[14] = 0.0  # S1
-    pu = xr.DataArray(pu, dims="ntides")
-    # convert from degrees to radians
-    pu = pu * rad
-
-    aa = xr.DataArray(
-        data=np.array(
-            [
-                1.731557546,  # M2
-                0.0,  # S2
-                6.050721243,  # N2
-                3.487600001,  # K2
-                0.173003674,  # K1
-                1.558553872,  # O1
-                6.110181633,  # P1
-                5.877717569,  # Q1
-                1.964021610,  # Mm
-                1.756042456,  # Mf
-                3.463115091,  # M4
-                1.499093481,  # Mn4
-                1.731557546,  # Ms4
-                4.086699633,  # 2n2
-                0.0,  # S1
-            ]
-        ),
-        dims="ntides",
-    )
-
-    return pf, pu, aa
-
-
-def compute_equilibrium_tide(lon, lat):
-    """Compute equilibrium tide for given longitudes and latitudes.
-
-    Parameters
-    ----------
-    lon : xr.DataArray
-        Longitudes in degrees.
-    lat : xr.DataArray
-        Latitudes in degrees.
-
-    Returns
-    -------
-    tpc : xr.DataArray
-        Equilibrium tide complex amplitude.
-
-    Notes
-    -----
-    This method computes the equilibrium tide complex amplitude for given longitudes
-    and latitudes. It considers 15 tidal constituents and their corresponding
-    amplitudes and elasticity factors. The types of tides are classified as follows:
-        - 2: semidiurnal
-        - 1: diurnal
-        - 0: long-term
-    """
-
-    # Amplitudes and elasticity factors for 15 tidal constituents
-    A = xr.DataArray(
-        data=np.array(
-            [
-                0.242334,  # M2
-                0.112743,  # S2
-                0.046397,  # N2
-                0.030684,  # K2
-                0.141565,  # K1
-                0.100661,  # O1
-                0.046848,  # P1
-                0.019273,  # Q1
-                0.042041,  # Mf
-                0.022191,  # Mm
-                0.0,  # M4
-                0.0,  # Mn4
-                0.0,  # Ms4
-                0.006141,  # 2n2
-                0.000764,  # S1
-            ]
-        ),
-        dims="ntides",
-    )
-    B = xr.DataArray(
-        data=np.array(
-            [
-                0.693,  # M2
-                0.693,  # S2
-                0.693,  # N2
-                0.693,  # K2
-                0.736,  # K1
-                0.695,  # O1
-                0.706,  # P1
-                0.695,  # Q1
-                0.693,  # Mf
-                0.693,  # Mm
-                0.693,  # M4
-                0.693,  # Mn4
-                0.693,  # Ms4
-                0.693,  # 2n2
-                0.693,  # S1
-            ]
-        ),
-        dims="ntides",
-    )
-
-    # types: 2 = semidiurnal, 1 = diurnal, 0 = long-term
-    ityp = xr.DataArray(
-        data=np.array([2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0, 0, 2, 1]), dims="ntides"
-    )
-
-    d2r = np.pi / 180
-    coslat2 = np.cos(d2r * lat) ** 2
-    sin2lat = np.sin(2 * d2r * lat)
-
-    p_amp = (
-        xr.where(ityp == 2, 1, 0) * A * B * coslat2  # semidiurnal
-        + xr.where(ityp == 1, 1, 0) * A * B * sin2lat  # diurnal
-        + xr.where(ityp == 0, 1, 0) * A * B * (0.5 - 1.5 * coslat2)  # long-term
-    )
-    p_pha = (
-        xr.where(ityp == 2, 1, 0) * (-2 * lon * d2r)  # semidiurnal
-        + xr.where(ityp == 1, 1, 0) * (-lon * d2r)  # diurnal
-        + xr.where(ityp == 0, 1, 0) * xr.zeros_like(lon)  # long-term
-    )
-
-    tpc = p_amp * np.exp(-1j * p_pha)
-
-    return tpc

roms_tools/setup/topography.py

@@ -1,13 +1,15 @@
-import time
 import logging
-import xarray as xr
-import numpy as np
-import gcm_filters
-from roms_tools.setup.utils import handle_boundaries
+import time
 import warnings
 from itertools import count
+
+import gcm_filters
+import numpy as np
+import xarray as xr
+
 from roms_tools.regrid import LateralRegridToROMS
 from roms_tools.setup.datasets import ETOPO5Dataset, SRTM15Dataset
+from roms_tools.setup.utils import handle_boundaries
 
 
 def _add_topography(
@@ -400,7 +402,9 @@ def _add_topography_metadata(ds, topography_source, smooth_factor, hmin, rmax):
     xarray.Dataset
         Updated dataset with added metadata.
     """
-    ds.attrs["topography_source"] = topography_source["name"]
+    ds.attrs["topography_source_name"] = topography_source["name"]
+    if "path" in topography_source:
+        ds.attrs["topography_source_path"] = topography_source["path"]
     ds.attrs["hmin"] = hmin
 
     return ds