qontract-reconcile 0.10.2.dev14__py3-none-any.whl → 0.10.2.dev15__py3-none-any.whl

reconcile/utils/raw_github_api.py

@@ -44,28 +44,21 @@ class RawGithubApi:
         result = res.json()
 
         if isinstance(result, list):
-            elements = []
-
-            for element in result:
-                elements.append(element)
-
+            elements = list(result)
             while "last" in res.links and "next" in res.links:
                 if res.links["last"]["url"] == res.links["next"]["url"]:
                     req_url = res.links["next"]["url"]
                     res = requests.get(req_url, headers=h, timeout=60)
                     res.raise_for_status()
 
-                    for element in res.json():
-                        elements.append(element)
-
+                    elements.extend(element for element in res.json())
                     return elements
 
                 req_url = res.links["next"]["url"]
                 res = requests.get(req_url, headers=h, timeout=60)
                 res.raise_for_status()
 
-                for element in res.json():
-                    elements.append(element)
+                elements.extend(element for element in res.json())
 
             return elements
 

reconcile/utils/repo_owners.py

@@ -92,15 +92,15 @@ class RepoOwners:
         :return: the path closest owners
         :rtype: dict
         """
-        candidates = []
+        candidates = [
+            owned_path
+            for owned_path in self.owners_map
+            if os.path.commonpath([path, owned_path]) == owned_path
+        ]
 
         if "." in self.owners_map:
             candidates.append(".")
 
-        for owned_path in self.owners_map:
-            if os.path.commonpath([path, owned_path]) == owned_path:
-                candidates.append(owned_path)
-
         if candidates:
             # The longest owned_path is the chosen
             elected = max(candidates, key=len)

reconcile/utils/rest_api_base.py

@@ -81,8 +81,7 @@ class ApiBase:
             return response.json()
         except requests.exceptions.JSONDecodeError:
             logging.error(
-                f"Failed to decode JSON response from {url}"
-                f"Response: {response.text}"
+                f"Failed to decode JSON response from {url}Response: {response.text}"
             )
             raise
 

reconcile/utils/rosa/rosa_cli.py

@@ -141,13 +141,13 @@ class RosaJob(K8sJob, BaseModel, frozen=True, arbitrary_types_allowed=True):
         }
 
     def annotations(self) -> dict[str, str]:
-        _annotations = {
+        annotations = {
             "qontract.rosa.aws_account_id": self.aws_account_id,
             "qontract.rosa.aws_region": self.aws_region,
             "qontract.rosa.ocm_org_id": self.ocm_org_id,
         }
-        _annotations.update(self.extra_annotations)
-        return _annotations
+        annotations.update(self.extra_annotations)
+        return annotations
 
     def secret_data(self) -> dict[str, str]:
         return {"OCM_TOKEN": self.ocm_token}

reconcile/utils/saasherder/saasherder.py

@@ -226,7 +226,7 @@ class SaasHerder:  # pylint: disable=too-many-public-methods
         if not allowed_secret_parameter_paths:
             self.valid = False
             logging.error(
-                f"[{saas_file_name}] " f"missing allowedSecretParameterPaths section"
+                f"[{saas_file_name}] missing allowedSecretParameterPaths section"
             )
             return
         for sp in secret_parameters:
@@ -558,8 +558,7 @@ class SaasHerder:  # pylint: disable=too-many-public-methods
     ) -> None:
         if target.image and target.upstream:
             logging.error(
-                f"[{saas_file_name}/{resource_template_name}] "
-                f"image used with upstream"
+                f"[{saas_file_name}/{resource_template_name}] image used with upstream"
             )
             self.valid = False
 
@@ -1056,35 +1055,30 @@ class SaasHerder:  # pylint: disable=too-many-public-methods
 
     @staticmethod
     def _collect_images(resource: Resource) -> set[str]:
-        images = set()
+        images: set[str] = set()
         # resources with pod templates
         with suppress(KeyError):
             template = resource["spec"]["template"]
-            for c in template["spec"]["containers"]:
-                images.add(c["image"])
+            images.update(c["image"] for c in template["spec"]["containers"])
         # init containers
         with suppress(KeyError):
             template = resource["spec"]["template"]
-            for c in template["spec"]["initContainers"]:
-                images.add(c["image"])
+            images.update(c["image"] for c in template["spec"]["initContainers"])
         # CronJob
         with suppress(KeyError):
             template = resource["spec"]["jobTemplate"]["spec"]["template"]
-            for c in template["spec"]["containers"]:
-                images.add(c["image"])
+            images.update(c["image"] for c in template["spec"]["containers"])
         # CatalogSource templates
         with suppress(KeyError):
             images.add(resource["spec"]["image"])
         # ClowdApp deployments
         with suppress(KeyError):
             deployments = resource["spec"]["deployments"]
-            for d in deployments:
-                images.add(d["podSpec"]["image"])
+            images.update(d["podSpec"]["image"] for d in deployments)
         # ClowdApp jobs
         with suppress(KeyError, TypeError):
             jobs = resource["spec"]["jobs"]
-            for j in jobs:
-                images.add(j["podSpec"]["image"])
+            images.update(j["podSpec"]["image"] for j in jobs)
 
         return images
 
@@ -1872,7 +1866,7 @@ class SaasHerder:  # pylint: disable=too-many-public-methods
             # not have promotion_data yet
             if not config_hashes or not promotion.promotion_data:
                 logging.info(
-                    "Promotion data is missing; rely on the success " "state only"
+                    "Promotion data is missing; rely on the success state only"
                 )
                 continue
 

reconcile/utils/secret_reader.py

@@ -163,7 +163,7 @@ class VaultSecretReader(SecretReaderBase):
             )
         except Forbidden:
             raise VaultForbidden(
-                f"permission denied reading vault secret " f"at {path}"
+                f"permission denied reading vault secret at {path}"
             ) from None
         except vault.SecretNotFound as e:
             raise SecretNotFound(*e.args) from e
@@ -315,7 +315,7 @@ class SecretReader(SecretReaderBase):
                 data = self.vault_client.read_all(params)  # type: ignore[attr-defined] # mypy doesn't recognize the VaultClient.__new__ method
             except Forbidden:
                 raise VaultForbidden(
-                    f"permission denied reading vault secret " f"at {path}"
+                    f"permission denied reading vault secret at {path}"
                 ) from None
             except vault.SecretNotFound as e:
                 raise SecretNotFound(*e.args) from e

reconcile/utils/sharding.py

@@ -4,8 +4,8 @@ import os
 
 LOG = logging.getLogger(__name__)
 
-SHARDS = int(os.environ.get("SHARDS", 1))
-SHARD_ID = int(os.environ.get("SHARD_ID", 0))
+SHARDS = int(os.environ.get("SHARDS", "1"))
+SHARD_ID = int(os.environ.get("SHARD_ID", "0"))
 
 
 def is_in_shard(value):

reconcile/utils/state.py

@@ -346,7 +346,7 @@ class State:
         :type key: string
         """
         if not force and self.exists(key):
-            raise KeyError(f"[state] key {key} already " f"exists in {self.state_path}")
+            raise KeyError(f"[state] key {key} already exists in {self.state_path}")
         self._set(key, value, metadata=metadata)
 
     def _set(
@@ -430,16 +430,16 @@ class State:
         This method is not thread-safe nor multi-process-safe! There is no locking mechanism in place.
         """
         try:
-            _current_value = self[key]
+            current_value = self[key]
         except KeyError:
-            _current_value = None
-        state_obj = TransactionStateObj(key, value=_current_value)
+            current_value = None
+        state_obj = TransactionStateObj(key, value=current_value)
         try:
             yield state_obj
         except AbortStateTransaction:
             return
         else:
-            if state_obj.changed and state_obj.value != _current_value:
+            if state_obj.changed and state_obj.value != current_value:
                 self[state_obj.key] = state_obj.value
             elif value is not None and state_obj.value != value:
                 self[state_obj.key] = value

reconcile/utils/terraform_client.py

@@ -477,7 +477,7 @@ class TerraformClient:  # pylint: disable=too-many-public-methods
             tf_resource = spec.resource
             replica_src = tf_resource.get("replica_source")
             if replica_src:
-                replica_source_name = f'{replica_src}-{tf_resource.get("provider")}'
+                replica_source_name = f"{replica_src}-{tf_resource.get('provider')}"
                 # Creating a dict that is convenient to use inside the
                 # loop processing the formatted_output
                 replicas_info[spec.provisioner_name][spec.output_prefix] = (
@@ -659,7 +659,7 @@ class TerraformClient:  # pylint: disable=too-many-public-methods
     def cleanup(self):
         if self._aws_api is not None:
             self._aws_api.cleanup()
-        for _, wd in self.working_dirs.items():
+        for wd in self.working_dirs.values():
             shutil.rmtree(wd)
 
     def _can_skip_rds_modifications(

reconcile/utils/terrascript/cloudflare_resources.py

@@ -376,18 +376,16 @@ class CloudflareLogpushOwnershipChallengeResource(TerrascriptResource):
         destination_conf = values.get("destination_conf")
         zone = values.get("zone_name")
         if zone:
-            resources.append(
+            resources += [
                 self.cloudflare_zone(
                     safe_resource_id(zone), name=zone, account_id="${var.account_id}"
-                )
-            )
-            resources.append(
+                ),
                 cloudflare_logpush_ownership_challenge(
                     self._spec.identifier,
                     zone_id=f"${{data.cloudflare_zone.{safe_resource_id(zone)}.id}}",
                     destination_conf=destination_conf,
-                )
-            )
+                ),
+            ]
         else:
             resources.append(
                 cloudflare_logpush_ownership_challenge(

reconcile/utils/terrascript_aws_client.py

@@ -2670,8 +2670,7 @@ class TerrascriptClient:  # pylint: disable=too-many-public-methods
                         tf_resources.append(Output(output_name, value=switch_role_arn))
             else:
                 raise KeyError(
-                    f"[{account}/{identifier}] "
-                    "expected one of ocm_map or assume_role"
+                    f"[{account}/{identifier}] expected one of ocm_map or assume_role"
                 )
 
         self.add_resources(account, tf_resources)
@@ -4565,14 +4564,14 @@ class TerrascriptClient:  # pylint: disable=too-many-public-methods
 
             # add arn to output
             output_name = (
-                f"{output_prefix}__cloudwatch_log_group_" f"{log_type.lower()}_arn"
+                f"{output_prefix}__cloudwatch_log_group_{log_type.lower()}_arn"
             )
             output_value = arn
             tf_resources.append(Output(output_name, value=output_value))
 
             # add name to output
             output_name = (
-                f"{output_prefix}__cloudwatch_log_group_" f"{log_type.lower()}_name"
+                f"{output_prefix}__cloudwatch_log_group_{log_type.lower()}_name"
             )
             output_value = log_type_identifier
             tf_resources.append(Output(output_name, value=output_value))
@@ -5078,7 +5077,7 @@ class TerrascriptClient:  # pylint: disable=too-many-public-methods
         secret = common_values.get("secret", None)
         if secret is None:
             raise KeyError(
-                "no secret defined for s3_cloudfront_public_key " f"{identifier}"
+                f"no secret defined for s3_cloudfront_public_key {identifier}"
             )
 
         secret_data = self.secret_reader.read_all(secret)
@@ -5429,8 +5428,7 @@ class TerrascriptClient:  # pylint: disable=too-many-public-methods
                     weight_sum += a["weight"]
                 if weight_sum != 100:
                     raise ValueError(
-                        "sum of weights for a rule should be 100"
-                        f" given: {weight_sum}"
+                        f"sum of weights for a rule should be 100 given: {weight_sum}"
                     )
             elif action_type == "fixed-response":
                 fr_data = action.get("fixed_response", {})
@@ -5604,8 +5602,8 @@ class TerrascriptClient:  # pylint: disable=too-many-public-methods
         if extra_tags:
             tags.update(json.loads(extra_tags))
         # common_values is untyped, so casting is necessary
-        region = cast(str, common_values.get("region")) or cast(
-            str, self.default_regions.get(account)
+        region = cast(
+            str, common_values.get("region") or self.default_regions.get(account)
         )
 
         template_values = {
@@ -6313,7 +6311,7 @@ class TerrascriptClient:  # pylint: disable=too-many-public-methods
             http_method="${aws_api_gateway_method.gw_method_proxy_any.http_method}",
             integration_http_method="${aws_api_gateway_method.gw_method_proxy_any.http_method}",
             connection_id=f"${{{api_gateway_vpc_link_resource.id}}}",
-            uri=f'{common_values.get("api_proxy_uri")}/api/{{proxy}}',
+            uri=f"{common_values.get('api_proxy_uri')}/api/{{proxy}}",
             **integration_proxy_args,
         )
         tf_resources.append(api_gateway_integration_proxy_resource)
@@ -6829,42 +6827,32 @@ class TerrascriptClient:  # pylint: disable=too-many-public-methods
             tf_resources.append(scram_secret_association)
 
         # outputs
-        tf_resources.append(
+        tf_resources += [
             Output(
                 output_prefix + "__zookeeper_connect_string",
                 value="${" + msk_cluster.zookeeper_connect_string + "}",
-            )
-        )
-        tf_resources.append(
+            ),
             Output(
                 output_prefix + "__zookeeper_connect_string_tls",
                 value="${" + msk_cluster.zookeeper_connect_string_tls + "}",
-            )
-        )
-        tf_resources.append(
+            ),
             Output(
                 output_prefix + "__bootstrap_brokers",
                 value="${" + msk_cluster.bootstrap_brokers + "}",
-            )
-        )
-        tf_resources.append(
+            ),
             Output(
                 output_prefix + "__bootstrap_brokers_tls",
                 value="${" + msk_cluster.bootstrap_brokers_tls + "}",
-            )
-        )
-        tf_resources.append(
+            ),
             Output(
                 output_prefix + "__bootstrap_brokers_sasl_iam",
                 value="${" + msk_cluster.bootstrap_brokers_sasl_iam + "}",
-            )
-        )
-        tf_resources.append(
+            ),
             Output(
                 output_prefix + "__bootstrap_brokers_sasl_scram",
                 value="${" + msk_cluster.bootstrap_brokers_sasl_scram + "}",
-            )
-        )
+            ),
+        ]
         self.add_resources(account, tf_resources)
 
     def populate_saml_idp(self, account_name: str, name: str, metadata: str) -> None:

reconcile/utils/vault.py

@@ -222,7 +222,7 @@ class _VaultClient:
         mount_point = path_split[0]
         read_path = "/".join(path_split[1:])
         if version is None:
-            msg = "version can not be null " f"for secret with path '{path}'."
+            msg = f"version can not be null for secret with path '{path}'."
             raise SecretVersionIsNone(msg)
         if version == SECRET_VERSION_LATEST:
             # https://github.com/hvac/hvac/blob/
@@ -236,7 +236,7 @@ class _VaultClient:
                 version=version,
             )
         except InvalidPath:
-            msg = f"version '{version}' not found " f"for secret with path '{path}'."
+            msg = f"version '{version}' not found for secret with path '{path}'."
             raise SecretVersionNotFound(msg) from None
         except hvac.exceptions.Forbidden:
             msg = f"permission denied accessing secret '{path}'"

reconcile/utils/vcs.py

@@ -70,25 +70,17 @@ class VCS:
         self._allow_opening_mrs = allow_opening_mrs
         self._secret_reader = secret_reader
         self._gh_per_repo_url: dict[str, GithubRepositoryApi] = (
-            github_api_per_repo_url if github_api_per_repo_url else {}
+            github_api_per_repo_url or {}
         )
-        self._default_gh_token = (
-            default_gh_token
-            if default_gh_token
-            else self._get_default_gh_token(github_orgs=github_orgs)
+        self._default_gh_token = default_gh_token or self._get_default_gh_token(
+            github_orgs=github_orgs
         )
-        self._gitlab_instance = (
-            gitlab_instance
-            if gitlab_instance
-            else self._gitlab_api(gitlab_instances=gitlab_instances)
+        self._gitlab_instance = gitlab_instance or self._gitlab_api(
+            gitlab_instances=gitlab_instances
         )
-        self._app_interface_api = (
-            app_interface_api
-            if app_interface_api
-            else self._init_app_interface_api(
-                gitlab_instances=gitlab_instances,
-                app_interface_repo_url=app_interface_repo_url,
-            )
+        self._app_interface_api = app_interface_api or self._init_app_interface_api(
+            gitlab_instances=gitlab_instances,
+            app_interface_repo_url=app_interface_repo_url,
         )
         self._is_commit_sha_regex = re.compile(r"^[0-9a-f]{40}$")
 

reconcile/vault_replication.py

@@ -197,14 +197,7 @@ def list_invalid_paths(
 ) -> list[str]:
     """Returns a list of paths that are listed to be copied are not present in the policy
     to fail the integration if we are trying to copy secrets that are not allowed."""
-
-    invalid_paths = []
-
-    for path in path_list:
-        if not _policy_contains_path(path, policy_paths):
-            invalid_paths.append(path)
-
-    return invalid_paths
+    return [path for path in path_list if not _policy_contains_path(path, policy_paths)]
 
 
 def _policy_contains_path(path: str, policy_paths: Iterable[str]) -> bool:

tools/app_interface_reporter.py

@@ -253,7 +253,7 @@ def get_apps_data(date, month_delta=1, thread_pool_size=10):
 
         app_name = app["name"]
 
-        logging.info(f"collecting post-deploy jobs " f"information for {app_name}")
+        logging.info(f"collecting post-deploy jobs information for {app_name}")
         # this is now empty as it referred to post_deploy jobs via Jenkins. This section
         # should be removed when we publish a new content format or if we get promotion data
         # differently.

tools/cli_commands/container_images_report.py

@@ -141,7 +141,7 @@ def _get_namespace_images(ns: NamespaceV1, oc_map: OCMap) -> NamespaceImages:
 
             for c in containers:
                 if m := IMAGE_NAME_REGEX.match(c["image"]):
-                    image_names.append(m.group("name"))
+                    image_names.append(m.group("name"))  # noqa: PERF401
     except Exception as exc:
         return NamespaceImages(
             namespace_name=ns.name,

tools/cli_commands/cost_report/view.py

@@ -382,8 +382,10 @@ def render_app_cost(
     if report.items:
         cost_details_sections.append(item_cost_renderer(report=report, **kwargs))
     if report.child_apps:
-        cost_details_sections.append(render_child_apps_cost(report))
-        cost_details_sections.append(render_total_cost(report))
+        cost_details_sections += [
+            render_child_apps_cost(report),
+            render_total_cost(report),
+        ]
     cost_details = (
         "\n".join(cost_details_sections) if cost_details_sections else "No data"
     )

tools/cli_commands/gpg_encrypt.py

@@ -155,11 +155,7 @@ class GPGEncryptCommand:
         command_data: GPGEncryptCommandData,
         secret_reader: SecretReader | None = None,
     ) -> GPGEncryptCommand:
-        cls_secret_reader = (
-            secret_reader
-            if secret_reader
-            else SecretReader(settings=config.get_config())
-        )
+        cls_secret_reader = secret_reader or SecretReader(settings=config.get_config())
 
         return cls(
             command_data=command_data,

tools/qontract_cli.py

@@ -602,7 +602,7 @@ def ocm_fleet_upgrade_policies(
 @click.option(
     "--ignore-sts-clusters",
     is_flag=True,
-    default=os.environ.get("IGNORE_STS_CLUSTERS", False),
+    default=bool(os.environ.get("IGNORE_STS_CLUSTERS")),
     help="Ignore STS clusters",
 )
 @click.pass_context
@@ -1102,7 +1102,7 @@ def cidr_blocks(ctx, for_cluster: int, mask: int) -> None:
             "from": str(ipaddress.ip_network(cidr)[0]),
             "to": str(ipaddress.ip_network(cidr)[-1]),
             "hosts": str(ipaddress.ip_network(cidr).num_addresses),
-            "description": f'CIDR {cidr} routed through account {connection["account"]["name"]} transit gateways',
+            "description": f"CIDR {cidr} routed through account {connection['account']['name']} transit gateways",
         }
         for c in clusters
         for connection in (c["peering"] or {}).get("connections") or []
@@ -1216,7 +1216,7 @@ def ocm_aws_infrastructure_access_switch_role_links(ctx):
     for user in sorted(by_user.keys()):
         print(f"- [{user}](#{user})")
     for user in sorted(by_user.keys()):
-        print("")
+        print()
         print(f"# {user}")
         print_output(ctx.obj["options"], by_user[user], columns)
 
@@ -1356,7 +1356,7 @@ def ocm_login(ctx, org_name):
     client_secret = secret_reader.read(ocm["accessTokenClientSecret"])
     access_token_command = f'curl -s -X POST {ocm["accessTokenUrl"]} -d "grant_type=client_credentials" -d "client_id={ocm["accessTokenClientId"]}" -d "client_secret={client_secret}" | jq -r .access_token'
     print(
-        f'ocm login --url {ocm["environment"]["url"]} --token $({access_token_command})'
+        f"ocm login --url {ocm['environment']['url']} --token $({access_token_command})"
     )
 
 
@@ -1607,7 +1607,7 @@ def jenkins_job_vault_secrets(ctx, instance_name: str, job_name: str) -> None:
                 secret_values = s["secret-values"]
                 for sv in secret_values:
                     print(
-                        f"export {sv['env-var']}=\"$(vault read -address={vault_url} -field={sv['vault-key']} {secret_path})\""
+                        f'export {sv["env-var"]}="$(vault read -address={vault_url} -field={sv["vault-key"]} {secret_path})"'
                     )
 
 
@@ -1809,12 +1809,12 @@ def rds_recommendations(ctx):
             continue
         for spec in get_external_resource_specs(namespace_info):
             if spec.provider == "rds":
-                targetted_accounts.append(spec.provisioner_name)
+                targetted_accounts.append(spec.provisioner_name)  # noqa: PERF401
 
     accounts = [
         a for a in queries.get_aws_accounts() if a["name"] in targetted_accounts
     ]
-    accounts.sort(key=lambda a: a["name"])
+    accounts.sort(key=itemgetter("name"))
 
     columns = [
         # 'RecommendationId',
@@ -1865,7 +1865,7 @@ def rds_recommendations(ctx):
                 if not recommendations:
                     continue
                 # Sort by ResourceName
-                recommendations.sort(key=lambda r: r["ResourceName"])
+                recommendations.sort(key=itemgetter("ResourceName"))
 
                 print(f"# {account_name} - {region}")
                 print("Note: Severity informational is not shown.")
@@ -2136,7 +2136,7 @@ def sre_checkpoints(ctx):
         if (app["path"] not in parent_apps and app["onboardingStatus"] == "OnBoarded")
     ]
 
-    checkpoints_data.sort(key=lambda c: c["latest"], reverse=True)
+    checkpoints_data.sort(key=itemgetter("latest"), reverse=True)
 
     columns = ["name", "latest"]
     print_output(ctx.obj["options"], checkpoints_data, columns)
@@ -2370,14 +2370,15 @@ def change_types(ctx) -> None:
         for ss in r.self_service or []:
             nr_files = len(ss.datafiles or []) + len(ss.resources or [])
             usage_statistics[ss.change_type.name] += nr_files
-    data = []
-    for ct in change_types:
-        data.append({
+    data = [
+        {
             "name": ct.name,
             "description": ct.description,
             "applicable to": f"{ct.context_type.value} {ct.context_schema or ''}",
             "# usages": usage_statistics[ct.name],
-        })
+        }
+        for ct in change_types
+    ]
     columns = ["name", "description", "applicable to", "# usages"]
     print_output(ctx.obj["options"], data, columns)
 

tools/saas_metrics_exporter/commit_distance/channel.py

@@ -36,7 +36,7 @@ def build_channels(saas_files: Iterable[SaasFile]) -> list[Channel]:
                 auth_code = (
                     saas_file.authentication.code if saas_file.authentication else None
                 )
-                target_name = target.name if target.name else "NoName"
+                target_name = target.name or "NoName"
                 saas_target = SaasTarget(
                     app_name=saas_file.app.name,
                     repo_url=resource_template.url,

tools/saas_promotion_state/saas_promotion_state.py

@@ -40,7 +40,7 @@ class SaasPromotionState:
                         continue
                     for publish_channel in target.promotion.publish or []:
                         if publish_channel == channel:
-                            publisher_uids.append(
+                            publisher_uids.append(  # noqa: PERF401
                                 target.uid(
                                     parent_saas_file_name=saas_file.name,
                                     parent_resource_template_name=resource_template.name,

tools/sd_app_sre_alert_report.py

@@ -48,7 +48,7 @@ def group_alerts(messages: list[dict]) -> dict[str, list[Alert]]:
     for m in messages:
         if "subtype" not in m or m["subtype"] != "bot_message":
             logging.debug(
-                f'Skipping message \'{m["text"]}\' as it does not come from a bot'
+                f"Skipping message '{m['text']}' as it does not come from a bot"
             )
             continue
 
@@ -65,7 +65,7 @@ def group_alerts(messages: list[dict]) -> dict[str, list[Alert]]:
             alert_message = mg.group(3)
 
             if not alert_name:
-                logging.debug(f'no alert name in title {at["title"]}. Skipping')
+                logging.debug(f"no alert name in title {at['title']}. Skipping")
                 continue
 
             # If there's only one alert related to the alert_name, message will be part
@@ -104,7 +104,7 @@ def group_alerts(messages: list[dict]) -> dict[str, list[Alert]]:
                     elif "Alerts Resolved" in line:
                         alert_state = "RESOLVED"
                     elif line.startswith("-"):
-                        mg = re.match("^- (.+)$", line)
+                        mg = re.match(r"^- (.+)$", line)
                         if not mg:
                             continue
                         alert_message = mg.group(1)