qontract-reconcile 0.10.2.dev14__py3-none-any.whl → 0.10.2.dev15__py3-none-any.whl

reconcile/openshift_namespace_labels.py

@@ -192,7 +192,7 @@ class LabelInventory:
                     changed[k] = v
 
             # remove old labels
-            for k, _ in current.items():
+            for k in current:
                 if k in managed and k not in desired:
                     changed[k] = None
 
@@ -261,7 +261,7 @@ def get_desired(
         # A dedicated integration or PR check will be done to ensure this
         # case does not occur (anymore)
         _LOG.debug(
-            f"Found several namespace definitions for " f"{cluster}/{ns_name}. Ignoring"
+            f"Found several namespace definitions for {cluster}/{ns_name}. Ignoring"
         )
         inventory.delete(cluster=cluster, namespace=ns_name)
 
@@ -310,8 +310,7 @@ def lookup_namespaces(cluster: str, oc_map: OCMap) -> tuple[str, dict[str, Any]
         _LOG.error(msg)
     except ApiException as e:
         _LOG.error(
-            f"Cluster {cluster} skipped: "
-            f"APIException [{e.status}:{e.reason}] {e.body}"
+            f"Cluster {cluster} skipped: APIException [{e.status}:{e.reason}] {e.body}"
         )
 
     return cluster, None

reconcile/openshift_namespaces.py

@@ -131,7 +131,7 @@ def check_results(
         if isinstance(e, Exception):
             err = True
             msg = (
-                f'cluster: {s["cluster"]}, namespace: {s["namespace"]}, '
+                f"cluster: {s['cluster']}, namespace: {s['namespace']}, "
                 f"exception: {e!s}"
             )
             logging.error(msg)

reconcile/openshift_network_policies.py

@@ -120,7 +120,7 @@ def run(dry_run, thread_pool_size=10, internal=None, use_jump_host=True, defer=N
         if ob.is_namespace_deleted(namespace_info):
             continue
 
-        shard_key = f"{namespace_info['cluster']['name']}/" f"{namespace_info['name']}"
+        shard_key = f"{namespace_info['cluster']['name']}/{namespace_info['name']}"
 
         if not is_in_shard(shard_key):
             continue

reconcile/openshift_resources_base.py

@@ -864,10 +864,10 @@ def get_namespaces(
             )
         )
     ]
-    _namespaces = filter_namespaces_by_cluster_and_namespace(
+    namespaces_ = filter_namespaces_by_cluster_and_namespace(
         namespaces, cluster_names, exclude_clusters, namespace_name
     )
-    return canonicalize_namespaces(_namespaces, providers, resource_schema_filter)
+    return canonicalize_namespaces(namespaces_, providers, resource_schema_filter)
 
 
 @defer
@@ -1029,10 +1029,10 @@ class CheckClusterScopedResourceDuplicates:
         duplicates: list[tuple[str, str, str, list[str]]] = []
 
         for cluster, cluster_resources in cluster_cs_resources.items():
-            _kind_name: dict[str, dict[str, list[str]]] = {}
+            kind_name: dict[str, dict[str, list[str]]] = {}
             for ns, resources in cluster_resources.items():
                 for kind, names in resources.items():
-                    k_ref = _kind_name.setdefault(kind, {})
+                    k_ref = kind_name.setdefault(kind, {})
                     for name in names:
                         n_ref = k_ref.setdefault(name, [])
                         n_ref.append(ns)

reconcile/openshift_serviceaccount_tokens.py

@@ -75,7 +75,7 @@ def get_tokens_for_service_account(
             == service_account
             and token["type"] == "kubernetes.io/service-account-token"
         ):
-            result.append(token)
+            result.append(token)  # noqa: PERF401
     return result
 
 

reconcile/openshift_tekton_resources.py

@@ -108,8 +108,7 @@ def fetch_tkn_providers(saas_file_name: str | None) -> dict[str, Any]:
 
     if duplicates:
         raise OpenshiftTektonResourcesBadConfigError(
-            "There are duplicates in tekton providers names: "
-            f'{", ".join(duplicates)}'
+            f"There are duplicates in tekton providers names: {', '.join(duplicates)}"
         )
 
     # Only get the providers that are used by the saas files

reconcile/openshift_users.py

@@ -47,10 +47,11 @@ def get_cluster_users(
 
     # backwarts compatibiltiy for clusters w/o auth
     identity_prefixes = ["github"]
-
-    for auth in cluster_info.auth:
-        if isinstance(auth, ClusterAuthOIDCV1 | ClusterAuthRHIDPV1):
-            identity_prefixes.append(auth.name)
+    identity_prefixes.extend(
+        auth.name
+        for auth in cluster_info.auth
+        if isinstance(auth, ClusterAuthOIDCV1 | ClusterAuthRHIDPV1)
+    )
 
     for u in oc.get_users():
         if u["metadata"].get("labels", {}).get("admin", ""):

reconcile/prometheus_rules_tester/integration.py

@@ -124,22 +124,22 @@ def get_rules_and_tests(
     """Iterates through all namespaces and returns a list of tests to run"""
     namespace_with_prom_rules, _ = orb.get_namespaces(
         PROVIDERS,
-        cluster_names=cluster_names if cluster_names else [],
+        cluster_names=cluster_names or [],
         namespace_name=NAMESPACE_NAME,
     )
 
-    iterable = []
+    iterable: list[RuleToFetch] = []
     for namespace in namespace_with_prom_rules:
         prom_rules = [
             r for r in namespace["openshiftResources"] if r["provider"] in PROVIDERS
         ]
-        for resource in prom_rules:
-            iterable.append(
-                RuleToFetch(
-                    namespace=namespace,
-                    resource=resource,
-                )
+        iterable.extend(
+            RuleToFetch(
+                namespace=namespace,
+                resource=resource,
             )
+            for resource in prom_rules
+        )
 
     return threaded.run(
         func=fetch_rule_and_tests,

reconcile/quay_mirror.py

@@ -190,8 +190,7 @@ class QuayMirror:
                     )
                     if mirror_image.registry == "docker.io" and item["public"]:
                         _LOG.error(
-                            "Image %s can't be mirrored to a public "
-                            "quay repository.",
+                            "Image %s can't be mirrored to a public quay repository.",
                             mirror_image,
                         )
                         sys.exit(ExitCodes.ERROR)
@@ -250,7 +249,7 @@ class QuayMirror:
             for item in data:
                 push_creds = self.push_creds[org_key].split(":")
                 image = Image(
-                    f'{item["server_url"]}/{org}/{item["name"]}',
+                    f"{item['server_url']}/{org}/{item['name']}",
                     username=push_creds[0],
                     password=push_creds[1],
                     response_cache=self.response_cache,
@@ -409,7 +408,7 @@ class QuayMirror:
             org = org_data["name"]
             instance = org_data["instance"]["name"]
             org_key = OrgKey(instance, org)
-            creds[org_key] = f'{raw_data["user"]}:{raw_data["token"]}'
+            creds[org_key] = f"{raw_data['user']}:{raw_data['token']}"
 
         return creds
 

reconcile/quay_mirror_org.py

@@ -150,7 +150,7 @@ class QuayMirrorOrg:
 
             for item in data:
                 image = Image(
-                    f'{server_url}/{org_name}/{item["name"]}',
+                    f"{server_url}/{org_name}/{item['name']}",
                     username=username,
                     password=password,
                     session=self.session,

reconcile/rhidp/ocm_oidc_idp/base.py

@@ -1,4 +1,5 @@
 import logging
+import operator
 from collections.abc import (
     Iterable,
     Sequence,
@@ -38,10 +39,10 @@ class IDPState(BaseModel):
     cluster: Cluster
     idp: OCMOIdentityProvider | OCMOIdentityProviderOidc | OCMOIdentityProviderGithub
 
-    def __eq__(self, __value: object) -> bool:
-        if not isinstance(__value, IDPState):
+    def __eq__(self, value: object) -> bool:
+        if not isinstance(value, IDPState):
             raise NotImplementedError("Cannot compare to non IDPState objects.")
-        return self.idp == __value.idp
+        return self.idp == value.idp
 
 
 def run(
@@ -91,19 +92,13 @@ def fetch_current_state(
     ocm_api: OCMBaseClient, clusters: Iterable[Cluster]
 ) -> list[IDPState]:
     """Fetch all current configured OIDC identity providers."""
-    current_state: list[IDPState] = []
-    for cluster in clusters:
+    return [
+        IDPState(cluster=cluster, idp=idp)
+        for cluster in clusters
         for idp in get_identity_providers(
             ocm_api=ocm_api, ocm_cluster=cluster.ocm_cluster
-        ):
-            current_state.append(
-                IDPState(
-                    cluster=cluster,
-                    idp=idp,
-                ),
-            )
-
-    return current_state
+        )
+    ]
 
 
 def fetch_desired_state(
@@ -175,7 +170,7 @@ def act(
             idp_state.idp.type,
             idp_state.idp.name,
         )),
-        equal=lambda idp1, idp2: idp1 == idp2,
+        equal=operator.eq,
     )
 
     for idp_state in diff_result.delete.values():

reconcile/run_integration.py

@@ -28,8 +28,8 @@ from reconcile.utils.runtime.environment import (
     log_fmt,
 )
 
-SHARDS = int(os.environ.get("SHARDS", 1))
-SHARD_ID = int(os.environ.get("SHARD_ID", 0))
+SHARDS = int(os.environ.get("SHARDS", "1"))
+SHARD_ID = int(os.environ.get("SHARD_ID", "0"))
 SHARD_ID_LABEL = os.environ.get("SHARD_KEY", f"{SHARD_ID}-{SHARDS}")
 PREFIX_LOG_LEVEL = os.environ.get("PREFIX_LOG_LEVEL", "false")
 
@@ -44,14 +44,14 @@ DRY_RUN = (
 )
 INTEGRATION_EXTRA_ARGS = os.environ.get("INTEGRATION_EXTRA_ARGS")
 CONFIG = os.environ.get("CONFIG", "/config/config.toml")
-PROMETHEUS_PORT = os.environ.get("PROMETHEUS_PORT", 9090)
+PROMETHEUS_PORT = int(os.environ.get("PROMETHEUS_PORT", "9090"))
 
 LOG_FILE = os.environ.get("LOG_FILE")
 LOG_LEVEL = os.environ.get("LOG_LEVEL", "INFO")
-SLEEP_DURATION_SECS = os.environ.get("SLEEP_DURATION_SECS", 600)
-SLEEP_ON_ERROR = os.environ.get("SLEEP_ON_ERROR", 10)
+SLEEP_DURATION_SECS = int(os.environ.get("SLEEP_DURATION_SECS", "600"))
+SLEEP_ON_ERROR = int(os.environ.get("SLEEP_ON_ERROR", "10"))
 
-PUSHGATEWAY_ENABLED = os.environ.get("PUSHGATEWAY_ENABLED", False)
+PUSHGATEWAY_ENABLED = bool(os.environ.get("PUSHGATEWAY_ENABLED"))
 
 LOG = logging.getLogger(__name__)
 
@@ -88,7 +88,7 @@ def _parse_dry_run_flag(dry_run: str | None) -> str | None:
         )
         logging.error(msg)
         raise ValueError(msg)
-    return dry_run if dry_run else None
+    return dry_run or None
 
 
 def build_entry_point_args(

reconcile/saas_auto_promotions_manager/publisher.py

@@ -54,7 +54,7 @@ class Publisher:
         self.app_name = app_name
         self.namespace_name = namespace_name
         self.resource_template_name = resource_template_name
-        self.target_name = target_name if target_name else "None"
+        self.target_name = target_name or "None"
         self.cluster_name = cluster_name
         self.redeploy_on_config_change = bool(redeploy_on_config_change)
         self.has_subscriber = has_subscriber

reconcile/saas_auto_promotions_manager/utils/saas_files_inventory.py

@@ -92,21 +92,15 @@ class SaasFilesInventory:
                     blocked_versions.setdefault(code_component.url, set()).add(version)
             for resource_template in saas_file.resource_templates:
                 for target in resource_template.targets:
-                    file_path = target.path if target.path else saas_file.path
+                    file_path = target.path or saas_file.path
                     if target.disable or target.delete:
                         continue
                     if not target.promotion:
                         continue
                     if not target.promotion.auto:
                         continue
-                    soak_days = (
-                        target.promotion.soak_days if target.promotion.soak_days else 0
-                    )
-                    schedule = (
-                        target.promotion.schedule
-                        if target.promotion.schedule
-                        else "* * * * *"
-                    )
+                    soak_days = target.promotion.soak_days or 0
+                    schedule = target.promotion.schedule or "* * * * *"
                     subscriber = Subscriber(
                         uid=target.uid(
                             parent_saas_file_name=saas_file.name,

reconcile/service_dependencies.py

@@ -21,13 +21,8 @@ QONTRACT_INTEGRATION = "service-dependencies"
 
 
 def get_dependency_names(dependency_map: Mapping[Any, Any], dep_type: str) -> list[str]:
-    dep_names = []
-    for dm in dependency_map:
-        if dm["type"] != dep_type:
-            continue
-        for service in dm["services"]:
-            dep_names.append(service["name"])
-    return dep_names
+    dependency_maps = (dm for dm in dependency_map if dm["type"] == dep_type)
+    return [service["name"] for service in dependency_maps]
 
 
 def get_desired_dependency_names(

reconcile/skupper_network/reconciler.py

@@ -31,7 +31,7 @@ def delete_skupper_site(
     for kind in integration_managed_kinds:
         # delete everything labeled by us
         to_delete.update({
-            f'{item["kind"]}-{item["metadata"]["name"]}': item
+            f"{item['kind']}-{item['metadata']['name']}": item
             for item in oc.get_items(
                 kind=kind,
                 namespace=site.namespace.name,
@@ -40,7 +40,7 @@ def delete_skupper_site(
         })
         # delete everything else that starts with 'skupper-'
         to_delete.update({
-            f'{item["kind"]}-{item["metadata"]["name"]}': item
+            f"{item['kind']}-{item['metadata']['name']}": item
             for item in oc.get_items(kind=kind, namespace=site.namespace.name)
             if item["metadata"]["name"].startswith("skupper-")
         })
@@ -84,12 +84,12 @@ def _create_token(
     logging.info(f"{connected_site}: Creating new connection token for {site}")
     sc = get_site_controller(connected_site)
     if not dry_run:
-        _labels = copy.deepcopy(site.token_labels)
-        _labels.update(labels)
+        labels_ = copy.deepcopy(site.token_labels)
+        labels_.update(labels)
         oc.apply(
             connected_site.namespace.name,
             resource=OR(
-                body=sc.site_token(connected_site.unique_token_name(site), _labels),
+                body=sc.site_token(connected_site.unique_token_name(site), labels_),
                 integration=integration,
                 integration_version=integration_version,
             ),

reconcile/skupper_network/site_controller.py

@@ -28,14 +28,14 @@ class SiteController:
 
     def site_token(self, name: str, labels: MutableMapping[str, str]) -> dict[str, Any]:
         """Skupper site token secret."""
-        _labels = copy.deepcopy(labels)
-        _labels["skupper.io/type"] = "connection-token-request"
+        labels_ = copy.deepcopy(labels)
+        labels_["skupper.io/type"] = "connection-token-request"
         return {
             "apiVersion": "v1",
             "kind": "Secret",
             "metadata": {
                 "name": name,
-                "labels": _labels,
+                "labels": labels_,
             },
         }
 

reconcile/sql_query.py

@@ -277,17 +277,17 @@ def collect_queries(
         tf_resource_info = get_tf_resource_info(terrascript, namespace, identifier)
         if tf_resource_info is None:
             logging.error(
-                f'[sql-query:{name} (path: {sql_query["path"]})] Could not find rds identifier {identifier} in namespace {namespace["name"]}. '
+                f"[sql-query:{name} (path: {sql_query['path']})] Could not find rds identifier {identifier} in namespace {namespace['name']}. "
                 "If this is a removed read only instance, consider updating the identifier to the source replica or remove this file."
             )
             sys.exit(ExitCodes.ERROR)
 
-        _queries = []
+        queries_ = []
         if sql_query["query"] is not None:
-            _queries.append(sql_query["query"])
+            queries_.append(sql_query["query"])
 
         if sql_query["queries"] is not None:
-            _queries.extend(sql_query["queries"])
+            queries_.extend(sql_query["queries"])
 
         # building up the final query dictionary
         item = {
@@ -296,7 +296,7 @@ def collect_queries(
             "identifier": sql_query["identifier"],
             "db_conn": db_conn,
             "output": output,
-            "queries": _queries,
+            "queries": queries_,
             **tf_resource_info,
         }
 

reconcile/status_board.py

@@ -194,40 +194,40 @@ class StatusBoardExporterIntegration(QontractReconcileIntegration):
                 )
             )
             # new product, so it misses also the applications
-            for app_name in desired_product_apps[product_name]:
-                return_list.append(
-                    StatusBoardHandler(
-                        action="create",
-                        status_board_object=create_app(app_name, product),
-                    )
+            return_list.extend(
+                StatusBoardHandler(
+                    action="create",
+                    status_board_object=create_app(app_name, product),
                 )
+                for app_name in desired_product_apps[product_name]
+            )
 
         # existing product, only add/remove applications
         for product_name, apps in diff_result.change.items():
             product = current_products[product_name]
-            for app_name in apps.desired - apps.current:
-                return_list.append(
-                    StatusBoardHandler(
-                        action="create",
-                        status_board_object=create_app(app_name, product),
-                    )
+            return_list.extend(
+                StatusBoardHandler(
+                    action="create",
+                    status_board_object=create_app(app_name, product),
                 )
+                for app_name in apps.desired - apps.current
+            )
             to_delete = apps.current - apps.desired
-            for application in product.applications or []:
-                if application.name in to_delete:
-                    return_list.append(
-                        StatusBoardHandler(
-                            action="delete",
-                            status_board_object=application,
-                        )
-                    )
+            return_list.extend(
+                StatusBoardHandler(
+                    action="delete",
+                    status_board_object=application,
+                )
+                for application in product.applications or []
+                if application.name in to_delete
+            )
 
         # product is deleted entirely
         for product_name in diff_result.delete:
-            for application in current_products[product_name].applications or []:
-                return_list.append(
-                    StatusBoardHandler(action="delete", status_board_object=application)
-                )
+            return_list.extend(
+                StatusBoardHandler(action="delete", status_board_object=application)
+                for application in current_products[product_name].applications or []
+            )
             return_list.append(
                 StatusBoardHandler(
                     action="delete", status_board_object=current_products[product_name]

reconcile/terraform_cloudflare_users.py

@@ -331,8 +331,8 @@ def build_external_resource_spec_from_cloudflare_users(
     """
     specs: list[ExternalResourceSpec] = []
 
-    for _, v in cloudflare_users.items():
-        for _, cf_user in v.items():
+    for v in cloudflare_users.values():
+        for cf_user in v.values():
             data_source_cloudflare_account_roles = {
                 "identifier": safe_resource_id(cf_user.account_name),
                 "account_id": "${var.account_id}",

reconcile/terraform_repo.py

@@ -382,12 +382,12 @@ class TerraformRepoIntegration(
 
                 # construct diff urls
                 diff_urls: list[str] = []
-                for pair in diff_result.change.values():
-                    if pair.current.ref != pair.desired.ref:
-                        # gitlab specific syntax
-                        diff_urls.append(
-                            f"{pair.current.repository}/compare/{pair.current.ref}...{pair.desired.ref}"
-                        )
+                # gitlab specific syntax
+                diff_urls.extend(
+                    f"{pair.current.repository}/compare/{pair.current.ref}...{pair.desired.ref}"
+                    for pair in diff_result.change.values()
+                    if pair.current.ref != pair.desired.ref
+                )
 
                 if len(diff_urls) > 0:
                     comment_body = "tf-repo diffs:\n" + "\n".join([

reconcile/terraform_users.py

@@ -95,12 +95,15 @@ def _filter_participating_aws_accounts(
     accounts: list,
     roles: list[dict[str, Any]],
 ) -> list:
-    participating_aws_account_names = set()
+    participating_aws_account_names: set[str] = set()
     for role in roles:
-        for aws_group in role["aws_groups"] or []:
-            participating_aws_account_names.add(aws_group["account"]["name"])
-        for user_policy in role["user_policies"] or []:
-            participating_aws_account_names.add(user_policy["account"]["name"])
+        participating_aws_account_names.update(
+            aws_group["account"]["name"] for aws_group in role["aws_groups"] or []
+        )
+        participating_aws_account_names.update(
+            user_policy["account"]["name"]
+            for user_policy in role["user_policies"] or []
+        )
     return [a for a in accounts if a["name"] in participating_aws_account_names]
 
 

reconcile/terraform_vpc_peerings.py

@@ -702,7 +702,7 @@ def run(
             integration_version=QONTRACT_INTEGRATION_VERSION,
             dry_run=dry_run,
             cache_source=cache_source,
-            shard=account_name if account_name else "",
+            shard=account_name or "",
             ttl_seconds=extended_early_exit_cache_ttl_seconds,
             logger=logging.getLogger(),
             runner=runner,

reconcile/terraform_vpc_resources/integration.py

@@ -196,7 +196,7 @@ class TerraformVpcResources(QontractReconcileIntegration[TerraformVpcResourcesPa
         mr_manager._fetch_managed_open_merge_requests()
 
         # Create a MR for each vpc request if the MR don't exist yet
-        for _, outputs in handled_output.items():
+        for outputs in handled_output.values():
             template = gql_api.get_template(
                 path="/templating/templates/terraform-vpc-resources/vpc.yml"
             )["template"]

reconcile/typed_queries/app_interface_deadmanssnitch_settings.py

@@ -10,7 +10,7 @@ from reconcile.utils.gql import GqlApi
 def get_deadmanssnitch_settings(
     gql_api: GqlApi | None = None,
 ) -> DeadMansSnitchSettingsV1:
-    api = gql_api if gql_api else gql.get_api()
+    api = gql_api or gql.get_api()
     data = query(query_func=api.query)
     if data.settings and data.settings[0].dead_mans_snitch_settings is not None:
         return data.settings[0].dead_mans_snitch_settings

reconcile/typed_queries/app_quay_repos_escalation_policies.py

@@ -9,6 +9,6 @@ from reconcile.utils.gql import GqlApi
 def get_apps_quay_repos_escalation_policies(
     gql_api: GqlApi | None = None,
 ) -> list[AppV1]:
-    api = gql_api if gql_api else gql.get_api()
+    api = gql_api or gql.get_api()
     data = query(query_func=api.query)
     return list(data.apps or [])

reconcile/typed_queries/aws_vpc_requests.py

@@ -4,6 +4,6 @@ from reconcile.utils.gql import GqlApi
 
 
 def get_aws_vpc_requests(gql_api: GqlApi | None = None) -> list[VPCRequest]:
-    api = gql_api if gql_api else gql.get_api()
+    api = gql_api or gql.get_api()
     data = query(query_func=api.query)
     return list(data.vpc_requests or [])

reconcile/typed_queries/aws_vpcs.py

@@ -7,6 +7,6 @@ from reconcile.utils.gql import GqlApi
 
 
 def get_aws_vpcs(gql_api: GqlApi | None = None) -> list[AWSVPC]:
-    api = gql_api if gql_api else gql.get_api()
+    api = gql_api or gql.get_api()
     data = query(query_func=api.query)
     return list(data.vpcs or [])

reconcile/typed_queries/clusters.py

@@ -13,6 +13,6 @@ def get_clusters(
     variables = {}
     if name:
         variables["name"] = name
-    api = gql_api if gql_api else gql.get_api()
+    api = gql_api or gql.get_api()
     data = query(query_func=api.query, variables=variables)
     return list(data.clusters or [])

reconcile/typed_queries/clusters_minimal.py

@@ -12,6 +12,6 @@ def get_clusters_minimal(
     variables = {}
     if name:
         variables["name"] = name
-    api = gql_api if gql_api else gql.get_api()
+    api = gql_api or gql.get_api()
     data = query(query_func=api.query, variables=variables)
     return list(data.clusters or [])

reconcile/typed_queries/clusters_with_dms.py

@@ -11,6 +11,6 @@ def get_clusters_with_dms(
 ) -> list[ClusterV1]:
     # get the clusters containing the filed enableDeadMansSnitch
     variable = {"filter": {"enableDeadMansSnitch": {"ne": None}}}
-    api = gql_api if gql_api else gql.get_api()
+    api = gql_api or gql.get_api()
     data = query(query_func=api.query, variables=variable)
     return data.clusters or []

reconcile/typed_queries/dynatrace_environments.py

@@ -9,6 +9,6 @@ from reconcile.utils.gql import GqlApi
 def get_dynatrace_environments(
     api: GqlApi | None = None,
 ) -> list[DynatraceEnvironmentV1]:
-    api = api if api else gql.get_api()
+    api = api or gql.get_api()
     data = query(api.query)
     return list(data.environments or [])

reconcile/typed_queries/dynatrace_token_provider_token_specs.py

@@ -9,6 +9,6 @@ from reconcile.utils.gql import GqlApi
 def get_dynatrace_token_provider_token_specs(
     api: GqlApi | None = None,
 ) -> list[DynatraceTokenProviderTokenSpecV1]:
-    api = api if api else gql.get_api()
+    api = api or gql.get_api()
     data = query(api.query)
     return list(data.token_specs or [])