python-openstackclient 9.0.0__py3-none-any.whl → 10.1.0__py3-none-any.whl

openstackclient/volume/v3/volume_message.py

@@ -14,7 +14,10 @@
 
 """Volume V3 Messages implementations"""
 
+import argparse
+from collections.abc import Iterable, Sequence
 import logging as LOG
+from typing import Any
 
 from cinderclient import api_versions
 from osc_lib import exceptions
@@ -29,7 +32,7 @@ from openstackclient.identity import common as identity_common
 class DeleteMessage(command.Command):
     _description = _('Delete a volume failure message')
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'message_ids',
@@ -40,7 +43,7 @@ class DeleteMessage(command.Command):
 
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         volume_client = self.app.client_manager.volume
 
         if volume_client.api_version < api_versions.APIVersion('3.3'):
@@ -70,7 +73,7 @@ class DeleteMessage(command.Command):
 class ListMessages(command.Lister):
     _description = _('List volume failure messages')
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
 
         parser.add_argument(
@@ -79,11 +82,15 @@ class ListMessages(command.Lister):
             help=_('Filter results by project (name or ID) (admin only)'),
         )
         identity_common.add_project_domain_option_to_parser(parser)
-        pagination.add_marker_pagination_option_to_parser(parser)
+        pagination.add_marker_pagination_option_to_parser(
+            parser, include_max_items=False
+        )
 
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[tuple[str, ...], Iterable[tuple[Any, ...]]]:
         volume_client = self.app.client_manager.volume
         identity_client = self.app.client_manager.identity
 
@@ -132,7 +139,7 @@ class ListMessages(command.Lister):
 class ShowMessage(command.ShowOne):
     _description = _('Show a volume failure message')
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'message_id',
@@ -142,7 +149,9 @@ class ShowMessage(command.ShowOne):
 
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         volume_client = self.app.client_manager.volume
 
         if volume_client.api_version < api_versions.APIVersion('3.3'):
@@ -154,4 +163,5 @@ class ShowMessage(command.ShowOne):
 
         message = volume_client.messages.get(parsed_args.message_id)
 
-        return zip(*sorted(message._info.items()))
+        col_headers, col_data = zip(*sorted(message._info.items()))
+        return col_headers, col_data

openstackclient/volume/v3/volume_snapshot.py

@@ -14,12 +14,15 @@
 
 """Volume v3 snapshot action implementations"""
 
+import argparse
+from collections.abc import Iterable, Sequence
 import functools
 import logging
-import typing as ty
+from typing import Any
 
 from cliff import columns as cliff_columns
 from openstack.block_storage.v3 import snapshot as _snapshot
+from openstack import utils as sdk_utils
 from osc_lib.cli import format_columns
 from osc_lib.cli import parseractions
 from osc_lib import exceptions
@@ -44,11 +47,13 @@ class VolumeIdColumn(cliff_columns.FormattableColumn[str]):
     ``functools.partial(VolumeIdColumn, volume_cache)``.
     """
 
-    def __init__(self, value, volume_cache=None):
+    def __init__(
+        self, value: str, volume_cache: dict[str, Any] | None = None
+    ) -> None:
         super().__init__(value)
         self._volume_cache = volume_cache or {}
 
-    def human_readable(self):
+    def human_readable(self) -> str:
         """Return a volume name if available
 
         :rtype: either the volume ID or name
@@ -60,7 +65,7 @@ class VolumeIdColumn(cliff_columns.FormattableColumn[str]):
         return volume
 
 
-def _format_snapshot(snapshot: _snapshot.Snapshot) -> dict[str, ty.Any]:
+def _format_snapshot(snapshot: _snapshot.Snapshot) -> dict[str, object]:
     # Some columns returned by openstacksdk should not be shown because they're
     # either irrelevant or duplicates
     ignored_columns = {
@@ -99,7 +104,7 @@ def _format_snapshot(snapshot: _snapshot.Snapshot) -> dict[str, ty.Any]:
 class CreateVolumeSnapshot(command.ShowOne):
     _description = _("Create new volume snapshot")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "snapshot_name",
@@ -123,7 +128,9 @@ class CreateVolumeSnapshot(command.ShowOne):
             action="store_true",
             default=False,
             help=_(
-                "Create a snapshot attached to an instance. Default is False"
+                "Allow snapshot of in-use (attached) volume. "
+                "Only needed for microversions prior to 3.66; "
+                "ignored for 3.66+"
             ),
         )
         parser.add_argument(
@@ -149,8 +156,12 @@ class CreateVolumeSnapshot(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '3'
+        )
 
         volume = parsed_args.volume
         if not parsed_args.volume:
@@ -176,22 +187,33 @@ class CreateVolumeSnapshot(command.ShowOne):
             )
         else:
             # Create a new snapshot from scratch
-            snapshot = volume_client.create_snapshot(
-                volume_id=volume_id,
-                force=parsed_args.force,
-                name=parsed_args.snapshot_name,
-                description=parsed_args.description,
-                metadata=parsed_args.properties,
-            )
+            # only for microversion < 3.66, pass force parameter
+            # for backward compatibility
+            if not sdk_utils.supports_microversion(volume_client, '3.66'):
+                snapshot = volume_client.create_snapshot(
+                    volume_id=volume_id,
+                    force=parsed_args.force,
+                    name=parsed_args.snapshot_name,
+                    description=parsed_args.description,
+                    metadata=parsed_args.properties,
+                )
+            else:
+                snapshot = volume_client.create_snapshot(
+                    volume_id=volume_id,
+                    name=parsed_args.snapshot_name,
+                    description=parsed_args.description,
+                    metadata=parsed_args.properties,
+                )
 
         data = _format_snapshot(snapshot)
-        return zip(*sorted(data.items()))
+        col_headers, col_data = zip(*sorted(data.items()))
+        return col_headers, col_data
 
 
 class DeleteVolumeSnapshot(command.Command):
     _description = _("Delete volume snapshot(s)")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "snapshots",
@@ -217,8 +239,10 @@ class DeleteVolumeSnapshot(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '3'
+        )
         result = 0
 
         if parsed_args.remote:
@@ -262,7 +286,7 @@ class DeleteVolumeSnapshot(command.Command):
 class ListVolumeSnapshot(command.Lister):
     _description = _("List volume snapshots")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             '--all-projects',
@@ -313,8 +337,12 @@ class ListVolumeSnapshot(command.Lister):
         pagination.add_marker_pagination_option_to_parser(parser)
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[tuple[str, ...], Iterable[tuple[Any, ...]]]:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '3'
+        )
         identity_client = self.app.client_manager.identity
 
         columns: tuple[str, ...] = (
@@ -377,6 +405,7 @@ class ListVolumeSnapshot(command.Lister):
         data = volume_client.snapshots(
             marker=parsed_args.marker,
             limit=parsed_args.limit,
+            max_items=parsed_args.max_items,
             all_projects=all_projects,
             project_id=project_id,
             name=parsed_args.name,
@@ -402,7 +431,7 @@ class ListVolumeSnapshot(command.Lister):
 class SetVolumeSnapshot(command.Command):
     _description = _("Set volume snapshot properties")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'snapshot',
@@ -458,8 +487,10 @@ class SetVolumeSnapshot(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '3'
+        )
 
         snapshot = volume_client.find_snapshot(
             parsed_args.snapshot, ignore_missing=False
@@ -517,7 +548,7 @@ class SetVolumeSnapshot(command.Command):
 class ShowVolumeSnapshot(command.ShowOne):
     _description = _("Display volume snapshot details")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "snapshot",
@@ -526,21 +557,26 @@ class ShowVolumeSnapshot(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '3'
+        )
 
         snapshot = volume_client.find_snapshot(
             parsed_args.snapshot, ignore_missing=False
         )
 
         data = _format_snapshot(snapshot)
-        return zip(*sorted(data.items()))
+        col_headers, col_data = zip(*sorted(data.items()))
+        return col_headers, col_data
 
 
 class UnsetVolumeSnapshot(command.Command):
     _description = _("Unset volume snapshot properties")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'snapshot',
@@ -560,8 +596,10 @@ class UnsetVolumeSnapshot(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '3'
+        )
 
         snapshot = volume_client.find_snapshot(
             parsed_args.snapshot, ignore_missing=False

openstackclient/volume/v3/volume_transfer_request.py

@@ -14,7 +14,10 @@
 
 """Volume v3 transfer action implementations"""
 
+import argparse
+from collections.abc import Iterable, Sequence
 import logging
+from typing import Any
 
 from cinderclient import api_versions
 from osc_lib import exceptions
@@ -30,7 +33,7 @@ LOG = logging.getLogger(__name__)
 class AcceptTransferRequest(command.ShowOne):
     _description = _("Accept volume transfer request.")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'transfer_request',
@@ -45,7 +48,9 @@ class AcceptTransferRequest(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         volume_client = self.app.client_manager.volume
 
         try:
@@ -63,13 +68,14 @@ class AcceptTransferRequest(command.ShowOne):
         )
         transfer_accept._info.pop("links", None)
 
-        return zip(*sorted(transfer_accept._info.items()))
+        col_headers, col_data = zip(*sorted(transfer_accept._info.items()))
+        return col_headers, col_data
 
 
 class CreateTransferRequest(command.ShowOne):
     _description = _("Create volume transfer request.")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             '--name',
@@ -102,7 +108,9 @@ class CreateTransferRequest(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         volume_client = self.app.client_manager.volume
 
         kwargs = {}
@@ -130,13 +138,16 @@ class CreateTransferRequest(command.ShowOne):
         )
         volume_transfer_request._info.pop("links", None)
 
-        return zip(*sorted(volume_transfer_request._info.items()))
+        col_headers, col_data = zip(
+            *sorted(volume_transfer_request._info.items())
+        )
+        return col_headers, col_data
 
 
 class DeleteTransferRequest(command.Command):
     _description = _("Delete volume transfer request(s).")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'transfer_request',
@@ -146,7 +157,7 @@ class DeleteTransferRequest(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         volume_client = self.app.client_manager.volume
         result = 0
 
@@ -179,7 +190,7 @@ class DeleteTransferRequest(command.Command):
 class ListTransferRequest(command.Lister):
     _description = _("Lists all volume transfer requests.")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             '--all-projects',
@@ -190,7 +201,9 @@ class ListTransferRequest(command.Lister):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[tuple[Any, ...]]]:
         columns = ['ID', 'Name', 'Volume ID']
         column_headers = ['ID', 'Name', 'Volume']
 
@@ -213,7 +226,7 @@ class ListTransferRequest(command.Lister):
 class ShowTransferRequest(command.ShowOne):
     _description = _("Show volume transfer request details.")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'transfer_request',
@@ -222,7 +235,9 @@ class ShowTransferRequest(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         volume_client = self.app.client_manager.volume
         volume_transfer_request = utils.find_resource(
             volume_client.transfers,
@@ -230,4 +245,7 @@ class ShowTransferRequest(command.ShowOne):
         )
         volume_transfer_request._info.pop("links", None)
 
-        return zip(*sorted(volume_transfer_request._info.items()))
+        col_headers, col_data = zip(
+            *sorted(volume_transfer_request._info.items())
+        )
+        return col_headers, col_data

openstackclient/volume/v3/volume_type.py

@@ -13,9 +13,11 @@
 
 """Volume v3 Type action implementations"""
 
+import argparse
+from collections.abc import Iterable, MutableMapping, Sequence
 import functools
 import logging
-import typing as ty
+from typing import Any
 
 from cinderclient import api_versions
 from cliff import columns as cliff_columns
@@ -32,7 +34,7 @@ from openstackclient.identity import common as identity_common
 LOG = logging.getLogger(__name__)
 
 
-class EncryptionInfoColumn(cliff_columns.FormattableColumn[ty.Any]):
+class EncryptionInfoColumn(cliff_columns.FormattableColumn[Any]):
     """Formattable column for encryption info column.
 
     Unlike the parent FormattableColumn class, the initializer of the
@@ -43,26 +45,30 @@ class EncryptionInfoColumn(cliff_columns.FormattableColumn[ty.Any]):
     ``functools.partial(EncryptionInfoColumn encryption_data)``.
     """
 
-    def __init__(self, value, encryption_data=None):
+    def __init__(
+        self, value: Any, encryption_data: dict[str, Any] | None = None
+    ) -> None:
         super().__init__(value)
         self._encryption_data = encryption_data or {}
 
-    def _get_encryption_info(self):
+    def _get_encryption_info(self) -> Any:
         type_id = self._value
         return self._encryption_data.get(type_id)
 
-    def human_readable(self):
+    def human_readable(self) -> str:
         encryption_info = self._get_encryption_info()
         if encryption_info:
             return utils.format_dict(encryption_info)
         else:
             return '-'
 
-    def machine_readable(self):
+    def machine_readable(self) -> Any:
         return self._get_encryption_info()
 
 
-def _create_encryption_type(volume_client, volume_type, parsed_args):
+def _create_encryption_type(
+    volume_client: Any, volume_type: Any, parsed_args: argparse.Namespace
+) -> Any:
     if not parsed_args.encryption_provider:
         msg = _(
             "'--encryption-provider' should be specified while "
@@ -85,7 +91,9 @@ def _create_encryption_type(volume_client, volume_type, parsed_args):
     return encryption
 
 
-def _set_encryption_type(volume_client, volume_type, parsed_args):
+def _set_encryption_type(
+    volume_client: Any, volume_type: Any, parsed_args: argparse.Namespace
+) -> None:
     # update the existing encryption type
     body = {}
     for attr in ['provider', 'cipher', 'key_size', 'control_location']:
@@ -109,7 +117,7 @@ def _set_encryption_type(volume_client, volume_type, parsed_args):
 class CreateVolumeType(command.ShowOne):
     _description = _("Create new volume type")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "name",
@@ -243,7 +251,9 @@ class CreateVolumeType(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         identity_client = self.app.client_manager.identity
         volume_client = self.app.client_manager.volume
 
@@ -325,13 +335,14 @@ class CreateVolumeType(command.ShowOne):
 
         volume_type._info.pop("os-volume-type-access:is_public", None)
 
-        return zip(*sorted(volume_type._info.items()))
+        col_headers, col_data = zip(*sorted(volume_type._info.items()))
+        return col_headers, col_data
 
 
 class DeleteVolumeType(command.Command):
     _description = _("Delete volume type(s)")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "volume_types",
@@ -341,7 +352,7 @@ class DeleteVolumeType(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         volume_client = self.app.client_manager.volume
         result = 0
 
@@ -373,7 +384,7 @@ class DeleteVolumeType(command.Command):
 class ListVolumeType(command.Lister):
     _description = _("List volume types")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             '--long',
@@ -467,7 +478,9 @@ class ListVolumeType(command.Lister):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[tuple[Any, ...]]]:
         volume_client = self.app.client_manager.volume
 
         if parsed_args.long:
@@ -522,7 +535,9 @@ class ListVolumeType(command.Lister):
                 is_public=parsed_args.is_public,
             )
 
-        formatters = {'Extra Specs': format_columns.DictColumn}
+        formatters: MutableMapping[str, Any] = {
+            'Extra Specs': format_columns.DictColumn
+        }
 
         if parsed_args.encryption_type:
             encryption = {}
@@ -549,7 +564,7 @@ class ListVolumeType(command.Lister):
             _EncryptionInfoColumn = functools.partial(
                 EncryptionInfoColumn, encryption_data=encryption
             )
-            formatters['id'] = _EncryptionInfoColumn  # type: ignore
+            formatters['id'] = _EncryptionInfoColumn
 
         return (
             column_headers,
@@ -567,7 +582,7 @@ class ListVolumeType(command.Lister):
 class SetVolumeType(command.Command):
     _description = _("Set volume type properties")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'volume_type',
@@ -706,7 +721,7 @@ class SetVolumeType(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         volume_client = self.app.client_manager.volume
         identity_client = self.app.client_manager.identity
 
@@ -802,7 +817,7 @@ class SetVolumeType(command.Command):
 class ShowVolumeType(command.ShowOne):
     _description = _("Display volume type details")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "volume_type",
@@ -819,7 +834,9 @@ class ShowVolumeType(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         volume_client = self.app.client_manager.volume
         volume_type = utils.find_resource(
             volume_client.volume_types, parsed_args.volume_type
@@ -867,13 +884,14 @@ class ShowVolumeType(command.ShowOne):
                     e,
                 )
         volume_type._info.pop("os-volume-type-access:is_public", None)
-        return zip(*sorted(volume_type._info.items()))
+        col_headers, col_data = zip(*sorted(volume_type._info.items()))
+        return col_headers, col_data
 
 
 class UnsetVolumeType(command.Command):
     _description = _("Unset volume type properties")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'volume_type',
@@ -908,7 +926,7 @@ class UnsetVolumeType(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         volume_client = self.app.client_manager.volume
         identity_client = self.app.client_manager.identity