python-openstackclient 9.0.0__py3-none-any.whl → 10.1.0__py3-none-any.whl

openstackclient/volume/v2/volume_snapshot.py

@@ -14,12 +14,15 @@
 
 """Volume v2 snapshot action implementations"""
 
+import argparse
 import functools
 import logging
-import typing as ty
+from collections.abc import Iterable, Sequence
+from typing import Any
 
 from cliff import columns as cliff_columns
 from openstack.block_storage.v2 import snapshot as _snapshot
+from openstack import utils as sdk_utils
 from osc_lib.cli import format_columns
 from osc_lib.cli import parseractions
 from osc_lib import exceptions
@@ -45,11 +48,13 @@ class VolumeIdColumn(cliff_columns.FormattableColumn[str]):
     ``functools.partial(VolumeIdColumn, volume_cache)``.
     """
 
-    def __init__(self, value, volume_cache=None):
+    def __init__(
+        self, value: str, volume_cache: dict[str, Any] | None = None
+    ) -> None:
         super().__init__(value)
         self._volume_cache = volume_cache or {}
 
-    def human_readable(self):
+    def human_readable(self) -> str:
         """Return a volume name if available
 
         :rtype: either the volume ID or name
@@ -61,7 +66,7 @@ class VolumeIdColumn(cliff_columns.FormattableColumn[str]):
         return volume
 
 
-def _format_snapshot(snapshot: _snapshot.Snapshot) -> dict[str, ty.Any]:
+def _format_snapshot(snapshot: _snapshot.Snapshot) -> dict[str, object]:
     # Some columns returned by openstacksdk should not be shown because they're
     # either irrelevant or duplicates
     ignored_columns = {
@@ -100,7 +105,7 @@ def _format_snapshot(snapshot: _snapshot.Snapshot) -> dict[str, ty.Any]:
 class CreateVolumeSnapshot(command.ShowOne):
     _description = _("Create new volume snapshot")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "snapshot_name",
@@ -150,8 +155,12 @@ class CreateVolumeSnapshot(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '2'
+        )
 
         volume = parsed_args.volume
         if not parsed_args.volume:
@@ -186,13 +195,14 @@ class CreateVolumeSnapshot(command.ShowOne):
             )
 
         data = _format_snapshot(snapshot)
-        return zip(*sorted(data.items()))
+        col_headers, col_data = zip(*sorted(data.items()))
+        return col_headers, col_data
 
 
 class DeleteVolumeSnapshot(command.Command):
     _description = _("Delete volume snapshot(s)")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "snapshots",
@@ -210,8 +220,10 @@ class DeleteVolumeSnapshot(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '2'
+        )
         result = 0
 
         for snapshot in parsed_args.snapshots:
@@ -220,7 +232,8 @@ class DeleteVolumeSnapshot(command.Command):
                     snapshot, ignore_missing=False
                 ).id
                 volume_client.delete_snapshot(
-                    snapshot_id, force=parsed_args.force
+                    snapshot_id,
+                    force=parsed_args.force,
                 )
             except Exception as e:
                 result += 1
@@ -244,7 +257,7 @@ class DeleteVolumeSnapshot(command.Command):
 class ListVolumeSnapshot(command.Lister):
     _description = _("List volume snapshots")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             '--all-projects',
@@ -295,8 +308,12 @@ class ListVolumeSnapshot(command.Lister):
         pagination.add_marker_pagination_option_to_parser(parser)
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[tuple[Any, ...]]]:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '2'
+        )
         identity_client = self.app.client_manager.identity
 
         columns: tuple[str, ...] = (
@@ -359,6 +376,7 @@ class ListVolumeSnapshot(command.Lister):
         data = volume_client.snapshots(
             marker=parsed_args.marker,
             limit=parsed_args.limit,
+            max_items=parsed_args.max_items,
             all_projects=all_projects,
             project_id=project_id,
             name=parsed_args.name,
@@ -384,7 +402,7 @@ class ListVolumeSnapshot(command.Lister):
 class SetVolumeSnapshot(command.Command):
     _description = _("Set volume snapshot properties")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'snapshot',
@@ -440,8 +458,10 @@ class SetVolumeSnapshot(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '2'
+        )
 
         snapshot = volume_client.find_snapshot(
             parsed_args.snapshot, ignore_missing=False
@@ -499,7 +519,7 @@ class SetVolumeSnapshot(command.Command):
 class ShowVolumeSnapshot(command.ShowOne):
     _description = _("Display volume snapshot details")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "snapshot",
@@ -508,21 +528,26 @@ class ShowVolumeSnapshot(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
-        volume_client = self.app.client_manager.sdk_connection.volume
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
+        volume_client = sdk_utils.ensure_service_version(
+            self.app.client_manager.sdk_connection.volume, '2'
+        )
 
         snapshot = volume_client.find_snapshot(
             parsed_args.snapshot, ignore_missing=False
         )
 
         data = _format_snapshot(snapshot)
-        return zip(*sorted(data.items()))
+        col_headers, col_data = zip(*sorted(data.items()))
+        return col_headers, col_data
 
 
 class UnsetVolumeSnapshot(command.Command):
     _description = _("Unset volume snapshot properties")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'snapshot',
@@ -542,7 +567,7 @@ class UnsetVolumeSnapshot(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         volume_client = self.app.client_manager.sdk_connection.volume
 
         snapshot = volume_client.find_snapshot(

openstackclient/volume/v2/volume_transfer_request.py

@@ -14,7 +14,10 @@
 
 """Volume v2 transfer action implementations"""
 
+import argparse
 import logging
+from collections.abc import Iterable, Sequence
+from typing import Any
 
 from osc_lib import exceptions
 from osc_lib import utils
@@ -29,7 +32,7 @@ LOG = logging.getLogger(__name__)
 class AcceptTransferRequest(command.ShowOne):
     _description = _("Accept volume transfer request.")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'transfer_request',
@@ -44,7 +47,9 @@ class AcceptTransferRequest(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         volume_client = self.app.client_manager.volume
 
         try:
@@ -62,13 +67,14 @@ class AcceptTransferRequest(command.ShowOne):
         )
         transfer_accept._info.pop("links", None)
 
-        return zip(*sorted(transfer_accept._info.items()))
+        col_headers, col_data = zip(*sorted(transfer_accept._info.items()))
+        return col_headers, col_data
 
 
 class CreateTransferRequest(command.ShowOne):
     _description = _("Create volume transfer request.")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             '--name',
@@ -82,7 +88,9 @@ class CreateTransferRequest(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         volume_client = self.app.client_manager.volume
 
         volume_id = utils.find_resource(
@@ -95,13 +103,16 @@ class CreateTransferRequest(command.ShowOne):
         )
         volume_transfer_request._info.pop("links", None)
 
-        return zip(*sorted(volume_transfer_request._info.items()))
+        col_headers, col_data = zip(
+            *sorted(volume_transfer_request._info.items())
+        )
+        return col_headers, col_data
 
 
 class DeleteTransferRequest(command.Command):
     _description = _("Delete volume transfer request(s).")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'transfer_request',
@@ -111,7 +122,7 @@ class DeleteTransferRequest(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         volume_client = self.app.client_manager.volume
         result = 0
 
@@ -144,7 +155,7 @@ class DeleteTransferRequest(command.Command):
 class ListTransferRequest(command.Lister):
     _description = _("Lists all volume transfer requests.")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             '--all-projects',
@@ -155,7 +166,9 @@ class ListTransferRequest(command.Lister):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[tuple[Any, ...]]]:
         columns = ['ID', 'Name', 'Volume ID']
         column_headers = ['ID', 'Name', 'Volume']
 
@@ -178,7 +191,7 @@ class ListTransferRequest(command.Lister):
 class ShowTransferRequest(command.ShowOne):
     _description = _("Show volume transfer request details.")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'transfer_request',
@@ -187,7 +200,9 @@ class ShowTransferRequest(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         volume_client = self.app.client_manager.volume
         volume_transfer_request = utils.find_resource(
             volume_client.transfers,
@@ -195,4 +210,7 @@ class ShowTransferRequest(command.ShowOne):
         )
         volume_transfer_request._info.pop("links", None)
 
-        return zip(*sorted(volume_transfer_request._info.items()))
+        col_headers, col_data = zip(
+            *sorted(volume_transfer_request._info.items())
+        )
+        return col_headers, col_data

openstackclient/volume/v2/volume_type.py

@@ -14,9 +14,12 @@
 
 """Volume v2 Type action implementations"""
 
+import argparse
+from collections.abc import MutableMapping
 import functools
 import logging
-import typing as ty
+from collections.abc import Iterable, Sequence
+from typing import Any
 
 from cliff import columns as cliff_columns
 from osc_lib.cli import format_columns
@@ -32,7 +35,7 @@ from openstackclient.identity import common as identity_common
 LOG = logging.getLogger(__name__)
 
 
-class EncryptionInfoColumn(cliff_columns.FormattableColumn[ty.Any]):
+class EncryptionInfoColumn(cliff_columns.FormattableColumn[Any]):
     """Formattable column for encryption info column.
 
     Unlike the parent FormattableColumn class, the initializer of the
@@ -43,26 +46,30 @@ class EncryptionInfoColumn(cliff_columns.FormattableColumn[ty.Any]):
     ``functools.partial(EncryptionInfoColumn encryption_data)``.
     """
 
-    def __init__(self, value, encryption_data=None):
+    def __init__(
+        self, value: Any, encryption_data: dict[str, Any] | None = None
+    ) -> None:
         super().__init__(value)
         self._encryption_data = encryption_data or {}
 
-    def _get_encryption_info(self):
+    def _get_encryption_info(self) -> Any:
         type_id = self._value
         return self._encryption_data.get(type_id)
 
-    def human_readable(self):
+    def human_readable(self) -> str:
         encryption_info = self._get_encryption_info()
         if encryption_info:
             return utils.format_dict(encryption_info)
         else:
             return '-'
 
-    def machine_readable(self):
+    def machine_readable(self) -> Any:
         return self._get_encryption_info()
 
 
-def _create_encryption_type(volume_client, volume_type, parsed_args):
+def _create_encryption_type(
+    volume_client: Any, volume_type: Any, parsed_args: argparse.Namespace
+) -> Any:
     if not parsed_args.encryption_provider:
         msg = _(
             "'--encryption-provider' should be specified while "
@@ -85,7 +92,9 @@ def _create_encryption_type(volume_client, volume_type, parsed_args):
     return encryption
 
 
-def _set_encryption_type(volume_client, volume_type, parsed_args):
+def _set_encryption_type(
+    volume_client: Any, volume_type: Any, parsed_args: argparse.Namespace
+) -> None:
     # update the existing encryption type
     body = {}
     for attr in ['provider', 'cipher', 'key_size', 'control_location']:
@@ -109,7 +118,7 @@ def _set_encryption_type(volume_client, volume_type, parsed_args):
 class CreateVolumeType(command.ShowOne):
     _description = _("Create new volume type")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "name",
@@ -243,7 +252,9 @@ class CreateVolumeType(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         identity_client = self.app.client_manager.identity
         volume_client = self.app.client_manager.volume
 
@@ -325,13 +336,14 @@ class CreateVolumeType(command.ShowOne):
 
         volume_type._info.pop("os-volume-type-access:is_public", None)
 
-        return zip(*sorted(volume_type._info.items()))
+        col_headers, col_data = zip(*sorted(volume_type._info.items()))
+        return col_headers, col_data
 
 
 class DeleteVolumeType(command.Command):
     _description = _("Delete volume type(s)")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "volume_types",
@@ -341,7 +353,7 @@ class DeleteVolumeType(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         volume_client = self.app.client_manager.volume
         result = 0
 
@@ -373,7 +385,7 @@ class DeleteVolumeType(command.Command):
 class ListVolumeType(command.Lister):
     _description = _("List volume types")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             '--long',
@@ -412,7 +424,9 @@ class ListVolumeType(command.Lister):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[tuple[Any, ...]]]:
         volume_client = self.app.client_manager.volume
 
         if parsed_args.long:
@@ -439,7 +453,9 @@ class ListVolumeType(command.Lister):
                 is_public=parsed_args.is_public,
             )
 
-        formatters = {'Extra Specs': format_columns.DictColumn}
+        formatters: MutableMapping[str, Any] = {
+            'Extra Specs': format_columns.DictColumn
+        }
 
         if parsed_args.encryption_type:
             encryption = {}
@@ -466,7 +482,7 @@ class ListVolumeType(command.Lister):
             _EncryptionInfoColumn = functools.partial(
                 EncryptionInfoColumn, encryption_data=encryption
             )
-            formatters['id'] = _EncryptionInfoColumn  # type: ignore
+            formatters['id'] = _EncryptionInfoColumn
 
         return (
             column_headers,
@@ -484,7 +500,7 @@ class ListVolumeType(command.Lister):
 class SetVolumeType(command.Command):
     _description = _("Set volume type properties")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'volume_type',
@@ -623,7 +639,7 @@ class SetVolumeType(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         volume_client = self.app.client_manager.volume
         identity_client = self.app.client_manager.identity
 
@@ -719,7 +735,7 @@ class SetVolumeType(command.Command):
 class ShowVolumeType(command.ShowOne):
     _description = _("Display volume type details")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "volume_type",
@@ -736,7 +752,9 @@ class ShowVolumeType(command.ShowOne):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
         volume_client = self.app.client_manager.volume
         volume_type = utils.find_resource(
             volume_client.volume_types, parsed_args.volume_type
@@ -784,13 +802,14 @@ class ShowVolumeType(command.ShowOne):
                     e,
                 )
         volume_type._info.pop("os-volume-type-access:is_public", None)
-        return zip(*sorted(volume_type._info.items()))
+        col_headers, col_data = zip(*sorted(volume_type._info.items()))
+        return col_headers, col_data
 
 
 class UnsetVolumeType(command.Command):
     _description = _("Unset volume type properties")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             'volume_type',
@@ -825,7 +844,7 @@ class UnsetVolumeType(command.Command):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         volume_client = self.app.client_manager.volume
         identity_client = self.app.client_manager.identity
 

openstackclient/volume/v3/backup_record.py

@@ -0,0 +1,94 @@
+#
+#   Licensed under the Apache License, Version 2.0 (the "License"); you may
+#   not use this file except in compliance with the License. You may obtain
+#   a copy of the License at
+#
+#        http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#   WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#   License for the specific language governing permissions and limitations
+#   under the License.
+
+"""Volume v3 Backup action implementations"""
+
+import argparse
+import logging
+from collections.abc import Iterable, Sequence
+from typing import Any
+
+from osc_lib import utils
+
+from openstackclient import command
+from openstackclient.i18n import _
+
+LOG = logging.getLogger(__name__)
+
+
+class ExportBackupRecord(command.ShowOne):
+    _description = _(
+        """Export volume backup details.
+
+Backup information can be imported into a new service instance to be able to
+restore."""
+    )
+
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
+        parser = super().get_parser(prog_name)
+        parser.add_argument(
+            "backup",
+            metavar="<backup>",
+            help=_("Backup to export (name or ID)"),
+        )
+        return parser
+
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
+        volume_client = self.app.client_manager.volume
+        backup = utils.find_resource(volume_client.backups, parsed_args.backup)
+        backup_data = volume_client.backups.export_record(backup.id)
+
+        # We only want to show "friendly" display names, but also want to keep
+        # json structure compatibility with cinderclient
+        if parsed_args.formatter == 'table':
+            backup_data['Backup Service'] = backup_data.pop('backup_service')
+            backup_data['Metadata'] = backup_data.pop('backup_url')
+
+        col_headers, col_data = zip(*sorted(backup_data.items()))
+        return col_headers, col_data
+
+
+class ImportBackupRecord(command.ShowOne):
+    _description = _(
+        """Import volume backup details.
+
+Exported backup details contain the metadata necessary to restore to a new or
+rebuilt service instance"""
+    )
+
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
+        parser = super().get_parser(prog_name)
+        parser.add_argument(
+            "backup_service",
+            metavar="<backup_service>",
+            help=_("Backup service containing the backup."),
+        )
+        parser.add_argument(
+            "backup_metadata",
+            metavar="<backup_metadata>",
+            help=_("Encoded backup metadata from export."),
+        )
+        return parser
+
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[Sequence[str], Iterable[Any]]:
+        volume_client = self.app.client_manager.volume
+        backup_data = volume_client.backups.import_record(
+            parsed_args.backup_service, parsed_args.backup_metadata
+        )
+        backup_data.pop('links', None)
+        col_headers, col_data = zip(*sorted(backup_data.items()))
+        return col_headers, col_data

openstackclient/volume/v3/block_storage_cleanup.py

@@ -10,6 +10,10 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+import argparse
+from collections.abc import Iterable
+from typing import Any
+
 from cinderclient import api_versions
 from osc_lib import exceptions
 
@@ -17,7 +21,9 @@ from openstackclient import command
 from openstackclient.i18n import _
 
 
-def _format_cleanup_response(cleaning, unavailable):
+def _format_cleanup_response(
+    cleaning: Any, unavailable: Any
+) -> tuple[tuple[str, ...], list[tuple[Any, ...]]]:
     column_headers = (
         'ID',
         'Cluster Name',
@@ -49,7 +55,7 @@ class BlockStorageCleanup(command.Lister):
     This command requires ``--os-volume-api-version`` 3.24 or greater.
     """
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             '--cluster',
@@ -127,7 +133,9 @@ class BlockStorageCleanup(command.Lister):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(
+        self, parsed_args: argparse.Namespace
+    ) -> tuple[tuple[str, ...], Iterable[tuple[Any, ...]]]:
         volume_client = self.app.client_manager.volume
 
         if volume_client.api_version < api_versions.APIVersion('3.24'):