passagemath-modules 10.5.46__cp310-cp310-macosx_14_0_arm64.whl → 10.6.20__cp310-cp310-macosx_14_0_arm64.whl

sage/rings/function_field/khuri_makdisi.pyx

@@ -88,7 +88,6 @@ cdef class KhuriMakdisi_base(object):
 
         TESTS::
 
-            sage: # long time
             sage: k = GF(7)
             sage: A.<x,y> = AffineSpace(k,2)
             sage: C = Curve(y^2 + x^3 + 2*x + 1).projective_closure()
@@ -183,7 +182,6 @@ cdef class KhuriMakdisi_base(object):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: h = C.function(y/x).divisor_of_poles()
@@ -209,7 +207,6 @@ cdef class KhuriMakdisi_base(object):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: h = C.function(y/x).divisor_of_poles()
@@ -235,7 +232,6 @@ cdef class KhuriMakdisi_base(object):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: h = C.function(y/x).divisor_of_poles()
@@ -261,7 +257,6 @@ cdef class KhuriMakdisi_base(object):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: h = C.function(y/x).divisor_of_poles()
@@ -331,7 +326,6 @@ cdef class KhuriMakdisi_base(object):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: h = C.function(y/x).divisor_of_poles()
@@ -365,7 +359,6 @@ cdef class KhuriMakdisi_large(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: h = C.function(y/x).divisor_of_poles()
@@ -423,7 +416,6 @@ cdef class KhuriMakdisi_large(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(7), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: J = C.jacobian(model='km_large')
@@ -486,7 +478,6 @@ cdef class KhuriMakdisi_large(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: F = C.function_field()
@@ -518,7 +509,7 @@ cdef class KhuriMakdisi_large(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
+            sage: # needs sage.combinat
             sage: k = GF(7)
             sage: A.<x,y> = AffineSpace(k,2)
             sage: C = Curve(y^2 + x^3 + 2*x + 1).projective_closure()
@@ -549,7 +540,6 @@ cdef class KhuriMakdisi_medium(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: h = C.function(y/x).divisor_of_poles()
@@ -601,7 +591,6 @@ cdef class KhuriMakdisi_medium(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: h = C.function(y/x).divisor_of_poles()
@@ -637,7 +626,6 @@ cdef class KhuriMakdisi_medium(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: h = C.function(y/x).divisor_of_poles()
@@ -657,7 +645,6 @@ cdef class KhuriMakdisi_medium(KhuriMakdisi_base):
 
         We check the computation in other model::
 
-            sage: # long time
             sage: J = C.jacobian(model='km_large', base_div=h)
             sage: G = J.group()
             sage: p1 = G.point(pl1 - b)
@@ -687,7 +674,7 @@ cdef class KhuriMakdisi_medium(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
+            sage: # needs sage.combinat
             sage: k = GF(7)
             sage: A.<x,y> = AffineSpace(k,2)
             sage: C = Curve(y^2 + x^3 + 2*x + 1).projective_closure()
@@ -719,7 +706,6 @@ cdef class KhuriMakdisi_small(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: b = C([0,1,0]).place()
@@ -777,7 +763,6 @@ cdef class KhuriMakdisi_small(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: b = C([0,1,0]).place()
@@ -812,7 +797,6 @@ cdef class KhuriMakdisi_small(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(17), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: b = C([0,1,0]).place()
@@ -832,7 +816,6 @@ cdef class KhuriMakdisi_small(KhuriMakdisi_base):
 
         We check the computation in other model::
 
-            sage: # long time
             sage: h = C.function(y/x).divisor_of_poles()
             sage: Jl = C.jacobian(model='km_large', base_div=h)
             sage: G = J.group()
@@ -840,13 +823,34 @@ cdef class KhuriMakdisi_small(KhuriMakdisi_base):
             sage: q2 = G.point(pl2 - b)
             sage: G.point(af.divisor()) == q1.addflip(p2)
             True
+
+        Check that :issue:`40237` is fixed::
+
+            sage: K = GF(2)
+            sage: F.<x> = FunctionField(K)
+            sage: t = polygen(F)
+            sage: E.<y> = F.extension(t^3 + (x^2 + x + 1)*t^2 + (x^3 + x + 1)*t + x^5 + x^4)
+            sage: O = E.maximal_order()
+            sage: Oinf = E.maximal_order_infinite()
+            sage: D1 = (-5*O.ideal(x, y).divisor() + O.ideal(x + 1, y^2 + y + 1).divisor()
+            ....:   + O.ideal(x^3 + x^2 + 1, y + x + 1).divisor())
+            sage: D2 = (Oinf.ideal(1/x, y/x^2 + 1).divisor() - 5*O.ideal(x, y).divisor()
+            ....:   + O.ideal(x^4 + x^3 + 1, y + x).divisor())
+            sage: J = E.jacobian('km_small', base_div=5*O.ideal(x, y).divisor())
+            sage: JD1 = J(D1)
+            sage: JD2 = J(D2)
+            sage: JD1 + JD2 == JD2 + JD1
+            True
         """
         cdef int d0 = self.d0
         cdef int g = self.g
         cdef Matrix w1, w2, w3, w4, w5
 
         w1 = self.mu_image(wd1, wd2, self.mu_mat33, 4*d0 - g + 1)
-        w2 = self.mu_preimage(self.wV3, w1, self.mu_mat33, 2*d0)
+        # The row space of w2 represents H^0(O(3D_0 - D1 - D2)), whose
+        # dimension is at least d0 - g + 1. Hence the codimension is at most
+        # 2*d0, and we cannot provide an expected_codim argument for mu_preimage.
+        w2 = self.mu_preimage(self.wV3, w1, self.mu_mat33)
         w3 = self.mu_preimage(self.wV2, w1, self.mu_mat42, 2*d0)
         # efficient than
         #   wf = matrix(w2[0])
@@ -861,7 +865,6 @@ cdef class KhuriMakdisi_small(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
             sage: P2.<x,y,z> = ProjectiveSpace(GF(7), 2)
             sage: C = Curve(x^3 + 5*z^3 - y^2*z, P2)
             sage: b = C([0,1,0]).place()
@@ -876,7 +879,6 @@ cdef class KhuriMakdisi_small(KhuriMakdisi_base):
 
         Check that :issue:`39148` is fixed::
 
-            sage: # long time
             sage: k.<x> = FunctionField(GF(17)); t = polygen(k)
             sage: F.<y> = k.extension(t^4 + (14*x + 14)*t^3 + 9*t^2 + (10*x^2 + 15*x + 8)*t
             ....:  + 7*x^3 + 15*x^2 + 6*x + 16)
@@ -895,8 +897,8 @@ cdef class KhuriMakdisi_small(KhuriMakdisi_base):
 
         w1 = self.mu_image(self.wV2, wd, self.mu_mat23, 4*d0 - g + 1)
         # The row space of w2 represents H^0(O(2D_0 - D)), whose dimension is
-        # at least d0 - g + 1, and hence the codimension is at most d0. Thus,
-        # we cannot provide an expected_codim argument for mu_preimage.
+        # at least d0 - g + 1. Hence the codimension is at most d0, and we
+        # cannot provide an expected_codim argument for mu_preimage.
         w2 = self.mu_preimage(self.wV3, w1, self.mu_mat23)
         # efficient than
         #   wf = matrix(w2[0])
@@ -914,7 +916,7 @@ cdef class KhuriMakdisi_small(KhuriMakdisi_base):
 
         TESTS::
 
-            sage: # long time
+            sage: # needs sage.combinat
             sage: k = GF(7)
             sage: A.<x,y> = AffineSpace(k,2)
             sage: C = Curve(y^2 + x^3 + 2*x + 1).projective_closure()

sage/rings/invariants/invariant_theory.py

@@ -119,7 +119,7 @@ import sage.rings.invariants.reconstruction as reconstruction
 
 
 ######################################################################
-def _guess_variables(polynomial, *args):
+def _guess_variables(polynomial, *args) -> tuple:
     """
     Return the polynomial variables.
 
@@ -276,16 +276,16 @@ def transvectant(f, g, h=1, scale='default'):
         from sage.functions.other import binomial, factorial
         if scale == 'default':
             scalar = factorial(f._d-h) * factorial(g._d-h) \
-                        * R(factorial(f._d)*factorial(g._d))**(-1)
+                * R(factorial(f._d)*factorial(g._d))**(-1)
         elif scale == 'none':
             scalar = 1
         else:
             raise ValueError('unknown scale type: %s' % scale)
 
         def diff(j):
-            df = f.form().derivative(x,j).derivative(y,h-j)
-            dg = g.form().derivative(x,h-j).derivative(y,j)
-            return (-1)**j * binomial(h,j) * df * dg
+            df = f.form().derivative(x, j).derivative(y, h-j)
+            dg = g.form().derivative(x, h-j).derivative(y, j)
+            return (-1)**j * binomial(h, j) * df * dg
         tv = scalar * sum([diff(j) for j in range(h+1)])
         if tv.parent() is not R:
             S = tv.parent()
@@ -368,7 +368,7 @@ class FormsBase(SageObject):
                 dp_dz = d*p - sum(x*dp_dx for x, dp_dx in zip(variables, grad))
                 grad.append(dp_dz)
                 return grad
-        jac = [diff(p,d) for p,d in args]
+        jac = [diff(p, d) for p, d in args]
         return matrix(self._ring, jac).det()
 
     def ring(self):
@@ -608,7 +608,7 @@ class AlgebraicForm(FormsBase):
             g = random_matrix(F, self._n, algorithm='unimodular')
         v = vector(self.variables())
         g_v = g * v
-        transform = dict( (v[i], g_v[i]) for i in range(self._n) )
+        transform = {v[i]: g_v[i] for i in range(self._n)}
         # The covariant of the transformed polynomial
         g_self = self.__class__(self._n, self._d, self.form().subs(transform), self.variables())
         cov_g = getattr(g_self, method_name)()
@@ -917,7 +917,7 @@ class AlgebraicForm(FormsBase):
             from sage.modules.free_module_element import vector
             v = vector(self._ring, self._variables)
             g_v = vector(self._ring, g*v)
-            transform = dict( (v[i], g_v[i]) for i in range(self._n) )
+            transform = {v[i]: g_v[i] for i in range(self._n)}
         # The covariant of the transformed polynomial
         return self.__class__(self._n, self._d,
                               self.form().subs(transform), self.variables())
@@ -1124,12 +1124,12 @@ class QuadraticForm(AlgebraicForm):
         coeff = self.scaled_coeffs()
         A = matrix(self._ring, self._n)
         for i in range(self._n):
-            A[i,i] = coeff[i]
+            A[i, i] = coeff[i]
         ij = self._n
         for i in range(self._n):
             for j in range(i+1, self._n):
-                A[i,j] = coeff[ij]
-                A[j,i] = coeff[ij]
+                A[i, j] = coeff[ij]
+                A[j, i] = coeff[ij]
                 ij += 1
         return A
 
@@ -1260,7 +1260,7 @@ class QuadraticForm(AlgebraicForm):
         else:
             var = self._variables[0:-1] + (1, )
         n = self._n
-        p = sum([ sum([ Aadj[i,j]*var[i]*var[j] for i in range(n) ]) for j in range(n)])
+        p = sum(Aadj[i, j] * var[i] * var[j] for i in range(n) for j in range(n))
         return invariant_theory.quadratic_form(p, self.variables())
 
     def as_QuadraticForm(self):
@@ -2540,7 +2540,7 @@ class TernaryQuadratic(QuadraticForm):
             (x^2, y^2, z^2, x*y, x*z, y*z)
         """
         R = self._ring
-        x,y,z = self._x, self._y, self._z
+        x, y, z = self._x, self._y, self._z
         if self._homogeneous:
             return (x**2, y**2, z**2, x*y, x*z, y*z)
         else:
@@ -2715,7 +2715,7 @@ class TernaryCubic(AlgebraicForm):
             (x^3, y^3, z^3, x^2*y, x^2*z, x*y^2, y^2*z, x*z^2, y*z^2, x*y*z)
         """
         R = self._ring
-        x,y,z = self._x, self._y, self._z
+        x, y, z = self._x, self._y, self._z
         if self._homogeneous:
             return (x**3, y**3, z**3, x**2*y, x**2*z, x*y**2,
                     y**2*z, x*z**2, y*z**2, x*y*z)
@@ -2805,14 +2805,14 @@ class TernaryCubic(AlgebraicForm):
             sage: cubic.S_invariant()
             -1/1296
         """
-        a,b,c,a2,a3,b1,b3,c1,c2,m = self.scaled_coeffs()
-        S = ( a*b*c*m-(b*c*a2*a3+c*a*b1*b3+a*b*c1*c2)
-              - m*(a*b3*c2+b*c1*a3+c*a2*b1)
-              + (a*b1*c2**2+a*c1*b3**2+b*a2*c1**2+b*c2*a3**2+c*b3*a2**2+c*a3*b1**2)
-              - m**4+2*m**2*(b1*c1+c2*a2+a3*b3)
-              - 3*m*(a2*b3*c1+a3*b1*c2)
-              - (b1**2*c1**2+c2**2*a2**2+a3**2*b3**2)
-              + (c2*a2*a3*b3+a3*b3*b1*c1+b1*c1*c2*a2) )
+        a, b, c, a2, a3, b1, b3, c1, c2, m = self.scaled_coeffs()
+        S = (a*b*c*m-(b*c*a2*a3+c*a*b1*b3+a*b*c1*c2)
+             - m*(a*b3*c2+b*c1*a3+c*a2*b1)
+             + (a*b1*c2**2+a*c1*b3**2+b*a2*c1**2+b*c2*a3**2+c*b3*a2**2+c*a3*b1**2)
+             - m**4+2*m**2*(b1*c1+c2*a2+a3*b3)
+             - 3*m*(a2*b3*c1+a3*b1*c2)
+             - (b1**2*c1**2+c2**2*a2**2+a3**2*b3**2)
+             + (c2*a2*a3*b3+a3*b3*b1*c1+b1*c1*c2*a2))
         return S
 
     def T_invariant(self):
@@ -2831,38 +2831,38 @@ class TernaryCubic(AlgebraicForm):
             sage: cubic.T_invariant()
             -t^6 - t^3 + 1
         """
-        a,b,c,a2,a3,b1,b3,c1,c2,m = self.scaled_coeffs()
-        T = ( a**2*b**2*c**2-6*a*b*c*(a*b3*c2+b*c1*a3+c*a2*b1)
-              - 20*a*b*c*m**3+12*a*b*c*m*(b1*c1+c2*a2+a3*b3)
-              + 6*a*b*c*(a2*b3*c1+a3*b1*c2) +
-              4*(a**2*b*c2**3+a**2*c*b3**3+b**2*c*a3**3 +
-                 b**2*a*c1**3+c**2*a*b1**3+c**2*b*a2**3)
-              + 36*m**2*(b*c*a2*a3+c*a*b1*b3+a*b*c1*c2)
-              - 24*m*(b*c*b1*a3**2+b*c*c1*a2**2+c*a*c2*b1**2+c*a*a2*b3**2+a*b*a3*c2**2 +
+        a, b, c, a2, a3, b1, b3, c1, c2, m = self.scaled_coeffs()
+        T = (a**2*b**2*c**2-6*a*b*c*(a*b3*c2+b*c1*a3+c*a2*b1)
+             - 20*a*b*c*m**3+12*a*b*c*m*(b1*c1+c2*a2+a3*b3)
+             + 6*a*b*c*(a2*b3*c1+a3*b1*c2) +
+             4*(a**2*b*c2**3+a**2*c*b3**3+b**2*c*a3**3 +
+                b**2*a*c1**3+c**2*a*b1**3+c**2*b*a2**3)
+             + 36*m**2*(b*c*a2*a3+c*a*b1*b3+a*b*c1*c2)
+             - 24*m*(b*c*b1*a3**2+b*c*c1*a2**2+c*a*c2*b1**2+c*a*a2*b3**2+a*b*a3*c2**2 +
                      a*b*b3*c1**2)
-              - 3*(a**2*b3**2*c2**2+b**2*c1**2*a3**2+c**2*a2**2*b1**2) +
-              18*(b*c*b1*c1*a2*a3+c*a*c2*a2*b3*b1+a*b*a3*b3*c1*c2)
-              - 12*(b*c*c2*a3*a2**2+b*c*b3*a2*a3**2+c*a*c1*b3*b1**2 +
+             - 3*(a**2*b3**2*c2**2+b**2*c1**2*a3**2+c**2*a2**2*b1**2) +
+             18*(b*c*b1*c1*a2*a3+c*a*c2*a2*b3*b1+a*b*a3*b3*c1*c2)
+             - 12*(b*c*c2*a3*a2**2+b*c*b3*a2*a3**2+c*a*c1*b3*b1**2 +
                    c*a*a3*b1*b3**2+a*b*a2*c1*c2**2+a*b*b1*c2*c1**2)
-              - 12*m**3*(a*b3*c2+b*c1*a3+c*a2*b1)
-              + 12*m**2*(a*b1*c2**2+a*c1*b3**2+b*a2*c1**2 +
+             - 12*m**3*(a*b3*c2+b*c1*a3+c*a2*b1)
+             + 12*m**2*(a*b1*c2**2+a*c1*b3**2+b*a2*c1**2 +
                         b*c2*a3**2+c*b3*a2**2+c*a3*b1**2)
-              - 60*m*(a*b1*b3*c1*c2+b*c1*c2*a2*a3+c*a2*a3*b1*b3)
-              + 12*m*(a*a2*b3*c2**2+a*a3*c2*b3**2+b*b3*c1*a3**2 +
+             - 60*m*(a*b1*b3*c1*c2+b*c1*c2*a2*a3+c*a2*a3*b1*b3)
+             + 12*m*(a*a2*b3*c2**2+a*a3*c2*b3**2+b*b3*c1*a3**2 +
                      b*b1*a3*c1**2+c*c1*a2*b1**2+c*c2*b1*a2**2)
-              + 6*(a*b3*c2+b*c1*a3+c*a2*b1)*(a2*b3*c1+a3*b1*c2)
-              + 24*(a*b1*b3**2*c1**2+a*c1*c2**2*b1**2+b*c2*c1**2*a2**2
+             + 6*(a*b3*c2+b*c1*a3+c*a2*b1)*(a2*b3*c1+a3*b1*c2)
+             + 24*(a*b1*b3**2*c1**2+a*c1*c2**2*b1**2+b*c2*c1**2*a2**2
                    + b*a2*a3**2*c2**2+c*a3*a2**2*b3**2+c*b3*b1**2*a3**2)
-              - 12*(a*a2*b1*c2**3+a*a3*c1*b3**3+b*b3*c2*a3**3+b*b1*a2*c1**3
+             - 12*(a*a2*b1*c2**3+a*a3*c1*b3**3+b*b3*c2*a3**3+b*b1*a2*c1**3
                    + c*c1*a3*b1**3+c*c2*b3*a2**3)
-              - 8*m**6+24*m**4*(b1*c1+c2*a2+a3*b3)-36*m**3*(a2*b3*c1+a3*b1*c2)
-              - 12*m**2*(b1*c1*c2*a2+c2*a2*a3*b3+a3*b3*b1*c1)
-              - 24*m**2*(b1**2*c1**2+c2**2*a2**2+a3**2*b3**2)
-              + 36*m*(a2*b3*c1+a3*b1*c2)*(b1*c1+c2*a2+a3*b3)
-              + 8*(b1**3*c1**3+c2**3*a2**3+a3**3*b3**3)
-              - 27*(a2**2*b3**2*c1**2+a3**2*b1**2*c2**2)-6*b1*c1*c2*a2*a3*b3
-              - 12*(b1**2*c1**2*c2*a2+b1**2*c1**2*a3*b3+c2**2*a2**2*a3*b3 +
-                   c2**2*a2**2*b1*c1+a3**2*b3**2*b1*c1+a3**2*b3**2*c2*a2) )
+             - 8*m**6+24*m**4*(b1*c1+c2*a2+a3*b3)-36*m**3*(a2*b3*c1+a3*b1*c2)
+             - 12*m**2*(b1*c1*c2*a2+c2*a2*a3*b3+a3*b3*b1*c1)
+             - 24*m**2*(b1**2*c1**2+c2**2*a2**2+a3**2*b3**2)
+             + 36*m*(a2*b3*c1+a3*b1*c2)*(b1*c1+c2*a2+a3*b3)
+             + 8*(b1**3*c1**3+c2**3*a2**3+a3**3*b3**3)
+             - 27*(a2**2*b3**2*c1**2+a3**2*b1**2*c2**2)-6*b1*c1*c2*a2*a3*b3
+             - 12*(b1**2*c1**2*c2*a2+b1**2*c1**2*a3*b3+c2**2*a2**2*a3*b3 +
+                   c2**2*a2**2*b1*c1+a3**2*b3**2*b1*c1+a3**2*b3**2*c2*a2))
         return T
 
     @cached_method
@@ -2897,9 +2897,9 @@ class TernaryCubic(AlgebraicForm):
         """
         a30, a03, a00, a21, a20, a12, a02, a10, a01, a11 = self.coeffs()
         if self._homogeneous:
-            x,y,z = self.variables()
+            x, y, z = self.variables()
         else:
-            x,y,z = (self._x, self._y, 1)
+            x, y, z = (self._x, self._y, 1)
         F = self._ring.base_ring()
         A00 = 3*x*a30 + y*a21 + z*a20
         A11 = x*a12 + 3*y*a03 + z*a02
@@ -2907,8 +2907,7 @@ class TernaryCubic(AlgebraicForm):
         A01 = x*a21 + y*a12 + 1/F(2)*z*a11
         A02 = x*a20 + 1/F(2)*y*a11 + z*a10
         A12 = 1/F(2)*x*a11 + y*a02 + z*a01
-        polar = matrix(self._ring, [[A00, A01, A02],[A01, A11, A12],[A02, A12, A22]])
-        return polar
+        return matrix(self._ring, [[A00, A01, A02], [A01, A11, A12], [A02, A12, A22]])
 
     @cached_method
     def Hessian(self):
@@ -2943,7 +2942,9 @@ class TernaryCubic(AlgebraicForm):
         Uyy = 2*x*a12 + 6*y*a03 + 2*z*a02
         Uyz = x*a11 + 2*y*a02 + 2*z*a01
         Uzz = 2*x*a10 + 2*y*a01 + 6*z*a00
-        H = matrix(self._ring, [[Uxx, Uxy, Uxz],[Uxy, Uyy, Uyz],[Uxz, Uyz, Uzz]])
+        H = matrix(self._ring, [[Uxx, Uxy, Uxz],
+                                [Uxy, Uyy, Uyz],
+                                [Uxz, Uyz, Uzz]])
         F = self._ring.base_ring()
         return 1/F(216) * H.det()
 
@@ -2971,11 +2972,11 @@ class TernaryCubic(AlgebraicForm):
             6952
         """
         U_conic = self.polar_conic().adjugate()
-        U_coeffs = ( U_conic[0,0], U_conic[1,1], U_conic[2,2],
-                     U_conic[0,1], U_conic[0,2], U_conic[1,2] )
+        U_coeffs = (U_conic[0, 0], U_conic[1, 1], U_conic[2, 2],
+                    U_conic[0, 1], U_conic[0, 2], U_conic[1, 2])
         H_conic = TernaryCubic(3, 3, self.Hessian(), self.variables()).polar_conic().adjugate()
-        H_coeffs = ( H_conic[0,0], H_conic[1,1], H_conic[2,2],
-                     H_conic[0,1], H_conic[0,2], H_conic[1,2] )
+        H_coeffs = (H_conic[0, 0], H_conic[1, 1], H_conic[2, 2],
+                    H_conic[0, 1], H_conic[0, 2], H_conic[1, 2])
         quadratic = TernaryQuadratic(3, 2, self._ring.zero(), self.variables())
         F = self._ring.base_ring()
         return 1/F(9) * _covariant_conic(U_coeffs, H_coeffs, quadratic.monomials())
@@ -3258,7 +3259,7 @@ class SeveralAlgebraicForms(FormsBase):
             g = random_matrix(F, self._n, algorithm='unimodular')
         v = vector(self.variables())
         g_v = g*v
-        transform = dict( (v[i], g_v[i]) for i in range(self._n) )
+        transform = {v[i]: g_v[i] for i in range(self._n)}
         # The covariant of the transformed form
         transformed = [f.transformed(transform) for f in self._forms]
         g_self = self.__class__(transformed)
@@ -4358,9 +4359,9 @@ class InvariantTheoryFactory:
             from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
             K = FractionField(Sequence(list(invariants)).universe())
             if variables is None:
-                x,z = PolynomialRing(K, 'x,z').gens()
+                x, z = PolynomialRing(K, 'x,z').gens()
             elif len(variables) == 2:
-                x,z = variables
+                x, z = variables
             else:
                 raise ValueError('incorrect number of variables provided, '
                                  'exactly two variables should be provided')

sage/rings/invariants/reconstruction.py

@@ -187,7 +187,7 @@ def binary_quintic_coefficients_from_invariants(invariants, K=None, invariant_ch
     If the invariant `M` vanishes, then the coefficients are computed in a
     different way::
 
-        sage: [A,B,C] = [3,1,2]
+        sage: A, B, C = 3, 1, 2
         sage: M = 2*A*B - 3*C
         sage: M
         0
@@ -266,7 +266,7 @@ def binary_quintic_coefficients_from_invariants(invariants, K=None, invariant_ch
     M = 2*A*B - 3*C
     N = K(2)**-1 * (A*C-B**2)
     R2 = -K(2)**-1 * (A*N**2-2*B*M*N+C*M**2)
-    scale = [1,1,1,1,1,1]
+    scale = [1, 1, 1, 1, 1, 1]
     from sage.arith.misc import binomial
     from sage.misc.functional import sqrt
     if len(invariants) == 3:
@@ -275,8 +275,8 @@ def binary_quintic_coefficients_from_invariants(invariants, K=None, invariant_ch
         else:
             # if R2 is not a square, we scale the invariants in a suitable way
             # so that the 'new' R2 is a square
-            [A, B, C] = [R2*A, R2**2*B, R2**3*C]
-            [M, N] = [R2**3*M, R2**4*N]
+            A, B, C = R2 * A, R2**2 * B, R2**3 * C
+            M, N = R2**3 * M, R2**4 * N
             R = R2**5
     elif len(invariants) == 4:
         if invariants[3]**2 != R2:
@@ -293,17 +293,17 @@ def binary_quintic_coefficients_from_invariants(invariants, K=None, invariant_ch
                                  'quintics with a treefold linear factor')
             else:
                 if B == 0:
-                    return (1,0,0,0,0,1)
+                    return (1, 0, 0, 0, 0, 1)
                 else:
-                    return (0,1,0,0,1,0)
+                    return (0, 1, 0, 0, 1, 0)
         else:
             # case corresponding to using alpha and gamma as coordinates
             if A == 0:
-                return (1,0,0,0,1,0)
+                return (1, 0, 0, 0, 1, 0)
             else:
                 if scaling == 'normalized':
                     # scaling z by (R/A**3)
-                    scale = [ (-N)**-5*A**6*(R/A**3)**i for i in range(6) ]
+                    scale = [(-N)**-5*A**6*(R/A**3)**i for i in range(6)]
                 D = -N
                 Delta = C
                 a = [0]

sage/rings/polynomial/ore_function_element.py

@@ -930,7 +930,7 @@ class OreFunction_with_large_center(OreFunction):
             (x^6 + 4)^(-1) * (x^3 + 2)
 
         By default, the name of the central variable is usually ``z`` (see
-        :meth:`sage.rings.polynomial.skew_polynomial_ring.SkewPolynomiaRing_finite_order.center`
+        :meth:`sage.rings.polynomial.skew_polynomial_ring.SkewPolynomialRing_finite_order.center`
         for more details about this).
         However, the user can specify a different variable name if desired::
 

sage/rings/polynomial/ore_polynomial_element.pyx

@@ -907,7 +907,7 @@ cdef class OrePolynomial(AlgebraElement):
             raise TypeError("the base ring must be a field")
         cdef OrePolynomial G = self
         cdef OrePolynomial U = self._parent.one()
-        cdef OrePolynomial V, V1, V2, Q, R, T
+        cdef OrePolynomial V, V1, Q, R, T
         cdef Morphism m
         if not other:
             V = self._parent.zero()
@@ -2569,7 +2569,7 @@ cdef class OrePolynomial_generic_dense(OrePolynomial):
             sage: a + a == 2*a
             True
         """
-        cdef Py_ssize_t i, min
+        cdef Py_ssize_t i
         cdef list x = (<OrePolynomial_generic_dense>self)._coeffs
         cdef list y = (<OrePolynomial_generic_dense>right)._coeffs
         cdef Py_ssize_t dx = len(x), dy = len(y)
@@ -2600,7 +2600,7 @@ cdef class OrePolynomial_generic_dense(OrePolynomial):
             sage: c - c == 0
             True
         """
-        cdef Py_ssize_t i, min
+        cdef Py_ssize_t i
         cdef list x = (<OrePolynomial_generic_dense>self)._coeffs
         cdef list y = (<OrePolynomial_generic_dense>right)._coeffs
         cdef Py_ssize_t dx = len(x), dy = len(y)
@@ -2868,7 +2868,6 @@ cdef class OrePolynomial_generic_dense(OrePolynomial):
             sage: a.coefficients(sparse=False)
             [t^2 + 1, 0, t + 1, 0, 1]
         """
-        zero = self.parent().base_ring().zero()
         if sparse:
             return [c for c in self._coeffs if not c.is_zero()]
         else:
@@ -2876,8 +2875,9 @@ cdef class OrePolynomial_generic_dense(OrePolynomial):
 
     def hilbert_shift(self, s, var=None):
         r"""
-        Return this Ore polynomial with variable shifted by `s`,
-        i.e. if this Ore polynomial is `P(x)`, return `P(x+s)`.
+        Return this Ore polynomial with variable shifted by `s`.
+
+        If this Ore polynomial is `P(x)`, this returns `P(x+s)`.
 
         INPUT:
 
@@ -2952,9 +2952,9 @@ cdef class OrePolynomial_generic_dense(OrePolynomial):
         if var is None:
             var = parent.variable_name()
         if derivation is None:
-            S = OrePolynomialRing(k, morphism, var)
+            S = OrePolynomialRing(k, morphism, var, polcast=False)
         else:
-            S = OrePolynomialRing(k, derivation, var)
+            S = OrePolynomialRing(k, derivation, var, polcast=False)
         if not self:
             return S.zero()
         X = S.gen() + s