passagemath-modules 10.5.46__cp310-cp310-macosx_14_0_arm64.whl → 10.6.20__cp310-cp310-macosx_14_0_arm64.whl

sage/modules/quotient_module.py

@@ -535,11 +535,21 @@ class FreeModule_ambient_field_quotient(FreeModule_ambient_field):
 
             sage: Q((ZZ^3)([1,2,3]))
             (2, 3)
+
+        TESTS:
+
+        Ensure that :issue:`39507` is fixed::
+
+            sage: V = VectorSpace(GF(2),3)
+            sage: A = V.subspace([(0,1,0), (1,1,1)])
+            sage: B = A.subspace([])
+            sage: list(A/B)
+            [(0, 0), (1, 0), (0, 1), (1, 1)]
         """
         if isinstance(x, self.element_class) and x.parent() is self:
             return x
         if isinstance(x, (list, tuple)) and len(x) == self._domain.rank():
-            return self.__quo_map(self._domain(x))
+            return self.__quo_map(self._domain.linear_combination_of_basis(x))
         return FreeModule_ambient_field._element_constructor_(self, x)
 
     def _coerce_map_from_(self, M):

sage/modules/submodule.py

@@ -104,7 +104,7 @@ class Submodule_free_ambient(Module_free_ambient):
             sage: R.<x,y> = QQ[]
             sage: S = R.quotient([x*y])
             sage: M = FreeModule(S, 2)
-            sage: M.zero_submodule()
+            sage: M.zero_submodule()                                                    # needs sage.libs.singular
             Submodule of Ambient free module of rank 2 over Quotient of Multivariate Polynomial Ring in x, y
              over Rational Field by the ideal (x*y)
               Generated by the rows of the matrix:

sage/modules/torsion_quadratic_module.py

@@ -742,7 +742,7 @@ class TorsionQuadraticModule(FGP_Module_class, CachedRepresentation):
                         return genus
         raise ValueError("this discriminant form and signature do not define a genus")
 
-    def is_genus(self, signature_pair, even=True):
+    def is_genus(self, signature_pair, even=True) -> bool:
         r"""
         Return ``True`` if there is a lattice with this signature and discriminant form.
 

sage/modules/vector_integer_sparse.pyx

@@ -67,11 +67,11 @@ cdef Py_ssize_t mpz_binary_search0(mpz_t* v, Py_ssize_t n, mpz_t x) noexcept:
     j = n-1
     while i<=j:
         if i == j:
-            if mpz_cmp(v[i],x) == 0:
+            if mpz_cmp(v[i], x) == 0:
                 return i
             return -1
         k = (i+j)/2
-        c = mpz_cmp(v[k],x)
+        c = mpz_cmp(v[k], x)
         if c > 0:       # v[k] > x
             j = k-1
         elif c < 0:     # v[k] < x
@@ -104,9 +104,9 @@ cdef Py_ssize_t mpz_binary_search(mpz_t* v, Py_ssize_t n, mpz_t x, Py_ssize_t* i
         return -1
     i = 0
     j = n-1
-    while i<=j:
+    while i <= j:
         if i == j:
-            c = mpz_cmp(v[i],x)
+            c = mpz_cmp(v[i], x)
             if c == 0:          # v[i] == x
                 ins[0] = i
                 return i

sage/modules/vector_rational_dense.pyx

@@ -309,7 +309,7 @@ cdef class Vector_rational_dense(free_module_element.FreeModuleElement):
         r = right
         z = self._new_c()
         cdef Py_ssize_t i
-        for i  in range(self._degree):
+        for i in range(self._degree):
             mpq_mul(z._entries[i], self._entries[i], r._entries[i])
         return z
 

sage/modules/vector_rational_sparse.pyx

@@ -74,11 +74,11 @@ cdef Py_ssize_t mpq_binary_search0(mpq_t* v, Py_ssize_t n, mpq_t x) noexcept:
     j = n-1
     while i<=j:
         if i == j:
-            if mpq_equal(v[i],x):
+            if mpq_equal(v[i], x):
                 return i
             return -1
         k = (i+j)/2
-        c = mpq_cmp(v[k],x)
+        c = mpq_cmp(v[k], x)
         if c > 0:       # v[k] > x
             j = k-1
         elif c < 0:     # v[k] < x
@@ -113,7 +113,7 @@ cdef Py_ssize_t mpq_binary_search(mpq_t* v, Py_ssize_t n, mpq_t x, Py_ssize_t* i
     j = n-1
     while i<=j:
         if i == j:
-            c = mpq_cmp(v[i],x)
+            c = mpq_cmp(v[i], x)
             if c == 0:          # v[i] == x
                 ins[0] = i
                 return i
@@ -148,7 +148,7 @@ cdef int mpq_vector_get_entry(mpq_t ans, mpq_vector* v, Py_ssize_t n) except -1:
     cdef Py_ssize_t m
     m = binary_search0(v.positions, v.num_nonzero, n)
     if m == -1:
-        mpq_set_si(ans, 0,1)
+        mpq_set_si(ans, 0, 1)
         return 0
     mpq_set(ans, v.entries[m])
     return 0
@@ -280,7 +280,7 @@ cdef int add_mpq_vector_init(mpq_vector* sum,
 
     mpq_init(tmp)
     # Do not do the multiply if the multiple is 1.
-    do_multiply = mpq_cmp_si(multiple, 1,1)
+    do_multiply = mpq_cmp_si(multiple, 1, 1)
 
     z = sum
     # ALGORITHM:

sage/modules/vector_space_morphism.py

@@ -891,9 +891,9 @@ class VectorSpaceMorphism(free_module_morphism.FreeModuleMorphism):
         A = homspace._matrix_space(side)(A)
         free_module_morphism.FreeModuleMorphism.__init__(self, homspace, A, side)
 
-    def is_invertible(self):
+    def is_invertible(self) -> bool:
         r"""
-        Determines if the vector space morphism has an inverse.
+        Determine if the vector space morphism has an inverse.
 
         OUTPUT:
 

sage/modules/with_basis/cell_module.py

@@ -172,6 +172,15 @@ class CellModule(CombinatorialFreeModule):
             sage: matrix([[W._bilinear_form_on_basis(s, t) for t in K] for s in K])
             [1 0]
             [0 1]
+
+        TESTS::
+
+            sage: C5.<z5> = CyclotomicField(5)
+            sage: TL = TemperleyLiebAlgebra(2, z5 + ~z5, C5)
+            sage: m = TL.cell_module(0)
+            sage: c = m.basis().keys()[0]
+            sage: m._bilinear_form_on_basis(c, c)
+            -z5^3 - z5^2 - 1
         """
         B = self._algebra.basis()
         elt = B[(self._la, s, s)] * B[(self._la, t, t)]
@@ -243,6 +252,14 @@ class CellModule(CombinatorialFreeModule):
             sage: W = S.cell_module([2,1])
             sage: W.nonzero_bilinear_form()
             True
+
+        TESTS::
+
+            sage: C5.<z5> = CyclotomicField(5)
+            sage: TL = TemperleyLiebAlgebra(2, z5 + ~z5, C5)
+            sage: m = TL.cell_module(0)
+            sage: m.nonzero_bilinear_form()
+            True
         """
         C = list(self.basis().keys())
         # Since the bilinear form is symmetric, it is sufficient

sage/modules/with_basis/indexed_element.pyx

@@ -863,7 +863,7 @@ cdef class IndexedFreeModuleElement(ModuleElement):
         zero = free_module.base_ring().zero()
         if sparse:
             if order is None:
-                order = {k: i for i,k in enumerate(self._parent.get_order())}
+                order = {k: i for i, k in enumerate(self._parent.get_order())}
             return free_module.element_class(free_module,
                                              {order[k]: c for k, c in d.items()},
                                              coerce=True, copy=False)

sage/modules/with_basis/invariant.py

@@ -998,7 +998,7 @@ class FiniteDimensionalTwistedInvariantModule(SubmoduleWithBasis):
         but you still may pass elements of ``M``, which is an instance of
         :class:`~sage.combinat.free_module.CombinatorialFreeModule`,
         because the underlying ``Representation`` is built off of ``M``
-        and we can cannonically construct elements of the ``Representation``
+        and we can canonically construct elements of the ``Representation``
         from elements of ``M``.
 
         ::

sage/modules/with_basis/representation.py

@@ -2879,7 +2879,6 @@ class SchurFunctorRepresentation(Subrepresentation):
         from sage.combinat.symmetric_group_algebra import SymmetricGroupAlgebra
         from sage.groups.perm_gps.permgroup_named import SymmetricGroup
         from sage.categories.tensor import tensor
-        from sage.matrix.matrix_space import MatrixSpace
 
         R = V.base_ring()
         self._shape = shape

sage/modules/with_basis/subquotient.py

@@ -357,7 +357,7 @@ class SubmoduleWithBasis(CombinatorialFreeModule):
         """
         return self.lift.section()
 
-    def is_submodule(self, other):
+    def is_submodule(self, other) -> bool:
         r"""
         Return whether ``self`` is a submodule of ``other``.
 
@@ -485,7 +485,7 @@ class SubmoduleWithBasis(CombinatorialFreeModule):
         V = A.submodule([A([vec[supp] for supp in supp_order]) for vec in other._basis], check=False)
         return (U, V)
 
-    def is_equal_subspace(self, other):
+    def is_equal_subspace(self, other) -> bool:
         r"""
         Return whether ``self`` is an equal submodule to ``other``.
 

sage/quadratic_forms/binary_qf.py

@@ -1223,7 +1223,7 @@ class BinaryQF(SageObject):
             self._cycle_list = C
         return self._cycle_list
 
-    def is_positive_definite(self):
+    def is_positive_definite(self) -> bool:
         """
         Return ``True`` if ``self`` is positive definite, i.e., has
         negative discriminant with `a > 0`.
@@ -1241,7 +1241,7 @@ class BinaryQF(SageObject):
 
     is_posdef = is_positive_definite
 
-    def is_negative_definite(self):
+    def is_negative_definite(self) -> bool:
         """
         Return ``True`` if ``self`` is negative definite, i.e., has
         negative discriminant with `a < 0`.
@@ -1258,7 +1258,7 @@ class BinaryQF(SageObject):
 
     is_negdef = is_negative_definite
 
-    def is_indefinite(self):
+    def is_indefinite(self) -> bool:
         """
         Return whether ``self`` is indefinite, i.e., has positive discriminant.
 
@@ -1272,7 +1272,7 @@ class BinaryQF(SageObject):
 
     is_indef = is_indefinite
 
-    def is_singular(self):
+    def is_singular(self) -> bool:
         """
         Return whether ``self`` is singular, i.e., has zero discriminant.
 
@@ -1287,7 +1287,7 @@ class BinaryQF(SageObject):
         """
         return self.discriminant().is_zero()
 
-    def is_nonsingular(self):
+    def is_nonsingular(self) -> bool:
         """
         Return whether this form is nonsingular, i.e., has nonzero discriminant.
 
@@ -1302,7 +1302,7 @@ class BinaryQF(SageObject):
         """
         return not self.discriminant().is_zero()
 
-    def is_equivalent(self, other, proper=True):
+    def is_equivalent(self, other, proper=True) -> bool:
         """
         Return whether ``self`` is equivalent to ``other``.
 
@@ -1432,7 +1432,7 @@ class BinaryQF(SageObject):
         return False
 
     @cached_method
-    def is_reduced(self):
+    def is_reduced(self) -> bool:
         r"""
         Return whether ``self`` is reduced.
 

sage/quadratic_forms/bqf_class_group.py

@@ -574,7 +574,7 @@ class BQFClassGroup_element(AdditiveGroupElement):
         """
         return self._form < other._form
 
-    def __bool__(self):
+    def __bool__(self) -> bool:
         r"""
         Return ``True`` if this form class is *not* the principal class
         and ``False`` otherwise.
@@ -589,7 +589,7 @@ class BQFClassGroup_element(AdditiveGroupElement):
         """
         return self != self.parent().zero()
 
-    def is_zero(self):
+    def is_zero(self) -> bool:
         r"""
         Return ``True`` if this form class is the principal class and
         ``False`` otherwise.
@@ -604,7 +604,7 @@ class BQFClassGroup_element(AdditiveGroupElement):
         """
         return not self
 
-    def __repr__(self):
+    def __repr__(self) -> str:
         r"""
         Return a string representation of this form class.
 
@@ -651,89 +651,18 @@ class BQFClassGroup_element(AdditiveGroupElement):
         return order_from_multiple(self, self.parent().cardinality())
 
 
-def _project_bqf(bqf, q):
-    r"""
-    Internal helper function to compute the image of a
-    :class:`BQFClassGroup_element` of discriminant `D`
-    in the form class group of discriminant `D/q^2`.
-
-    ALGORITHM: Find a class representative with `q^2 \mid a`
-    (and `q \mid b`) and substitute `x\mapsto x/q`.
-
-    EXAMPLES::
-
-        sage: from sage.quadratic_forms.bqf_class_group import _project_bqf
-        sage: f1 = BinaryQF([4, 2, 105])
-        sage: f2 = _project_bqf(f1, 2); f2
-        x^2 + x*y + 105*y^2
-        sage: f1.discriminant().factor()
-        -1 * 2^2 * 419
-        sage: f2.discriminant().factor()
-        -1 * 419
-
-    ::
-
-        sage: f1 = BinaryQF([109, 92, 113])
-        sage: f2 = _project_bqf(f1, 101); f2
-        53*x^2 - 152*x*y + 109*y^2
-        sage: f1.discriminant().factor()
-        -1 * 2^2 * 101^2
-        sage: f2.discriminant().factor()
-        -1 * 2^2
-    """
-    q2 = q**2
-    disc = bqf.discriminant()
-    if not q2.divides(disc) or disc//q2 % 4 not in (0, 1):
-        raise ValueError('discriminant not divisible by q^2')
-
-    a, b, c = bqf
-
-    # lucky case: q^2|c (and q|b)
-    if q2.divides(c):
-        a, b, c = c, -b, a
-
-    # general case: neither q^2|a nor q^2|c
-    elif not q2.divides(a):
-
-        # represent some multiple of q^2
-        R = Zmod(q2)
-        x = polygen(R)
-        for v in R:
-            eq = a*x**2 + b*x*v + c*v**2
-            try:
-                u = eq.any_root()
-            except (ValueError, IndexError):  # why IndexError? see #37034
-                continue
-            if u or v:
-                break
-        else:
-            assert False
-
-        # find equivalent form with q^2|a (and q|b)
-        u, v = map(ZZ, (u, v))
-        assert q2.divides(bqf(u, v))
-        if not v:
-            v += q
-        g, r, s = u.xgcd(v)
-        assert g.is_one()
-        M = matrix(ZZ, [[u, -v], [s, r]])
-        assert M.det().is_one()
-        a, b, c = bqf * M
-
-    # remaining case: q^2|a (and q|b)
-    assert q2.divides(a)
-    assert q.divides(b)
-    return BinaryQF(a//q2, b//q, c)
-
-
 class BQFClassGroupQuotientMorphism(Morphism):
     r"""
     Let `D` be a discriminant and `f > 0` an integer.
 
     Given the class groups `G` and `H` of discriminants `f^2 D` and `D`,
     this class represents the natural projection morphism `G \to H` which
-    is defined by finding a class representative `[a,b,c]` satisfying
-    `f^2 \mid a` and `f \mid b` and substituting `x \mapsto x/f`.
+    is defined by composing the class representative `[a,b,c]` with the
+    principal form of the target discriminant.
+
+    Alternatively, evaluating this map can be characterized as finding a
+    class representative `[a,b,c]` satisfying `f^2 \mid a` and `f \mid b`
+    and substituting `x \mapsto x/f`.
 
     This map is a well-defined group homomorphism.
 
@@ -763,6 +692,17 @@ class BQFClassGroupQuotientMorphism(Morphism):
         sage: elt2 = G.random_element()
         sage: proj(elt1 + elt2) == proj(elt1) + proj(elt2)
         True
+
+    Check that it satisfies compatibility::
+
+        sage: ff = f * randrange(1, 10^3)
+        sage: F = BQFClassGroup(ff^2*D)
+        sage: proj = F.hom(H)
+        sage: proj1 = F.hom(G)
+        sage: proj2 = G.hom(H)
+        sage: elt = F.random_element()
+        sage: proj(elt) == proj2(proj1(elt))
+        True
     """
     def __init__(self, G, H):
         r"""
@@ -781,9 +721,8 @@ class BQFClassGroupQuotientMorphism(Morphism):
             raise TypeError('G needs to be a BQFClassGroup')
         if not isinstance(H, BQFClassGroup):
             raise TypeError('H needs to be a BQFClassGroup')
-        try:
-            self.f = ZZ((G.discriminant() / H.discriminant()).sqrt(extend=False)).factor()
-        except ValueError:
+        f2 = ZZ(G.discriminant() / H.discriminant())
+        if not f2.is_square():
             raise ValueError('morphism only defined when disc(G) = f^2 * disc(H)')
         super().__init__(G, H)
 
@@ -793,22 +732,17 @@ class BQFClassGroupQuotientMorphism(Morphism):
 
         EXAMPLES::
 
-            sage: from sage.quadratic_forms.bqf_class_group import BQFClassGroupQuotientMorphism, _project_bqf
+            sage: from sage.quadratic_forms.bqf_class_group import BQFClassGroupQuotientMorphism
             sage: G = BQFClassGroup(-4*117117)
             sage: H = BQFClassGroup(-4*77)
             sage: proj = BQFClassGroupQuotientMorphism(G, H)
             sage: elt = G(BinaryQF(333, 306, 422))
             sage: proj(elt)
             Class of 9*x^2 + 4*x*y + 9*y^2
-            sage: proj(elt) == H(_project_bqf(_project_bqf(elt.form(), 3), 13))
-            True
-            sage: proj(elt) == H(_project_bqf(_project_bqf(elt.form(), 13), 3))
-            True
 
-        ALGORITHM: Repeated application of :func:`_project_bqf` for the prime factors in `f`.
+        ALGORITHM: [Buell89]_, Theorem 7.9
         """
+        one = BinaryQF.principal(self.codomain().discriminant())
         bqf = elt.form()
-        for q, m in self.f:
-            for _ in range(m):
-                bqf = _project_bqf(bqf, q)
+        bqf *= one
         return self.codomain()(bqf)

sage/quadratic_forms/extras.py

@@ -9,7 +9,7 @@ from sage.arith.misc import legendre_symbol
 from sage.rings.integer_ring import ZZ
 
 
-def is_triangular_number(n, return_value=False):
+def is_triangular_number(n, return_value=False) -> bool | tuple:
     """
     Return whether ``n`` is a triangular number.
 

sage/quadratic_forms/quadratic_form.py

@@ -84,7 +84,7 @@ def quadratic_form_from_invariants(F, rk, det, P, sminus):
 
     OUTPUT: a quadratic form with the specified invariants
 
-    Let `(a_1, \ldots, a_n)` be the gram marix of a regular quadratic space.
+    Let `(a_1, \ldots, a_n)` be the Gram matrix of a regular quadratic space.
     Then Cassel's Hasse invariant is defined as
 
     .. MATH::
@@ -1216,7 +1216,7 @@ class QuadraticForm(SageObject):
             sage: A.base_ring()
             Integer Ring
         """
-        A = (ZZ(1) / ZZ(2)) * self.matrix()
+        A = (ZZ.one() / ZZ(2)) * self.matrix()
         n = self.dim()
 
         # Test to see if it has an integral Gram matrix
@@ -1230,11 +1230,12 @@ class QuadraticForm(SageObject):
             return MatrixSpace(self.base_ring(), n, n)(A)
         raise TypeError("this form does not have an integral Gram matrix")
 
-    def has_integral_Gram_matrix(self):
+    def has_integral_Gram_matrix(self) -> bool:
         r"""
         Return whether the quadratic form has an integral Gram matrix (with respect to its base ring).
 
-        A warning is issued if the form is defined over a field, since in that case the return is trivially true.
+        A warning is issued if the form is defined over a field,
+        since in that case the return is trivially true.
 
         EXAMPLES::
 

sage/quadratic_forms/quadratic_form__equivalence_testing.py

@@ -6,6 +6,8 @@ AUTHORS:
 
 - Anna Haensch (2014-12-01): added test for rational isometry
 """
+from typing import Any
+
 from sage.arith.misc import (hilbert_symbol,
                              GCD,
                              is_prime,
@@ -21,7 +23,7 @@ from sage.rings.rational_field import QQ
 # (For now, we require both forms to be positive definite.)                  #
 ##############################################################################
 
-def is_globally_equivalent_to(self, other, return_matrix=False):
+def is_globally_equivalent_to(self, other, return_matrix=False) -> bool | Any:
     r"""
     Determine if the current quadratic form is equivalent to the
     given form over `\ZZ`.
@@ -115,7 +117,8 @@ def is_globally_equivalent_to(self, other, return_matrix=False):
         return True
 
 
-def is_locally_equivalent_to(self, other, check_primes_only=False, force_jordan_equivalence_test=False):
+def is_locally_equivalent_to(self, other, check_primes_only=False,
+                             force_jordan_equivalence_test=False) -> bool:
     r"""
     Determine if the current quadratic form (defined over `\ZZ`) is
     locally equivalent to the given form over the real numbers and the
@@ -173,7 +176,7 @@ def is_locally_equivalent_to(self, other, check_primes_only=False, force_jordan_
     return True
 
 
-def has_equivalent_Jordan_decomposition_at_prime(self, other, p):
+def has_equivalent_Jordan_decomposition_at_prime(self, other, p) -> bool:
     """
     Determine if the given quadratic form has a Jordan decomposition
     equivalent to that of ``self``.
@@ -299,7 +302,7 @@ def has_equivalent_Jordan_decomposition_at_prime(self, other, p):
         raise TypeError("this should not have happened")
 
 
-def is_rationally_isometric(self, other, return_matrix=False):
+def is_rationally_isometric(self, other, return_matrix=False) -> bool | Any:
     """
     Determine if two regular quadratic forms over a number field are isometric.
 

sage/quadratic_forms/quadratic_form__local_field_invariants.py

@@ -617,7 +617,7 @@ def is_hyperbolic(self, p) -> bool:
             self.hasse_invariant(p) == 1)
 
 
-def is_anisotropic(self, p):
+def is_anisotropic(self, p) -> bool:
     r"""
     Check if the quadratic form is anisotropic over the `p`-adic numbers `\QQ_p` or `\RR`.
 
@@ -687,7 +687,7 @@ def is_anisotropic(self, p):
     raise NotImplementedError("we have not established a convention for 0-dim'l quadratic forms")
 
 
-def is_isotropic(self, p):
+def is_isotropic(self, p) -> bool:
     r"""
     Check if `Q` is isotropic over the `p`-adic numbers `\QQ_p` or `\RR`.
 
@@ -926,9 +926,9 @@ def compute_definiteness_string_by_determinants(self):
     return "pos_def" if first_coeff > 0 else "neg_def"
 
 
-def is_positive_definite(self):
+def is_positive_definite(self) -> bool:
     """
-    Determines if the given quadratic form is positive-definite.
+    Determine if the given quadratic form is positive-definite.
 
     .. NOTE::
 
@@ -963,9 +963,9 @@ def is_positive_definite(self):
     return (def_str == "pos_def") or (def_str == "zero")
 
 
-def is_negative_definite(self):
+def is_negative_definite(self) -> bool:
     """
-    Determines if the given quadratic form is negative-definite.
+    Determine if the given quadratic form is negative-definite.
 
     .. NOTE::
 
@@ -1000,9 +1000,9 @@ def is_negative_definite(self):
     return (def_str == "neg_def") or (def_str == "zero")
 
 
-def is_indefinite(self):
+def is_indefinite(self) -> bool:
     """
-    Determines if the given quadratic form is indefinite.
+    Determine if the given quadratic form is indefinite.
 
     .. NOTE::
 
@@ -1037,9 +1037,9 @@ def is_indefinite(self):
     return def_str == "indefinite"
 
 
-def is_definite(self):
+def is_definite(self) -> bool:
     """
-    Determines if the given quadratic form is (positive or negative) definite.
+    Determine if the given quadratic form is (positive or negative) definite.
 
     .. NOTE::
 

sage/quadratic_forms/quadratic_form__ternary_Tornaria.py

@@ -90,7 +90,7 @@ def content(self):
 
 
 # in quadratic_form.py
-# def is_primitive(self):
+# def is_primitive(self) -> bool:
 #     """
 #     Checks if the form is a multiple of another form... only over ZZ for now.
 #     """
@@ -111,7 +111,7 @@ def content(self):
 
 def adjoint(self):
     """
-    This gives the adjoint (integral) quadratic form associated to the
+    Return the adjoint (integral) quadratic form associated to the
     given form, essentially defined by taking the adjoint of the matrix.
 
     EXAMPLES::