lino 25.2.2__py3-none-any.whl → 25.3.0__py3-none-any.whl

lino/modlib/printing/actions.py

@@ -1,5 +1,5 @@
 # -*- coding: UTF-8 -*-
-# Copyright 2009-2024 Rumma & Ko Ltd
+# Copyright 2009-2025 Rumma & Ko Ltd
 # License: GNU Affero General Public License v3 (see file COPYING for details)
 
 from lino import logger
@@ -24,10 +24,6 @@ from lino.utils.xml import validate_xml
 
 from .choicelists import BuildMethods
 
-# davlink = settings.SITE.plugins.get('davlink', None)
-# has_davlink = davlink is not None and settings.SITE.use_java
-has_davlink = False
-
 
 class BasePrintAction(Action):
     sort_index = 50
@@ -37,7 +33,7 @@ class BasePrintAction(Action):
     hotkey = Hotkey("p", code="KeyP", ctrl=True)
 
     def __init__(self, build_method=None, label=None, **kwargs):
-        super(BasePrintAction, self).__init__(label, **kwargs)
+        super().__init__(label, **kwargs)
         if build_method is not None:
             self.build_method = build_method
 
@@ -50,7 +46,7 @@ class BasePrintAction(Action):
             return False
         # if actor.__name__ == 'ExcerptsByProject':
         #     logger.info("20140401 attach_to_actor() %r", self)
-        return super(BasePrintAction, self).attach_to_actor(actor, name)
+        return super().attach_to_actor(actor, name)
 
     def get_print_templates(self, bm, elem):
         # print("20190506 BasePrintAction.get_print_templates", elem)
@@ -69,17 +65,19 @@ class BasePrintAction(Action):
         """Return the target filename if a document needs to be built,
         otherwise return ``None``.
         """
-        elem.before_printable_build(bm)
-        # raise Exception("20170519 before_build didn't warn")
-        filename = bm.get_target_name(self, elem)
-        if not filename:
+        # elem.before_printable_build(bm)
+        if not elem.must_build_printable(bm):
             return
-        if os.path.exists(filename):
-            logger.debug("%s %s -> overwrite existing %s.", bm, elem, filename)
-            os.remove(filename)
-        else:
-            # logger.info("20121221 makedirs_if_missing %s",os.path.dirname(filename))
-            rt.makedirs_if_missing(os.path.dirname(filename))
+        # raise Exception("20170519 before_build didn't warn")
+        filename = bm.get_target_file(self, elem).path
+        filename.unlink(missing_ok=True)
+        filename.parent.mkdir(exist_ok=True, parents=True)
+        # if filename.exists():
+        #     logger.debug("%s %s -> overwrite existing %s.", bm, elem, filename)
+        #     os.remove(filename)
+        # else:
+        #     # logger.info("20121221 makedirs_if_missing %s",os.path.dirname(filename))
+        #     rt.makedirs_if_missing(os.path.dirname(filename))
         logger.debug("%s : %s -> %s", bm, elem, filename)
         return filename
 
@@ -94,14 +92,12 @@ class BasePrintAction(Action):
             "If it doesn't, please "
             "ask your system administrator."
         )
-        msg = msg.format(etree.tostring(E.a(leaf, href=url), encoding="unicode"))
+        msg = msg.format(etree.tostring(
+            E.a(leaf, href=url), encoding="unicode"))
         # msg %= dict(doc=leaf, help=etree.tostring(
         #     help_url, encoding="unicode"))
         kw.update(message=msg, alert=True)
-        if has_davlink and bm.use_webdav and ar.request is not None:
-            kw.update(open_webdav_url=ar.request.build_absolute_uri(url))
-        else:
-            kw.update(open_url=url)
+        kw.update(open_url=url)
         ar.success(**kw)
         return
 
@@ -111,9 +107,10 @@ class BasePrintAction(Action):
         if isinstance(bm, str):
             bm = BuildMethods.get_by_value(bm)
         bm.build(ar, self, elem)
-        mf = bm.get_target(self, elem)
-        leaf = mf.parts[-1]
-        self.notify_done(ar, bm, leaf, mf.get_url(ar.request), **kw)
+        mf = bm.get_target_file(self, elem)
+        # leaf = mf.parts[-1]
+        leaf = mf.path.name
+        self.notify_done(ar, bm, leaf, mf.url, **kw)
 
 
 class DirectPrintAction(BasePrintAction):
@@ -137,7 +134,7 @@ class DirectPrintAction(BasePrintAction):
 class WriteXmlAction(DirectPrintAction):
     """Generate an XML file from this database object."""
 
-    combo_group = "writexml"
+    # combo_group = "writexml"
     label = _("XML")
 
     build_method = "xml"
@@ -148,6 +145,7 @@ class WriteXmlAction(DirectPrintAction):
     def validate_result_file(self, bm, xmlfile):
         if self.xsd_file:
             logger.info("Validate %s against %s ...", xmlfile, self.xsd_file)
+            # doc = etree.parse(xmlfile)
             if True:
                 validate_xml(xmlfile, self.xsd_file)
             else:
@@ -174,23 +172,25 @@ class CachedPrintAction(BasePrintAction):
         if len(ar.selected_rows) == 1:
             obj = ar.selected_rows[0]
             bm = obj.get_build_method()
-            mf = bm.get_target(self, obj)
-            leaf = mf.parts[-1]
+            mf = bm.get_target_file(self, obj)
+            # leaf = mf.parts[-1]
+            leaf = mf.path.name
             if obj.build_time is None:
                 obj.build_target(ar)
                 ar.debug("%s has been built.", leaf)
             else:
                 ar.debug("Reused %s from cache.", leaf)
 
-            url = mf.get_url(ar.request)
-            self.notify_done(ar, bm, leaf, url, **kw)
+            # url = mf.get_url(ar.request)
+            self.notify_done(ar, bm, leaf, mf.url, **kw)
             ar.set_response(refresh=True)
             return
 
         def ok(ar2):
             # qs = [ar.actor.get_row_by_pk(pk) for pk in ar.selected_pks]
             mf = self.print_multiple(ar, ar.selected_rows)
-            ar2.success(open_url=mf.get_url(ar.request))
+            ar2.success(open_url=mf.url)
+            # ar2.success(open_url=mf.get_url(ar.request))
             # kw.update(refresh_all=True)
             # return kw
 
@@ -203,13 +203,16 @@ class CachedPrintAction(BasePrintAction):
             # assert isinstance(obj,CachedPrintable)
             if obj.printed_by_id is None:
                 obj.build_target(ar)
-            pdf = obj.get_target_name()
-            assert pdf is not None
-            pdfs.append(pdf)
+            # pdf = obj.get_target_file().name
+            # assert pdf is not None
+            # pdfs.append(pdf)
+            mf = obj.get_target_file()
+            pdfs.append(mf.path)
 
         mf = TmpMediaFile(ar, "pdf")
-        rt.makedirs_if_missing(os.path.dirname(mf.name))
-        merge_pdfs(pdfs, mf.name)
+        # rt.makedirs_if_missing(os.path.dirname(mf.name))
+        rt.makedirs_if_missing(mf.path.parent)
+        merge_pdfs(pdfs, mf.path)
         return mf
 
 
@@ -221,9 +224,9 @@ class EditTemplate(BasePrintAction):
 
     def attach_to_actor(self, actor, name):
         # if not settings.SITE.is_installed('davlink'):
-        if not (settings.SITE.webdav_protocol or has_davlink):
+        if not settings.SITE.webdav_protocol:
             return False
-        return super(EditTemplate, self).attach_to_actor(actor, name)
+        return super().attach_to_actor(actor, name)
 
     def run_from_ui(self, ar, **kw):
         lcd = settings.SITE.confdirs.LOCAL_CONFIG_DIR
@@ -253,7 +256,7 @@ class EditTemplate(BasePrintAction):
         url = settings.SITE.build_media_url(*parts)
         # url = ar.build_webdav_uri(url)
 
-        if not (settings.SITE.webdav_protocol or has_davlink):
+        if not settings.SITE.webdav_protocol:
             msg = "cp %s %s" % (filename, local_file)
             ar.debug(msg)
             raise Warning(
@@ -275,7 +278,8 @@ class EditTemplate(BasePrintAction):
             ar.debug("Gonna copy %s to %s", filename, local_file)
 
             def ok(ar2):
-                logger.info("%s made local template copy %s", ar.user, local_file)
+                logger.info("%s made local template copy %s",
+                            ar.user, local_file)
                 rt.makedirs_if_missing(os.path.dirname(local_file))
                 shutil.copyfile(filename, local_file)
                 # shutil.copy() can cause PermissionError if dst exists and is
@@ -305,14 +309,15 @@ class ClearCacheAction(Action):
         # should be visible in the UI
         if obj is not None and not obj.build_time:
             return False
-        return super(ClearCacheAction, self).get_action_permission(ar, obj, state)
+        return super().get_action_permission(ar, obj, state)
 
     def run_from_ui(self, ar):
         elem = ar.selected_rows[0]
 
         def doit(ar):
             elem.clear_cache()
-            ar.success(_("%s printable cache has been cleared.") % elem, refresh=True)
+            ar.success(_("%s printable cache has been cleared.") %
+                       elem, refresh=True)
 
         t = elem.get_cache_mtime()
         if t is not None:

lino/modlib/printing/choicelists.py

@@ -1,16 +1,15 @@
 # -*- coding: UTF-8 -*-
-# Copyright 2009-2023 Rumma & Ko Ltd
+# Copyright 2009-2025 Rumma & Ko Ltd
 # License: GNU Affero General Public License v3 (see file COPYING for details)
 """
 Choicelists for `lino.modlib.printing`.
 
 """
 
-from lino import logger
-
 import os
 import io
 from copy import copy
+from pathlib import Path
 
 from django.conf import settings
 from django.utils import translation
@@ -25,6 +24,7 @@ from django.template.loader import select_template
 from lino.core.choicelists import ChoiceList, Choice
 from lino.utils.media import MediaFile
 from lino.api import rt, _
+from lino import logger
 
 try:
     import pyratemp
@@ -42,25 +42,23 @@ class BuildMethod(Choice):
         # same.
         if names is None:
             names = self.name
-        super(BuildMethod, self).__init__(
-            names, self.__class__.__name__, names, **kwargs
-        )
+        super().__init__(names, self.__class__.__name__, names, **kwargs)
 
-    def get_target(self, action, obj):
+    def get_target_file(self, action, obj):
         # Used by get_target_name()
         # assert self.name is not None
         return MediaFile(
             self.use_webdav,
             self.cache_name,
             self.value,
-            obj.filename_root() + self.target_ext,
+            obj.get_printable_target_stem() + self.target_ext,
         )
 
-    def get_target_name(self, action, elem):
-        return self.get_target(action, elem).name
+    # def get_target_name(self, action, elem):
+    #     return self.get_target_file(action, elem).name
 
     def get_target_url(self, action, elem):
-        return self.get_target(action, elem).url
+        return self.get_target_file(action, elem).url
 
     def build(self, ar, action, elem):
         raise NotImplementedError
@@ -72,7 +70,7 @@ class TemplatedBuildMethod(BuildMethod):
     default_template = ""  # overridden by lino_xl.lib.appypod
 
     def __init__(self, *args, **kwargs):
-        super(TemplatedBuildMethod, self).__init__(*args, **kwargs)
+        super().__init__(*args, **kwargs)
         if self.templates_name is None:
             assert len(self.names) == 1
             self.templates_name = self.names[0]
@@ -110,7 +108,8 @@ class DjangoBuildMethod(TemplatedBuildMethod):
         except TemplateDoesNotExist as e:
             raise Warning("No template found for %s (%s)" % (e, tpls2))
         except Exception as e:
-            raise Exception("Error while loading template for %s : %s" % (tpls2, e))
+            raise Exception(
+                "Error while loading template for %s : %s" % (tpls2, e))
 
     # ,MEDIA_URL=settings.MEDIA_URL):
     def render_template(self, elem, tpl, **context):
@@ -172,7 +171,8 @@ class SimpleBuildMethod(TemplatedBuildMethod):
 
         lang = elem.get_print_language() or translation.get_language()
         if lang != settings.SITE.DEFAULT_LANGUAGE.django_code:
-            name = tpl_leaf[: -len(self.template_ext)] + "_" + lang + self.template_ext
+            name = tpl_leaf[: -len(self.template_ext)] + \
+                                   "_" + lang + self.template_ext
             if rt.find_config_file(name, *elem.get_template_groups()):
                 return name
         return tpl_leaf
@@ -234,6 +234,7 @@ class XmlBuildMethod(DjangoBuildMethod):
         filename = action.before_build(self, elem)
         if filename is None:
             return
+        filename = Path(filename)
         tpl = self.get_template(action, elem)
 
         lang = str(elem.get_print_language() or translation.get_language())
@@ -288,7 +289,8 @@ class BuildMethods(ChoiceList):
             if bm is None:
                 raise Exception(
                     "Invalid default_build_method '{}', choices are {}".format(
-                        settings.SITE.default_build_method, tuple(cls.get_list_items())
+                        settings.SITE.default_build_method, tuple(
+                            cls.get_list_items())
                     )
                 )
             return bm

lino/modlib/printing/mixins.py

@@ -1,5 +1,5 @@
 # -*- coding: UTF-8 -*-
-# Copyright 2009-2024 Rumma & Ko Ltd
+# Copyright 2009-2025 Rumma & Ko Ltd
 # License: GNU Affero General Public License v3 (see file COPYING for details)
 
 import os
@@ -137,14 +137,15 @@ class Printable(Model):
             kw = ar.get_printable_context(**kw)
         kw.update(this=self)  # for backward compatibility
         kw.update(obj=self)  # preferred in new templates
-        kw.update(language=self.get_print_language() or translation.get_language())
+        kw.update(language=self.get_print_language()
+                  or translation.get_language())
         # settings.SITE.DEFAULT_LANGUAGE.django_code)
         kw.update(site=settings.SITE)
         kw.update(weekdays=weekdays)
         return kw
 
-    def before_printable_build(self, bm):
-        pass
+    def must_build_printable(self, bm):
+        return True
 
 
 class CachedPrintable(Duplicable, Printable):
@@ -155,23 +156,26 @@ class CachedPrintable(Duplicable, Printable):
     do_clear_cache = ClearCacheAction()
     edit_template = EditTemplate()
 
-    build_time = models.DateTimeField(_("build time"), null=True, editable=False)
-
+    build_time = models.DateTimeField(
+        _("build time"), null=True, editable=False)
     build_method = BuildMethods.field(blank=True, null=True)
 
     def full_clean(self, *args, **kwargs):
         if not self.build_method:
             self.build_method = self.get_default_build_method()
-        super(CachedPrintable, self).full_clean(*args, **kwargs)
+        super().full_clean(*args, **kwargs)
 
     def on_duplicate(self, ar, master):
-        super(CachedPrintable, self).on_duplicate(ar, master)
+        super().on_duplicate(ar, master)
         self.build_time = None
         self.build_method = None
 
-    def get_target_name(self):
-        if self.build_time:
-            return self.get_build_method().get_target_name(self.do_print, self)
+    def must_build_printable(self, bm):
+        return self.build_time is None
+
+    # def get_target_name(self):
+    #     if self.build_time:
+    #         return self.get_build_method().get_target_name(self.do_print, self)
 
     def get_build_method(self):
         return self.build_method or self.get_default_build_method()
@@ -184,14 +188,12 @@ class CachedPrintable(Duplicable, Printable):
         file, or `None` if no such file exists.
 
         """
-        filename = self.get_target_name()
+        filename = self.get_target_file().path
         if not filename:
             return None
-        try:
-            t = os.path.getmtime(filename)
-        except OSError:
+        if not filename.exists():
             return None
-        return datetime.datetime.fromtimestamp(t)
+        return datetime.datetime.fromtimestamp(filename.lstat().st_mtime)
 
     def clear_cache(self):
         self.build_time = None
@@ -223,14 +225,14 @@ class TypedPrintable(CachedPrintable):
     def get_template_groups(self):
         ptype = self.get_printable_type()
         if ptype is None:
-            return super(TypedPrintable, self).get_template_groups()
+            return super().get_template_groups()
         return ptype.get_template_groups()
 
     def get_default_build_method(self):
         ptype = self.get_printable_type()
         if ptype and ptype.build_method:
             return ptype.build_method
-        return super(TypedPrintable, self).get_default_build_method()
+        return super().get_default_build_method()
 
     # def get_build_method(self):
     #     if not self.build_method:
@@ -239,12 +241,12 @@ class TypedPrintable(CachedPrintable):
     # ptype = self.get_printable_type()
     # if ptype and ptype.build_method:
     #     return ptype.build_method
-    # return super(TypedPrintable, self).get_build_method()
+    # return super().get_build_method()
 
     def get_print_templates(self, bm, action):
         ptype = self.get_printable_type()
         if ptype is None:
-            return super(TypedPrintable, self).get_print_templates(bm, action)
+            return super().get_print_templates(bm, action)
 
         if ptype.template:
             return [ptype.template]

lino/modlib/publisher/models.py

@@ -2,6 +2,7 @@
 # Copyright 2012-2024 Rumma & Ko Ltd
 # License: GNU Affero General Public License v3 (see file COPYING for details)
 
+from .ui import *
 from lino.api import rt, dd
 
 from .choicelists import PublishingStates, PageFillers, SpecialPages
@@ -31,6 +32,7 @@ from lino.mixins import Hierarchical, Sequenced, Referrable
 from lino.modlib.office.roles import OfficeUser
 from lino.modlib.publisher.mixins import Publishable, PublishableContent
 from lino.modlib.comments.mixins import Commentable
+from lino.modlib.linod.choicelists import schedule_daily
 from lino.modlib.memo.mixins import Previewable
 from lino.mixins.polymorphic import Polymorphic
 from lino_xl.lib.topics.mixins import Taggable
@@ -50,7 +52,8 @@ class Page(
 
     memo_command = "page"
 
-    ref = models.CharField(_("Reference"), max_length=200, blank=True, null=True)
+    ref = models.CharField(
+        _("Reference"), max_length=200, blank=True, null=True)
 
     title = dd.CharField(_("Title"), max_length=250, blank=True)
     child_node_depth = models.IntegerField(default=1)
@@ -382,7 +385,7 @@ if dd.plugins.memo.use_markup:
 #     language = dd.LanguageField()
 
 
-@dd.schedule_daily()
+@schedule_daily()
 def update_publisher_pages(ar):
     # BaseRequest(parent=ar).run(settings.SITE.site_config.check_all_summaries)
     # rt.login().run(settings.SITE.site_config.check_all_summaries)
@@ -398,6 +401,3 @@ def update_publisher_pages(ar):
         prev = obj
         count += 1
     ar.logger.info("%d pages have been updated.", count)
-
-
-from .ui import *

lino/modlib/summaries/models.py

@@ -5,7 +5,8 @@ from django.conf import settings
 
 # from django.db import models
 from lino.api import dd, rt, _
-from lino.core.requests import BaseRequest
+# from lino.core.requests import BaseRequest
+from lino.modlib.linod.choicelists import schedule_daily
 
 from .mixins import UpdateSummariesByMaster, SlaveSummarized, Summarized
 
@@ -54,7 +55,7 @@ def masters_with_summaries():
     return summary_masters
 
 
-@dd.schedule_daily()
+@schedule_daily()
 def checksummaries(ar):
     # BaseRequest(parent=ar).run(settings.SITE.site_config.check_all_summaries)
     # rt.login().run(settings.SITE.site_config.check_all_summaries)

lino/modlib/system/models.py

@@ -2,6 +2,27 @@
 # Copyright 2009-2023 Rumma & Ko Ltd
 # License: GNU Affero General Public License v3 (see file COPYING for details)
 
+from lino.utils.report import EmptyTable
+from lino.core.signals import testcase_setup
+from django.test.signals import setting_changed
+from .mixins import Lockable
+from .choicelists import (
+    YesNo,
+    Genders,
+    PeriodEvents,
+    DurationUnits,
+    Recurrences,
+    Weekdays,
+    DisplayColors
+)
+from lino.modlib.checkdata.choicelists import Checker
+from lino.modlib.printing.choicelists import BuildMethods
+from lino.core.actors import resolve_action
+from lino.core.roles import SiteStaff
+from lino.core.utils import is_devserver
+from lino.core.utils import full_model_name
+from lino.core import actions
+from lino.api import dd, rt
 from lino.utils.html import E
 from django.conf import settings
 from django.utils.encoding import force_str
@@ -14,27 +35,8 @@ from django.apps import apps
 
 get_models = apps.get_models
 
-from lino.api import dd, rt
-from lino.core import actions
-from lino.core.utils import full_model_name
-from lino.core.utils import is_devserver
-from lino.core.roles import SiteStaff
-from lino.core.actors import resolve_action
-
-from lino.modlib.printing.choicelists import BuildMethods
-from lino.modlib.checkdata.choicelists import Checker
 
 # import them here to have them on rt.models.system:
-from .choicelists import (
-    YesNo,
-    Genders,
-    PeriodEvents,
-    DurationUnits,
-    Recurrences,
-    Weekdays,
-    DisplayColors
-)
-from .mixins import Lockable
 
 
 class BuildSiteCache(dd.Action):
@@ -89,7 +91,8 @@ class SiteConfig(dd.Model):
         verbose_name=_("Default build method"), blank=True, null=True
     )
 
-    simulate_today = models.DateField(_("Simulated date"), blank=True, null=True)
+    simulate_today = models.DateField(
+        _("Simulated date"), blank=True, null=True)
 
     site_company = dd.ForeignKey(
         "contacts.Company",
@@ -190,10 +193,12 @@ class SiteConfig(dd.Model):
                 oldval = getattr(cls._site_config, fld.attname)
                 newval = getattr(self, fld.attname)
                 if oldval != newval:
-                    diffs.append("{}: {} -> {}".format(fld.attname, oldval, newval))
+                    diffs.append(
+                        "{}: {} -> {}".format(fld.attname, oldval, newval))
             if len(diffs):
                 print(
-                    "20220824 Overriding SiteConfig instance (diffs={})".format(diffs)
+                    "20220824 Overriding SiteConfig instance (diffs={})".format(
+                        diffs)
                 )
             cls._site_config = self
             # cls._site_config.update_from(self)
@@ -212,9 +217,6 @@ def my_handler(sender, **kw):
     # ~ dd.database_connected.send(sender,**kw)
 
 
-from django.test.signals import setting_changed
-from lino.core.signals import testcase_setup
-
 setting_changed.connect(my_handler)
 testcase_setup.connect(my_handler)
 dd.connection_created.connect(my_handler)
@@ -244,9 +246,6 @@ class SiteConfigs(dd.Table):
     do_build = BuildSiteCache()
 
 
-from lino.utils.report import EmptyTable
-
-
 class Dashboard(EmptyTable):
     # label = _("D")
     hide_navigator = True
@@ -328,7 +327,7 @@ class BleachChecker(Checker):
                 yield m
 
     def get_checkdata_problems(self, obj, fix=False):
-        t = tuple(obj.fields_to_bleach())
+        t = tuple(obj.fields_to_bleach(save=False))
         if len(t):
             fldnames = ", ".join([f.name for f, old, new in t])
             yield (True, _("Fields {} have unbleached content.").format(fldnames))

lino/modlib/uploads/__init__.py

@@ -1,9 +1,6 @@
 # Copyright 2010-2024 Rumma & Ko Ltd
 # License: GNU Affero General Public License v3 (see file COPYING for details)
-"""See :doc:`/specs/uploads`.
 
-
-"""
 from os import symlink
 from os.path import join
 from lino import ad, _
@@ -12,6 +9,7 @@ from lino.modlib.memo.parser import split_name_rest
 UPLOADS_ROOT = 'uploads'
 VOLUMES_ROOT = 'volumes'
 
+
 class Plugin(ad.Plugin):
     "See :doc:`/dev/plugins`."
 
@@ -35,12 +33,12 @@ class Plugin(ad.Plugin):
     # TODO: Also remove the Volume model and its actors when with_volumes is set
     # to False.
 
-    def get_uploads_root(self):
-        # return join(self.site.django_settings["MEDIA_ROOT"], "uploads")
-        return self.site.media_root / UPLOADS_ROOT
+    # def get_uploads_root(self):
+    #     # return join(self.site.django_settings["MEDIA_ROOT"], "uploads")
+    #     return self.site.media_root / UPLOADS_ROOT
 
-    def get_volumes_root(self):
-        return self.site.media_root / VOLUMES_ROOT
+    # def get_volumes_root(self):
+    #     return self.site.media_root / VOLUMES_ROOT
 
     def setup_main_menu(self, site, user_type, m, ar=None):
         mg = self.get_menu_group()
@@ -61,14 +59,19 @@ class Plugin(ad.Plugin):
 
     def post_site_startup(self, site):
 
+        self.uploads_root = site.media_root / UPLOADS_ROOT
+        self.volumes_root = site.media_root / VOLUMES_ROOT
+
         if site.is_installed("memo"):
 
             def gallery(ar, text, cmdname, mentions, context):
                 Upload = site.models.uploads.Upload
-                photos = [Upload.objects.get(pk=int(pk)) for pk in text.split()]
+                photos = [Upload.objects.get(pk=int(pk))
+                          for pk in text.split()]
                 # ctx = dict(width="{}%".format(int(100/len(photos))))
                 mentions.update(photos)
-                html = "".join([obj.memo2html(ar, obj.description) for obj in photos])
+                html = "".join([obj.memo2html(ar, obj.description)
+                               for obj in photos])
                 return '<p align="center">{}</p>'.format(html)
 
             site.plugins.memo.parser.register_command("gallery", gallery)
@@ -76,7 +79,7 @@ class Plugin(ad.Plugin):
         super().post_site_startup(site)
 
         # site.makedirs_if_missing(self.get_uploads_root())
-        # site.makedirs_if_missing(self.get_volumes_root())
+        # site.makedirs_if_missing(self.volumes_root)
 
     def get_requirements(self, site):
         if self.with_thumbnails: