lino 25.2.2__py3-none-any.whl → 25.3.0__py3-none-any.whl

lino/modlib/extjs/views.py

@@ -27,6 +27,7 @@ import os
 from pathlib import Path
 
 from django import http
+from django.contrib.messages import success
 from django.db import models
 from django.conf import settings
 from django.core.cache import cache
@@ -38,6 +39,7 @@ from django.utils.decorators import method_decorator
 from django.views.decorators.csrf import ensure_csrf_cookie, csrf_protect
 from django.utils.translation import gettext as _
 from django.utils.encoding import force_str
+from django.utils.html import mark_safe
 from lino.core import auth
 
 from lino.core.signals import pre_ui_delete
@@ -181,7 +183,8 @@ class SWView(TemplateView):
 class RunJasmine(View):
     def get(self, request, *args, **kw):
         return http.HttpResponse(
-            settings.SITE.kernel.extjs_renderer.html_page(request, run_jasmine=True)
+            settings.SITE.kernel.extjs_renderer.html_page(
+                request, run_jasmine=True)
         )
 
 
@@ -203,7 +206,8 @@ class ActionParamChoices(View):
         if ba is None:
             raise Exception("Unknown action %r for %s" % (an, actor))
         field = ba.action.get_param_elem(field)
-        qs, row2dict = choices_for_field(ba.request(request=request), ba.action, field)
+        qs, row2dict = choices_for_field(
+            ba.request(request=request), ba.action, field)
         if field.blank:
             emptyValue = "<br/>"
         else:
@@ -313,7 +317,8 @@ class Restful(View):
         ar.renderer = settings.SITE.kernel.extjs_renderer
         ar.form2obj_and_save(data, elem, False)
         # Ext.ensible needs grid_fields, not detail_fields
-        ar.set_response(rows=[rh.store.row2dict(ar, elem, rh.store.grid_fields)])
+        ar.set_response(rows=[rh.store.row2dict(
+            ar, elem, rh.store.grid_fields)])
         return json_response(ar.response)
 
 
@@ -343,19 +348,53 @@ class ApiElement(View):
             ba = rpt.detail_action
             if ba is None:
                 raise http.Http404("%s has no detail_action" % rpt)
+
+        fmt = request.GET.get(constants.URL_PARAM_FORMAT,
+                              ba.action.default_format)
+
         try:
             if pk and pk != "-99999" and pk != "-99998":
                 sr = [pk]
-                # if issubclass(rpt.model, models.Model):
-                #     try:
-                #         ar = ba.request(request=request, selected_pks=sr)
-                #     # except ObjectDoesNotExist as e:  # 20250212
-                #     except rpt.model.DoesNotExist as e:
-                #         # print("20240911", e)
-                #         raise http.Http404(f"Object {sr} does not exist on {rpt}")
-                # else:
-                #     ar = ba.request(request=request, selected_pks=sr)
-                ar = ba.request(request=request, selected_pks=sr)
+                if issubclass(rpt.model, models.Model):
+                    try:
+                        ar = ba.request(request=request, selected_pks=sr)
+                    # except ObjectDoesNotExist as e:  # 20250212
+                    except rpt.model.DoesNotExist:
+                        if fmt == constants.URL_FORMAT_JSON:
+                            # rescue_ar: without sr and even request, to render a table request (grid view action) on breadcrumb
+                            rescue_ar = rpt.request(
+                                renderer=settings.SITE.kernel.default_renderer)
+                            default_table = rpt.model.get_default_table()
+
+                            title = tostring(rescue_ar.href_to_request(
+                                rescue_ar, icon_name=None))
+
+                            def get_response():
+                                msg = mark_safe(
+                                    f'Record (pk={pk}) is no longer available on current table.')
+                                datarec = dict(
+                                    success=False, message=msg, title=title)
+                                datarec.update(**vm)
+                                return datarec
+
+                            try:
+                                # take default table and try to show the row
+                                ar = default_table.detail_action.request(
+                                    request=request, selected_pks=sr)
+                            except default_table.model.DoesNotExist:
+                                return json_response(get_response())
+
+                            url = ar.obj2url(ar.selected_rows[0])
+                            datarec = get_response()
+                            datarec['message'] += mark_safe(
+                                f' Reload in <a href="{url}">{default_table}</a>.')
+                            return json_response(datarec)
+                        # print("20240911", e)
+                        raise http.Http404(
+                            f"Object {sr} does not exist on {rpt}")
+                else:
+                    ar = ba.request(request=request, selected_pks=sr)
+                # ar = ba.request(request=request, selected_pks=sr)
                 elem = ar.selected_rows[0]
                 # print(
                 #     "20170116 views.ApiElement.get", ba,
@@ -398,8 +437,6 @@ class ApiElement(View):
 
         # print("20240402 permission", ar, "granted to", ar.get_user(), ar.bound_action.action.select_rows, ar.selected_rows)
 
-        fmt = request.GET.get(constants.URL_PARAM_FORMAT, ba.action.default_format)
-
         if ba.action.opens_a_window:
             if fmt == constants.URL_FORMAT_JSON:
                 if pk == "-99999":
@@ -409,7 +446,8 @@ class ApiElement(View):
                     elem = ar.create_instance()
                     datarec = elem2rec_empty(ar, ar.ah, elem)
                 elif elem is None:
-                    datarec = dict(success=False, message=NOT_FOUND % (rpt, pk))
+                    datarec = dict(
+                        success=False, message=NOT_FOUND % (rpt, pk))
                 else:
                     datarec = ar.elem2rec_detailed(elem)
                 datarec.update(**vm)
@@ -500,7 +538,8 @@ class ApiList(View):
             # Have same-origin policy work for iframe of file upload. see ticket #2885
             # https://stackoverflow.com/questions/22627392/extjs-fileuplaod-cross-origin-frame
             response.content = """<html><head><script type="text/javascript">document.domain="{}";</script></head><body>{}</body></html>""".format(
-                request.POST["_document_domain"], response.content.decode("utf-8")
+                request.POST["_document_domain"], response.content.decode(
+                    "utf-8")
             )
         return response
 
@@ -519,7 +558,8 @@ class ApiList(View):
         # print(20170921, fmt)
 
         if fmt == constants.URL_FORMAT_JSON:
-            rows = [rh.store.row2list(ar, row) for row in ar.sliced_data_iterator]
+            rows = [rh.store.row2list(ar, row)
+                    for row in ar.sliced_data_iterator]
             total_count = ar.get_total_count()
             # raise Exception("20171208 {}".format(ar.data_iterator.query))
             for row in ar.create_phantom_rows():
@@ -562,7 +602,8 @@ class ApiList(View):
             sp = request.GET.get(constants.URL_PARAM_SHOW_PARAMS_PANEL, None)
             if sp is not None:
                 # ~ after_show.update(show_params_panel=sp)
-                after_show.update(show_params_panel=constants.parse_boolean(sp))
+                after_show.update(
+                    show_params_panel=constants.parse_boolean(sp))
 
             # if isinstance(ar.bound_action.action, actions.ShowInsert):
             #     elem = ar.create_instance()
@@ -581,7 +622,8 @@ class ApiList(View):
         if fmt == "csv":
             # ~ response = HttpResponse(mimetype='text/csv')
             charset = settings.SITE.csv_params.get("encoding", "utf-8")
-            response = http.HttpResponse(content_type='text/csv;charset="%s"' % charset)
+            response = http.HttpResponse(
+                content_type='text/csv;charset="%s"' % charset)
             if False:
                 response["Content-Disposition"] = (
                     'attachment; filename="%s.csv"' % ar.actor
@@ -604,8 +646,10 @@ class ApiList(View):
 
         if fmt == constants.URL_FORMAT_PRINTER:
             if ar.get_total_count() > MAX_ROW_COUNT:
-                raise Exception(_("List contains more than %d rows") % MAX_ROW_COUNT)
-            response = http.HttpResponse(content_type='text/html;charset="utf-8"')
+                raise Exception(
+                    _("List contains more than %d rows") % MAX_ROW_COUNT)
+            response = http.HttpResponse(
+                content_type='text/html;charset="utf-8"')
             doc = Document(force_str(ar.get_title()))
             doc.body.append(E.h1(doc.title))
             t = doc.add_table()

lino/modlib/help/config/makehelp/conf.tpl.py

@@ -10,7 +10,7 @@ intersphinx_mapping = {}
 
 {% if makehelp.language.index == 0 -%}
 
-html_context = dict(public_url="{{settings.SITE.server_url}}media/cache/help")
+html_context = dict(public_url="{{settings.SITE.server_url}}/media/cache/help")
 
 from rstgen.sphinxconf import configure ; configure(globals())
 from lino.sphinxcontrib import configure ; configure(globals())

lino/modlib/jinja/mixins.py

@@ -0,0 +1,73 @@
+# -*- coding: UTF-8 -*-
+# Copyright 2022-2025 Rumma & Ko Ltd
+# License: GNU Affero General Public License v3 (see file COPYING for details)
+
+import os
+import base64
+from pathlib import Path
+from lxml import etree
+
+from django.conf import settings
+from django.utils import translation
+from django.utils.html import mark_safe, escape
+
+from lino.api import dd
+from lino.utils.xml import validate_xml
+from lino.utils.media import MediaFile
+
+
+def xml_element(name, value):
+    if value:
+        return f"<{name}>{escape(str(value))}</{name}>"
+    return ""
+
+
+class XMLMaker(dd.Model):
+
+    class Meta:
+        abstract = True
+
+    xml_validator_file = None
+    xml_file_template = None
+    # xml_file_name = None
+
+    def get_xml_file_parts(self):
+        yield 'xml'
+        yield self.get_printable_target_stem() + ".xml"
+
+    def make_xml_file(self, ar):
+        renderer = settings.SITE.plugins.jinja.renderer
+        tpl = renderer.jinja_env.get_template(self.xml_file_template)
+        context = self.get_printable_context(ar)
+        context.update(xml_element=xml_element)
+        context.update(base64=base64)
+        xml = tpl.render(**context)
+        # parts = [
+        #     dd.plugins.accounting.xml_media_dir,
+        #     self.xml_file_name.format(self=self)]
+        xmlfile = MediaFile(False, *self.get_xml_file_parts())
+        # xmlfile = Path(settings.MEDIA_ROOT, *parts)
+        ar.logger.info("Make %s from %s ...", xmlfile.path, self)
+        xmlfile.path.parent.mkdir(exist_ok=True, parents=True)
+        xmlfile.path.write_text(xml)
+        # xmlfile.write_text(etree.tostring(xml))
+
+        if self.xml_validator_file:
+            # print("20250218 {xml[:100]}")
+            # doc = etree.fromstring(xml.encode("utf-8"))
+            ar.logger.info("Validate %s against %s ...",
+                           xmlfile.path.name, self.xml_validator_file)
+            if True:
+                validate_xml(xmlfile.path, self.xml_validator_file)
+            else:
+                try:
+                    validate_xml(xmlfile.path, self.xml_validator_file)
+                except Exception as e:
+                    msg = _("XML validation failed: {}").format(e)
+                    # print(msg)
+                    raise Warning(msg)
+
+        # url = settings.SITE.build_media_url(*parts)
+        # return mark_safe(f"""<a href="{url}">{url}</a>""")
+        # return (xmlfile, url)
+        return xmlfile

lino/modlib/jinja/models.py

@@ -0,0 +1,6 @@
+# -*- coding: UTF-8 -*-
+# Copyright 2025 Rumma & Ko Ltd
+# License: GNU Affero General Public License v3 (see file COPYING for details)
+
+from .mixins import XMLMaker
+from .choicelists import JinjaBuildMethod

lino/modlib/linod/__init__.py

@@ -20,6 +20,7 @@ class Plugin(ad.Plugin):
     verbose_name = _("Lino daemon")
     use_channels = False
     background_sleep_time = 5  # in seconds
+    daemon_user = "robin"  # TODO: find a better solution
 
     def on_plugins_loaded(self, site):
         assert self.site is site

lino/modlib/linod/choicelists.py

@@ -80,3 +80,24 @@ add("INFO")
 add("WARNING")
 add("ERROR")
 add("CRITICAL")
+
+
+def background_task(**kwargs):
+    if "class_name" not in kwargs:
+        kwargs["class_name"] = "linod.SystemTask"
+
+    def decorator(func):
+        Procedures.add_item(func, **kwargs)
+        return func
+
+    return decorator
+
+
+def schedule_often(every=10, **kwargs):
+    kwargs.update(every_unit="secondly", every=every)
+    return background_task(**kwargs)
+
+
+def schedule_daily(**kwargs):
+    kwargs.update(every_unit="daily", every=1)
+    return background_task(**kwargs)

lino/modlib/linod/consumers.py

@@ -36,7 +36,10 @@ from .utils import BROADCAST_CHANNEL
 #     logger.addHandler(logging.StreamHandler())
 #     logger.setLevel(logging.INFO)
 
-is_slave = lambda actor: actor.master is not None
+
+def is_slave(actor): return actor.master is not None
+
+
 match_master = (
     lambda ContentType, MasterModel, Master: Master == MasterModel
     or ContentType == Master
@@ -57,8 +60,12 @@ class LinodConsumer(AsyncConsumer):
     async def run_background_tasks(self, event: dict):
         # 'run.background.tasks' in `pm linod`
         from lino.modlib.linod.mixins import start_task_runner
+        # from lino.core.utils import login
+        # ar = login(settings.SITE.plugins.linod.daemon_user)
         from lino.core.requests import BaseRequest
-        ar = BaseRequest()
+        u = await settings.SITE.user_model.objects.aget(
+            username=settings.SITE.plugins.linod.daemon_user)
+        ar = BaseRequest(user=u)
         asyncio.ensure_future(start_task_runner(ar))
 
     async def send_push(self, event):
@@ -82,7 +89,8 @@ class LinodConsumer(AsyncConsumer):
         if user is None:
             subs = settings.SITE.models.notify.Subscription.objects.all()
         else:
-            subs = settings.SITE.models.notify.Subscription.objects.filter(user=user)
+            subs = settings.SITE.models.notify.Subscription.objects.filter(
+                user=user)
         async for sub in subs.aiterator():
             sub_info = {
                 "endpoint": sub.endpoint,
@@ -122,7 +130,8 @@ class LinodConsumer(AsyncConsumer):
             data.update(
                 **dict(
                     [
-                        (a.actor_id, {"mk": msg["mk"], "mt": mt, "pk": msg["pk"]})
+                        (a.actor_id, {"mk": msg["mk"],
+                         "mt": mt, "pk": msg["pk"]})
                         for a in ups
                         if is_slave(a)
                         and match_master(ContentType, MasterModel, a.master)

lino/modlib/linod/fixtures/linod.py

@@ -0,0 +1,32 @@
+# -*- coding: utf-8 -*-
+# Copyright 2025 Rumma & Ko Ltd
+# License: GNU Affero General Public License v3 (see file COPYING for details)
+from asgiref.sync import async_to_sync
+from lino.api import rt
+from lino.modlib.linod.mixins import start_task_runner
+
+# import logging
+# from lino import logger
+# def getHandlerByName(name):
+#     for l in logger.handlers:
+#         if l.name == name:
+#             return l
+
+def objects():
+    raise Exception("""
+
+    This fixture isn't used at the moment.  I wrote it because I thought it
+    would be nice to run the system task runner automatically when ``pm prep``
+    in order to cover the sync_ibanity system task. But (1) this would require
+    me to integrate also the ``checkdata`` and ``checksummaries`` fixtures into
+    it (otherwise they would run again as a system task) and (2) we don't want
+    to start `sync_ibanity` automatically on GitLab because it can't work
+    without credentials.
+
+        """)
+    ar = rt.login("robin")
+    # logger.setLevel(logging.DEBUG)
+    # getHandlerByName('console').setLevel(logging.DEBUG)
+    # ar.debug("Coucou")
+    async_to_sync(start_task_runner)(ar, max_count=1)
+    return []

lino/modlib/linod/management/commands/linod.py

@@ -1,5 +1,5 @@
 # -*- coding: UTF-8 -*-
-# Copyright 2022-2024 Rumma & Ko Ltd
+# Copyright 2022-2025 Rumma & Ko Ltd
 # License: GNU Affero General Public License v3 (see file COPYING for details)
 
 # import time
@@ -10,6 +10,7 @@ from django.conf import settings
 from django.core.management import BaseCommand, call_command
 from lino.api import dd, rt
 from lino.modlib.linod.mixins import start_log_server, start_task_runner
+from lino.core.requests import BaseRequest
 
 if dd.plugins.linod.use_channels:
     import threading
@@ -50,7 +51,10 @@ class Command(BaseCommand):
             # print("20240424 Run Lino daemon without channels")
 
             async def main():
-                ar = rt.login()
+                u = await settings.SITE.user_model.objects.aget(
+                    username=settings.SITE.plugins.linod.daemon_user)
+                ar = BaseRequest(user=u)
+                # ar = rt.login(dd.plugins.linod.daemon_user)
                 await asyncio.gather(start_log_server(), start_task_runner(ar))
                 # t1 = asyncio.create_task(settings.SITE.start_log_server())
                 # t2 = asyncio.create_task(start_task_runner(ar))

lino/modlib/linod/mixins.py

@@ -4,20 +4,18 @@
 # See https://dev.lino-framework.org/plugins/linod.html
 
 import logging
-import sys
 import traceback
 import asyncio
 import pickle
 from datetime import timedelta
-from io import StringIO
 from django.conf import settings
 from django.db import models
 from django.utils import timezone
-from django.core.exceptions import ValidationError
+# from django.core.exceptions import ValidationError
 from asgiref.sync import sync_to_async, async_to_sync
 
 from lino import logger
-from lino.api import dd, rt, _
+from lino.api import dd, _
 from lino.mixins import Sequenced
 from lino.modlib.system.mixins import RecurrenceSet
 from lino.modlib.system.choicelists import Recurrences
@@ -34,8 +32,9 @@ def astr(self):
 
 class RunNow(dd.Action):
     label = _("Run now")
+    help_text = _("Mark the task as to be executed asap by linod.")
     select_rows = True
-
+    button_text = "▶"
     # icon_name = 'bell'
     # icon_name = 'lightning'
 
@@ -44,7 +43,6 @@ class RunNow(dd.Action):
         for obj in ar.selected_rows:
             assert issubclass(obj.__class__, Runnable)
             if True:  # dd.plugins.linod.use_channels:
-                # Mark the task as to be executed asap by linod.
                 obj.last_start_time = None
                 obj.last_end_time = None
                 obj.message = "{} requested to run this task at {}.".format(
@@ -65,9 +63,11 @@ class Runnable(Sequenced, RecurrenceSet):
 
     log_level = LogLevels.field(default="INFO")
     disabled = dd.BooleanField(_("Disabled"), default=False)
-    last_start_time = dd.DateTimeField(_("Started at"), null=True, editable=False)
+    last_start_time = dd.DateTimeField(
+        _("Started at"), null=True, editable=False)
     last_end_time = dd.DateTimeField(_("Ended at"), null=True, editable=False)
-    message = dd.RichTextField(_("Logged messages"), format="plain", editable=False)
+    message = dd.RichTextField(
+        _("Logged messages"), format="plain", editable=False)
 
     # procedure = Procedures.field(strict=False, unique=True, editable=False)
     procedure = Procedures.field(strict=False)
@@ -76,14 +76,17 @@ class Runnable(Sequenced, RecurrenceSet):
     run_now = RunNow()
 
     def __str__(self):
-        r = "{} #{} ({})".format(self._meta.verbose_name, self.seqno, self.name)
+        r = "{} #{} ({})".format(
+            self._meta.verbose_name, self.seqno, self.name)
         return r
 
     def full_clean(self, *args, **kwargs):
         super().full_clean(*args, **kwargs)
-        class_name = dd.full_model_name(self.__class__)
-        if self.procedure.class_name != class_name:
-            raise ValidationError(f"Invalid procedure for {class_name}")
+        # 20250213 The following caused 'Invalid procedure invoicing.Task for
+        # linod.SystemTask' during restore.py:
+        # class_name = dd.full_model_name(self.__class__)
+        # if self.procedure.class_name != class_name:
+        #     raise ValidationError(f"Invalid procedure {self.procedure.class_name} for {class_name}")
         if self.every_unit is None:
             self.every_unit = Recurrences.never
         if not self.name:
@@ -157,7 +160,7 @@ class Runnable(Sequenced, RecurrenceSet):
         return _("Scheduled to run at {}").format(dd.ftl(next_time))
 
 
-async def start_task_runner(ar, max_count=None):
+async def start_task_runner(ar=None, max_count=None):
     # called from consumers.LinoConsumer.run_background_tasks()
     await ar.ainfo("Start task runner using %s...", ar.logger)
     # ar.info("Start task runner using %s...", ar.logger)
@@ -168,7 +171,8 @@ async def start_task_runner(ar, max_count=None):
         await ar.adebug("Start next task runner loop.")
 
         now = timezone.now()
-        next_time = now + timedelta(seconds=dd.plugins.linod.background_sleep_time)
+        next_time = now + \
+            timedelta(seconds=dd.plugins.linod.background_sleep_time)
 
         for cls in Procedures.task_classes():
             # asyncio.ensure_future(m.start_task_runner(ar.spawn_request()))

lino/modlib/linod/models.py

@@ -30,11 +30,12 @@ class SystemTask(Runnable):
 class SystemTasks(dd.Table):
     # label = _("System tasks")
     model = "linod.SystemTask"
+    order_by = ['seqno']
     required_roles = dd.login_required(SiteStaff)
     column_names = "seqno name log_level disabled status procedure *"
     detail_layout = """
     seqno procedure
-    name 
+    name
     every every_unit
     log_level disabled status
     last_start_time last_end_time
@@ -58,7 +59,8 @@ class SystemTaskChecker(Checker):
         for proc in Procedures.get_list_items():
             if proc.class_name == "linod.SystemTask":
                 if SystemTask.objects.filter(procedure=proc).count() == 0:
-                    msg = _("No {} for {}").format(SystemTask._meta.verbose_name, proc)
+                    msg = _("No {} for {}").format(
+                        SystemTask._meta.verbose_name, proc)
                     yield (True, msg)
                     if fix:
                         logger.debug("Create background task for %r", proc)

lino/modlib/memo/mixins.py

@@ -43,7 +43,8 @@ def rich_text_to_elems(ar, description):
 
     # After 20250213 #5929 (Links in the description of a ticket aren't rendered
     # correctly) we no longer try to automatically detect reSTructuredText
-    # markup in a RichTextField (anyway nobody has ever used this feature).
+    # markup in a RichTextField. Anyway nobody has ever used this feature
+    # (except for the furniture fixture of the products plugin).
 
     # if description.startswith("<"):
     if True:

lino/modlib/memo/parser.py

@@ -135,7 +135,7 @@ class Parser:
     def compile_suggester_regex(self):
         triggers = "".join(
             [
-                "\\" if key in "[\^$.|?*+(){}" else "" + key
+                r"\\" if key in r"[\^$.|?*+(){}" else "" + key
                 for key in self.suggesters.keys()
             ]
         )

lino/modlib/notify/models.py

@@ -22,6 +22,7 @@ from lino.utils.format_date import fds
 from lino.mixins import Created, ObservedDateRange
 from lino.modlib.gfks.mixins import Controllable
 from lino.modlib.users.mixins import UserAuthored, My
+from lino.modlib.linod.choicelists import schedule_daily, schedule_often
 from lino.modlib.office.roles import OfficeUser
 
 from .choicelists import MessageTypes, MailModes
@@ -29,7 +30,9 @@ from .api import send_notification, NOTIFICATION, send_panel_update
 
 html_parser = etree.HTMLParser()
 
-subaddress_separator = dd.get_plugin_setting('inbox', 'subaddress_separator', None)
+subaddress_separator = dd.get_plugin_setting(
+    'inbox', 'subaddress_separator', None)
+
 
 def groupname(s):
     # Remove any invalid characters from the given string so that it can
@@ -126,7 +129,8 @@ class Message(UserAuthored, Controllable, Created):
     message_type = MessageTypes.field(default="change")
     seen = models.DateTimeField(_("seen"), null=True, editable=False)
     sent = models.DateTimeField(_("sent"), null=True, editable=False)
-    body = dd.RichTextField(_("Body"), editable=False, format="html", default="")
+    body = dd.RichTextField(_("Body"), editable=False,
+                            format="html", default="")
     mail_mode = MailModes.field(default="often")
     subject = models.CharField(_("Subject"), max_length=250, editable=False)
     reply_to = dd.ForeignKey(
@@ -171,7 +175,8 @@ class Message(UserAuthored, Controllable, Created):
                 ba = owner.get_detail_action(ar)
                 if ba is not None:
                     push_options.update(
-                        action_url=ar.renderer.get_detail_url(ar, ba.actor, owner.pk)
+                        action_url=ar.renderer.get_detail_url(
+                            ar, ba.actor, owner.pk)
                     )
                 # push_options.update(action_url=ar.renderer.obj2url(ar, owner))
             me = ar.get_user()
@@ -267,7 +272,8 @@ class Message(UserAuthored, Controllable, Created):
                     collect(u, obj)
             else:
                 collect(obj.user, obj)
-        ar.logger.debug("Send out '%s' summaries for %d users.", mm, len(users))
+        ar.logger.debug(
+            "Send out '%s' summaries for %d users.", mm, len(users))
         for user, messages in users.items():
             with translation.override(user.language):
                 sender = sender_parts[0]
@@ -276,9 +282,11 @@ class Message(UserAuthored, Controllable, Created):
                     subject = msg.subject
                     if subaddress_separator is not None:
                         if msg.reply_to_id:
-                            sender += subaddress_separator + str(msg.reply_to_id)
+                            sender += subaddress_separator + \
+                                str(msg.reply_to_id)
                         elif msg.owner_id:
-                            sender += subaddress_separator + str(msg.owner_type)
+                            sender += subaddress_separator + \
+                                str(msg.owner_type)
                             sender += subaddress_separator + str(msg.owner_id)
                 else:
                     subject = _("{} notifications").format(len(messages))
@@ -386,7 +394,7 @@ class MyMessages(My, Messages):
     default_display_modes = {None: constants.DISPLAY_MODE_SUMMARY}
 
     @classmethod
-    def unused_get_table_summary(cls, mi, ar):
+    def unused_get_table_summary(cls, ar):
         # 20240710 Replaced by table_as_summary(), which is now more simple. But
         # I leave the old version here in case some unexpected regression
         # occurs.
@@ -460,18 +468,18 @@ class MyMessages(My, Messages):
 #         h)
 
 
-@dd.schedule_often(every=10)
+@schedule_often(every=10)
 def send_pending_emails_often(ar):
     # print("20231021 send_pending_emails_often()", ar.logger)
     rt.models.notify.Message.send_summary_emails(ar, MailModes.often)
 
 
-@dd.schedule_daily()
+@schedule_daily()
 def send_pending_emails_daily(ar):
     rt.models.notify.Message.send_summary_emails(ar, MailModes.daily)
 
 
-# @dd.schedule_often(every=10)
+# @schedule_often(every=10)
 # def send_pending_emails_often(ar):
 #     Message = rt.models.notify.Message
 #     qs = Message.objects.filter(sent__isnull=True)
@@ -488,7 +496,7 @@ remove_after = dd.plugins.notify.remove_after
 
 if remove_after:
 
-    @dd.schedule_daily()
+    @schedule_daily()
     def clear_seen_messages(ar):
         Message = rt.models.notify.Message
         qs = Message.objects.filter(