folio-migration-tools 1.9.2__py3-none-any.whl → 1.9.4__py3-none-any.whl

folio_migration_tools/migration_tasks/loans_migrator.py

@@ -6,7 +6,7 @@ import sys
 import time
 import traceback
 from datetime import datetime, timedelta
-from typing import Annotated, Optional
+from typing import Annotated, Literal, Optional
 from urllib.error import HTTPError
 from zoneinfo import ZoneInfo
 from pydantic import Field
@@ -17,6 +17,7 @@ from folio_uuid.folio_namespaces import FOLIONamespaces
 from art import tprint
 
 from folio_migration_tools.circulation_helper import CirculationHelper
+from folio_migration_tools.custom_exceptions import TransformationRecordFailedError
 from folio_migration_tools.helper import Helper
 from folio_migration_tools.library_configuration import (
     FileDefinition,
@@ -54,7 +55,7 @@ class LoansMigrator(MigrationTaskBase):
             Optional[list[FileDefinition]],
             Field(
                 title="Open loans files",
-                description="List of files containing open loan data."
+                description="List of files containing open loan data.",
             ),
         ]
         fallback_service_point_id: Annotated[
@@ -68,10 +69,7 @@ class LoansMigrator(MigrationTaskBase):
             Optional[int],
             Field(
                 title="Starting row",
-                description=(
-                    "The starting row for data processing. "
-                    "By default is 1."
-                ),
+                description=("The starting row for data processing. By default is 1."),
             ),
         ] = 1
         item_files: Annotated[
@@ -79,8 +77,7 @@ class LoansMigrator(MigrationTaskBase):
             Field(
                 title="Item files",
                 description=(
-                    "List of files containing item data. "
-                    "By default is empty list."
+                    "List of files containing item data. By default is empty list."
                 ),
             ),
         ] = []
@@ -89,8 +86,7 @@ class LoansMigrator(MigrationTaskBase):
             Field(
                 title="Patron files",
                 description=(
-                    "List of files containing patron data. "
-                    "By default is empty list."
+                    "List of files containing patron data. By default is empty list."
                 ),
             ),
         ] = []
@@ -103,7 +99,7 @@ class LoansMigrator(MigrationTaskBase):
         self,
         task_configuration: TaskConfiguration,
         library_config: LibraryConfiguration,
-        folio_client
+        folio_client,
     ):
         csv.register_dialect("tsv", delimiter="\t")
         self.patron_item_combos: set = set()
@@ -128,7 +124,9 @@ class LoansMigrator(MigrationTaskBase):
         my_path = "/configurations/entries?query=(module==ORG%20and%20configName==localeSettings)"
         try:
             self.tenant_timezone_str = json.loads(
-                self.folio_client.folio_get_single_object(my_path)["configs"][0]["value"]
+                self.folio_client.folio_get_single_object(my_path)["configs"][0][
+                    "value"
+                ]
             )["timezone"]
             logging.info("Tenant timezone is: %s", self.tenant_timezone_str)
         except Exception:
@@ -137,10 +135,14 @@ class LoansMigrator(MigrationTaskBase):
         self.tenant_timezone = ZoneInfo(self.tenant_timezone_str)
         self.semi_valid_legacy_loans = []
         for file_def in task_configuration.open_loans_files:
-            loans_file_path = self.folder_structure.legacy_records_folder / file_def.file_name
+            loans_file_path = (
+                self.folder_structure.legacy_records_folder / file_def.file_name
+            )
             with open(loans_file_path, "r", encoding="utf-8") as loans_file:
-                total_rows, empty_rows, reader = MappingFileMapperBase._get_delimited_file_reader(
-                    loans_file, loans_file_path
+                total_rows, empty_rows, reader = (
+                    MappingFileMapperBase._get_delimited_file_reader(
+                        loans_file, loans_file_path
+                    )
                 )
                 logging.info("Source data file contains %d rows", total_rows)
                 logging.info("Source data file contains %d empty rows", empty_rows)
@@ -157,7 +159,8 @@ class LoansMigrator(MigrationTaskBase):
                 self.semi_valid_legacy_loans.extend(
                     self.load_and_validate_legacy_loans(
                         reader,
-                        file_def.service_point_id or task_configuration.fallback_service_point_id,
+                        file_def.service_point_id
+                        or task_configuration.fallback_service_point_id,
                     )
                 )
 
@@ -166,8 +169,12 @@ class LoansMigrator(MigrationTaskBase):
                     len(self.semi_valid_legacy_loans),
                     file_def.file_name,
                 )
-        logging.info("Loaded and validated %s loans in total", len(self.semi_valid_legacy_loans))
-        if any(self.task_configuration.item_files) or any(self.task_configuration.patron_files):
+        logging.info(
+            "Loaded and validated %s loans in total", len(self.semi_valid_legacy_loans)
+        )
+        if any(self.task_configuration.item_files) or any(
+            self.task_configuration.patron_files
+        ):
             self.valid_legacy_loans = list(self.check_barcodes())
             logging.info(
                 "Loaded and validated %s loans against barcodes",
@@ -184,9 +191,9 @@ class LoansMigrator(MigrationTaskBase):
 
     def check_smtp_config(self):
         try:
-            smtp_config = self.folio_client.folio_get_single_object("/smtp-configuration")[
-                "smtpConfigurations"
-            ][0]
+            smtp_config = self.folio_client.folio_get_single_object(
+                "/smtp-configuration"
+            )["smtpConfigurations"][0]
             smtp_config_disabled = "disabled" in smtp_config["host"].lower()
         except IndexError:
             smtp_config_disabled = True
@@ -194,7 +201,9 @@ class LoansMigrator(MigrationTaskBase):
         if not smtp_config_disabled:
             logging.warn("SMTP connection not disabled...")
             for i in range(10, 0, -1):
-                sys.stdout.write("Pausing for {:02d} seconds. Press Ctrl+C to exit...\r".format(i))
+                sys.stdout.write(
+                    "Pausing for {:02d} seconds. Press Ctrl+C to exit...\r".format(i)
+                )
                 time.sleep(1)
         else:
             logging.info("SMTP connection is disabled...")
@@ -224,7 +233,9 @@ class LoansMigrator(MigrationTaskBase):
                         f"Patron barcode: {legacy_loan.patron_barcode} {ee}"
                     )
                 if num_loans % 25 == 0:
-                    logging.info(f"{timings(self.t0, t0_migration, num_loans)} {num_loans}")
+                    logging.info(
+                        f"{timings(self.t0, t0_migration, num_loans)} {num_loans}"
+                    )
 
     def checkout_single_loan(self, legacy_loan: LegacyLoan):
         """Checks a legacy loan out. Retries once if it fails.
@@ -236,14 +247,20 @@ class LoansMigrator(MigrationTaskBase):
 
         if res_checkout.was_successful:
             self.migration_report.add("Details", i18n.t("Checked out on first try"))
-            self.migration_report.add_general_statistics(i18n.t("Successfully checked out"))
+            self.migration_report.add_general_statistics(
+                i18n.t("Successfully checked out")
+            )
             self.set_renewal_count(legacy_loan, res_checkout)
             self.set_new_status(legacy_loan, res_checkout)
         elif res_checkout.should_be_retried:
             res_checkout2 = self.handle_checkout_failure(legacy_loan, res_checkout)
             if res_checkout2.was_successful and res_checkout2.folio_loan:
-                self.migration_report.add("Details", i18n.t("Checked out on second try"))
-                self.migration_report.add_general_statistics(i18n.t("Successfully checked out"))
+                self.migration_report.add(
+                    "Details", i18n.t("Checked out on second try")
+                )
+                self.migration_report.add_general_statistics(
+                    i18n.t("Successfully checked out")
+                )
                 logging.info("Checked out on second try")
                 self.set_renewal_count(legacy_loan, res_checkout2)
                 self.set_new_status(legacy_loan, res_checkout2)
@@ -251,7 +268,8 @@ class LoansMigrator(MigrationTaskBase):
                 if res_checkout2.error_message == "Aged to lost and checked out":
                     self.migration_report.add(
                         "Details",
-                        i18n.t("Second failure") + f": {res_checkout2.migration_report_message}",
+                        i18n.t("Second failure")
+                        + f": {res_checkout2.migration_report_message}",
                     )
                     logging.error(
                         f"{res_checkout2.error_message}. Item barcode: {legacy_loan.item_barcode}"
@@ -260,15 +278,22 @@ class LoansMigrator(MigrationTaskBase):
                     self.failed[legacy_loan.item_barcode] = legacy_loan
                     self.migration_report.add_general_statistics(i18n.t("Failed loans"))
                     Helper.log_data_issue(
-                        "", "Loans failing during checkout", json.dumps(legacy_loan.to_dict())
+                        "",
+                        "Loans failing during checkout",
+                        json.dumps(legacy_loan.to_dict()),
+                    )
+                    logging.error(
+                        "Failed on second try: %s", res_checkout2.error_message
                     )
-                    logging.error("Failed on second try: %s", res_checkout2.error_message)
                     self.migration_report.add(
                         "Details",
-                        i18n.t("Second failure") + f": {res_checkout2.migration_report_message}",
+                        i18n.t("Second failure")
+                        + f": {res_checkout2.migration_report_message}",
                     )
         elif not res_checkout.should_be_retried:
-            logging.error("Failed first time. No retries: %s", res_checkout.error_message)
+            logging.error(
+                "Failed first time. No retries: %s", res_checkout.error_message
+            )
             self.migration_report.add_general_statistics(i18n.t("Failed loans"))
             self.migration_report.add(
                 "Details",
@@ -295,14 +320,18 @@ class LoansMigrator(MigrationTaskBase):
         elif legacy_loan.next_item_status not in ["Available", "", "Checked out"]:
             self.set_item_status(legacy_loan)
 
-    def set_renewal_count(self, legacy_loan: LegacyLoan, res_checkout: TransactionResult):
+    def set_renewal_count(
+        self, legacy_loan: LegacyLoan, res_checkout: TransactionResult
+    ):
         if legacy_loan.renewal_count > 0:
             self.update_open_loan(res_checkout.folio_loan, legacy_loan)
-            self.migration_report.add_general_statistics(i18n.t("Updated renewal count for loan"))
+            self.migration_report.add_general_statistics(
+                i18n.t("Updated renewal count for loan")
+            )
 
     def wrap_up(self):
         for k, v in self.failed.items():
-            self.failed_and_not_dupe[k] = [v.to_dict()]
+            self.failed_and_not_dupe[k] = [v if isinstance(v, dict) else v.to_dict()]
         print(f"Wrapping up. Unique loans in failed:{len(self.failed_and_not_dupe)}")
 
         self.write_failed_loans_to_file()
@@ -315,15 +344,19 @@ class LoansMigrator(MigrationTaskBase):
 
     def write_failed_loans_to_file(self):
         csv_columns = [
-            "due_date",
+            "patron_barcode",
+            "proxy_patron_barcode",
             "item_barcode",
-            "next_item_status",
+            "due_date",
             "out_date",
-            "patron_barcode",
+            "next_item_status",
             "renewal_count",
+            "service_point_id",
         ]
         with open(self.folder_structure.failed_recs_path, "w+") as failed_loans_file:
-            writer = csv.DictWriter(failed_loans_file, fieldnames=csv_columns, dialect="tsv")
+            writer = csv.DictWriter(
+                failed_loans_file, fieldnames=csv_columns, dialect="tsv"
+            )
             writer.writeheader()
             for _k, failed_loan in self.failed_and_not_dupe.items():
                 writer.writerow(failed_loan[0])
@@ -338,12 +371,16 @@ class LoansMigrator(MigrationTaskBase):
             user_barcodes, self.task_configuration.patron_files, self.folder_structure
         )
         for loan in self.semi_valid_legacy_loans:
-            has_item_barcode = loan.item_barcode in item_barcodes or not any(item_barcodes)
-            has_patron_barcode = loan.patron_barcode in user_barcodes or not any(user_barcodes)
+            has_item_barcode = loan.item_barcode in item_barcodes or not any(
+                item_barcodes
+            )
+            has_patron_barcode = loan.patron_barcode in user_barcodes or not any(
+                user_barcodes
+            )
             has_proxy_barcode = True
             if loan.proxy_patron_barcode:
-                has_proxy_barcode = loan.proxy_patron_barcode in user_barcodes or not any(
-                    user_barcodes
+                has_proxy_barcode = (
+                    loan.proxy_patron_barcode in user_barcodes or not any(user_barcodes)
                 )
             if has_item_barcode and has_patron_barcode and has_proxy_barcode:
                 self.migration_report.add_general_statistics(
@@ -374,10 +411,14 @@ class LoansMigrator(MigrationTaskBase):
                 )
             if not has_proxy_barcode:
                 Helper.log_data_issue(
-                    "", "Loan without matched proxy patron barcode", json.dumps(loan.to_dict())
+                    "",
+                    "Loan without matched proxy patron barcode",
+                    json.dumps(loan.to_dict()),
                 )
 
-    def load_and_validate_legacy_loans(self, loans_reader, service_point_id: str) -> list:
+    def load_and_validate_legacy_loans(
+        self, loans_reader, service_point_id: str
+    ) -> list:
         results = []
         num_bad = 0
         logging.info("Validating legacy loans in file...")
@@ -397,13 +438,30 @@ class LoansMigrator(MigrationTaskBase):
                     )
                     self.migration_report.add_general_statistics(i18n.t("Failed loans"))
                     for error in legacy_loan.errors:
-                        self.migration_report.add("DiscardedLoans", f"{error[0]} - {error[1]}")
+                        self.migration_report.add(
+                            "DiscardedLoans", f"{error[0]} - {error[1]}"
+                        )
                     # Add this loan to failed loans for later correction and re-run.
                     self.failed[
                         legacy_loan.item_barcode or f"no_barcode_{legacy_loan_count}"
                     ] = legacy_loan
                 else:
                     results.append(legacy_loan)
+            except TransformationRecordFailedError as trfe:
+                num_bad += 1
+                self.migration_report.add_general_statistics(
+                    i18n.t("Loans failed pre-validation")
+                )
+                self.migration_report.add(
+                    "DiscardedLoans",
+                    f"{trfe.message} - see data issues log",
+                )
+                trfe.log_it()
+                self.failed[
+                    legacy_loan_dict.get(
+                        "item_barcode", f"no_barcode_{legacy_loan_count}"
+                    )
+                ] = legacy_loan_dict
             except ValueError as ve:
                 logging.exception(ve)
         logging.info(
@@ -443,13 +501,20 @@ class LoansMigrator(MigrationTaskBase):
         elif folio_checkout.error_message.startswith(
             "Cannot check out item that already has an open loan"
         ):
-            return folio_checkout
+            return self.handle_checked_out_item(legacy_loan)
         elif "Aged to lost" in folio_checkout.error_message:
-            return self.handle_aged_to_lost_item(legacy_loan)
+            return self.handle_lost_item(legacy_loan, "Aged to lost")
         elif folio_checkout.error_message == "Declared lost":
-            return folio_checkout
-        elif folio_checkout.error_message.startswith("Cannot check out to inactive user"):
-            return self.checkout_to_inactice_user(legacy_loan)
+            return self.handle_lost_item(legacy_loan, "Declared lost")
+        elif folio_checkout.error_message.startswith(
+            "Cannot check out to inactive user"
+        ):
+            return self.checkout_to_inactive_user(legacy_loan)
+        elif (
+            "has the item status Claimed returned and cannot be checked out"
+            in folio_checkout.error_message
+        ):
+            return self.handle_claimed_returned_item(legacy_loan)
         else:
             self.migration_report.add(
                 "Details",
@@ -475,46 +540,116 @@ class LoansMigrator(MigrationTaskBase):
                     f"Duplicate loans (or failed twice) Item barcode: "
                     f"{legacy_loan.item_barcode} Patron barcode: {legacy_loan.patron_barcode}"
                 )
-                self.migration_report.add("Details", i18n.t("Duplicate loans (or failed twice)"))
+                self.migration_report.add(
+                    "Details", i18n.t("Duplicate loans (or failed twice)")
+                )
                 del self.failed[legacy_loan.item_barcode]
             return TransactionResult(False, False, "", "", "")
 
-    def checkout_to_inactice_user(self, legacy_loan) -> TransactionResult:
+    def checkout_to_inactive_user(self, legacy_loan) -> TransactionResult:
         logging.info("Cannot check out to inactive user. Activating and trying again")
         user = self.get_user_by_barcode(legacy_loan.patron_barcode)
         expiration_date = user.get("expirationDate", datetime.isoformat(datetime.now()))
         user["expirationDate"] = datetime.isoformat(datetime.now() + timedelta(days=1))
         self.activate_user(user)
         logging.debug("Successfully Activated user")
-        res = self.circulation_helper.check_out_by_barcode(legacy_loan)  # checkout_and_update
+        res = self.circulation_helper.check_out_by_barcode(
+            legacy_loan
+        )  # checkout_and_update
+        if res.should_be_retried:
+            res = self.handle_checkout_failure(legacy_loan, res)
         self.migration_report.add("Details", res.migration_report_message)
         self.deactivate_user(user, expiration_date)
         logging.debug("Successfully Deactivated user again")
         self.migration_report.add("Details", i18n.t("Handled inactive users"))
         return res
 
-    def handle_aged_to_lost_item(self, legacy_loan: LegacyLoan) -> TransactionResult:
+    def handle_checked_out_item(self, legacy_loan: LegacyLoan) -> TransactionResult:
         if self.circulation_helper.is_checked_out(legacy_loan):
             return TransactionResult(
                 False,
                 False,
                 legacy_loan,
-                i18n.t("Aged to lost and checked out"),
-                i18n.t("Aged to lost and checked out"),
+                i18n.t(
+                    "Loan already exists for %{item_barcode}",
+                    item_barcode=legacy_loan.item_barcode,
+                ),
+                i18n.t(
+                    "Loan already exists for %{item_barcode}",
+                    item_barcode=legacy_loan.item_barcode,
+                ),
             )
-
         else:
-            logging.debug("Setting Available")
+            logging.debug(
+                i18n.t(
+                    'Setting item %{item_barcode} to status "Available"',
+                    item_barcode=legacy_loan.item_barcode,
+                )
+            )
             legacy_loan.next_item_status = "Available"
             self.set_item_status(legacy_loan)
             res_checkout = self.circulation_helper.check_out_by_barcode(legacy_loan)
-            legacy_loan.next_item_status = "Aged to lost"
+            legacy_loan.next_item_status = "Checked out"
+            return res_checkout
+
+    def handle_lost_item(
+        self,
+        legacy_loan: LegacyLoan,
+        lost_type: Literal["Aged to lost", "Declared lost"],
+    ) -> TransactionResult:
+        if self.circulation_helper.is_checked_out(legacy_loan):
+            return TransactionResult(
+                False,
+                False,
+                legacy_loan,
+                i18n.t("%{lost_type} and checked out", lost_type=lost_type),
+                i18n.t("%{lost_type} and checked out", lost_type=lost_type),
+            )
+
+        else:
+            logging.debug(
+                'Setting item %{item_barcode} to status "Available"',
+                item_barcode=legacy_loan.item_barcode,
+            )
+            legacy_loan.next_item_status = "Available"
             self.set_item_status(legacy_loan)
-            s = "Successfully Checked out Aged to lost item and put the status back"
+            res_checkout = self.circulation_helper.check_out_by_barcode(legacy_loan)
+            legacy_loan.next_item_status = lost_type
+            if lost_type == "Aged to lost":
+                self.set_item_status(legacy_loan)
+                s = i18n.t(
+                    "Successfully Checked out %{lost_type} item and put the status back",
+                    lost_type=lost_type,
+                )
+            else:
+                s = i18n.t(
+                    "Successfully Checked out %{lost_type} item. Item will be declared lost.",
+                    lost_type=lost_type,
+                )
             logging.info(s)
             self.migration_report.add("Details", s)
             return res_checkout
 
+    def handle_claimed_returned_item(self, legacy_loan: LegacyLoan):
+        if self.circulation_helper.is_checked_out(legacy_loan):
+            return TransactionResult(
+                False,
+                False,
+                legacy_loan,
+                i18n.t("Claimed returned and checked out"),
+                i18n.t("Claimed returned and checked out"),
+            )
+        else:
+            logging.debug(
+                'Setting item %{item_barcode} to status "Available"',
+                item_barcode=legacy_loan.item_barcode,
+            )
+            legacy_loan.next_item_status = "Available"
+            self.set_item_status(legacy_loan)
+            res_checkout = self.circulation_helper.check_out_by_barcode(legacy_loan)
+            legacy_loan.next_item_status = "Claimed returned"
+            return res_checkout
+
     def update_open_loan(self, folio_loan: dict, legacy_loan: LegacyLoan):
         due_date = du_parser.isoparse(str(legacy_loan.due_date))
         out_date = du_parser.isoparse(str(legacy_loan.out_date))
@@ -525,7 +660,9 @@ class LoansMigrator(MigrationTaskBase):
             loan_to_put["dueDate"] = due_date.isoformat()
             loan_to_put["loanDate"] = out_date.isoformat()
             loan_to_put["renewalCount"] = renewal_count
-            url = f"{self.folio_client.gateway_url}/circulation/loans/{loan_to_put['id']}"
+            url = (
+                f"{self.folio_client.gateway_url}/circulation/loans/{loan_to_put['id']}"
+            )
             req = self.http_client.put(
                 url,
                 headers=self.folio_client.okapi_headers,
@@ -546,7 +683,8 @@ class LoansMigrator(MigrationTaskBase):
             else:
                 self.migration_report.add(
                     "Details",
-                    i18n.t("Update open loan error http status") + f": {req.status_code}",
+                    i18n.t("Update open loan error http status")
+                    + f": {req.status_code}",
                 )
                 req.raise_for_status()
             logging.debug("Updating open loan was successful")
@@ -576,40 +714,59 @@ class LoansMigrator(MigrationTaskBase):
             "servicePointId": str(self.task_configuration.fallback_service_point_id),
         }
         logging.debug(f"Declare lost data: {json.dumps(data, indent=4)}")
-        if self.folio_put_post(declare_lost_url, data, "POST", i18n.t("Declare item as lost")):
-            self.migration_report.add("Details", i18n.t("Successfully declared loan as lost"))
+        if self.folio_put_post(
+            declare_lost_url, data, "POST", i18n.t("Declare item as lost")
+        ):
+            self.migration_report.add(
+                "Details", i18n.t("Successfully declared loan as lost")
+            )
         else:
             logging.error(f"Unsuccessfully declared loan {folio_loan} as lost")
-            self.migration_report.add("Details", i18n.t("Unsuccessfully declared loan as lost"))
+            self.migration_report.add(
+                "Details", i18n.t("Unsuccessfully declared loan as lost")
+            )
 
     def claim_returned(self, folio_loan):
-        claim_returned_url = f"/circulation/loans/{folio_loan['id']}/claim-item-returned"
+        claim_returned_url = (
+            f"/circulation/loans/{folio_loan['id']}/claim-item-returned"
+        )
         logging.debug(f"Claim returned url:{claim_returned_url}")
         due_date = du_parser.isoparse(folio_loan["dueDate"])
         data = {
-            "itemClaimedReturnedDateTime": datetime.isoformat(due_date + timedelta(days=1)),
+            "itemClaimedReturnedDateTime": datetime.isoformat(
+                due_date + timedelta(days=1)
+            ),
             "comment": "Created at migration. Date is due date + 1 day",
         }
         logging.debug(f"Claim returned data:\t{json.dumps(data)}")
-        if self.folio_put_post(claim_returned_url, data, "POST", i18n.t("Declare item as lost")):
+        if self.folio_put_post(
+            claim_returned_url, data, "POST", i18n.t("Claim item returned")
+        ):
             self.migration_report.add(
                 "Details", i18n.t("Successfully declared loan as Claimed returned")
             )
         else:
-            logging.error(f"Unsuccessfully declared loan {folio_loan} as Claimed returned")
+            logging.error(
+                f"Unsuccessfully declared loan {folio_loan} as Claimed returned"
+            )
             self.migration_report.add(
                 "Details",
                 i18n.t(
-                    "Unsuccessfully declared loan %{loan} as Claimed returned", loan=folio_loan
+                    "Unsuccessfully declared loan %{loan} as Claimed returned",
+                    loan=folio_loan,
                 ),
             )
 
     def set_item_status(self, legacy_loan: LegacyLoan):
         try:
             # Get Item by barcode, update status.
-            item_path = f'item-storage/items?query=(barcode=="{legacy_loan.item_barcode}")'
+            item_path = (
+                f'item-storage/items?query=(barcode=="{legacy_loan.item_barcode}")'
+            )
             item_url = f"{self.folio_client.gateway_url}/{item_path}"
-            resp = self.http_client.get(item_url, headers=self.folio_client.okapi_headers)
+            resp = self.http_client.get(
+                item_url, headers=self.folio_client.okapi_headers
+            )
             resp.raise_for_status()
             data = resp.json()
             folio_item = data["items"][0]
@@ -659,11 +816,11 @@ class LoansMigrator(MigrationTaskBase):
         self.migration_report.add("Details", i18n.t("Successfully deactivated user"))
 
     def update_item(self, item):
-        url = f'/item-storage/items/{item["id"]}'
+        url = f"/item-storage/items/{item['id']}"
         return self.folio_put_post(url, item, "PUT", i18n.t("Update item"))
 
     def update_user(self, user):
-        url = f'/users/{user["id"]}'
+        url = f"/users/{user['id']}"
         self.folio_put_post(url, user, "PUT", i18n.t("Update user"))
 
     def get_user_by_barcode(self, barcode):
@@ -730,7 +887,9 @@ class LoansMigrator(MigrationTaskBase):
         try:
             api_path = f"{folio_loan['id']}/change-due-date"
             api_url = f"{self.folio_client.gateway_url}/circulation/loans/{api_path}"
-            body = {"dueDate": du_parser.isoparse(str(legacy_loan.due_date)).isoformat()}
+            body = {
+                "dueDate": du_parser.isoparse(str(legacy_loan.due_date)).isoformat()
+            }
             req = self.http_client.post(
                 api_url, headers=self.folio_client.okapi_headers, json=body
             )
@@ -746,12 +905,14 @@ class LoansMigrator(MigrationTaskBase):
                 return False
             elif req.status_code == 201:
                 self.migration_report.add(
-                    "Details", i18n.t("Successfully changed due date") + f" ({req.status_code})"
+                    "Details",
+                    i18n.t("Successfully changed due date") + f" ({req.status_code})",
                 )
                 return True, json.loads(req.text), None
             elif req.status_code == 204:
                 self.migration_report.add(
-                    "Details", i18n.t("Successfully changed due date") + f" ({req.status_code})"
+                    "Details",
+                    i18n.t("Successfully changed due date") + f" ({req.status_code})",
                 )
                 return True, None, None
             else:

folio_migration_tools/migration_tasks/organization_transformer.py

@@ -148,6 +148,7 @@ class OrganizationTransformer(MigrationTaskBase):
         self.mapper = OrganizationMapper(
             self.folio_client,
             self.library_configuration,
+            self.task_configuration,
             self.organization_map,
             self.load_ref_data_mapping_file(
                 "organizationTypes",

folio_migration_tools/task_configuration.py

@@ -25,7 +25,9 @@ class AbstractTaskConfiguration(BaseModel):
         str,
         Field(
             title="Migration task type",
-            description=("The type of migration task you want to perform."),
+            description=(
+                "The type of migration task you want to perform."
+            ),
         ),
     ]
     ecs_tenant_id: Annotated[

folio_migration_tools/test_infrastructure/mocked_classes.py

@@ -121,6 +121,11 @@ def folio_get_all_mocked(ref_data_path, array_name, query="", limit=10):
                 "name": "FOLIO user department name",
                 "code": "fdp",
             },
+            {
+                "id": "12a2ad12-951d-4124-9fb2-58c70f0b7f72",
+                "name": "FOLIO user department name 2",
+                "code": "fdp2",
+            },
             {
                 "id": "2f452d21-507d-4b32-a89d-8ea9753cc946",
                 "name": "FOLIO fallback user department name",