folio-migration-tools 1.9.2__py3-none-any.whl → 1.9.4__py3-none-any.whl

folio_migration_tools/migration_tasks/batch_poster.py

@@ -33,9 +33,9 @@ def write_failed_batch_to_file(batch, file):
 
 
 class BatchPoster(MigrationTaskBase):
-    """Batchposter
+    """BatchPoster
 
-    Args:
+    Parents:
         MigrationTaskBase (_type_): _description_
 
     Raises:
@@ -131,6 +131,56 @@ class BatchPoster(MigrationTaskBase):
                 ),
             ),
         ] = False
+        preserve_statistical_codes: Annotated[
+            bool,
+            Field(
+                title="Preserve statistical codes",
+                description=(
+                    "Toggles whether or not to preserve statistical codes "
+                    "during the upsert process. Defaults to False"
+                ),
+            ),
+        ] = False
+        preserve_administrative_notes: Annotated[
+            bool,
+            Field(
+                title="Preserve administrative notes",
+                description=(
+                    "Toggles whether or not to preserve administrative notes "
+                    "during the upsert process. Defaults to False"
+                ),
+            ),
+        ] = False
+        preserve_temporary_locations: Annotated[
+            bool,
+            Field(
+                title="Preserve temporary locations",
+                description=(
+                    "Toggles whether or not to preserve temporary locations "
+                    "on items during the upsert process. Defaults to False"
+                ),
+            ),
+        ] = False
+        preserve_temporary_loan_types: Annotated[
+            bool,
+            Field(
+                title="Preserve temporary loan types",
+                description=(
+                    "Toggles whether or not to preserve temporary loan types "
+                    "on items during the upsert process. Defaults to False"
+                ),
+            ),
+        ] = False
+        preserve_item_status: Annotated[
+            bool,
+            Field(
+                title="Preserve item status",
+                description=(
+                    "Toggles whether or not to preserve item status "
+                    "on items during the upsert process. Defaults to False"
+                ),
+            ),
+        ] = True
 
     task_configuration: TaskConfiguration
 
@@ -158,7 +208,8 @@ class BatchPoster(MigrationTaskBase):
         if self.api_info["supports_upsert"]:
             self.query_params["upsert"] = self.task_configuration.upsert
         elif self.task_configuration.upsert and not self.api_info["supports_upsert"]:
-            logging.info("Upsert is not supported for this object type. Query parameter will not be set.")
+            logging.info(
+                "Upsert is not supported for this object type. Query parameter will not be set.")
         self.snapshot_id = str(uuid4())
         self.failed_objects: list = []
         self.batch_size = self.task_configuration.batch_size
@@ -174,11 +225,14 @@ class BatchPoster(MigrationTaskBase):
         self.okapi_headers = self.folio_client.okapi_headers
         self.http_client = None
         self.starting_record_count_in_folio: Optional[int] = None
+        self.finished_record_count_in_folio: Optional[int] = None
 
     def do_work(self):
         with self.folio_client.get_folio_http_client() as httpx_client:
             self.http_client = httpx_client
-            with open(self.folder_structure.failed_recs_path, "w", encoding='utf-8') as failed_recs_file:
+            with open(
+                    self.folder_structure.failed_recs_path, "w", encoding='utf-8'
+            ) as failed_recs_file:
                 self.get_starting_record_count()
                 try:
                     batch = []
@@ -249,7 +303,7 @@ class BatchPoster(MigrationTaskBase):
                             self.handle_generic_exception(
                                 exception, last_row, batch, self.processed, failed_recs_file
                             )
-                    logging.info("Done posting %s records. ", (self.processed))
+                    logging.info("Done posting %s records. ", self.processed)
                     if self.task_configuration.object_type == "SRS":
                         self.commit_snapshot()
 
@@ -276,7 +330,7 @@ class BatchPoster(MigrationTaskBase):
 
     async def set_version_async(self, batch, query_api, object_type) -> None:
         """
-        Fetches the current version of the records in the batch, if the record exists in FOLIO
+        Fetches the current version of the records in the batch if the record exists in FOLIO
 
         Args:
             batch (list): List of records to fetch versions for
@@ -288,7 +342,7 @@ class BatchPoster(MigrationTaskBase):
         """
         fetch_batch_size = 90
         fetch_tasks = []
-        updates = {}
+        existing_records = {}
         async with httpx.AsyncClient(base_url=self.folio_client.gateway_url) as client:
             for i in range(0, len(batch), fetch_batch_size):
                 batch_slice = batch[i:i + fetch_batch_size]
@@ -297,7 +351,10 @@ class BatchPoster(MigrationTaskBase):
                         client,
                         query_api,
                         params={
-                            "query": f"id==({' OR '.join([record['id'] for record in batch_slice if 'id' in record])})",
+                            "query": (
+                                "id==("
+                                f"{' OR '.join([r['id'] for r in batch_slice if 'id' in r])})"
+                            ),
                             "limit": fetch_batch_size
                         },
                     )
@@ -306,37 +363,91 @@ class BatchPoster(MigrationTaskBase):
             responses = await asyncio.gather(*fetch_tasks)
 
             for response in responses:
-                self.update_record_versions(object_type, updates, response)
+                self.collect_existing_records_for_upsert(object_type, response, existing_records)
         for record in batch:
-            if record["id"] in updates:
-                record.update(updates[record["id"]])
+            if record["id"] in existing_records:
+                self.prepare_record_for_upsert(record, existing_records[record["id"]])
+
+    def handle_source_marc(self, new_record: dict, existing_record: dict):
+        updates = {}
+        updates.update(existing_record)
+        self.handle_upsert_for_administrative_notes(updates)
+        self.handle_upsert_for_statistical_codes(updates)
+        keep_new = {k: v for k, v in new_record.items() if k in ["statisticalCodeIds", "administrativeNotes"]}
+        if "instanceStatusId" in new_record:
+            updates["instanceStatusId"] = new_record["instanceStatusId"]
+        for k, v in keep_new.items():
+            updates[k] = list(dict.fromkeys(updates.get(k, []) + v))
+        new_record.update(updates)
 
     @staticmethod
-    def update_record_versions(object_type, updates, response):
+    def collect_existing_records_for_upsert(object_type: str, response: httpx.Response, existing_records: dict):
         if response.status_code == 200:
             response_json = response.json()
             for record in response_json[object_type]:
-                updates[record["id"]] = {
-                            "_version": record["_version"],
-                        }
-                if "hrid" in record:
-                    updates[record["id"]]["hrid"] = record["hrid"]
-                if "status" in record:
-                    updates[record["id"]]["status"] = record["status"]
-                if "lastCheckIn" in record:
-                    updates[record["id"]]["lastCheckIn"] = record["lastCheckIn"]
+                existing_records[record["id"]] = record
         else:
             logging.error(
-                        "Failed to fetch current records. HTTP %s\t%s",
-                        response.status_code,
-                        response.text,
-                    )
+                "Failed to fetch current records. HTTP %s\t%s",
+                response.status_code,
+                response.text,
+            )
+
+    def handle_upsert_for_statistical_codes(self, updates: dict):
+        if not self.task_configuration.preserve_statistical_codes:
+            updates.pop("statisticalCodeIds", None)
+
+    def handle_upsert_for_administrative_notes(self, updates: dict):
+        if not self.task_configuration.preserve_administrative_notes:
+            updates.pop("administrativeNotes", None)
+
+    def handle_upsert_for_temporary_locations(self, updates: dict):
+        if not self.task_configuration.preserve_temporary_locations:
+            updates.pop("temporaryLocationId", None)
+
+    def handle_upsert_for_temporary_loan_types(self, updates: dict):
+        if not self.task_configuration.preserve_temporary_loan_types:
+            updates.pop("temporaryLoanTypeId", None)
+
+    def keep_existing_fields(self, updates: dict, existing_record: dict):
+        keep_existing_fields = ["hrid", "lastCheckIn"]
+        if self.task_configuration.preserve_item_status:
+            keep_existing_fields.append("status")
+        for key in keep_existing_fields:
+            if key in existing_record:
+                updates[key] = existing_record[key]
+
+    def prepare_record_for_upsert(self, new_record: dict, existing_record: dict):
+        if "source" in existing_record and "MARC" in existing_record["source"]:
+            self.handle_source_marc(new_record, existing_record)
+        else:
+            updates = {
+                "_version": existing_record["_version"],
+            }
+            self.keep_existing_fields(updates, existing_record)
+            keep_new = {k: v for k, v in new_record.items() if k in ["statisticalCodeIds", "administrativeNotes"]}
+            self.handle_upsert_for_statistical_codes(existing_record)
+            self.handle_upsert_for_administrative_notes(existing_record)
+            self.handle_upsert_for_temporary_locations(existing_record)
+            self.handle_upsert_for_temporary_loan_types(existing_record)
+            for k, v in keep_new.items():
+                updates[k] = list(dict.fromkeys(existing_record.get(k, []) + v))
+            for key in [
+                "temporaryLocationId",
+                "temporaryLoanTypeId",
+            ]:
+                if key in existing_record:
+                    updates[key] = existing_record[key]
+            new_record.update(updates)
 
-    async def get_with_retry(self, client: httpx.AsyncClient, url: str, params: dict = {}):
+    async def get_with_retry(self, client: httpx.AsyncClient, url: str, params=None):
+        if params is None:
+            params = {}
         retries = 3
         for attempt in range(retries):
             try:
-                response = await client.get(url, params=params, headers=self.folio_client.okapi_headers)
+                response = await client.get(
+                    url, params=params, headers=self.folio_client.okapi_headers)
                 response.raise_for_status()
                 return response
             except httpx.HTTPError as e:
@@ -477,8 +588,8 @@ class BatchPoster(MigrationTaskBase):
         )
         logging.info(last_row)
         logging.info("=========Stack trace==============")
-        traceback.logging.info_exc() # type: ignore
-        logging.info("=======================", flush=True)
+        traceback.logging.info_exc()  # type: ignore
+        logging.info("=======================")
 
     def post_batch(self, batch, failed_recs_file, num_records, recursion_depth=0):
         if self.query_params.get("upsert", False) and self.api_info.get("query_endpoint", ""):
@@ -514,7 +625,7 @@ class BatchPoster(MigrationTaskBase):
                 )
                 write_failed_batch_to_file(batch, failed_recs_file)
             if json_report.get("failedUsers", []):
-                logging.error("Errormessage: %s", json_report.get("error", []))
+                logging.error("Error message: %s", json_report.get("error", []))
                 for failed_user in json_report.get("failedUsers"):
                     logging.error(
                         "User failed. %s\t%s\t%s",
@@ -581,8 +692,8 @@ class BatchPoster(MigrationTaskBase):
                 resp = json.dumps(response, indent=4)
             except TypeError:
                 resp = response
-            except Exception:
-                logging.exception("something unexpected happened")
+            except Exception as e:
+                logging.exception(f"something unexpected happened, {e}")
                 resp = response
             raise TransformationRecordFailedError(
                 "",
@@ -603,17 +714,29 @@ class BatchPoster(MigrationTaskBase):
             payload = {self.api_info["object_name"]: batch}
         if self.http_client and not self.http_client.is_closed:
             return self.http_client.post(
-                url, json=payload, headers=self.folio_client.okapi_headers, params=self.query_params
+                url,
+                json=payload,
+                headers=self.folio_client.okapi_headers,
+                params=self.query_params
             )
         else:
-            return httpx.post(url, headers=self.okapi_headers, json=payload, params=self.query_params, timeout=None)
+            return httpx.post(
+                url,
+                headers=self.okapi_headers,
+                json=payload,
+                params=self.query_params,
+                timeout=None)
 
     def get_current_record_count_in_folio(self):
         if "query_endpoint" in self.api_info:
             url = f"{self.folio_client.gateway_url}{self.api_info['query_endpoint']}"
             query_params = {"query": "cql.allRecords=1", "limit": 0}
             if self.http_client and not self.http_client.is_closed:
-                res = self.http_client.get(url, headers=self.folio_client.okapi_headers, params=query_params)
+                res = self.http_client.get(
+                    url,
+                    headers=self.folio_client.okapi_headers,
+                    params=query_params
+                )
             else:
                 res = httpx.get(url, headers=self.okapi_headers, params=query_params, timeout=None)
             try:
@@ -623,11 +746,15 @@ class BatchPoster(MigrationTaskBase):
                 logging.error("Failed to get current record count. HTTP %s", res.status_code)
                 return 0
             except KeyError:
-                logging.error(f"Failed to get current record count. No 'totalRecords' in response: {res.json()}")
+                logging.error(
+                    "Failed to get current record count. "
+                    f"No 'totalRecords' in response: {res.json()}"
+                )
                 return 0
         else:
             raise ValueError(
-                "No 'query_endpoint' available for %s. Cannot get current record count.", self.task_configuration.object_type
+                "No 'query_endpoint' available for %s. Cannot get current record count.",
+                self.task_configuration.object_type
             )
 
     def get_starting_record_count(self):
@@ -635,14 +762,20 @@ class BatchPoster(MigrationTaskBase):
             logging.info("Getting starting record count in FOLIO")
             self.starting_record_count_in_folio = self.get_current_record_count_in_folio()
         else:
-            logging.info("No query_endpoint available for %s. Cannot get starting record count.", self.task_configuration.object_type)
+            logging.info(
+                "No query_endpoint available for %s. Cannot get starting record count.",
+                self.task_configuration.object_type
+            )
 
     def get_finished_record_count(self):
         if "query_endpoint" in self.api_info:
             logging.info("Getting finished record count in FOLIO")
             self.finished_record_count_in_folio = self.get_current_record_count_in_folio()
         else:
-            logging.info("No query_endpoint available for %s. Cannot get ending record count.", self.task_configuration.object_type)
+            logging.info(
+                "No query_endpoint available for %s. Cannot get ending record count.",
+                self.task_configuration.object_type
+            )
 
     def wrap_up(self):
         logging.info("Done. Wrapping up")
@@ -663,7 +796,9 @@ class BatchPoster(MigrationTaskBase):
             logging.info("Done posting %s records. %s failed", self.num_posted, self.num_failures)
         if self.starting_record_count_in_folio:
             self.get_finished_record_count()
-            total_on_server = self.finished_record_count_in_folio - self.starting_record_count_in_folio
+            total_on_server = (
+                    self.finished_record_count_in_folio - self.starting_record_count_in_folio
+            )
             discrepancy = self.processed - self.num_failures - total_on_server
             if discrepancy != 0:
                 logging.error(
@@ -712,7 +847,10 @@ class BatchPoster(MigrationTaskBase):
                 temp_report = copy.deepcopy(self.migration_report)
                 temp_start = self.start_datetime
                 self.task_configuration.rerun_failed_records = False
-                self.__init__(self.task_configuration, self.library_configuration, self.folio_client)
+                self.__init__(
+                    self.task_configuration,
+                    self.library_configuration,
+                    self.folio_client)
                 self.performing_rerun = True
                 self.migration_report = temp_report
                 self.start_datetime = temp_start
@@ -747,9 +885,11 @@ class BatchPoster(MigrationTaskBase):
                 res = httpx.post(url, headers=self.okapi_headers, json=snapshot, timeout=None)
             res.raise_for_status()
             logging.info("Posted Snapshot to FOLIO: %s", json.dumps(snapshot, indent=4))
-            get_url = f"{self.folio_client.gateway_url}/source-storage/snapshots/{self.snapshot_id}"
-            getted = False
-            while not getted:
+            get_url = (
+                f"{self.folio_client.gateway_url}/source-storage/snapshots/{self.snapshot_id}"
+            )
+            got = False
+            while not got:
                 logging.info("Sleeping while waiting for the snapshot to get created")
                 time.sleep(5)
                 if self.http_client and not self.http_client.is_closed:
@@ -757,11 +897,14 @@ class BatchPoster(MigrationTaskBase):
                 else:
                     res = httpx.get(get_url, headers=self.okapi_headers, timeout=None)
                 if res.status_code == 200:
-                    getted = True
+                    got = True
                 else:
                     logging.info(res.status_code)
-        except Exception:
-            logging.exception("Could not post the snapshot")
+        except httpx.HTTPStatusError as exc:
+            logging.exception("HTTP error occurred while posting the snapshot: %s", exc)
+            sys.exit(1)
+        except Exception as exc:
+            logging.exception("Could not post the snapshot: %s", exc)
             sys.exit(1)
 
     def commit_snapshot(self):
@@ -776,11 +919,15 @@ class BatchPoster(MigrationTaskBase):
                 res = httpx.put(url, headers=self.okapi_headers, json=snapshot, timeout=None)
             res.raise_for_status()
             logging.info("Posted Committed snapshot to FOLIO: %s", json.dumps(snapshot, indent=4))
-        except Exception:
+        except httpx.HTTPStatusError as exc:
+            logging.exception("HTTP error occurred while posting the snapshot: %s", exc)
+            sys.exit(1)
+        except Exception as exc:
             logging.exception(
                 "Could not commit snapshot with id %s. Post this to /source-storage/snapshots/%s:",
                 self.snapshot_id,
                 self.snapshot_id,
+                exc,
             )
             logging.info("%s", json.dumps(snapshot, indent=4))
             sys.exit(1)
@@ -891,8 +1038,11 @@ def get_api_info(object_type: str, use_safe: bool = True):
     try:
         return choices[object_type]
     except KeyError:
-        key_string = ",".join(choices.keys())
-        logging.error(f"Wrong type. Only one of {key_string} are allowed")
+        key_string = ", ".join(choices.keys())
+        logging.error(
+            f"Wrong type. Only one of {key_string} are allowed, "
+            f"received {object_type=} instead"
+        )
         logging.error("Halting")
         sys.exit(1)
 
@@ -908,7 +1058,7 @@ def chunks(records, number_of_chunks):
         _type_: _description_
     """
     for i in range(0, len(records), number_of_chunks):
-        yield records[i : i + number_of_chunks]
+        yield records[i: i + number_of_chunks]
 
 
 def get_human_readable(size, precision=2):

folio_migration_tools/migration_tasks/holdings_marc_transformer.py

@@ -1,5 +1,3 @@
-'''Main "script."'''
-
 import csv
 import json
 import logging
@@ -19,7 +17,10 @@ from folio_migration_tools.library_configuration import (
 from folio_migration_tools.marc_rules_transformation.rules_mapper_holdings import (
     RulesMapperHoldings,
 )
-from folio_migration_tools.migration_tasks.migration_task_base import MarcTaskConfigurationBase, MigrationTaskBase
+from folio_migration_tools.migration_tasks.migration_task_base import (
+    MarcTaskConfigurationBase,
+    MigrationTaskBase
+)
 
 
 class HoldingsMarcTransformer(MigrationTaskBase):
@@ -37,14 +38,18 @@ class HoldingsMarcTransformer(MigrationTaskBase):
             str,
             Field(
                 title="Migration task type",
-                description=("The type of migration task you want to perform"),
+                description=(
+                    "The type of migration task you want to perform"
+                ),
             ),
         ]
         files: Annotated[
             List[FileDefinition],
             Field(
                 title="Source files",
-                description=("List of MARC21 files with holdings records"),
+                description=(
+                    "List of MARC21 files with holdings records"
+                ),
             ),
         ]
         hrid_handling: Annotated[
@@ -125,8 +130,8 @@ class HoldingsMarcTransformer(MigrationTaskBase):
         default_call_number_type_name: Annotated[
             str,
             Field(
-                title="Default callnumber type name",
-                description="The name of the callnumber type that will be used as fallback",
+                title="Default call_number type name",
+                description="The name of the call_number type that will be used as fallback",
             ),
         ]
         fallback_holdings_type_id: Annotated[
@@ -140,7 +145,10 @@ class HoldingsMarcTransformer(MigrationTaskBase):
             str,
             Field(
                 title="Supplemental MFHD mapping rules file",
-                description="The name of the file in the mapping_files directory containing supplemental MFHD mapping rules",
+                description=(
+                    "The name of the file in the mapping_files directory "
+                    "containing supplemental MFHD mapping rules"
+                ),
             ),
         ] = ""
         include_mrk_statements: Annotated[
@@ -148,8 +156,10 @@ class HoldingsMarcTransformer(MigrationTaskBase):
             Field(
                 title="Include MARC statements (MRK-format) as staff-only Holdings notes",
                 description=(
-                    "If set to true, the MARC statements will be included in the output as MARC Maker format fields. "
-                    "If set to false (default), the MARC statements will not be included in the output."
+                    "If set to true, the MARC statements "
+                    "will be included in the output as MARC Maker format fields. "
+                    "If set to false (default), the MARC statements "
+                    "will not be included in the output."
                 ),
             ),
         ] = False
@@ -188,7 +198,8 @@ class HoldingsMarcTransformer(MigrationTaskBase):
                 title="Include MARC Record (as MARC21 decoded string) as note",
                 description=(
                     "If set to true, the MARC record will be included in the output as a "
-                    "decoded binary MARC21 record. If set to false (default), the MARC record will not be "
+                    "decoded binary MARC21 record. If set to false (default), "
+                    "the MARC record will not be "
                     "included in the output."
                 ),
             ),

folio_migration_tools/migration_tasks/items_transformer.py

@@ -127,7 +127,8 @@ class ItemsTransformer(MigrationTaskBase):
                 title="Statistical code map file name",
                 description=(
                     "Path to the file containing the mapping of statistical codes. "
-                    "The file should be in TSV format with legacy_stat_code and folio_code columns."
+                    "The file should be in TSV format with legacy_stat_code "
+                    "and folio_code columns."
                 ),
             ),
         ] = ""
@@ -217,7 +218,10 @@ class ItemsTransformer(MigrationTaskBase):
         self.folio_keys = MappingFileMapperBase.get_mapped_folio_properties_from_map(
             self.items_map
         )
-        if any(k for k in self.folio_keys if k.startswith("statisticalCodeIds")):
+        if (
+            any(k for k in self.folio_keys if k.startswith("statisticalCodeIds"))
+            or any(getattr(k, "statistical_code", "") for k in self.task_configuration.files)
+        ):
             statcode_mapping = self.load_ref_data_mapping_file(
                 "statisticalCodeIds",
                 self.folder_structure.mapping_files_folder
@@ -355,7 +359,7 @@ class ItemsTransformer(MigrationTaskBase):
                     )
 
                     self.mapper.perform_additional_mappings(legacy_id, folio_rec, file_def)
-                    self.handle_circiulation_notes(folio_rec, self.folio_client.current_user)
+                    self.handle_circulation_notes(folio_rec, self.folio_client.current_user)
                     self.handle_notes(folio_rec)
                     if folio_rec["holdingsRecordId"] in self.boundwith_relationship_map:
                         for idx_, instance_id in enumerate(
@@ -373,7 +377,7 @@ class ItemsTransformer(MigrationTaskBase):
                     if idx == 0:
                         logging.info("First FOLIO record:")
                         logging.info(json.dumps(folio_rec, indent=4))
-                    # TODO: turn this into a asynchrounous task
+                    # TODO: turn this into a asynchronous task
                     Helper.write_to_file(results_file, folio_rec)
                     self.mapper.migration_report.add_general_statistics(
                         i18n.t("Number of records written to disk")
@@ -388,8 +392,8 @@ class ItemsTransformer(MigrationTaskBase):
                     logging.fatal(attribute_error)
                     logging.info("Quitting...")
                     sys.exit(1)
-                except Exception as excepion:
-                    self.mapper.handle_generic_exception(idx, excepion)
+                except Exception as exception:
+                    self.mapper.handle_generic_exception(idx, exception)
                 self.mapper.migration_report.add(
                     "GeneralStatistics",
                     i18n.t("Number of Legacy items in %{container}", container=file_def),
@@ -425,14 +429,14 @@ class ItemsTransformer(MigrationTaskBase):
                 del folio_object["notes"]
 
     @staticmethod
-    def handle_circiulation_notes(folio_rec, current_user_uuid):
+    def handle_circulation_notes(folio_rec, current_user_uuid):
         if not folio_rec.get("circulationNotes", []):
             return
         filtered_notes = []
         for circ_note in folio_rec.get("circulationNotes", []):
             if circ_note.get("noteType", "") not in ["Check in", "Check out"]:
                 raise TransformationProcessError(
-                    "", "Circulation Note types are not mapped correclty"
+                    "", "Circulation Note types are not mapped correctly"
                 )
             if circ_note.get("note", ""):
                 circ_note["id"] = str(uuid.uuid4())
@@ -455,11 +459,22 @@ class ItemsTransformer(MigrationTaskBase):
                         json.loads(x) for x in boundwith_relationship_file
                     )
             logging.info(
-                    "Rows in Bound with relationship map: %s", len(self.boundwith_relationship_map)
+                "Rows in Bound with relationship map: %s",
+                len(self.boundwith_relationship_map)
                 )
         except FileNotFoundError:
             raise TransformationProcessError(
-                    "", "Boundwith relationship file specified, but relationships file from holdings transformation not found. ", self.folder_structure.boundwith_relationships_map_path
+                "",
+                "Boundwith relationship file specified, but relationships file "
+                "from holdings transformation not found.",
+                self.folder_structure.boundwith_relationships_map_path
+            )
+        except ValueError:
+            raise TransformationProcessError(
+                "",
+                "Boundwith relationship file specified, but relationships file "
+                "from holdings transformation is not a valid line JSON.",
+                self.folder_structure.boundwith_relationships_map_path,
             )
 
     def wrap_up(self):